[issue39189] Use io.DEFAULT_BUFFER_SIZE for filecmp BUFSIZE variable

2020-01-02 Thread Bahram Aghaei
New submission from Bahram Aghaei : Hello there, I was reading the `filecmp` module and I noticed that it defined the BUFSIZE manually, I think it's better to stick to the io.DEFAULT_BUFFER_SIZE variable for both consistency and easy to maintain in the future. C

[issue39189] Use io.DEFAULT_BUFFER_SIZE for filecmp BUFSIZE variable

2020-06-01 Thread Bahram Aghaei
Bahram Aghaei added the comment: Well, I think because the io module provides Python’s main facilities for dealing with various types of I/O, so using io.DEFAULT_BUFFER_SIZE is a kind of standard buffer size. I don't see any scientific reason for choosing the 8 * 1024 inside the fi