[issue33274] minidom removeAttributeNode returns None

New submission from Ari Krupnik : W3C DOM Level 1[1] requires removeAttributeNode() to return the removed node: removeAttributeNode: Removes the specified attribute. Return Value: The Attr node that was removed. Minidom implementation returns None. [1]https://www.w3.org/TR/1998/REC-DOM-Level

[issue33274] minidom removeAttributeNode returns None

Change by Ari Krupnik : -- type: -> behavior ___ Python tracker <https://bugs.python.org/issue33274> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue33274] minidom removeAttributeNode returns None

Ari Krupnik added the comment: I guess the main question if whether minidom wants to adhere to the standard or be pythonic, and it's not up to me to decide, although personally I like standards. The common use case for DOM functions returning the relevant nodes is for the caller to

[issue33274] minidom removeAttributeNode returns None

Change by Ari Krupnik : -- keywords: +patch pull_requests: +7086 stage: test needed -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33274] minidom removeAttributeNode returns None

Change by Ari Krupnik : -- pull_requests: +7087 ___ Python tracker <https://bugs.python.org/issue33274> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33274] minidom removeAttributeNode returns None

Ari Krupnik added the comment: I added a test case and a News entry per serhiy.storchaka's request. https://github.com/python/cpython/pull/7465 I agree with fdrake's concerns about DOM's usefulness. DOM is not very Pythonic. I note that as long as Python has a DOM implementat

[issue33274] minidom removeAttributeNode returns None

Change by Ari Krupnik : -- pull_requests: -7086 ___ Python tracker <https://bugs.python.org/issue33274> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33274] minidom removeAttributeNode returns None

Change by Ari Krupnik : -- pull_requests: +7088 ___ Python tracker <https://bugs.python.org/issue33274> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33274] minidom removeAttributeNode returns None

Ari Krupnik added the comment: My bad. This issue looks like a simple omission to me--albeit one that's been in the code a long time. My patch simply brings the code into compliance with what the documentation (including in 2.7) already says it

[issue33274] minidom removeAttributeNode returns None

Ari Krupnik added the comment: I feel a little bit like I wandered into a card game whose rules I didn't understand. I'm just a lay, mortal user. I've been writing Python for 15 years, first time I saw an opportunity to contribute back. I saw what looked to me like a bug tha

[issue33274] minidom removeAttributeNode returns None

Ari Krupnik added the comment: In retrospect, I wish I had submitted this as a documentation change, simply acknowledging this function's behavior. "In most computer projects there comes a day when it is discovered that the machine and the manual don't agree. When the confro