Change by Andrew Svetlov :
--
pull_requests: +15179
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Andrew Svetlov added the comment:
The issue is related to Python 3.8 and master only. 3.6-3.7 are not affected
--
versions: +Python 3.9 -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue34
Andrew Svetlov added the comment:
Kyle, thanks for the fix.
I have basically the same change in my PR but with test and news note.
--
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15180
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
pull_requests: -15179
___
Python tracker
<https://bugs.python.org/issue34769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Andrew Svetlov :
--
pull_requests: +15183
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
pull_requests: +15183, 15184
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
pull_requests: +15183, 15184, 15185
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Andrew Svetlov added the comment:
New changeset 1c0600998681295735a18690fae184b0c9a4ca51 by Andrew Svetlov in
branch 'master':
bpo-34679: Restore instantiation Windows IOCP event loop from non-main thread
(#15492)
https://github.com/python/cpyt
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
The solution produces subtle and error-prone code. It can live in third party
library but not good enough for stdlib I think.
--
___
Python tracker
<https://bugs.python.org/issue33
Andrew Svetlov added the comment:
In asyncio code please use non-blocking code and await a future returned by
run_until_complete.
The following code doesn't leak:
import asyncio
import concurrent
import threading
def prepare_a_giant_list():
m = []
for i in range(1000
Andrew Svetlov added the comment:
This is a new feature (and not a blocker).
Shift to 3.9.
Nathaniel, the PR is outdated.
Have you an intention to land it or the issue can be closed by the lack of
interest?
--
nosy: +asvetlov
versions: +Python 3.9 -Python 3.8
Andrew Svetlov added the comment:
Let's close the issue as "won't fix".
Third-party loop implementation *can* be reentrant but we don't want to
encourage people to use this pattern in stdlib.
--
resolution: -> wont fix
stage: patch review ->
Change by Andrew Svetlov :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Andrew Svetlov :
As discussed in discussion
https://github.com/python/cpython/pull/14488#discussion_r322176319
Hide feed_eof(), feed_data(), set_exception() and set_transport() methods.
--
components: asyncio
messages: 351433
nosy: asvetlov, yselivanov
priority
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15415
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15762
___
Python tracker
<https://bugs.python.org/issu
Andrew Svetlov added the comment:
Done.
The only API from transport that users really need is get_extra_info() which is
exposed as a stream method already.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Thanks for the report xtreak, I'll make a fix.
--
___
Python tracker
<https://bugs.python.org/issue36373>
___
___
Pytho
Andrew Svetlov added the comment:
Better to avoid _asyncio_internal if not strictly necessary.
Currently, _asyncio_internal is used for protection of asyncio class direct
instantiation.
E.g. stream = asyncio.Stream() is forbidden, people should use factories like
stream = await
Change by Andrew Svetlov :
--
pull_requests: +15530
pull_request: https://github.com/python/cpython/pull/15889
___
Python tracker
<https://bugs.python.org/issue36
Andrew Svetlov added the comment:
Answered in https://github.com/python/cpython/pull/15889
--
___
Python tracker
<https://bugs.python.org/issue36373>
___
___
Andrew Svetlov added the comment:
Thanks!
The test case re-creates a loop per test for the sake of test isolation
(scheduled activities from test_a() don't interleave with test_b()).
Unfortunately, on the class level level (setUpClass()/tearDownClass()) the loop
doesn't exits.
Change by Andrew Svetlov :
--
pull_requests: +15542
pull_request: https://github.com/python/cpython/pull/15901
___
Python tracker
<https://bugs.python.org/issue36
Andrew Svetlov added the comment:
New changeset 4601f7a49fe8ed00c4b6b70b0eda2b3922568e9b by Andrew Svetlov in
branch '3.8':
[3.8] bpo-36373: Fix deprecation warnings (GH-15889) (GH-15901)
https://github.com/python/cpython/commit/4601f7a49fe8ed00c4b6b70b0eda2b
Andrew Svetlov added the comment:
New changeset 0ba5dbd992d68d7df23396148ad55624200a1dbc by Andrew Svetlov (Miss
Islington (bot)) in branch '3.8':
bpo-32972: Document IsolatedAsyncioTestCase of unittest module (GH-15878)
(GH-15918)
https://github.com/python/cpyt
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Andrew Svetlov :
1. Factories are recommended way for a task and a future creation.
2. Consider this task as asyncio tests tidy up.
--
components: asyncio
keywords: 3.3regression
messages: 351837
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15568
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15928
___
Python tracker
<https://bugs.python.org/issu
Change by Andrew Svetlov :
--
keywords: -3.3regression, patch
___
Python tracker
<https://bugs.python.org/issue38107>
___
___
Python-bugs-list mailing list
Unsub
Change by Andrew Svetlov :
--
keywords: +patch
___
Python tracker
<https://bugs.python.org/issue38107>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
New changeset 9aee90018a5213e3529768e0b873955d23f5e50b by Andrew Svetlov in
branch 'master':
bpo-38107: Replace direct future and task contructor calls with factories in
asyncio tests (GH-15928)
https://github.com/python/cpyt
Andrew Svetlov added the comment:
Done, thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Yes, please do
--
___
Python tracker
<https://bugs.python.org/issue34634>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
Let's keep it open if you don't give up the issue entirely.
--
___
Python tracker
<https://bugs.python.org/issue30491>
___
__
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue27589>
___
___
Andrew Svetlov added the comment:
Agree
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Allow multiple separators in Stream.readuntil
___
Python tracker
<https://bugs.python
Change by Andrew Svetlov :
--
pull_requests: +15655
pull_request: https://github.com/python/cpython/pull/16033
___
Python tracker
<https://bugs.python.org/issue36
Andrew Svetlov added the comment:
New changeset a488879cbaf4b8b52699cadccf73bb4c271bcb29 by Andrew Svetlov in
branch 'master':
bpo-36373: Deprecate explicit loop in task and subprocess API (GH-16033)
https://github.com/python/cpython/commit/a488879cbaf4b8b52699cadccf73bb
Change by Andrew Svetlov :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
please do
--
___
Python tracker
<https://bugs.python.org/issue37141>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15684
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16061
___
Python tracker
<https://bugs.python.org/issu
Change by Andrew Svetlov :
--
pull_requests: +15691
pull_request: https://github.com/python/cpython/pull/16070
___
Python tracker
<https://bugs.python.org/issue38
Andrew Svetlov added the comment:
Yes, please close as a duplicate.
--
___
Python tracker
<https://bugs.python.org/issue37455>
___
___
Python-bugs-list mailin
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Andrew Svetlov :
Transports are abstract interfaces.
Adding slots allows using slots in transport implementations as well.
If the implementation doesn't use slots -- everything keeps working.
Slots can help with saving a memory footprint a little.
--
compo
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15699
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16077
___
Python tracker
<https://bugs.python.org/issu
Andrew Svetlov added the comment:
Note, slots for protocols are provided by 3.8 already.
--
___
Python tracker
<https://bugs.python.org/issue38148>
___
___
Pytho
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
You spawn too many subprocesses that finish virtually at the same time.
It leads to wakeup_fd overrun.
Python 3.6 is in security mode, sorry (and the fix is impossible).
Python 3.7 has warn_on_full_buffer=False flag for
https://docs.python.org/3/library
Change by Andrew Svetlov :
--
versions: +Python 3.9 -Python 2.7
___
Python tracker
<https://bugs.python.org/issue12144>
___
___
Python-bugs-list mailin
Andrew Svetlov added the comment:
The issue can be closed, loop.add_reader() / loop.remove_reader() calls
correctly handle closed loop now
--
nosy: +asvetlov
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Pytho
Andrew Svetlov added the comment:
New changeset 9eb35ab0d71a6bd680e84fa0f828cb634e72b681 by Andrew Svetlov in
branch 'master':
bpo-38148: Add slots to asyncio transports (GH-16077)
https://github.com/python/cpython/commit/9eb35ab0d71a6bd680e84fa0f828cb
Change by Andrew Svetlov :
--
pull_requests: +15714
pull_request: https://github.com/python/cpython/pull/16093
___
Python tracker
<https://bugs.python.org/issue38
Andrew Svetlov added the comment:
New changeset e7b7edf5ebaed14dc68c841a8a98260f1330ef9a by Andrew Svetlov
(Xtreak) in branch '3.7':
[3.7] bpo-12144: Handle cookies with expires attribute in
CookieJar.make_cookies (GH-13921) (GH-16092)
https://github.com/python/cpyt
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Andrew Svetlov :
--
keywords: +easy, newcomer friendly
___
Python tracker
<https://bugs.python.org/issue37404>
___
___
Python-bugs-list mailin
Andrew Svetlov added the comment:
New changeset 6638c9226066205a646e18da95b33e619d784b0b by Andrew Svetlov in
branch '3.8':
[3.8] bpo-38148: Add slots to asyncio transports (GH-16077) (GH-16093)
https://github.com/python/cpython/commit/6638c9226066205a646e18da95b33e
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Vlad, the PR is very welcome!
--
___
Python tracker
<https://bugs.python.org/issue34344>
___
___
Python-bugs-list mailin
Andrew Svetlov added the comment:
I believe after implementing AsyncMock we can close the issue
--
nosy: +asvetlov
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
I believe with AsyncMock implemented we can close the issue
--
___
Python tracker
<https://bugs.python.org/issue26140>
___
___
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15758
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16148
___
Python tracker
<https://bugs.python.org/issu
Andrew Svetlov added the comment:
I have a PR for the fix.
Yuri preliminary agrees with the patch but he requested more time for careful
review.
I've added 'release blocker' priority to don't miss this bugfix for the next
release.
--
nosy: +lukasz.langa, ned.de
Andrew Svetlov added the comment:
Thanks Hrvoje!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Thanks. The correct fix is 'do nothing if stream._transport is None'.
We have only two weeks before 3.8rc, thus I'll prepare a fix myself for the
sake of fast merging.
--
assignee: -> asvetlov
Andrew Svetlov added the comment:
This fix cannot land on 3.6, the version is in security-fix only mode.
--
versions: -Python 3.6
___
Python tracker
<https://bugs.python.org/issue38
Andrew Svetlov added the comment:
Raymond, sorry if I was so quick in applying.
The patch is very trivial and obvious.
I am pretty sure that Yuri and Victor approve it.
The PR doesn't fix a mistake, the code is still valid.
But we all changed our mind what is the loop role, should
Andrew Svetlov added the comment:
Thanks, Ned.
I love to include this in 3.7.5.
I've pinged Yuri offline with ask for review
--
___
Python tracker
<https://bugs.python.org/is
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Thnks, Kyle!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
New changeset 9fdc64cf1266b6d5bf0503847b5c38e5edc53a14 by Andrew Svetlov (Kyle
Stanley) in branch 'master':
bpo-34037: Fix test_asyncio failure and add loop.shutdown_default_executor()
(GH-15735)
https://github.com/python/cpyt
Andrew Svetlov added the comment:
I think we need better name than just `_is_coroutine`.
All async function properties as dunder named, the new *official* name should
follow this convention as well
--
___
Python tracker
<https://bugs.python.
Andrew Svetlov added the comment:
I think `func.__awaitable__ = True` can serve all possible situations.
We need it for async mocks (now the library use flawless `_is_coroutine`
approach.
`__awaitable__` can also cover cases where a regular function returns awaitable
object or there is a
Andrew Svetlov added the comment:
There is an alternative proposal: let's deprecate and eventually remove streams
API entirely (for sockets, pipes, and subprocesses).
By this, we will never have a chance to conflict with trio.
Another option is removing asyncio at all (again to
Change by Andrew Svetlov :
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue38242>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
I would say that we can reimplement the Stream class on top of new composable
streams in the future.
I'd love to do it right now but these streams don't exist yet.
I totally support the idea of new streams design, it looks very attra
Change by Andrew Svetlov :
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue38242>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
Awesome!
--
___
Python tracker
<https://bugs.python.org/issue38242>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
I think if we want to support SOCK_SEQPACKET by asyncio we should do it
explicitly.
In the other case, we can open a can of worms: we cannot guarantee that all
existing protocols are supported by asyncio seamlessly.
Anyway, this is a new feature request
Andrew Svetlov added the comment:
We can implement these using the following procedure:
1. Use only one socket type per pull request
2. Add support for, e.g. SOCK_SEQPACKET to asyncio code
3. Add test(s) that checks that SOCK_SEQPACKET works fine
(./Lib/test/test_asyncio folder, perhaps
Andrew Svetlov added the comment:
If you have no time for contribution -- that's fine, CPython is the Open Source
project driven by volunteers.
The only caveat is that the issue may wait for years before we find a champion
to pick it up.
For example, this particular problem is on the
Andrew Svetlov added the comment:
I'd like to see how thread pools integrate with (not existing yet bug planned
for 3.9) task groups before pushing forward the proposed approach.
--
___
Python tracker
<https://bugs.python.org/is
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +16056
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16472
___
Python tracker
<https://bugs.python.org/issu
New submission from Andrew Svetlov :
Sockets support it, there is no reason for missing the method in unix pipe.
--
components: asyncio
messages: 353494
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: Implement unix read_pipe.is_reading() method
Andrew Svetlov added the comment:
The issue is easy, basically we need the following code plus a test
def is_reading(self):
return not self._paused and not self._closing
--
keywords: +newcomer friendly
type: -> enhancement
___
Pyt
Andrew Svetlov added the comment:
New changeset 58498bc7178608b1ab031994ca09c43889ce3e76 by Andrew Svetlov in
branch 'master':
bpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe
(GH-16472)
https://github.com/python/cpyt
Andrew Svetlov added the comment:
Nothing special.
There is UnixReadPipeTransportTests test cases inside
Lib/test/test_asyncio/test_unix_events.py
This class has a bunch of tests for pause_reading() / resume_reading().
Test(s) for is_reading() can be built in the same way
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
You MUST await a future returned from `loop.run_in_executor()` to avoid the
leak.
Yuri, what should we do with the issue? I see the second similar report in the
last half of the year.
Sure, we can add weakrefs somewhere in futures._chain_future() but I
Andrew Svetlov added the comment:
Victor answered the first :)
--
___
Python tracker
<https://bugs.python.org/issue38430>
___
___
Python-bugs-list mailin
Andrew Svetlov added the comment:
> Can a Task be used instead of a Future in run_in_executor()?
I don't think that the task is required here. The problem is that
run_in_executor is a function that returns asyncio future; that is in turn a
wrapper around concurrent future object
Andrew Svetlov added the comment:
The change is slightly not backward compatible but
1. It's pretty visible. In the worst-case instead of the memory leak people see
a RuntimeWarning
2. We did it already for a part of API, e.g. loop.sock_read() and f
Andrew Svetlov added the comment:
> code that incorrectly imported directly from the submodules will break
That's true. Please note: incorrect code will break. The correct code keeps
working.
I'm personally not sure if we need to reflect *private* API change in Release
No
Change by Andrew Svetlov :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue38563>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
Pull Request is welcome!
--
___
Python tracker
<https://bugs.python.org/issue38563>
___
___
Python-bugs-list mailing list
Unsub
401 - 500 of 2519 matches
Mail list logo
