[issue20949] Missing platform security integrations

2021-12-13 Thread Ammar Askar
Ammar Askar added the comment: Hi Jeffrey, your second solution where you omit `-pie` is almost there. Instead of modifying the Makefile you can pass `-pie` in `LINKFORSHARED`: export CFLAGS="-fPIC -fstack-protector-all -D_FORTIFY_SOURCE=2" export CXXFLAGS="-fPIC -fstac

[issue46762] assertion failure in f-string parsing Parser/string_parser.c

2022-02-15 Thread Ammar Askar
New submission from Ammar Askar : Similar to https://bugs.python.org/issue46503 found by the ast.literal_eval fuzzer ``` >>> f'{<' python: Parser/string_parser.c:346: fstring_compile_expr: Assertion `*expr_end == '}' || *expr_end == '!' || *expr_

[issue37862] Search doesn't find built-in functions

2019-08-21 Thread Ammar Askar
Ammar Askar added the comment: See also https://bugs.python.org/issue34398 There is some related work done by Julien there as well: https://github.com/JulienPalard/pydocsearch -- nosy: +ammar2 ___ Python tracker <https://bugs.python.

[issue37980] regression when passing numpy bools to sorted(..., reverse=r)

2019-08-29 Thread Ammar Askar
Ammar Askar added the comment: Thanks for the insight Terry. I think the functions that accept ints as bools are kind of a red herring: Booleans were only formally introduced in Python 2.3 [1], thus any functions that existed before that accepted ints and continued to accept ints for

[issue38057] Docs: source code don't can be translate

2019-09-08 Thread Ammar Askar
Ammar Askar added the comment: What version of Sphinx are you using? As far as I know, Sphinx supports internationalization for autodoc, so this should be possible. -- nosy: +ammar2 ___ Python tracker <https://bugs.python.org/issue38

[issue38125] Can' build document in Sphinx v2.2.0

2019-09-11 Thread Ammar Askar
Ammar Askar added the comment: When did you try this? For reference, Doc/conf.py on master currently has `master_doc = 'contents'` and I performed a successful build with Sphinx 2.2.0 a few days ago. -- nosy: +ammar2 ___ Python track

[issue38152] AST change introduced tons of reference leaks

2019-09-14 Thread Ammar Askar
Change by Ammar Askar : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38188] Incorrect Argument Order for Calls to _winapi.DuplicateHandle() in multiprocessing.reduction.DupHandle

2019-09-16 Thread Ammar Askar
Change by Ammar Askar : -- nosy: +eryksun ___ Python tracker <https://bugs.python.org/issue38188> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38189] pip does not run in virtual environment in 3.8

2019-09-16 Thread Ammar Askar
Ammar Askar added the comment: As the error says: > Can't connect to HTTPS URL because the SSL module is not available. Since you built it from source, you should check your build logs, the _ssl module likely failed to build. You're most probably missing the openss

[issue38204] Cannot compile on RPi with optimizations

2019-09-17 Thread Ammar Askar
Ammar Askar added the comment: Could you provide the output of gcc --version and ld --version -- nosy: +ammar2 ___ Python tracker <https://bugs.python.org/issue38

[issue38206] Clarify that tp_dealloc must decref for heap allocated type

2019-09-17 Thread Ammar Askar
New submission from Ammar Askar : When dealing with a heap allocated type (https://docs.python.org/3/c-api/typeobj.html#Py_TPFLAGS_HEAPTYPE / PyType_FromSpec), if the type has a custom tp_dealloc function then it MUST decrement the references to the type object itself due to this code block

[issue38206] Clarify that tp_dealloc must decref for heap allocated type

2019-09-17 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +15844 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16248 ___ Python tracker <https://bugs.python.org/issu

[issue38204] Cannot compile on RPi with optimizations

2019-09-18 Thread Ammar Askar
Ammar Askar added the comment: Hmm, I think this might be the following gcc/binutils bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84847 https://sourceware.org/bugzilla/show_bug.cgi?id=20882 This might be a bit of a pain but could you try updating binutils and see if the problem

[issue38205] Python no longer compiles without small integer singletons

2019-09-18 Thread Ammar Askar
Ammar Askar added the comment: For the control path warning, that can be fixed by just hinting to the compiler that the function doesn't return like so: # ifdef __GNUC__ __attribute__ ((noreturn)) # elif defined(_MSC_VER) __declspec(noreturn) # endif static inline

[issue38216] Fix for issue30458 prevents crafting invalid requests

2019-09-19 Thread Ammar Askar
Ammar Askar added the comment: > What bothers me here is that we apparently changed de facto behavior between > maintenance releases, in the middle of 3.7's lifecycle, without warning, no > doubt because we didn't realize it would break third-party packages. Arguably, I

[issue38233] datetime.datetime.fromtimestamp have different behaviour on windows and mac

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: Thanks for the report Alexandre, this has to do with issues with negative numbers in Window's time APIs. There's already a bug open for this, so I've marked it as a duplicate. -- nosy: +ammar2 resolution: -> duplicate stage: ->

[issue38231] Documentation search results focus on tutorials and not language specifications

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: This is a great point Matt, the documentation search is a bit lacking and we're kind of using https://bugs.python.org/issue34398 and https://github.com/python/cpython/pull/8773 to track it. The current idea that Julien, the docs expert, had is to add some

[issue34398] Docs search should prominently show definitions and glossary items

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: Changing the title a little to represent that this is now a general improvement of the docs search. Julien is working to upstream a solution into Sphinx that will allow any items to be featured prominently on search. -- title: Docs search does not

[issue38231] Documentation search results focus on tutorials and not language specifications

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: > Somewhat related, I am responding to this through the bugs.python.org > interface. If I reply directly to the email the tracker sent me, will my > reply be properly routed to this thread? Yes, it will :) The bug tracker allows replies

[issue38237] Expose meaningful keyword arguments for pow()

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: Looks like a solid proposal, I especially like the clarity for the 3-argument call. Often beginners ask about why there's a third argument in pow especially when teaching RSA and number-theoretic stuff. Do you mind if I take this on Raymond? --

[issue38237] Expose meaningful keyword arguments for pow()

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: Actually quick question, should a similar change be made for `math.pow` for consistency's sake? -- ___ Python tracker <https://bugs.python.org/is

[issue38237] Expose meaningful keyword arguments for pow()

2019-09-20 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +15887 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16302 ___ Python tracker <https://bugs.python.org/issu

[issue38237] Expose meaningful keyword arguments for pow()

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: I've made a PR, feel free to close it if you'd rather implement this yourself or this proposal won't be accepted :) -- ___ Python tracker <https://bugs.pyt

[issue38237] Expose meaningful keyword arguments for pow()

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: Here's a little microbenchmark, let me know if there's anything specific you'd like to see: Before == > python -m pyperf timeit "from test.test_builtin import BuiltinTest; tst = > BuiltinTest()" -- "tst.test_pow()&q

[issue38237] Expose meaningful keyword arguments for pow()

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: Before == >python -m pyperf timeit "pow(2, 3)" --duplicate 10 Mean +- std dev: 242 ns +- 19 ns > python -m pyperf timeit "pow(2.0, 3.0)" --duplicate 10 Mean +- std dev: 197 ns +- 16 ns After = > python -m pyperf t

[issue38237] Expose meaningful keyword arguments for pow()

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: math.pow changes removed from PR -- ___ Python tracker <https://bugs.python.org/issue38237> ___ ___ Python-bugs-list mailin

[issue38240] assertCountEqual is horribly misleading, sounds like only counts are being compared

2019-09-20 Thread Ammar Askar
Change by Ammar Askar : -- resolution: -> duplicate stage: -> resolved superseder: -> unittest.TestCase.assertCountEqual is a very misleading name type: -> behavior ___ Python tracker <https://bugs.python

[issue38240] assertCountEqual is horribly misleading, sounds like only counts are being compared

2019-09-20 Thread Ammar Askar
Ammar Askar added the comment: Hey Vitaly, not sure if you're the author of the original bug here: https://bugs.python.org/issue27071 Could you re-open that so the discussion is kept in one place. -- nosy: +ammar2 ___ Python tracker &

[issue38231] Documentation search results focus on tutorials and not language specifications

2019-09-20 Thread Ammar Askar
Change by Ammar Askar : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Docs search should prominently show definitions and glossary items ___ Python tracker <https://bugs.python

[issue38245] Why am I getting inconsistent results in this simple List assignment?

2019-09-21 Thread Ammar Askar
Ammar Askar added the comment: Check out this part of the FAQ: https://docs.python.org/3/faq/programming.html#how-do-i-create-a-multidimensional-list Essentially, when you did `C = 2*[[]]`, what happens is that the SAME empty list is placed into C[0] and C[1]. Whereas when you do `M

[issue38247] list(str.split(ch)) Does not print blank elements upon repeating character(ch)

2019-09-21 Thread Ammar Askar
Ammar Askar added the comment: For whitespace, the correct way to achieve this using split() with no argument: >>> print(list("Hello World How Are You?".split())) ['Hello', 'World', 'How', 'Are', 'You?'] >>> prin

[issue38206] Clarify that tp_dealloc must decref for heap allocated type

2019-09-27 Thread Ammar Askar
Change by Ammar Askar : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38300] Documentation says destuction of TemporaryDirectory object will also delete it, but it does not.

2019-09-27 Thread Ammar Askar
Ammar Askar added the comment: Hmm, I can't recreate this locally: >>> import tempfile >>> import os >>> t = tempfile.TemporaryDirectory() >>> temp_dir = t.name >>> os.path.exists(temp_dir) True >>> del t >>>

[issue38312] curses: add `set_tabsize` and `set_escdelay`

2019-09-28 Thread Ammar Askar
Ammar Askar added the comment: > I'd like to help with this, but I don't even know where to start with > argumentclinic -- any points would be greatly appreciated Are you asking about argumentclinic in general or something specific to this bug? If it's something specifi

[issue38302] __rpow__ not reached when __ipow__ returns NotImplemented

2019-09-29 Thread Ammar Askar
Ammar Askar added the comment: This isn't the ternary form of pow(), the documentation there is referring to the `pow(base, exp, modulus)`. -- nosy: +ammar2 ___ Python tracker <https://bugs.python.org/is

[issue38316] docs: Code object's "co_stacksize" field is described with mistake

2019-09-29 Thread Ammar Askar
Ammar Askar added the comment: Yeah, that parenthesized bit seems a bit weird: co_stacksize really has nothing to do with the number of variables, it's just that certain opcodes (https://docs.python.org/3/library/dis.html#python-bytecode-instructions) push and pop off the

[issue38318] Issues linking with ncurses and tinfo (cannot resolve symbols)

2019-09-29 Thread Ammar Askar
Change by Ammar Askar : -- nosy: +skrah, twouters ___ Python tracker <https://bugs.python.org/issue38318> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38327] Creating set with empty string returns empty set

2019-09-30 Thread Ammar Askar
Ammar Askar added the comment: I think the key thing you're missing here is that the set() constructor can take any arbitrary iterable (https://docs.python.org/3/library/functions.html#func-set). It simply goes over all the elements inside and adds them all to the set. This is no diff

[issue38357] print adding extra bytes in hex above x7F

2019-10-02 Thread Ammar Askar
Ammar Askar added the comment: If you're trying to get raw bytes, you need to use print(b'\x80') what's happening right now is that the '\x80' is treated as a unicode code point (see https://docs.python.org/3/howto/unicode.html#the-string-type), and wh

[issue17894] Edits to descriptor howto

2019-10-09 Thread Ammar Askar
Ammar Askar added the comment: Any updates on this? Some of the re-organization and simplifications here look pretty good overall and make the guide way more approachable. Seeing as how this has been sitting a while and Github has an option allow maintainers to make edits to PRs. Raymond

[issue20443] __code__. co_filename should always be an absolute path

2019-10-21 Thread Ammar Askar
Ammar Askar added the comment: I did a quick search to see what code would break from sys.argv[0] going relative intext:"sys.argv[0]" ext:py site:github.com https://www.google.com/search?q=intext:"sys.argv%5B0%5D"+ext:py+site:github.com and while most uses of i

[issue38558] Data Structures documentation out of sync with new Walrus operator

2019-10-24 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +16451 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16919 ___ Python tracker <https://bugs.python.org/issu

[issue38558] Data Structures documentation out of sync with new Walrus operator

2019-10-25 Thread Ammar Askar
Ammar Askar added the comment: Thank you for the report Matt! -- nosy: +ammar2 resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker <https://bugs.python.or

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-10-31 Thread Ammar Askar
Ammar Askar added the comment: This is what I get on master, will try 3.7.5+ as noted in the Github issue: Python 3.9.0a0 (heads/noopt-dirty:f3b170812d, Oct 1 2019, 20:15:53) [MSC v.1916 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or

[issue38645] datetime.datetime.fromtimestamp(0, tzlocal()) throws error

2019-10-31 Thread Ammar Askar
Ammar Askar added the comment: Err...I mean I think this is a dateutil bug rather than in the Python stdlib. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38645] datetime.datetime.fromtimestamp(0, tzlocal()) throws error

2019-10-31 Thread Ammar Askar
Ammar Askar added the comment: It is windows specific, but I don't think this is a dateutil bug rather than the python stdlib: Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 16:07:46) [MSC v.1900 32 bit (Intel)] on win32 Type "help", "copyright", "credits"

[issue38645] datetime.datetime.fromtimestamp(0, tzlocal()) throws error

2019-10-31 Thread Ammar Askar
Ammar Askar added the comment: Closing, here's the bug in dateutil's repo: https://github.com/dateutil/dateutil/issues/197 -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker <h

[issue38660] Checking if two regexes are equal should test if they are functionally equivalent

2019-11-01 Thread Ammar Askar
Ammar Askar added the comment: The notion of equivalent regular expressions does exist but is way more complicated than the simple example you described. For example: r"a|b" is the same as r"[ab]", r"^aa*$" is the same as r"^a+$" Implementin

[issue38655] ipaddress.ip_network('0.0.0.0/0').is_private == True

2019-11-04 Thread Ammar Askar
Ammar Askar added the comment: The documentation for is_private notes: Returns: A boolean, True if the address is reserved per RFC 4193. iana-ipv4-special-registry or iana-ipv6-special-registry. If we take a look at the iana-ipv4-special-registry then 0.0.0.0/8 does show up there

[issue38655] ipaddress.ip_network('0.0.0.0/0').is_private == True

2019-11-04 Thread Ammar Askar
Ammar Askar added the comment: Aah actually I was looking at an older version of the docs, the documentation now says, "if the address is allocated for private networks" which is actually misleading. The addresses here aren't all private networks: https://github.com/pyth

[issue38699] socket: change listen() default backlog from 128 to 4096?

2019-11-05 Thread Ammar Askar
Ammar Askar added the comment: Just for some more reference points from "production" python web servers: * gunicorn - 2048 (https://github.com/benoitc/gunicorn/blob/678b326dc030b450717ec505df69863dcd6fb716/docs/source/settings.rst#backlog) * tornado - 128 (https://github.com/

[issue16575] ctypes: unions as arguments

2019-11-05 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +16572 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/17064 ___ Python tracker <https://bugs.python.org/issu

[issue16575] ctypes: unions as arguments

2019-11-05 Thread Ammar Askar
Ammar Askar added the comment: Opened https://github.com/python/cpython/pull/17064 to fix this. Essentially it's a tiny little oversight in the back-porting. In the 3.7 branch, we perform an attribute lookup for `from_param` before the union checking code, so we must remember to DECR

[issue38696] HTTP modules documentation error

2019-11-05 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +16575 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17066 ___ Python tracker <https://bugs.python.org/issu

[issue38706] What should the error message in the exception raised by assertTrue and assertFalse be?

2019-11-05 Thread Ammar Askar
Ammar Askar added the comment: I like Steven's "truthy value" or "true value" proposal. Another alternative: "x does not evaluate to true" "x does not evaluate to false" -- nosy: +ammar2 ___ Python

[issue38706] What should the error message in the exception raised by assertTrue and assertFalse be?

2019-11-06 Thread Ammar Askar
Ammar Askar added the comment: I don't think the word "true" is really the issue here. It's the fact that "is" in this context is ambiguous, is it referring to the English "is" or the python operator `is`? -- __

[issue16575] ctypes: unions as arguments

2019-11-06 Thread Ammar Askar
Ammar Askar added the comment: Will close after https://buildbot.python.org/all/#/builders?tags=%2Brefleak&tags=%2B3.7 go back to green. -- ___ Python tracker <https://bugs.python.org/iss

[issue38724] Implement subprocess.Popen.__repr__

2019-11-06 Thread Ammar Askar
Change by Ammar Askar : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38724> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16575] ctypes: unions as arguments

2019-11-06 Thread Ammar Askar
Change by Ammar Askar : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue16575> ___ ___ Pyth

[issue43499] Compiler warnings in building Python 3.9 on Windows

2021-03-16 Thread Ammar Askar
Change by Ammar Askar : -- nosy: +ammar2 nosy_count: 1.0 -> 2.0 pull_requests: +23657 pull_request: https://github.com/python/cpython/pull/20628 ___ Python tracker <https://bugs.python.org/issu

[issue43499] Compiler warnings in building Python 3.9 on Windows

2021-03-16 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +23658 pull_request: https://github.com/python/cpython/pull/20508 ___ Python tracker <https://bugs.python.org/issue43

[issue43499] Compiler warnings in building Python 3.9 on Windows

2021-03-16 Thread Ammar Askar
Ammar Askar added the comment: Sure thing, I'll work on the backport. -- ___ Python tracker <https://bugs.python.org/issue43499> ___ ___ Python-bugs-list m

[issue43499] Compiler warnings in building Python 3.9 on Windows

2021-03-16 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +23661 pull_request: https://github.com/python/cpython/pull/24896 ___ Python tracker <https://bugs.python.org/issue43

[issue43555] Location of SyntaxError with new parser missing (after continuation character)

2021-03-22 Thread Ammar Askar
Ammar Askar added the comment: > We should definitely document the column offset being 1-based Yes please, I remember working on that issue to make it consistently 1-based a while ago and I remember that the tooling was relying on 1-based indexes for column offsets. -- n

[issue43601] Tools/c-analyzer/check-c-globals.py run throw exception err

2021-03-23 Thread Ammar Askar
Change by Ammar Askar : -- nosy: +eric.snow ___ Python tracker <https://bugs.python.org/issue43601> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26702] A better assert statement

2021-03-28 Thread Ammar Askar
Ammar Askar added the comment: Just a note and possible design inspiration, pytest has pretty assertions like this to allowing you to write unit tests purely with the assert statement and not unittest's special `assert...` methods: https://docs.pytest.org/en/stable/ex

[issue41670] ceval traces code differently with USE_COMPUTED_GOTOS

2021-04-02 Thread Ammar Askar
Change by Ammar Askar : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34398] Docs search should prominently show definitions and glossary items

2021-04-02 Thread Ammar Askar
Ammar Askar added the comment: Thank you to Julien for reviewing, we ended up going with our own solution instead of waiting on Sphinx and I think it looks good :) -- resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue40932] subprocess docs should warn of shlex use on Windows

2021-04-02 Thread Ammar Askar
Ammar Askar added the comment: Thank you Steve and Zachary for reviewing, this warning is in the docs now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40705] use-after-free in _zoneinfo.c's module_free function

2021-04-02 Thread Ammar Askar
Change by Ammar Askar : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41283] The parameter name for imghdr.what in the documentation is wrong

2021-04-02 Thread Ammar Askar
Change by Ammar Askar : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue29505] Submit the re, json, csv, & struct modules to oss-fuzz testing

2021-04-02 Thread Ammar Askar
Ammar Askar added the comment: All the modules prescribed in the original bug are now actively being fuzzed, thank you to Devin for the original work on this and Gregory for reviewing all these changes. I'm closing this now, feel free to make a new bug and nosy me in if there are any

[issue40012] Avoid Python 2 documentation to appear in Web search results

2021-04-02 Thread Ammar Askar
Ammar Askar added the comment: This has been fixed as part of https://github.com/python/docsbuild-scripts/pull/99 Thank you to Julien, our Google results are much cleaner now :) -- resolution: -> fixed stage: -> resolved status: open -&g

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread Ammar Askar
New submission from Ammar Askar : As pointed out by Guido in https://bugs.python.org/issue43555, we switched to making the column offsets for SyntaxError be 1-indexed consistently in https://bugs.python.org/issue34683 The rationale is explained by Guido and expanded upon in follow up

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +23900 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25153 ___ Python tracker <https://bugs.python.org/issu

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-03 Thread Ammar Askar
Ammar Askar added the comment: Aah thanks for pointing that out Terry, I didn't realize f-strings have different semantics for SyntaxError. Would you mind making a separate issue for that, I'll look into making the documentation for it clearer after I get a chance to i

[issue43836] range.index doesn't support start/stop optional arguments

2021-04-14 Thread Ammar Askar
Ammar Askar added the comment: Marked as a duplicate. Kaleb, would you mind posting your comment on the original bug #28197? -- nosy: +ammar2 resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Add start and stop parameters to the range

[issue43837] Operator precedence documentation could be more clear

2021-04-18 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch nosy: +ammar2 nosy_count: 8.0 -> 9.0 pull_requests: +24194 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25469 ___ Python tracker <https://bugs.python.org/i

[issue43837] Operator precedence documentation could be more clear

2021-04-18 Thread Ammar Askar
Ammar Askar added the comment: Opened https://github.com/python/cpython/pull/25469 for the first suggestion of reversing the precedence table order since it seems like a good improvement. I think the tight binding to weak order is more natural and aside from K&R, the following o

[issue38659] enum classes cause slow startup time

2021-04-21 Thread Ammar Askar
Ammar Askar added the comment: Looks like this is the issue described in the comment here: https://github.com/python/cpython/blob/master/Lib/test/test_enum.py#L3691-L3692 On the first run you have the correct ('CONVERT_STRING_TEST_NAME_A', 5) but later it

[issue38659] enum classes cause slow startup time

2021-04-21 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +24234 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/25516 ___ Python tracker <https://bugs.python.org/issu

[issue43888] GitHub Actions CI/CD `Coverage` job is broken on master

2021-04-24 Thread Ammar Askar
Ammar Askar added the comment: For what it's worth I think Brett's suggestion of just removing the coverage build entirely is good too since it seems like no one actually looks at the results and they take up valuable CI time. -- nos

[issue43888] GitHub Actions CI/CD `Coverage` job is broken on master

2021-04-27 Thread Ammar Askar
Change by Ammar Askar : -- pull_requests: +24370 pull_request: https://github.com/python/cpython/pull/25679 ___ Python tracker <https://bugs.python.org/issue43

[issue43899] separate builtin function

2021-04-29 Thread Ammar Askar
Ammar Askar added the comment: Note that the `more_itertools` package on pypi also has a partition method. Shall we close this off given that a recipe is already present and this is available as part of a popular 3rd-party library? -- nosy: +ammar2

[issue43614] Search is not beginner friendly

2021-04-29 Thread Ammar Askar
Ammar Askar added the comment: Just a little update to this, now that issue34398 is fixed it is possible to make this more beginner friendly by making sure the right terms have glossary entries. As an example, here is a search for "argument" on the latest docs: https://docs.pytho

[issue43565] PyUnicode_KIND macro does not has specified return type

2021-04-29 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch nosy: +ammar2 nosy_count: 4.0 -> 5.0 pull_requests: +24416 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25724 ___ Python tracker <https://bugs.python.org/i

[issue43982] Code coverage on the CI: validate codecov shell script checksum

2021-04-29 Thread Ammar Askar
Ammar Askar added the comment: See also https://github.com/python/cpython/pull/25679 where we're proposing just removing the coverage build altogether. -- nosy: +ammar2 ___ Python tracker <https://bugs.python.org/is

[issue43888] GitHub Actions CI/CD `Coverage` job is broken on master

2021-04-30 Thread Ammar Askar
Ammar Askar added the comment: Coverage builds have been removed from the CI, closing this now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43982] Code coverage on the CI: validate codecov shell script checksum

2021-04-30 Thread Ammar Askar
Ammar Askar added the comment: With issue43888 being fixed with the removal of the coverage build, this is now obsolete. Thanks for pointing out the codecov breach, we will make sure to follow this if we ever re-add codecov. -- resolution: -> out of date stage: -> resolved

[issue44006] symbol documentation still exists

2021-05-02 Thread Ammar Askar
Ammar Askar added the comment: Added Julien to the nosy list, looks like we might be retaining old deleted docs pages. -- nosy: +ammar2, mdk ___ Python tracker <https://bugs.python.org/issue44

[issue44006] symbol documentation still exists

2021-05-03 Thread Ammar Askar
Ammar Askar added the comment: Also, would it make sense to do a clean build (with the html output folder wiped) in the build-cron to avoid this happening in the future? -- ___ Python tracker <https://bugs.python.org/issue44

[issue40222] "Zero cost" exception handling

2021-05-09 Thread Ammar Askar
Ammar Askar added the comment: Seconded, also seeing the same ASAN failure on the fuzzers with a blame for this commit. -- nosy: +ammar2 ___ Python tracker <https://bugs.python.org/issue40

[issue44184] crash on windows invoking flake8

2021-05-20 Thread Ammar Askar
Ammar Askar added the comment: Can recreate on the latest 3.10 checkout, taking a look. -- nosy: +ammar2 ___ Python tracker <https://bugs.python.org/issue44

[issue44184] crash on windows invoking flake8

2021-05-20 Thread Ammar Askar
Ammar Askar added the comment: The segfault seems to be occuring on typeobject.c:1456 during interpreter finalization: if (type->tp_flags & Py_TPFLAGS_HEAPTYPE && !(base->tp_flags & Py_TPFLAGS_HEAPTYPE)) where `type` seems to have already been deallocated.

[issue44184] crash on windows invoking flake8

2021-05-20 Thread Ammar Askar
Ammar Askar added the comment: The bisect was bizarre to say the least... It points to commit 11159d2c9d6616497ef4cc62953a5c3cc8454afb bpo-43080: pprint for dataclass instances (GH-24389) * Added pprint support for dataclass instances which don't have a custom __repr__. which doesn&#x

[issue44184] crash on windows invoking flake8

2021-05-20 Thread Ammar Askar
Ammar Askar added the comment: Just to thicken the mystery a bit further, if you comment out import inspect in dataclasses.py, the error also goes away. -- ___ Python tracker <https://bugs.python.org/issue44

[issue44184] crash on windows invoking flake8

2021-05-21 Thread Ammar Askar
Ammar Askar added the comment: Indeed, it's quite a tricky issue so I'm glad it was caught in the beta. Thank you for the report Anthony. Thanks for tracing the root cause and the fix Victor and thank you to everyone who he

[issue44349] Edge case in pegen's error displaying with non-utf8 lines

2021-06-08 Thread Ammar Askar
New submission from Ammar Askar : The AST currently stores column offsets for characters as byte-offsets. However, when displaying errors, these byte-offsets must be turned into character-offsets so that the characters line up properly with the characters on the line when printed. This is

[issue44349] Edge case in compiler when error displaying with non-utf8 lines

2021-06-08 Thread Ammar Askar
Change by Ammar Askar : -- title: Edge case in when error displaying with non-utf8 lines -> Edge case in compiler when error displaying with non-utf8 lines ___ Python tracker <https://bugs.python.org/issu

[issue43950] Include column offsets for bytecode instructions

2021-06-29 Thread Ammar Askar
Change by Ammar Askar : -- nosy: +ammar2 nosy_count: 8.0 -> 9.0 pull_requests: +25524 pull_request: https://github.com/python/cpython/pull/26958 ___ Python tracker <https://bugs.python.org/issu

  1   2   3   4   5   >