Abhilash Raj added the comment:
@Victor: This is already backported to 3.6. I am not sure about what gets
backported to 3.5 right now, I don't even see a 'Backport to 3.5' label on
Github (which made me think we are discouraged to backport to 3.5). I can work
on a manual bac
Abhilash Raj added the comment:
You have correctly identified that "=aa" is detected as a encoded word and
causes the get_encoded_word to fail.
However, "=?utf-8?q?somevalue?=aa" should ideally get parsed as "somevalueaa"
and not "=?utf-8?q?someval
Abhilash Raj added the comment:
I meant, =aa is identified as encoded word escape
--
___
Python tracker
<https://bugs.python.org/issue37764>
___
___
Python-bug
Abhilash Raj added the comment:
Although, the 2nd bug I spoke of is kind of speculative, I haven't been able to
find a test case which matches rfc2047_matcher but raises exception with
get_encoded_word (after, ofcourse, the first bug is fixed), which the only way
to cause an infinite
Change by Abhilash Raj :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue37826>
___
___
Pyth
Change by Abhilash Raj :
--
pull_requests: +15036
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/15317
___
Python tracker
<https://bugs.python.org/issu
Abhilash Raj added the comment:
Created a backport PR for 3.5.
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issu
Change by Abhilash Raj :
--
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9 -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/i
Change by Abhilash Raj :
--
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.3, Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.org/i
Abhilash Raj added the comment:
I am slightly confused if this should be backported to bugfix branches since
this is technically a new feature, the ability to parse Message-ID field.
I would love to see what David and Barry think about this
Abhilash Raj added the comment:
2.7 needs a separate PR since the code is very different and my familiarity
with 2.7 version of email package is very limited.
I am going to work on a separate patch later this week for 2.7.
--
___
Python tracker
Abhilash Raj added the comment:
Removing 2.7 which only accepts security patches.
--
nosy: +maxking
versions: -Python 2.7
___
Python tracker
<https://bugs.python.org/issue32
Change by Abhilash Raj :
--
pull_requests: +15138
pull_request: https://github.com/python/cpython/pull/15446
___
Python tracker
<https://bugs.python.org/issue37
Abhilash Raj added the comment:
I manually created a backport PR for 3.5 and added Larry as a reviewer.
https://github.com/python/cpython/pull/15446
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Abhilash Raj :
--
pull_requests: +15344
pull_request: https://github.com/python/cpython/pull/15686
___
Python tracker
<https://bugs.python.org/issue37
Abhilash Raj added the comment:
New changeset 6ad0a2c45f78020f7994e47620c1cf7b225f8197 by Abhilash Raj in
branch '3.8':
[3.8] bpo-37764: Fix infinite loop when parsing unstructured email headers.
(GH-15239) (GH-15686)
https://github.com/python/cpyt
Change by Abhilash Raj :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue37764>
___
___
Pyth
Abhilash Raj added the comment:
I think so, yes.
Also, while you are at it, can you also close bpo-35939 with a comment that
points to this issue and the right PR for the fix?
--
___
Python tracker
<https://bugs.python.org/issue22
Change by Abhilash Raj :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue37764>
___
___
Python-bugs-list mailing list
Unsubscrib
Abhilash Raj added the comment:
Merged in 2.7, closing this one finally!
Thanks to everyone who helped with this :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bug
Abhilash Raj added the comment:
Martin: Can you please create a PR for the added patch? If you are busy, I can
do that for you, just wanted to ask before I do :)
I am going to remove "easy" label from this issue, which IMO it clearly isn't
given 4 years of history to catch
Abhilash Raj added the comment:
New changeset 2702638eabe5f7b25f36d295f0ad78cb8d4eda05 by Abhilash Raj (Michael
Selik) in branch 'master':
bpo-34002: Minor efficiency and clarity improvements in email package. (GH-7999)
https://github.com/python/cpyt
Abhilash Raj added the comment:
PR is now merged.
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Abhilash Raj added the comment:
It seems that SMTPNotSupportedError is publicly documented, it should be a part
of __all__.
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue38
Abhilash Raj added the comment:
New changeset 3faf826e5879536d2272f1a51c58965a16827f81 by Abhilash Raj (nde) in
branch 'master':
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (#16525)
https://github.com/python/cpython/commit/3faf826e5879536d2272f1a51c5896
Abhilash Raj added the comment:
It is actually parsed correctly and serialized back when you try to convert it
to a string representation:
from email.parser import BytesFeedParser
import email.policy
def main():
eml_string = 'From: Nobody <""@example.org>'
Abhilash Raj added the comment:
The function of this imaginary method is described below:
# The magic_html_parser has to rewrite the href="cid:" attributes to
# point to the filenames in partfiles. It also has to do a safety-sanitize
# of the html. It could be wri
Abhilash Raj added the comment:
The comment should make it clear that it is an made up imaginary module. The no
dependencies outside of standard library is not written, I guess?
--
___
Python tracker
<https://bugs.python.org/issue38
Abhilash Raj added the comment:
We could move that comment to the top near the import, I am totally fine with
that.
--
___
Python tracker
<https://bugs.python.org/issue38
Abhilash Raj added the comment:
New changeset 65dcc8a8dc41d3453fd6b987073a5f1b30c5c0fd by Abhilash Raj (Andrei
Troie) in branch 'master':
bpo-38332: Catch KeyError from unknown cte in encoded-word. (GH-16503)
https://github.com/python/cpython/commit/65dcc8a8dc41d3453fd6b987073a5f
Abhilash Raj added the comment:
David: How do you propose we move forward on this?
Should we provide a switch to keep the original behaviour (which is off by
default) so if there is someone depending on this bug, they could still
continue to do it with relatively small change?
It is a
Abhilash Raj added the comment:
I am looking into the issue.
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue38449>
___
___
Python-bugs-list m
Abhilash Raj added the comment:
The bug is interesting due to some of the implementation details of
"guess_type". The documentation says that it can parse either a URL or a
filename.
Switching from urllib.parse._splittype to urllib.parse.urlparse changed what a
valid "path&
Abhilash Raj added the comment:
Yeah, I agree. I'll submit a PR for reverting the commits.
--
___
Python tracker
<https://bugs.python.org/issue38449>
___
___
Change by Abhilash Raj :
--
keywords: +patch
pull_requests: +16302
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16724
___
Python tracker
<https://bugs.python.org/issu
Change by Abhilash Raj :
--
pull_requests: +16303
pull_request: https://github.com/python/cpython/pull/16724
___
Python tracker
<https://bugs.python.org/issue22
Change by Abhilash Raj :
--
pull_requests: +16307
pull_request: https://github.com/python/cpython/pull/16727
___
Python tracker
<https://bugs.python.org/issue22
Change by Abhilash Raj :
--
pull_requests: +16308
pull_request: https://github.com/python/cpython/pull/16727
___
Python tracker
<https://bugs.python.org/issue38
Change by Abhilash Raj :
--
pull_requests: +16309
pull_request: https://github.com/python/cpython/pull/16728
___
Python tracker
<https://bugs.python.org/issue38
Change by Abhilash Raj :
--
pull_requests: +16310
pull_request: https://github.com/python/cpython/pull/16728
___
Python tracker
<https://bugs.python.org/issue22
Change by Abhilash Raj :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue38341>
___
___
Pyth
Abhilash Raj added the comment:
I am going to re-open this since the fixes were reverted in all the branches.
--
status: closed -> open
___
Python tracker
<https://bugs.python.org/issu
Abhilash Raj added the comment:
corona10: That's okay, it happens. I missed it too. There was really no way to
foresee all the use cases, which is why we have beta and rc period to catch
bugs.
Yes, we should add a test case definitely, do you want to work on
Abhilash Raj added the comment:
New changeset 5a638a805503131f4a9cc2bbc5944611295c1500 by Abhilash Raj in
branch '3.8':
[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper
parsing of URLs" (GH-16724) (GH-16728)
https://github.com/p
Abhilash Raj added the comment:
New changeset 5a638a805503131f4a9cc2bbc5944611295c1500 by Abhilash Raj in
branch '3.8':
[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper
parsing of URLs" (GH-16724) (GH-16728)
https://github.com/p
Change by Abhilash Raj :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.or
Abhilash Raj added the comment:
New changeset 2fe4c48917c2d1b40cf063c6ed22ae2e71f4cb62 by Abhilash Raj
(Dong-hee Na) in branch 'master':
bpo-38449: Add URL delimiters test cases (#16729)
https://github.com/python/cpython/commit/2fe4c48917c2d1b40cf063c6ed22ae
Change by Abhilash Raj :
--
pull_requests: +16980
pull_request: https://github.com/python/cpython/pull/17503
___
Python tracker
<https://bugs.python.org/issue38
Change by Abhilash Raj :
--
keywords: +patch
pull_requests: +16981
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17504
___
Python tracker
<https://bugs.python.org/issu
Abhilash Raj added the comment:
Closing this since it has been fixed in Python 3.8.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: -Python 3.7
___
Python tracker
<https://bugs.python.or
Abhilash Raj added the comment:
New changeset 68157da8b42b26408af5d157d2dba4fcf29c6320 by Abhilash Raj in
branch 'master':
bpo-38698: Add a new InvalidMessageID token to email header parser. (GH-17503)
https://github.com/python/cpython/commit/68157da8b42b26408af5d157d2dba4
Abhilash Raj added the comment:
New changeset 3ae4ea1931361dd2743e464790e739d9285501bf by Abhilash Raj in
branch 'master':
bpo-38708: email: Fix a potential IndexError when parsing Message-ID (GH-17504)
https://github.com/python/cpython/commit/3ae4ea1931361dd2743e464790e739
Abhilash Raj added the comment:
Closing this as fixed.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Abhilash Raj added the comment:
Closing this as fixed.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Abhilash Raj added the comment:
I tried to take a look at the code to see where the fix needs to be and I
probably need some help.
I looked at the parse tree for the header and it looks something like this:
ContentDisposition([Token([ValueTerminal('attachment')]), Val
Change by Abhilash Raj :
--
pull_requests: +17090
pull_request: https://github.com/python/cpython/pull/17620
___
Python tracker
<https://bugs.python.org/issue39
Abhilash Raj added the comment:
Thanks for the pointer, David! I created a PR for the fix, would you be able to
review it please?
--
___
Python tracker
<https://bugs.python.org/issue39
Abhilash Raj added the comment:
Thanks David! I applied the fixes as per your comments, can you please take
another look?
--
___
Python tracker
<https://bugs.python.org/issue39
Abhilash Raj added the comment:
Sure, fixed as per your comments in the PR.
--
___
Python tracker
<https://bugs.python.org/issue39040>
___
___
Python-bugs-list m
Change by Abhilash Raj :
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue39071>
___
___
Python-bugs-list mailing list
Unsubscribe:
Abhilash Raj added the comment:
I double checked, there should be 4 commits in the PR and last 2 have the
changes that you asked for in the test case and NEWS entry.
Your previous comment will point at the old diff, you might have to look at the
full diff here: https://github.com/python
Abhilash Raj added the comment:
New changeset b2b4a51f7463a0392456f7772f33223e57fa4ccc by Abhilash Raj (Philip
McMahon) in branch 'master':
bpo-32021: Support brotli .br encoding in mimetypes (#12200)
https://github.com/python/cpython/commit/b2b4a51f7463a0392456f7772f3322
Change by Abhilash Raj :
--
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.8
___
Python tracker
<https://bugs.python.org/i
Change by Abhilash Raj :
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue39628>
___
___
Python-bugs-list mailing list
Unsubscribe:
Abhilash Raj added the comment:
I have merged https://github.com/python/cpython/pull/20542 and backported to
3.8 and 3.9 branches (https://github.com/python/cpython/pull/21404 &
https://github.com/python/cpython/pull/21405).
Closing this issue.
--
resolution: -> fixed
stage
Abhilash Raj added the comment:
Closing this since the PRs for the behavior change reported by Mike and
BPO-41206 is now merged too.
--
nosy: +maxking
stage: patch review -> resolved
status: open -> closed
___
Python tracker
Abhilash Raj added the comment:
Thanks Mark!
--
___
Python tracker
<https://bugs.python.org/issue40597>
___
___
Python-bugs-list mailing list
Unsubscribe:
Abhilash Raj added the comment:
I was wrong about the parsing error, it looks like length from the policy isn't
used when parsing.
>>> from email.policy import default
>>> from email import message_from_string
>>> p = default.clone(max_line_length=1
Abhilash Raj added the comment:
According to RFC 2047 5(1)
> However, an 'encoded-word' that appears in a
header field defined as '*text' MUST be separated from any adjacent
'encoded-word' or 'text' by 'linear-white-space'.
So, it see
Abhilash Raj added the comment:
The solution replaces RFC 20147 chrome for utf-8 and q to make sure there is a
space before ew, it wouldn't replace in case of any other charset/cte pair.
value = value.replace("=?UTF-8?Q?=20", " =?UTF-8?Q?&q
Abhilash Raj added the comment:
Just for reference DKIM-Signature header is defined in RFC 6376 and the BNF
description for the header is mentioned here
(https://tools.ietf.org/html/rfc6376#section-3.5).
It is a bit long so I am not copy-pasting it here.
I might take a stab at writing a
Change by Abhilash Raj :
--
pull_requests: +13300
___
Python tracker
<https://bugs.python.org/issue33524>
___
___
Python-bugs-list mailing list
Unsubscribe:
Abhilash Raj added the comment:
Ah, I wrongly assumed the patch had the same thing.
Sorry about that.
--
___
Python tracker
<https://bugs.python.org/issue21
Change by Abhilash Raj :
--
keywords: +patch
pull_requests: +13307
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Abhilash Raj added the comment:
I have created https://github.com/python/cpython/pull/13397 for this. For now,
it only parses Message-ID header.
I do plan to add support for other Identification headers soon, perhaps in a
2nd PR.
--
nosy: +maxking
stage: patch review -> ne
Change by Abhilash Raj :
--
pull_requests: +13335
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue21315>
___
___
Python-bugs-list mai
Abhilash Raj added the comment:
Created a Pull Request for this.
https://github.com/python/cpython/pull/13425
--
___
Python tracker
<https://bugs.python.org/issue21
Abhilash Raj added the comment:
I have made the requested changes on PR.
David, can you please review again?
--
___
Python tracker
<https://bugs.python.org/issue35
Abhilash Raj added the comment:
I have made the requested changes on PR.
--
___
Python tracker
<https://bugs.python.org/issue21315>
___
___
Python-bugs-list m
Change by Abhilash Raj :
--
keywords: +patch
pull_requests: +13505
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/13598
___
Python tracker
<https://bugs.python.org/issu
Abhilash Raj added the comment:
IMO, this is a duplicate of https://bugs.python.org/issue33529 (which was
reported before this one was).
I have tested that the fix for bpo-33529 does indeed fix the test case which
has been provided above.
The Pull Request for bpo-33529 has been merged, so
Change by Abhilash Raj :
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue34025>
___
___
Python-bugs-list mailing list
Unsubscribe:
Abhilash Raj added the comment:
This is a dupe of https://bugs.python.org/issue30835, which has an attached PR.
I have verified the provided test case is fixed by the PR for bpo-30835.
--
nosy: +maxking
___
Python tracker
<https://bugs.python.
Abhilash Raj added the comment:
I am not sure which 2nd PR are we talking about here?
The reported exception stems from Lib/email/feedparser.py#L323 and same is
fixed in PR (https://github.com/python/cpython/pull/13598) for bpo-30835
Abhilash Raj added the comment:
How about we go a slightly different route than suggested by jpic and instead
of returning a None value, we return the entire rest of the string as the
domain? That would take care of the security issue since it won't be a valid
domain anymore.
Abhilash Raj added the comment:
I don't know if we can make the API consistent between parseaddr and the
parsing header value since they are completely different even right now. Like
you already noticed there is no way to register defects and instead parseaddr
returns ('', &#
Abhilash Raj added the comment:
I agree that we currently abandon parsing (raise `HeaderParseError`) when we
encounter a unexpected token when parsing domain (expected token is
dot-atom-text).
However, that mechanism is meant to signal the higher level parser that we
should look for a
Abhilash Raj added the comment:
slight typo in the previous message:
s/fallback to `get_unstructured` /fallback to *something*/g
--
___
Python tracker
<https://bugs.python.org/issue34
Change by Abhilash Raj :
--
pull_requests: +13782
pull_request: https://github.com/python/cpython/pull/13909
___
Python tracker
<https://bugs.python.org/issue36
Change by Abhilash Raj :
--
pull_requests: +13783
pull_request: https://github.com/python/cpython/pull/13910
___
Python tracker
<https://bugs.python.org/issue36
Abhilash Raj added the comment:
I don't think this is an issue anymore, I guess this was fixed as a part of
some other PR.
I tested this out on a recent branch:
>>> import email
>>> msg = email.message_from_string('From: Abhilash
')
>>
Abhilash Raj added the comment:
I wasn't able to reproduce this on the latest master. Probably fixed as a part
of some other PR.
>>> msg = email.message_from_string('ReplyTo: ""')
>>> msg
>>> msg['ReplyTo'
Abhilash Raj added the comment:
I can't reproduce this issue on the latest master branch. This seems to be
fixed as a part of a different PR I suppose.
>>> import email
>>> msg = email.message_from_string("From: Bonifac Karaka :
boni...@gmail.com")
Abhilash Raj added the comment:
I can't reproduce this problem with the latest master branch, it was perhaps
fixed with some other PR.
This is also a dupe of bpo-31445.
@barry, @david: I think this issue can be closed.
--
nosy: +ma
Abhilash Raj added the comment:
For the record, this is how I tested using the master branch:
>>> msg = email.message_from_string(' To: (Recipient list suppressed)')
>>> msg['To']
>>> import email.policy
>>> msg = email.message_from
Abhilash Raj added the comment:
Nevermind, I was wrong, I was able to reproduce it:
>>> msg = email.message_from_string('To: (Recipient list suppressed)',
>>> policy=email.policy.default))
File "", line 1
SyntaxError: unmatched ')'
>>
Change by Abhilash Raj :
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue4963>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Abhilash Raj :
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue26543>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Abhilash Raj :
--
pull_requests: +13968
pull_request: https://github.com/python/cpython/pull/14119
___
Python tracker
<https://bugs.python.org/issue33
Change by Abhilash Raj :
--
pull_requests: +14194
pull_request: https://github.com/python/cpython/pull/14380
___
Python tracker
<https://bugs.python.org/issue33
1 - 100 of 139 matches
Mail list logo
