Pablo Galindo Salgado added the comment:
Indeed, seems my original hunch is correct. Steve, could you take a look when
you have some time?
--
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
Thanks for the catch Carl!
> I can try to fix this.
Awesome, I will wait for the PR!
--
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28279
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30059
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Don't worry, turns out it was a bit messier than I thought, so I prepared the
PR. If you have some time, it would be great if you can take a quick look.
--
___
Python tracker
<https://bugs.py
Pablo Galindo Salgado added the comment:
New changeset 59435eea08d30796174552c0ca03c59b41adf8a5 by Pablo Galindo Salgado
in branch 'main':
bpo-46042: Improve SyntaxError locations in the symbol table (GH-30059)
https://github.com/python/cpython/commit/59435eea08d30796174552c0ca03c5
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> Oh no, I was about to open mine ;-)
Sorry, Carl, I apologize. I hope it was not too disruptive to do the work. I
was taking a look and I felt bad that the issue was probably messier than I
thought and I didn't want you to have to iterate ma
Pablo Galindo Salgado added the comment:
New changeset 438817fdd5b731d486285d205bed2e78b655c0d6 by Miss Islington (bot)
in branch '3.10':
bpo-46042: Improve SyntaxError locations in the symbol table (GH-30059)
(GH-30064)
https://github.com/python/cpyt
New submission from Pablo Galindo Salgado :
Python3.9 shows:
../3.9/python /bin/ls
SyntaxError: Non-UTF-8 code starting with '\xfc' in file /bin/ls on line 2, but
no encoding declared; see https://python.org/dev/peps/pep-0263/ for detail
while 3.10 shows:
python /bin/ls
Fil
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28288
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30068
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 4325a766f5f603ef6dfb8c4d5798e5e73cb5efd5 by Pablo Galindo Salgado
in branch 'main':
bpo-46054: Fix parsing error when parsing non-utf8 characters in source files
(GH-30068)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +28296
pull_request: https://github.com/python/cpython/pull/30074
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
New changeset 94483f1e3cec182fabe19268e579f63045bc984a by Miss Islington (bot)
in branch '3.10':
bpo-46054: Fix parsing error when parsing non-utf8 characters in source files
(GH-30068) (GH-30069)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset c6d1c52c166968fb722ae26d44aa2c1c030dc613 by Pablo Galindo Salgado
in branch 'main':
bpo-46054: Correct non-utf8 character tests in test_exceptions (GH-30074)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
This is a side effect on the fix in:
https://bugs.python.org/issue40847
--
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
Unfortunately I am not sure if this is going to be easier to retrofit for the
reasons exposed in the issue. I will try to take a look, but if you have some
cycles to spare, a PR would be welcomed
Pablo Galindo Salgado added the comment:
Actually, I am not sure if this is a bug, at least according to this comment:
https://bugs.python.org/msg370812
What are your thoughts on this Guido?
--
nosy: +gvanrossum
___
Python tracker
<ht
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28349
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30130
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
nevermind, I am convinced is a bug. I filed a PR for it
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg408657
___
Python tracker
<https://bugs.python.org/issue46091>
___
___
Python-bug
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
That is weird, but can happen for example if some pthread of some c extensiΓ³n
for example picks up the Gil, causing a new PyThreadState to be created and
linked but has not called into Python yet.
Basically, an external native thread that calls
Pablo Galindo Salgado added the comment:
Relevant section:
https://docs.python.org/3/c-api/init.html#non-python-created-threads
--
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
This is a stack overflow in the parser, unfortunately, which unfortunately is
very difficult to defend against.
--
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
This is a known issue for recursive descendent parsers. The only thing we can
do here is somehow limit the maximum stack depth of the C stack, but that can:
* Slow down the parser.
* Limit valid expressions that otherwise won't segfault.
* Still
Pablo Galindo Salgado added the comment:
I worked in the past in a refactor of the math based rules
(https://github.com/python/cpython/pull/20696/files) that could prevent
**this** particular example, but others could still make the parser crash by
stack overflow
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 2.0 -> 3.0
pull_requests: +28394
pull_request: https://github.com/python/cpython/pull/30177
___
Python tracker
<https://bugs.python.org/iss
Pablo Galindo Salgado added the comment:
I made a draft PR here:
https://github.com/python/cpython/pull/30177
to fix the issue. But we should benchmark and evaluate it before deciding
anything.
--
___
Python tracker
<https://bugs.python.
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28395
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30177
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +28396
pull_request: https://github.com/python/cpython/pull/30177
___
Python tracker
<https://bugs.python.org/issue6
Pablo Galindo Salgado added the comment:
New changeset e9898bf153d26059261ffef11f7643ae991e2a4c by Pablo Galindo Salgado
in branch 'main':
bpo-46110: Add a recursion check to avoid stack overflow in the PEG parser
(GH-30177)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +28435
pull_request: https://github.com/python/cpython/pull/30214
___
Python tracker
<https://bugs.python.org/issue46
Change by Pablo Galindo Salgado :
--
pull_requests: +28436
pull_request: https://github.com/python/cpython/pull/30215
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
New changeset dc73199a212a44553578eb4952631e5ba9e5f292 by Pablo Galindo Salgado
in branch '3.10':
[3.10] bpo-46110: Add a recursion check to avoid stack overflow in the PEG
parser (GH-30177) (GH-30214)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset e5cf31d3c2b30d12f238c6ab26d15855eefb2a8a by Pablo Galindo Salgado
in branch '3.9':
[3.9] bpo-46110: Add a recursion check to avoid stack overflow in the PEG
parser (GH-30177) (#30215)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue37295>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
I can try to prototype something in the parser to see how it looks and work on
the pep if everything looks ok.
Parentheses are a bit tricky in general as backtracking ends causing all sorts
of tricky situations with custom syntax errors as the parser
Pablo Galindo Salgado added the comment:
> We managed to do this for 'with' so it should be possible here too, I'd
> think. The "committing" token would be the newline following the close
> parenthesis.
I am not so sure is that inmediate. Changing the a
Pablo Galindo Salgado added the comment:
We could do this, but feels a bit hacky:
| 'assert' '(' a=expression b=[',' z=expression { z }] ')' &(NEWLINE | ';')
| 'assert' a=expression b=[',' z=expression { z }]
Pablo Galindo Salgado added the comment:
Another possibility is actually handled this in the compiler:
if we see an assert with a tuple of two elements, we can assume is basically in
the form that we want and proceed as if is in the form
assert A, B
This also feels a bit hacky because the
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28465
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30247
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
This seems to be fixed on the main branch (at least I cannot reproduce it in
the main branch). If so, this means that will be fixed in Python 3.10.2.
10maurycy10, could you please confirm that this is indeed the case
Change by Pablo Galindo Salgado :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Example:
>>> ___π
File "", line 1
___π
^
SyntaxError: invalid character 'π' (U+1F600)
>>> __π
File "", line 1
__π
^
SyntaxError: invalid character 'π' (U+1F600)
Pablo Galindo Salgado added the comment:
>It seems that the PR was merged without discussion about 85% regression in
>python_startup benchmark
Ugh, that's quite bad. We measured performance impact in general and that was
quite acceptable but seems that for startup this is quit
Change by Pablo Galindo Salgado :
--
nosy: +lukasz.langa
versions: +Python 3.11, Python 3.9
___
Python tracker
<https://bugs.python.org/issue46110>
___
___
Pytho
Pablo Galindo Salgado added the comment:
Guido, Eric, what are your thoughts here?
The fix that I merged works by limiting the maximum recursion but seems that
incrementing the recursion counter on every parser call makes quite a lot of
impact on startup.
Unfortunately if we revert the fix
Pablo Galindo Salgado added the comment:
> Let me have a look. May take a day, okay?--
Absolutely! There is no rush as the only close release IIRC is another alpha of
3.11.
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I don't know what you mean with "it's missing". That is the actual rule used in
the grammar:
https://github.com/python/cpython/blob/8e75c6b49b7cb8515b917f01b32ece8c8ea2c0a0/Grammar/python.gram#L88
--
resolution:
Pablo Galindo Salgado added the comment:
invalid_* rules are not part of the official grammar as they are only used for
error reporting. We need to update the peg grammar highlighter to exclude it
--
___
Python tracker
<https://bugs.python.
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28553
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30341
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
This are my results running directly the pyperformance run script
(https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_python_startup/run_benchmark.py)
with and without the fix (both PGO/LTO):
pablogsal@Obsidian-W
Pablo Galindo Salgado added the comment:
I am not able to reproduce on Linux either, with pyperformance or manual
testing in the CLI.
Interestingle, this shows up in both machines:
https://speed.python.org/timeline/#/?exe=12&ben=python_startup&env=1&revs=50&equid=off&a
Pablo Galindo Salgado added the comment:
> Does python_startup benchmark start with all modules parsed and __pycache__d,
> or with no cache, so it includes the normally one-time parse time?
I don't know what pyperf does with the cache (adding Victor as maybe he knowns).
Pablo Galindo Salgado added the comment:
Ran pyperformance with PGO/LTO CPU-isol on my Linux box and I cannot reproduce
either:
β― pyperf compare_to json/* --table --table-format=md -G
| Benchmark | 2021-12-20_10-23-master-6ca78affc802 |
2021-12-20_15-43-master-e9898bf153d2
Pablo Galindo Salgado added the comment:
> Maybe something unrelated changed on the benchmark machines?
Very unlikely, it happened on two separate machines with different
distributions and nothing was updated in the machines that I can see.
Both use a configuration file for pyperforma
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue42202>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
> I propose a test: revert the PR and see if speed.Python.org shows a speedup
back to the previous number.--
Ok, let's do that and see what happens
--
___
Python tracker
<https://bugs.python.org
Change by Pablo Galindo Salgado :
--
pull_requests: +28577
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/30363
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 9d35dedc5e7e940b639230fba93c763bd9f19c09 by Pablo Galindo Salgado
in branch 'main':
Revert "bpo-46110: Add a recursion check to avoid stack overflow in the PEG
parser (GH-30177)" (GH-30363)
https://github.com/p
Change by Pablo Galindo Salgado :
--
pull_requests: +28579
pull_request: https://github.com/python/cpython/pull/30366
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
New changeset 9d6a239a34a66e16188d76c23a3a770515ca44ca by Erlend Egeberg
Aasland in branch 'main':
bpo-44092: Don't reset statements/cursors before rollback (GH-26026)
https://github.com/python/cpython/commit/9d6a239a34a66e16188d76c23
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I ran the benchmarks machines with the revert and seems that it doesn't go back
to the previous timing:
https://speed.python.org/timeline/#/?exe=12&ben=python_startup&env=1&revs=50&equid=off&quarts=on&extr=on
(che
Pablo Galindo Salgado added the comment:
https://speed.python.org/timeline/#/?exe=12&ben=python_startup&env=4&revs=50&equid=off&quarts=on&extr=on
also doesn't show any difference with the revert
--
___
Python trac
Pablo Galindo Salgado added the comment:
New changeset dd6c35761a4cd417e126a2d51dd0b89c8a30e5de by Pablo Galindo Salgado
in branch 'main':
bpo-46110: Restore commit e9898bf153d26059261ffef11f7643ae991e2a4c
https://github.com/python/cpython/commit/dd6c35761a4cd417e126a2d51dd0b8
Pablo Galindo Salgado added the comment:
At thing at this point we can confidently say that is very very unlike that
there is no actual regression.
What's going on with the performance servers is something I still cannot
explain. I at least can confirm the servers system packages wer
Pablo Galindo Salgado added the comment:
> I presume you mean
> "it is very very *likely* that there is no actual regression"
Yes, sorry, that's what I meant :)
> This shouldn't hold up releases
Cool, we will proceed with
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28588
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30378
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset a09062c267a94200ad299f779429fea1b571ee35 by Erlend Egeberg
Aasland in branch 'main':
bpo-44092: Move What's New entry to where it belongs (GH-30381)
https://github.com/python/cpython/commit/a09062c267a94200ad299f779
Pablo Galindo Salgado added the comment:
New changeset 70f415fb8b632247e28d87998642317ca7a652ae by Pablo Galindo Salgado
in branch 'main':
bpo-46240: Correct the error for unclosed parentheses when the tokenizer is not
finished (GH-30378)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset e09d94a140a5f6903017da9b6ac752ba041d69da by Pablo Galindo Salgado
in branch 'main':
bpo-46231: Remove invalid_* rules preceded by more tokens from the grammar docs
(GH-30341)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Thanks Andre for the report!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 7d7817cf0f826e566d8370a0e974bbfed6611d91 by Kumar Aditya in
branch 'main':
bpo-20369: concurrent.futures.wait() now deduplicates futures given aβ¦
(GH-30168)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue46260>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
I did a run of pyperformance manually forcing setuptools<60.0 and another with
setuptools>=60.0 I can reproduce the timing difference.
I assume we can therefore close this issue and maybe open another one thinking
about how to deal wi
New submission from Pablo Galindo Salgado :
Seems that the FreeBSD buildbots cannot compile Python 3.11 anymore:
LD_LIBRARY_PATH=/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build CC='cc
-pthread' LDSHARED='cc -pthread -shared' OPT='-g -O0 -Wall'
Pablo Galindo Salgado added the comment:
Can this be closed?
--
___
Python tracker
<https://bugs.python.org/issue40222>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
If this is not fixed by this week, I will be forced to revert the PR
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
There is also this other builder:
https://buildbot.python.org/all/#/builders/172/builds/1093
failing what what seems is a freeze problem:
- 'use_frozen_modules': 1,
+ 'use_frozen_modules': -1,
?+
Pablo Galindo Salgado added the comment:
Is there anything left here?
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Yeah, the docs mention explicitly that is a dictionary or NULL.
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue46236>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
I am quite sure this is due to PR 23316
--
___
Python tracker
<https://bugs.python.org/issue46236>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
>> I am not a regular CPython developer, so I don't have a good way to assess
>> which reviewers speak for the project and which reviewers are only offering
>> a personal opinion.
In this webpage (bpo) core developers have a l
Pablo Galindo Salgado added the comment:
New changeset dd50316e458d7c3284f8948b0606d8aa91ab855d by Simon McVittie in
branch 'main':
bpo-43137: Revert "webbrowser: Don't run gvfs-open on GNOME" (GH-30417)
https://github.com/python/cpython/commit/dd50316e458d7c3
Pablo Galindo Salgado added the comment:
I am removing the "release blocker" tag.
Simon, thanks a lot for both PRs. I am sorry that we needed to revert your
original work, but unfortunately it was blocking a release and we are forced to
act in this case. PLease, work together with
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.11
___
Python tracker
<https://bugs.python
Pablo Galindo Salgado added the comment:
Gentle ping, as the next alpha will be release soon
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue45665>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue46274>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue46275>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Unfortunately the buildbots are still red:
https://buildbot.python.org/all/#/builders/483/builds/1416/steps/5/logs/stdio
https://buildbot.python.org/all/#/builders/172/builds/1102
One is the test_embed problem with frozen modules
Pablo Galindo Salgado added the comment:
This doesn't look like a bug to me and is documented behavior:
https://docs.python.org/3/reference/datamodel.html#object.__del__
Check this paragraph:
Warning Due to the precarious circumstances under which __del__() methods are
invoked, excep
Change by Pablo Galindo Salgado :
--
title: backslash creating statement out of nothing -> Tokenizer module does not
handle backslash characters correctly
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> Based on the research of the result, I tried to design a tool to
> automatically detect and repair vulnerabilities in CPython and make this tool
> available. See:
You mention here that your tool automatically "repairs" the code.
Pablo Galindo Salgado added the comment:
> Is this under control, or do you still need help with some part?
As Christian mentions, we still have the test_embed issue
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> I don't see how this could be an uninitialized read, although I'm willing to
> be wrong.
It can be uninitialized if the parenstack[nested_depth] value is itself
initialized, which can happen if the memory block pointed by parensta
101 - 200 of 4560 matches
Mail list logo