Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue42163>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
Indeed, it was unexpected that consumers of the `uname_result` were using
`_replace`. In fact, the focus of the tests is on ensuring that users are able
to access the items by index, e.g. `uname()[0]`.
It should be possible to support `_replace` on the
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21926
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Acknowledged. Thanks for the report. I'll likely address this issue alongside
the other (same PR).
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21945
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Please take a look at the PR. Let me know what you think about the limited
compatibility it adds (still doesn't allow _replace on 'processor').
--
___
Python tracker
<https://bugs.pyt
Jason R. Coombs added the comment:
New changeset c41559021213cfc9dc62a83fc63306b3bdc3e64b by MARUYAMA Norihiro in
branch 'master':
bpo-37193: remove thread objects which finished process its request (GH-13893)
https://github.com/python/cpython/commit/c41559021213cfc9dc62a83fc63306
Jason R. Coombs added the comment:
I recommend a rollback. I’ll try to get to it later today.
--
___
Python tracker
<https://bugs.python.org/issue37193>
___
___
Change by Jason R. Coombs :
--
pull_requests: +22024
pull_request: https://github.com/python/cpython/pull/23107
___
Python tracker
<https://bugs.python.org/issue37
Change by Jason R. Coombs :
--
pull_requests: +22043
pull_request: https://github.com/python/cpython/pull/23127
___
Python tracker
<https://bugs.python.org/issue37
New submission from Jason R. Coombs :
In issue37193, I'd worked on an implementation in which a thread reference
would be removed as the thread was closing, but this led to a memory leak
caught by the buildbots (https://bugs.python.org/issue37193#msg380172).
As I tracked down the issue
Jason R. Coombs added the comment:
I filed issue42263 to capture the underlying cause of the memory leak that led
to the buildbot failures and the rollback.
--
___
Python tracker
<https://bugs.python.org/issue37
Jason R. Coombs added the comment:
I don't think it's a race condition for two reasons: adding a `time.sleep(1)`
after `.start` still raises errors, and in issue37193, there were 10 threads
created, with at least 9 of those reaching termination before the test ended,
yet it
Jason R. Coombs added the comment:
Yes, I agree it's a duplicate of issue37788.
And yes, it does still leak if the list is never created or if the target is a
no-op.
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> fix for bpo
Change by Jason R. Coombs :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue37788>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
I marked bpo-42263 as a duplicate of this issue.
This issue is implicated in preventing the desired fix for bpo-37193, where a
thread wishes to remove the handle to itself after performing its duty. By
removing its own handle, it can never be joined, and
Jason R. Coombs added the comment:
Pedro - thanks for the detailed report. Pull requests against
importlib_metadata are easier to accept because they can be tested more easily,
released more rapidly, and there's a straightforward way to port them to
CPython. Regardless, I see y
Jason R. Coombs added the comment:
Yes - I keep both in sync.
--
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
If you wish for the functionality to be available in setuptools (backported),
please contribute the change at https://github.com/pypa/distutils. At some
point, contributions to CPython will also be synced there as well, and any
changes there get synced
Jason R. Coombs added the comment:
As I reviewed the PR, I do realize how tricky this change is going to be. In
addition to the three MSVC implementations in distutils, Setuptools has its own
(https://github.com/pypa/setuptools/blob/master/setuptools/msvc.py).
Interestingly, that file
Jason R. Coombs added the comment:
Yes. If I trust my message from earlier, this issue is resolved. Closing now.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
The MS support engineer has come back confirming the bug and suggesting using
the MS C API instead of wstat for doing directory detection. It's still
possible they'll fix the bug in an upcoming update, but even if they do, it
will leave a window
Changes by Jason R. Coombs :
--
keywords: +patch
Added file: http://bugs.python.org/file24229/f3c7f4243a04.diff
___
Python tracker
<http://bugs.python.org/issue6
Changes by Jason R. Coombs :
Added file: http://bugs.python.org/file24230/55d164f36389.diff
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bug
Changes by Jason R. Coombs :
Added file: http://bugs.python.org/file24231/577b717055bc.diff
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bug
Jason R. Coombs added the comment:
I've regenerated the diff a couple of times (once after rebasing to not undo
Amaury's changes and another after correcting the whitespace).
--
keywords: +needs review
___
Python tracker
<http://bu
Changes by Jason R. Coombs :
Added file: http://bugs.python.org/file24245/2b7bf4e5cb9f.diff
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bug
Changes by Jason R. Coombs :
Added file: http://bugs.python.org/file24246/1cdb64480494.diff
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bug
Jason R. Coombs added the comment:
I've created yet another patch (1cdb64480494) which adds a regression test
under Python 2.7 to demonstrate that the fix works (based on
test_import_symlink_package.py).
--
___
Python tracker
Jason R. Coombs added the comment:
I've created yet another patch (1cdb64480494) which adds a regression test
under Python 2.7 to demonstrate that the fix works (based on
test_import_symlink_package.py).
--
___
Python tracker
Jason R. Coombs added the comment:
While this may in fact be related to #6727, I don't believe it's a proper
duplicate. I believe there's a more fundamental issue that's causing both #6727
and #13412, and that's that stat/wstat is broken on Windows due to a regres
Changes by Jason R. Coombs :
--
hgrepos: +104
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Jason R. Coombs :
Added file: http://bugs.python.org/file24250/4aaf78f0dd10.diff
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bug
Jason R. Coombs added the comment:
4aaf78f0dd10.diff is the same patch as that for 2.7 but ported to 3.1.
--
___
Python tracker
<http://bugs.python.org/issue6
Changes by Jason R. Coombs :
--
hgrepos: +105
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Jason R. Coombs :
Added file: http://bugs.python.org/file24251/4fdbc9f74235.diff
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bug
Jason R. Coombs added the comment:
I ported the patch to the 3.2 branch. This port required more extensive
adjustments. In particular, the NullImporter no longer used (char *) for
directory detection, but instead used platform-specific PyObjects.
Therefore, the 3.2 diff creates a new
Jason R. Coombs added the comment:
After hearing back from Microsoft support (and by proxy, the Visual Studio
development team), it is clear that this issue is very low priority for them
(they see it as having trivial business impact), so we cannot expect it to be
fixed in the upstream
New submission from Jason R. Coombs :
The Python 2.7.2 docs say this about __import__:
Positive values for level indicate the number of parent directories to
search relative to the directory of the module calling __import__().
But I find that even when setting level=1, the parent
Jason R. Coombs added the comment:
Sorry for the mistake.
I corrected the pkgB package, but the result is the same:
jaraco@devjaraco:~$ tree master
master
├── __init__.py
├── __init__.pyc
├── pkgA
│ ├── foo.py
│ ├── foo.pyc
│ ├── __init__.py
Jason R. Coombs added the comment:
Thanks for the tip Brent. Still, no luck.
jaraco@devjaraco:~$ python2.7 -c 'import master.pkgA;
print("pkgA.__package__ is {}".format(master.pkgA.__package__)); import
master.pkgA.foo'
pkgA.__package__ is None
Traceback (m
New submission from Jason R. Coombs :
When using a MANIFEST.in with only "include *.txt", on Windows, distutils grabs
too many files. I set DISTUTILS_DEBUG=1 and ran ./setup.py sdist on the keyring
library and it included this output:
include *.txt
include_pattern: applyi
Changes by Jason R. Coombs :
--
components: +Windows
___
Python tracker
<http://bugs.python.org/issue14004>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
The bug is indeed fixed in the latest 2.7 tip:
PS C:\Users\jaraco\projects\public\keyring>
C:\Users\jaraco\projects\public\cpython\PCbuild\amd64\python.exe setup.py sdist
2> NULL | findstr .hg
(produces no
Jason R. Coombs added the comment:
If always using a posix path separator, I recommend using posixpath.join
instead of hard-coding the path separator.
--
___
Python tracker
<http://bugs.python.org/issue14
Jason R. Coombs added the comment:
It's not that I forgot to set DISTUTILS_DEBUG, I simply did not set it. If the
bug were still present, I would have seen a line indicating that
.hg/last-message.txt was being copied.
For completeness, here's the output with the DEBUG setting:
Changes by Jason R. Coombs :
--
hgrepos: -104
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
I've gone ahead and pushed the changesets for Python 2.7. I'll continue to hold
off on Python 3.2/3.3 until I can review. Perhaps Brian and I can review these
changes at PyCon.
--
___
Python trac
Jason R. Coombs added the comment:
I see that. Thanks. I'm on it.
--
___
Python tracker
<http://bugs.python.org/issue6727>
___
___
Python-bugs-list m
Jason R. Coombs added the comment:
The Unix tests are now passing again. Some Windows buildbots are failing
because they do not have the symlink privilege. I'll add a guard in the test to
not run it if it doesn't have privilege
Changes by Jason R. Coombs :
--
nosy: +jason.coombs
___
Python tracker
<http://bugs.python.org/issue14243>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Jason R. Coombs :
Summary of this thread:
http://mail.python.org/pipermail/python-dev/2012-March/118233.html
When upgrading a host from Python 2.6.7 to 2.6.8 or from 2.7.2 to 2.7.3,
virtualenvs will no longer work if they attempt to use os.urandom. I have not
yet
Changes by Jason R. Coombs :
--
versions: +Python 3.1 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue1>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
3.1 and 3.2 are affected as well.
--
___
Python tracker
<http://bugs.python.org/issue1>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
Martin makes a good point, but I see it somewhat differently.
virtualenv and its users have always accepted the risk of running an old
interpreter against a different standard library (of the same minor version).
So the risk of not receiving the security
Jason R. Coombs added the comment:
The consensus from the release managers seems to be "don't patch", so I propose
we move forward with including the release notes as drafted.
--
___
Python tracker
<http://bugs.pyt
Jason R. Coombs added the comment:
My mistake - Georg has not yet weighed in. Perhaps it's best to wait for his
opinion.
--
___
Python tracker
<http://bugs.python.org/is
Jason R. Coombs added the comment:
I agree. If the primary usage of the class does not work well on Windows,
developers will continue to write code using the primary usage because it works
on their unix system, and it will continue to cause failures when run on
windows. Because Python should
Jason R. Coombs added the comment:
For posterity, here's the release notes that we had drafted on the pirate pad:
Note: This patch release of Python may have compatibility implications for
environments utilizing the third-party virtualenv. For more detail see XXX.
[the note above is int
Jason R. Coombs added the comment:
I started trying to replicate the failure. I got as far as this Dockerfile:
```
FROM fedora:rawhide
RUN yum install -y clang make git
RUN git clone https://github.com/python/cpython
WORKDIR cpython
RUN ./configure
RUN make
```
And then running `./python
Jason R. Coombs added the comment:
New changeset c3738cfe63b1f2c1dc4a28d0ff9adb4e9e3aae1f by Jason R. Coombs
(Chih-Hsuan Yen) in branch 'master':
bpo-34632: fix installation of importlib.metadata (#13563)
https://github.com/python/cpython/commit/c3738cfe63b1f2c1dc4a28d0ff9adb
New submission from Jason R. Coombs :
As [reported here](https://bugs.python.org/issue34632#msg343445), I submitted a
pull request that passed all tests locally and in CI, but when accepted, build
bots started to fail as a result of new files having been added to the project.
It seems it&#
Change by Jason R. Coombs :
--
pull_requests: +13476
pull_request: https://github.com/python/cpython/pull/13566
___
Python tracker
<https://bugs.python.org/issue34
Jason R. Coombs added the comment:
> By the way, I think Python.framework is not needed?
Correct. That was an artifact that I unintentionally added.
I've submitted https://github.com/python/cpython/pull/13566 to address the two
concerns.
I've also opened issue37043 and
New submission from Jason R. Coombs :
When developing on macOS, after some build/test operations (I'm not sure
exactly which, but seemingly relating to a framework build), artifacts are
generated which aren't ignored. As a result, it's easy for them to leak into a
merge requ
Jason R. Coombs added the comment:
New changeset f7fba6cfb62edfc22e9b2e12a00ebaf5f348398e by Jason R. Coombs in
branch 'master':
bpo-34632 fix buildbots and remove artifact (GH-13566)
https://github.com/python/cpython/commit/f7fba6cfb62edfc22e9b2e12a00eba
Jason R. Coombs added the comment:
I believe buildbots are fixed. Please re-open if you find otherwise.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
In GH-13565, @yan12125 provides [this
reference](https://github.com/python/buildmaster-config/blob/master/master/custom/factories.py)
to the buildbot code that copies the code and thus imposes the requirement to
declare source directories
Jason R. Coombs added the comment:
> I've just locally ran sphinx 2.0.0 on 071cbd4ea1 (the current tip of your PR)
> and I'm not getting any error, which one are you getting?
The issue occurs on 2347d3ae36 with `make suspicious` with Sphinx 2.0.0 and
2.0.1.
```
Doc 2
Jason R. Coombs added the comment:
I imagine that importlib.metadata isn’t imported at bootstrap time, only after
the import infrastructure is ready. I think an early failure to import one of
those dependencies is desirable. What is the reasoning behind deferring the
imports and why does it
New submission from Jason R. Coombs :
A few years ago, Windows [announced more lenient support for creating symbolic
links](). This more lenient support requires the caller to pass a flag in the
API. Neither the blog post nor the API docs give any indication of why one
would not ever pass
Jason R. Coombs added the comment:
The missing reference above should be
https://blogs.windows.com/windowsdeveloper/2016/12/02/symlinks-windows-10/#iqm9GJhlyWhcM78e.97
--
___
Python tracker
<https://bugs.python.org/issue37
Jason R. Coombs added the comment:
I see looking at the code and docs now that this work was done for Python 3.8.
--
resolution: -> works for me
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Jason R. Coombs :
Originally reported in https://github.com/jaraco/zipp/issues/7, the parent of a
Path object referencing a directory is returning the incorrect result:
cpython master $ docker run -it python:rc-buster
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +14452
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14638
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset 38f44b4a4adc37e8f5f8971917d8b3145f351a56 by Jason R. Coombs in
branch 'master':
bpo-37520: Correct behavior for zipfile.Path.parent (GH-14638)
https://github.com/python/cpython/commit/38f44b4a4adc37e8f5f8971917d8b3
Jason R. Coombs added the comment:
New changeset 66905d14672517d50dc8ba516b9839f9ddbcc131 by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-37520: Correct behavior for zipfile.Path.parent (GH-14638) (GH-14641)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Jason R. Coombs :
Importlib_metadata 0.19 is about to release. Let's sync the code with that
milestone (https://gitlab.com/python-devs/importlib_metadata/-/milestones/20).
--
components: Library (Lib)
messages: 348581
nosy: barry, jaraco
priority: normal
sev
Jason R. Coombs added the comment:
I've started work on this in
https://github.com/jaraco/cpython/commit/ee913fd4b1cc3bb324f43bfebd4f1006f90c2b6e,
but two tests are failing:
==
FAIL: test_egg
Jason R. Coombs added the comment:
Okay, I think the issue was that I had failed to `make regen-importlib`. After
doing that, the tests are passing. PR incoming.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +14759
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14993
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset 049460da9c7b5f51732e2966195c44713af9dc4c by Jason R. Coombs in
branch 'master':
bpo-37697: Sync with importlib_metadata 0.19 (#14993)
https://github.com/python/cpython/commit/049460da9c7b5f51732e2966195c44
Jason R. Coombs added the comment:
New changeset f96334c17946683dd4fb5a84e86a7a4caa4b487d by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-37697: Sync with importlib_metadata 0.19 (GH-14993) (GH-14995)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
> Why is the code in `Lib/importlib/metadata/__init__.py`
Mainly because originally, the code was in multiple modules. I'm happy for it
to move into a single file module.
--
___
Python tracker
Jason R. Coombs added the comment:
Please do.
--
___
Python tracker
<https://bugs.python.org/issue37772>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue37772>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
> Is there a reason that requires() and files() return iterators instead of
> lists?
I'm a huge fan of `itertools` and Python 3's move to prefer iterables over
materialized lists, and I feel that forcing materialized results gives the
cal
Jason R. Coombs added the comment:
One consequence of this change is that now any string that has a backslash
needs to be escaped or raw, leading to changes like this on
(https://github.com/cherrypy/cherrypy/pull/1610/commits/1d8c03ea8c5fe90f29bbea267300b97c78391c24#diff
New submission from Jason R. Coombs:
Consider this script, which runs successfully on Python 3:
import cgitb
import sys
def fiter():
assert False
yield 1, 1
yield 2, 2
yield 3, 3
try:
x = set(id_ for id_, _ in fiter())
except:
print cgitb.html(sys.exc_info())
Run
Jason R. Coombs added the comment:
While investigating https://github.com/pypa/setuptools/issues/1062, I
discovered that the implementation in the attached patch is insufficient. The
'parse_config_files' calls ConfigParser.__init__ in two places, before the for
loop and at the e
Jason R. Coombs added the comment:
Ack. The interpolation behavior was also present in Python 2.7. I missed that
when I found this ticket and assumed it was similar to issue 20120. In this
ticket, the user is requesting that distutils actually change the behavior from
performing interpolation
Jason R. Coombs added the comment:
Given that it's a change in behavior and not a bugfix, I don't see how this
change could go into anything but the next release.
--
versions: -Python 2.7, Python 3.5, Python 3.6
___
Python trac
New submission from Jason R. Coombs:
Similar to #16180 and possible a duplicate of #14743, if the script being run
under pdb becomes invalid such as through a chdir operation, pdb will get
trapped in a loop, catching its own exception.
$ mkdir foo
$ cat > foo/script.py
import os
os.chdir(&
Jason R. Coombs added the comment:
Regarding other uses of .pth files, the project
[future-fstrings](https://github.com/asottile/future-fstrings) relies on .pth
files to enable its at-startup behavior.
I'm also +1 to remove .pth files, but I also believe it's not viable tod
Jason R. Coombs added the comment:
I don't think this ticket should be implemented as described.
Consider the use-case in importlib_metadata, which loads metadata from a
package, metadata known to be of a specified encoding. It already knows the
encoding and has decoded the full messa
New submission from Jason R. Coombs :
Originally [reported in
testing-cabal/mock#405](https://github.com/testing-cabal/mock/issues/405), I
believe I've discovered an inconsistency that manifests as a flaw:
`patch` and `patch.object` allow the target to be specified as string referrin
Jason R. Coombs added the comment:
I believe this issue is a duplicate of 17561, which I stumbled onto today.
--
resolution: -> duplicate
superseder: -> Add socket.create_server_sock() convenience function
___
Python tracker
Jason R. Coombs added the comment:
I do believe this issue is still important and relevant. See issue25667 for a
duplicate ticket (and references to implementations) and issue24209 for another
issue where this could have been applied.
--
nosy: +jason.coombs
versions: +Python 3.8
901 - 1000 of 1490 matches
Mail list logo
