[issue37837] add internal _PyLong_FromUnsignedChar() function

2019-08-24 Thread Greg Price
Greg Price added the comment: Oh also: * What compiler, and what compilation flags, are you using in your benchmarking? That seems relevant :) -- ___ Python tracker <https://bugs.python.org/issue37

[issue37837] add internal _PyLong_FromUnsignedChar() function

2019-08-24 Thread Greg Price
Greg Price added the comment: > Is there a particular reason to specifically call PyLong_FromSize_t? Seems > like PyLong_FromLong is the natural default (and what we default to in the > rest of the code), and it's what this ends up calling anyway. Ah I see, the patch is mean

[issue18236] str.isspace should use the Unicode White_Space property

2019-08-24 Thread Greg Price
Greg Price added the comment: > I've gone and made a patch for this change Update: * The preparatory changes in #37760 are now almost all merged; GH-15265 is the one piece remaining, and I'd be grateful for a review. It's a generally straightforward and boring change that

[issue37837] add internal _PyLong_FromUnsignedChar() function

2019-08-24 Thread Greg Price
Greg Price added the comment: Very interesting, thanks! It looks like with LTO enabled, this optimization has no effect at all. This change adds significant complexity, and it seems like the hoped-for payoff is entirely in terms of performance on rather narrowly-focused microbenchmarks

[issue37936] gitignore file is too broad

2019-08-26 Thread Greg Price
Change by Greg Price : -- pull_requests: +15219 pull_request: https://github.com/python/cpython/pull/15542 ___ Python tracker <https://bugs.python.org/issue37

[issue37936] gitignore file is too broad

2019-08-26 Thread Greg Price
Greg Price added the comment: > I have a minimal fix which takes care of all the files above. I'll post that > shortly, and I may also write up a more thorough fix that tries to make it > easy not to fall into the same Git pitfall again. Both now done. * GH-15451 is that minim

[issue37966] is_normalized is much slower than the standard's algorithm

2019-08-27 Thread Greg Price
New submission from Greg Price : In 3.8 we add a new function `unicodedata.is_normalized`. The result is equivalent to `str == unicodedata.normalize(form, str)`, but the implementation uses a version of the "quick check" algorithm from UAX #15 as an optimization to try to avoid

[issue37966] is_normalized is much slower than the standard's algorithm

2019-08-27 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +15231 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15558 ___ Python tracker <https://bugs.python.org/issu

[issue37966] is_normalized is much slower at "no" than the standard's algorithm

2019-08-27 Thread Greg Price
Greg Price added the comment: Fix posted, as GH-15558. Adding cc's for the folks in the thread on #32285, where this function was originally added. -- components: +Unicode nosy: +Maxime Belanger, benjamin.peterson, ezio.melotti, steven.daprano, vstinner title: is_normalized is

[issue6331] Add unicode script info to the unicode database

2019-08-27 Thread Greg Price
Change by Greg Price : -- nosy: +Greg Price ___ Python tracker <https://bugs.python.org/issue6331> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37837] add internal _PyLong_FromUnsignedChar() function

2019-08-27 Thread Greg Price
Greg Price added the comment: Ah OK, that makes sense of it then :) > But the most important thing is that using PyLong_FromUnsignedLong() instead > of _PyLong_FromUnsignedChar() on top of GH-15192 is producing the same > results: striter_next() uses small_ints[] directly. Howev

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
New submission from Greg Price : Benjamin noticed in reviewing GH-15558 (for #37966) several points where the existing code around Unicode normalization can be improved: * on the `QuickcheckResult` enum: > Maybe `makeunicodedata.py` should output this enum (with better name namespac

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +15366 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15711 ___ Python tracker <https://bugs.python.org/issu

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
Change by Greg Price : -- pull_requests: +15367 pull_request: https://github.com/python/cpython/pull/15712 ___ Python tracker <https://bugs.python.org/issue38

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
Change by Greg Price : -- pull_requests: +15368 pull_request: https://github.com/python/cpython/pull/15558 ___ Python tracker <https://bugs.python.org/issue38

[issue38015] inline function generates slightly inefficient machine code

2019-09-08 Thread Greg Price
Greg Price added the comment: (Just to help keep discussions together: some earlier discussion was on GH-15216 .) Because is_small_int / IS_SMALL_INT is so small, there's not much cost in the source code to making it a macro (as GH-15710 did). But I think it'd be a mistake t

[issue38079] _PyObject_VAR_SIZE should avoid arithmetic overflow

2019-09-09 Thread Greg Price
New submission from Greg Price : Currently `_PyObject_VAR_SIZE` effectively has a precondition that it must not be passed arguments which would overflow in its arithmetic. If that's violated, it overflows... which is undefined behavior already, and in fact the likely next thing that ha

[issue38079] _PyObject_VAR_SIZE should avoid arithmetic overflow

2019-09-09 Thread Greg Price
Greg Price added the comment: (The tracker just linked GH-14838 to this issue because I mentioned it in a comment there, but it's not for this issue -- it's that recent fix for an 11-year-old bug in a callsite's overflow check.) -- ___

[issue37936] gitignore file is too broad

2019-09-10 Thread Greg Price
Change by Greg Price : -- pull_requests: +15472 pull_request: https://github.com/python/cpython/pull/15823 ___ Python tracker <https://bugs.python.org/issue37

[issue37936] gitignore file is too broad

2019-09-10 Thread Greg Price
Greg Price added the comment: Thanks @zach.ware for the review and merge of GH-15451! That was the "minimal" fix, fixing rules that apply to files we have in the repo now. So `rg` will no longer ignore `PC/pyconfig.h`. :-) I've just sent GH-15823 with the "more thorough

[issue27970] ssl: can't verify a trusted site with imcomplete certificate chain

2019-09-17 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker <https://bugs.python.org/issue27970> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Greg Price
Greg Price added the comment: Thanks Victor for linking that issue back here. > A first change converted a macro to a static inline function. The second > change converted the static inline fnuction to a macro Not quite. The first change converted a macro `CHECK_SMALL_INT` to an equi

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Greg Price
Greg Price added the comment: > if using a static inline function is causing issues Separately from whether there was or wasn't such an issue here, I think it's interesting to note that the build failure bpo-38205 is an example of exactly the opposite! It was caused by a comb

[issue38015] inline function generates slightly inefficient machine code

2019-09-17 Thread Greg Price
Greg Price added the comment: See followup at https://bugs.python.org/issue38205 and https://bugs.python.org/issue37812#msg352670 . The patch in GH-15710 had a side effect of introducing a call to `Py_UNREACHABLE` inside a comma-expression. A subsequent commit 3ab61473b changed

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Greg Price
Greg Price added the comment: > We're wasted a lot of dev time on something that never promised much value in > the first place. So, I'll revert and close this tracker issue OK, so be it. I'll certainly agree that this series of threads consumed a lot more time than I

[issue18236] str.isspace should use the Unicode White_Space property

2019-09-17 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +15849 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16254 ___ Python tracker <https://bugs.python.org/issu

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-09-17 Thread Greg Price
Greg Price added the comment: Thanks Benjamin for reviewing and merging this series! -- ___ Python tracker <https://bugs.python.org/issue37760> ___ ___ Pytho

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-19 Thread Greg Price
Greg Price added the comment: I hesitate to come back to this thread, because as Raymond says it's consumed a lot of time already. But I think this point is of broader interest than the specific few lines we've been discussing: > When small integer are disabled at com

[issue16684] Unicode property value abbreviated names and long names

2019-09-20 Thread Greg Price
Greg Price added the comment: I've gone and implemented a version of this that's integrated into Tools/unicode/makeunicodedata.py , and into the unicodedata module. Patch attached. Demo: >>> import unicodedata, pprint >>> pprint.pprint(unicodedata.property_va

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-20 Thread Greg Price
Greg Price added the comment: > labeling long-stable code as "evil". Let me apologize about this bit -- I was thinking of the term in quotes (referring to the earlier comment), but I didn't write it clearly that way. I don't think any of this code is evil, past o

[issue43497] SyntaxWarning for "assertion is always true, perhaps remove parentheses?" does not work with constants

2021-03-15 Thread Greg Darke
New submission from Greg Darke : The following block of code does not produce a SyntaxWarning in python 3.7 and above (it does produce a warning in python 3.6 and below): ``` assert(False, 'msg') ``` If the tuple is not a constant (for example `(x, 'msg')`), then a warnin

[issue43497] SyntaxWarning for "assertion is always true, perhaps remove parentheses?" does not work with constants

2021-03-15 Thread Greg Darke
Change by Greg Darke : -- keywords: +patch pull_requests: +23629 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24867 ___ Python tracker <https://bugs.python.org/issu

[issue43497] SyntaxWarning for "assertion is always true, perhaps remove parentheses?" does not work with constants

2021-03-15 Thread Greg Darke
Greg Darke added the comment: I would argue that there is none (especially if it is tuple/something that is always true) -- thus why I would assume that Python would provide a warning. This bug comes from a discussion I was having with someone earlier today where they mentioned that it

[issue43497] SyntaxWarning for "assertion is always true, perhaps remove parentheses?" does not work with constants

2021-03-16 Thread Greg Darke
Change by Greg Darke : -- resolution: -> fixed ___ Python tracker <https://bugs.python.org/issue43497> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue43350] [sqlite3] Active statements are reset twice in _pysqlite_query_execute()

2021-05-10 Thread Greg Stein
Change by Greg Stein : -- nosy: +gstein nosy_count: 3.0 -> 4.0 pull_requests: +24667 pull_request: https://github.com/python/cpython/pull/26015 ___ Python tracker <https://bugs.python.org/issu

[issue42514] Relocatable framework for macOS

2021-06-23 Thread Greg Neagle
Greg Neagle added the comment: While checking this issue hoping there might be updates, I realized that I didn't share a link to the script I use to convert python.org's Python framework into one that can be relocated. It's here: https://github.com/gregneagle/rel

[issue45027] Allow basicConfig to configure any logger, not just root

2021-08-26 Thread Greg Werbin
New submission from Greg Werbin : Hello all! I am proposing to add a "logger=" kwarg to logging.basicConfig(), which would cause the configuration to be applied to the specified logger. The value of this parameter could be a string or a logging.Logger object. Omitting logger=

[issue45027] Allow basicConfig to configure any logger, not just root

2021-08-27 Thread Greg Werbin
Change by Greg Werbin : -- keywords: +patch pull_requests: +26452 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28010 ___ Python tracker <https://bugs.python.org/issu

[issue45086] f-string unmatched ']'

2021-09-02 Thread Greg Kuhn
New submission from Greg Kuhn : Hi All, Is the below a bug? Shouldn't the interpreter be complaining about a curly brace? $ python Python 3.8.5 (tags/v3.8.5:580fbb0, Jul 20 2020, 15:43:08) [MSC v.1926 32 bit (Intel)] on win32 Type "help", "copyright", "

[issue45086] f-string unmatched ']'

2021-09-02 Thread Greg Kuhn
Greg Kuhn added the comment: But doesn't the square bracket have no relevance here? It's not within a curly bracketed string so shouldn't be treated specially. I would have expected the error to be: SyntaxError: f-string: unmatched '}'. Unless I need to

[issue45086] f-string unmatched ']'

2021-09-04 Thread Greg Kuhn
Greg Kuhn added the comment: I see, thank you all for the detailed investigation and explanation!! Agreed Terry, anyone who reads the error should be able to parse it themselves and see what the errors is. Pointing the user to the error site is the most important piece

[issue45027] Allow basicConfig to configure any logger, not just root

2021-09-14 Thread Greg Werbin
Greg Werbin added the comment: Hi, thanks for the comment. > First of all, library developers should not be configuring loggers at all, > other than adding a NullHandler to their top-level logger. This is true, and I agree. I am not expecting people to start using basicConfig()

[issue45027] Allow basicConfig to configure any logger, not just root

2021-09-17 Thread Greg Werbin
Greg Werbin added the comment: > Users certainly don't need an API change to prevent that, should they wish > to. The following simple call will suffice (using 'gnupg' just as an example): > > logging.getLogger('gnupg').setLevel(logging.CRITICAL + 1)

[issue40350] modulefinder chokes on numpy - dereferencing None in spec.loader

2020-04-21 Thread Greg Whiteley
New submission from Greg Whiteley : Issue: Running ModuleFinder.run_script() on numpy versions 1.16.1 to 1.18.3 (maybe more) fails with backtrace. See steps to reproduce below. I do not see this problem on earlier versions of python than 3.8 (tested 3.4, 3.5, 3.6 on ubuntu LTSs), but the

[issue42514] Relocatable framework for macOS

2020-11-30 Thread Greg Neagle
New submission from Greg Neagle : The current Python.framework installed by the macOS packages is hard-coded to /Library/Frameworks/Python.framework and breaks if renamed or moved. A relocatable framework would allow users/admins/developers to install a specific framework to an alternate

[issue42514] Relocatable framework for macOS

2020-11-30 Thread Greg Neagle
Greg Neagle added the comment: A Python.app you could drop somewhere convenient would by definition need a relocatable Python.framework within. :-) -- ___ Python tracker <https://bugs.python.org/issue42

[issue38227] Setting a signal handler gets multiprocessing.Pool stuck

2020-07-19 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker <https://bugs.python.org/issue38227> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1524081] logging using the SysLog handler fails if locale is set

2020-08-17 Thread Greg Price
Greg Price added the comment: For the record because this issue is mentioned in a comment in logging/handlers.py and people are sometimes confused by it today: > This happens because in that particular locale, > "INFO".lower() != "info" Since Python 3, this no

[issue20468] resource module documentation is incorrect

2020-09-09 Thread Greg Lindahl
Greg Lindahl added the comment: I just tripped on the bug that the maxrss field is kilobytes on Linux and bytes on Darwin. I don't think referring to the C manpages is sufficient to prevent confusion. I don't actually use my package on a Mac, I just use Travis-CI

[issue33762] temp file isn't IOBase

2019-06-04 Thread Greg Lindahl
Greg Lindahl added the comment: This is breaking aiohttp client file multipart uploads from temporary files. I'd be willing to bet that a lot of libraries do isinstance(foo, io.IOBase) deep in their guts. -- nosy: +wumpus ___ Python tr

[issue36502] str.isspace() for U+00A0 and U+202F differs from document

2019-08-03 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +14836 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15019 ___ Python tracker <https://bugs.python.org/issu

[issue36502] str.isspace() for U+00A0 and U+202F differs from document

2019-08-03 Thread Greg Price
Greg Price added the comment: The actual behavior turns out to match that comment. See attached PR, which adds a test confirming that and also corrects the documentation. (A related issue is #18236 -- we should probably adjust the definition to match the one Unicode now provides. But

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

2019-08-04 Thread Greg Price
New submission from Greg Price : The unicodedata module has two test cases which run through the database and make a hash of its visible outputs for all codepoints, comparing the hash against a checksum. These are helpful regression tests for making sure the behavior isn't chang

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

2019-08-04 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +14865 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15125 ___ Python tracker <https://bugs.python.org/issu

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

2019-08-04 Thread Greg Price
Change by Greg Price : -- pull_requests: +14866 pull_request: https://github.com/python/cpython/pull/15126 ___ Python tracker <https://bugs.python.org/issue37

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

2019-08-04 Thread Greg Price
Greg Price added the comment: Sent two small PRs! The first one, GH-15125, makes the substantive test change I described above. The second one, GH-15126, is a small pure refactor to that test file, just cleaning out some bits that made sense when it was first written (as a script) but are

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-04 Thread Greg Price
New submission from Greg Price : I spent some time yesterday on #18236, and I have a patch for it. Most of that work happens in the script Tools/unicode/makeunicode.py , and along the way I made several changes there that I found made it somewhat nicer to work on, and I think will help other

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-04 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +14868 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15128 ___ Python tracker <https://bugs.python.org/issu

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-04 Thread Greg Price
Change by Greg Price : -- pull_requests: +14869 pull_request: https://github.com/python/cpython/pull/15129 ___ Python tracker <https://bugs.python.org/issue37

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-04 Thread Greg Price
Change by Greg Price : -- pull_requests: +14870 pull_request: https://github.com/python/cpython/pull/15130 ___ Python tracker <https://bugs.python.org/issue37

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-04 Thread Greg Price
Greg Price added the comment: Just posted three PRs: * GH-15128 and GH-15129 are both quite small * GH-15130 is the first of two patches factoring out common parsing logic. Two remaining patches go on top of GH-15130. Here are drafts, in case they're helpful for reference: * Patc

[issue18236] str.isspace should use the Unicode White_Space property

2019-08-07 Thread Greg Price
Greg Price added the comment: I've gone and made a patch for this change: https://github.com/gnprice/cpython/commit/7dab9d879 Most of the work happens in the script Tools/unicode/makeunicode.py , and along the way I made several changes there that I found made it somewhat nicer to wo

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-07 Thread Greg Price
Change by Greg Price : -- pull_requests: +14903 pull_request: https://github.com/python/cpython/pull/15171 ___ Python tracker <https://bugs.python.org/issue37

[issue18236] str.isspace should use the Unicode White_Space property

2019-08-08 Thread Greg Price
Greg Price added the comment: Good question! With the patch: >>> import re >>> re.match(r'\s', '\x1e') >>> In other words, the definition of the regexp r'\s' follows along. Good to know. -- ___

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-10 Thread Greg Price
New submission from Greg Price : In longobject.c we have the following usage a few times: PyObject * PyLong_FromLong(long ival) { PyLongObject *v; // ... more locals ... CHECK_SMALL_INT(ival); if (ival < 0) { /* negate: can't write this as abs_ival = -ival si

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-10 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +14932 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15203 ___ Python tracker <https://bugs.python.org/issu

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-10 Thread Greg Price
Greg Price added the comment: I've just sent GH-15203 which is the first of two patches for this. It's quite small. The second patch, which completes the change, is also small: https://github.com/gnprice/cpython/commit/c6b905104 It depends on the first one, so I think the easiest

[issue37802] micro-optimization of PyLong_FromSize_t()

2019-08-10 Thread Greg Price
Change by Greg Price : -- nosy: +Greg Price ___ Python tracker <https://bugs.python.org/issue37802> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-11 Thread Greg Price
Greg Price added the comment: > Sometimes for testing we turn it off in order to identify identity test bugs. Interesting! Well, if the option is useful for testing, that's certainly a good reason to keep it. > Also, eveonline was controlling this to save memory. Also interest

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-11 Thread Greg Price
Change by Greg Price : -- pull_requests: +14944 pull_request: https://github.com/python/cpython/pull/15216 ___ Python tracker <https://bugs.python.org/issue37

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-11 Thread Greg Price
Greg Price added the comment: > On the other hand, if it is tricky and requires something more than minor > surgery, that would be a hint that it isn't worth it. There is some value in > code that is stable and known to be working just fine. Definitely true! I think this cha

[issue35756] Using `return value` in a generator function skips the returned value on for-loop iteration

2019-01-17 Thread Greg Ewing
Greg Ewing added the comment: There is no bug here; the current implementation is working as intended. The word "yields" in the quoted section of the PEP indeed refers to the "yield" keyword and nothing else. Possibly that could be clarified, but I believe it's

[issue35756] Using `return value` in a generator function skips the returned value on for-loop iteration

2019-01-18 Thread Greg Ewing
Greg Ewing added the comment: bryan.koch wrote: > It would be awesome if invoking a generator above would throw a > SyntaxError iff it contained a return and it wasn't invoked through `yield > from`. Why do you care about that so much? There's nothing to stop you from

[issue30147] change in interface for compiled regex.pattern

2017-04-23 Thread Greg Lindahl
New submission from Greg Lindahl: The following script runs fine in python 3.6 and recently started failing the assertion in 3.7-dev and nightly import re r = re.compile(re.escape('/foo')) print(r) print(r.pattern) assert r.pattern.startswith('\\/') -- components:

[issue36470] dataclasses replace raises an exception with an empty

2019-03-29 Thread Greg Kuhn
New submission from Greg Kuhn : I have a snippet below which runs fine on python 3.7.0 but raises a ValueError exception on 3.7.1. I believe it's related to https://bugs.python.org/issue33805. The error: c:\python\lib\dataclasses.py:1219: ValueError The script: from dataclasses i

[issue36470] dataclasses.replace raises an exception if InitVar with default argument is not provided.

2019-03-29 Thread Greg Kuhn
Greg Kuhn added the comment: Fixed title -- title: dataclasses replace raises an exception with an empty -> dataclasses.replace raises an exception if InitVar with default argument is not provided. ___ Python tracker <https://bugs.pyth

[issue36590] Add Bluetooth RFCOMM Support for Windows

2019-04-10 Thread Greg Bowser
New submission from Greg Bowser : socketmodule supports Bluetooth RFCOMM sockets for Linux. Given that winsock supports this under windows, it is possible to add windows support as well. -- components: IO, Windows messages: 339888 nosy: Greg Bowser, paul.moore, steve.dower, tim.golden

[issue31096] asyncio.stream.FlowControlMixin._drain_helper may lead to a blocking behavior

2018-01-11 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker <https://bugs.python.org/issue31096> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32600] SpooledTemporaryFile should implement IOBase

2018-01-19 Thread Greg Matous
New submission from Greg Matous : SpooledTemporaryFile returns alternately a buffer or a TemporaryFile(). In either case it should behave like a file-thing. However it doesn't implement certain properties in IOBase like readable, seekable which seems like should be available. for exampl

[issue4356] Add "key" argument to "bisect" module functions

2018-01-21 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker <https://bugs.python.org/issue4356> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12735] request full Unicode collation support in std python library

2018-01-21 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker <https://bugs.python.org/issue12735> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17305] IDNA2008 encoding missing

2018-01-27 Thread Greg Lindahl
Greg Lindahl added the comment: I am avoiding Python's built-in libraries as much as possible in my aiohttp-based crawler because of this issue, but I cannot open a connection to https://xn--ho-hia.de because there is an 'IDNA does not round-trip' raise in the python 3.6 libr

[issue28414] SSL match_hostname fails for internationalized domain names

2018-01-28 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker <https://bugs.python.org/issue28414> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16733] Solaris ctypes_test failures

2018-05-08 Thread Greg Onufer
Greg Onufer added the comment: The bitfields failures are due to Python not implementing bitfields the same as the compiler. https://docs.oracle.com/cd/E77782_01/html/E77792/gqexw.html "Signed and Unsigned int Bit-fields Bit-fields which are declared as int (not signed int or unsigne

[issue16733] Solaris ctypes_test failures

2018-05-09 Thread Greg Onufer
Greg Onufer added the comment: Or probably just change the type of the bitfield from "int" to "signed int"! -- ___ Python tracker <https://bug

[issue29095] Compiling Python 3.6 from source on MacOS X Sierra

2017-10-05 Thread Greg Couch
Greg Couch added the comment: The problem with compiling OpenSSL from source is that it doesn't know how to access the root certificates needed for verification on Mac OS X. See issue17128 for more details. -- nosy: +gregcouch ___ Python tr

[issue17305] IDNA2008 encoding missing

2017-12-28 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker <https://bugs.python.org/issue17305> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33693] test test_webbrowser failed

2018-05-30 Thread Greg Walters
New submission from Greg Walters : Python 3.70b4 Linux Mint 18.3 Dell Latitude-E5500 While running make test got the following error... == ERROR: test_get (test.test_webbrowser.ImportTest

[issue33693] test test_webbrowser failed

2018-05-30 Thread Greg Walters
Greg Walters added the comment: Thank you. On Wed, May 30, 2018 at 6:22 AM, STINNER Victor wrote: > > STINNER Victor added the comment: > > It seems to be a regression caused by bpo-24241. > > -- > nosy: +vstinner > > _

[issue33693] test test_webbrowser failed

2018-05-30 Thread Greg Walters
Greg Walters added the comment: Thank you On Wed, May 30, 2018, 6:28 AM Martin Panter wrote: > > Martin Panter added the comment: > > This sounds like the existing bug Issue 31014 > > -- > nosy: +martin.panter > superseder: -> webbrowser._synthesize uses

[issue4508] distutils compiler not handling spaces in path to output/src files

2018-08-12 Thread Greg Toombs
Greg Toombs added the comment: Confirmed still broken in 3.6.3. I ran into this when running CFFI. It does very wrong things with the path to cl.exe and include files with path spaces. My workaround is to monkeypatch distutils.ccompiler.gen_preprocess_options such that include paths are

[issue14766] Non-naive time comparison throws naive time error

2012-05-10 Thread Greg Weller
Greg Weller added the comment: I think this is a documentation bug. The criteria for datetime and time objects being aware are slightly different. A datetime object d is aware if d.tzinfo.utcoffset(d) does not return None, while a time object t is aware if t.tzinfo.utcoffset(None) does not

[issue14766] Non-naive time comparison throws naive time error

2012-05-10 Thread Greg Weller
Greg Weller added the comment: I agree that the language in the quoted paragraph makes it sound as if any object with a non-None tzinfo is aware, which isn't the case. I've changed the first couple sentences to, I think, better reflect what characterizes an object as b

[issue11176] give more meaningful argument names in argparse documentation

2012-07-07 Thread Greg Roodt
Greg Roodt added the comment: Is this still an issue? If so, I've created a simpler first example as suggested below. If we decide these docs still need a bit more work, I can also continue to provide better examples than the "foo bar" ones. -- keywords: +patch nosy

[issue15183] it should be made clear that the statement in the --setup option and the setup kw arg aren't included in the count

2012-07-07 Thread Greg Roodt
Greg Roodt added the comment: Confirmed that the setup statement is correctly excluded from the overall timed run. I've updated the docstring and rst to make this clearer. -- keywords: +patch nosy: +groodt Added file: http://bugs.python.org/file26288/timeit_setup_clarification

[issue8823] urllib2 does not catch httplib.BadStatusLine

2012-07-07 Thread Greg Roodt
Greg Roodt added the comment: I've made a small change to urllib2 to catch the httplib.BadStatusLine and raise as URLError. This exception should rarely happen as it means the server is returning invalid responses. Nevertheless, I've added a test and hopefully fixed the issue.

[issue5815] locale.getdefaultlocale() missing corner case

2012-07-07 Thread Greg Roodt
Greg Roodt added the comment: Bumping this as part of a bug scrub at EuroPython. Is this still an issue? Should we fix in docs or in code? -- nosy: +groodt ___ Python tracker <http://bugs.python.org/issue5

[issue5931] Python runtime name hardcoded in wsgiref.simple_server

2012-07-07 Thread Greg Roodt
Greg Roodt added the comment: Bumping as part of bug scrub at EuroPython. Patch seems sensible to me. Obvious options to me are to either accept patch, close bug or write docs. Bug has not seen activity in years, so can probably be closed. -- nosy: +groodt

[issue1076515] shutil.move clobbers read-only files.

2012-07-07 Thread Greg Roodt
Greg Roodt added the comment: I believe this can be closed. shutil.copyfile attempts to copy file contents from src to dst, so it makes sense for this to fail if dst is read-only. shutil.move replaces the dst, which is permitted based on directory permissions. -- nosy: +groodt

[issue11176] give more meaningful argument names in argparse documentation

2012-07-09 Thread Greg Roodt
Greg Roodt added the comment: Hi David Ok, I like the idea of working on a solution together. I like your idea of the pizza-making more than the current "foo bar" examples. Should we collaborate outside of the bug tracker? Greg On 9 July 2012 07:11, David Lam wrote: > >

<    1   2   3   4   >