Changes by Demian Brecht :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue22931>
___
___
Python-bugs-list mai
Changes by Demian Brecht :
Added file: http://bugs.python.org/file38773/issue22931_2.patch
___
Python tracker
<http://bugs.python.org/issue22931>
___
___
Python-bug
Demian Brecht added the comment:
Agreed. However, I'm wondering if that should belong in a new issue geared
towards further clarifying behaviour of request body types. The patch
introduces the behaviour this specific issue was looking, with the largest
change being that iterators ma
Changes by Demian Brecht :
Added file: http://bugs.python.org/file38797/issue12319_5.patch
___
Python tracker
<http://bugs.python.org/issue12319>
___
___
Python-bug
Changes by Demian Brecht :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue3566>
___
___
Python-bugs-list mai
Demian Brecht added the comment:
Thanks for the report and follow up Vova. I've come across this line and it
puzzled me as well as to why it's hardcoded. Rather than the hardcoded approach
in your patch, I've attached a patch that uses _http_vsn_str which is
consistent with oth
Demian Brecht added the comment:
This doesn't seem to be an issue in 3.4+, the following headers are injected in
a call to urlopen():
GET / HTTP/1.1
Accept-Encoding: identity
Host: example.com
User-Agent: Python-urllib/3.4
Connection: close
However, this is not the same behaviour in 2.7:
Demian Brecht added the comment:
+1 to the adding the support for HTTP/2. I would personally like to see a few
things happen before that though (which I've been putting some effort into as i
can)
+ refactor http.client to cleanly separate transport from application protocol
level
+ f
Demian Brecht added the comment:
@Cory: my own plan was to use your implementation as the baseline and add
server support. If you take a crack at it that would be great!
--
___
Python tracker
<http://bugs.python.org/issue23
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue23888>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
A test really should be added for this. Otherwise, LGTM.
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue23
Demian Brecht added the comment:
> I think it's ok to slightly break a non-public API since it's required to fix
> an obvious bug.
To play devil's advocate here, /is/ this really non-public API? According to
documented Python naming conventions, HTTPResponse is part of
Demian Brecht added the comment:
Vincent: The logic to determine content length is undergoing a bit of an
overhaul as part of #12319, which I'm hoping to wrap up in the next week or so.
--
___
Python tracker
<http://bugs.python.org/is
Demian Brecht added the comment:
Although it's likely not going to be a high frequency issue (but would be
painful to track down when it does become an issue), by doing an
int(float(expires)), you're losing the sub-second portion of the expiry. Why
not something like this:
try:
Demian Brecht added the comment:
Changing to "behavior" type as crash is generally used to indicate an
interpreter issue.
--
nosy: +orsenthil
stage: -> patch review
type: crash -> behavior
___
Python tracker
<http://bugs.py
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue23930>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Demian Brecht:
There's a feature available via nose that might be nice to have in unittest:
package-level setup and teardown functions.
Using nose, I can define a setUpModule() method in a test package's __init__.py
and it will execute it during the test ru
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue13567>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Thanks for the follow up on that. In light of your findings, I agree with the
path you've taken in your patch (and yeah, you'd have to deal with conversions
in the output if you were to take my suggestion). I've left a couple minor
comments in
Demian Brecht added the comment:
I left a small comment around indentation in Rietveld.
Also, for the sake of completeness (and for others taking part in this
review/commit), I dug through the relevant RFCs and none of them seem to define
time as having sub-section resolution
Demian Brecht added the comment:
LGTM, thanks for the patch!
--
nosy: +r.david.murray
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue17849>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Demian Brecht:
http_proxy and https_proxy are common environment variables used cross
platform. Currently, urllib.request has support for it, but http.client does
not. It probably should.
If support is added to http.client, the handling of proxy environment variables
in
Demian Brecht added the comment:
If nobody else gets to it first, I'll try to get to review this later today or
tomorrow. Apologies for the delay on the review Martin, a new baby (coming next
month), moving /and/ taking on a new job all at the same time seems to limit
free time a l
Demian Brecht added the comment:
> What's the status on this one? It looks like some review comments need
> addressing.
That's about it. Unfortunately I've been pretty tied up over the last month and
a bit. I'll try to get to hopefully closing this
Demian Brecht added the comment:
> This needs a review from the people who created and applied the security
> patch.
+ Guido (committed https://hg.python.org/cpython/rev/9e765e65e5cb)
--
nosy: +gvanrossum
___
Python tracker
<http://bugs.p
Demian Brecht added the comment:
Added comments to Rietveld.
--
___
Python tracker
<http://bugs.python.org/issue23377>
___
___
Python-bugs-list mailing list
Unsub
Demian Brecht added the comment:
Latest patch should address all outstanding comments.
--
Added file: http://bugs.python.org/file39447/issue12319_6.patch
___
Python tracker
<http://bugs.python.org/issue12
Demian Brecht added the comment:
BTW, thanks for the reviews Martin and the nudge Antoine!
--
___
Python tracker
<http://bugs.python.org/issue12319>
___
___
Pytho
New submission from Demian Brecht:
Far too many times have I wished that changing the logging output in
http.client was controllable through logging configuration rather than code
changes modifying a connection's debuglevel.
It would be nice if the http package was brought up to date an
Demian Brecht added the comment:
Thanks for the report Rolf. I'll look into your suggestion for this patch.
Antoine: Given beta is slated for the 24th and Martin's legitimate concerns, I
think it might be a little hasty to get this in before feature freeze. Knocking
it back to 3.6
Changes by Demian Brecht :
--
keywords: +easy
___
Python tracker
<http://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
FWIW, I was intending to address the issues Rolf raised. Also, I agree that a
patch shouldn't knowingly have negative knock-on effects to dependents.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue24209>
___
___
Python-bugs-list mailing list
Unsubscribe:
401 - 434 of 434 matches
Mail list logo
