Chris Jerdonek added the comment:
It still seems like things could be made more DRY. Also, the pattern of having
assert_unix_browser() execute various function blocks depending on whether
various arguments are not None doesn't seem as clean or scalable as it should
be (e.g. if the numb
Chris Jerdonek added the comment:
> Please remove the "... " prompt from the example so that the code is
> cut-and-pasteable by people who want to experiment with the example.
That is the usual format for docstring examples. See, for example--
http://docs.python.org/dev/libr
Chris Jerdonek added the comment:
Thanks, Anton. It is looking a lot better now. I still have comments, but
because my comments have not been on the substance of the patch and because I
am not a core developer, I will defer to others at this point
Chris Jerdonek added the comment:
Thanks a lot, Andrew.
--
___
Python tracker
<http://bugs.python.org/issue15624>
___
___
Python-bugs-list mailing list
Unsub
Chris Jerdonek added the comment:
Yes, that too. :) I am working on it.
--
___
Python tracker
<http://bugs.python.org/issue15561>
___
___
Python-bugs-list mailin
Chris Jerdonek added the comment:
I think it can be useful for testing reasons (e.g. testing that os.linesep is
respected by certain code).
--
___
Python tracker
<http://bugs.python.org/issue15
New submission from Chris Jerdonek:
The io.TextIOWrapper documentation says that the write_through argument was
added in version 3.3:
"Changed in version 3.3: The write_through argument has been added."
http://docs.python.org/dev/library/io.html#io.TextIOWrapper
However, it s
Chris Jerdonek added the comment:
For 3.2 to mention write_through, issue 15638 should probably be fixed first.
I can create a patch for that first.
--
dependencies: +incorrect version info for TextIOWrapper write_through docs
___
Python tracker
Changes by Chris Jerdonek :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue15595>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
The C version seems to have it in 3.2 as well:
http://hg.python.org/cpython/file/5b629e9fde61/Modules/_io/textio.c#l818
Is it possible you were thinking of issue 15571 (not "used" in Python version
but still
Chris Jerdonek added the comment:
> As I can see in subprocess.py TextIOWrapper is applied to stdin also in
> non-buffered (write_through=True) mode.
In 3.2, I will not mention the write_through argument based on Antoine's
response to
Chris Jerdonek added the comment:
Ah, thank you. I see.
--
___
Python tracker
<http://bugs.python.org/issue15638>
___
___
Python-bugs-list mailing list
Unsub
Chris Jerdonek added the comment:
> From my perspective input should be encoded (converted to bytes) if it is str
> regardless of universal_newlines value.
I don't know the reason, but the limitation is documented:
"The optional input argument should be data to be sent to t
Chris Jerdonek added the comment:
Andrew, here is the new patch for 3.2. 3.3 will come shortly after.
--
Added file: http://bugs.python.org/file26783/issue-15561-3-branch-32.patch
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Here is the patch for the default/3.3 branch, which for convenience is a diff
for the branch *after the 3.2 patch has been forward-ported to 3.3*.
I did not think it was necessary to mention write_through specifically since it
seems more like an
Chris Jerdonek added the comment:
This issue may be the bug referenced here:
# BUG: can't give a non-empty stdin because it breaks both the
# select- and poll-based communicate() implementations.
(stdout, stderr) = p.communicate()
http://hg.python.org/cpython/file/843e0da7e91f/Lib
Chris Jerdonek added the comment:
> Fixed. BTW I prefer to use «stream» as alias to file object
Thanks a lot, Andrew. Yes, I agree and actually contemplated doing that myself.
--
___
Python tracker
<http://bugs.python.org/issu
Changes by Chris Jerdonek :
--
nosy: +asvetlov
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/issue15497>
___
___
Python-bugs-list mailin
Changes by Chris Jerdonek :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue15437>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Attaching a failing test case.
Also, to confirm, this issue does not seem to affect 3.2.
--
keywords: +patch
Added file: http://bugs.python.org/file26787/failing-test-case-1.patch
___
Python tracker
<h
Changes by Chris Jerdonek :
--
stage: test needed -> needs patch
___
Python tracker
<http://bugs.python.org/issue15592>
___
___
Python-bugs-list mailing list
Un
Changes by Chris Jerdonek :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue14649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Attaching patch.
--
stage: needs patch -> patch review
Added file: http://bugs.python.org/file26788/issue-15592-1.patch
___
Python tracker
<http://bugs.python.org/issu
Changes by Chris Jerdonek :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue15269>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
It seems to be fixed now. Thanks.
--
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue15322>
___
_
Chris Jerdonek added the comment:
Updating patch to latest again.
--
nosy: +asvetlov
Added file: http://bugs.python.org/file26792/issue-15543-3.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Jerdonek :
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue12623>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Sure, you're welcome. And sounds good, I'll change it. The singular was the
prevailing form, but you're right that there is no reason we can't change it.
--
___
Python tracker
<http://bug
Chris Jerdonek added the comment:
Is it worth standardizing on "universal newlines mode" in the code as well
(docstrings, etc)? There are about ten occurrences of "universal newline mode"
that would need to be changed.
--
___
P
Chris Jerdonek added the comment:
Here is a new patch with David's suggested change (just for doc files though).
--
Added file: http://bugs.python.org/file26796/issue-15543-4.patch
___
Python tracker
<http://bugs.python.org/is
Chris Jerdonek added the comment:
Thanks a lot, Senthil. I appreciate it.
--
___
Python tracker
<http://bugs.python.org/issue15269>
___
___
Python-bugs-list m
Chris Jerdonek added the comment:
Updating patch to tip again.
--
Added file: http://bugs.python.org/file26799/issue-15543-5.patch
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
> > only one Popen instance (for the iconv call), but different encodings
> > for stdin and stdout.
> Isn't that the exception rather than the rule? I think it actually makes
> sense, in at least 99.83% of cases ;-), to have a common enc
New submission from Chris Jerdonek:
The --help documentation for the python executable says--
PYTHONIOENCODING: Encoding[:errors] used for stdin/stdout/stderr.
However, PYTHONIOENCODING doesn't seem to be respected for the python
executable's "refs" output to stderr
Chris Jerdonek added the comment:
Thanks, Andrew!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Chris Jerdonek added the comment:
> What to do if stdin doesn't have `encoding` attribute? Convert to bytes using
> filesystemencoding?
If choosing an encoding, it probably makes sense to default to the same as for
when universal_newlines=True, namely locale.getpreferredenc
Chris Jerdonek added the comment:
To my previous comment, issue 15648 shows the case where I was able to change
the encoding for stdout in the child process but not stderr (which would
require supporting two encodings in Popen to handle
Chris Jerdonek added the comment:
> Every doctest is docstring from tested module, but not every docstring is a
> valid doctest.
Actually, I'm not sure even this is correct. doctest will form a unittest
*TestSuite* from a module if it has docstrings, but it will not necessaril
Chris Jerdonek added the comment:
> I suspect the intent was to raise an error if there were no *tests*, not if
> there were no docstrings.
That, or the implementor thought that if no docstrings were found, then that
might indicate something went wrong with the parsing.
For back
Chris Jerdonek added the comment:
Senthil, here is a recent e-mail and response in which I asked about
documentation changes and adding tests during feature freeze:
http://mail.python.org/pipermail/python-dev/2012-July/121138.html
Also, here is a recent example of a documentation
Chris Jerdonek added the comment:
The problem seems to be restricted only to DocTestSuite. testmod and
DocTestFinder both seem to work fine. DocTestSuite calls DocTestFinder but not
the other way around: nothing calls DocTestSuite.
If in certain versions we do not treat raising the
Chris Jerdonek added the comment:
Sure, I'd be happy to do both 2.7 and 3.2. I can upload the patch for the
default branch as a delta to apply after the 3.2 change has been forward-ported
from 3.2 to default. Thanks for taking an interest in this!
--
versions: +Python 2.7, P
Chris Jerdonek added the comment:
I would like the chance to try implementing this without depending on Sphinx
and "make doctest". I don't think it would take much work, and it would let us
leverage and hook into regrtest's existing options (like test selection by
name).
Chris Jerdonek added the comment:
Here is the patch for 2.7.
--
Added file: http://bugs.python.org/file26822/issue-15543-6-py27.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Jerdonek :
Added file: http://bugs.python.org/file26826/issue-15543-6-py32.patch
___
Python tracker
<http://bugs.python.org/issue15543>
___
___
Python-bug
Chris Jerdonek added the comment:
And here are the 3.2 patch and the 3.3 "delta" after forward-porting. Note
that to forward-port the 3.2 patch to the default 3.3 branch, you can simply
drop the changes to the file Doc/library/bz2.rst. I think that is the only
conflict.
--
Chris Jerdonek added the comment:
Thanks, David! Also, can/did you check that reflows like these still link to
the glossary correctly?
+ :func:`input` function to allow opening files in binary or :term:`universal
+ newlines` mode. Another new parameter, *openhook*, lets you use a function
Chris Jerdonek added the comment:
Andrew, I'm not sure if this is the issue, but it seems like the only tests in
which input is passed to communicate() with universal newlines is when stdin is
the only PIPE, i.e.:
def test_universal_newlines_communicate_stdin(self):
# univ
Chris Jerdonek added the comment:
> Pushing to communicate input with "\r" (see attached patch) produces the
> error.
Is this a supported use case? In universal newlines, stdin line endings are
supposed to be "\n". From the subprocess documentation: "For std
Chris Jerdonek added the comment:
> Looking the code this test will fail on Windows. I cannot check it just now
> but looks like this is the problem.
Would it be possible to do something like the following to check this on a
non-Windows machine (since the Python implementation of io re
New submission from Chris Jerdonek:
It would be nice if hovering over the right side of the header to a glossary
entry would expose a link in the same way that it does for function
definitions, etc.
http://docs.python.org/dev/glossary.html#glossary
Otherwise, there doesn't seem to
New submission from Chris Jerdonek:
It would be nice if the first sentence of the documentation for the open()
built-in function:
"Open file and return a corresponding stream. If the file cannot be opened, an
OSError is raised."
http://docs.python.org/dev/library/functions.html#op
Changes by Chris Jerdonek :
--
keywords: +easy
___
Python tracker
<http://bugs.python.org/issue15694>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Do we pin the version of Sphinx that we use to generate the documentation? If
Sphinx fixes the issue, would we need to make a corresponding change here to
reflect the fix?
--
___
Python tracker
<h
Chris Jerdonek added the comment:
> I think we generally upgrade it exactly when there is a new Sphinx feature we
> want for our docs :)
:) Would the appropriate way to handle it be then to create an issue to
"upgrade Sphinx when XXX issue is resolved" and link to the corre
Chris Jerdonek added the comment:
I created a Sphinx issue for this here:
https://bitbucket.org/birkenfeld/sphinx/issue/996/expose-glossary-entry-link-on-hover
--
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
I created a Sphinx issue for this here:
https://bitbucket.org/birkenfeld/sphinx/issue/997/index-targets-not-getting-created-in
--
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Attaching patch. I also added two index entries for "file object" and made a
couple wording adjustments to the intro paragraph of the io module.
--
keywords: +patch
stage: -> patch review
versions: +Python 3.2
Added file: http://bu
Chris Jerdonek added the comment:
Good suggestion, David. Here is such sample test code. It is adapted from the
sample code for "ValueError: generator already executing" included in PEP 255:
def test_gen(call_gen_method):
def gen():
call_gen_method(me)
yiel
Chris Jerdonek added the comment:
Thanks. Could either one of you commit this for me?
--
___
Python tracker
<http://bugs.python.org/issue15694>
___
___
Python-bug
Chris Jerdonek added the comment:
Thank you, Andrew. Here is a patch updated with that change (and also merging
with tip).
--
Added file: http://bugs.python.org/file26899/issue-15595-4.patch
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
It might be worth mentioning and/or linking to some of the branching tips
discussed in the FAQ. For example, using `hg share` instead of `hg clone`
eliminates the need to pull between repositories/working directories:
http://docs.python.org/devguide
Chris Jerdonek added the comment:
> I think the aim of that part of the devguide is to give one clear, simple,
> working way to operate on different branches at the same time.
The change can be as simple as adding a sentence along the lines of, "Also see
the version control section
Chris Jerdonek added the comment:
I would be happy to take a look at this and propose a patch.
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
I haven't been able to test this via Python because my system sqlite3 version
isn't new enough. But I was able to test this against sqlite3 directly. I
suspect there may be no issue.
John, have you tried naming your constraint?
http://www.
Chris Jerdonek added the comment:
> When building CPython yourself, it will use what version is found on your
> system.
Ned, this is somewhat off-topic to the issue, but do you know of any ways to
tell CPython to use a particular version of sqlite3 at compile time if a system
has dif
Changes by Chris Jerdonek :
--
resolution: works for me -> invalid
stage: needs patch -> committed/rejected
___
Python tracker
<http://bugs.python.org/i
Chris Jerdonek added the comment:
I randomly ran into this issue again. I'm not sure this was ever resolved
(i.e. I think it may always have been different from issue 15111).
I still get the above behavior in the default branch.
And here is what I get in the 3.2 branch (the error inform
Chris Jerdonek added the comment:
I ran into this again because an error while running `./python.exe -m test` was
getting masked. The use of __main__.py in the package may be the
distinguishing characteristic.
--
___
Python tracker
<h
Changes by Chris Jerdonek :
--
keywords: +3.2regression
___
Python tracker
<http://bugs.python.org/issue15316>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Should this issue be fixed before the release? If it is not fixed, certain
problems found after the release may become harder to report and diagnose
(because the true source of error will be masked).
Two months ago issue 15111 which was thought to be the
Chris Jerdonek added the comment:
Here is a formal unit test case that passes in 3.2 but not in 3.3 (a "simpler"
case not using __main__.py).
(script_helper.create_empty_file() doesn't seem to be available in 3.2.)
--
keywords: +patch
Added file: http://bugs.python.org/
Chris Jerdonek added the comment:
You're welcome, Brett. I'll let you or someone else recast the test using the
latest preferred techniques. I was just using the style of the immediately
surrounding tests.
--
___
Python trac
Changes by Chris Jerdonek :
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue15767>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Hi moijes12, for instructions on compiling and submitting patches, etc., see
the Python Developer's Guide (aka the devguide). You may also be interested in
the Python Mentors Group: http://pythonmentors.com/
Lastly (a small point), in the future you can
Changes by Chris Jerdonek :
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue11664>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Adding Éric because of the interest in test setup and tear down in issue 11664.
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Here is an updated patch for review (just for the default branch for now).
The main change from the previous patch is that the ValueError exception is now
documented.
A few additional comments/questions:
Is there a better way to signify in the documentation
Changes by Chris Jerdonek :
Added file: http://bugs.python.org/file26991/issue-14649-3.patch
___
Python tracker
<http://bugs.python.org/issue14649>
___
___
Python-bug
Chris Jerdonek added the comment:
> Personally I prefer to have the test case create the file(s) used in the test
> dynamically, writing them to the temporary working directory.
I prefer that too, but when I approached this issue, I found that test_doctest
doesn't use unittest. I
Chris Jerdonek added the comment:
Small tweak to a code comment in the patch (`tests` is not itself a
unittest.TestSuite instance).
--
Added file: http://bugs.python.org/file27000/issue-14649-4.patch
___
Python tracker
<http://bugs.python.
Chris Jerdonek added the comment:
Here is a patch that documents and adds tests for the existing behavior (i.e.
keeping the current behavior the same).
I also expanded the patch slightly to cover related edge cases that involve the
interplay between whitespace, empty lines, and indenting
Chris Jerdonek added the comment:
I submitted a patch for this issue on the Sphinx tracker.
--
___
Python tracker
<http://bugs.python.org/issue15693>
___
___
Pytho
Chris Jerdonek added the comment:
Attached are a few test cases showing that Popen *does* consider cwd when
searching for the executable (as well as for args[0]), and in particular that
you *can* specify the program's path relative to cwd.
I also moved the test_cwd test to be adjacent t
Changes by Chris Jerdonek :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue15533>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Here is a full patch for the default branch (documentation correction and test
cases for the documented behavior).
If this patch looks acceptable, I can prepare a separate patch for 2.7.
--
Added file: http://bugs.python.org/file27018/issue-15533-2
Changes by Chris Jerdonek :
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15533>
___
___
Python-bugs-lis
Chris Jerdonek added the comment:
python_dir = os.path.dirname(os.path.realpath(sys.executable))
wrong_cwd = os.path.join(python_dir, 'Doc')
Actually, is there a better directory to be using for this? I'd like a
directory that is guaranteed to exist that is in the sa
Chris Jerdonek added the comment:
Here is a new patch that makes no assumptions about the contents of the
directory containing sys.executable.
--
Added file: http://bugs.python.org/file27026/issue-15533-3-default.patch
___
Python tracker
<h
Chris Jerdonek added the comment:
Updating the patch after discussing with David on IRC.
The two new files are now added to Lib/test instead of to a subdirectory of
Lib/test. Moving the doctest files to a subdirectory can be discussed and
possibly addressed as part of a separate issue
Chris Jerdonek added the comment:
This is a nit, but can you adhere to an 80-character line length? Much (but
not all) of the documentation does.
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
> With your patch 5 applied, test_zipimport_support fails.
You're right. It looks like test_zipimport_support is tightly coupled to
test_doctest. For example--
http://hg.python.org/cpython/file/786d9516663e/Lib/test/test_zipimport_support.py
Chris Jerdonek added the comment:
I updated the patch to fix the test_zipimport_support tests. All tests now
pass. The only changes were to Lib/test/test_zipimport_support.py.
I'll make a note about test_pyclbr and test_zipimport_support when I create the
issue to move the suppo
Changes by Chris Jerdonek :
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue15806>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
> In other words, (int(groups[0]), int(groups[1])) >= (int(previous_groups[0]),
> int(previous_groups[1])).
Why not use a single self.assertGreaterEqual() on the pairs (with an
appropriate change in the message)?
It currently hand-codes the lexi
Chris Jerdonek added the comment:
Attaching an updated patch that improves the organization of the new test cases
(test ordering, test names, and test comments, etc).
--
Added file: http://bugs.python.org/file27043/issue-15510-4.patch
___
Python
Chris Jerdonek added the comment:
This is a nit, but there should be two spaces after the period:
+each option in the section. Otherwise, return a list of tuples with
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
> If the double space is used elsewhere in the same document,
You can see one above the change in the patch file.
--
___
Python tracker
<http://bugs.python.org/issu
New submission from Chris Jerdonek:
>From d...@python.org:
"""
In a number of places we find documentation with optional leading arguments
where the meta-notation (square brackets) are in the wrong place. For
example, for range, the standard doc heading says
r
Chris Jerdonek added the comment:
Do we know that this is easy? It might be a Sphinx issue, in which case it
might not be as trivial as fixing typos.
I ask because the reST file looks correct (for range() for example):
.. function:: range([start,] stop[, step
601 - 700 of 1575 matches
Mail list logo
