[issue43773] macOS official installer builds not respecting DYLD_LIBRARY_PATH environment variable.

2021-11-09 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: -27755 ___ Python tracker <https://bugs.python.org/issue43773> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43773] macOS official installer builds not respecting DYLD_LIBRARY_PATH environment variable.

2021-11-09 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: -brandtbucher ___ Python tracker <https://bugs.python.org/issue43773> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45757] compiler emits EXTENDED_ARG + NOP sequence in 3.10

2021-11-09 Thread Brandt Bucher
Brandt Bucher added the comment: Indeed. Do you plan on removing the extra EXTENDED_ARGs in instrsize and write_op_arg? I can take care of it if not. -- ___ Python tracker <https://bugs.python.org/issue45

[issue45757] compiler emits EXTENDED_ARG + NOP sequence in 3.10

2021-11-10 Thread Brandt Bucher
Brandt Bucher added the comment: Here's a (more) minimal reproducer I've been able to create: ``` # First, "use up" 256 unique constants: spam=0x00;spam=0x01;spam=0x02;spam=0x03;spam=0x04;spam=0x05;spam=0x06;spam=0x07; spam=0x08;spam=0x09;spam=0x0a;spam=0x0b;spam=0x0c;spam

[issue45636] Merge BINARY_*/INPLACE_* into BINARY_OP/INPLACE_OP

2021-11-10 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset 9178f533ff5ea7462a2ca22cfa67afd78dad433b by Brandt Bucher in branch 'main': bpo-45636: Merge all numeric operators (GH-29482) https://github.com/python/cpython/commit/9178f533ff5ea7462a2ca22cfa67af

[issue45636] Merge BINARY_*/INPLACE_* into BINARY_OP

2021-11-10 Thread Brandt Bucher
Change by Brandt Bucher : -- title: Merge BINARY_*/INPLACE_* into BINARY_OP/INPLACE_OP -> Merge BINARY_*/INPLACE_* into BINARY_OP ___ Python tracker <https://bugs.python.org/issu

[issue45636] Merge BINARY_*/INPLACE_* into BINARY_OP

2021-11-10 Thread Brandt Bucher
Brandt Bucher added the comment: Tasks for tomorrow: - Reimplement the string formatting fast-path as a proper specialization. - Try indexing into an array of function pointers instead of switching. - Experiment more generic specializations for all operators (for instance, when lhs.__class__

[issue45753] Further speed up Python-to-Python calls.

2021-11-11 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue45753> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45510] Specialize BINARY_SUBTRACT

2021-11-11 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue45510> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45773] Compiler hangs during jump elimination

2021-11-11 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset 27b69e60daa7b191ee6bc76fb6d5fb7d793062ab by Brandt Bucher in branch 'main': bpo-45773: Stop "optimizing" certain jump patterns (GH-29505) https://github.com/python/cpython/commit/27b69e60daa7b191ee6b

[issue45773] Compiler hangs during jump elimination

2021-11-11 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +27776 pull_request: https://github.com/python/cpython/pull/29526 ___ Python tracker <https://bugs.python.org/issue45

[issue45773] Compiler hangs during jump elimination

2021-11-11 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset a89bbde83fe7f8cc347341e7ec57cda3ba312530 by Brandt Bucher in branch '3.10': [3.10] bpo-45773: Stop "optimizing" certain jump patterns (GH-29526) https://github.com/python/cpython/commit/a89bbde83fe7f8cc3473

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

2021-11-11 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher nosy_count: 4.0 -> 5.0 pull_requests: +27778 pull_request: https://github.com/python/cpython/pull/29528 ___ Python tracker <https://bugs.python.org/issu

[issue45636] Merge BINARY_*/INPLACE_* into BINARY_OP

2021-11-11 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +27782 pull_request: https://github.com/python/cpython/pull/29532 ___ Python tracker <https://bugs.python.org/issue45

[issue45791] __instancecheck__ being checked on type(cls) instead of cls

2021-11-13 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue45791> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45773] Compiler hangs during jump elimination

2021-11-13 Thread Brandt Bucher
Change by Brandt Bucher : -- resolution: -> fixed stage: patch review -> resolved status: open -> pending ___ Python tracker <https://bugs.python.or

[issue45116] Performance regression 3.10b1: inlining issue in the big _PyEval_EvalFrameDefault() function with Visual Studio (MSC)

2021-11-15 Thread Brandt Bucher
Brandt Bucher added the comment: The total size of the main interpreter loop was recently reduced somewhat by an unrelated change: https://github.com/python/cpython/commit/9178f533ff5ea7462a2ca22cfa67afd78dad433b I wonder if this issue still exists

[issue45636] Merge BINARY_*/INPLACE_* into BINARY_OP

2021-11-15 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset ec382fac0db6d9159c2d3496a70b7a605545957e by Brandt Bucher in branch 'main': bpo-45636: Remove the old %-formatting fast-path (GH-29532) https://github.com/python/cpython/commit/ec382fac0db6d9159c2d3496a70b7a

[issue45636] Merge BINARY_*/INPLACE_* into BINARY_OP

2021-11-15 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +27813 pull_request: https://github.com/python/cpython/pull/29565 ___ Python tracker <https://bugs.python.org/issue45

[issue45636] Merge BINARY_*/INPLACE_* into BINARY_OP

2021-11-16 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset 6a84d61c55f2e543cf5fa84522d8781a795bba33 by Brandt Bucher in branch 'main': bpo-45636: Simplify BINARY_OP (GH-29565) https://github.com/python/cpython/commit/6a84d61c55f2e543cf5fa84522d878

[issue45116] Performance regression 3.10b1: inlining issue in the big _PyEval_EvalFrameDefault() function with Visual Studio (MSC)

2021-11-16 Thread Brandt Bucher
Brandt Bucher added the comment: Hm. If removing 26 opcodes didn't fix this, then maybe the size of _PyEval_EvalFrameDefault isn't really the issue? -- ___ Python tracker <https://bugs.python.o

[issue45510] Specialize BINARY_SUBTRACT

2021-12-08 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +28218 pull_request: https://github.com/python/cpython/pull/29995 ___ Python tracker <https://bugs.python.org/issue45

[issue38764] Deterministic globbing.

2019-11-10 Thread Brandt Bucher
New submission from Brandt Bucher : This has been discussed before, but we now have examples in the news of glob's non-deterministic behavior causing some real headaches for hundreds of people in the scientific community. After some cursory discussion (https://discuss.python.org/t/a

[issue38764] Deterministic globbing.

2019-11-10 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +16611 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17105 ___ Python tracker <https://bugs.python.org/issu

[issue38764] Deterministic globbing.

2019-11-10 Thread Brandt Bucher
Brandt Bucher added the comment: I disagree somewhat with the assessment that glob provides "thin" access to OS services. It is composed of a few low-level utilities, but it exposes them through what I consider to be a fairly high-level, abstract, friendly interface that (

[issue38438] argparse "usage" overly-complex with nargs="*"

2019-11-10 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +16612 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17106 ___ Python tracker <https://bugs.python.org/issu

[issue38438] argparse "usage" overly-complex with nargs="*"

2019-11-10 Thread Brandt Bucher
Brandt Bucher added the comment: I went ahead and opened a PR, since it's been a month. -- ___ Python tracker <https://bugs.python.org/issue38438> ___ ___

[issue38764] Deterministic globbing.

2019-11-11 Thread Brandt Bucher
Brandt Bucher added the comment: I'm not sure listdir and walk should be sorted, for the reasons Raymond mentioned. And I was actually surprised to learn today that pathlib.Path.glob doesn't use the glob module internally. Was there some reasoning behind this decision? Separato

[issue38328] Speed up the creation time of constant list literals.

2019-11-11 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16621 pull_request: https://github.com/python/cpython/pull/17114 ___ Python tracker <https://bugs.python.org/issue38

[issue38328] Speed up the creation time of constant list literals.

2019-11-11 Thread Brandt Bucher
Brandt Bucher added the comment: I have created a new patch (PR 17114) that performs this optimization directly in the compiler, rather than the peephole optimizer. I think I like the new one better. -- ___ Python tracker <ht

[issue38328] Speed up the creation time of constant list and set literals.

2019-11-11 Thread Brandt Bucher
Change by Brandt Bucher : -- title: Speed up the creation time of constant list literals. -> Speed up the creation time of constant list and set literals. ___ Python tracker <https://bugs.python.org/issu

[issue25866] Reference 3. Data Model: miscellaneous minor cleanups on the word "sequence".

2019-11-13 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue25866> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11354] argparse: nargs could accept range of options count

2019-11-13 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue11354> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38823] Improve stdlib module initialization error handling.

2019-11-16 Thread Brandt Bucher
New submission from Brandt Bucher : Many of the C stdlib modules can benefit from improved error handling during initialization. I've now had two PRs where the authors had reference leaks on error conditions, but defended their decisions by pointing to examples of similar idioms all ove

[issue38823] Improve stdlib module initialization error handling.

2019-11-16 Thread Brandt Bucher
Brandt Bucher added the comment: How do others feel about the creation of a new private API? It would keep these diffs smaller and ease refactoring... and it would probably be good to have around anyways: /* Like PyModule_AddObject, but steals o on success AND failure. */ int

[issue38823] Improve stdlib module initialization error handling.

2019-11-16 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue38823> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38823] Improve stdlib module initialization error handling.

2019-11-16 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +16699 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17195 ___ Python tracker <https://bugs.python.org/issu

[issue38823] Improve stdlib module initialization error handling.

2019-11-16 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16702 pull_request: https://github.com/python/cpython/pull/17198 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-17 Thread Brandt Bucher
Brandt Bucher added the comment: Yes, there are still a few dozen modules I plan to update! -- ___ Python tracker <https://bugs.python.org/issue38823> ___ ___

[issue38823] Improve stdlib module initialization error handling.

2019-11-17 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16711 pull_request: https://github.com/python/cpython/pull/17206 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-17 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16718 pull_request: https://github.com/python/cpython/pull/17215 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-17 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16719 pull_request: https://github.com/python/cpython/pull/17216 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16735 pull_request: https://github.com/python/cpython/pull/17235 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16736 pull_request: https://github.com/python/cpython/pull/17236 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16747 pull_request: https://github.com/python/cpython/pull/17250 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-19 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16753 pull_request: https://github.com/python/cpython/pull/17260 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-19 Thread Brandt Bucher
Brandt Bucher added the comment: Thanks Victor. These obviously aren’t urgent, so feel free to return to them whenever’s convenient. I also pinged you on #17235 (_tracemalloc) too. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-20 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16769 pull_request: https://github.com/python/cpython/pull/17276 ___ Python tracker <https://bugs.python.org/issue38

[issue38823] Improve stdlib module initialization error handling.

2019-11-20 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16790 pull_request: https://github.com/python/cpython/pull/17298 ___ Python tracker <https://bugs.python.org/issue38

[issue38870] Expose ast.unparse in the ast module

2019-11-20 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue38870> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38721] modulefinder should use import hooks properly

2019-11-21 Thread Brandt Bucher
Brandt Bucher added the comment: I'm not sure what you mean when you say "modulefinder currently will detect modules imported by a script dynamically by running the script"... modulefinder is completely static, no? I also think that changing sys.path like this is a bad idea (

[issue38721] modulefinder should use import hooks properly

2019-11-21 Thread Brandt Bucher
Brandt Bucher added the comment: See prior discussion on this here: https://github.com/python/cpython/pull/11787#discussion_r256442282 -- ___ Python tracker <https://bugs.python.org/issue38

[issue38361] syslog: Default "ident" in syslog.openlog() shouldn't contain slash

2020-01-15 Thread Brandt Bucher
Change by Brandt Bucher : -- components: +Library (Lib) -Extension Modules nosy: +brandtbucher resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 3.5, Python 3.6, Python 3.7, Python 3.8 ___ Python tracke

[issue39440] Use PyNumber_InPlaceAdd in sum() for the second iteration onward

2020-01-23 Thread Brandt Bucher
Brandt Bucher added the comment: Prior discussion at https://bugs.python.org/issue18305. Note the final comment. In short, this is a breaking semantic change, and the general consensus is that using sum for sequence concatenation is an anti-pattern. -- nosy: +brandtbucher

[issue39440] Use PyNumber_InPlaceAdd in sum() for the second iteration onward

2020-01-23 Thread Brandt Bucher
Change by Brandt Bucher : -- resolution: -> duplicate ___ Python tracker <https://bugs.python.org/issue39440> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue39440] Use PyNumber_InPlaceAdd in sum() for the second iteration onward

2020-01-28 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +17619 pull_request: https://github.com/python/cpython/pull/18240 ___ Python tracker <https://bugs.python.org/issue39

[issue39440] Use PyNumber_InPlaceAdd in sum() for the second iteration onward

2020-01-28 Thread Brandt Bucher
Brandt Bucher added the comment: Perhaps. I've opened a PR to update the comment with more info. -- ___ Python tracker <https://bugs.python.org/is

[issue39320] Handle unpacking of */** arguments and rvalues in the compiler

2020-01-28 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue39320> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39320] Handle unpacking of */** arguments and rvalues in the compiler

2020-01-28 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +17623 pull_request: https://github.com/python/cpython/pull/18243 ___ Python tracker <https://bugs.python.org/issue39

[issue39320] Handle unpacking of */** arguments and rvalues in the compiler

2020-01-29 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +17641 pull_request: https://github.com/python/cpython/pull/18264 ___ Python tracker <https://bugs.python.org/issue39

[issue39573] Make PyObject an opaque structure in the limited C API

2020-02-12 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +17870 pull_request: https://github.com/python/cpython/pull/18496 ___ Python tracker <https://bugs.python.org/issue39

[issue39411] pyclbr rewrite using AST

2020-02-13 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue39411> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39702] PEP 614: Relaxing Grammar Restrictions On Decorators

2020-02-20 Thread Brandt Bucher
New submission from Brandt Bucher : The attached PR implements PEP 614's revised grammar for decorators, with tests. In short: decorator: '@' dotted_name [ '(' [arglist] ')' ] NEWLINE becomes decorator: '@' namedexpr_test NEWLINE I'm ma

[issue39702] PEP 614: Relaxing Grammar Restrictions On Decorators

2020-02-20 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +17949 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18570 ___ Python tracker <https://bugs.python.org/issu

[issue19660] decorator syntax: allow testlist instead of just dotted_name

2020-02-20 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> PEP 614: Relaxing Grammar Restrictions On Decorators ___ Python tracker <https://bugs.python

[issue37196] Allowing arbitrary expressions in the @expression syntax

2020-02-20 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher resolution: -> duplicate status: open -> closed superseder: -> PEP 614: Relaxing Grammar Restrictions On Decorators ___ Python tracker <https://bugs.python.or

[issue39537] Change line number table format

2020-02-20 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker <https://bugs.python.org/issue39537> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36144] Dictionary addition. (PEP 584)

2020-02-24 Thread Brandt Bucher
Brandt Bucher added the comment: My current PR plans are: - Docs. This will include the dict docs and the whatsnew 3.9. I assume we have no plans to cover this in the tutorials, etc. Let me know if I'm missing anything here. - collections.defaultdict, with tests. I don't think

[issue36144] Dictionary addition. (PEP 584)

2020-02-25 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +18020 pull_request: https://github.com/python/cpython/pull/18659 ___ Python tracker <https://bugs.python.org/issue36

[issue36144] Dictionary addition. (PEP 584)

2020-02-25 Thread Brandt Bucher
Brandt Bucher added the comment: As a somewhat simpler example: >>> f = {False: False} >>> z = {0: 0} >>> f | z {False: 0} >>> {**f, **z} {False: 0} >>> f.update(z); f {False: 0} Though these hairier cases aren't explicitly addressed, the

[issue36144] Dictionary union. (PEP 584)

2020-02-25 Thread Brandt Bucher
Change by Brandt Bucher : -- title: Dictionary addition. (PEP 584) -> Dictionary union. (PEP 584) ___ Python tracker <https://bugs.python.org/issue36144> ___ _

[issue36144] Dictionary union. (PEP 584)

2020-02-26 Thread Brandt Bucher
Brandt Bucher added the comment: Yep. I'm currently working on OrderedDict, defaultdict, and MappingProxyType. My brother is looking to make his first contribution, so he'll be taking care of ChainMap. -- ___ Python track

[issue36144] Dictionary union. (PEP 584)

2020-02-26 Thread Brandt Bucher
Brandt Bucher added the comment: The plan is to follow dict’s semantics. The |= operator will basically delegate to the first map in the chain. The | operator will create a new ChainMap where the first map is the merged result of the old first map, and the others are the same. So, basically

[issue36144] Dictionary union. (PEP 584)

2020-02-26 Thread Brandt Bucher
Brandt Bucher added the comment: > I think for `|=` the only choice is for it to be essentially an alias to > `.update()`. So that means `cm |= other` becomes `cm.maps[0].update(other)`. Agreed. > These semantics make `|=` behave rather differently from `|`. Is that okay? > If n

[issue36144] Dictionary union. (PEP 584)

2020-02-27 Thread Brandt Bucher
Brandt Bucher added the comment: > Note that in your last message, `d1 |= cm2` will fail for this reason. You > can of course fix that with `d1 |= dict(cm2)`, although IIUC there's no > reason one of the maps couldn't be some other [Mutable]Mapping. Mappings and iterabl

[issue36144] Dictionary union. (PEP 584)

2020-02-27 Thread Brandt Bucher
Brandt Bucher added the comment: I believe that: cm | other Should return the equivalent of: ChainMap(cm.maps[0] | dict(other), *cm.maps[1:]) -- ___ Python tracker <https://bugs.python.org/issue36

[issue36144] Dictionary union. (PEP 584)

2020-02-27 Thread Brandt Bucher
Brandt Bucher added the comment: ...however, I could also see the (similar): ChainMap(other, *cm.maps) # Note that `other` is the original reference here. Being okay as well. Maybe even better, now that I've written it out. -- ___ P

[issue36144] Dictionary union. (PEP 584)

2020-02-27 Thread Brandt Bucher
Brandt Bucher added the comment: > Im not sure if the dict(other) cast is the best way to go about it. Maybe > this would work? Yeah, I was imagining something like that... I used the cast for brevity in my reply but that probably wasn't helpful. Note that for __or__, we proba

[issue36144] Dictionary union. (PEP 584)

2020-02-27 Thread Brandt Bucher
Brandt Bucher added the comment: Just to clarify: If we decide to check isinstance(other, (ChainMap, dict)), '|' should probably be used. If we decide to check isinstance(other, Mapping), I think the copy/update methods shou

[issue36144] Dictionary union. (PEP 584)

2020-02-27 Thread Brandt Bucher
Brandt Bucher added the comment: I think we're only seriously considering the first variant (although implemented slightly differently, see my last two messages). And __ror__ would probably change, returning the type of self. What are the "problems" with it, exactly? W

[issue36144] Dictionary union. (PEP 584)

2020-02-27 Thread Brandt Bucher
Brandt Bucher added the comment: Sounds good, I'll have these up soon. -- ___ Python tracker <https://bugs.python.org/issue36144> ___ ___ Python-bugs-list m

[issue36144] Dictionary union. (PEP 584)

2020-03-01 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +18086 pull_request: https://github.com/python/cpython/pull/18729 ___ Python tracker <https://bugs.python.org/issue36

[issue39702] PEP 614: Relaxing Grammar Restrictions On Decorators

2020-03-03 Thread Brandt Bucher
Brandt Bucher added the comment: Agreed. I'll have something up later, hopefully. I'll add a tiny blurb to whatsnew, as well as adding the PEP to the "See also:" note in https://docs.python.org/3.9/reference/compound_stmts.html and updating the mini-grammar there. I

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-05 Thread Brandt Bucher
New submission from Brandt Bucher : It looks like https://docs.python.org/3/reference/expressions.html and https://docs.python.org/3/reference/compound_stmts.html were never updated for named expressions. Because this change has to be backported, it's sort of a blocker for my PEP 614

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-05 Thread Brandt Bucher
Brandt Bucher added the comment: Sorry, I hadn't seen your comment... :( I've already finished the grammar specification bit, but not the prose description of how assignment expressions work, etc. How about I leave that empty in my PR and you can actually do the documenta

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-05 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +18151 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18793 ___ Python tracker <https://bugs.python.org/issu

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-05 Thread Brandt Bucher
Brandt Bucher added the comment: Of course. After my PR is merged, you can make another PR that replaces the ".. TODO: BPO-39868" line with a description of how assignment expressions work. Likely much of the language can be borrowed from the PEP. Let me know if you need help w

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-05 Thread Brandt Bucher
Brandt Bucher added the comment: Thanks for offering to help, Shankar! For this change, you can look at the other sections of the Doc/reference/expressions.rst file for an idea of what we're looking for. I think a few sentences and maybe a small code snippet should probably be fine.

[issue39702] PEP 614: Relaxing Grammar Restrictions On Decorators

2020-03-05 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +18158 pull_request: https://github.com/python/cpython/pull/18802 ___ Python tracker <https://bugs.python.org/issue39

[issue36144] Dictionary union. (PEP 584)

2020-03-06 Thread Brandt Bucher
Brandt Bucher added the comment: My brother will have a ChainMap PR up soon. I'm just finishing up MappingProxyType, myself. Probably both this weekend. Then I'll move on to OrderedDict, which looks like it could be tricky. I'll need to familiarize myself with the implem

[issue36144] Dictionary union. (PEP 584)

2020-03-06 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +18172 pull_request: https://github.com/python/cpython/pull/18814 ___ Python tracker <https://bugs.python.org/issue36

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-06 Thread Brandt Bucher
Brandt Bucher added the comment: Great. Just replacing the TODO line with your new description (and maybe an example) should be perfect! -- keywords: -patch stage: patch review -> ___ Python tracker <https://bugs.python.org/issu

[issue39702] PEP 614: Relaxing Grammar Restrictions On Decorators

2020-03-07 Thread Brandt Bucher
Change by Brandt Bucher : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue39702> ___ ___ Pyth

[issue39890] The AST is mangled when compiling starred assignments.

2020-03-07 Thread Brandt Bucher
New submission from Brandt Bucher : It looks like assignment_helper is the only place where we actually change the semantic meaning of the AST during compilation (a starred name is changed to a regular name as a shortcut). This probably isn't a great idea, and it would bite us later

[issue39890] The AST is mangled when compiling starred assignments.

2020-03-07 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +18190 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18833 ___ Python tracker <https://bugs.python.org/issu

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-07 Thread Brandt Bucher
Brandt Bucher added the comment: > I have created my draft with an example but I am confused about where exactly > do I have to add the code and push it. > I have cloned these two repositories in my system and setup everything: > https://github.com/python/cpython > https://gi

[issue39890] The AST is mangled when compiling starred assignments

2020-03-07 Thread Brandt Bucher
Change by Brandt Bucher : -- title: The AST is mangled when compiling starred assignments. -> The AST is mangled when compiling starred assignments ___ Python tracker <https://bugs.python.org/issu

[issue39857] subprocess.run: add an extra_env kwarg to complement existing env kwarg

2020-03-07 Thread Brandt Bucher
Brandt Bucher added the comment: Caleb's answer, using PEP 584's merge operator: newenv = os.environ | {'FOO': ..., 'BAR': ...} subprocess.run(..., env=new_env, ...) -- nosy: +brandtbucher ___ Python tra

[issue36144] Dictionary union. (PEP 584)

2020-03-07 Thread Brandt Bucher
Brandt Bucher added the comment: Issue 39857 just reminded me that we should update os._Environ as well (the type of os.environ and os.environb). I have another first-timer who will probably want to take it. -- ___ Python tracker <ht

[issue39857] subprocess.run: add an extra_env kwarg to complement existing env kwarg

2020-03-07 Thread Brandt Bucher
Brandt Bucher added the comment: Ah, I didn't realize that os.environ and os.environ b aren't dict subclasses. I've added a ticket to update them with the new operators! -- ___ Python tracker <https://bugs.pyt

<    1   2   3   4   5   6   >