[issue44232] Crash in Objects/typeobject.c

2021-05-25 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +24950 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26358 ___ Python tracker ___

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

2021-05-25 Thread Trygve Aaberge
Trygve Aaberge added the comment: > The _PyImport_FixupExtensionObject() change impacts extensions using the > legacy API and so should not be used in subinterpreters. I'm not using that directly in my code, but I guess it's used indirectly? If it shouldn't be used, what's the alternative in

[issue44232] Crash in Objects/typeobject.c

2021-05-25 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +24951 pull_request: https://github.com/python/cpython/pull/26359 ___ Python tracker ___ __

[issue44232] Crash in Objects/typeobject.c

2021-05-25 Thread STINNER Victor
STINNER Victor added the comment: > We noticed a behavior change in [1]. Hey, well done bisection, you're right, it's a regression of my large type_new() refactoring in bpo-43770. I wrote PR 26359 to fix it. -- ___ Python tracker

[issue44131] [C API] Add tests on Py_FrozenMain()

2021-05-25 Thread STINNER Victor
STINNER Victor added the comment: commit eaede0ded72e67cee4a91c086847d54cb64ca74c Author: Victor Stinner Date: Mon May 17 23:48:35 2021 +0200 bpo-44131: Test Py_FrozenMain() (GH-26126) * Add test_frozenmain to test_embed * Add Programs/test_frozenmain.py * Add Programs/

[issue37596] Reproducible pyc: frozenset is not serialized in a deterministic order

2021-05-25 Thread Filipe Laíns
Filipe Laíns added the comment: What about normal sets? They also suffer from the same issue. -- ___ Python tracker ___ ___ Python-b

[issue42109] Use hypothesis for testing the standard library, falling back to stubs

2021-05-25 Thread Paul Ganssle
Paul Ganssle added the comment: > I use hypothesis during development, but don't have a need for in the the > standard library. By the time code lands there, we normally have a specific > idea of what edge cases needs to be in the tests. The suggestion I've made here is that we use @example

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

2021-05-25 Thread STINNER Victor
STINNER Victor added the comment: George-Cristian Bîrzan: "The timeline there is wrong." Fixed: https://python-security.readthedocs.io/vuln/ipaddress-ipv4-leading-zeros.html#timeline The strange part is "2019-03-20 (-741 days): Python issue bpo-36384 reported by Joel Croteau". The problem i

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

2021-05-25 Thread George-Cristian Bîrzan
George-Cristian Bîrzan added the comment: I think the only thing I'd improve would be to mention that this issue is the one that introduced the bug, otherwise it looks a bit weird. -- ___ Python tracker

[issue44226] Threads shutting down in Py 2.7 but not in Py 3.69 while making SSH connection using Paramiko module

2021-05-25 Thread Muralidhar BN
Muralidhar BN added the comment: We have checked this issue by adapting another 3rd party SSH packages ( replace paramiko with pyssh). Using this we have found same o/p results. Which means it is not 3rd party SSH package ( paramiko or pyssh) issue. Issue report in Paramiko github will be r

[issue44233] Provide Windows Terminal Fragment Extension

2021-05-25 Thread Steve Dower
Steve Dower added the comment: Thanks! This is a great idea. I'd prioritise adding support to the Store app first, as that's easier to manage (we're not having to modify files owned by other apps outside of our install directory). But no reason we couldn't extend the older installer and mak

[issue44031] python3.8.9, python3.9.2 test_embed test_tabnanny failed

2021-05-25 Thread Alexei S
Alexei S added the comment: make test TESTOPTS="-v test_embed test_tabnanny" CC='gcc -pthread' LDSHARED='gcc -pthread -shared' OPT='-DNDEBUG -g -fwrapv -O3 -Wall' _TCLTK_INCLUDES='' _TCLTK_LIBS='' ./python -E ./setup.py build running build running build_ext The following modu

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset d3c277a59c3d93fb92f7026f63678083d1d49fc5 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for sqlite3 heap types (GH-26104) https://github.com/python/cpython/commit/d3c277a59c3d93fb92f7026f63678083d1d49fc

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +24952 pull_request: https://github.com/python/cpython/pull/26361 ___ Python tracker _

[issue37439] Add random.binomialvariate()

2021-05-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: A presumed optimal version of this is already available in numpy. https://numpy.org/doc/stable/reference/random/generated/numpy.random.Generator.binomial.html https://github.com/numpy/numpy/blob/2232a473f8713f532c8164c8cf616f7bd05f54a7/numpy/random/_generat

[issue40551] PRs should be rebased on top of master before running the build/tests

2021-05-25 Thread Filipe Laíns
Change by Filipe Laíns : -- resolution: -> works for me stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread miss-islington
miss-islington added the comment: New changeset e8d9df0089e30a06d837fa2cfbd070e01531701f by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for sqlite3 heap types (GH-26104) https://github.com/python/cpython/commit/e8d9df0089e30a06d837fa2cfbd070e01531701f -

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread miss-islington
Change by miss-islington : -- pull_requests: +24953 pull_request: https://github.com/python/cpython/pull/26362 ___ Python tracker ___ __

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset bd404ccac0d3e8358995ac0cbeec9373bb6c4d96 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for arraymodule types (GH-26114) https://github.com/python/cpython/commit/bd404ccac0d3e8358995ac0cbeec9373bb6c4d96

[issue44217] Tkinter/IDLE: literal astral char discombobulates text editing

2021-05-25 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: I executed the code Tal provided and yes both Serhiy and Tal you're right. It seems the backspace problem is related to Tcl/Tk's indexing. 1.1 and 1.2 both refer to 😀. Also the dancing I told actually tells why this is happening. Since Tcl/Tk uses BMP it tre

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread miss-islington
miss-islington added the comment: New changeset 534da740a2586357d204ab5f446295b9ce220787 by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for arraymodule types (GH-26114) https://github.com/python/cpython/commit/534da740a2586357d204ab5f446295b9ce220787 --

[issue44217] Tkinter/IDLE: literal astral char discombobulates text editing

2021-05-25 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: Sorry, 1.0 and 1.1 refer to 😀 not 1.1 and 1.2 -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

2021-05-25 Thread STINNER Victor
STINNER Victor added the comment: > I think the only thing I'd improve would be to mention that this issue is the > one that introduced the bug, otherwise it looks a bit weird. Ok, done: https://python-security.readthedocs.io/vuln/ipaddress-ipv4-leading-zeros.html#timeline -- _

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24954 pull_request: https://github.com/python/cpython/pull/26363 ___ Python tracker ___ ___

[issue43693] Logically merge cell and locals array. They are already contiguous in memory

2021-05-25 Thread Eric Snow
Change by Eric Snow : -- pull_requests: +24955 pull_request: https://github.com/python/cpython/pull/26364 ___ Python tracker ___ ___

[issue37439] Add random.binomialvariate()

2021-05-25 Thread Mark Dickinson
Mark Dickinson added the comment: I think the NumPy implementation may be from here: https://core.ac.uk/download/pdf/11007254.pdf (though I'm struggling to find a clear citation in the NumPy source) -- ___ Python tracker

[issue44237] test_ssl randomly fails on macOS GH Action: test_get_server_certificate_sni() and test_get_server_certificate_timeout()

2021-05-25 Thread STINNER Victor
New submission from STINNER Victor : https://github.com/python/cpython/pull/26359/checks?check_run_id=2668874284 Error 1: 2021-05-25T20:02:41.9174160Z == 2021-05-25T20:02:41.9268350Z ERROR: test_get_server_certificate_sni (t

[issue44232] Crash in Objects/typeobject.c

2021-05-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset bd199e72fb60a8ff001a023f23925092a290be91 by Victor Stinner in branch 'main': bpo-44232: Fix type_new() error reporting (GH-26359) https://github.com/python/cpython/commit/bd199e72fb60a8ff001a023f23925092a290be91 -- ___

[issue44237] test_ssl randomly fails on macOS GH Action: test_get_server_certificate_sni() and test_get_server_certificate_timeout()

2021-05-25 Thread Christian Heimes
Christian Heimes added the comment: It looks like a duplicate or very similar to bpo-44229. -- dependencies: +test_get_server_certificate fails intermittently on macOS ___ Python tracker

[issue44232] Crash in Objects/typeobject.c

2021-05-25 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +24956 pull_request: https://github.com/python/cpython/pull/26365 ___ Python tracker _

[issue44237] test_ssl randomly fails on macOS GH Action: test_get_server_certificate_sni() and test_get_server_certificate_timeout()

2021-05-25 Thread STINNER Victor
STINNER Victor added the comment: > https://github.com/python/cpython/pull/26359/checks?check_run_id=2668874284 test.pythoninfo: ssl.HAS_SNI: True ssl.OPENSSL_VERSION: OpenSSL 1.1.1k 25 Mar 2021 ssl.OPENSSL_VERSION_INFO: (1, 1, 1, 11, 15) ssl.OP_ALL: 0x8054 ssl.OP_NO_TLSv1_1: 0x1000

[issue37439] Add random.binomialvariate()

2021-05-25 Thread Mark Dickinson
Mark Dickinson added the comment: Nope, that's the wrong paper. It looks as though this is the right one, but it's hidden behind a paywall: https://dl.acm.org/doi/abs/10.1145/42372.42381 -- ___ Python tracker _

[issue43921] test_ssl fails on Windows buildbots

2021-05-25 Thread Steve Dower
Steve Dower added the comment: I can't reproduce these on my own (Windows) machine either. Looking at the output, I think the tests are just going to be inherently flakey. It's not testing the specific scenario directly enough, and relying heavily on implicit synchronization. We probably ju

[issue43921] test_ssl fails on Windows buildbots

2021-05-25 Thread STINNER Victor
STINNER Victor added the comment: > Looking at the output, I think the tests are just going to be inherently > flakey. It's not testing the specific scenario directly enough, and relying > heavily on implicit synchronization. My notes to debug race conditions: https://pythondev.readthedocs.i

[issue43921] test_ssl fails on Windows buildbots

2021-05-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Looking at the output, I think the tests are just going to be inherently > flakey. It's not testing the specific scenario directly enough, and relying > heavily on implicit synchronization. But 3.9 and 3.8 are not failing on test_ssl, so do somethin

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24957 pull_request: https://github.com/python/cpython/pull/26368 ___ Python tracker ___ ___

[issue43216] Removal of @asyncio.coroutine in Python 3.11

2021-05-25 Thread Illia Volochii
Change by Illia Volochii : -- keywords: +patch pull_requests: +24958 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26369 ___ Python tracker ___ _

[issue43921] test_ssl fails on Windows buildbots

2021-05-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Also, this seems to be reproducible in MacOS at least: https://bugs.python.org/issue44229 -- ___ Python tracker ___ _

[issue44031] python3.8.9, python3.9.2 test_embed test_tabnanny failed

2021-05-25 Thread Alexei S
Alexei S added the comment: I downloaded tar.gz of Python-3.8.9 and Python-3.9.4 into my ~/Downloads folder (~/Загрузки in Russian) extracted them, after that executed: chmod +x configure CXX=/usr/bin/g++ ./configure --enable-optimizations make -j4 problems the same for both Python versions

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Christian, I've got a PR ready for Modules/_ssl.c, but I won't submit it if you'd rather do it yourself. I'll stay off the sha/md5 types unless you approve :) -- nosy: +christian.heimes ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Christian Heimes
Christian Heimes added the comment: Please open PRs and assign them to me. I'll review them as soon as possible. -- ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24959 pull_request: https://github.com/python/cpython/pull/26370 ___ Python tracker ___ ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24960 pull_request: https://github.com/python/cpython/pull/26371 ___ Python tracker ___ ___

[issue42792] [MacOS] Can't open file in a separate (threading.Thread) thread

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland nosy_count: 4.0 -> 5.0 pull_requests: +24961 pull_request: https://github.com/python/cpython/pull/26372 ___ Python tracker ___

[issue42792] [MacOS] Can't open file in a separate (threading.Thread) thread

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24962 pull_request: https://github.com/python/cpython/pull/26373 ___ Python tracker ___ ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24963 pull_request: https://github.com/python/cpython/pull/26372 ___ Python tracker ___ ___

[issue42792] [MacOS] Can't open file in a separate (threading.Thread) thread

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: -24961 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue42792] [MacOS] Can't open file in a separate (threading.Thread) thread

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: -24962 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24964 pull_request: https://github.com/python/cpython/pull/26373 ___ Python tracker ___ ___

[issue42792] [MacOS] Can't open file in a separate (threading.Thread) thread

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24965 pull_request: https://github.com/python/cpython/pull/26373 ___ Python tracker ___ ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks! Hashlib PR comin' up. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +24966 pull_request: https://github.com/python/cpython/pull/26374 ___ Python tracker ___ ___

[issue44237] test_ssl randomly fails on macOS GH Action: test_get_server_certificate_sni() and test_get_server_certificate_timeout()

2021-05-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue44092] [sqlite3] Remove special rollback handling

2021-05-25 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Berker, does this look ok to you? -- title: [sqlite3] consider removing special rollback handling -> [sqlite3] Remove special rollback handling ___ Python tracker __

[issue44222] Improving _removeHandlerRef for a very long _handlerList

2021-05-25 Thread miss-islington
miss-islington added the comment: New changeset 156699bca02dd2def844d03e26fc16a831336635 by Yonatan Goldschmidt in branch 'main': bpo-44222: Improve _removeHandlerRef() for a very long _handlerList (GH-26325) https://github.com/python/cpython/commit/156699bca02dd2def844d03e26fc16a831336635

[issue43921] test_ssl fails on Windows buildbots

2021-05-25 Thread Steve Dower
Steve Dower added the comment: > But 3.9 and 3.8 are not failing on test_ssl, so do something has clearly > changed. Are the failing tests new? They're flakey in the sense that they're not failing reliably, when they clearly should be :) If something changed about how any part of the respon

[issue44222] Improving _removeHandlerRef for a very long _handlerList

2021-05-25 Thread Yonatan Goldschmidt
Change by Yonatan Goldschmidt : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Neil Schemenauer
Change by Neil Schemenauer : -- nosy: +nascheme ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue43921] test_ssl fails on Windows buildbots

2021-05-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks for the explanation! > They're flakey in the sense that they're not failing reliably, when they > clearly should be :) Yeah, I do agree with you in this, but I am still not happy that they *realiably* pass in 3.9 and 3.8 in two different OS wh

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Victor, can you take a look at the opened PRs? -- ___ Python tracker ___ ___ Python-bugs-l

[issue44208] argparse: Accept option without needing to distinguish "-" from "_" in arg_string

2021-05-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: William, thank you for the suggestion, but we're going to decline for the reasons listed by Eric and me. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue43693] Logically merge cell and locals array. They are already contiguous in memory

2021-05-25 Thread Eric Snow
Change by Eric Snow : -- pull_requests: +24967 pull_request: https://github.com/python/cpython/pull/26375 ___ Python tracker ___ ___

[issue44208] argparse: Accept option without needing to distinguish "-" from "_" in arg_string

2021-05-25 Thread Catherine Devlin
Catherine Devlin added the comment: All that said, it's easy to imagine a PyPI package that would give this functionality for those who want it. Maybe even one that could also alter the behavior of Click and Typer. If you want to go that route, let me know. --

[issue42194] Docs for argparse.BooleanOptionalAction missing "New in version 3.9"

2021-05-25 Thread John Belmonte
John Belmonte added the comment: I've opened a new PR, please review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue5758] fileinput.hook_compressed returning bytes from gz file

2021-05-25 Thread Inada Naoki
Inada Naoki added the comment: > I did consider and confirm that mode="rb" does also provide a uniform > solution, but it also regresses the behavior of uncompressed inputs, making > them bytes where they were text. Of course, I suggested to use "rb" when you want to read bytes. * When read

[issue37596] Reproducible pyc: frozenset is not serialized in a deterministic order

2021-05-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Is it possible to defer hash randomization until after pycs are generated? The underlying problem here is an intentional scrambling of data. If determinism is what is desired then deferring that action addresses the action cause of non-determinism rathe

[issue37596] Reproducible pyc: frozenset is not serialized in a deterministic order

2021-05-25 Thread Raymond Hettinger
Change by Raymond Hettinger : -- Removed message: https://bugs.python.org/msg394414 ___ Python tracker ___ ___ Python-bugs-list mail

[issue42109] Use hypothesis for testing the standard library, falling back to stubs

2021-05-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: In order to understand what Paul is concretely proposing, I read and partly reviewed his PR. I thought about maintainability. Part A adds test.support.hypothesis_helper, similar in purpose to other specialized xyz_helper modules. Hypothesis_helper imports

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-05-25 Thread hai shi
hai shi added the comment: > * functools._lru_list_elem Looks like this type have performance in issue PR-5008 when supporting GC. I am not sure there have other similar questions or not. -- ___ Python tracker

<    1   2