[issue43954] Possible missing word on unittest doc

2021-04-30 Thread Julien Palard
Julien Palard added the comment: New changeset 2abbd8f2add5e80b86a965625b9a77ae94a101cd by Zackery Spytz in branch 'master': bpo-43954: Fix a missing word in the unittest docs (GH-25672) https://github.com/python/cpython/commit/2abbd8f2add5e80b86a965625b9a77ae94a101cd -- __

[issue43954] Possible missing word on unittest doc

2021-04-30 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +24431 pull_request: https://github.com/python/cpython/pull/25741 ___ Python tracker _

[issue43954] Possible missing word on unittest doc

2021-04-30 Thread Julien Palard
Julien Palard added the comment: As far as this issue is concerned, it's fixed. The discussion about this feature not working can continue in the appropriate issue (23882) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue43954] Possible missing word on unittest doc

2021-04-30 Thread miss-islington
miss-islington added the comment: New changeset a92d7387632de1fc64de51f22f6191acd0c6f5c0 by Miss Islington (bot) in branch '3.9': bpo-43954: Fix a missing word in the unittest docs (GH-25672) https://github.com/python/cpython/commit/a92d7387632de1fc64de51f22f6191acd0c6f5c0 -- _

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: Py_TPFLAGS_IMMUTABLETYPE has been applied to array.array by Erlend in https://github.com/python/cpython/pull/25696. Should Py_TPFLAGS_IMMUTABLETYPE be applied to other heap types also (the ones that were converted from static types)? -- __

[issue41277] documentation: os.setxattr() errno EEXIST and ENODATA

2021-04-30 Thread Roundup Robot
Change by Roundup Robot : -- nosy: +python-dev nosy_count: 3.0 -> 4.0 pull_requests: +24432 pull_request: https://github.com/python/cpython/pull/25742 ___ Python tracker ___ __

[issue43968] os.path.realpath() unexpected breaking change: resolves subst'd paths to real paths

2021-04-30 Thread sfmc
sfmc added the comment: I see the point: the real path may not be accessible from the substitute drive: - if symlink (or junction) is used, pointing to path not visible from the substitute drive. - if different security context is used (e.g. different user or UAC). But that is the discussio

[issue43976] Introduce mechanism to allow Python distributors to add custom site install schemes

2021-04-30 Thread Miro Hrončok
Miro Hrončok added the comment: Cross referencing the discussion: https://discuss.python.org/t/mechanism-for-distributors-to-add-site-install-schemes-to-python-installations/8467 -- nosy: +hroncok ___ Python tracker

[issue43984] [security]winreg.SetValueEx shoule check the returned value

2021-04-30 Thread r3pwnx
New submission from r3pwnx : The library winreg[1] can be used to access registry on windows. >reg.SetValueEx(key, 'X', 0, reg.REG_DWORD, -1337) `SetValueEx` could store data in the value field of an open registry key, In the source file of "PC/winreg.c", `Py2Reg`is called first ``` stati

[issue43434] sqlite3.Connection(...) bypasses 'sqlite3.connect' audit hooks

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Steve, is it worth it to improve this? -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue43977] Implement the latest semantics for PEP 634 for matching collections

2021-04-30 Thread Mark Shannon
Mark Shannon added the comment: New changeset 069e81ab3da46c441335ca762c4333b7bd91861d by Mark Shannon in branch 'master': bpo-43977: Use tp_flags for collection matching (GH-25723) https://github.com/python/cpython/commit/069e81ab3da46c441335ca762c4333b7bd91861d -- ___

[issue43851] Optimise SQLite builds on macOS and Windows

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: If Berker does not disapprove, I'd like to apply GH-25413 and GH-25414 to the installers, Steve & Ned. -- ___ Python tracker ___ ___

[issue43985] lib2to3 fails on a slash('/') after positional_only paramter in a function signature

2021-04-30 Thread MisterY
New submission from MisterY : When I try to format a code snippet with yapf, there comes a error. It seems lib2to3 can't reconised SLASH. echo "def foo(posonly1, posonly2, /, positional_or_keyword): pass" | yapf Traceback (most recent call last): File "d:\program files\python38\lib\site-pa

[issue43985] lib2to3 fails on a slash('/') after positional_only paramter in a function signature

2021-04-30 Thread Christian Heimes
Christian Heimes added the comment: The slash syntax was introduced in 3.8. I guess the grammar of lib2to3 was not updated to support new syntax elements. Łukasz, could you please take a look? -- nosy: +christian.heimes, lukasz.langa ___ Python tra

[issue43985] lib2to3 fails on a slash('/') after positional_only paramter in a function signature

2021-04-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: https://bugs.python.org/issue36541 add support for walrus operator and positional arguments. Relevant commit : https://github.com/python/cpython/commit/06bfd033e847bedb6e123d131dcf46393a4555df Relevant yapf issue on python 3.8 support : https://gi

[issue43985] lib2to3 fails on a slash('/') after positional_only paramter in a function signature

2021-04-30 Thread MisterY
MisterY added the comment: python 3.8.3 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue43985] lib2to3 fails on a slash('/') after positional_only paramter in a function signature

2021-04-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks, the change was merged in December 14, 2020 just missing 3.8.7 . Can you please upgrade to 3.8.8 or 3.8.9 and try? If the issue still persists I guess it's then an issue with yapf since Python 3.8.8 has the code merged with tests. --

[issue43951] Two minor fixes for C module object

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: commit 175a54b2d8f967605f1d46b5cadccdcf2b54842f Author: larryhastings Date: Thu Apr 29 20:13:25 2021 -0700 Two minor fixes for accessing a module's name. (#25658) While working on another issue, I noticed two minor nits in the C implementation

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Victor: > check_set_special_type_attr() is used to prevent setting the following > attributes: > [...] > Right now, I cannot set the attribues on array.array type: > [...] > I guess that type_setattro() is used and it checks for > Py_TPFLAGS_IMMUTABLE

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: > Is this always the case? If so, can we turn the check in > check_set_special_type_attr() into an assert? In any case, > Py_TPFLAGS_IMMUTABLETYPE should be used, not !Py_TPFLAGS_HEAPTYPE. I don't know. In case of doubt, I suggest to only replace !Py_TPFLAGS

[issue43973] Use Py_TPFLAGS_IMMUTABLETYPE in __class__ assignments check

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset b73b5fb9ea08156991a065c1696e8d8cf7622482 by Erlend Egeberg Aasland in branch 'master': bpo-43973: object_set_class() checks Py_TPFLAGS_IMMUTABLETYPE (GH-25714) https://github.com/python/cpython/commit/b73b5fb9ea08156991a065c1696e8d8cf7622482

[issue43973] Use Py_TPFLAGS_IMMUTABLETYPE in __class__ assignments check

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Ok! Did you see bpo-24912 regarding the ModuleType check? -- ___ Python tracker ___ ___ P

[issue43973] Use Py_TPFLAGS_IMMUTABLETYPE in __class__ assignments check

2021-04-30 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue12883] xml.sax.xmlreader.AttributesImpl allows empty string as attribute names

2021-04-30 Thread Irit Katriel
Irit Katriel added the comment: I don't think the proposed patch is an acceptable solution. It silently skips invalid attributes. It would be ok to either raise an exception or to leave it as it is (junk-in-junk-out). I'm not sure which is better. -- nosy: +iritkatriel versions:

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Yep, I agree. From my coverage output, it seems that this branch is never executed. BUT, that may of course be because there's no test that exercises this branch. -- ___ Python tracker

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- pull_requests: +24433 pull_request: https://github.com/python/cpython/pull/25743 ___ Python tracker ___ __

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: Hum, another function should be updated. Do you want to propose a fix Erlend? static int type_set_annotations(PyTypeObject *type, PyObject *value, void *context) { if (!(type->tp_flags & Py_TPFLAGS_HEAPTYPE)) { PyErr_Format(PyExc_TypeError, "can't

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: I just found it myself :) pushing out the PR now! -- ___ Python tracker ___ ___ Python-bu

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Included in GH-25743 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue24912] The type of cached objects is mutable

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: Update: a new Py_TPFLAGS_IMMUTABLETYPE flag was added in bpo-43908, and it's now checked rather than relying on Py_TPFLAGS_HEAPTYPE to decide if a type is "mutable" or not. -- nosy: +ned.deily ___ Python tracker

[issue43973] Use Py_TPFLAGS_IMMUTABLETYPE in __class__ assignments check

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: > Ok! Did you see bpo-24912 regarding the ModuleType check? No, I didn't. Sorry, there are too many things to look at, and too little bit. Do you think that something should be changed? If yes, please open a new separated issue. --

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-24912 "The type of cached objects is mutable". -- ___ Python tracker ___ ___ Python-

[issue43916] Check that new heap types cannot be created uninitialised

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3bb09947ec4837de75532e21dd4bd25db0a1f1b7 by Victor Stinner in branch 'master': bpo-43916: Add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag (GH-25721) https://github.com/python/cpython/commit/3bb09947ec4837de75532e21dd4bd25db0a1f1b7 --

[issue43916] Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
Change by STINNER Victor : -- title: Check that new heap types cannot be created uninitialised -> Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag ___ Python tracker

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
Change by STINNER Victor : -- title: Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag -> Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag __

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
Change by STINNER Victor : -- components: +C API ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue43973] Use Py_TPFLAGS_IMMUTABLETYPE in __class__ assignments check

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: > Do you think that something should be changed? If yes, please open a new > separated issue. No, my comment was just for information :) -- ___ Python tracker

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +24434 pull_request: https://github.com/python/cpython/pull/25745 ___ Python tracker ___ __

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: PyStdPrinter_Type implements tp_new, but tp_init always fail: static int stdprinter_init(PyObject *self, PyObject *args, PyObject *kwds) { PyErr_SetString(PyExc_TypeError, "cannot create 'stderrprinter' instances"); return -1; } Ma

[issue43986] ipaddress: increment/decrement on IPv*Interface disregards bitmask prefix

2021-04-30 Thread Kat Hoessel
New submission from Kat Hoessel : IPv4 and IPv6 interface objects of the `ipaddress` library show unexpected behaviour when arithmetic operators like + (increment) and - (decrement) are run on them. `ipaddress` interfaces can be incremented/decremented, similar to IP addresses. Currently, th

[issue15443] datetime module has no support for nanoseconds

2021-04-30 Thread Mark Dickinson
Mark Dickinson added the comment: [Alexander] > Is there high enough demand for nanoseconds in datetime and time instances? One need that we've encountered in real code is simply for compatibility. We have Python code that interacts with a logging web service whose timestamps include nanose

[issue43987] Add "Annotations Best Practices" to HOWTO

2021-04-30 Thread Larry Hastings
New submission from Larry Hastings : Dealing with annotations is complicated. I think there should be a section of the Python documentation describing best practices for working with annotations. So, here goes. The best spot I found for it was as a new HOWTO. I added links to that HOWTO to

[issue24912] The type of cached objects is mutable

2021-04-30 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- nosy: +erlendaasland nosy_count: 17.0 -> 18.0 pull_requests: +24435 pull_request: https://github.com/python/cpython/pull/25714 ___ Python tracker

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: https://docs.python.org/dev/c-api/typeobj.html#Py_TPFLAGS_IMMUTABLETYPE says: "This bit is set for type objects that are immutable: type attributes cannot be set nor deleted." Is it possible that a metatype (type subtype) overrides tp_setattro and ignores th

[issue43987] Add "Annotations Best Practices" to HOWTO

2021-04-30 Thread Larry Hastings
Change by Larry Hastings : -- keywords: +patch pull_requests: +24436 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/25746 ___ Python tracker __

[issue43987] Add "Annotations Best Practices" to HOWTO

2021-04-30 Thread Larry Hastings
Change by Larry Hastings : -- nosy: +Jelle Zijlstra ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: Erlend: would you mind to document the new Py_TPFLAGS_IMMUTABLETYPE flag in the C API section of What's New in Python 3.10? https://docs.python.org/dev/whatsnew/3.10.html#c-api-changes In "New Features", something like: * Add a new :c:data:`Py_TPFLAGS_IMMUTA

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Yes, I’ll have a look at it this afternoon. (On mobile now.) -- ___ Python tracker ___ ___

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: The CVE-2021-29921 was assigned to this vulnerability. -- title: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal -> [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambig

[issue43981] test_idle is leaking references

2021-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I will try to investigate today or tomorrow but notice that is very possible that the leak is somewhere else in the interpreter and is just showing in the IDLE tests. -- ___ Python tracker

[issue37387] test_compileall fails randomly on Windows when tests are run in parallel

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: I proposed a way to fix the issue: "Maybe the test should copy all .py files of the stdlib into a temporary directory and work there, to not impact other tests run in parallel." Shreyan Avigyan: > Though I've never been able to reproduce this test failure.

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 0cad068ec174bbe33fb80460da56eb413f3b9359 by Victor Stinner in branch 'master': bpo-43916: Remove _disabled_new() function (GH-25745) https://github.com/python/cpython/commit/0cad068ec174bbe33fb80460da56eb413f3b9359 --

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- pull_requests: +24437 pull_request: https://github.com/python/cpython/pull/25748 ___ Python tracker ___ __

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +24438 pull_request: https://github.com/python/cpython/pull/25749 ___ Python tracker ___ __

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4908fae3d57f68694cf006e89fd7761f45003447 by Victor Stinner in branch 'master': bpo-43916: PyStdPrinter_Type uses Py_TPFLAGS_DISALLOW_INSTANTIATION (GH-25749) https://github.com/python/cpython/commit/4908fae3d57f68694cf006e89fd7761f45003447 ---

[issue43922] Double dots in quopri transported emails

2021-04-30 Thread Julien Castiaux
Julien Castiaux added the comment: Fix deployed in the third party -- resolution: -> third party stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43667] Solaris: Fix broken Unicode encoding in non-UTF locales

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9032cf5cb1e33c0349089cfb0f6bf11ed3c30e86 by Jakub Kulík in branch 'master': bpo-43667: Fix broken Unicode encoding in non-UTF locales on Solaris (GH-25096) https://github.com/python/cpython/commit/9032cf5cb1e33c0349089cfb0f6bf11ed3c30e86 --

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 64141382ecbad665d5738ff26d15505f3427c724 by Erlend Egeberg Aasland in branch 'master': bpo-43908: check_set_special_type_attr() checks Py_TPFLAGS_IMMUTABLETYPE (GH-25743) https://github.com/python/cpython/commit/64141382ecbad665d5738ff26d15505f

[issue40222] "Zero cost" exception handling

2021-04-30 Thread Mark Shannon
Change by Mark Shannon : -- keywords: +patch pull_requests: +24440 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25729 ___ Python tracker ___ ___

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- pull_requests: +24439 pull_request: https://github.com/python/cpython/pull/25750 ___ Python tracker ___ __

[issue43933] Regression in python3.10 with traceback frame having lineno of -1

2021-04-30 Thread Mark Shannon
Mark Shannon added the comment: New changeset 5979e81a212949c62c2490167c9137d233d7de64 by Mark Shannon in branch 'master': bpo-43933: Set frame.f_lineno during call to __exit__ (GH-25719) https://github.com/python/cpython/commit/5979e81a212949c62c2490167c9137d233d7de64 --

[issue43933] Regression in python3.10 with traceback frame having lineno of -1

2021-04-30 Thread Mark Shannon
Mark Shannon added the comment: I'm claiming that this is fixed. Feel free to reopen if the additional line in tracing causes a problem. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 387397f8a4244c983f4568c16a28842e3268fe5d by Erlend Egeberg Aasland in branch 'master': bpo-43916: select.poll uses Py_TPFLAGS_DISALLOW_INSTANTIATION (GH-25750) https://github.com/python/cpython/commit/387397f8a4244c983f4568c16a28842e3268fe5d -

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9746cda705decebc0ba572d95612796afd06dcd4 by Erlend Egeberg Aasland in branch 'master': bpo-43916: Apply Py_TPFLAGS_DISALLOW_INSTANTIATION to selected types (GH-25748) https://github.com/python/cpython/commit/9746cda705decebc0ba572d95612796afd06d

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Pablo & Serhiy, can we close this issue now? -- ___ Python tracker ___ ___ Python-bugs-li

[issue4130] Intel icc 9.1 does not support __int128_t used by ctypes

2021-04-30 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue43988] Add test.support.assert_dissallow_instantiation

2021-04-30 Thread Erlend Egeberg Aasland
New submission from Erlend Egeberg Aasland : See https://github.com/python/cpython/pull/25748#discussion_r623849521: "What do you think of adding support.assert_disallow_instanciation(type, *args) function which would check for TypeError but also check the error message? TypeError is quite gen

[issue43988] Add test.support.assert_dissallow_instantiation

2021-04-30 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: Currently, 33 types explicitly set the Py_TPFLAGS_DISALLOW_INSTANTIATION flag: * PyStdPrinter_Type * _curses.ncurses_version type * _curses_panel.panel * _dbm.dbm * _gdbm.gdbm * _hashlib.HASH * _hashlib.HASHXOF * _hashlib.HMAC * _multibytecodec.MultibyteCodec

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: I remove the release blocker priority of this issue, since the main issue has been fixed. -- priority: release blocker -> ___ Python tracker __

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: Currently, 4 types are declared with Py_TPFLAGS_IMMUTABLETYPE explicitly: * array.array * re.Pattern * re.Match * _sre.SRE_Scanner -- ___ Python tracker ___

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: Moreover, all static types get the Py_TPFLAGS_IMMUTABLETYPE flag automatically. For example, "./python -c pass" initializes 196 immutable static types: * ArithmeticError * AssertionError * AttributeError * BaseException * BlockingIOError * BrokenPipeError * B

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: Victor, the types, that Py_TPFLAGS_IMMUTABLETYPE flag is yet to be applied to, are different for 3.9 and 3.10. Should we proceed with that? (If yes I'd be happy to collaborate with Erlend to apply the flag on those types.) -- __

[issue14243] tempfile.NamedTemporaryFile not particularly useful on Windows

2021-04-30 Thread Zachary Ware
Zachary Ware added the comment: > if NamedTemporaryFile is used as a context manager, the file is closed *on > context manager exit* and *not* when the file is closed. +1 -- ___ Python tracker

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: > Victor, the types, that Py_TPFLAGS_IMMUTABLETYPE flag is yet to be applied > to, are different for 3.9 and 3.10. Should we proceed with that? (If yes I'd > be happy to collaborate with Erlend to apply the flag on those types.) Please don't change the behav

[issue37387] test_compileall fails randomly on Windows when tests are run in parallel

2021-04-30 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: Ok -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: Ok -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue43908] array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag

2021-04-30 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: Ok -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue43710] Access violations in C extension modules on Python 3.9.3

2021-04-30 Thread Anjali Singh
Change by Anjali Singh : Added file: https://bugs.python.org/file50002/Screenshot_20210426-104915_Lucknow Public School.jpg ___ Python tracker ___ ___

[issue14243] tempfile.NamedTemporaryFile not particularly useful on Windows

2021-04-30 Thread Paul Moore
Paul Moore added the comment: Looking at the various comments, I think we have 5 votes for deleting on CM exit when used as a CM, and no change in behaviour otherwise (me, Zachary, Ethan, Jason and Steve). Steve also wants O_TEMPORARY to be removed, which doesn't seem controversial among thi

[issue43710] Access violations in C extension modules on Python 3.9.3

2021-04-30 Thread Zachary Ware
Change by Zachary Ware : Removed file: https://bugs.python.org/file49966/logs.gz ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue43710] Access violations in C extension modules on Python 3.9.3

2021-04-30 Thread Zachary Ware
Change by Zachary Ware : Removed file: https://bugs.python.org/file50002/Screenshot_20210426-104915_Lucknow Public School.jpg ___ Python tracker ___ _

[issue43933] Regression in python3.10 with traceback frame having lineno of -1

2021-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks Mark for the quick fix! Can someone confirm if the pytest issue is fixed? -- ___ Python tracker ___ __

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Unfortunately commit 2f2b69855d6524e15d12c15ddc0adce629e7de84 has broken the buildbots: == FAIL: test_annotations_are_created_correctly (test.test_module.ModuleTests) -

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think that test_annotations_are_created_correctly should use the import_helper.import_fresh_module helper -- ___ Python tracker ___

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +24441 pull_request: https://github.com/python/cpython/pull/25751 ___ Python tracker ___ __

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Larry Hastings
Larry Hastings added the comment: Gee whiz! Sorry about that. I swear, it works fine on my machine. I'll incorporate import_helper.import_fresh_module helper into the test as you suggest, and once I get it to work I'll send you a PR. I don't know how to test fixing this failure, though, b

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: According to msg391924, more types should use Py_TPFLAGS_DISALLOW_INSTANTIATION: * _md5.md5 * _sha1.sha1 * _sha256.sha224 * _sha256.sha256 * _sha512.sha384 * _sha512.sha512 * select.devpoll: I created PR 25751 * select.kevent: it implements a working tp_new m

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Oh, actually is workse because commenting out the test shows refleaks: 𓋹 ./python.exe -m test test_module -R : 0:00:00 load avg: 5.03 Run tests sequentially 0:00:00 load avg: 5.03 [1/1] test_module beginning 9 repetitions 123456789 . test_module

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: >> Why would it fail on Windows? It fails on all refleak buildbots. To reproduce: % ./configure --with-pydebug -C && make -j -s % ./python.exe -m test test_module -R : -- ___ Python tracker

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +24443 pull_request: https://github.com/python/cpython/pull/25753 ___ Python tracker ___ __

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Larry Hastings
Change by Larry Hastings : -- pull_requests: +24442 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/25752 ___ Python tracker ___ __

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Larry Hastings
Larry Hastings added the comment: Eek! I swear I did a refleak check and got a clean bill of health. Again, sorry about this! -- ___ Python tracker ___

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +2 pull_request: https://github.com/python/cpython/pull/25754 ___ Python tracker ___ ___

[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2021-04-30 Thread STINNER Victor
STINNER Victor added the comment: * _md5.md5 * _sha1.sha1 * _sha256.sha224 * _sha256.sha256 * _sha512.sha384 * _sha512.sha512 I created PR 25753. -- ___ Python tracker ___ __

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Eek! I swear I did a refleak check and got a clean bill of health. Again, > sorry about this! No problem at all! I'm sure we can fix this on time :) Opened https://github.com/python/cpython/pull/25754 for the refleaks --

[issue43901] Lazy-create an empty annotations dict in all unannotated user classes and modules

2021-04-30 Thread Larry Hastings
Larry Hastings added the comment: You want a separate PR for the refleak fix, or should I roll them both up into one? -- ___ Python tracker ___ __

[issue43984] [security]winreg.SetValueEx shoule check the returned value

2021-04-30 Thread Shreyan Avigyan
Shreyan Avigyan added the comment: +1 on my side. -- nosy: +paul.moore, shreyanavigyan, steve.dower, stutzbach, tim.golden, zach.ware ___ Python tracker ___ __

[issue29753] [Linux] ctypes packs bitfields Incorrectly

2021-04-30 Thread Filipe Laíns
Filipe Laíns added the comment: I forgot to ping here, the patch went in and should be available in 3.10, so this can be closed now. -- nosy: +jaraco ___ Python tracker ___ __

  1   2   3   >