[issue43894] IDLE editor file minor refactoring

2021-04-23 Thread Éric Araujo
Éric Araujo added the comment: Hello and thanks for wanting to contribute to Python! In the CPython project, stylistic changes are not made by themselves as a matter of course (accross the whole codebase or in a specific module): among reasons, these obfuscate file history, need reviewer time

[issue43895] Unnecessary Cache of Shared Object Handles

2021-04-23 Thread Ian H
Change by Ian H : -- keywords: +patch pull_requests: +24282 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25487 ___ Python tracker ___ __

[issue43895] Unnecessary Cache of Shared Object Handles

2021-04-23 Thread Éric Araujo
Change by Éric Araujo : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue43923] Can't create generic NamedTuple as of py3.9

2021-04-23 Thread Eric V. Smith
Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue43908] array.array should remain immutable

2021-04-23 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: BTW, slightly related, AFAICT: - https://github.com/python/cpython/blob/e047239eafefe8b19725efffe7756443495cf78b/Objects/typeobject.c#L4620-L4668 - bpo-24912 -- ___ Python tracker

[issue43914] Highlight invalid ranges in SyntaxErrors

2021-04-23 Thread Éric Araujo
Éric Araujo added the comment: What a great, useful change! -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailin

[issue30713] Reject newline character (U+000A) in URLs in urllib.parse

2021-04-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue43883] Making urlparse WHATWG conformant

2021-04-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue43908] array.array should remain immutable

2021-04-23 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: I've prepared a diff using grep & sed (see attached patch). Let me know if you want it converted to a PR. I've excluded the test and the _xx extension modules. -- Added file: https://bugs.python.org/file49979/apply-to-all.diff __

[issue43908] array.array should remain immutable

2021-04-23 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : Added file: https://bugs.python.org/file49980/apply-to-all.diff ___ Python tracker ___ ___ Python-bugs-li

[issue43908] array.array should remain immutable

2021-04-23 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : Removed file: https://bugs.python.org/file49979/apply-to-all.diff ___ Python tracker ___ ___ Python-bugs-

[issue43911] Queue.get() memory leak

2021-04-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Here's a more compact version of the variant with an underlying dict: class MyQueue(Queue): def _init(self, maxsize): self.end = 0 self.q = {} def _qsize(self): return len(self.q) def _put(self

[issue38605] [typing] PEP 563: Postponed evaluation of annotations: enable it by default in Python 3.11

2021-04-23 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > Hopefully Batuhan has a recollection of what I am thinking of, there was some > significant delay while we figured out what to do about some of these. The major one that I'd recall is that inspect.signature() just uses whatever is in __annotations__ inste

[issue43926] Clean metadata (importlib_metadata 4.0)

2021-04-23 Thread Jason R. Coombs
New submission from Jason R. Coombs : [importlib_metadata 4.0](https://importlib-metadata.readthedocs.io/en/latest/history.html#v4-0-0) introduced these important changes to the `metadata` function: ``PackageMetadata`` as returned by ``metadata()`` and ``Distribution.metadata()`` now provid

[issue39950] Add pathlib.Path.hardlink_to()

2021-04-23 Thread miss-islington
miss-islington added the comment: New changeset f24e2e5464ba6498e7b8d73c3f9b417d59fd1b26 by Barney Gale in branch 'master': bpo-39950: add `pathlib.Path.hardlink_to()` method that supersedes `link_to()` (GH-18909) https://github.com/python/cpython/commit/f24e2e5464ba6498e7b8d73c3f9b417d59fd1

[issue43864] [Windows] test_importlib logs: DeprecationWarning: WindowsRegistryFinder.find_module() is deprecated and slated for removal in Python 3.12; use find_spec() instead

2021-04-23 Thread Brett Cannon
Change by Brett Cannon : -- keywords: +patch pull_requests: +24283 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25563 ___ Python tracker ___ ___

[issue43894] IDLE editor file minor refactoring

2021-04-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: This started as an extraction and revision of changes in Tal's PR, one of which appeared to be an intended behavior change, that I requested there. Paine may have expanded the scope more than I intended. Will look soon. --

[issue43894] IDLE editor file minor refactoring

2021-04-23 Thread E. Paine
E. Paine added the comment: I agree with your points and understand that there is good reason for the PR to be rejected. If Terry decides it's too big (I did do a lot more than what was originally in PR-22682), I am more than happy to close this issue. -- ___

[issue43907] pickle.py bytearray memoization bug with protocol 5

2021-04-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: New changeset 1e9f0933095403b215c2c4a0be7915d034ff7026 by Carl Friedrich Bolz-Tereick in branch 'master': bpo-43907: add missing memoize call in pure python pickling of bytearray (GH-25501) https://github.com/python/cpython/commit/1e9f0933095403b215c2c4a0be7

[issue43907] pickle.py bytearray memoization bug with protocol 5

2021-04-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the report and fix! -- components: +Library (Lib) resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior versions: +Python 3.10 ___ Python tracker

[issue43762] Add audit events for loading of sqlite3 extensions

2021-04-23 Thread Steve Dower
Steve Dower added the comment: Left some minor suggestions on the PR, but wanted to copy this comment here as well: I wonder if it's worth returning the connection object when it's created (through a new event in module.c) and then reference it in these events? That can then correlate these

[issue40432] Pegen regenerate project for Windows not working

2021-04-23 Thread Steve Dower
Steve Dower added the comment: Thanks for the PR, kj! Left a suggestion for you, but otherwise it should solve the problem nicely. -- ___ Python tracker ___ _

[issue43652] Upgrade Windows tcl/tk to 8.6.11

2021-04-23 Thread Steve Dower
Steve Dower added the comment: Thanks for finishing up that patch. And yes, we add a ".0" in case we need to patch the sources ourselves. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue43926] Clean metadata (importlib_metadata 4.0)

2021-04-23 Thread Jason R. Coombs
Change by Jason R. Coombs : -- keywords: +patch pull_requests: +24284 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25565 ___ Python tracker ___

[issue42361] Use Tcl/Tk 8.6.10 in build-installer.py when building on recent macOS

2021-04-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Close this? Upgrade done, twice. -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-li

[issue43649] time.strftime('%z') doesn't return UTC offset in the form ±HHMM

2021-04-23 Thread Steve Dower
Steve Dower added the comment: I agree with Eryk, this is not an issue with the supported C runtime. mingw-w64 has supposedly been working on UCRT support (it may even be working already?), and that is what will be necessary. We certainly aren't going to try and runtime detect this and reimp

[issue43927] Remove IOError references from the tutorial

2021-04-23 Thread Tim Huegerich
New submission from Tim Huegerich : Although IOError has been merged into OSError since version 3.3, Section 8.5 of the Tutorial still uses it in examples. The Python 9.4 version of the tutorial features an example raising an IOError, which is then output as OSError, raising potential confus

[issue30555] _io._WindowsConsoleIO breaks in the face of fd redirection

2021-04-23 Thread Steve Dower
Steve Dower added the comment: New changeset 5e437fb872279960992c9a07f1a4c051b4948c53 by Segev Finer in branch 'master': bpo-30555: Fix WindowsConsoleIO fails in the presence of fd redirection (GH-1927) https://github.com/python/cpython/commit/5e437fb872279960992c9a07f1a4c051b4948c53 -

[issue30555] _io._WindowsConsoleIO breaks in the face of fd redirection

2021-04-23 Thread Steve Dower
Steve Dower added the comment: Thanks for persisting with this change. Looks like backports will have to be manual, and I'm not going to get to them today myself, but if someone else wants to do it then feel free. I'm pretty sure this won't have any (negative) visible impact, but just in ca

[issue42725] PEP 563: Should the behavior change for yield/yield from's

2021-04-23 Thread Larry Hastings
Larry Hastings added the comment: I think stringized annotations should prohibit the same things PEP 649 prohibits: walrus, yield / yield from, and await. This was easy in my 649 branch; walrus adds locals, and yield / yield from make it a generator. So the code raises an error if the gener

[issue42725] PEP 563: Should the behavior change for yield/yield from's

2021-04-23 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > This was easy in my 649 branch; walrus adds locals, and yield / yield from > make it a generator. So the code raises an error if the generated > annotations code object has locals or is a generator. I don't think I had to > do anything special to prohib

[issue38659] enum classes cause slow startup time

2021-04-23 Thread Ethan Furman
Change by Ethan Furman : -- pull_requests: +24285 pull_request: https://github.com/python/cpython/pull/25566 ___ Python tracker ___

[issue43652] Upgrade Windows tcl/tk to 8.6.11

2021-04-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Previous issue, which I mistyped, was #39107. Release notes at https://sourceforge.net/projects/tcl/files/Tcl/8.6.11/tcltk-release-notes-8.6.11.txt/view -- ___ Python tracker __

[issue41277] documentation: os.setxattr() errno EEXIST and ENODATA

2021-04-23 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 2.0 -> 3.0 pull_requests: +24286 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25567 ___ Python tracker

[issue42725] PEP 563: Should the behavior change for yield/yield from's

2021-04-23 Thread Larry Hastings
Larry Hastings added the comment: Wouldn't it be easier to just throw an exception in the stringizing code? I note that there are dedicated functions to generate walrus, yield, yield from, and await in Python/ast_unparse.c. In theory this is a general-purpose facility, but in practice it's

[issue43776] Popen with shell=True yield mangled repr output

2021-04-23 Thread mkocher
mkocher added the comment: There's a PR up with removed `list` call as well as improved test coverage for the case where args is passed into Popen as a string. Hopefully this can get merged before things starting getting crazy with the 3.10 release crunch. -- _

[issue43924] print unexpected values in infinite loop

2021-04-23 Thread Steven D'Aprano
Steven D'Aprano added the comment: I'm closing this as "Works for me". rafihassan190041234, if you still think it is a bug in the language, rather than a bug in your code or a mistake in your understanding, you can re-open this with more details. As Zach already commented, you need to give u

[issue38659] enum classes cause slow startup time

2021-04-23 Thread Ethan Furman
Ethan Furman added the comment: New changeset 6c681e1a4aa2dbca61be9a26c9257d7d25fa29a7 by Ethan Furman in branch 'master': bpo-38659: [Enum] do not check '_inverted_' during simple test (GH-25566) https://github.com/python/cpython/commit/6c681e1a4aa2dbca61be9a26c9257d7d25fa29a7 --

[issue42725] PEP 563: Should the behavior change for yield/yield from's

2021-04-23 Thread Guido van Rossum
Guido van Rossum added the comment: So shouldn't we just rule out some specific bits of syntax in annotations? That can be done after the PEG grammar has accepted them, otherwise we'd end up having a whole new expression-like grammar section that excludes them. I think this is the list we sh

[issue38605] [typing] PEP 563: Postponed evaluation of annotations: enable it by default in Python 3.11

2021-04-23 Thread Guido van Rossum
Guido van Rossum added the comment: I don't like adding a flag. In the PEP-563-by-default world we didn't need a flag. Perhaps once Larry implements inspect.get_annotations() (issue43817) we can make inspect.signature() always call that? -- ___

[issue43928] Fix the typo in documentation

2021-04-23 Thread Jeffrey Tse
Change by Jeffrey Tse : -- assignee: docs@python components: Documentation nosy: docs@python, jeffreytse.mail priority: normal severity: normal status: open title: Fix the typo in documentation versions: Python 3.8 ___ Python tracker

[issue43908] array.array should remain immutable

2021-04-23 Thread Guido van Rossum
Guido van Rossum added the comment: Does the test suite pass for apply-to-all.diff? Also, quite a hornet's nest you've uncovered (about __class__ assignment). Would that be fixed better with the IMMUTABLE flag? -- ___ Python tracker

[issue43928] Fix the typo in documentation

2021-04-23 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 2.0 -> 3.0 pull_requests: +24287 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25568 ___ Python tracker _

[issue43928] Fix the typo in documentation

2021-04-23 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue43776] Popen with shell=True yield mangled repr output

2021-04-23 Thread mkocher
mkocher added the comment: There also appears to be an issue when args are provided as a `pathlib.Path` instance. Python 3.9.2 | packaged by conda-forge | (default, Feb 21 2021, 05:02:20) Type 'copyright', 'credits' or 'license' for more information IPython 7.22.0 -- An enhanced Interactive

[issue31870] add timeout parameter for get_server_certificate in ssl.py

2021-04-23 Thread miss-islington
miss-islington added the comment: New changeset b2fac1afaa7c0d41a263781fcf94d8a92dc31b48 by Zackery Spytz in branch 'master': bpo-31870: Add a timeout parameter to ssl.get_server_certificate() (GH-22270) https://github.com/python/cpython/commit/b2fac1afaa7c0d41a263781fcf94d8a92dc31b48 -

[issue43928] Fix the typo in documentation

2021-04-23 Thread Jeffrey Tse
Change by Jeffrey Tse : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue43817] Add inspect.get_annotations()

2021-04-23 Thread Larry Hastings
Larry Hastings added the comment: Time runs short for Python 3.10b1. Can I get a review from anybody here, say over the weekend? -- ___ Python tracker ___ __

[issue31870] add timeout parameter for get_server_certificate in ssl.py

2021-04-23 Thread Christian Heimes
Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.8 ___ Python tracker ___ _

[issue43928] Fix the typo in documentation

2021-04-23 Thread Jeffrey Tse
Change by Jeffrey Tse : -- pull_requests: +24288 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/25569 ___ Python tracker ___ _

[issue31870] add timeout parameter for get_server_certificate in ssl.py

2021-04-23 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +24289 pull_request: https://github.com/python/cpython/pull/25570 ___ Python tracker ___

[issue31870] add timeout parameter for get_server_certificate in ssl.py

2021-04-23 Thread Christian Heimes
Christian Heimes added the comment: New changeset f05c2aed7e25087122613b51f152919c79641f66 by Christian Heimes in branch 'master': bpo-31870: Fix test_get_server_certificate_timeout on Windows (GH-25570) https://github.com/python/cpython/commit/f05c2aed7e25087122613b51f152919c79641f66 -

<    1   2