[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

2020-01-21 Thread Brett Cannon
Brett Cannon added the comment: There's no deprecation warning because how do you warn about that? You raise DeprecationWarning about an exception you have yet to raise? And I personally think calling this unfair is a bit harsh. -- ___ Python trac

[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

2020-01-21 Thread Miro Hrončok
Miro Hrončok added the comment: I know that raising a DeprecationWarning here is most likely not possible or too black-magical to do. My intention was not to be harsh, sorry about that. I just wanted to point out that a backwards incompatible behavior like this without a (possible) deprecatio

[issue39390] shutil.copytree - 3.8 changed argument types of the ignore callback

2020-01-21 Thread Manuel Barkhau
Manuel Barkhau added the comment: Unless somebody else wants to, I could have a go at an PR to update shutil.py -- ___ Python tracker ___ _

[issue1812] doctest _load_testfile function -- newline handling seems incorrect

2020-01-21 Thread Peter Donis
Peter Donis added the comment: Pinging as a reminder that there is a pull request for this issue awaiting review. -- ___ Python tracker ___ ___

[issue39390] shutil.copytree - 3.8 changed argument types of the ignore callback

2020-01-21 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Yes, thanks. Whoever got bit by this is either getting an exception or not the intended behavior (due to failed string comparison). I doubt anybody is relying on the new type checking since it's not documented. If they are, they are probably just doing:

[issue39390] shutil.copytree - 3.8 changed argument types of the ignore callback

2020-01-21 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue39408] Add support for SQLCipher

2020-01-21 Thread Sebastian Noack
Sebastian Noack added the comment: Yes, I could use LD_LIBRARY_PATH (after copying /usr/lib/libsqlcipher.so.0 to /some/folder/libsqlite3.so), or alternatively LD_PRELOAD, and the sqlite3 stdlib module will just work as-is with SQLCipher. The latter is in fact what I'm doing at the moment, bu

[issue31405] shutil.which doesn't find files without PATHEXT extension on Windows

2020-01-21 Thread Anthony Sottile
Anthony Sottile added the comment: should I open a new issue for this, or is this an appropriate task to add to this discussion shutil.which also doesn't apply `PATHEXT` when the path contains a directory separator C:\Users\IEUser\astpretty>venv\Scripts\python --version Python 3.7.5 C:\Use

[issue39375] Document os.environ[x] = y and os.putenv() as thread unsafe

2020-01-21 Thread Eryk Sun
Change by Eryk Sun : -- Removed message: https://bugs.python.org/msg360245 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39411] pyclbr rewrite using AST

2020-01-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Nice. A few notes. Docs: The initial doc paragraph now has 'module browser' rather than 'class browser'. The change is needed 2 other places. Could be part of this PR or another one. * Chapter title: "Python class browser support". The only instance of '

[issue18819] tarfile fills devmajor and devminor fields even for non-devices

2020-01-21 Thread Ethan Furman
Ethan Furman added the comment: Thanks for moving this issue forward, William! -- assignee: -> ethan.furman stage: patch review -> test needed ___ Python tracker ___

[issue39416] Document default numeric string formats

2020-01-21 Thread Karl O. Pinc
New submission from Karl O. Pinc : Seems sane to put _some_ restrictions on the string representations of the Numeric classes. This would be a change to the Python language specification. Suggestions made in a pull request. See the email thread: Subject: Documenting Python's float.__str__()

[issue39408] Add support for SQLCipher

2020-01-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: It might help if you show the change you actually propose. -- nosy: +benjamin.peterson ___ Python tracker ___

[issue39416] Document default numeric string formats

2020-01-21 Thread Karl O. Pinc
Change by Karl O. Pinc : -- keywords: +patch pull_requests: +17498 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18111 ___ Python tracker ___ ___

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +17499 pull_request: https://github.com/python/cpython/pull/18112 ___ Python tracker ___ __

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 0d5eac8c327251f8edde5261cee43975d81311f6 by Benjamin Peterson (Dong-hee Na) in branch 'master': closes bpo-39415: Remove unused codes from longobject.c complexobject.c floatobject.c. (GH-18105) https://github.com/python/cpython/commit/0d5eac

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +17500 pull_request: https://github.com/python/cpython/pull/18113 ___ Python tracker ___ __

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread Eryk Sun
Eryk Sun added the comment: > Python can safely removes the string to _putenv() just after the call? Windows ucrt copies the buffer that's passed to _[w]putenv. This makes it non-compliant with POSIX but easier to use in this case. Here's an example using ctypes: >>> ucrt = ctypes.CDLL

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread miss-islington
miss-islington added the comment: New changeset a755410e054e1e2390de5830befc08fe80706c66 by Miss Islington (bot) in branch '3.8': closes bpo-39415: Remove unused codes from longobject.c complexobject.c floatobject.c. (GH-18105) https://github.com/python/cpython/commit/a755410e054e1e2390de583

[issue18842] Add float.is_finite is_nan is_infinite to match Decimal methods

2020-01-21 Thread Dong-hee Na
Dong-hee Na added the comment: rm-finite.patch was applied by bpo-39415. > Once that's merged, let's close this issue as rejected. I close this issue to a rejected state as discussed above. Thank you to all who participated in this discussion. -- nosy: +corona10 resolution: -> rejec

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread Dong-hee Na
Dong-hee Na added the comment: Thank you to all who participated in this discussion and review :) -- ___ Python tracker ___ ___ Pyt

[issue39416] Document default numeric string formats

2020-01-21 Thread Eric V. Smith
Eric V. Smith added the comment: Is the lack of this documentation causing some confusion somewhere? This isn't rhetorical, I'm genuinely curious what problem you're trying to solve. Is there any mainstream programming language where the basics of what you've laid out aren't true? It all see

[issue39375] Document os.environ[x] = y and os.putenv() as thread unsafe

2020-01-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: fwiw, no need to remove that message. We'll want to make the docs clear that this does not apply to Windows. :) -- ___ Python tracker __

<    1   2