[issue39396] AIX: self.assertEqualSign(math.nextafter(-0.0, +0.0), +0.0) test fails on AIX

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +17484 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18094 ___ Python tracker ___ _

[issue39396] AIX: self.assertEqualSign(math.nextafter(-0.0, +0.0), +0.0) test fails on AIX

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: > For this particular case, I'd be fine with adding a special case for `x == y` > in the code (suitably commented to explain why the special case is there, and > under what conditions it can be removed). I proposed PR 18094. Because of your parenthesis, I c

[issue39399] Cross compilation using different libc is broken

2020-01-21 Thread Andrew Aladjev
Andrew Aladjev added the comment: Hello, it seems like issue 22724 is completely the same. Let's discuss solutions there. Thank you. -- ___ Python tracker ___ ___

[issue22724] byte-compile fails for cross-builds

2020-01-21 Thread Andrew Aladjev
Change by Andrew Aladjev : -- nosy: +puchenyaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue39397] Mac : fail to launch Python 3.8

2020-01-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: An additional question: what version of macOS are you using? -- ___ Python tracker ___ ___ Pytho

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread STINNER Victor
New submission from STINNER Victor : Currently, os.putenv() is always implemented with putenv(). The problem is that putenv(str) puts directly the string into the environment, the string is not copied. So Python has to keep track of this memory. In Python 3.9, this string is now cleared at Py

[issue22724] byte-compile fails for cross-builds

2020-01-21 Thread Andrew Aladjev
Andrew Aladjev added the comment: Hello. I've provided a double recompilation workaround in the following gentoo bug https://bugs.gentoo.org/705970. You can use it for now if you don't want to wait until this issue will be fixed. I will try patches provided by people in this issue today's ev

[issue39395] The os module should unset() environment variable at exit

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: Fedora downstream issue, crash in the "elements" package: https://bugzilla.redhat.com/show_bug.cgi?id=1791761 -- ___ Python tracker ___

[issue35003] Provide an option to venv to put files in a bin/ directory on Windows

2020-01-21 Thread Vinay Sajip
Vinay Sajip added the comment: The Scripts/bin thing is not specific to venv - for whatever reason, the original Windows implementation chose to use "Scripts" rather than "bin" for the executables directory under Windows, and I don't think it can be changed now without affecting backward com

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +17485 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18095 ___ Python tracker ___ _

[issue39395] The os module should unset() environment variable at exit

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: I proposed bpo-39406 which avoids to have to clear environment variables set by Python at exit on platforms providing setenv(). -- ___ Python tracker __

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: setenv() is available on: * Linux: http://man7.org/linux/man-pages/man3/setenv.3.html * macOS: https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/setenv.3.html * FreeBSD: https://www.freebsd.org/cgi/man.cgi?que

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Maybe use SetEnvironmentVariable() on Windows? -- nosy: +serhiy.storchaka ___ Python tracker ___ __

[issue39407] Bitfield Union does not work for bit widths greater than 8 bits

2020-01-21 Thread James
New submission from James : Creating a Bitfield from a ctypes union and structure results in unexpected behaviour. It seems when you set the bit-width of a structure field to be greater than 8 bits it results in the subsequent bits being set to zero. class BitFieldStruct(ctypes.LittleEndian

[issue39408] Add support for SQLCipher

2020-01-21 Thread Sebastian Noack
New submission from Sebastian Noack : SQLCipher is industry-standard technology for managing an encrypting SQLite databases. It has been implemented as a fork of SQLite3. So the sqlite3 corelib module would build as-is against it. But rather than a fork (of this module), I'd rather see integr

[issue39396] AIX: self.assertEqualSign(math.nextafter(-0.0, +0.0), +0.0) test fails on AIX

2020-01-21 Thread Mark Dickinson
Mark Dickinson added the comment: So on cmath.exp, we've seen something like this before, on macOS. What was happening was that the C source contained matching `sin` and `cos` calls, and a compiler optimization replaced that pair of calls with a single call to C's cexp. And then cexp didn't

[issue39396] AIX: self.assertEqualSign(math.nextafter(-0.0, +0.0), +0.0) test fails on AIX

2020-01-21 Thread Mark Dickinson
Mark Dickinson added the comment: > I don't have an issue reference to hand See #18513. -- ___ Python tracker ___ ___ Python-bugs-

[issue39397] Mac : fail to launch Python 3.8

2020-01-21 Thread Sebastien Foo
Sebastien Foo added the comment: thanks averyone to help me here are the values you are expecting locale LANG="en_US" LC_COLLATE="en_US" LC_CTYPE="en_US" LC_MESSAGES="en_US" LC_MONETARY="en_US" LC_NUMERIC="en_US" LC_TIME="en_US" LC_ALL= doing env I get this (no LC_ALL ) LC_TERMINAL_VERSION=3.

[issue39397] Mac : fail to launch Python 3.8

2020-01-21 Thread Inada Naoki
Inada Naoki added the comment: > doing env I get this (no LC_ALL ) [snip] > LC_CTYPE=en_US This is wrong setting. Find where this environment variable is set and remove it. -- ___ Python tracker _

[issue39404] Pexpect : setwinsize() not working in SLES 12.4 kernel 4.12.14-94.41-default

2020-01-21 Thread Archana Pandey
Change by Archana Pandey : -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pyth

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: > Maybe use SetEnvironmentVariable() on Windows? I didn't know this function. I updated PR 18095. -- ___ Python tracker ___

[issue22724] byte-compile fails for cross-builds

2020-01-21 Thread Andrew Aladjev
Andrew Aladjev added the comment: I've made a quick test of all patches provided. All patches have failed to fix it. The problem is more heavy than it looks like. Please look at the following code: PYTHON_FOR_BUILD='_PYTHON_PROJECT_BASE=$(abs_builddir) _PYTHON_HOST_PLATFORM=$(_PYTHON_HOST_P

[issue32989] IDLE: Fix pyparse.find_good_parse_start

2020-01-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +17486 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/18096 ___ Python tracker ___ ___

[issue32989] IDLE: Fix pyparse.find_good_parse_start

2020-01-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset ec64640a2c5236d7a5d5470d759172a3d93eab0b by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968) https://github.com/python/cpython/commit/ec64640a2c5236d7a5d5470d759172a3d93eab0b

[issue32989] IDLE: Fix pyparse.find_good_parse_start

2020-01-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +17487 pull_request: https://github.com/python/cpython/pull/18097 ___ Python tracker ___ __

[issue39283] Add ability to inherit unittest arguement parser

2020-01-21 Thread Ajay Tripathi
Ajay Tripathi added the comment: Hi pual, > The issue of testing a script that uses argparse has come up on StackOverFlow > a number of times. Sorry for the confusing but this is not a support ticket, I am not stuck with a problem and I am aware of the variaous solutions on Stackoverflow to

[issue39396] AIX: self.assertEqualSign(math.nextafter(-0.0, +0.0), +0.0) test fails on AIX

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: New changeset 85ead4fc62829cb7ef2eb0af1a2933282f58c629 by Victor Stinner in branch 'master': bpo-39396: Fix math.nextafter(-0.0, +0.0) on AIX 7.1 (GH-18094) https://github.com/python/cpython/commit/85ead4fc62829cb7ef2eb0af1a2933282f58c629 -- __

[issue39396] AIX: self.assertEqualSign(math.nextafter(-0.0, +0.0), +0.0) test fails on AIX

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: My change should fix nextafter test failure on AIX. Again, please open a separated issue for "FAIL: test_specific_values (test.test_cmath.CMathTests)". -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue33387] Simplify bytecodes for try-finally, try-except and with blocks.

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +17488 pull_request: https://github.com/python/cpython/pull/18099 ___ Python tracker ___ __

[issue32989] IDLE: Fix pyparse.find_good_parse_start

2020-01-21 Thread miss-islington
miss-islington added the comment: New changeset f3d3a3cc114ed30829544c3613b73e4fa6dd5599 by Miss Islington (bot) in branch '3.7': bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968) https://github.com/python/cpython/commit/f3d3a3cc114ed30829544c3613b73e4fa6dd5599 -- no

[issue32989] IDLE: Fix pyparse.find_good_parse_start

2020-01-21 Thread miss-islington
miss-islington added the comment: New changeset 060ad2fc1535adc76f96be8269b4af0f14429161 by Miss Islington (bot) in branch '3.8': bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968) https://github.com/python/cpython/commit/060ad2fc1535adc76f96be8269b4af0f14429161 -- _

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread Eryk Sun
Eryk Sun added the comment: > Maybe use SetEnvironmentVariable() on Windows? `_wputenv` keeps Python's copy of the environment block in sync with CRT's copy, which in turn calls `SetEnvironmentVariableW` to sync with process environment block. The CRT's copy of the environment excludes and

[issue39397] Mac : fail to launch Python 3.8

2020-01-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: The other locale related settings are off as well, the default system locale ends with ".UTF-8". -- ___ Python tracker ___

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This indeed a good argument to continue to use _wputenv. Thank you Eryk, you have saved us from making a mistake. -- ___ Python tracker __

[issue39409] AIX: FAIL: test_specific_values (test.test_cmath.CMathTests)

2020-01-21 Thread Michael Felt
New submission from Michael Felt : Per message: https://bugs.python.org/issue39396#msg360362 opening new issue. Research (as requested) to follow. -- components: Tests messages: 360389 nosy: Michael.Felt, vstinner priority: normal severity: normal status: open title: AIX: FAIL: test_sp

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +17490 pull_request: https://github.com/python/cpython/pull/18101 ___ Python tracker ___ __

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset eab3b3f1c60afecfb4db3c3619109684cb04bd60 by Serhiy Storchaka (William Chargin) in branch 'master': bpo-39389: gzip: fix compression level metadata (GH-18077) https://github.com/python/cpython/commit/eab3b3f1c60afecfb4db3c3619109684cb04bd60 -

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +17489 pull_request: https://github.com/python/cpython/pull/18100 ___ Python tracker ___ __

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution William! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39408] Add support for SQLCipher

2020-01-21 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +berker.peksag, ghaering ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue39389] gzip metadata fails to reflect compresslevel

2020-01-21 Thread miss-islington
miss-islington added the comment: New changeset ab0d8e356ecd351d55f89519a6a97a1e69c0dfab by Miss Islington (bot) in branch '3.8': bpo-39389: gzip: fix compression level metadata (GH-18077) https://github.com/python/cpython/commit/ab0d8e356ecd351d55f89519a6a97a1e69c0dfab -- nosy: +mi

[issue33387] Simplify bytecodes for try-finally, try-except and with blocks.

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: New changeset 629023c05be24fa2f01c914c739aaa5a61a0304c by Victor Stinner in branch 'master': bpo-33387: Fix compiler warning in frame_block_unwind() (GH-18099) https://github.com/python/cpython/commit/629023c05be24fa2f01c914c739aaa5a61a0304c -- ___

[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

2020-01-21 Thread Miro Hrončok
Miro Hrončok added the comment: While raising ImportError certainly makes much more sense in this case, this change is backwards incompatible and there was no DeprecationWarning. I don't consider that fair. As a certain compromise, we could maybe raise a custom ImportError+ValueError offspri

[issue39410] CentOS 6.10 SQLite 3.30.1 - _sqlite3 builds successfully but is removed because it cannot be imported.

2020-01-21 Thread Igor Ceh
New submission from Igor Ceh : While trying to build Python 3.8.1 from source with Sqlite 3.30.1 on a CentOS 6.10 I get the following warning: *** WARNING: renaming "_sqlite3" since importing it failed: build/lib.linux-x86_64-3.8/_sqlite3.cpython-38-x86_64-linux-gnu.so: undefined symbol: sql

[issue39408] Add support for SQLCipher

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What exactly do you need to add and change in the sqlite module? The stdlib cannot depend on a third-party module. Ideally, you just create a subclass of some standard class and overrides a constructor and few methods. -- nosy: +serhiy.storchaka _

[issue39411] pyclbr rewrite on AST

2020-01-21 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : pyclbr currently uses token streams to analyze but it can be alot simpler with usage of AST. There are already many flaws, including some comments about limitations of this token stream processing. I have a draft about this. Initial PR wont change any be

[issue39411] pyclbr rewrite on AST

2020-01-21 Thread Batuhan
Change by Batuhan : -- keywords: +patch pull_requests: +17491 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18103 ___ Python tracker ___

[issue39409] AIX: FAIL: test_specific_values (test.test_cmath.CMathTests)

2020-01-21 Thread Mark Dickinson
Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue39402] Consistent use of terms

2020-01-21 Thread Raymond Leiter
Raymond Leiter added the comment: Ray; Thanks for the reply. I understand very well, your remarks -- and, in fact, agree with them. I think my aversion to chaotic terminology stems from my study of BNF and the joy of reading RFCs. I'll send in suggestions if I find actual errors or really confu

[issue35943] PyImport_GetModule() can return partially-initialized module

2020-01-21 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: > Do you mean that there is a risk that the backport introduces a regression in > another part of the code? If yes, I would suggest to not backport the change > to *stable* branches. My worry are the many changes that are required to ceval to make this bac

[issue39410] CentOS 6.10 SQLite 3.30.1 - _sqlite3 builds successfully but is removed because it cannot be imported.

2020-01-21 Thread Igor Ceh
Igor Ceh added the comment: I've changed ./Modules/_sqlite/util.h //#if SQLITE_VERSION_NUMBER >= 3007014 #if SQLITE_VERSION_NUMBER >= 3107014 // Change #define SQLITE3_CLOSE sqlite3_close_v2 #else #define SQLITE3_CLOSE sqlite3_close #endif #endif And tried to recompile with a new error: ***

[issue39412] Install launcher for all users

2020-01-21 Thread ccetsii
New submission from ccetsii : In Python 3.8.1 (32 bits) Windows Installer, the first page show a checkbox for "install launcher for all users (recommended)", but software install in user directory (see screenchot attachment). Casually, in "customize installation" option, exist other "Install f

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
New submission from STINNER Victor : os.unsetenv() is documented to be available on Windows, but it's not. In Python 3.8, "del os.environ[key]" is implemented as: os.putenv(key.upper(), "") Attached PR implements it using SetEnvironmentVariableW(name, NULL). -- components: Library

[issue39411] pyclbr rewrite on AST

2020-01-21 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +17492 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18104 ___ Python tracker ___ _

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: New changeset 56cd3710a1ea3ba872d345ea1bebc86ed08bc8b8 by Victor Stinner in branch 'master': bpo-39413: Implement os.unsetenv() on Windows (GH-18104) https://github.com/python/cpython/commit/56cd3710a1ea3ba872d345ea1bebc86ed08bc8b8 -- _

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread Eryk Sun
Eryk Sun added the comment: This bypasses the CRT's copy of the environment. If any C code calls [_w]getenv, it will still see the variable defined. The only way it won't is if setting the value also bypassed the CRT environment by directly calling SetEnvironmentVariableW. -- nosy:

[issue39412] Install launcher for all users

2020-01-21 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ __

[issue39412] Install launcher for all users

2020-01-21 Thread Eryk Sun
Eryk Sun added the comment: The py launcher is separate from individual installations of Python. However many versions of Python are installed at the system level and for however many users, the system needs only one installation of the launcher. That's why it's recommended to install for al

[issue37909] Thread pool return ref hold memory

2020-01-21 Thread Anders
Anders added the comment: Note: due to a change in Python 3.8 this example would be a lot less noticeable if tested. The problem remains the same though. If you run this snippet with Python 3.7, which is before the thread reuse was introduced into the ThreadPoolExecutor, each thread will kee

[issue39407] Bitfield Union does not work for bit widths greater than 8 bits

2020-01-21 Thread SilentGhost
Change by SilentGhost : -- nosy: +amaury.forgeotdarc, belopolsky, meador.inge versions: -Python 3.5, Python 3.6 ___ Python tracker ___

[issue39410] CentOS 6.10 SQLite 3.30.1 - _sqlite3 builds successfully but is removed because it cannot be imported.

2020-01-21 Thread SilentGhost
Change by SilentGhost : -- components: +Library (Lib) nosy: +ghaering versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-l

[issue39414] Multiprocessing resolving object as None

2020-01-21 Thread Reece Dunham
New submission from Reece Dunham : Exception ignored in: Traceback (most recent call last): File "/root/conda/lib/python3.8/multiprocessing/pool.py", line 268, in __del__ File "/root/conda/lib/python3.8/multiprocessing/queues.py", line 362, in put AttributeError: 'NoneType' object has no at

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread Dong-hee Na
New submission from Dong-hee Na : For example, long_is_finite has not been used for 12 years. -- assignee: corona10 messages: 360408 nosy: corona10 priority: normal severity: normal status: open title: Remove unused code from longobject.c complexobject.c floatobject.c _

[issue39414] Multiprocessing resolving object as None

2020-01-21 Thread Reece Dunham
Change by Reece Dunham : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue39414] Multiprocessing resolving object as None

2020-01-21 Thread Dong-hee Na
Dong-hee Na added the comment: If you don't mind, Would you like to attach the reproducible script for this? -- nosy: +corona10 ___ Python tracker ___

[issue39145] Innocuous parent class changes multiple inheritance MRO

2020-01-21 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: +17493 pull_request: https://github.com/python/cpython/pull/18105 ___ Python tracker ___ _

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread Dong-hee Na
Change by Dong-hee Na : -- keywords: +patch pull_requests: +17494 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18105 ___ Python tracker ___

[issue39145] Innocuous parent class changes multiple inheritance MRO

2020-01-21 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: -17493 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue38856] wait_closed() can raise ConnectionResetError

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: Why is this issue marked as a release blocker? Is it a Python 3.8 regression, or just a regular bug? -- nosy: +vstinner ___ Python tracker _

[issue39414] Multiprocessing resolving object as None

2020-01-21 Thread Reece Dunham
Reece Dunham added the comment: Not sure exactly where its being thrown, but I know it happened in https://cirrus-ci.com/task/4875001270632448?command=test_pyside2#L3974 -- ___ Python tracker __

[issue38856] asyncio ProactorEventLoop: wait_closed() can raise ConnectionResetError

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- title: wait_closed() can raise ConnectionResetError -> asyncio ProactorEventLoop: wait_closed() can raise ConnectionResetError ___ Python tracker ___

[issue38856] asyncio ProactorEventLoop: wait_closed() can raise ConnectionResetError

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- components: +Windows, asyncio nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___

[issue38076] Make struct module PEP-384 compatible

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: > https://github.com/python/cpython/pull/18038 is a partial fix for this Is it enough to reduce the issue priority from release blocker to normal? -- ___ Python tracker ___

[issue38076] Make struct module PEP-384 compatible

2020-01-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Is it enough to reduce the issue priority from release blocker to normal? The error can still happened in other modules and under similar conditions, no? -- ___ Python tracker

[issue38076] Make struct module PEP-384 compatible

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: > The error can still happened in other modules and under similar conditions, > no? The question was if the next 3.9 *alpha* release must be blocked by this issue. I don't think so. I reduce the priority to normal (not set). If someone disagrees, feel free

[issue38076] Make struct module PEP-384 compatible

2020-01-21 Thread Eddie Elizondo
Eddie Elizondo added the comment: The PR that I sent out already fixes the issue. @vstinner, @pablogsal, please take a look again https://github.com/python/cpython/pull/18039 That should close this issue, no need to work around the bug priority. -- __

[issue38076] Make struct module PEP-384 compatible

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: > That should close this issue, no need to work around the bug priority. I'm concerned by release blocker because 3.9.0a3 version is supposed to be released soon, and usually release blocker do block a release :-) --

[issue38076] Make struct module PEP-384 compatible

2020-01-21 Thread Eddie Elizondo
Eddie Elizondo added the comment: > I'm concerned by release blocker because 3.9.0a3 version is supposed to be > released soon, and usually release blocker do block a release :-) Ah! That makes sense! In any case, feel free to ping me if you need help on my side to get this PR through (or t

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +17495 pull_request: https://github.com/python/cpython/pull/18106 ___ Python tracker ___ __

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: > This bypasses the CRT's copy of the environment. If any C code calls > [_w]getenv, it will still see the variable defined. The only way it won't is > if setting the value also bypassed the CRT environment by directly calling > SetEnvironmentVariableW. Oh.

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: I created bpo-39413 "Implement os.unsetenv() on Windows" to prepare work on this issue. But Eryk raised the same concern about CRT: https://bugs.python.org/issue39413#msg360404 I wasn't aware of that :-/ > `_wputenv` keeps Python's copy of the environment b

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: I checked the doc: _putenv("VAR=") removes the environment variable "VAR". It's well documented: https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/putenv-wputenv?view=vs-2019 "You can remove a variable from the environment by specifying an emp

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: New changeset 623ed6171eae35af7fd2e804dfd9c832c05c5d48 by Victor Stinner in branch 'master': bpo-39406: Add PY_PUTENV_DICT macro to posixmodule.c (GH-18106) https://github.com/python/cpython/commit/623ed6171eae35af7fd2e804dfd9c832c05c5d48 -- __

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is also _wputenv_s which affects _spawn, _exec and system. -- ___ Python tracker ___ ___

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +17496 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/18107 ___ Python tracker ___ __

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
STINNER Victor added the comment: PR 18107 still fix this issue (add os.unsetenv() to Python 3.9 on Windows), but fix the implementation (use _wputenv() rather than SetEnvironmentVariableW(), to update the CRT). -- ___ Python tracker

[issue39413] Implement os.unsetenv() on Windows

2020-01-21 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +17497 pull_request: https://github.com/python/cpython/pull/18108 ___ Python tracker ___ __

[issue39406] Implement os.putenv() with setenv() if available

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Why posix_putenv_garbage was renamed to putenv_dict? -- ___ Python tracker ___ ___ Python-bugs-

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: A patch was proposed in issue18842. -- nosy: +martin.panter, serhiy.storchaka ___ Python tracker ___ __

[issue39409] AIX: FAIL: test_specific_values (test.test_cmath.CMathTests)

2020-01-21 Thread Mark Dickinson
Mark Dickinson added the comment: Similar previous issues on macOS: #18513, #15477. -- ___ Python tracker ___ ___ Python-bugs-list

[issue39390] shutil.copytree - 3.8 changed argument types of the ignore callback

2020-01-21 Thread Manuel Barkhau
Manuel Barkhau added the comment: Is there anything I can do to help move this forward? -- ___ Python tracker ___ ___ Python-bugs-l

[issue37909] Thread pool return ref hold memory

2020-01-21 Thread Andrew Svetlov
Andrew Svetlov added the comment: The latest example releases allocated python objects. The memory is returned to allocator which, in turn, can hold it for a while. The allocator is not controlled by Python API. Anyway, if an explicit executor solves your needs -- please just use it. ---

[issue39415] Remove unused code from longobject.c complexobject.c floatobject.c

2020-01-21 Thread Mark Dickinson
Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue39353] Deprecate the binhex module, binhex4 and hexbin4 standards

2020-01-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree with deprecating binhex. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue39408] Add support for SQLCipher

2020-01-21 Thread Sebastian Noack
Sebastian Noack added the comment: Well, the stdlib already depends on a third-party library here, i.e. SQLite3. SQLCipher is a drop-in replacement for SQLite3 that adds support for encrypted databases. In order to use SQLCipher, I'd have to build the sqlite3 module against SQLCipher (instea

[issue39390] shutil.copytree - 3.8 changed argument types of the ignore callback

2020-01-21 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue39390] shutil.copytree - 3.8 changed argument types of the ignore callback

2020-01-21 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > Should not copytree convert arguments of the ignore callback to str and list > correspondingly? It should. I think it makes sense to just do this for Python 3.8.2 instead of updating the doc. -- ___ Python t

[issue39408] Add support for SQLCipher

2020-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If SQLCipher is a drop-in replacement, perhaps the simplest way is to use LD_LIBRARY_PATH to replace libsqlite3. You can also insert a path to your build of the _sqlite module in sys.path before standard paths. --

  1   2   >