[issue37408] [DOC] Precise that Tarfile "format" argument only concerns writing.

Łukasz Langa added the comment: New changeset 1aeb720d64021e544043ca4619a44a7da0cd00dd by Łukasz Langa (Miss Islington (bot)) in branch '3.8': bpo-37408: Precise that Tarfile "format" argument only concerns writing. (GH-14389) (#16465) https://github.com/python/cpython/commit/1aeb720d64021e54

[issue38270] Tests: Avoid MD5 or check for MD5 availablity

Łukasz Langa added the comment: New changeset bfca56b3ddb4bb0a98931ebcd1257af2afa9b2ae by Łukasz Langa (Christian Heimes) in branch '3.8': [3.8] bpo-38270: More fixes for strict crypto policy (GH-16418) (#16437) https://github.com/python/cpython/commit/bfca56b3ddb4bb0a98931ebcd1257af2afa9b2ae

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

New submission from STINNER Victor : Error on a 32-bit buildbot worker where ssize_t maximum = 2,147,483,647 (2**31-1) bytes = ~2.0 GiB. test_largefile uses: # size of file to create (>2 GiB; 2 GiB == 2,147,483,648 bytes) size = 2_500_000_000 x86 Gentoo Installed with X 3.x: https://buildbot

[issue38308] Add optional weighting to statistics.harmonic_mean()

Dong-hee Na added the comment: Great idea! -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

STINNER Victor added the comment: Oh, it's likely a regression caused by: commit 5bcc6d89bcb622a6786fff632fabdcaf67dbb4e2 Author: Giampaolo Rodola Date: Mon Sep 30 12:51:55 2019 +0800 bpo-37096: Add large-file tests for modules using sendfile(2) (GH-13676) > https://buildbot.python.o

[issue37096] Add large-file tests for modules using sendfile(2)

STINNER Victor added the comment: TestCopyfile fails on 32-bit system: bpo-38319. -- nosy: +vstinner resolution: fixed -> status: closed -> open ___ Python tracker ___ __

[issue38270] Tests: Avoid MD5 or check for MD5 availablity

STINNER Victor added the comment: Can we close the issue? -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: On my Windows 10 version 1903, I get: C:\> typeperf "\System\Processor Queue Length" -si 1 Fin du programme, veuillez patienter... Erreur : aucun compteur valide. C:\> echo %errorlevel% -268435454 Error message in english: "Error: No valid counters" Because

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: I tested attached win_utils.py on my Windows 10. I uses the command: ['typeperf', '"\\Système\\Longueur de la file du processeur"', '-si', '5'] Oh wait, counter names are now translated? Oh ok. -- ___ Python tracke

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: We could avoid typeperf command by accessing directly performance counters: (1) The Performance Data Helper (PDH) interface, which provides high-level access to data from both version 1 and version 2 performance counter providers. (2) The registry interface,

[issue38320] Clarify unittest expectedFailure behaviour in the documentation

New submission from Kit Choi : Following discussion in https://bugs.python.org/issue38296 The docstring of unittest.expectedFailure is misleading for people who differentiate "error" and "failure" when they read the sentence. This has a consequence of developers using the decorator without no

[issue38296] unittest expectedFailure does not differentiate errors from failures

Kit Choi added the comment: See issue38320 for documentation change request -- nosy: +Kit Choi2 ___ Python tracker ___ ___ Python-b

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Marat Sharafutdinov added the comment: Andrew, thank you! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38321] Windows: compiler warnings when building Python 3.8

New submission from STINNER Victor : c:\program files (x86)\windows kits\10\include\10.0.17763.0\um\winbase.h(103): warning C4005: 'Yield': macro redefinition c:\vstinner\python\3.8\modules\_asynciomodule.c(2667): warning C4102: 'set_exception': unreferenced label c:\vstinner\python\3.8\modu

[issue38282] socketmodule.c: _FORTIFY_SOURCE=2 warning in AF_ALG case of getsockaddrarg()

STINNER Victor added the comment: Similar when building Python on Fedora 30 (GCC version 9.2.1) with gcc -O3: In function ‘getsockaddrarg’, inlined from ‘sock_bind’ at /home/vstinner/python/master/Modules/socketmodule.c:3113:10: /home/vstinner/python/master/Modules/socketmodule.c:2331:9: w

[issue38321] Compiler warnings when building Python 3.8

Change by STINNER Victor : -- title: Windows: compiler warnings when building Python 3.8 -> Compiler warnings when building Python 3.8 ___ Python tracker ___ _

[issue38321] Windows: compiler warnings when building Python 3.8

STINNER Victor added the comment: Warnings on Linux with gcc -O3: /home/vstinner/python/master/Modules/_randommodule.c:546:17: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 546 | {Py_tp_doc, random_doc}, | ^~~~

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16073 pull_request: https://github.com/python/cpython/pull/16487 ___ Python tracker ___ __

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16074 pull_request: https://github.com/python/cpython/pull/16488 ___ Python tracker ___ __

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 89f8177dcfdbcf17c85bb6998c946c9f42bf6e27 by Victor Stinner in branch 'master': bpo-38304: Fix PyConfig usage in python_uwp.cpp (GH-16487) https://github.com/python/cpython/commit/89f8177dcfdbcf17c85bb6998c946c9f42bf6e27 -- ___

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 81f6b031c46721478372d77fe2e55aa1f8300ae1 by Victor Stinner in branch '3.8': bpo-38304: Fix PyConfig usage in python_uwp.cpp (GH-16488) https://github.com/python/cpython/commit/81f6b031c46721478372d77fe2e55aa1f8300ae1 -- __

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

New submission from STINNER Victor : Python path configuration: PYTHONHOME = (not set) PYTHONPATH = (not set) program name = 'D:\a\1\b\layout-appx-amd64\python.exe' isolated = 0 environment = 1 user site = 1 import site = 1 sys._base_executable = 'D:\\a\\1\\b\\layout-appx-amd64\\

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

Change by STINNER Victor : -- keywords: +patch pull_requests: +16075 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16489 ___ Python tracker ___ _

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

Change by STINNER Victor : -- pull_requests: +16076 pull_request: https://github.com/python/cpython/pull/16490 ___ Python tracker ___ __

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

STINNER Victor added the comment: New changeset 18c4ba9f33868761e374a725d497902863d59ea9 by Victor Stinner in branch '3.8': bpo-38322: Fix gotlandmark() of PC/getpathp.c (GH-16490) https://github.com/python/cpython/commit/18c4ba9f33868761e374a725d497902863d59ea9 --

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

STINNER Victor added the comment: New changeset dec39716ca93ee2e8d9b94915ece33014eb58e9e by Victor Stinner in branch 'master': bpo-38322: Fix gotlandmark() of PC/getpathp.c (GH-16489) https://github.com/python/cpython/commit/dec39716ca93ee2e8d9b94915ece33014eb58e9e -- _

[issue38323] test_ayncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x

New submission from STINNER Victor : test_asyncio fails once on AMD64 RHEL7 Refleaks 3.x, and then test_close_kill_running() was killed after 3h 15 min. I guess that it hangs, but I'm not 100% sure. When test_asyncio was re-run, it seems like test_asyncio was run 3x successful but it hanged a

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

STINNER Victor added the comment: Similar failure on ARMv7 Debian buster 3.x: https://buildbot.python.org/all/#/builders/176/builds/1372 pythoninfo: sys.maxsize: 2147483647 -- ___ Python tracker ___

[issue38324] test_locale and test__locale failures on Windows

New submission from STINNER Victor : On Windows 10 version 1903, 3 locale tests fail: vstinner@WIN C:\vstinner\python\3.8>python -m test -v test_locale test__locale == ERROR: test_getsetlocale_issue1813 (test.test_locale.TestM

[issue38325] [Windows] test_winconsoleio failures

New submission from STINNER Victor : On Windows 10 version 1903, test_winconsoleio even when run from cmd.exe console. C:\vstinner\python\3.8>python -m test -v test_winconsoleio Running Release|x64 interpreter... == CPython 3.8.0b4+ (heads/pr/16490:8a204fd07c, Sep 30 2019, 14:29:53) [MSC v.191

[issue38324] [Windows] test_locale and test__locale failures on Windows

Change by STINNER Victor : -- components: +Tests, Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware title: test_locale and test__locale failures on Windows -> [Windows] test_locale and test__locale failures on Windows versions: +Python 3.8, Python 3.9 _

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

STINNER Victor added the comment: Facts: * appx tests are not run on buildbots * appx tests are not run in pre-commit CI of pull requests * appx tests seem to only be run on Azure Pipelines of the branches (like 3.8 and master) * the fixed bug likely existed since Python 3.6: static int gotl

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

Change by Giampaolo Rodola' : -- keywords: +patch pull_requests: +16077 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16491 ___ Python tracker __

[issue38326] Concerns with the last minute changes to the PEP 587 API

New submission from Nick Coghlan : (Nosy list is RM, PEP 587 BDFL-Delegate, PEP 587 author) Filing as a release blocker, given that I don't think we should ship rc1 until consensus has been reached on the last minute changes to the PEP 587 configuration API. Thread at https://mail.python.or

[issue38321] Compiler warnings when building Python 3.8

STINNER Victor added the comment: Other warnings: c:\vstinner\python\master\objects\longobject.c(420): warning C4244: 'function': conversion from 'unsigned __int64' to 'sdigit', possible loss of data c:\vstinner\python\master\objects\longobject.c(428): warning C4267: 'function': conversion

[issue38321] Compiler warnings when building Python 3.8

STINNER Victor added the comment: And more: c:\vstinner\python\master\modules\_testcapimodule.c(6409): warning C4146: unary minus operator applied to unsigned type, result still unsigned -- ___ Python tracker

[issue38321] Compiler warnings when building Python 3.8

Change by STINNER Victor : -- keywords: +patch pull_requests: +16078 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16492 ___ Python tracker ___ _

[issue22273] abort when passing certain structs by value using ctypes

Change by STINNER Victor : -- pull_requests: +16079 pull_request: https://github.com/python/cpython/pull/16492 ___ Python tracker ___ __

[issue38321] Compiler warnings when building Python 3.8

Change by STINNER Victor : -- pull_requests: +16080 pull_request: https://github.com/python/cpython/pull/16493 ___ Python tracker ___ __

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

Change by STINNER Victor : -- pull_requests: +16081 pull_request: https://github.com/python/cpython/pull/16493 ___ Python tracker ___ __

[issue38321] Compiler warnings when building Python 3.8

Change by STINNER Victor : -- pull_requests: +16082 pull_request: https://github.com/python/cpython/pull/16494 ___ Python tracker ___ __

[issue38315] Provide defaultdict variant that passes key to default_factory

Mark Amery added the comment: I'm aware of __missing__. However, I don't think its existence is by itself a knockdown argument against doing this. __missing__ also fulfils the need satisfied by defaultdict, yet Python still has both - and the latter is almost always more convenient to use wh

[issue38326] Concerns with the last minute changes to the PEP 587 API

Nick Coghlan added the comment: (I'm currently working a PR for this that Victor can review) -- assignee: -> ncoghlan ___ Python tracker ___ _

[issue38321] Compiler warnings when building Python 3.8

STINNER Victor added the comment: New changeset efe74b6369a8d08f27c69703fcc1686966e51068 by Victor Stinner in branch 'master': bpo-38321: Fix _asynciomodule.c compiler warning (GH-16493) https://github.com/python/cpython/commit/efe74b6369a8d08f27c69703fcc1686966e51068 -- __

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Change by Łukasz Langa : -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

STINNER Victor added the comment: New changeset efe74b6369a8d08f27c69703fcc1686966e51068 by Victor Stinner in branch 'master': bpo-38321: Fix _asynciomodule.c compiler warning (GH-16493) https://github.com/python/cpython/commit/efe74b6369a8d08f27c69703fcc1686966e51068 -- nosy: +vsti

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

STINNER Victor added the comment: > 2019-09-30 14:41:36 lukasz.langaset priority: release blocker Why setting it back to release blocker? As far as I recall, this issue is not a Python 3.8 regression. The regression which triggered this old and existing bug has been fixed, see prev

[issue38326] Concerns with the last minute changes to the PEP 587 API

Steve Dower added the comment: (Continuing from the email thread, so read that for context if you haven't) Binary compatibility of an embedding-only struct is totally unnecessary, as posted on the thread. There's no feasible way to embed cross-Python versions on any platform, so we should ju

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

Steve Dower added the comment: The bug was probably exposed due to a change in path initialization (there's been a few changes here recently ;) ) that stopped normalising prefix. You can see that sys.executable in your dumped path has additional "." in the path, and that's never been the cas

[issue35360] Update SQLite to 3.28 in Windows and macOS installer builds

Steve Dower added the comment: Please file a new issue -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue38324] [Windows] test_locale and test__locale failures on Windows

Steve Dower added the comment: This is a known issue (forgetting the number right now) - Linux-style locales don't work on Windows, and so there's a normalization function that has to be completely rewritten. Also, since these seem to be on your own machine, I'm guessing your locale is not

[issue38327] Creating set with empty string returns empty set

New submission from Emil Bode : Initializing/creating a new set with an empty string via the set-command returns an empty set instead of set with the empty string. As in: While set('somestring') gives me a set of size one, set('') gives me an empty set (of size zero), just as set() would do

[issue38327] Creating set with empty string returns empty set

Emil Bode added the comment: Some details about my setup: Python 3.7.1, Spyder 3.3.2 IPython 7.2.0 under Windows 10 64-bit -- ___ Python tracker ___ __

[issue38327] Creating set with empty string returns empty set

Ammar Askar added the comment: I think the key thing you're missing here is that the set() constructor can take any arbitrary iterable (https://docs.python.org/3/library/functions.html#func-set). It simply goes over all the elements inside and adds them all to the set. This is no different

[issue38327] Creating set with empty string returns empty set

Emil Bode added the comment: You're right, I tested with set('a'), which gave me a set of size one, but generalized it here to 'somestring'. Maybe I'm just too loose with using set, instead of {} Sorry to bother you -- ___ Python tracker

[issue38326] Concerns with the last minute changes to the PEP 587 API

Change by Łukasz Langa : -- versions: +Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38242] Revert the new asyncio Streams API

Change by Bruce Merry : -- nosy: +bmerry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue22273] abort when passing certain structs by value using ctypes

Vinay Sajip added the comment: New changeset c9a413ede47171a224c72dd34122005170caaad4 by Vinay Sajip (Victor Stinner) in branch 'master': bpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492) https://github.com/python/cpython/commit/c9a413ede47171a224c72dd34122005170caaad4 -

[issue38321] Compiler warnings when building Python 3.8

Vinay Sajip added the comment: New changeset c9a413ede47171a224c72dd34122005170caaad4 by Vinay Sajip (Victor Stinner) in branch 'master': bpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492) https://github.com/python/cpython/commit/c9a413ede47171a224c72dd34122005170caaad4 -

[issue38324] [Windows] test_locale and test__locale failures on Windows

Tim Golden added the comment: This is the existing issue https://bugs.python.org/issue37945 which I haven't had time to progress. Please feel free to follow up -- ___ Python tracker

[issue37398] contextlib.ContextDecorator decorating async functions

Change by Krzysztof Wróblewski : -- nosy: +Krzysztof Wróblewski ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: > Would the attached rough patch (gc_disable_wr_callback.txt) > be a possible fix? When we find W inside handle_weakrefs(), > we mark it as trash and will not execute the callback. It's semantically correct since we never wanted to execute a callback from a tras

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Change by Neil Schemenauer : -- pull_requests: +16083 pull_request: https://github.com/python/cpython/pull/16495 ___ Python tracker ___

[issue38326] Concerns with the last minute changes to the PEP 587 API

Change by Nick Coghlan : -- keywords: +patch pull_requests: +16084 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/16496 ___ Python tracker __

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: Neil, how about this alternative: leave the weakref implementation alone. If we find a trash weakref, simply clear it instead. That would prevent callbacks too, & would also prevent the weakref from being used to retrieve its possibly-trash-too referent. ---

[issue38303] Make audioop PEP-384 compatible

Change by Tyler Kieft : -- keywords: +patch pull_requests: +16085 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16497 ___ Python tracker ___

[issue38297] Imports at top of module is often not used

Brett Cannon added the comment: So it's a bit misleading to use the stdlib as a guideline because there are reasons we do this in certain spots. E.g. the os module purposefully does function-level imports to make startup cheaper. importlib does this to minimize how many modules need to be fr

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: > Why setting it back to release blocker? As far as I recall, this issue is not > a Python 3.8 regression. The regression which triggered this old and existing > bug has been fixed, see previous comments. I leave it up to our glorious release manager to deci

[issue38302] __rpow__ not reached when __ipow__ returns NotImplemented

hongweipeng added the comment: Oh, I see. Thank you. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: Oops, I linked to wrong PR, my proposed fix is GH-16495. It is the same as what Tim suggests in his last comment. -- ___ Python tracker _

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: Neil, my brief msg 10 minutes before yours suggested the same thing (just clear the weakref), so it must be right ;-) -- ___ Python tracker ___

[issue38328] Speed up the creation time of constant list literals.

New submission from Brandt Bucher : The attached PR contains a small change to the peephole optimizer that converts sequences of: LOAD_CONST(a), LOAD_CONST(b), ..., BUILD_LIST(n) to LOAD_CONST((a, b, ...)), BUILD_LIST_UNPACK(1) The improvement quickly becomes significant for lists larger th

[issue33325] Optimize sequences of constants in the compiler

Change by Brandt Bucher : -- pull_requests: +16086 pull_request: https://github.com/python/cpython/pull/16498 ___ Python tracker ___ ___

[issue38328] Speed up the creation time of constant list literals.

Change by Brandt Bucher : -- keywords: +patch pull_requests: +16087 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16498 ___ Python tracker ___ __

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: FWIW, I agree with Neil in all respects about the release: his patch is the best approach, plugs segfaulting holes that have been there for many years, and the earlier patches aren't needed anymore. -- ___ Python tra

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Change by miss-islington : -- pull_requests: +16088 pull_request: https://github.com/python/cpython/pull/16499 ___ Python tracker ___ __

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Łukasz Langa added the comment: > If that PR is applied, I think we should also restore tp_clear for functions > (revert GH-15826). If that's safe and easy, let's go for it. Would it help with memory usage in functions or was BPO-33418 addressed in another way since? --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: It's unclear to me whether BPO-33418 was a bug or a contrived annoyance :-) If someone believes it was worth addressing, then what it did is the only way to fix it, so should be restored now. -- ___ Python tracker

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: > Would [func tp_clear] help with memory usage in functions or was BPO-33418 > addressed in another way since? Having a tp_clear for all container objects that can be involved in reference cycles will help the GC free memory. BPO-33418 may be contrived bu

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Łukasz Langa added the comment: Is introducing tp_clear on functions a thing that has ABI consequences? In other words, if we take our time on this, would it land in 3.8.1 or 3.9.0? I'm kind of nervous about the rate of change in the past 48 hours. --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: Yes, it's better to have tp_clear than not for a variety of reasons (including setting examples of best practice). Best I can tell, the patch for BPO-33418 was reverted _only_ to worm around the crash in _this_ report. That's no longer needed. Or, if it is, we

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Łukasz Langa added the comment: Now we only need a volunteer to prepare a PR to revert the revert... :> -- ___ Python tracker ___ __

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: Łukasz, all type objects have tp_clear slots, and always did. The patch in question put something useful in the function object's tp_clear slot instead of leaving it NULL. No interface, as such, changes either way. -- __

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: > Is introducing tp_clear on functions a thing that has ABI consequences? In > other words, if we take our time on this, would it land in 3.8.1 or 3.9.0? I think it should not have ABI consequences. However, I see the addition of tp_clear as a new feature

[issue37945] [Windows] locale.getdefaultlocale() issues on Windows: test_locale.test_getsetlocale_issue1813()

Change by STINNER Victor : -- title: test_locale failing -> [Windows] locale.getdefaultlocale() issues on Windows: test_locale.test_getsetlocale_issue1813() ___ Python tracker ___

[issue38324] [Windows] test_locale and test__locale failures on Windows

STINNER Victor added the comment: > Also, since these seem to be on your own machine, I'm guessing your locale is > not en-US? Oh, the behavior of setlocale() depends on my system locale? Yeah, my system is configured in French, sorry I don't recall the locale name. --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Łukasz Langa added the comment: If either of you resurrects tp_clear in functions in the next 12 hours or so, I'll merge it. -- ___ Python tracker ___

[issue38321] Compiler warnings when building Python 3.8

STINNER Victor added the comment: New changeset aca8c406ada3bb547765b262bed3ac0cc6be8dd3 by Victor Stinner in branch 'master': bpo-38321: Fix _testcapimodule.c warning (GH-16494) https://github.com/python/cpython/commit/aca8c406ada3bb547765b262bed3ac0cc6be8dd3 -- __

[issue38329] Top level symlinks are broken in the Python 3.7.4 framework for macOS.

New submission from Kevin Packard : The macOS installer for Python 3.7.4 places "Python.framework" into /Library/Frameworks/ However, the top-level symlinks inside the framework are broken for "Headers" and "Resources". Because of this, the framework can not be imported into an Xcode project

[issue38325] [Windows] test_winconsoleio failures

Eryk Sun added the comment: Apparently handling non-BMP codes is broken in recent builds of the new console in Windows 10. I see this problem in build 18362 as well. It seems there have been updates that have changed the naive way the console used to handle surrogate codes as just regular UC

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

STINNER Victor added the comment: > The bug was probably exposed due to a change in path initialization (there's > been a few changes here recently ;) ) that stopped normalising prefix. You > can see that sys.executable in your dumped path has additional "." in the > path, and that's never b

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

STINNER Victor added the comment: > Adding in the appx _layout_ test (it's the whole test suite in an "installed" > layout) was easier to do in CI than creating a buildbot config, so I threw it > in as a test and then left it on. It's certainly not been failing this whole > time. I'm fine w

[issue38325] [Windows] test_winconsoleio failures

STINNER Victor added the comment: Until a fix is found, can we mark the tests as "known to fail" on a specific Windows version? (So test_winconsoleio doesn't fail anymore.) -- ___ Python tracker ___

[issue38330] httplib specifies content-length when transfer-encoding present

New submission from apmatthews : RFC 7230 3.3.2 states "A sender MUST NOT send a Content-Length header field in any message that contains a Transfer-Encoding header field." When trying to perform a chunked request: import httplib http = httplib.HTTPSConnection('google.com') http.request("POST

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16089 pull_request: https://github.com/python/cpython/pull/16500 ___ Python tracker ___ __

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

Steve Dower added the comment: > I checked why sys.executable is not normalized in the the "appx build". > PC\python_uwp.cpp calls set_process_name() which sets PyConfig.executable and > the path is not normalized. If PyConfig.executable is set explicitly, the > path is left unchanged: PyCon

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

Steve Dower added the comment: Either way, the paths in the latest tests [1] seem to be fine, and they all passed, so I don't think this is a release blocker anymore. Thanks, Victor! [1]: https://dev.azure.com/Python/cpython/_build/results?buildId=52024&view=logs&j=c8a71634-e5ec-54a0-3958-7

[issue38326] Concerns with the last minute changes to the PEP 587 API

STINNER Victor added the comment: > Binary compatibility of an embedding-only struct is totally unnecessary, as > posted on the thread. Well, I'm fine with removing PyConfig.struct_size right now. I wrote two PRs to remove it: * PR 16500 (code) * https://github.com/python/peps/pull/1185 (PE

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: I reopen the issue since there seems to be disagreement about the whole feature (provide a stable ABI for embedded Python): see bpo-38326. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue38330] httplib specifies content-length when transfer-encoding present

Change by apmatthews : -- keywords: +patch pull_requests: +16090 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16501 ___ Python tracker ___ _

  1   2   >