[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: I suspect the relevant failure here (which is not listed in Pablo's post) is this one: == ERROR: test_realpath_curdir (test.test_ntpath.TestNtpath) --

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15080 pull_request: https://github.com/python/cpython/pull/15369 ___ Python tracker ___ __

[issue37910] argparse wrapping fails with metavar="" (no metavar)

2019-08-21 Thread Sam Franklin
New submission from Sam Franklin : When argparse wraps the usage text, it can fail its assertion tests with whitespace differences. This can occur when metavar="", needed if a user wishes to avoid having a metavar print. It also could occur if a user specifies any other whitespace. Here's a

[issue37792] xml.etree.ElementTree.Element.__eq__ does compare only objects identity

2019-08-21 Thread Raymond Hettinger
Raymond Hettinger added the comment: Macro, we appreciate your sentiments. Please consider this module has been around for a long time and that others aren't reacting to the API the same way you are. Deprecating SubElement, fromstringlist() and tostringlist() because you don't like them wi

[issue32949] Simplify "with"-related opcodes

2019-08-21 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue29988] with statements are not ensuring that __exit__ is called if __enter__ succeeds

2019-08-21 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: Okay, the venv break is related (and it should have broken more frequently). The new realpath() implementation leaves the \\?\ prefix behind if the path doesn't exist, since that's the error you get when the path is longer than MAX_PATH and you're on a system t

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: And sorry, the test_ntpath traceback was half listed in Pablo's message, but was missing the critical lines :) -- ___ Python tracker ___ ___

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset df2d4a6f3d5da2839c4fc11d31511c8e028daf2c by Steve Dower in branch 'master': bpo-37834: Normalise handling of reparse points on Windows (GH-15231) https://github.com/python/cpython/commit/df2d4a6f3d5da2839c4fc11d31511c8e028daf2c -- __

[issue1311] os.path.exists(os.devnull) regression on windows

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset df2d4a6f3d5da2839c4fc11d31511c8e028daf2c by Steve Dower in branch 'master': bpo-37834: Normalise handling of reparse points on Windows (GH-15231) https://github.com/python/cpython/commit/df2d4a6f3d5da2839c4fc11d31511c8e028daf2c -- nosy: +

[issue29988] with statements are not ensuring that __exit__ is called if __enter__ succeeds

2019-08-21 Thread Raymond Hettinger
Raymond Hettinger added the comment: Historically, in C, Python, and and low-level interrupt programming it was the responsibility of a person writing a signal handler to make minimal variable edits and not disrupt anything else in the ecosystem. Are we changing that rule? (I'm still at t

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Change by Steve Dower : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15081 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/15370 ___ Python tracker ___

[issue1311] os.path.exists(os.devnull) regression on windows

2019-08-21 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15082 pull_request: https://github.com/python/cpython/pull/15370 ___ Python tracker ___ __

[issue1311] os.path.exists(os.devnull) regression on windows

2019-08-21 Thread Steve Dower
Steve Dower added the comment: Well, I was trying not to resurrect this old issue, but looks like I did it accidentally. Hi there, old hands! We miss you :) We also figured out a new [l]stat() implementation on Windows that handles symlinks and junctions better, and also non-file types such

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset 9eb3d5463976068900e94b860ced7e035885835c by Steve Dower in branch '3.8': bpo-37834: Normalise handling of reparse points on Windows (GH-15370) https://github.com/python/cpython/commit/9eb3d5463976068900e94b860ced7e035885835c -- _

[issue1311] os.path.exists(os.devnull) regression on windows

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset 9eb3d5463976068900e94b860ced7e035885835c by Steve Dower in branch '3.8': bpo-37834: Normalise handling of reparse points on Windows (GH-15370) https://github.com/python/cpython/commit/9eb3d5463976068900e94b860ced7e035885835c -- _

[issue37663] Making venv activation script prompts consistent

2019-08-21 Thread Brett Cannon
Brett Cannon added the comment: New changeset 48ede6b8f685669f53d26ae8456647af42ae3dae by Brett Cannon in branch 'master': bpo-37663: have venv activation scripts all consistently use __VENV_PROMPT__ for prompt customization (GH-14941) https://github.com/python/cpython/commit/48ede6b8f685669

[issue37482] Email address display name fails with both encoded words and special chars

2019-08-21 Thread miss-islington
miss-islington added the comment: New changeset df0c21ff46c5c37b6913828ef8c7651f523432f8 by Miss Islington (bot) (bsiem) in branch 'master': bpo-37482: Fix email address name with encoded words and special chars (GH-14561) https://github.com/python/cpython/commit/df0c21ff46c5c37b6913828ef8c7

[issue37911] Minor error in PEP567 code example

2019-08-21 Thread Semyon
New submission from Semyon : In PEP-567 there is a code example in `contextvars.Context` section (https://www.python.org/dev/peps/pep-0567/#contextvars-context): ``` # Print all context variables and their values in 'ctx': print(ctx.items()) ``` But `ctx.items()` doesn't return a list of tupl

[issue37482] Email address display name fails with both encoded words and special chars

2019-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +15083 pull_request: https://github.com/python/cpython/pull/15371 ___ Python tracker ___ __

[issue37910] argparse wrapping fails with metavar="" (no metavar)

2019-08-21 Thread Sam Franklin
Change by Sam Franklin : -- keywords: +patch pull_requests: +15084 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15372 ___ Python tracker ___ ___

[issue37482] Email address display name fails with both encoded words and special chars

2019-08-21 Thread miss-islington
miss-islington added the comment: New changeset c5bba853d5e7836f6d4340e18721d3fb3a6ee0f7 by Miss Islington (bot) in branch '3.7': bpo-37482: Fix email address name with encoded words and special chars (GH-14561) https://github.com/python/cpython/commit/c5bba853d5e7836f6d4340e18721d3fb3a6ee0f

[issue36311] Flaw in Windows code page decoder for large input

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset 7ebdda0dbee7df6f0c945a7e1e623e47676e112d by Steve Dower in branch 'master': bpo-36311: Fixes decoding multibyte characters around chunk boundaries and improves decoding performance (GH-15083) https://github.com/python/cpython/commit/7ebdda0dbee7df

[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS

2019-08-21 Thread Jeremy Kloth
Jeremy Kloth added the comment: I happened to catch a stuck build prior to the process being killed: https://buildbot.python.org/all/#/builders//builds/2887 In short, the PR doesn't change the problem. The regrtest main will wait indefinitely on the successfully killed process. I have some

[issue36311] Flaw in Windows code page decoder for large input

2019-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +15085 pull_request: https://github.com/python/cpython/pull/15374 ___ Python tracker ___ __

[issue36311] Flaw in Windows code page decoder for large input

2019-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +15086 pull_request: https://github.com/python/cpython/pull/15375 ___ Python tracker ___ __

[issue36311] Flaw in Windows code page decoder for large input

2019-08-21 Thread Steve Dower
Steve Dower added the comment: I'll get the 3.7 and 3.8 backports merged - looks like they're trivial. Going to need some help with the 2.7 backport, but I'm happy to approve a PR. -- stage: patch review -> backport needed ___ Python tracker

[issue29988] with statements are not ensuring that __exit__ is called if __enter__ succeeds

2019-08-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: The signal handler in this case is CPython's internal signal handling system thus any such onus falls on us... The great signal handling hack of "set a flag that the interpreter loop checks on occasion" trick lasted a long time, but our VM has since evolve

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset 06be2c7f357d12249445e95def1fb708a087b357 by Steve Dower in branch 'master': bpo-9949: Call normpath() in realpath() and avoid unnecessary prefixes (GH-15369) https://github.com/python/cpython/commit/06be2c7f357d12249445e95def1fb708a087b357 -

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15087 pull_request: https://github.com/python/cpython/pull/15376 ___ Python tracker ___ __

[issue36311] Flaw in Windows code page decoder for large input

2019-08-21 Thread miss-islington
miss-islington added the comment: New changeset f93c15aedc2ea2cb8b56fc9dbb0d412918992e86 by Miss Islington (bot) in branch '3.8': bpo-36311: Fixes decoding multibyte characters around chunk boundaries and improves decoding performance (GH-15083) https://github.com/python/cpython/commit/f93c1

[issue36311] Flaw in Windows code page decoder for large input

2019-08-21 Thread miss-islington
miss-islington added the comment: New changeset 735a960ac98cf414caf910565220ab2761fa542a by Miss Islington (bot) in branch '3.7': bpo-36311: Fixes decoding multibyte characters around chunk boundaries and improves decoding performance (GH-15083) https://github.com/python/cpython/commit/735a9

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Eryk Sun
Eryk Sun added the comment: I'm tentatively reopening this issue for you to consider the following point, Steve. A real path is not always the same as a final path. We can find code that does `relpath(realpath(target), realpath(start))` to compute the relative path to target for a symlink.

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: > We can find code that does `relpath(realpath(target), realpath(start))` to > compute the relative path to target for a symlink. > In other words, the caller wants a solidified form of `start` that can be > used to compute the path to a target for a relative

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset a50d2f7e199f3be60c70c1586ee60ec60bf36642 by Steve Dower in branch '3.8': bpo-9949: Call normpath() in realpath() and avoid unnecessary prefixes (GH-15376) https://github.com/python/cpython/commit/a50d2f7e199f3be60c70c1586ee60ec60bf36642

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15088 pull_request: https://github.com/python/cpython/pull/15377 ___ Python tracker ___ _

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: Adding a small fix for the Win7 buildbots in PR 15377 -- ___ Python tracker ___ ___ Python-bugs-list

[issue37528] test_tarfile: test_extractall_symlinks() fails on Windows with: [WinError 206] The filename or extension is too long

2019-08-21 Thread Steve Dower
Steve Dower added the comment: I disabled the long path support on my own build and can reproduce this by passing a long path to --tempdir Unfortunately, I'm not familiar enough with what tarfile is trying to do here - why is it recreating the entire directory structure within itself? Brows

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Eryk Sun
Eryk Sun added the comment: > Aware code can handle it [the exception] by getting a real path and > taking appropriate measures. That should be "by getting a final path". -- ___ Python tracker _

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: New changeset 374be59b8e479afa8c7a8ae6e77e98915e2f6d45 by Steve Dower in branch 'master': bpo-37834: Fix test on Windows 7 (GH-15377) https://github.com/python/cpython/commit/374be59b8e479afa8c7a8ae6e77e98915e2f6d45 --

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +15089 pull_request: https://github.com/python/cpython/pull/15378 ___ Python tracker ___ __

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Eryk Sun
Eryk Sun added the comment: >> We can find code that does `relpath(realpath(target), >> realpath(start))` to compute the relative path to target >> for a symlink. >> ... > I don't know how common this scenario is, but I can certainly > say that it's never worked on Windows. You'd also end u

[issue37912] fstring with quotation marks conflict

2019-08-21 Thread Seaky Lone
New submission from Seaky Lone : For example, I have the following code: something = 'some thing' string = f'some text {something.split(' ')}' The second expression is thought to be invalid because it is regarded as two strings ['some text {something.split(', ')}']. I have to change either pa

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread miss-islington
miss-islington added the comment: New changeset 967d625a6df27fb490f035045ec8fe4675001d63 by Miss Islington (bot) in branch '3.8': bpo-37834: Fix test on Windows 7 (GH-15377) https://github.com/python/cpython/commit/967d625a6df27fb490f035045ec8fe4675001d63 -- nosy: +miss-islington _

[issue37834] readlink on Windows cannot read app exec links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: That should be all the buildbot issues fixes, so I'm marking this resolved and will wait for the inevitable 3.8.0b4 feedback! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue9949] os.path.realpath on Windows does not follow symbolic links

2019-08-21 Thread Steve Dower
Steve Dower added the comment: At this point, I'm inclined to say let's wait and see what the 3.8.0b4 feedback looks like. Given that WSL has been fudging the boundaries here and hasn't suffered as a result, I don't expect much of a problem (and this change does actually make realpath() con

[issue37912] fstring with quotation marks conflict

2019-08-21 Thread Eric V. Smith
Eric V. Smith added the comment: The lexer sees an f-string: f'some text {something.split(' next to a normal string: ')}' The first of those is not a valid f-string because of the unmatched left brace, so it's an error. I'm contemplating making the f-string parser smarter to be able to detec

[issue37911] Minor error in PEP567 code example

2019-08-21 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: PEPs have their own GitHub issue tracker though I am not sure of edits to this PEP. GitHub : https://github.com/python/peps/issues . This can be closed as third party. -- nosy: +xtreak ___ Python tracke

[issue37910] argparse wrapping fails with metavar="" (no metavar)

2019-08-21 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +paul.j3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue36876] Global C variables are a problem.

2019-08-21 Thread Paulo Henrique Silva
Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue36854] GC operates out of global runtime state.

2019-08-21 Thread Paulo Henrique Silva
Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue24554] GC should happen when a subinterpreter is destroyed

2019-08-21 Thread Paulo Henrique Silva
Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue37862] Search doesn't find built-in functions

2019-08-21 Thread Kim Oldfield
Kim Oldfield added the comment: Usually the search page is the quickest way to find documentation about a module or function - quicker than navigating through a couple of levels of pages (documentation home, index, index by letter, scroll or search in page to find desired name, click on name

[issue36877] [meta] Move fields from _PyRuntimeState to PyInterpreterState.

2019-08-21 Thread Paulo Henrique Silva
Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue37862] Search doesn't find built-in functions

2019-08-21 Thread Ammar Askar
Ammar Askar added the comment: See also https://bugs.python.org/issue34398 There is some related work done by Julien there as well: https://github.com/JulienPalard/pydocsearch -- nosy: +ammar2 ___ Python tracker

[issue36710] Pass _PyRuntimeState as an argument rather than using the _PyRuntime global variable

2019-08-21 Thread Paulo Henrique Silva
Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

2019-08-21 Thread Paulo Henrique Silva
Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue37894] [win] shutil.which can not find the path if 'cmd' include directory path and not include extension name

2019-08-21 Thread Eryk Sun
Eryk Sun added the comment: The code that sets up the PATHEXT `files` could be moved up. It also needs to be fixed in order to implement the correct behavior. For example: use_bytes = isinstance(cmd, bytes) files = [cmd] if _WINDOWS: # Also look for the name plus each PAT

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2019-08-21 Thread Jordon.X
Jordon.X <9651...@qq.com> added the comment: Thanks vstinner. I also don't think it's necessary to backport to the old version. Close this issue is fine. -- ___ Python tracker ___

[issue29250] islink and stat follow_symlinks are inconsistent on Windows

2019-08-21 Thread Eryk Sun
Change by Eryk Sun : -- dependencies: -os.walk always follows Windows junctions resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker __

[issue37074] os.stat() does not work for NUL and CON

2019-08-21 Thread Eryk Sun
Change by Eryk Sun : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue37754] Persistence of Shared Memory Segment after process exits

2019-08-21 Thread Vinay Sharma
Vinay Sharma added the comment: > In terms of providing "consistent behavior across platforms that can be > reasonably supported", the behavior suggested above could not > reasonably be supported in Windows. I understand that persistence of a shared memory segment after all the processes usin

[issue37862] Search doesn't find built-in functions

2019-08-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Even if click 'Library Reference', click '2. Built-in...', click name in the index at the top of the page to go to the entry I know I want to read is sometimes slower that 'click search box', enter word, hit Return, wait for results, scan results to find tha

[issue37074] os.stat() does not work for NUL and CON

2019-08-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Where it was fixed? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue35889] sqlite3.Row doesn't have useful repr

2019-08-21 Thread Raymond Hettinger
Raymond Hettinger added the comment: If this goes forward, the maximum output size needs to be limited in some way (like what is done in reprlib). Given Serhiy's doubts, I'm only +0 on this. Feel free to close this if you like. For the most part, I don't think people even look at Row objec

[issue37792] xml.etree.ElementTree.Element.__eq__ does compare only objects identity

2019-08-21 Thread Marco Sulla
Marco Sulla added the comment: @rhettinger: "Deprecating [...] just cause disruption to existing, deployed code" How? Deprecating is used just to maintain intact the already existing code... "Please do not go down of the path of making yourself the arbiter of what is Pythonic or standard.

[issue37754] Persistence of Shared Memory Segment after process exits

2019-08-21 Thread Eryk Sun
Eryk Sun added the comment: > register the shared the shared_memory only when it's created and > not when it's attached. In Windows, the section object is reference counted. I haven't looked into the Unix implementation, but maybe it could use advisory locking. After opening shared memory v

[issue36906] Compile time textwrap.dedent() equivalent for str or bytes literals

2019-08-21 Thread Raymond Hettinger
Raymond Hettinger added the comment: We should consider dedicated syntax for compile-time dedenting: d"""\ This would be left aligned but this would only have four spaces And this would be left-justified. """ # Am not sure what to do about this last

[issue32471] Add an UML class diagram to the collections.abc module documentation

2019-08-21 Thread Raymond Hettinger
Raymond Hettinger added the comment: See the rationale in the closed PR. I rather liked this idea but it didn't prove to be a net win during user testing. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Pytho

[issue26680] Incorporating float.is_integer into the numeric tower and Decimal

2019-08-21 Thread Raymond Hettinger
Raymond Hettinger added the comment: Marking this as closed: * no forward movement for a year and half * opposition from multiple core devs Feel free to revive this if you truly think this is needed and want to get the debate going again. Also, expanding the numeric tower is always going to

[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

2019-08-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I tried to solve this issue myself, and figured out that it is not so simple. It is possible to make tee() nor crashing, but it is not possible to guarantee the order of the output without using a lock in tee(). It you can get a sequence 1, 2, 4, 3, ... S

[issue37074] os.stat() does not work for NUL and CON

2019-08-21 Thread Eryk Sun
Eryk Sun added the comment: > Where it was fixed? It was addressed in issue 37834. PR 15231 includes a rewrite of win32_xstat_impl. The file type was needed, so the rewrite could also address the problem of character devices such as CON and NUL. -- _

[issue37482] Email address display name fails with both encoded words and special chars

2019-08-21 Thread B Siemerink
Change by B Siemerink : -- pull_requests: +15090 pull_request: https://github.com/python/cpython/pull/15380 ___ Python tracker ___ _

<    1   2