[issue37833] tkinter crashes macOS in the latest macOS update 10.14.6

2019-08-13 Thread Ronald Oussoren
Ronald Oussoren added the comment: A followup question: How can I determine the exact version of Tk? -- ___ Python tracker ___ ___

[issue37833] tkinter crashes macOS in the latest macOS update 10.14.6

2019-08-13 Thread Ned Deily
Ned Deily added the comment: As far as I know, the best information you can get from Tk about version is the patch level which does not necessarily take into account builds from a dev repo or patched source. The easiest way to get that info from tkinter is to use test.pythoninfo: $ python3

[issue37833] tkinter crashes macOS in the latest macOS update 10.14.6

2019-08-13 Thread Ricardo Smits
Ricardo Smits added the comment: Thanks! I was just looking how to send you all this info, so here it is: tkinter.TCL_VERSION: 8.6 tkinter.TK_VERSION: 8.6 tkinter.info_patchlevel: 8.6.8 $ python3.7 -c 'import _tkinter;print(_tkinter.__file__)' /anaconda3/envs/main/lib/python3.7/lib-dynload/_

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Change by Greg Price : -- pull_requests: +14969 pull_request: https://github.com/python/cpython/pull/15248 ___ Python tracker ___ __

[issue32771] merge the underlying data stores of unicodedata and the str type

2019-08-13 Thread Greg Price
Change by Greg Price : -- nosy: +Greg Price ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue37833] tkinter crashes macOS in the latest macOS update 10.14.6

2019-08-13 Thread Ned Deily
Ned Deily added the comment: OK, thanks, Ricardo. Since you appear to be using an Anaconda-supplied Tk, I suggest you open an issue or otherwise ask for help from the Conda project and, as necessary, the Tk folks. Without more info and unable to reproduce with other sources of Tk, there is

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > IHMO PGO compilation already defeats the purpose of these macros. That's certainly true. The question is whether we want to optimize also non-PGO builds. -- ___ Python tracker

[issue12611] 2to3 crashes when converting doctest using reduce()

2019-08-13 Thread Aldwin Pollefeyt
Change by Aldwin Pollefeyt : -- pull_requests: +14970 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15249 ___ Python tracker ___ _

[issue12611] 2to3 crashes when converting doctest using reduce()

2019-08-13 Thread Aldwin Pollefeyt
Change by Aldwin Pollefeyt : -- nosy: +aldwinaldwin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue37835] typing.get_type_hints wrong namespace for forward-declaration of inner class

2019-08-13 Thread Netzeband
New submission from Netzeband : When evaluating the type-hints of an inner-class (a class defined inside a function scope), the forward declaration does not work correctly. In this case the typing.get_type_hints does not get the right namespace, thus the class-string specified is not found.

[issue37836] Support .as_integer_ratio() in fractions.Fraction

2019-08-13 Thread Jeroen Demeyer
New submission from Jeroen Demeyer : Currently, the fractions.Fraction constructor accepts an .as_integer_ratio() method only for the specific types "float" and "Decimal". It would be good to support this for arbitrary classes. This is part of what was proposed in #37822, but without adding t

[issue31601] Availability of utimensat, futimens not checked correctly on macOS

2019-08-13 Thread Ronald Oussoren
Ronald Oussoren added the comment: I'd prefer a solution that uses symbols where the are available (weak linking). That way users on newer systems can use all functionality available there, without having multiple binaries. I've done this in the past for older macOS versions, but don't know

[issue12447] ~True is not False

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: bpo-37831 has been marked as a duplicate of this issue. -- nosy: +vstinner ___ Python tracker ___ ___

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

2019-08-13 Thread Sanyam Khurana
Sanyam Khurana added the comment: Thanks for the bug report Alan & for the PR Ngalim! I've checked the current docs and this is a valid bug. I've also reviewed the Pull request and it looks good to me. @Mariatta, @Senthil can you please have a look at this? Many thanks! -- nosy: +C

[issue37837] add internal _PyLong_FromUnsignedChar() function

2019-08-13 Thread Sergey Fedoseev
New submission from Sergey Fedoseev : When compiled with default NSMALLPOSINTS, _PyLong_FromUnsignedChar() is significantly faster than other PyLong_From*(): $ python -m perf timeit -s "from collections import deque; consume = deque(maxlen=0).extend; b = bytes(2**20)" "consume(b)" --compare-

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Eryk Sun
Eryk Sun added the comment: > Honestly, the only real problem I've seen is in applications that use > a reimplementation of spawn() rather than the UCRT's version (which > handles the reparse point jsut fine). I looked into this spawn problem. It's due to Cygwin's spawnve, which calls NtOpenF

[issue37837] add internal _PyLong_FromUnsignedChar() function

2019-08-13 Thread Sergey Fedoseev
Change by Sergey Fedoseev : -- keywords: +patch pull_requests: +14971 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15251 ___ Python tracker ___

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Netzeband
New submission from Netzeband : When decorating a function and using a forward declaration as type hint, the typing.get_type_hints function does not work anymore, since it cannot find the forward declared name in the namespace. After debugging I think, the typing.get_type_hints function is ac

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +gvanrossum, levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue37839] makesetup Doesn't Handle Defines with Equal Sign

2019-08-13 Thread Will Bond
New submission from Will Bond : Using 3.8.0b3 on macOS. I'm doing a custom compile with (heavy) modifications to Modules/Setup.local. Whenever I add a define rule to a module line that includes an equal sign, e.g.: _sqlite3 -DMODULE_NAME=_sqlite3 _sqlite/module.c _sqlite/cache.c _sqlite/conn

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: > That's certainly true. The question is whether we want to optimize also > non-PGO builds. If it's an optimization, can you show a benchmark to validate that it's really faster as expected? I tried for 6 months to run benchmarks without PGO and it was a lo

[issue37840] bytearray_getitem() handles negative index incorrectly

2019-08-13 Thread Sergey Fedoseev
New submission from Sergey Fedoseev : bytearray_getitem() adjusts negative index, though that's already done by PySequence_GetItem(). This makes PySequence_GetItem(bytearray(1), -2) to return 0 instead of raise IndexError. -- components: Interpreter Core messages: 349545 nosy: sir-sig

[issue37840] bytearray_getitem() handles negative index incorrectly

2019-08-13 Thread Sergey Fedoseev
Change by Sergey Fedoseev : -- keywords: +patch pull_requests: +14972 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15250 ___ Python tracker ___

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

2019-08-13 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue32771] merge the underlying data stores of unicodedata and the str type

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: > This will remove awkward maneuvers like ast.c importing unicodedata in order > to perform normalization. unicodedata is not needed by default. ast.c only imports unicodedata at the first non-ASCII identifier. If you application (and all dependencies) only

[issue32771] merge the underlying data stores of unicodedata and the str type

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: Hum, I forget to mention that the module is compiled as a dynamically library, at least on Fedora: $ python3 Python 3.7.4 (default, Jul 9 2019, 16:32:37) [GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] on linux Type "help", "copyright", "credits" or "license" for mo

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: $ find -name "*db.h" ./Modules/unicodedata_db.h ./Modules/unicodename_db.h ./Objects/unicodetype_db.h For .gitattributes, I would prefer to use unicode*_db.h pattern rather than "a generic" *_db.h, to avoid masking other potential file called "something_db.h"

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: "from typing import *" I like to run pyflakes time to time on the Python code base. Please avoid "import *" since it prevents pyflakes (and other code analyzers) to find bugs. Example: $ pyflakes Tools/unicode/makeunicodedata.py Tools/unicode/makeunicodedat

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: BTW: Since when do we use type annotations in Python's stdlib ? -- nosy: +lemburg ___ Python tracker ___

[issue16958] The sqlite3 context manager does not work with isolation_level=None

2019-08-13 Thread STINNER Victor
Change by STINNER Victor : -- keywords: -easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue37837] add internal _PyLong_FromUnsignedChar() function

2019-08-13 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: Maybe an even better idea would be to partially inline PyLong_FromLong(). If the check for small ints in PyLong_FromLong() would be inlined, then the compiler could optimize those checks. This would benefit all users of PyLong_FromLong() without code changes

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > If it's an optimization, can you show a benchmark to validate that it's > really faster as expected? Yes, I did test it. I didn't save the results, but I can redo them if you want. If you plan to reject the issue anyway, there is no point. > not building

[issue36077] Inheritance dataclasses fields and default init statement

2019-08-13 Thread Kim Gustyr
Change by Kim Gustyr : -- nosy: +kgustyr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue25299] TypeError: __init__() takes at least 4 arguments (4 given)

2019-08-13 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: paul.j3, The fix looks promising. Do you want to open a PR with this fix? -- nosy: +nanjekyejoannah ___ Python tracker ___ __

[issue1615158] POSIX capabilities support

2019-08-13 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: > I would expect that Py_LIKELY/Py_UNLIKELY helps with this. Well, PGO is made of many optimizations, not only help branch prediction. For example, it detects hot code and tries to put functions which call them each other close in memory to enhance the CPU i

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: Another example to explain my concern. In the Linux kernel, list macros used to prefetch next items: “(...) So the conclusion is: prefetches are absolutely toxic, even if the NULL ones are excluded.” https://lwn.net/Articles/444336/ The lesson is that we sho

[issue37821] IDLE shell uses wrong namespace for completions

2019-08-13 Thread Tal Einat
Tal Einat added the comment: Terry, many thanks for the clarifications! > The intended behavior is to complete if at all possible. I can see the point in that. > What is odd to me is that you seem happy using the more numerous non-user > IDLE imports when there is no Shell. The alternative

[issue37821] IDLE shell uses wrong namespace for completions

2019-08-13 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg349556 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37821] IDLE shell uses wrong namespace for completions

2019-08-13 Thread Tal Einat
Tal Einat added the comment: Terry, many thanks for the clarifications! > The intended behavior is to complete if at all possible. I can see the point in that. > What is odd to me is that you seem happy using the more numerous non-user > IDLE imports when there is no Shell. The alternative

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +p-ganssle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: Could be related to some discussions in this PR: https://github.com/python/cpython/pull/14842 -- ___ Python tracker ___ __

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue35707] time.sleep() should support objects with __float__

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-20861. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-35707. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue33523] loop.run_until_complete re-entrancy to support more complicated codebases in transition to asyncio

2019-08-13 Thread flying sheep
flying sheep added the comment: There’s this monkeypatching solution: https://pypi.org/project/nest-asyncio/ But yes, it’s a very practical problem that you can’t call async code from sync code that’s being called from async code. -- nosy: +flying sheep __

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: It started to write a new issue, but then I found this issue issue (created in 2013!) which is still open. So let me write my comment here instead. The code to convert a number to an integer is quite complex in Python. There are *many* ways to do that and ea

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: We're not talking about prefetching here. The Py_LIKELY/Py_UNLIKELY macros only affect which of the two code paths in a branch is the "default" one, i.e. the one not involving a jmp. -- ___ Python tracker

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: This is essentially a duplicate of #36048. The example is now deprecated: >>> from decimal import Decimal >>> from datetime import datetime >>> datetime(Decimal("2000.5"), 1, 2) :1: DeprecationWarning: an integer is required (got type decimal.Decimal). Impli

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Srinivas Nyayapati
Change by Srinivas Nyayapati : -- pull_requests: +14973 pull_request: https://github.com/python/cpython/pull/15252 ___ Python tracker ___ __

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Guido van Rossum
Guido van Rossum added the comment: Using `__wrapped__` if present sounds like a good idea. Ivan, what do you think? Netzeband, have you considered submitting a PR with the necessary changes (and tests and docs)? -- ___ Python tracker

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Srinivas Nyayapati
Srinivas Nyayapati added the comment: I submitted a new PR for the Windows test case. Please take a look. Also how do I attach the label "skip news" to this new PR? -- ___ Python tracker ___

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: I claim that adding Py_LIKELY/Py_UNLIKELY will reduce the performance randomness of non-PGO builds. So it would be strange to use that randomness as an argument *against* this patch. -- ___ Python tracker

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Paul Moore
Paul Moore added the comment: I added the label for you. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Paul Moore
Paul Moore added the comment: To clarify, I think adding the label needs core dev (or maybe triager) rights on github, so I don't think it's something you can do yourself. -- ___ Python tracker

[issue37830] continue in finally with return in try results with segfault

2019-08-13 Thread Ethan Furman
Ethan Furman added the comment: My apologies if I missed something, but do we have a consensus on the desired solution? My understanding of `try/finally` is that whatever happens in the `finally` clause should: - always happen - win any conflicts with `try` clause For example: try:

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: > We're not talking about prefetching here. The Py_LIKELY/Py_UNLIKELY macros > only affect which of the two code paths in a branch is the "default" one, > i.e. the one not involving a jmp. I know. My point about prefetching is that if we provide a way to dev

[issue8243] curses writing to window's bottom right position raises: `_curses.error: addstr() returned ERR'

2019-08-13 Thread Anthony Sottile
Anthony Sottile added the comment: In case it helps someone else, `insstr` seems to not have this limitation -- nosy: +Anthony Sottile ___ Python tracker ___ __

[issue36266] Which module could not be found?

2019-08-13 Thread Srinivas Nyayapati
Srinivas Nyayapati added the comment: can a reviewer please take a look to my PR? -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

2019-08-13 Thread egaudry
egaudry added the comment: Hi, I think that there are some issues in the last patch (0001-Build-or-disable-readline-module-with-Editline.patch) made available. For instance, the using_libedit_emulation variable should be protected by DETECT_EDITLINE ifdef (and not SUPPORT_EDITLINE). And the

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: Few more links about likely/__builtin_expect: * GCC documentation says: "In general, you should prefer to use actual profile feedback for this (-fprofile-arcs), as programmers are notoriously bad at predicting how their programs actually perform." https:/

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: This issue has been fixed in Python 3.3 by bpo-17576 which started to emit the DeprecationWarning. -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> PyNumber_Index() is not int-subclass friendly (or op

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
New submission from Steve Dower : A change made to the python_uwp.vcxproj (or more likely the .cpp file) has introduced a runtime dependency on msvcp140.dll. As we don't distribute this dependency, and it is not always installed by default, we should statically link it instead. -- as

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +14974 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15253 ___ Python tracker _

[issue37830] continue in finally with return in try results with segfault

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Batuhan, unfortunately your second solution does not work too, because continue and break can be conditional. For example: def simple(x): for number in range(2): try: return number finally: if x: c

[issue37830] continue and break in finally with return in try results with segfault

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Note, that we have a regression in 3.8. There is a use case for "break" in "finally", and such code is even used in the stdlib. And who know in what third-party code it is used. In specific circumstances (see msg349513) it now can cause a crash. Other exam

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: > Using `__wrapped__` if present sounds like a good idea. Yeah, I like this idea, this will likely cover most use cases (since most people actually do use @wraps). -- ___ Python tracker

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe we should tag this issue "newcomer friendly"? It seems a pretty open and shut case. -- ___ Python tracker ___ ___

[issue37842] Initialize Py_buffer variables more efficiently

2019-08-13 Thread Sergey Fedoseev
New submission from Sergey Fedoseev : Argument Clinic generates `{NULL, NULL}` initializer for Py_buffer variables. Such initializer zeroes all Py_buffer members, but as I understand only `obj` and `buf` members are really had to be initialized. Avoiding unneeded initialization provides tiny

[issue37842] Initialize Py_buffer variables more efficiently

2019-08-13 Thread Sergey Fedoseev
Change by Sergey Fedoseev : -- keywords: +patch pull_requests: +14975 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15254 ___ Python tracker ___

[issue21109] tarfile: Traversal attack vulnerability

2019-08-13 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: SafeTarFile does not pass the existing tests, mainly because the existing file Lib/test/tarfiletestdata/testtar.tar seems to be "unsafe", producing errors like these: tarfile.SecurityError: : block device tarfile.SecurityError: : duplicate name It seems

[issue25299] TypeError: __init__() takes at least 4 arguments (4 given)

2019-08-13 Thread paul j3
paul j3 added the comment: I'm not set up to work with the current development distribution (via github). All my proposed patches are diffs for earlier repos. Paul -- ___ Python tracker __

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Brett Cannon
Change by Brett Cannon : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue37843] CGIHTTPRequestHandler does not take args.directory in constructor

2019-08-13 Thread Richard Jayne
New submission from Richard Jayne : In Lib/http/server.py if args.cgi: handler_class = CGIHTTPRequestHandler else: handler_class = partial(SimpleHTTPRequestHandler, directory=args.directory) Notice that CGIHTTPRequestHandler does not acce

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I personally don't think we need to change this. C and Python are different, and the PEP 7 rules have been in place for ages. +Guido -- nosy: +gvanrossum ___ Python tracker

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PEP 8 contains contradictory examples. https://www.python.org/dev/peps/pep-0008/#indentation > # No extra indentation. > if (this_is_one_thing and > that_is_another_thing): > do_something() > > # Add a comment, which will provid

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > I like to run pyflakes time to time on the Python code base. Please avoid > "import *" since it prevents pyflakes (and other code analyzers) to find bugs. Ah fair enough, thanks! Pushed that change to the next/current PR, GH-15248. -- ___

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
Steve Dower added the comment: New changeset b0dace3e979381426385c551b116d0f1434096ee by Steve Dower in branch 'master': bpo-37841: Remove python_uwp dependency on msvcp140.dll (GH-15253) https://github.com/python/cpython/commit/b0dace3e979381426385c551b116d0f1434096ee -- _

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +14976 pull_request: https://github.com/python/cpython/pull/15257 ___ Python tracker ___ __

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1ac2a83f30312976502fda042db5ce18d10ceec2 by Victor Stinner (Hai Shi) in branch 'master': bpo-37583: Add err 113 to support.get_socket_conn_refused_errs() (GH-14729) https://github.com/python/cpython/commit/1ac2a83f30312976502fda042db5ce18d10ceec

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +14977 pull_request: https://github.com/python/cpython/pull/15258 ___ Python tracker ___ __

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: > I looked into this spawn problem. It's due to Cygwin's spawnve, which calls > NtOpenFile to open the file, and then memory-maps it and reads the image > header [1]. Great, that's roughly what I suspected. Unfortunately, I've been told that looking into Cygwi

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > BTW: Since when do we use type annotations in Python's stdlib ? Hmm, interesting question! At a quick grep, it's in a handful of places in the stdlib: asyncio, functools, importlib. The earliest it appeared was in 3.7.0a4. It's in more places in the test suit

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset 853eecc7692503fec8240fd9a74d9f88e0392630 by Miss Islington (bot) in branch '3.8': bpo-37841: Remove python_uwp dependency on msvcp140.dll (GH-15253) https://github.com/python/cpython/commit/853eecc7692503fec8240fd9a74d9f88e0392630 -- n

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread hai shi
Change by hai shi : -- pull_requests: +14978 pull_request: https://github.com/python/cpython/pull/15259 ___ Python tracker ___ ___ P

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Netzeband
Netzeband added the comment: Thanks for your feedback. I can create a pull-request. However, I did it never before for the Python-Lib, so I first have to setup the correct environment for that and ensure, that I can run all test-cases. Since I'm on vacation soon, it could take several weeks.

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Guido van Rossum
Guido van Rossum added the comment: PEP 8 intentionally allows users to choose whether to put the operator at the start or end of the line (as long as they're consistent within a file or project). This is to avoid a barrage of "style fixes" that are just noise. But PEP 7 is only for CPython'

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset ee989512528d178d6f088916aba3e67ea9487ceb by Miss Islington (bot) in branch '3.8': bpo-37583: Add err 113 to support.get_socket_conn_refused_errs() (GH-14729) https://github.com/python/cpython/commit/ee989512528d178d6f088916aba3e67ea9487ceb ---

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: > If we support reading junctions, this should be using the substitute name > (with \??\ replaced by \\?\) instead of the print name. GetFinalPathName() does this conversion for us, any reason not to use that? (GetFullPathName() doesn't seem to recognize the \?

[issue37844] PyRun_SimpleFile should provide a version that does not need a FILE*

2019-08-13 Thread Christian Biesinger
New submission from Christian Biesinger : Because FILE* requires that the runtime library matches between Python and a program using it, it is very hard to use this correctly on Windows. It would be nice if Python provided either: - A function to open a FILE* given a filename, suitable for pa

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is the minimal Python version for developing CPython? The system Python 3 on current Ubuntu LTS (18.04) is 3.6, so I think it should not be larger. -- nosy: +serhiy.storchaka ___ Python tracker

[issue37845] SLCertVerificationError: Unable to handle SAN names (from Certifications) published with white spaces at start

2019-08-13 Thread David K.
New submission from David K. : Unable to establish SSL connections using company's private certificates where their SANs (Subject Alternative Names) contain at least one DNS Name that starts with white spaces. Attempting to establish SSL connection would result in Exception: SSLCertVerificati

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: Latest PR update uses GetFinalPathName to resolve SubstituteName, returning it unmodified on failure (e.g. symlink where the target file no longer exists). Replacing "\??\" with "\\?\" in place is trivial though, as we start with a mutable buffer. I'm just not

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > What is the minimal Python version for developing CPython? The system Python > 3 on current Ubuntu LTS (18.04) is 3.6, so I think it should not be larger. Ah, I think my previous message had an ambiguous parse: the earliest that *uses* of the typing module app

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > I just checked and `python3.6 Tools/unicode/makeunicodedata.py` works fine, > both at master and with GH-15248. This is good. But the title mentioned dataclasses, and they are 3.7+. -- ___ Python tracker

[issue37845] SLCertVerificationError: Unable to handle SAN names (from Certifications) published with white spaces at start

2019-08-13 Thread David K.
Change by David K. : -- keywords: +patch pull_requests: +14979 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15260 ___ Python tracker ___ ___

[issue21131] test_faulthandler.test_register_chain fails on 64bit ppc/arm with kernel >= 3.10

2019-08-13 Thread Bennet Fauber
Bennet Fauber added the comment: One additional note on this. Thanks to a colleague at USC who pointed out that this bug does not seem to get exercised if one does not include `--enable-shared` at configuration. I confirmed this using the distributed Python-3.7.4.tgz file and `configure --

  1   2   >