[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: shutil.COPY_BUFSIZE isn't documented. Is it a deliberate choice? https://docs.python.org/dev/library/shutil.html -- ___ Python tracker ___ __

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread STINNER Victor
New submission from STINNER Victor : TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x: * The tests should be skipped on this buildbot worker * Or the feature should be fixed on FreeBSD https://buildbot.python.org/all/#/builders/168/builds/617 Example: ERROR: test_shared_memory_Shar

[issue29659] Expose the `length` arg from shutil.copyfileobj for public use

2019-02-25 Thread Inada Naoki
Inada Naoki added the comment: bpo-33671 fixed this. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed versions: +Python 3.8 -Python 3.7 ___ Python tracker __

[issue36103] Increase

2019-02-25 Thread Inada Naoki
Change by Inada Naoki : -- nosy: inada.naoki priority: normal severity: normal status: open title: Increase ___ Python tracker ___ _

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread Inada Naoki
New submission from Inada Naoki : shutil.COPY_BUFSIZE is 16KiB on non-Windows platform. But it seems bit small for performance. As this article[1], 128KiB is the best performance on common system. [1]: https://eklitzke.org/efficient-file-copying-on-linux Another resource: EBS document [2] uses

[issue35886] Move PyInterpreterState into Include/internal/pycore_pystate.h

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: > This broke cffi: Well, that's not a surprise :-) It's a deliberate backward incompatible change. But that's where I suggested to test "popular C extensions" with a C API change before merging it. It's ok if issues are discovered later, but the author of b

[issue10308] Modules/getpath.c bugs

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: I reviewed getpath.diff: diff -pru Python-2.7/Modules/getpath.c Python-2.7/Modules/getpath.c --- Python-2.7/Modules/getpath.c +++ Python-2.7/Modules/getpath.c @@ -218,7 +218,7 @@ joinpath(char *buffer, char *stuff) if (n > MAXPATHLEN) Py_FatalErr

[issue34656] [CVE-2018-20406] memory exhaustion in Modules/_pickle.c:1393

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: As I wrote in my previous comment, I don't think that Python 2.7 is affected by this issue. -- components: +Library (Lib) -ctypes versions: +Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8 -Python 2.7 _

[issue36093] UnicodeEncodeError raise from smtplib.verify() method

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: Barry: would you mind to have a look at this issue? It seems like smtplib encodes Unicode commands to ASCII, whereas verify() argument (SMTP "VRFY" command) is an hostname and hostname can be non-ASCII ("punycode" encoding, RFC 3492). -- nosy: +barr

[issue35886] Move PyInterpreterState into Include/internal/pycore_pystate.h

2019-02-25 Thread Nathaniel Smith
Nathaniel Smith added the comment: The cffi issue is: https://bitbucket.org/cffi/cffi/issues/403/build-fails-on-38-dev-pyinterpreterstate Armin already went ahead and committed the change to make cffi include internal/pycore_pystate.h. I guess this might not be the ideal final outcome thoug

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread Łukasz Langa
New submission from Łukasz Langa : The ARMv7 Ubuntu buildbot is consistently failing since build #2160: https://buildbot.python.org/all/#/builders/106/builds/2160 This looks like a testing environment issue to me rather than a code issue. But I'd like it fixed either way before we get to 3.8.0

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola' : This is what MS doc says about GetSystemInfo: https://docs.microsoft.com/en-us/windows/desktop/api/sysinfoapi/nf-sysinfoapi-getsysteminfo <> $ grep -r GetSystemInfo Modules/_ctypes/malloc_closure.c:GetSystemInfo(&systeminfo); Modules/mmapmodule.c

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: I guess it depends on what the information is used for. From a quick glance at the code I'd say that the current usage is correct, and that GetNativeSystemInfo could be used when reporting about the currently running system (for example by functions in the

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2019-02-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Yes, it's deliberate, see PR-12016. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue35810] Object Initialization does not incref Heap-allocated Types

2019-02-25 Thread Eddie Elizondo
Eddie Elizondo added the comment: > could we just remove the whole concept of heap allocated types? I do have plans to start migrating more and more CPython modules to use heap allocated types. For example I have posixmodule up in the queue (PR10854) and a local change with all of _io migrat

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: > Yes, it's deliberate, see PR-12016. "I decided not to document `shutil.COPY_BUFSIZE` because I consider it a corner case." Ok. I have no opinion on that, I just wanted to ask the question :-) -- ___ Python trac

[issue32129] Icon on macOS

2019-02-25 Thread Kevin Walzer
Kevin Walzer added the comment: Is there any reason not to commit the patch I submitted to address this issue?As an alternative I can submit a high-res PNG that can be used, and will submit a different patch to incorporate it, which would work from either the standard app bundle or the comma

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Related to issue35925 ? -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list ma

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +pablogsal, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Dmitrii Pasechnik
New submission from Dmitrii Pasechnik : The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on Fre

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread SilentGhost
Change by SilentGhost : -- nosy: +mark.dickinson stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> duplicate superseder: -> test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a) ___ Python tracker

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: bpo-36104 has been marked as a duplicate of this issue. Copy of Lukasz's msg336511: The ARMv7 Ubuntu buildbot is consistently failing since build #2160: https://buildbot.python.org/all/#/builders/106/builds/2160 This looks like a testing environment issue t

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: Lukasz: this issue is that Debian Buster uses a strict OpenSSL policy. I guess that external public server used by tests are incompatible with this strict policy. -- nosy: +lukasz.langa ___ Python tracker

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Davin Potts added the comment: Though apparently undocumented on FreeBSD, their implementation of shm_open differs from others in the following way: all names for shared memory blocks *must* begin with a slash. This requirement does not exist on OpenBSD. According to its man page on shm_op

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread STINNER Victor
Change by STINNER Victor : -- stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mail

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread desbma
desbma added the comment: Your first link explains why 128kB buffer size is faster in the context of cp: it's due to fadvise and kernel read ahead. None of the shutil functions call fadvise, so the benchmark and conclusions are irrelevant to the Python buffer size IMO. In general, the bigge

[issue36078] argparse: positional with type=int, default=SUPPRESS raise ValueError

2019-02-25 Thread Axel
Axel added the comment: Thanks for so fast looking into this. Good idea to use the workaround with a own conversion function. I'll use this for now. To see what's happening, I tried a own Action with print in __call__ and a own conversion function with printing. I found following workflow:

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Emmanuel Arias
Emmanuel Arias added the comment: Hi!, It seem a good improve to resolve a potential problem. But I am not convinced if that problem could appear because sinpi() is definded locally. -- ___ Python tracker ___

[issue30782] Allow limiting the number of concurrent tasks in asyncio.as_completed

2019-02-25 Thread Andrey Paramonov
Andrey Paramonov added the comment: > an implicit requirement that back pressure from the consumer should be > handled (i.e. if whoever's iterating through "async for fut in > as_completed(...)" is too slow, then the tasks should pause until it catches > up) No, I don't think it is required

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Steve Dower
Steve Dower added the comment: Yeah, possibly only the CPU count one could change, but there's an ongoing discussion on another bug about whether that should return the actual count or the usable count. 32-bit processes have restrictions beyond what the system is capable of, and I believe w

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Dmitrii Pasechnik
Dmitrii Pasechnik added the comment: This has a potential header conflict. For the same reason functions like lgamma, etc. are prefixed with `m_` in Modules/mathmodule.c -- ___ Python tracker ___

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Dmitrii Pasechnik
Dmitrii Pasechnik added the comment: e.g. if I rename `m_lgamma` to `lgamma` I get ``` mathmodule.c:389:1: error: static declaration of ‘lgamma’ follows non-static declaration lgamma(double x) ``` -- ___ Python tracker

[issue36030] add internal API function to create tuple without items array initialization

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This change is virtually renaming _PyStack_AsTuple to _PyTuple_FromArray and using it in appropriate places for code simplification. I am +1 for such change. -- ___ Python tracker

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Davin Potts added the comment: In local testing, I found the following systems to impose the leading slash as a requirement for simply creating a shared memory block: * NetBSD 8.0 * FreeBSD 12.x * TrueOS 18.12 (the OS formerly known as PC-BSD) I found the following systems to have no required

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: It appears you guys are right. Sorry for the noise. -- ___ Python tracker ___ ___ Python-bugs-

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Emmanuel Arias
Change by Emmanuel Arias : -- nosy: +eamanu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread Inada Naoki
Inada Naoki added the comment: > Your first link explains why 128kB buffer size is faster in the context of > cp: it's due to fadvise and kernel read ahead. > > None of the shutil functions call fadvise, so the benchmark and conclusions > are irrelevant to the Python buffer size IMO. Even w

[issue36048] Deprecate implicit truncating when convert Python numbers to C integers: use __index__, not __int__

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 6a44f6eef3d0958d2347190b3e2d1222c2e9 by Serhiy Storchaka in branch 'master': bpo-36048: Use __index__() instead of __int__() for implicit conversion if available. (GH-11952) https://github.com/python/cpython/commit/6a44f6eef3d0958d234

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a180b007d96fe68b32f11dec720fbd0cd5b6758a by Serhiy Storchaka in branch 'master': bpo-28450: Fix and improve the documentation for unknown escapes in RE. (GH-11920) https://github.com/python/cpython/commit/a180b007d96fe68b32f11dec720fbd0cd5b67

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a24107b04c1277e3c1105f98aff5bfa3a98b33a0 by Serhiy Storchaka in branch 'master': bpo-35459: Use PyDict_GetItemWithError() instead of PyDict_GetItem(). (GH-2) https://github.com/python/cpython/commit/a24107b04c1277e3c1105f98aff5bfa3a98b33a0

[issue35178] Typo/trivial mistake in warnings.py (may be related to 2.x to 3.x conversion)

2019-02-25 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: @tashrifbillah I will be happy to add a test on a follow up PR attributing to the original PR as per https://github.com/python/cpython/pull/10343#issuecomment-467026474 Thanks -- nosy: +xtreak ___ Pytho

[issue36048] Deprecate implicit truncating when convert Python numbers to C integers: use __index__, not __int__

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +12060 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34781] infinite waiting in multiprocessing.Pool

2019-02-25 Thread Dongyan Li
Dongyan Li added the comment: I got the same issue with Python 3.7.2 on Windows Build 14393. Seems that the program got stuck on the `waiter.acquire()` method. -- nosy: +Dongyan Li ___ Python tracker __

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 95fc8e687c487ecf97f4b1b98dfc0c05e3c9cbff by Serhiy Storchaka in branch '3.7': [3.7] bpo-28450: Fix and improve the documentation for unknown escapes in RE. (GH-11920). (GH-12029) https://github.com/python/cpython/commit/95fc8e687c487ecf97f4b1

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32129] Icon on macOS

2019-02-25 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +12061 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
New submission from Natanael Copa : Alpine Linux's python 3.6.8 native build on aarch64 gets killed by stack protector when run on Raspberry Pi 3. It does not happen when same binary runs on packet.net's aarch64 machine. I was able to get a backtrace by copying the core. Core was generated b

[issue36030] add internal API function to create tuple without items array initialization

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset 234531b4462b20d668762bd78406fd2ebab129c9 by Victor Stinner (Sergey Fedoseev) in branch 'master': bpo-36030: Add _PyTuple_FromArray() function (GH-11954) https://github.com/python/cpython/commit/234531b4462b20d668762bd78406fd2ebab129c9

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Natanael Copa added the comment: Interestingly, it does not crash when I run python in valgrind. -- ___ Python tracker ___ ___ Pyth

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Natanael Copa added the comment: Valgrind claims there are some use of uninitialized values. -- Added file: https://bugs.python.org/file48169/valgrind.out ___ Python tracker _

[issue36030] add internal API function to create tuple without items array initialization

2019-02-25 Thread Sergey Fedoseev
Change by Sergey Fedoseev : -- pull_requests: +12062 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-02-25 Thread Eric Snow
Eric Snow added the comment: GH-11617 has introduces a slight performance regression which will need to be resolved. If I can't find the problem right away then I'll probably temporarily revert the commit. See https://mail.python.org/pipermail/python-dev/2019-February/156451.html.

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Natanael Copa added the comment: It seems like python 3.7.2 works. Any idea which commit(s) may have fixed it? -- ___ Python tracker ___ __

[issue32129] Icon on macOS

2019-02-25 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +12064 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue35178] Typo/trivial mistake in warnings.py (may be related to 2.x to 3.x conversion)

2019-02-25 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +12063 stage: -> patch review ___ Python tracker ___ ___ Py

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread desbma
desbma added the comment: If you do a benchmark by reading from a file, and then writing to /dev/null several times, without clearing caches, you are measuring *only* the syscall overhead: * input data is read from the Linux page cache, not the file on your SSD itself * no data is written (ob

[issue32129] IDLE app icon is blurry on macOS with Aqua Tk 8.6

2019-02-25 Thread Ned Deily
Ned Deily added the comment: Thanks, Kevin, for the reminder. Yeah, there's no reason not to push this. I've attached PRs for 3.x and for 2.7. -- stage: patch review -> commit review title: Icon on macOS -> IDLE app icon is blurry on macOS with Aqua Tk 8.6 versions: +Python 2.7, Pyt

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Change by Natanael Copa : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue35840] Control flow inconsistency on closed asyncio stream

2019-02-25 Thread Emmanuel Arias
Emmanuel Arias added the comment: Ok, I am working on that. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue36108] Avoid failing the build on race condition in clean

2019-02-25 Thread Steve Dower
New submission from Steve Dower : In PCbuild/openssl.props there is a task that deletes some copied files. This *might* fail on rebuilds where a Python process from a previous build has been running (for a very specific example, the rebuild as part of the release build triggered this). We s

[issue36039] Replace append loops with list comprehensions

2019-02-25 Thread Lukas Geiger
Lukas Geiger added the comment: Thank you very much for your thorough explanation, totally makes sense. -- ___ Python tracker ___ _

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Change by Davin Potts : -- keywords: +patch pull_requests: +12065 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue34623] _elementtree.c doesn't call XML_SetHashSalt()

2019-02-25 Thread Larry Hastings
Larry Hastings added the comment: New changeset d16eaf36795da48b930b80b20d3805bc27820712 by larryhastings (stratakis) in branch '3.4': [3.4] bpo-34623: Use XML_SetHashSalt in _elementtree (#9953) https://github.com/python/cpython/commit/d16eaf36795da48b930b80b20d3805bc27820712 -- _

[issue34623] _elementtree.c doesn't call XML_SetHashSalt()

2019-02-25 Thread Larry Hastings
Larry Hastings added the comment: New changeset 41b48e71ac8a71f56694b548f118bd20ce203410 by larryhastings (stratakis) in branch '3.5': [3.5] bpo-34623: Use XML_SetHashSalt in _elementtree (#9933) https://github.com/python/cpython/commit/41b48e71ac8a71f56694b548f118bd20ce203410 -- _

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Davin Potts added the comment: I have locally tested GH-12036 on all 5 of the aforementioned OSes and all are made happy by the patch. Victor: If we want to go ahead and apply this patch right away to hopefully make the FreeBSD buildbot go green, the nature of this change is sufficiently s

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Change by Davin Potts : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

2019-02-25 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : https://buildbot.python.org/all/#/builders/32/builds/2198 == ERROR: test_vicious_descriptor_nonsense (test.test_descr.ClassPropertiesAndMethods) -

[issue35512] patch.dict resolves in_dict eagerly (should be late resolved)

2019-02-25 Thread Chris Withers
Chris Withers added the comment: New changeset ea199b90bb61866cd3c2f154341d1eb0d5c4a710 by Chris Withers (Miss Islington (bot)) in branch '3.7': bpo-35512: Resolve string target to patch.dict decorator during function call GHGH-12000 (#12021) https://github.com/python/cpython/commit/ea199b90

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2019-02-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: Sorry, no. I have long lost context and interest in this. -- ___ Python tracker ___ ___ Python-bug

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I can reproduce this locally. How has this not being spotted by the CI: ❯ ./python.exe -m test test_descr Run tests sequentially 0:00:00 load avg: 3.82 [1/1] test_descr test test_descr failed -- Traceback (most recent call last): File "/Users/pgalindo3

[issue35746] [ssl][CVE-2019-5010] TALOS-2018-0758 Denial of Service

2019-02-25 Thread Larry Hastings
Larry Hastings added the comment: New changeset 6c655ce34ae54adb8eef22b73108e22cc381cb8d by larryhastings (Victor Stinner) in branch '3.4': bpo-35746: Fix segfault in ssl's cert parser (GH-11569) (#11868) https://github.com/python/cpython/commit/6c655ce34ae54adb8eef22b73108e22cc381cb8d

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: Apply the patch, we will see if the buildbot color changes :-) -- ___ Python tracker ___ ___ Pyth

[issue36110] test_descr: test_vicious_descriptor_nonsense() fails randomly

2019-02-25 Thread STINNER Victor
New submission from STINNER Victor : test_vicious_descriptor_nonsense() started to fails randomly: $ ./python -m test -j0 -F test_descr test_descr test_descr test_descr test_descr test_descr Run tests in parallel using 10 child processes 0:00:03 load avg: 1.24 [1/6] test_descr passed 0:00:03 l

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: It seems like the change introduced a regression: bpo-36110. -- ___ Python tracker ___ ___ Python

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: It seems that this is a race condition created as a consequence of: https://github.com/python/cpython/pull/2/files -- nosy: +serhiy.storchaka ___ Python tracker

[issue36030] add internal API function to create tuple without items array initialization

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset f1b9abe35f75393351b3d954a392122a3f8f6951 by Victor Stinner (Sergey Fedoseev) in branch 'master': bpo-36030: Remove _PyStack_AsTuple() and _PyStack_AsTupleSlice() (GH-12032) https://github.com/python/cpython/commit/f1b9abe35f75393351b3d954a392122

[issue36111] Negative `offset` values are no longer acceptable with implementation of `seek` with python3; should be per POSIX

2019-02-25 Thread Enji Cooper
New submission from Enji Cooper : I tried using os.SEEK_END in a technical interview, but unfortunately, that didn't work with python 3.x: pinklady:cpython ngie$ python3 Python 3.7.2 (default, Feb 12 2019, 08:15:36) [Clang 10.0.0 (clang-1000.11.45.5)] on darwin Type "help", "copyright", "cred

[issue36111] Negative `offset` values are no longer acceptable with implementation of `seek` with python3; should be per POSIX

2019-02-25 Thread Steven D'Aprano
Steven D'Aprano added the comment: I believe you will find that this is because you opened the file in text mode, which means Unicode, not bytes. If you open it in binary mode, the POSIX spec applies: py> fp = open("sample", "rb"); fp.seek(-100, os.SEEK_END) 350 Supported values for seeking

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Rohit travels and tours
Change by Rohit travels and tours : -- type: -> resource usage ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Davin Potts added the comment: New changeset aadef2b41600cb6a4f845cdc4cea001c916d8745 by Davin Potts in branch 'master': bpo-36102: Prepend slash to all POSIX shared memory block names (#12036) https://github.com/python/cpython/commit/aadef2b41600cb6a4f845cdc4cea001c916d8745 -- ___

[issue36111] Negative `offset` values are no longer acceptable with implementation of `seek` with python3; should be per POSIX

2019-02-25 Thread Enji Cooper
Enji Cooper added the comment: ?! Being blunt: why should opening a file in binary vs text mode matter? POSIX doesn't make this distinction. Per the pydoc (https://docs.python.org/2/library/functions.html#open): > The default is to use text mode, which may convert '\n' characters to a > pl

[issue34656] [CVE-2018-20406] memory exhaustion in Modules/_pickle.c:1393

2019-02-25 Thread Larry Hastings
Larry Hastings added the comment: New changeset 4b42d575bf0fb01192b3ec54b7e224b238691527 by larryhastings (Victor Stinner) in branch '3.4': [3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) (#11870) https://github.com/python/cpython/commit/4b42d575bf0fb01192b3ec54b

[issue36111] Negative `offset` values are no longer acceptable with implementation of `seek` with python3 when in text mode; should be per POSIX

2019-02-25 Thread Enji Cooper
Change by Enji Cooper : -- title: Negative `offset` values are no longer acceptable with implementation of `seek` with python3; should be per POSIX -> Negative `offset` values are no longer acceptable with implementation of `seek` with python3 when in text mode; should be per POSIX

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Davin Potts added the comment: Closing. Thank you Giampaolo for jumping in so quickly to review! Thank you Victor for catching this on the buildbot. Though what is this talk of "_if_ the color changes"? ;) -- resolution: -> fixed stage: patch review -> resolved status: open -> clo

[issue35802] os.stat / os.lstat always present, but code checks hastattr(os, 'stat') / hasattr(os, 'lstat')

2019-02-25 Thread Anthony Sottile
Change by Anthony Sottile : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list ma

[issue35892] Fix awkwardness of statistics.mode() for multimodal datasets

2019-02-25 Thread Steven D'Aprano
Steven D'Aprano added the comment: Executive summary: - let's change the behaviour of mode to return a single mode rather than raise an exception if there are multimodes; - and let's do it without a depreciation period. Further comments in no particular order: I agree that in practice the

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: FYI the test also failed on AMD64 FreeBSD 10-STABLE Non-Debug 3.x: https://buildbot.python.org/all/#/builders/167/builds/600 I will keep on eye on this buildbot worker as well ;-) -- ___ Python tracker

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2019-02-25 Thread Larry Hastings
Larry Hastings added the comment: New changeset 8bcbc7896d1fe1c289bae339d408fdf1472a00fa by larryhastings (Victor Stinner) in branch '3.5': bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907) (#11874) https://github.com/python/cpython/commit/8bcbc7896d1fe1c289bae339d408fdf1472a0

[issue35892] Fix awkwardness of statistics.mode() for multimodal datasets

2019-02-25 Thread Steven D'Aprano
Steven D'Aprano added the comment: What do people think about leaving this as an "Easy First Issue" for the sprint? If others agree that it is sufficiently easy, we can assign the task to Cheryl. It should be fairly easy: mode calls an internal function _counts which is not public and not u

[issue36112] os.path.realpath on windows and substed drives

2019-02-25 Thread Totte Karlsson
New submission from Totte Karlsson : Python's os.path.realpath, when used with a substed drive on the Windows platform, don't resolve the substed path to the *real* path. For example creating a substed drive like this: subst z: C:\Users\Public\Desktop and checking for the real path in p

[issue36110] test_descr: test_vicious_descriptor_nonsense() fails randomly

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Duplicate of https://bugs.python.org/issue36109 -- nosy: +pablogsal ___ Python tracker ___ ___

[issue36110] test_descr: test_vicious_descriptor_nonsense() fails randomly

2019-02-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36110] test_descr: test_vicious_descriptor_nonsense() fails randomly

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I was faster this time ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue34791] xml package does not obey sys.flags.ignore_environment

2019-02-25 Thread Larry Hastings
Larry Hastings added the comment: New changeset 765d333512e9b58da4a4431595a0e81517ef0443 by larryhastings (Victor Stinner) in branch '3.4': bpo-34791: xml package obeys ignore env flags (GH-9544) (#11872) https://github.com/python/cpython/commit/765d333512e9b58da4a4431595a0e81517ef0443

[issue24235] ABCs don't fail metaclass instantiation

2019-02-25 Thread Cheryl Sabella
Cheryl Sabella added the comment: Closing as a duplicate as Luiz suggested. -- nosy: +cheryl.sabella resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> abstract class instantiable when subclassing built-in types ___

[issue36046] support dropping privileges when running subprocesses

2019-02-25 Thread Patrick McLean
Patrick McLean added the comment: Alexey, here are my responses to your points: 1) This is intentional, this is for dropping privileges before running some (possibly untrusted) command, we do not want to leave a path for the subprocess to gain root back. If there is a subprocess that needs r

[issue25337] weakref.finalize documentation refers to old interpreter shutdown behavior

2019-02-25 Thread Cheryl Sabella
Cheryl Sabella added the comment: Adding @pitrou to the nosylist as he implemented PEP442 in issue 18112. If he agrees with the proposed change, then I believe this can be marked as 'easy'. -- nosy: +cheryl.sabella, pitrou versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5, Py

  1   2   >