[issue35393] Typo in documentation

2018-12-03 Thread Filip Bengtsson
Filip Bengtsson added the comment: https://github.com/python/cpython/pull/10876/commits/00f39c15a13377f3920c72267b2b78a043d9b8ab -- ___ Python tracker ___

[issue35387] Dialogs on IDLE are accompanied by a small black window

2018-12-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I just updated my Macbook to Mohave. As implied, I do not see this on installed 3.7.1 with 8.6.8. But this is a heads-up for future releases. Someone with both a Mac Python development environment + tip 8.6 would have to look at this now. When the packag

[issue35310] select which was interrupted by EINTR isn't re-run if the timeout has passed

2018-12-03 Thread Oran Avraham
Change by Oran Avraham : -- pull_requests: +10116 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue35380] Enable TCP_NODELAY for proactor event loop

2018-12-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset fe91e9ba08a8854e2149398386702828fe3c0038 by Andrew Svetlov (Miss Islington (bot)) in branch '3.7': [3.7] bpo-35380: Enable TCP_NODELAY for proactor event loop (GH-10867) (GH-10872) https://github.com/python/cpython/commit/fe91e9ba08a8854e214939

[issue35226] mock.call equality surprisingly broken

2018-12-03 Thread miss-islington
Change by miss-islington : -- pull_requests: +10117 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35226] mock.call equality surprisingly broken

2018-12-03 Thread Chris Withers
Chris Withers added the comment: New changeset 8ca0fa9d2f4de6e69f0902790432e0ab2f37ba68 by Chris Withers in branch 'master': bpo-35226: Fix equality for nested unittest.mock.call objects. (#10555) https://github.com/python/cpython/commit/8ca0fa9d2f4de6e69f0902790432e0ab2f37ba68 --

[issue35226] mock.call equality surprisingly broken

2018-12-03 Thread miss-islington
Change by miss-islington : -- pull_requests: +10118 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35226] mock.call equality surprisingly broken

2018-12-03 Thread Chris Withers
Chris Withers added the comment: New changeset 67e6136a6d5c07141d4dba820c450a70db7aedd5 by Chris Withers (Miss Islington (bot)) in branch '3.6': bpo-35226: Fix equality for nested unittest.mock.call objects. (GH-10555) https://github.com/python/cpython/commit/67e6136a6d5c07141d4dba820c450a70d

[issue35226] mock.call equality surprisingly broken

2018-12-03 Thread Chris Withers
Chris Withers added the comment: New changeset e8f9e4785caeef8a68bb7859280e91a4cb424b79 by Chris Withers (Miss Islington (bot)) in branch '3.7': bpo-35226: Fix equality for nested unittest.mock.call objects. (GH-10555) https://github.com/python/cpython/commit/e8f9e4785caeef8a68bb7859280e91a4c

[issue35394] Add __slots__ = () to asyncio protocols

2018-12-03 Thread Andrew Svetlov
New submission from Andrew Svetlov : Protocols have no members. Adding empty slots doesn't harm any existing code but it allows to write proper protocol implementation with slot-based class. -- components: asyncio messages: 330986 nosy: asvetlov, yselivanov priority: normal severity:

[issue35226] mock.call equality surprisingly broken

2018-12-03 Thread Chris Withers
Change by Chris Withers : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mail

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

2018-12-03 Thread Chris Withers
Chris Withers added the comment: xtreak - great to see action on this! First step would be to add a unit test for the failure case I reported. I like the tests you have too, but would be good to see the specific failure case covered too. Beyond that, if we can get all the the new tests passi

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread STINNER Victor
STINNER Victor added the comment: tzickel: > A. The documentation explicitly says: "When the pool object is garbage > collected terminate() will be called immediately." (Happened till a code > refactor 9 years ago introduced this bug). It is a *very bad* practice to rely on __del__. Don't do

[issue35395] Typo in asyncio eventloop documentation

2018-12-03 Thread Naglis
New submission from Naglis : loop.add_writer and loop.add_signal_handler have *callback* in their signatures, but in their documentation regarding functools.partial usage the function is referred to as *func*. -- assignee: docs@python components: Documentation messages: 330989 nosy: d

[issue35395] Typo in asyncio eventloop documentation

2018-12-03 Thread Naglis
Change by Naglis : -- keywords: +patch pull_requests: +10119 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue35395] Typo in asyncio eventloop documentation

2018-12-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: Would you create a PR with a fix? -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list

[issue35395] Typo in asyncio eventloop documentation

2018-12-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: Sorry, you did already -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35396] Add support for __fspath__ to fnmatch.fnmatchase and filter

2018-12-03 Thread Andrés Delfino
New submission from Andrés Delfino : Both fnmatch.fnmatchase and fnmatch.filter (in Unix) do not support path-like objects. This is inconvenient, for example, when taking advantage of os.scandir and working with os.DirEntry objets. Also, fnmatch.filter in Windows does support path-like object

[issue35396] Add support for __fspath__ to fnmatch.fnmatchase and filter

2018-12-03 Thread Andrés Delfino
Change by Andrés Delfino : -- keywords: +patch pull_requests: +10121 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue35377] urlparse doesn't validate the scheme

2018-12-03 Thread Steven D'Aprano
Steven D'Aprano added the comment: I'm changing the name to better describe the problem, and suggest a better solution. The urlparse.urlsplit and .urlunsplit functions currently don't validate the scheme argument, if given. According to the RFC: Scheme names consist of a sequence of char

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I'm not comfortable with the fix. I cannot explain why but I feel like adding > a strong dependency from a child to its parent is going to lead to more bugs, > not less. It sounds like a recipe for reference cycles. Maybe I'm just plain > wrong. Th

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg330994 ___ Python tracker ___ ___ Python-bugs-list

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I'm not comfortable with the fix. I cannot explain why but I feel like adding > a strong dependency from a child to its parent is going to lead to more bugs, > not less. It sounds like a recipe for reference cycles. Maybe I'm just plain > wrong. Th

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I'm not comfortable with the fix. I cannot explain why but I feel like adding > a strong dependency from a child to its parent is going to lead to more bugs, > not less. It sounds like a recipe for reference cycles. Maybe I'm just plain > wrong. Th

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg330995 ___ Python tracker ___ ___ Python-bugs-list

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread STINNER Victor
STINNER Victor added the comment: > I found the weird code in the example in several projects. I have corrected > it to use the pool as a context manager or to call close(), but this means > that users are doing this and it used to work and not it does not: > technically is a regression. Th

[issue35373] PyInit_timezone() must return a value

2018-12-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset 5eb78c75128187a36d8e983027632fa51cc2ff4d by Victor Stinner in branch '3.7': [3.7] bpo-35373: Fix PyInit_timezone() error handling (GH-10864) https://github.com/python/cpython/commit/5eb78c75128187a36d8e983027632fa51cc2ff4d --

[issue35373] PyInit_timezone() must return a value

2018-12-03 Thread miss-islington
Change by miss-islington : -- pull_requests: +10122 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I disagree that a child should keep its parent alive. But this is normal across the standard library. For example, here is how a deque iterator keeps the deque alive: >>> x = deque([1,2,3]) >>> deque_iter = iter(x) >>> deque_weakref = weakref.ref(x)

[issue35373] PyInit_timezone() must return a value

2018-12-03 Thread STINNER Victor
STINNER Victor added the comment: In Python 2.7, inittimezone() is simpler and so less likely to fail. I propose to leave Python 2.7 unchanged. -- versions: +Python 3.6, Python 3.7, Python 3.8 ___ Python tracker

[issue35373] PyInit_timezone() must return a value

2018-12-03 Thread miss-islington
miss-islington added the comment: New changeset f455353bc0d195e092f09fec92ed16e9be02b7b1 by Miss Islington (bot) in branch '3.6': [3.7] bpo-35373: Fix PyInit_timezone() error handling (GH-10864) https://github.com/python/cpython/commit/f455353bc0d195e092f09fec92ed16e9be02b7b1 -- nos

[issue35390] ctypes not possible to pass NULL c_void_p in structure by reference

2018-12-03 Thread Martin Panter
Martin Panter added the comment: This problem is common to structure fields in general, not just "c_void_p". I recently encountered it with a different type (don't remember the type now, but I notice plain types like c_int share the problem). I found

[issue35397] Undeprecate and document urllib.parse.unwrap

2018-12-03 Thread Steven D'Aprano
New submission from Steven D'Aprano : The urllib.parse module contains an undocumented function unwrap: unwrap('') --> 'type://host/path' This is useful. I've been re-inventing this function in many of my scripts, because I didn't know it existed (not documented!) and only stumbled across

[issue35373] PyInit_timezone() must return a value

2018-12-03 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue9338] argparse optionals with nargs='?', '*' or '+' can't be followed by positionals

2018-12-03 Thread kernc
Change by kernc : -- nosy: +kernc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mail

[issue35305] subprocess.Popen(['/sbin/ldconfig', '-p'], stdin=PIPE) itself hangs/deadlocks (Linux)

2018-12-03 Thread HenrikB
HenrikB added the comment: Thank you both for the comments and suggests. Before I'm getting to the "interesting" part, first to the "easy" one: >> What is also useful to know, is that I'm observing this on a legacy RHEL 6 >> system *with a customized kernel* part of the Scyld ClusterWare >

[issue35390] ctypes not possible to pass NULL c_void_p in structure by reference

2018-12-03 Thread Eryk Sun
Eryk Sun added the comment: Your example uses POINTER(c_double), not c_void_p. There's no problem with an actual pointer object (i.e. subclass of ctypes._Pointer). The problem is with simple types (i.e. immediate subclasses of ctypes._SimpleCData), including simple pointer types (i.e. c_void

[issue35398] SQLite incorrect row count for UPDATE

2018-12-03 Thread Montana Low
New submission from Montana Low : SQLite driver returns an incorrect row count (-1) for UPDATE statements that begin with a comment. Downstream Reference: https://github.com/sqlalchemy/sqlalchemy/issues/4396 Test Case: ``` import sqlite3 conn = sqlite3.connect(":memory:") cursor = conn.cu

[issue11107] Cache constant "slice" instances

2018-12-03 Thread Josh Rosenberg
Change by Josh Rosenberg : -- versions: +Python 3.8 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue35398] SQLite incorrect row count for UPDATE

2018-12-03 Thread mike bayer
Change by mike bayer : -- nosy: +zzzeek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue35399] Sysconfig bug

2018-12-03 Thread Jorge Ramos
New submission from Jorge Ramos : As can be seen in the file, the sysconfig test fails when profiling (PGO) this utility. This is the very same bug as described in issue#35299 https://bugs.python.org/issue35299 but in distutils. The problem is that when the test for sysconfig runs, it does no

[issue35400] PGOMGR : warning PG0188:

2018-12-03 Thread Jorge Ramos
New submission from Jorge Ramos : The following command: Tools\msi\buildrelease.bat -x64 is used to build a 64 bit version (on win_10_64) of python (using visual studio 2017). The following modules did not build correctly because, presumably, the corresponding .PGC files could not be found

[issue35399] Sysconfig bug

2018-12-03 Thread Jorge Ramos
Change by Jorge Ramos : -- components: +Build ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-03 Thread tzickel
tzickel added the comment: Reverting the code will cause another class of problems, like the reason I fixed it. Programs written such as the example that Pablo gave (and what I've seen) will quietly leak child processes, file descriptors (for the pipes) and memory to a variety degree might n

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-03 Thread Ned Deily
New submission from Ned Deily : New versions of OpenSSL were released on 2018-11-20. We should update for 3.7.2, 3.6.8, and 2.7.16. -- assignee: christian.heimes components: SSL, Windows, macOS messages: 331010 nosy: benjamin.peterson, christian.heimes, ned.deily, paul.moore, ronaldo

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-03 Thread Ned Deily
New submission from Ned Deily : Tcl/Tk 8.6.9 (followed by Tk 8.6.9.1) was released recently. Among other things, they contain fixes for various issues on macOS, some of which have been seen by macOS users of IDLE and other tkinter apps, so the macOS installer should definitely be updated for

[issue35395] Typo in asyncio eventloop documentation

2018-12-03 Thread miss-islington
miss-islington added the comment: New changeset 17473347942353946fe455f797a2197cb89c1090 by Miss Islington (bot) (Naglis) in branch 'master': bpo-35395: fix typos in asyncio eventloop documentation (GH-10880) https://github.com/python/cpython/commit/17473347942353946fe455f797a2197cb89c1090

[issue35395] Typo in asyncio eventloop documentation

2018-12-03 Thread miss-islington
Change by miss-islington : -- pull_requests: +10123 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35395] Typo in asyncio eventloop documentation

2018-12-03 Thread miss-islington
miss-islington added the comment: New changeset 6627d3ae1e151095fda4ec2592c7cfb759f23669 by Miss Islington (bot) in branch '3.7': bpo-35395: fix typos in asyncio eventloop documentation (GH-10880) https://github.com/python/cpython/commit/6627d3ae1e151095fda4ec2592c7cfb759f23669 --

<    1   2