[issue35115] UUID objects can't be casted by `hex()`

2018-10-31 Thread Mark Dickinson
Mark Dickinson added the comment: > I don't see large usability difference between 'uuid={:x}'.format(u) and > 'uuid={.hex}'.format(u). Agreed. @fcurella: marking as enhancement is fine, but you need to be specific about what exact enhancement you're proposing. Adding __hex__ back isn't a r

[issue35121] Cookie domain check returns incorrect results

2018-10-31 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: The current set of tests are at https://github.com/python/cpython/blob/0353b4eaaf451ad463ce7eb3074f6b62d332f401/Lib/test/test_http_cookiejar.py#L406 . A simple set of tuple that can be added based on the report as below : ("http://barfoo.com";, ".

[issue35110] Fix more spaces around hyphens and dashes

2018-10-31 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +9566 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35110] Fix more spaces around hyphens and dashes

2018-10-31 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +9567 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35110] Fix more spaces around hyphens and dashes

2018-10-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b183750f53bac7738b1fff114e0a2615d970 by Serhiy Storchaka in branch '3.7': [3.7] bpo-35110: Fix unintentional spaces around hyphens and dashes. (GH-10231). (GH-10253) https://github.com/python/cpython/commit/b183750f53bac7738b1fff114e0

[issue35110] Fix more spaces around hyphens and dashes

2018-10-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 1e8c18509eb15efb8e80971b9935d17e7bbeabf4 by Serhiy Storchaka in branch '3.6': [3.6] bpo-35110: Fix unintentional spaces around hyphens and dashes. (GH-10231). (GH-10254) https://github.com/python/cpython/commit/1e8c18509eb15efb8e80971b9935d17

[issue35110] Fix more spaces around hyphens and dashes

2018-10-31 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +9568 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35110] Fix more spaces around hyphens and dashes

2018-10-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 511747bec3aca4ad7930005e3adece9196c1cd39 by Serhiy Storchaka in branch 'master': bpo-35110: Fix yet few spaces before dashes. (GH-10255) https://github.com/python/cpython/commit/511747bec3aca4ad7930005e3adece9196c1cd39 -- __

[issue35110] Fix more spaces around hyphens and dashes

2018-10-31 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33138] Improve standard error for uncopyable types

2018-10-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Changed to "cannot pickle 'XXX' object" after discussing on Python-Dev: https://mail.python.org/pipermail/python-dev/2018-October/155599.html -- ___ Python tracker __

[issue33023] Unable to copy ssl.SSLContext

2018-10-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: After discussing on Python-Dev all error messages were changed to "cannot pickle 'XXX' object". https://mail.python.org/pipermail/python-dev/2018-October/155599.html I suggest to not add __getstate__() methods with different error messages. But the dup()

[issue35121] Cookie domain check returns incorrect results

2018-10-31 Thread 西田雄治
西田雄治 added the comment: I think that is desired result. thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue35121] Cookie domain check returns incorrect results

2018-10-31 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +9569 stage: -> patch review ___ Python tracker ___ ___ Pyt

[issue15809] 2.7 IDLE console uses incorrect encoding.

2018-10-31 Thread Pradyun Gedam
Change by Pradyun Gedam : -- nosy: -pradyunsg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue21314] Document '/' in signatures

2018-10-31 Thread Pradyun Gedam
Pradyun Gedam added the comment: We now have a PEP for this; just noting this here since I don't see a cross reference between them. https://www.python.org/dev/peps/pep-0570/ -- nosy: +pradyunsg ___ Python tracker

[issue35122] Process not exiting on unhandled exception when using multiprocessing module

2018-10-31 Thread akhi singhania
New submission from akhi singhania : I am not sure if this is an implementation bug or just a documentation bug. When using the multiprocessing module, I have come across a scenario where the process fails to exit when it throws an unhandled exception because it is waiting for the feeder thr

[issue35123] Add style guide for sentinel usage

2018-10-31 Thread Robert Wright
New submission from Robert Wright : Sentinel values are used inconsistently in the Python code base. It would be helpful to have a style guide (about eg. casing, placement, and sentinel reuse) to prevent arguments about their use in future code. -- messages: 328984 nosy: madman bob pr

[issue35121] Cookie domain check returns incorrect results

2018-10-31 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the confirmation. I have created a PR (https://github.com/python/cpython/pull/10258) with test and added 3.8 as affected version. Please add in if I have missed anything in the PR. -- versions: +Python 3.8 __

[issue35124] Add style guide for unit tests

2018-10-31 Thread Robert Wright
New submission from Robert Wright : There should be a style guide for tests, to prevent arguments about their use in future code. -- messages: 328986 nosy: madman bob priority: normal severity: normal status: open title: Add style guide for unit tests _

[issue35123] Add style guide for sentinel usage

2018-10-31 Thread Eric V. Smith
Eric V. Smith added the comment: Could you give some examples of problems caused by inconsistent usage of sentinels? I do often wish modules exposed their sentinel values, since it makes writing wrappers easier. It's one of the reasons I ended up exposing dataclasses.MISSING. -- no

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset b08746bfdf64e55ce33516f2065fa2aa4f51be95 by Xiang Zhang in branch 'master': bpo-35062: Fix parsing _io.IncrementalNewlineDecoder's *translate* argument. (GH-10217) https://github.com/python/cpython/commit/b08746bfdf64e55ce33516f2065fa2aa4f51be95

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +9571 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +9570 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +9573 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31354] Fixing a bug related to LTO only build

2018-10-31 Thread Charalampos Stratakis
Change by Charalampos Stratakis : -- pull_requests: +9572 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue35123] Add style guide for sentinel usage

2018-10-31 Thread Robert Wright
Robert Wright added the comment: Just the classic problems caused by inconsistency in code - confusion when reading, and disagreements when writing. For reading: Where should I look in a file for the sentinels? Is this value a sentinel, or is it some other type of variable? For writing, the

[issue25416] Add encoding aliases from the (HTML5) Encoding Standard

2018-10-31 Thread Ezio Melotti
Ezio Melotti added the comment: Adding those aliases sounds good to me. I think it would be good to add some tests first (possibly as a separate issue/pr), even though I'm not sure what would be the best way to test the aliases. Testing if the list is complete/correct should be done against

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread miss-islington
miss-islington added the comment: New changeset 907b07ee31a657914dafb0a6b7fa724be0f8d8ac by Miss Islington (bot) in branch '3.6': bpo-35062: Fix parsing _io.IncrementalNewlineDecoder's *translate* argument. (GH-10217) https://github.com/python/cpython/commit/907b07ee31a657914dafb0a6b7fa724be

[issue35121] Cookie domain check returns incorrect results

2018-10-31 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +martin.panter, orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread miss-islington
miss-islington added the comment: New changeset 71b6c1af727fbe13525fb734568057d78cea33f3 by Miss Islington (bot) in branch '3.7': bpo-35062: Fix parsing _io.IncrementalNewlineDecoder's *translate* argument. (GH-10217) https://github.com/python/cpython/commit/71b6c1af727fbe13525fb734568057d78

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread miss-islington
miss-islington added the comment: New changeset 05acd44ad6b61adb24571eb0203de7b25c7e869b by Miss Islington (bot) in branch '2.7': bpo-35062: Fix parsing _io.IncrementalNewlineDecoder's *translate* argument. (GH-10217) https://github.com/python/cpython/commit/05acd44ad6b61adb24571eb0203de7b25

[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-31 Thread Xiang Zhang
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue35119] Customizing module attribute access example raises RecursionError

2018-10-31 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report Denis. Would you like to propose a PR for this? The file is at https://github.com/python/cpython/blob/master/Doc/reference/datamodel.rst . This was added as part of 5364b5cd757. I am adding Ivan who added the example for confi

[issue19376] document that strptime() does not support the Feb 29 if the format does not contain the year

2018-10-31 Thread Tal Einat
Tal Einat added the comment: > I think for starters we should document the behavior of strptime when no > year, month or day are specified. As part of that documentation, we can add a > footnote about Feb 29th. This sounds good to me. We could also improve the exception raised in the specif

[issue35115] UUID objects can't be casted by `hex()`

2018-10-31 Thread fcurella
fcurella added the comment: I'm not sure what can be done to make UUIDs work with `hex()`. The only way I see is to add back something _like_ `__hex__`, but with a different name. But in that case, I can see how the same arguments that were originally brought up against `__hex__` could apply

[issue35125] asyncio shield: remove inner callback on outer cancellation

2018-10-31 Thread mainro
New submission from mainro : When the future returned by shield is cancelled, its completion callback of the inner future is not removed. This makes the callback list of inner inner future grow each time a shield is created. -- components: asyncio files: shield_cancel.patch keywords:

[issue35033] Column or row spanning cells are not implemented.

2018-10-31 Thread Julien Palard
Julien Palard added the comment: https://github.com/sphinx-doc/sphinx/pull/5559 has been merged, let's wait for a release of Sphinx and we'll be able to build Python 3.8 documentation as text again. -- ___ Python tracker

[issue35119] Customizing module attribute access example raises RecursionError

2018-10-31 Thread Ronald Oussoren
Ronald Oussoren added the comment: I'm not convinced that any change is needed, this is completely expected behaviour (and not special to modules). The following code also raises RecursionError: class VerboseObject: def __setattr__(self, nm, value): print(f"Setting {nm} to {value

[issue35126] Mistake in FAQ about converting number to string.

2018-10-31 Thread Pawel
New submission from Pawel : In this question: https://docs.python.org/2.7/faq/programming.html#how-do-i-convert-a-number-to-a-string There is a statement: "{:.3f}".format(1/3) yields '0.333' While In [2]: "{:.3f}".format(1/3) Out[2]: '0.000' In [3]: "{:.3f}".format(1/3.0) Out[3]: '0.333' --

[issue31625] stop using ranlib

2018-10-31 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Would it make sense to backport that to 3.6 as well? Currently this blocks https://bugs.python.org/issue28015 from being backported to 3.6 -- nosy: +cstratak ___ Python tracker

[issue28015] configure --with-lto builds fail when CC=clang on Linux, requires gold linker

2018-10-31 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: The issue with the 3.6 branch is https://bugs.python.org/issue31625 which hasn't been backported to 3.6. Would it make sense to backport it? I have the backports ready locally but not sure if pushing https://bugs.python.org/issue31625 to 3.6 is desira

[issue35111] Make Custom Object Classes JSON Serializable

2018-10-31 Thread andrew c
andrew c added the comment: Bob, I understand what you are saying, but having a built-in is way easier than encoder/decoders. You can still have both actually. Even if you didn't have two way, a one way would be amazingly helpful. For large development systems, a __json__ method would ma

[issue35111] Make Custom Object Classes JSON Serializable

2018-10-31 Thread Bob Ippolito
Bob Ippolito added the comment: That's what the for_json method is in simplejson, it does not have widespread usage. You can implement that when encoding: ``` def json_default(obj): try: return obj.__json__() except AttributeError: raise TypeError("{} can not be JSON

[issue35127] pyurandom() fails if user does not have an entropy device

2018-10-31 Thread Gyff Mjord
New submission from Gyff Mjord : Because of [reasons], I installed a FreeBSD and recompiled it to provide a minimalist kernel. Thus, it does not have the entropy devices /dev/urandom and /dev/random It is a FreeBSD-10-0 running in a Hyper-V virutalization platform. I kinda recompiled python-

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset 2be00d987d37682a55db67c298e82c405d01b868 by Victor Stinner in branch 'master': bpo-35081: Move Py_BUILD_CORE code to internal/mem.h (GH-10249) https://github.com/python/cpython/commit/2be00d987d37682a55db67c298e82c405d01b868 -- __

[issue35123] Add style guide for sentinel usage

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: Context: https://github.com/python/cpython/pull/8548#pullrequestreview-166711603 -- nosy: +vstinner ___ Python tracker ___ __

[issue35124] Add style guide for unit tests

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: Context: https://github.com/python/cpython/pull/8548#pullrequestreview-166712031 -- nosy: +vstinner ___ Python tracker ___ __

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9574 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: > Include/internal/pystate.h uses #include "pystate.h" to include > Include/pystate.h, but it tries to include itself > (Include/internal/pystate.h) which does nothing because of "#ifndef > Py_INTERNAL_PYSTATE_H #define Py_INTERNAL_PYSTATE_H ... #endif". I

[issue35127] pyurandom() fails if user does not have an entropy device

2018-10-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35113] inspect.getsource returns incorrect source for classes when class definition is part of multiline strings

2018-10-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue30410] Documentation for sys.stdout encoding does not reflect the new Windows behavior in Python 3.6+

2018-10-31 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +9575 stage: -> patch review ___ Python tracker ___ ___ Python-bu

[issue34965] Python on Docker container using flask is going down after sometime

2018-10-31 Thread Windson Yang
Windson Yang added the comment: Hello, Srikanth, I think you have to look through the docker documents like https://docs.docker.com/config/containers/logging/ -- ___ Python tracker _

[issue24916] In sysconfig, don't rely on sys.version format

2018-10-31 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I'm working on changing _PY_VERSION to get its value from sys.version_info instead of sys.version, but I am not sure what the best way is to map between a release stage to the corresponding letter(release->rc). Could someone help me a tiny bit with this

[issue25416] Add encoding aliases from the (HTML5) Encoding Standard

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue35122] Process not exiting on unhandled exception when using multiprocessing module

2018-10-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Unless I don't understand the issue correctly, this is documented here: https://docs.python.org/3/library/multiprocessing.html#multiprocessing-programming Bear in mind that a process that has put items in a queue will wait before terminating until all

[issue35118] Add peek() or first() method in queue

2018-10-31 Thread Windson Yang
Change by Windson Yang : -- keywords: +patch pull_requests: +9576 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue34965] Python on Docker container using flask is going down after sometime

2018-10-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: What version of Python are you using? There is very few things we can do on out side if you don't provide some reproducer or some evidence that CPython is the source of this problem and not your application code or a third party module. Could you tr

[issue34912] Update overflow checks in resize_buffer

2018-10-31 Thread Windson Yang
Windson Yang added the comment: Sorry, Stefan Behnel, I still don't get it. alloc will always bigger than size after the if else case: if (size < alloc / 2) { /* Major downsize; resize down to exact size. */ alloc = size + 1; } else if (size < alloc) { /*

[issue35105] Document that CPython accepts "invalid" identifiers

2018-10-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35126] Mistake in FAQ about converting number to string.

2018-10-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Yep, this is incorrect in Python 2 unless `from __future__ import division` is imported at the beginning. Would you want to make a PR against the 2.7 branch to correct this? -- nosy: +pablogsal ___ Python t

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9577 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue26558] Disable PyGILState_Check() when Py_NewInterpreter() is called and add more checks on the GIL

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9578 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35128] warning.warn messages with spacing issues

2018-10-31 Thread Pablo Santiago Blum de Aguiar
New submission from Pablo Santiago Blum de Aguiar : Some warn messages miss space between words, such as: Use of 'buffering' argument is deprecated and ignoredsince Python 3.0. in bz2 library, and: keyfile and certfile are deprecated, use acustom context instead in many libraries, such as p

[issue35128] warning.warn messages with spacing issues

2018-10-31 Thread Pablo Santiago Blum de Aguiar
Pablo Santiago Blum de Aguiar added the comment: Sorry, only when creating the PR I read that trivial changes like this need no issue. -- stage: -> resolved status: open -> closed ___ Python tracker _

[issue35129] Different behaviour comparing versions (distutils.version.LooseVersion) between python2.7 and python3.x

2018-10-31 Thread davide moro
New submission from davide moro : I noticed that with the python2.7 version of distutils.version.LooseVersion let you compare '7' with 'xp' without exceptions (e.g., LooseVersion('7') > LooseVersion('xp')). If you do the same with python3.6 or python3.7, you'll get the following exception:

[issue35119] Customizing module attribute access example raises RecursionError

2018-10-31 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Yes, this is expected, you should use ``super().__setattr__()``. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue35129] Different behaviour comparing versions (distutils.version.LooseVersion) between python2.7 and python3.x

2018-10-31 Thread Steven D'Aprano
Steven D'Aprano added the comment: There is no need to split the relevant code into a third-party website, especially when it is so small and can be included in-line here. Python 2.7: py> import distutils.version py> distutils.version.LooseVersion('7') > distutils.version.LooseVersion('XP')

[issue35123] Add style guide for sentinel usage

2018-10-31 Thread Steven D'Aprano
Steven D'Aprano added the comment: I was not aware that there currently were arguments about the use of sentinels in future code. I feel that you are being excessively prescriptive here: "we should nip it in the bud" is good advice for gardening, but for programming it just results in a lot

[issue35124] Add style guide for unit tests

2018-10-31 Thread Steven D'Aprano
Steven D'Aprano added the comment: I think this is being excessively prescriptive and solving a problem that isn't a problem. But perhaps if you start by proposing a concrete style guide, I can judge better. -- nosy: +steven.daprano ___ Python tr

[issue26558] Disable PyGILState_Check() when Py_NewInterpreter() is called and add more checks on the GIL

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3a228ab17c2a9cffd1a2f15f30d6209768de20a6 by Victor Stinner in branch 'master': bpo-26558: Fix Py_FatalError() with GIL released (GH-10267) https://github.com/python/cpython/commit/3a228ab17c2a9cffd1a2f15f30d6209768de20a6 -- __

[issue26558] Disable PyGILState_Check() when Py_NewInterpreter() is called and add more checks on the GIL

2018-10-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +9579 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue26558] Disable PyGILState_Check() when Py_NewInterpreter() is called and add more checks on the GIL

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9580 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35123] Add style guide for sentinel usage

2018-10-31 Thread Eric V. Smith
Eric V. Smith added the comment: I don't see any problems that need solving. My only interest in this is that I tend to think sentinels that are used for missing parameters should be exposed, and this isn't always an obvious consideration when designing an API. For example, say there's a li

[issue26558] Disable PyGILState_Check() when Py_NewInterpreter() is called and add more checks on the GIL

2018-10-31 Thread miss-islington
miss-islington added the comment: New changeset 192c54713b4c67a8d14b2d98056771feba40ca37 by Miss Islington (bot) in branch '3.7': bpo-26558: Fix Py_FatalError() with GIL released (GH-10267) https://github.com/python/cpython/commit/192c54713b4c67a8d14b2d98056771feba40ca37 -- nosy: +m

[issue26558] Disable PyGILState_Check() when Py_NewInterpreter() is called and add more checks on the GIL

2018-10-31 Thread Eric Snow
Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread Eric Snow
Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

2018-10-31 Thread Eric Snow
Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset 27e2d1f21975dfb8c0ddcb192fa0f45a51b7977e by Victor Stinner in branch 'master': bpo-35081: Add pycore_ prefix to internal header files (GH-10263) https://github.com/python/cpython/commit/27e2d1f21975dfb8c0ddcb192fa0f45a51b7977e --

[issue35129] Different behaviour comparing versions (distutils.version.LooseVersion) between python2.7 and python3.x

2018-10-31 Thread Éric Araujo
Éric Araujo added the comment: Please discuss on #14894 -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> distutils.LooseVersion fails to compare number and a word ___ Python tracker

[issue35128] warning.warn messages with spacing issues

2018-10-31 Thread Pablo Santiago Blum de Aguiar
Change by Pablo Santiago Blum de Aguiar : -- pull_requests: +9581 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue26558] Disable PyGILState_Check() when Py_NewInterpreter() is called and add more checks on the GIL

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset ff56597151206a03ce421712516323430b7749c8 by Victor Stinner in branch '3.6': bpo-26558: Fix Py_FatalError() with GIL released (GH-10267) (GH-10270) https://github.com/python/cpython/commit/ff56597151206a03ce421712516323430b7749c8 -- __

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset 50b48572d9a90c5bb36e2bef6179548ea927a35a by Victor Stinner in branch 'master': bpo-35081: Add _PyThreadState_GET() internal macro (GH-10266) https://github.com/python/cpython/commit/50b48572d9a90c5bb36e2bef6179548ea927a35a --

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9582 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9583 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset e281f7d80ce2584a7e6a36acffb5a9cd796a0fe2 by Victor Stinner in branch 'master': bpo-35081: Move accu.h to Include/internal/pycore_accu.h (GH-10271) https://github.com/python/cpython/commit/e281f7d80ce2584a7e6a36acffb5a9cd796a0fe2 -- __

[issue35081] Rename Include/internals/ to Include/pycore/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: Copy of my comment on PR 10271: https://github.com/python/cpython/pull/10271#issuecomment-434897408 I tried to enforce to require Py_BUILD_CORE in pycore_accu.h to be defined using: #ifndef Py_BUILD_CORE # error "Py_BUILD_CORE must be defined to include thi

[issue35081] Move internal headers to Include/internal/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- title: Rename Include/internals/ to Include/pycore/ -> Move internal headers to Include/internal/ ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9584 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue32804] urllib.retrieve documentation doesn't mention context parameter

2018-10-31 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset aa39c1ab6de6d3fb0204741efdde9b7eed25b093 by Xiang Zhang (Lysandros Nikolaou) in branch '2.7': [2.7] bpo-32804: Include the context parameter in urlretrieve documentation (GH-10203) https://github.com/python/cpython/commit/aa39c1ab6de6d3fb0204741ef

[issue32804] urllib.retrieve documentation doesn't mention context parameter

2018-10-31 Thread Xiang Zhang
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue35101] inspect.findsource breaks on class frame objects

2018-10-31 Thread orlnub123
orlnub123 added the comment: Added the requested test cases. They aren't an exact match but they should serve the same purpose. -- ___ Python tracker ___

[issue35105] Document that CPython accepts "invalid" identifiers

2018-10-31 Thread orlnub123
orlnub123 added the comment: I'd argue that it's an implementation detail. Documenting it might be nice as some projects such as pytest do use it but I don't think it would make sense in setattr() or getattr() since all they do (at least in this case) is assign/retrieve from the __dict__. On

[issue35081] Move internal headers to Include/internal/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: New changeset a1c249c40517917d2e0971d55aea8d14a44b2cc8 by Victor Stinner in branch 'master': bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273) https://github.com/python/cpython/commit/a1c249c40517917d2e0971d55aea8d14a44b2cc8 -- _

[issue35081] Move internal headers to Include/internal/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9585 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35120] SSH tunnel support to ftp lib

2018-10-31 Thread Windson Yang
Windson Yang added the comment: Hello, Mohit Sharma. Would you mind adding more details about the bug? -- nosy: +Windson Yang ___ Python tracker ___ __

[issue35081] Move internal headers to Include/internal/

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: > bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273) I tried to add the Py_BUILD_CORE guard in pycore_pathconfig.h: +#ifndef Py_BUILD_CORE +# error "Py_BUILD_CORE must be defined to include this header" +#endif But it breaks the compilatio

[issue35081] Move internal headers to Include/internal/

2018-10-31 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9586 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35105] Document that CPython accepts "invalid" identifiers

2018-10-31 Thread STINNER Victor
STINNER Victor added the comment: > I'd argue that it's an implementation detail. Documenting it might be nice as > some projects such as pytest do use it but I don't think it would make sense > in setattr() or getattr() since all they do (at least in this case) is > assign/retrieve from the

[issue35105] Document that CPython accepts "invalid" identifiers

2018-10-31 Thread Windson Yang
Windson Yang added the comment: I agreed we should document it, it' not obvious to me at least. -- nosy: +Windson Yang ___ Python tracker ___ _

  1   2   >