[issue33597] Compact PyGC_Head

2018-05-22 Thread INADA Naoki
New submission from INADA Naoki : Currently, PyGC_Head takes three words; gc_prev, gc_next, and gc_refcnt. gc_refcnt is used when collecting, for trial deletion. gc_prev is used for tracking and untracking. So if we can avoid tracking/untracking while trial deletion, gc_prev and gc_refcnt can

[issue33597] Compact PyGC_Head

2018-05-22 Thread INADA Naoki
Change by INADA Naoki : -- keywords: +patch pull_requests: +6682 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33596] fix memory leak in lib/json/scanner.py py_make_scanner

2018-05-22 Thread yzongyue
Change by yzongyue : -- keywords: +patch pull_requests: +6683 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue5945] PyMapping_Check returns 1 for lists

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset f5b1183610d5888db3bbd639b1a0c945dbd8f8dd by Serhiy Storchaka in branch 'master': bpo-5945: Improve mappings and sequences C API docs. (GH-7029) https://github.com/python/cpython/commit/f5b1183610d5888db3bbd639b1a0c945dbd8f8dd --

[issue5945] PyMapping_Check returns 1 for lists

2018-05-22 Thread miss-islington
Change by miss-islington : -- pull_requests: +6684 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue5945] PyMapping_Check returns 1 for lists

2018-05-22 Thread miss-islington
miss-islington added the comment: New changeset e1a78cacf65f007b1000966ce3aac6ac2eaa5cfc by Miss Islington (bot) in branch '3.7': bpo-5945: Improve mappings and sequences C API docs. (GH-7029) https://github.com/python/cpython/commit/e1a78cacf65f007b1000966ce3aac6ac2eaa5cfc -- nosy:

[issue33598] ActiveState Recipes links in docs, and the apparent closure of Recipes

2018-05-22 Thread Alex Walters
New submission from Alex Walters : ActiveState has stopped accepting new recipes on their website, and migrated all current recipes to a Github repo. I have seen no official announcement of a shutdown date for the code.activestate.com website, but it's future has to be in question considering

[issue33599] Copying objects subclassed from SimpleNamespace doesn't work

2018-05-22 Thread Sascha
New submission from Sascha : Try from types import SimpleNamespace import copy class Person(SimpleNamespace): def __init__(self, name, **kwargs): self.name = name super().__init__(**kwargs) bob = Person('Bob', job='tester') clone = copy.copy(bob) For me this results in Typ

[issue30877] possibe typo in json/scanner.py

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry for not fixing this issue earlier. The fix is trivial, but it needed tests. PR 7048 adds a simpler test. -- versions: +Python 3.8 -Python 3.5 ___ Python tracker

[issue30877] possibe typo in json/scanner.py

2018-05-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +6685 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue33596] fix memory leak in lib/json/scanner.py py_make_scanner

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your report and pull request, but it is a duplicate of issue30877. This bug was not fixed before because we wanted a test. -- nosy: +serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed supersede

[issue33599] Copying objects subclassed from SimpleNamespace doesn't work

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Right, this is because your subclass is not completely compatible with SimpleNamespace. The SimpleNamespace constructor accepts only keyword arguments, but your class requires a positional argument. You have to implement the __copy__ method for supporting s

[issue5945] PyMapping_Check returns 1 for lists

2018-05-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +6686 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33597] Compact PyGC_Head

2018-05-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue5945] PyMapping_Check returns 1 for lists

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 93e9fb5664e56c02c9aa89098b556929735b35db by Serhiy Storchaka in branch '3.6': [3.6] bpo-5945: Improve mappings and sequences C API docs. (GH-7029). (GH-7049) https://github.com/python/cpython/commit/93e9fb5664e56c02c9aa89098b556929735b35db --

[issue30877] possibe typo in json/scanner.py

2018-05-22 Thread miss-islington
Change by miss-islington : -- pull_requests: +6687 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30877] possibe typo in json/scanner.py

2018-05-22 Thread miss-islington
Change by miss-islington : -- pull_requests: +6688 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue33580] Make binary/text file glossary entries follow most common "see also" style

2018-05-22 Thread Andrés Delfino
Andrés Delfino added the comment: This one can be closed, right? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue33580] Make binary/text file glossary entries follow most common "see also" style

2018-05-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue33531] test_asyncio: test_subprocess test_stdin_broken_pipe() failure on Travis CI

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > Fixed failed sendfile tests on Windows (at least I hope so). I guess that Andrew means the following fix: commit e2537521916c5bf88fcf54d4654ff1bcd332be4a Author: Andrew Svetlov Date: Mon May 21 12:03:45 2018 +0300 Fix asyncio flaky tests (#7023) ---

[issue29640] _PyThreadState_Init and fork race leads to inconsistent key list

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > the old TLS API is only available if PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT. PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT is defined on most (pthread) platforms, no? I understood that the PEP 539 is mostly designed for Cygwin, a platform which is not officially suppo

[issue30877] possibe typo in json/scanner.py

2018-05-22 Thread miss-islington
miss-islington added the comment: New changeset 25fd6cc5b0ad311bb771ae47ae8173417730bb6a by Miss Islington (bot) in branch '3.7': bpo-30877: Fix clearing a cache in the the JSON decoder. (GH-7048) https://github.com/python/cpython/commit/25fd6cc5b0ad311bb771ae47ae8173417730bb6a -- no

[issue33600] [EASY DOC] Python 2: document that platform.linux_distribution() has been removed

2018-05-22 Thread STINNER Victor
New submission from STINNER Victor : The platform.linux_distribution() function has been removed from the future Python 3.8. The removal should be documented in Python 2.7 documentation, and mention the alternative. Python 2 documenation: https://docs.python.org/2/library/platform.html#platfor

[issue33600] [EASY DOC] Python 2: document that platform.linux_distribution() has been removed

2018-05-22 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue29640] _PyThreadState_Init and fork race leads to inconsistent key list

2018-05-22 Thread Petr Viktorin
Petr Viktorin added the comment: > PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT is defined on most (pthread) platforms, > no? > I propose to cast pthread_key_create() result to int, but only define > PyThread_create_key() in Python/thread_pthread.h if > PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT is define

[issue30877] possibe typo in json/scanner.py

2018-05-22 Thread miss-islington
miss-islington added the comment: New changeset 2baee0aa77055755ac50e92e64bbccfea4108621 by Miss Islington (bot) in branch '3.6': bpo-30877: Fix clearing a cache in the the JSON decoder. (GH-7048) https://github.com/python/cpython/commit/2baee0aa77055755ac50e92e64bbccfea4108621 -- _

[issue20941] pytime.c:184 and pytime.c:218: runtime error, outside the range of representable values of type 'long'

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: I close the issue as a duplicate of bpo-31373. Reopen/comment bpo-31373 if the issue is not completely fixed. -- resolution: out of date -> duplicate stage: -> resolved status: open -> closed ___ Python tracker

[issue28240] Enhance the timeit module: display average +- std dev instead of minimum

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > Wait, I didn't notice the change to the format of raw timings. It looks as a > regression to me. Do you mean that some applications may run timeit as a CLI and parse stdout to get raw values? Why doing so? timeit is a Python module, it's trivial to use its

[issue33518] Add PEP to glossary

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8cbde8a43769641373a681af4b0d72944af43f95 by Victor Stinner (Andrés Delfino) in branch '2.7': [2.7] bpo-33518: Add PEP entry to documentation glossary (GH-6860). (#6936) https://github.com/python/cpython/commit/8cbde8a43769641373a681af4b0d72944af4

[issue33518] Add PEP to glossary

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: Thank you Andrés Delfino. I applied your PR to 2.7, 3.6, 3.7 and master. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue33521] Add 1.32x faster C implementation of asyncio.isfuture().

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > @pitrou We'll measure the wins of gather when we implement it in C. Before > that, we need to get all helpers ready in C. You don't have to provide _asyncio.isfuture() (in C) to implement gather() in C. If your goal is to optimize gather(), write a change t

[issue28167] remove platform.linux_distribution()

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: FYI I created bpo-33600: "[EASY DOC] Python 2: document that platform.linux_distribution() has been removed". -- ___ Python tracker ___ _

[issue23860] Windows: Failure to check return value from lseek() in Modules/mmapmodule.c

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: "At the moment, I'm not sure if it's needed or not, but if it's only an issue with XP, then it might not be worth fixing...:)" If the workaround is no longer needed, the lseek() call should be removed. -- components: +Windows nosy: +paul.moore, steve.d

[issue23860] Windows: Failure to check return value from lseek() in Modules/mmapmodule.c

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: Oh right, PR 7017 does that: it removes the lseek() call ;-) -- ___ Python tracker ___ ___ Python-

[issue33601] Py_UTF8Mode is not documented

2018-05-22 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Py_UTF8Mode was added to the limited API in 3.7, but it is not documented anywhere. -- assignee: docs@python components: Documentation messages: 317286 nosy: docs@python, ncoghlan, serhiy.storchaka, vstinner priority: normal severity: normal status

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > Also, the actual removal of the "modules" field was reverted. Oh... I didn't understand that part :-) Ok. In this case it's fine to close this documentation issue. Nothing should be documented for 3.7 ;-) -- ___

[issue33197] Confusing error message when constructing invalid inspect.Parameters

2018-05-22 Thread Dong-hee Na
Dong-hee Na added the comment: Can I get a code review for PR 6636? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue33565] strange tracemalloc results

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: A memory leak is when each iteration adds a fixed number of bytes of the memory: I'm talking about tracemalloc.get_traced_memory()[0] value. For example, if you compare the total traced memory between your iteration 30 and iteration 20, you get a value 10N. I

[issue28240] Enhance the timeit module: display average +- std dev instead of minimum

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, it was my thought. But seems you are right, it is easier to use Python as a programming language. In the past I used the CLI because the programming interface didn't supported autoranging. Although I would change the human-readable output to raw times

[issue29640] _PyThreadState_Init and fork race leads to inconsistent key list

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > But! I suppose we could fix the bug only for platforms with > PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT. Yes, this is my proposal. >> I propose to cast pthread_key_create() result to int, but only define >> PyThread_create_key() in Python/thread_pthread.h if >

[issue33601] [EASY DOC] Py_UTF8Mode is not documented

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: I wasn't sure if I should document it, but after talking with Serhiy on IRC, I now agree that the new variable should be documented. It should be documented at: https://docs.python.org/dev/c-api/init.html#global-configuration-variables -- keywords: +e

[issue33602] Remove set and queue references from Data Types

2018-05-22 Thread Andrés Delfino
New submission from Andrés Delfino : Data Types mentions sets (which are now built-in) and synchronized queues (now mentioned in Concurrent Execution). I'm proposing fixing this. PR also adds mention to bytearray. -- assignee: docs@python components: Documentation messages: 317293 nosy

[issue33602] Remove set and queue references from Data Types

2018-05-22 Thread Andrés Delfino
Change by Andrés Delfino : -- keywords: +patch pull_requests: +6689 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue33601] [EASY DOC] Py_UTF8Mode is not documented

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If there are reasons of including it in the limited API, it should be documented. -- ___ Python tracker ___ ___

[issue33597] Compact PyGC_Head

2018-05-22 Thread INADA Naoki
INADA Naoki added the comment: $ ./python -m perf compare_to master.json twogc.json -G --min-speed=2 Slower (3): - scimark_monte_carlo: 268 ms +- 9 ms -> 278 ms +- 8 ms: 1.04x slower (+4%) - fannkuch: 1.03 sec +- 0.02 sec -> 1.06 sec +- 0.02 sec: 1.03x slower (+3%) - spectral_norm: 285 ms +- 9

[issue33238] AssertionError on await of Future returned by asyncio.wrap_future

2018-05-22 Thread Jason Haydaman
Change by Jason Haydaman : -- keywords: +patch pull_requests: +6690 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue33603] Subprocess Thread handles grow with each call and aren't released until script ends

2018-05-22 Thread GranPrego
New submission from GranPrego : On windows 7 / 10 I'm using subprocess to launch a dos cmdline executable and returning the results, which is all working fine. However, each time I make a call, the Python handle count is gradually increasing, jumping up , back a few, then jumping up and so on.

[issue33597] Compact PyGC_Head

2018-05-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: Interesting. Do you have any comparisons on memory footprint too? -- ___ Python tracker ___ ___ P

[issue33597] Compact PyGC_Head

2018-05-22 Thread INADA Naoki
INADA Naoki added the comment: $ ./python-gc -c 'import asyncio,sys; sys._debugmallocstats()' master: # bytes in allocated blocks=4,011,368 # bytes in available blocks= 136,640 50 unused pools * 4096 bytes = 204,800 # bytes lost to po

[issue33597] Compact PyGC_Head

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is an interesting idea. The other problem with the garbage collecting is that it modifies the memory of all collectable objects. This leads to deduplicating virtually all memory blocks after the fork, even if these objects are not used in the child. I

[issue2504] Add gettext.pgettext() and variants support

2018-05-22 Thread Éric Araujo
Éric Araujo added the comment: It was an answer to «Is there anything I can do to help get this into the codebase» Feel free to take this on! I’ll try to review. -- ___ Python tracker __

[issue30877] possibe typo in json/scanner.py

2018-05-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue33597] Compact PyGC_Head

2018-05-22 Thread INADA Naoki
INADA Naoki added the comment: @Serhiy php implemented similar idea recently. https://react-etc.net/entry/improvements-to-garbage-collection-gc-php-7-3-boosts-performance-in-benchmark In short, each tracked object have only "index" of GC struct, not "pointer". GC struct is in array and it can

[issue33597] Compact PyGC_Head

2018-05-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 22/05/2018 à 17:31, INADA Naoki a écrit : > > INADA Naoki added the comment: > > $ ./python-gc -c 'import asyncio,sys; sys._debugmallocstats()' Thanks. You can also collect peak memory stats during the benchmark suite, though the numbers may be approxima

[issue33593] Support heapq on typed arrays?

2018-05-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: I don't think we should go down this path. The efficiency of the C implementation depends on it being tightly coupled to lists. This tool is used in the schedulers of various async tools (such as Tornando), used for merge(), nsmallest(), and nlargest() a

[issue33590] sched.enter priority has no impact on execution

2018-05-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: It would be nice to either modify the example or add another example to show the use of enterabs() and of the priority field being used as a tie breaker for two events scheduled at the same time. -- nosy: +rhettinger status: pending -> open __

[issue33565] strange tracemalloc results

2018-05-22 Thread Alexander Mohr
Alexander Mohr added the comment: I believe your method is flawed, when enabling tracemalloc it's going to be using memory as well to store the traces. I still believe you need to use the method I mentioned and further even if we don't take into account the total memory the traces I mentione

[issue33597] Compact PyGC_Head

2018-05-22 Thread INADA Naoki
INADA Naoki added the comment: In Doc folder: make clean make PYTHON=../python venv /usr/bin/time make html master: 113.15user 0.41system 1:55.46elapsed 98%CPU (0avgtext+0avgdata 205472maxresident)k 18800inputs+223544outputs (1major+66066minor)pagefaults 0swaps 111.07user 0.44sy

[issue23188] Provide a C helper function to chain raised (but not yet caught) exceptions

2018-05-22 Thread Eric Snow
Eric Snow added the comment: FTR, see PEP 490 ("Chain exceptions at C level") which proposed implicitly chaining exceptions in the PyErr_* API. While that PEP was rejected (not all exceptions should be chained), it does make a good point about the clunkiness of using _PyErr_ChainExceptions():

[issue33565] strange tracemalloc results

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: Oh. Usually, I strip traces allocated by tracemalloc using filters: http://pytracemalloc.readthedocs.io/examples.html#pretty-top snapshot = snapshot.filter_traces(( tracemalloc.Filter(False, ""), tracemalloc.Filter(False, ""), )) -

[issue33565] strange tracemalloc results

2018-05-22 Thread Alexander Mohr
Alexander Mohr added the comment: that's not going to affect http://pytracemalloc.readthedocs.io/api.html#get_traced_memory. There is no filter for that :) as to your sum that's exactly what my original callstack lists: 21 memory blocks: 4.7 KiB this means 21 blocks were not released, and i

[issue33592] Document contextvars C API

2018-05-22 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset b2f5f59ae15564b991f3ca4850e6ad28d9faacbc by Yury Selivanov (Elvis Pranskevichus) in branch 'master': bpo-33592: Document the C API in PEP 567 (contextvars) (GH-7033) https://github.com/python/cpython/commit/b2f5f59ae15564b991f3ca4850e6ad28d9faacb

[issue33592] Document contextvars C API

2018-05-22 Thread miss-islington
Change by miss-islington : -- pull_requests: +6691 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue33593] Support heapq on typed arrays?

2018-05-22 Thread Diego Argueta
Diego Argueta added the comment: I was referring to the C arrays in the Python standard library: https://docs.python.org/3/library/array.html -- ___ Python tracker ___ ___

[issue33603] Subprocess Thread handles grow with each call and aren't released until script ends

2018-05-22 Thread Eryk Sun
Eryk Sun added the comment: The thread handle that CreateProcess returns gets immediately closed in Popen._execute_child, so I can't see how this is due to subprocess. Please check to make sure these thread handles aren't for threads in your own process. Set the lower pane of Process Explorer

[issue33597] Compact PyGC_Head

2018-05-22 Thread Yury Selivanov
Yury Selivanov added the comment: This is such a great idea. +1 from me. -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs

[issue23188] Provide a C helper function to chain raised (but not yet caught) exceptions

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is usually more complex code between PyErr_Fetch() and _PyErr_ChainExceptions(): PyObject *exc, *val, *tb, *close_result; PyErr_Fetch(&exc, &val, &tb); close_result = _PyObject_CallMethodId(result, &PyId_close, NULL); _P

[issue33593] Support heapq on typed arrays?

2018-05-22 Thread Diego Argueta
Diego Argueta added the comment: However I do see your point about the speed. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue33592] Document contextvars C API

2018-05-22 Thread miss-islington
miss-islington added the comment: New changeset afec2d583a06849c5080c6cd40266743c8e04b3e by Miss Islington (bot) in branch '3.7': bpo-33592: Document the C API in PEP 567 (contextvars) (GH-7033) https://github.com/python/cpython/commit/afec2d583a06849c5080c6cd40266743c8e04b3e -- nosy

[issue33603] Subprocess Thread handles grow with each call and aren't released until script ends

2018-05-22 Thread Antoine Pitrou
Change by Antoine Pitrou : -- nosy: +giampaolo.rodola, gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue33593] Support heapq on typed arrays?

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Workaround: alist = list(a) heapq.heapify(alist) a[:] = alist And it should be not much slower than using heapq.heapify() directly if it could support general sequences. Using it with array.array would add significant overhead due to boxing. -- no

[issue33603] Subprocess Thread handles grow with each call and aren't released until script ends

2018-05-22 Thread GranPrego
GranPrego added the comment: Process explorer is showing the handles as belonging to the python executable. I can see the cmd process start,then the executable which terminates cleanly. I can see thread handles appearing under the python process, with some terminating, but more green than re

[issue30940] Documentation for round() is incorrect.

2018-05-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

2018-05-22 Thread Ned Deily
Ned Deily added the comment: > Considering the huge popularity of these SO questions, I don't think this > should be reverted [...] As I understand it (and, again, I make no claim to be an argparse expert), there does not seem to be one absolutely correct answer here; there has to be a trade

[issue33531] test_asyncio: test_subprocess test_stdin_broken_pipe() failure on Travis CI

2018-05-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: The patch seems to have worked. The last AppVeyor failure was a day ago, when testing the 3.7 backport of the fix. https://ci.appveyor.com/project/python/cpython/history -- ___ Python tracker

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

2018-05-22 Thread Anthony Sottile
Anthony Sottile added the comment: Is there then no pathway for actually fixing the bug? aka how can I get `required=True` to be the default. -- ___ Python tracker ___ __

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2018-05-22 Thread Matthias Bussonnier
New submission from Matthias Bussonnier : HMAC docs says digestmod=md5 default will be removed in 3.6, but was not. We should likely bumpt that to 3.8 in the documentation, and actually remove it in 3.8 -- messages: 317322 nosy: mbussonn priority: normal severity: normal status: open

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2018-05-22 Thread Matthias Bussonnier
Change by Matthias Bussonnier : -- keywords: +patch pull_requests: +6692 stage: -> patch review ___ Python tracker ___ ___ Python-bu

[issue33603] Subprocess Thread handles grow with each call and aren't released until script ends

2018-05-22 Thread Eryk Sun
Eryk Sun added the comment: The 2nd example with subprocess.run() creates two threads in the Python process, since you're redirecting both stdout and stderr to pipes and run() calls communicate(). The first example with subprocess.Popen() shouldn't create any threads. In either case, nothing

[issue33605] Detect accessing event loop from a different thread outside of _debug

2018-05-22 Thread Hrvoje Nikšić
New submission from Hrvoje Nikšić : Looking at StackOverflow's python-asyncio tag[1], it appears that it's a very common mistake for users to invoke asyncio functions or methods from a thread other than the event loop thread. In some cases this happens because the user is careless with threads

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I tried to use add_subparsers() with required=True and have found it not usable. import argparse parser = argparse.ArgumentParser(prog='PROG') subparsers = parser.add_subparsers(required=True) parser_a = subparsers.add_parser('a') parser_b = subparsers.add_pa

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

2018-05-22 Thread Anthony Sottile
Anthony Sottile added the comment: That's a separate issue (also a bug introduced by the bad 3.3 patch): https://bugs.python.org/issue29298 I have an open PR to fix it as well but it has not seen review action: https://github.com/python/cpython/pull/3680 -- _

[issue33593] Support heapq on typed arrays?

2018-05-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: As noted by Serhiy, the interaction with the Array type would incur significant overhead. Your fastest approach will be to follow his suggest to first convert to a list and then perform heap manipulations. Marking this as closed. Thank you for the sugges

[issue33603] Subprocess Thread handles grow with each call and aren't released [Windows]

2018-05-22 Thread Gregory P. Smith
Change by Gregory P. Smith : -- title: Subprocess Thread handles grow with each call and aren't released until script ends -> Subprocess Thread handles grow with each call and aren't released [Windows] ___ Python tracker

[issue33606] Improve logging performance when logger disabled

2018-05-22 Thread Vinay Sajip
New submission from Vinay Sajip : If a logger is disabled (by setting it's disabled attribute to True), the check for this is done late in the dispatch of the logging event - during the handle() call - rather than isEnabledFor(), which would short-circuit some processing. So the check for logg

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Wouldn't be better to first fix this bug, and only after that add the 'required' parameter? Adding it introduced yet one bug: when pass arguments as positional, the 'help' argument will be swallowed. You can add new parameters only after existing positiona

[issue33607] Explicitly track object ownership (and allocator).

2018-05-22 Thread Eric Snow
New submission from Eric Snow : When an object is created it happens relative to the current thread (ergo interpreter) and the current allocator (part of global state). We do not track either of these details for the object. It may make sense to start doing so (reasons next). Regarding trackin

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

2018-05-22 Thread Anthony Sottile
Anthony Sottile added the comment: The bug is orthogonal, you can trigger it without the `required=` keyword argument via the (currently suggested) monkeypatch workaround which restores the pre-3.3 behaviour: import argparse parser = argparse.ArgumentParser() subp = parser.add_subparsers() s

[issue33109] argparse: make new 'required' argument to add_subparsers default to False instead of True

2018-05-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please ignore the last paragraph. It was my mistake, all add_subparsers() parameters are keyword-only, and _SubParsersAction is a privale class. -- ___ Python tracker

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2018-05-22 Thread Eric Snow
New submission from Eric Snow : In order to keep subinterpreters properly isolated, objects from one interpreter should not be used in C-API calls in another interpreter. That is relatively straight-forward except in one case: indicating that the other interpreter doesn't need the object to exis

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2018-05-22 Thread Eric Snow
Eric Snow added the comment: As a lesser (IMHO) alternative, we could also modify Py_DECREF to respect a new "shared" marker of some sort (perhaps relative to #33607), but that would probably still require one of the refcount-based solutions (and add a branch to Py_DECREF). -- versions:

[issue23188] Provide a C helper function to chain raised (but not yet caught) exceptions

2018-05-22 Thread Eric Snow
Eric Snow added the comment: good point :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue33516] unittest.mock: Add __round__ to supported magicmock methods

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6c4fab0f4b95410a1a964a75dcdd953697eff089 by Victor Stinner (John Reese) in branch 'master': bpo-33516: Add support for __round__ in MagicMock (GH-6880) https://github.com/python/cpython/commit/6c4fab0f4b95410a1a964a75dcdd953697eff089 --

[issue33516] unittest.mock: Add __round__ to supported magicmock methods

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: Thank you Martijn Pieters for the feature request/bug report, and thanks John Reese for the implementation! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33565] strange tracemalloc results

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > this means 21 blocks were not released, and in this case leaked because > nothing should be held onto after the first iteration (creating the initial > connector in the connection pool. In the head object case that's going to be > a new connector per itera

[issue33607] Explicitly track object ownership (and allocator).

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: "Either we'd add 2 pointer-size fields to PyObject or we would keep a separate hash table (or two) pointing from each object to the info (...)" The expect a huge impact on the memory footprint. I dislike the idea. Currently, the smallest Python object is: >>

[issue33605] Detect accessing event loop from a different thread outside of _debug

2018-05-22 Thread Yury Selivanov
Yury Selivanov added the comment: > I suggest that asyncio should be stricter about this error and that methods > and functions that operate on the event loop, such as call_soon, call_later, > create_task, ensure_future, and close, should all call _check_thread() even > when not in debug mode

[issue33565] strange tracemalloc results

2018-05-22 Thread Alexander Mohr
Alexander Mohr added the comment: yes, memory does go up. If you click the botocore bug link you'll see a graph of memory usage over time. -- ___ Python tracker ___ _

[issue33604] HMAC default to MD5 marked as to be removed in 3.6

2018-05-22 Thread Matthias Bussonnier
Change by Matthias Bussonnier : -- pull_requests: +6693 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue32400] inspect.isdatadescriptor false negative

2018-05-22 Thread Aaron Hall
Change by Aaron Hall : -- nosy: +Aaron Hall ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

  1   2   >