[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 24bff360c2aa6d52f7a40ef35a5d7e5660d13402 by Benjamin Peterson in branch '3.6': gc types needs to be allocated as such (closes #29398) https://github.com/python/cpython/commit/24bff360c2aa6d52f7a40ef35a5d7e5660d13402 New changeset 9e499c39bc298b080

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 24bff360c2aa6d52f7a40ef35a5d7e5660d13402 by Benjamin Peterson in branch 'master': gc types needs to be allocated as such (closes #29398) https://github.com/python/cpython/commit/24bff360c2aa6d52f7a40ef35a5d7e5660d13402 New changeset 9e499c39bc298b

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29398] memory corruption in xxlimited

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 24bff360c2aa6d52f7a40ef35a5d7e5660d13402 by Benjamin Peterson in branch '3.5': gc types needs to be allocated as such (closes #29398) https://github.com/python/cpython/commit/24bff360c2aa6d52f7a40ef35a5d7e5660d13402 -- __

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: I'm running pyperformance. BTW, hashlib doesn't provide siphash24. So can we simply replace siphash24 with siphash13, like ruby? https://github.com/ruby/ruby/commit/04c94f95d1a1c6a12f5412228a2bcdc00f5de3b2 -- ___ Pyth

[issue29377] Add the 'wrapper_descriptor' type to the types module

2017-02-01 Thread Manuel Krebber
Manuel Krebber added the comment: One question I was wondering about is whether those types should be checked by inspect.isroutine() as well. -- ___ Python tracker ___ _

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: PEP 456 defines an API to add more hashing algorithms and make the selection of hash algorithm a compile time option. We can easily add SipHash-1-3 and make it the default algorithm. Vendors then can select between FNV2, SipHash-1-3 and SipHash-2-4. On anot

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: $ ../python.default -m perf compare_to default.json patched4.json -G Slower (2): - scimark_sor: 479 ms +- 8 ms -> 485 ms +- 9 ms: 1.01x slower (+1%) - genshi_xml: 196 ms +- 2 ms -> 196 ms +- 2 ms: 1.00x slower (+0%) Faster (19): - json_loads: 62.7 us +- 0.5 us -> 6

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: > PEP 456 defines an API to add more hashing algorithms and make the selection > of hash algorithm a compile time option. We can easily add SipHash-1-3 and > make it the default algorithm. Vendors then can select between FNV2, > SipHash-1-3 and SipHash-2-4. OK,

[issue29397] linux/random.h present but cannot be compiled

2017-02-01 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Could you upload a copy of config.log? Also added developers that play in random.h games -- components: +Build nosy: +Chi Hsuan Yen, benjamin.peterson, haypo ___ Python tracker ___

[issue29377] Add the 'wrapper_descriptor' type to the types module

2017-02-01 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Guido, I attach the full patch now, as you asked. (Initially I was not sure about tests, but now I understand more these types, so that I added even few more tests than in original patch) > Maybe we need to wait for the github migration to complete though? I

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: I added SipHash13 as additional hash algorithm in https://github.com/tiran/cpython/tree/siphash13 . Still need to verify the finalizer. For hashlib I'd need to move to a different implementation of SipHash. The implementation in pyhash.c is optimized for sp

Re: [issue29410] Moving to SipHash-1-3

2017-02-01 Thread M.-A. Lemburg
On 01.02.2017 10:14, Christian Heimes wrote: > > PEP 456 defines an API to add more hashing algorithms and make the selection > of hash algorithm a compile time option. We can easily add SipHash-1-3 and > make it the default algorithm. Vendors then can select between FNV2, > SipHash-1-3 and Sip

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: > it seems as if it would make sense to not use a fixed > hash algorithm for all strings lengths, but instead a > hybrid one to increase performance for short strings > (which are used a lot in Python). > > Is there a good hash algorithm with provides better > perfo

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The performance of hash algorithm shouldn't affect general benchmarks since hash value is cached inside string object. Almost all dict lookups in critical parts are lookups with interned strings. But in corner cases the difference can be measurable. We shoul

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 01.02.2017 10:50, INADA Naoki wrote: > >> it seems as if it would make sense to not use a fixed >> hash algorithm for all strings lengths, but instead a >> hybrid one to increase performance for short strings >> (which are used a lot in Python). >> >> Is

[issue29404] "TypeError: 'int' does not have the buffer interface" on memoryview over bytearray

2017-02-01 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +benjamin.peterson, skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 01.02.2017 11:07, Serhiy Storchaka wrote: > > The performance of hash algorithm shouldn't affect general benchmarks since > hash value is cached inside string object. Almost all dict lookups in > critical parts are lookups with interned strings. But in

[issue29402] Problem with Checkbutton and duplicate last name components

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The variable option of the checkbutton widget specifies the name of a global variable to set to indicate whether or not this button is selected. It defaults to the name of the button within its parent (i.e. the last element of the button window's path name).

[issue29411] Option --executable for entry_points

2017-02-01 Thread Michal Cyprian
New submission from Michal Cyprian: 1. python3 setup.py build --executable="/usr/bin/binary" 2. python3 setup.py install -O1 --skip-build These two commands are typically used to build and install Python packages from sources. Let's assume there is a setup.py script of package foo, containing a

[issue27647] Update Windows build to Tcl/Tk 8.6.6

2017-02-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: AFAIK, the Windows x.y compiled release and installer is normally updated to the latest stable tcl/tk, about the time of beta 1, and never changed for bugfix releases. 2.7 was an exception because of its long life and because later 8.5.z releases has some cri

[issue27647] Update Windows 2.7 build to Tcl/Tk 8.5.19

2017-02-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: I changed title to match what might and, I think, should happen. My take: x.y is normally followed within 2 years by x.(y+1), which on Windows includes the latest tcl/tk. So, on Windows, anyone who wants the new tcl/tk can upgrade to the newer Python. For 2.

[issue27647] Update Windows 2.7 build to Tcl/Tk 8.5.19

2017-02-01 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue27200] make doctest in CPython has failures

2017-02-01 Thread Marco Buttu
Marco Buttu added the comment: Thank you Raymond for your time. I just want to note that does not distrac the reader, because it is not show in the output. Furthermore, to doctest an example we do not need to add the prompt (>>>): we can use the testcode/testoutput Sphinx directives. ---

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b279c263708 by doko in branch '3.5': Issue #29169: Fix NEWS entry. https://hg.python.org/cpython/rev/7b279c263708 -- ___ Python tracker __

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: Current Py_HASH_CUTOFF implementation seems weak. ``` switch(len) { /* ((hash << 5) + hash) + *p == hash * 33 + *p */ case 7: hash = ((hash << 5) + hash) + *p++; /* fallthrough */ ... case 1: hash = ((hash << 5) + hash) +

[issue27400] Datetime NoneType after calling Py_Finalize and Py_Initialize

2017-02-01 Thread Christopher Schramm
Christopher Schramm added the comment: This issue should have a much higher priority as it basically breaks Python embedding unless the user either does not re-initialize the interpreter or avoid the use of _datetime.strptime. We're currently testing with a patch based on Christian and Alexand

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: Py_HASH_CUTOFF was an experimental feature for low-performance platforms. On modern hardware the performance increase is marginal to non-existing. I planned to deprecate the feature in 3.6 but forgot. We can deprecate it now and remove it in either 3.7 or 3.

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Gareth Rees
Gareth Rees added the comment: Is there any chance of making progress on this issue? Is there anything wrong with my patch? Did I omit any relevant point in my message of 2016-06-11 16:26? It would be nice if this were not left in limbo for another four years. -- _

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 01.02.2017 13:03, INADA Naoki wrote: > Maybe, we should remove Py_HASH_CUTOFF completely? I think we ought to look for a better hash algorithm for short strings, e.g. a CRC based one. Some interesting investigations on this: http://www.orthogonal.com.au/

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: We can and should still use hash randomization for short strings, but a different key than for hash randomization for longer strings. -- ___ Python tracker _

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: Py_HASH_CUTOFF uses different secret from siphash already. The problem is the secret doesn't affects to collision at all. Attacker can produce large number of collision, without knowing the secret. BTW, we have FNV already. Let's survey about FNV-1 short string c

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: https://emboss.github.io/blog/2012/12/14/breaking-murmur-hash-flooding-dos-reloaded/ Murmur may be safe for <16 byte too. -- ___ Python tracker __

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c1f136e83fe9a145f509b27417a8dd2a37ac27c by doko in branch '3.6': Issue #29169: Fix NEWS entry. https://github.com/python/cpython/commit/7c1f136e83fe9a145f509b27417a8dd2a37ac27c -- ___ Python tracker <

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c1f136e83fe9a145f509b27417a8dd2a37ac27c by doko in branch '3.5': Issue #29169: Fix NEWS entry. https://github.com/python/cpython/commit/7c1f136e83fe9a145f509b27417a8dd2a37ac27c -- ___ Python tracker <

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c1f136e83fe9a145f509b27417a8dd2a37ac27c by doko in branch 'master': Issue #29169: Fix NEWS entry. https://github.com/python/cpython/commit/7c1f136e83fe9a145f509b27417a8dd2a37ac27c -- ___ Python tracke

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: Unless somebody is able to show a real-world example with a considerable performance boost (>5%), I'm strictly against any kind of special casing for short strings. I don't want to trade security for performance. You might be able to persuade me to go for a

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: Summary of overt and implied votes: Core Devs: +1 Mark Dickenson +1 Ethan Furman ?? Serhiy Storchaka -1 Alexander Belopolsky (at first, but unclear after) Other: +1 Ryan Gonzales, quoting Guido about equivalence of ints and longs. The sys.exit docstring says "I

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Gareth Rees
Gareth Rees added the comment: In Windows, under cmd.exe, you can use %errorlevel% -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue29412] IndexError thrown on email.message.M

2017-02-01 Thread Joel Uckelman
New submission from Joel Uckelman: Test case: import email import email.policy txt = '''From: juckel...@strozfriedberg.co.uk To: (Recipient list suppressed) Date: Thu, 22 Aug 2013 04:13:02 + Subject: ADSF-1082 Hey! ''' msg = email.message_from_string(txt) msg.get('t

[issue29412] IndexError thrown on email.message.EmailMessage.get

2017-02-01 Thread Joel Uckelman
Changes by Joel Uckelman : -- title: IndexError thrown on email.message.M -> IndexError thrown on email.message.EmailMessage.get ___ Python tracker ___ _

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Count me as +1. The patch LGTM. See also issue28998. -- ___ Python tracker ___ ___ Python-bugs-li

[issue29412] IndexError thrown on email.message.EmailMessage.get

2017-02-01 Thread R. David Murray
R. David Murray added the comment: Does the patch from issue 27931 fix your problem as well? I haven't looked closely enough to see if I think it should, I'm just hoping :) -- ___ Python tracker _

[issue27051] Create PIP gui

2017-02-01 Thread Nick Coghlan
Nick Coghlan added the comment: Rather than "rejected" per se, I've closed this as "postponed" - I still think there's potential value in bundling a component management GUI in the future, but it should be *after* a project has established itself as the de facto introductory approach via PyPI.

[issue29412] IndexError thrown on email.message.EmailMessage.get

2017-02-01 Thread Joel Uckelman
Joel Uckelman added the comment: No dice. I get the same exception with issue27931_v2.patch. I briefly looked at the other two, and don't expect those will help, either. -- ___ Python tracker _

[issue27400] Datetime NoneType after calling Py_Finalize and Py_Initialize

2017-02-01 Thread Nick Coghlan
Nick Coghlan added the comment: I've added Steve Dower to the nosy list, as he's done some work recently on making the Windows builds more embedding-friendly, and I believe at least some of that time may have been funded work. Unfortunately, we don't currently have anyone I'm aware of that's b

[issue24869] shlex lineno inaccurate with certain inputs

2017-02-01 Thread Gareth Rees
Gareth Rees added the comment: Here's a patch that implements my proposal (1) -- under this patch, tokens read from an input stream belong to a subtype of str with startline and endline attributes giving the line numbers of the first and last character of the token. This allows the accurate re

[issue29412] IndexError thrown on email.message.Message.get

2017-02-01 Thread Joel Uckelman
Changes by Joel Uckelman : -- title: IndexError thrown on email.message.EmailMessage.get -> IndexError thrown on email.message.Message.get ___ Python tracker ___ ___

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 54fa95b19fae by Victor Stinner in branch 'default': python-gdb.py supports method-wrapper https://hg.python.org/cpython/rev/54fa95b19fae -- nosy: +python-dev ___ Python tracker

[issue29362] regrtest: don't fail immediately if a child does crash

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Attached patch changes libregrtest to handle CHILD_ERROR as a normal result and continue the execution of following tests. As a result, it displays the test summary as usual on such crash. -- Ammar Askar: Thanks for regrtest_crash.diff, but I prefer to execut

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 30867b703933d6ba30bc5f609a1a2337925ead33 by Victor Stinner in branch 'master': python-gdb.py supports method-wrapper https://github.com/python/cpython/commit/30867b703933d6ba30bc5f609a1a2337925ead33 -- ___

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset ffd2e5f9256a by Victor Stinner in branch 'default': Make test_gdb.test_wrapper_call() make reliable https://hg.python.org/cpython/rev/ffd2e5f9256a -- ___ Python tracker

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- resolution: -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset fcba9c9d987b by Victor Stinner in branch 'default': Document that _PyFunction_FastCallDict() must copy kwargs https://hg.python.org/cpython/rev/fcba9c9d987b -- nosy: +python-dev ___ Python tracker

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: INADA Naoki: "Since mutating kw dict shouldn't affect caller's dict, caller and callee can't share the dict." Oh, I knew that, it's not the first time that I propose to implement this optimization and that I got this answer !? So I added a comment for myself,

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue29311] Argument Clinic: convert dict methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Thank you very much for the docstring enhancement Serhiy! I like your new docstrings. It seems like all known issues are now fixed, so I close the issue. Thanks Naoki and Martin too for the reviews. -- resolution: -> fixed status: open -> closed ___

[issue29300] Modify the _struct module to use FASTCALL and Argument Clinic

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: Would you mind to review my latest patch, struct_fastcall-6.patch? It should address all your remarks, except your proposal to write a converter for cache_struct(): see my previous comment about this idea. Thanks in advance ;) -- _

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Thanks again Serhiy for the better docstrings! Known issues are now fixed, so I close the issue. Thanks for the review Naoki. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Recently, I saw complains that I push changes too fast without reviews. This issue is a good example. So let me elaborate myself a little bit on these changes. I'm not really proud of the "Rename _PyArg_ParseStack to _PyArg_ParseStackAndKeywords" change. It s

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 758674087b12 by Victor Stinner in branch 'default': Issue #29286: Rename private PyArg_UnpackStack_impl() to unpack_stack() https://hg.python.org/cpython/rev/758674087b12 -- ___ Python tracker

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: "Oh, I have wrote almost the same patch before going to sleep yesteday! ;) But the building crashed (likely due to a bug in _PyStack_UnpackDict()) and it was too late to resolve this." Oh, sorry that you wrote almost the same code. Well, at

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: str type still has a few methods using METH_VARARGS (slower than METH_FASTCALL): * count() * find() * index() * rfind() * rindex() * startswith() * endswith() * format() Maybe I will propose a change later to convert these methods to Argument Clinic, but I con

[issue29263] Implement LOAD_METHOD/CALL_METHOD for C functions

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: INADA Naoki: "Maybe, we should do: * Make clinic use more METH_FASTCALL * Use clinic more in builtin methods; before trying this optimization." I created the issue #29286 "Use METH_FASTCALL in str methods" which is now fixed. I started to propose patches for o

[issue29260] Use designated initializers to define PyTypeObject types

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: The question was discussed on the python-dev mailing list: [Python-Dev] Can we use "designated initializer" widely in core modules? https://mail.python.org/pipermail/python-dev/2017-January/147154.html I understood that it's ok to use them in new code, but not t

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5910fd7231d34363798d2815be2f66909e638d1c by Victor Stinner in branch 'master': Issue #29286: Rename private PyArg_UnpackStack_impl() to unpack_stack() https://github.com/python/cpython/commit/5910fd7231d34363798d2815be2f66909e638d1c -- _

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2c145e9eda756aa2001282d7c016e740dd00a2d7 by Victor Stinner in branch 'master': Document that _PyFunction_FastCallDict() must copy kwargs https://github.com/python/cpython/commit/2c145e9eda756aa2001282d7c016e740dd00a2d7 -- ___

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 88835e6022a81d8107a296c9f6e5f16c7d39e27a by Victor Stinner in branch 'master': Make test_gdb.test_wrapper_call() make reliable https://github.com/python/cpython/commit/88835e6022a81d8107a296c9f6e5f16c7d39e27a -- _

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- resolution: rejected -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/pytho

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: "The default branch is now as good as Python 3.4, in term of stack consumption, and Python 3.4 was the Python version which used the least stack memory according to my tests." I consider that the initial issue is now fixed, so I close the issue. Thanks Serhiy

[issue29234] Disable inlining of _PyStack_AsTuple() to reduce the stack consumption

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: The initial issue has been fixed. With the issue #28870 (msg285169): "The default branch is now as good as Python 3.4, in term of stack consumption, and Python 3.4 was the Python version which used the least stack memory according to my tests." Serhiy: As I w

[issue29227] Reduce C stack consumption in function calls

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Victor: "I plan to run a benchmark when all my patches to reduce the stack consumption will be ready." msg285200 of issue #28870: "I also ran the reliable performance benchmark suite with LTO+PGO. There is no significant performance change on these benchmarks

[issue29300] Modify the _struct module to use FASTCALL and Argument Clinic

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It looks to me that the type of the self parameter can be changed from PyObject* to PyStructObject*. This will make the patch larger but the final code simpler. class Struct "PyStructObject *" "&PyStructType" --

  1   2   3   >