[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: > It may break other debuggers like Python Tools for Visual Studio, though > (+steve.dower for that). Do you mean debuggers expecting that bytecode is run in PyEval_EvalFrameEx() rather than PyEval_EvalFrameDefault()? Can't we fix these debuggers? > IMHO, in

[issue28920] Dangerous usage of "O" format string in _asynciomodule.c

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset f2745b64d8b7 by Victor Stinner in branch '3.6': _asyncio uses _PyObject_CallMethodIdObjArgs() https://hg.python.org/cpython/rev/f2745b64d8b7 -- nosy: +python-dev ___ Python tracker

[issue28920] Dangerous usage of "O" format string in _asynciomodule.c

2016-12-15 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue28838] Using consistent naming for arguments of "call" functions (C API)

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 654ec6ed3225 by Victor Stinner in branch 'default': Issue #28838: Cleanup abstract.h https://hg.python.org/cpython/rev/654ec6ed3225 -- ___ Python tracker _

[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: May be just replace inlined call with _PyEval_EvalFrameDefault? -- ___ Python tracker ___ ___ Pyth

[issue28838] Using consistent naming for arguments of "call" functions (C API)

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Victor, it would be worth to discuss this change on Python-Dev. -- ___ Python tracker ___ ___ Pyth

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2016-12-15 Thread INADA Naoki
INADA Naoki added the comment: > Fixed fromkeys() in Py2.7. Stills needs to be forward ported to 3.4/3.5. dict.fromkeys() is fixed already in 3.6+. dict(l) doesn't presize the dict. If it's desirable, let's create a new issue. -- nosy: +inada.naoki resolution: -> fixed status: open

[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: "May be just replace inlined call with _PyEval_EvalFrameDefault?" Do you mean replacing PyEval_EvalFrameEx() with _PyEval_EvalFrameDefault()? It would defeat the purpose of the PEP 523, no? -- ___ Python tra

[issue28977] Document PyObject_CallFunction() special case more explicitly

2016-12-15 Thread STINNER Victor
New submission from STINNER Victor: The PyObject_CallFunction() function has a special case if the format string is "O". See my email thread on python-dev: https://mail.python.org/pipermail/python-dev/2016-December/146919.html Serhiy wrote: "It is documented for Py_BuildValue(), and the documen

[issue28838] Using consistent naming for arguments of "call" functions (C API)

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: I pushed cleanup-2.patch (after a minor rebase). Sorry for breaking "hg annotation" on Include/abstract.h: I hope that it will be less annoying that the giant "replace tabs with space" made by Antoine Pitrou a few years ago which modified almost all .c and .h

[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ah, now I see. I was confused by the fact that eval_frame is set only to _PyEval_EvalFrameDefault. But how large the gain of inlining PyEval_EvalFrameEx()? Is it worth cluttering the code? Since almost all calls of PyEval_EvalFrameEx() are in the same file

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread Ned Deily
Ned Deily added the comment: It appears this issue has stalled again. Is the most recent patch fix28147-py36-2.patch) ready for review? If so, can someone please review it? Then it needs to be pushed to the 3.6 branch for 3.6.1 and exposed to the buildbots. Only then could we consider cher

[issue28967] copy.copy fails on threading.local subclass

2016-12-15 Thread Ned Deily
Ned Deily added the comment: Thanks for raising the issue, Jelle. And thanks for the analysis, Serhiy. It doesn't sound like a release blocker for 3.6.0. Is it worth addressing at all? -- assignee: ned.deily -> priority: release blocker -> normal versions: +Python 3.7 _

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread Ned Deily
Changes by Ned Deily : -- priority: high -> deferred blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue28971] nntplib is broken when responses are longer than _MAXLINE

2016-12-15 Thread Xavier de Gaye
Xavier de Gaye added the comment: The patch: 1) Increases _MAXLINE to 4096. 2) Reverts issue 16040 and that is not correct, please ignore that part. The changes made in issue 16040 limit the amount of data read by readline() and does not close the nntp session when the server sends a message wh

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 56a7eb5a0679 by Xiang Zhang in branch '3.6': Issue #28930: Add a Makefile rule for bytes_methods.c. https://hg.python.org/cpython/rev/56a7eb5a0679 New changeset c4bcca326c0a by Xiang Zhang in branch 'default': Issue #28930: Merge from 3.6. https://h

[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: "Since almost all calls of PyEval_EvalFrameEx() are in the same file as its definition, I suppose the compiler can inline it even without PGO." Let me check. My patch changes gen_send_ex() of genobject.c and _PyEval_EvalCodeWithName() of ceval.c. "gcc

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

2016-12-15 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Py

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: fix28147-py36-2.patch: test_dict pass with DEBUG_PYDICT defined. -- ___ Python tracker ___ ___ Pytho

[issue11322] encoding package's normalize_encoding() function is too slow

2016-12-15 Thread INADA Naoki
Changes by INADA Naoki : -- keywords: +patch Added file: http://bugs.python.org/file45909/encoding_normalize_optimize.patch ___ Python tracker ___ ___

[issue11322] encoding package's normalize_encoding() function is too slow

2016-12-15 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28971] nntplib is broken when responses are longer than _MAXLINE

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It seems to me there are two issues: 1) The limit of line length is not large enough. 2) After raising an error on too long line the NNTP object is left in broken state. The first issue can be solved by increasing the default limit or by patching the nntp m

[issue11322] encoding package's normalize_encoding() function is too slow

2016-12-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Thanks for the patch. Victor has implemented the function in C, AFAIK, so an even better approach would be to expose that function at the Python level and use it in the encodings package. -- versions: +Python 3.7 -Python 3.4, Python 3.5 _

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread INADA Naoki
Changes by INADA Naoki : Added file: http://bugs.python.org/file45910/fix28147-py36-3.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: I reviewed fix28147-py36-2.patch, I have some requests. -- ___ Python tracker ___ ___ Python-bugs-li

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: Ned: "If so, can someone please review it?" Done. Ned: "I am very reluctant to delay now for an issue that has been open now for 3 months throughout the beta phase of the release cycle. If enough people feel we should delay 3.6.0 to address this, we can."

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: Can you provide a code snippet that demonstrates the actual problem? As far as I can see this code behaves as documented -- nosy: +brendan-donegan ___ Python tracker

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: fix28147-py36-3.patch LGTM: Naoki, please push it right now. But please see also my comments on fix28147-py36-2.patch: I would still apprecicate that we enhance the comment in dictobject.c. The comment is not a blocker issue for 3.6.0, it can be enhanced later

[issue11322] encoding package's normalize_encoding() function is too slow

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: It seems like encodings.normalize_encoding() currently has no unit test! Before modifying it, I would prefer to see a few unit tests: * " utf 8 " * "UtF 8" * "utf8\xE9" * etc. Since we are talking about an optimmization, I would like to see a benchmark result

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
woo yoo added the comment: code : >>> if 1<2<3:print(123);print(op); Output: 123 Traceback (most recent call last): NameError:... -- ___ Python tracker ___ ___

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Raoul Gough
Raoul Gough added the comment: Hi Serhiy, thanks very much for looking at this. My only concern with removing the code completely is that it does work (presumably as intended) with at least some of the standard exception types. For example, if you change the demo to raise and catch a RuntimeEr

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: How does that contradict the documentation? Both print statements were executed - the second one raised an exception because of 'op' not being defined. -- ___ Python tracker

[issue28879] smtplib send_message should add Date header if it is missing, per RFC5322

2016-12-15 Thread Maciej Szulik
Maciej Szulik added the comment: I tend to agree with Eric Lafontaine, looking at the quote Henning von Bargen posted the originator address field is also required, but yet we don't explicitly check its presence in the code, but rely on the SMTP server to error out. -- nosy: +maciej.s

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
woo yoo added the comment: code : >>> if 1<2<3:print(123);print(op);print(opi); Output: 123 Traceback (most recent call last): NameError:name 'op' is not defined The third 'print' call hasn't been executed. -- ___ Python tracker

[issue28838] Using consistent naming for arguments of "call" functions (C API)

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: "Victor, it would be worth to discuss this change on Python-Dev." Done: https://mail.python.org/pipermail/python-dev/2016-December/146999.html -- ___ Python tracker __

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps it was added for debugging. Exceptions that don't define own __new__ and __init__ inherit them from BaseException. BaseException constructor saves positional arguments as the args attribute. But not all standard exceptions accept arbitrary number of

[issue27400] Datetime NoneType after calling Py_Finalize and Py_Initialize

2016-12-15 Thread Chi Hsuan Yen
Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28969] fnmatch is not threadsafe

2016-12-15 Thread Peter Otten
Peter Otten added the comment: Here's another way to reproduce the error. The problem seems to be in the C implementation of _lru_cache_wrapper() / bounded_lru_cache_wrapper(). $ cat test.py import functools import threading import time @functools.lru_cache(maxsize=2) def f(v): time.sleep(

[issue28838] Using consistent naming for arguments of "call" functions (C API)

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue28969] fnmatch is not threadsafe

2016-12-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka keywords: +3.5regression stage: -> needs patch versions: +Python 3.6, Python 3.7 ___ Python tracker ___ _

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset eb830f1511ef by Serhiy Storchaka in branch '2.7': Issue #28925: cPickle now correctly propagates errors when unpickle instances https://hg.python.org/cpython/rev/eb830f1511ef -- nosy: +python-dev ___ Pyth

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: Indeed, but that's merely because an exception has been raised. The example given doesn't include any statements that would raise an exception. I'm not sure it's necessary to re-iterate well known Python behaviour in this section. Anyway, that's my 2c -

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-15 Thread INADA Naoki
INADA Naoki added the comment: This patch updates the comment. -- Added file: http://bugs.python.org/file45911/fix28147-comment-update.patch ___ Python tracker ___ __

[issue28969] lru_cache is not threadsafe

2016-12-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- title: fnmatch is not threadsafe -> lru_cache is not threadsafe ___ Python tracker ___ ___ Python-bug

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
woo yoo added the comment: Thanks for your attention. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue28689] OpenSSL 1.1.0c test failures

2016-12-15 Thread Christian Heimes
Christian Heimes added the comment: No blacklisting :) I don't want to mess with any code prior to the final release of Python 3.6.0. Let's just document that stock 1.1.0c is not compatible. Ned, I'm setting the release blocker flag as a reminder to add a comment to the release notes of 3.6.0.

[issue28870] Refactor PyObject_CallFunctionObjArgs() and like

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 71876e4abce4 by Victor Stinner in branch 'default': Add _PY_FASTCALL_SMALL_STACK constant https://hg.python.org/cpython/rev/71876e4abce4 -- nosy: +python-dev ___ Python tracker

[issue28915] Modify PyObject_CallFunction() to use fast call internally

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset bec846dd92e8 by Victor Stinner in branch 'default': Fix _PyObject_CallFunctionVa(), use the small stack https://hg.python.org/cpython/rev/bec846dd92e8 -- ___ Python tracker

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread woo yoo
New submission from woo yoo: Quote the documentation as below: > parameter_list ::= (defparameter ",")* | "*" [parameter] ("," defparameter)* ["," "**" parameter] | "**" parameter | defparameter [","] ) The last right parenthesis is r

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread woo yoo
woo yoo added the comment: Here is the link https://docs.python.org/3/reference/compound_stmts.html#function-definitions -- ___ Python tracker ___ __

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread woo yoo
woo yoo added the comment: Just the right parenthesis is redundant, ignore other words. -- ___ Python tracker ___ ___ Python-bugs-list

[issue28969] lru_cache is not threadsafe

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your example Peter. Proposed patch fixes the KeyError. It introduces new private C API _PyDict_Pop_KnownHash(). It is like _PyDict_Pop(), but with precomputed hash. -- keywords: +patch stage: needs patch -> patch review Added file: http

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

2016-12-15 Thread Chun-Yu Tseng
Chun-Yu Tseng added the comment: Here comes the patch: 1. Let Pdb can also resume from `return`, `until` and `next` commands when receiving Control-C. 2. Explicitly raise `bdb.BdbQuit` when an unexpected exception occurs in `sigint_handler`. See #24283. 3. Add two tests `test_break_during_in

[issue28969] lru_cache is not threadsafe

2016-12-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

2016-12-15 Thread Matt Joiner
Changes by Matt Joiner : -- nosy: -anacrolix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue28971] nntplib is broken when responses are longer than _MAXLINE

2016-12-15 Thread Xavier de Gaye
Xavier de Gaye added the comment: It seems that the comment placed above the definition of _MAXLINE in the nntplib module is not correct: "RFC 3977 limits NNTP line length to 512 characters, including CRLF. We have selected 2048 just to be on the safe side." The 512 characters limit in RFC

[issue28969] lru_cache is not threadsafe

2016-12-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file45912/lru_cache-dict-pop-3.5.patch ___ Python tracker ___ ___ Python-bu

[issue28969] lru_cache is not threadsafe

2016-12-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45914/lru_cache-dict-pop-3.5.patch ___ Python tracker ___ ___ Python-bugs

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread woo yoo
woo yoo added the comment: And i find that the current rules of parameter_list includes a bare '*',which is illegal in practice. -- ___ Python tracker ___ __

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread Jim Fasarakis-Hilliard
Jim Fasarakis-Hilliard added the comment: See issue<9232> that changed the docs on function definitions. These changes aren't reflected in the 3.5 documentation though, you'll find them in the 3.6 docs. The linked grammar is probably missing an opening parentheses from what I can tell, i.e ch

[issue28870] Refactor PyObject_CallFunctionObjArgs() and like

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: I reworked abstract.c to prepare work for this issue: * change 455169e87bb3: Add _PyObject_CallFunctionVa() helper * change 6e748eb79038: Add _PyObject_VaCallFunctionObjArgs() private function * change 71876e4abce4: Add _PY_FASTCALL_SMALL_STACK constant I wrot

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

2016-12-15 Thread STINNER Victor
Changes by STINNER Victor : -- title: Refactor PyObject_CallFunctionObjArgs() and like -> Reduce stack consumption of PyObject_CallFunctionObjArgs() and like ___ Python tracker

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: I don't propose to add _testcapi.pyobjectl_callfunctionobjargs_stacksize(). It's just to test the patch. I'm using it with: $./python -c 'import _testcapi; n=100; print(_testcapi.pyobjectl_callfunctionobjargs_stacksize(n) / (n+1))' 384.0 The value of n has no

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread woo yoo
woo yoo added the comment: There is a few difference between Python-3.5.2 and Python-3.6.2 concerning the EBNF rules even though the parenthesis bug is fixed. -- ___ Python tracker ___

[issue23246] distutils fails to locate vcvarsall with Visual C++ Compiler for Python

2016-12-15 Thread Matteo Bertini
Matteo Bertini added the comment: I'm back on this issue with a minimal patch, and a longer motivation. Distutils does not support Visual C++ for Python compiler, but it could, with a one-line patch. The proposed workaround is to use `setuptools`. But, we are not alone in this World, am I sup

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread woo yoo
woo yoo added the comment: Nor the rules in Python-3.6.0 excludes the bare '*' following no parameters. -- ___ Python tracker ___ ___

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: I also tried to use alloca(): see attached alloca.patch. But the result is quite bad: 528 bytes of stack memory per call. I only attach the patch to discuss the issue, but I now dislike the option: the result is bad, it's less portable and more dangerous. ---

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: I also tried Serhiy's approach, split the function into subfunctions, but the result is not as good as expected: 496 bytes. See attached subfunc.patch. -- Added file: http://bugs.python.org/file45918/subfunc.patch __

[issue28979] What's New entry on compact dict mentions "faster" implementation

2016-12-15 Thread Jim Fasarakis-Hilliard
New submission from Jim Fasarakis-Hilliard: Specifically, the entry reads: "The dict type has been reimplemented to use a faster, more compact representation similar to the PyPy dict implementation." Through, the text describing the new implementation doesn't mention anything on speed, it onl

[issue28965] Multiprocessing spawn/forkserver fails to pass Queues

2016-12-15 Thread kumaar.nd
kumaar.nd added the comment: hi, few comments on this: [when tested with 'spawn'] 1. the document(3x, 17.2.1.2) clearly mentions that 'spawn' doesnt inherit the file-handles (hence FileNotFoundError). 2. the document's examples has spawn() followed by join() where parent waits for the Child t

[issue7291] urllib2 cannot handle https with proxy requiring auth

2016-12-15 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Modify target versions to bugfix and feature branches -- versions: +Python 3.7 -Python 2.6, Python 3.4 ___ Python tracker ___

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue28968] xml rpc server fails with connection reset by peer error no 104

2016-12-15 Thread R. David Murray
R. David Murray added the comment: Connection reset by peer means the far end has terminated the connection. You'll probably need to do some protocol analysis (wireshark or a similar tool) to find out why the connection is being dropped, or perhaps you can look at the far end logging. As it

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
woo yoo added the comment: Why the issue was closed? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: For comparison, Python 3.5 (before fast calls) uses 448 bytes of C stack per call. Python 3.5 uses a tuple allocated in the heap memory. -- ___ Python tracker

[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread Steve Dower
Steve Dower added the comment: At least define EvalFrameEx in a header as an inline func, rather than copying the body. VS expected to walk the native stack and locate the f parameter in EvalFrameEx. Since the function gets inlined, it couldn't find the frame. I use the JIT hook to insert my

[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: Well, since the impact on performance is likely non-existent, whereas drawbacks are real, I close the issue. Thanks for your feedback ;-) -- resolution: -> rejected status: open -> closed ___ Python tracker

[issue28924] Inline PyEval_EvalFrameEx() in callers

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: > At least define EvalFrameEx in a header as an inline func, rather than > copying the body. Hum, it would break the stable ABI, no? -- ___ Python tracker ___

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
Changes by woo yoo : -- resolution: not a bug -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue28879] smtplib send_message should add Date header if it is missing, per RFC5322

2016-12-15 Thread R. David Murray
R. David Murray added the comment: The sendmail function will never modify the RFC822+ content. send_message, however, already does several manipulations of the message headers to make sending email simpler. Practicality (make it easy to send messages without knowing the details of the SMTP/

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread R. David Murray
R. David Murray added the comment: What do you mean by "a bare * followed by no parameters"? That is, what is the thing that is considered invalid that you are saying the BNF rules allow? I'm looking for a code snipped that produces a syntax error. -- nosy: +r.david.murray _

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread R. David Murray
R. David Murray added the comment: Because the documentation is correct. There is no bug here. As Brendan said, there is no need to repeat a fundamental (that statements can raise exceptions) in this context. The point of the passage is that if x: a; b; c; is equivalent to if x:

[issue7291] urllib2 cannot handle https with proxy requiring auth

2016-12-15 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23246] distutils fails to locate vcvarsall with Visual C++ Compiler for Python

2016-12-15 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread woo yoo
woo yoo added the comment: Code: >>>def f(a, *): >>>print(a) (SyntaxError occurs here) -- ___ Python tracker ___ ___ Pyth

[issue28980] ResourceWarning when imorting antigravity in 3.6

2016-12-15 Thread Ivan Levkivskyi
New submission from Ivan Levkivskyi: In 3.6 importing antigravity prints a warning (although it does what it should do): >>> import antigravity /home/ivan/.../Lib/subprocess.py:761: ResourceWarning: subprocess 15501 is still running ResourceWarning, source=self) This is probably related to

[issue28978] a redundant right parentheses in the EBNF rules of parameter_list

2016-12-15 Thread R. David Murray
R. David Murray added the comment: Ah, I see. (", " defparameter)* should instead be "+", or whatever the BNF equivalent is. -- ___ Python tracker ___ _

[issue28979] What's New entry on compact dict mentions "faster" implementation

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: Agree. Patch provided. -- keywords: +patch nosy: +brendan-donegan Added file: http://bugs.python.org/file45919/whatsnew36.patch ___ Python tracker

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
woo yoo added the comment: According to the original description, "either all or none...",what does 'none' represent? -- ___ Python tracker ___ _

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: None represents the case where the if statement is false On Thu, 15 Dec 2016 at 20:40 woo yoo wrote: > > woo yoo added the comment: > > According to the original description, "either all or none...",what does > 'none' represent? > > -- > > ___

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
woo yoo added the comment: "either all or none of the print() calls are executed",I think the 'none' describes the number of the calls to be executed. -- ___ Python tracker ___

[issue28979] What's New entry on compact dict mentions "faster" implementation

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 181453f9a0c4 by Victor Stinner in branch '3.6': Issue #28979: Fix What's New in Python 3.6, dict https://hg.python.org/cpython/rev/181453f9a0c4 -- nosy: +python-dev ___ Python tracker

[issue28979] What's New entry on compact dict mentions "faster" implementation

2016-12-15 Thread STINNER Victor
STINNER Victor added the comment: @Ned: Would you be ok to cherry-pick 181453f9a0c4 in Python 3.6.0? -- nosy: +haypo ___ Python tracker ___ __

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: I think the consensus is that the wording is correct. If you can come up with text that is clearer, and still correct, please do submit a patch. On Thu, 15 Dec 2016 at 20:50 woo yoo wrote: > > woo yoo added the comment: > > "either all or none of the print()

[issue28979] What's New entry on compact dict mentions "faster" implementation

2016-12-15 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +inada.naoki, ned.deily, serhiy.storchaka, yselivanov ___ Python tracker ___ ___ Python-bugs-list

[issue27069] webbrowser creates zombi processes in the background mode

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: This appears to be Firefox specific? At least: b = webbrowser.get("chromium-browser") b.open("https://bugs.python.org/issue26741";) returns simply: True With no exception -- nosy: +brendan-donegan ___ Python trac

[issue28980] ResourceWarning when imorting antigravity in 3.6

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: I think this is essentially a duplicate of http://bugs.python.org/issue27069, or at least fixing that will fix this (as the exception is caused by the webbrowser.open() call) -- nosy: +brendan-donegan ___ Python tr

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread woo yoo
woo yoo added the comment: In fact, I'm a newcomer to Python. When i have experimented with those description interactively using Python interpreter, i got confused. I don't know how to submit a patch.If the description were changed by me,it would be: >if xis equivalent to >if xprint(x) >

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread R. David Murray
R. David Murray added the comment: As I said, the language reference is a specification, not a tutorual. The text as written is clear technical English. You are correct that 'none' refers to the number of statements executed, but 'none' are executed when the statement is false, and 'all' are

  1   2   >