[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Marcos Dione
Changes by Marcos Dione : Removed file: http://bugs.python.org/file42616/copy_file_range.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Marcos Dione
Marcos Dione added the comment: Version without the NEWS and ACKS change. -- Added file: http://bugs.python.org/file42617/copy_file_range.diff ___ Python tracker ___

[issue26862] SYS_getdents64 does not need to be defined on android API 21

2016-04-26 Thread Stefan Krah
Stefan Krah added the comment: @shiz: Can we settle on API level 21 or is there any reason to leave this in? -- nosy: +skrah ___ Python tracker ___ __

[issue26849] android does not support versioning in SONAME

2016-04-26 Thread Xavier de Gaye
Xavier de Gaye added the comment: Attached are the logcat traces of the abort. This links helps in reading Android avc messages: http://www.all-things-android.com/content/debugging-se-android-avc-messages -- Added file: http://bugs.python.org/file42618/logcat.txt _

[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Marcos Dione
Marcos Dione added the comment: Ok, I have a preliminary version of the patch. It has several parts: * Adding the functionality to the os module, with docstring. * Make shutil.copyfileobj() to use it if available. * Modify the docs (this has to be done by hand, right?). * Modify NEWS and ACKS.

[issue26020] set_display evaluation order doesn't match documented behaviour

2016-04-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- components: +Interpreter Core -Documentation nosy: +serhiy.storchaka stage: patch review -> commit review type: -> behavior ___ Python tracker _

[issue26020] set_display evaluation order doesn't match documented behaviour

2016-04-26 Thread Neil Girdhar
Neil Girdhar added the comment: Also, please add the following test: "{*{True, 1}}" Should be True. -- ___ Python tracker ___ ___ Pyt

[issue26020] set_display evaluation order doesn't match documented behaviour

2016-04-26 Thread Neil Girdhar
Neil Girdhar added the comment: Please don't forget to fix BUILD_SET_UNPACK to match. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue26865] toward the support of the android platform

2016-04-26 Thread Xavier de Gaye
New submission from Xavier de Gaye: This issue lists issues that may have to be fixed in the perspective of a future support of the android platform. build issue #26849: android does not support versioning in SONAME issue #26851: android compilation and link flags issue #26852: add

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Xiang Zhang
Xiang Zhang added the comment: No, urllib.request does not handle the no_proxy environment in case-sensitive way. It first checks if any environment_variable.lower() ends with "_proxy", and then checks if there is any environment_variable ends with "_proxy". So it works as a case insensitive c

[issue26859] unittest fails with "Start directory is not importable"

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26866] Inconsistent environment in Windows using "Open With"

2016-04-26 Thread Tom Middleton
New submission from Tom Middleton: I have found that the execution of python scripts is inconsistent from the following methods: >From Explorer: 1) Right-Click->Open with->python.exe 2) Right-Click->Open (assuming python.exe being the "default" application) 3) Right-Click->Open with->"Choose de

[issue26020] set_display evaluation order doesn't match documented behaviour

2016-04-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Please don't forget to fix BUILD_SET_UNPACK to match. Isn't it already correct? > Also, please add the following test: "{*{True, 1}}" Did you meant "{*{True}, *{1}}"? -- ___ Python tracker

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Daniel Morrison
Daniel Morrison added the comment: I believe there was a misunderstanding. While the environment variable name is handled in a case insensitive way, the contents of the environment variable is not. Please see some examples below: >>> os.environ['no_proxy'] = 'example.com' >>> urllib.re

[issue26020] set_display evaluation order doesn't match documented behaviour

2016-04-26 Thread Neil Girdhar
Neil Girdhar added the comment: Ah, sorry, I somehow went cross-eyed. Not sure offhand which test would test the BUILD_TUPLE_UNPACK, but I think you're right Serhiy. Could just add both? -- ___ Python tracker __

[issue26865] Meta-issue: support of the android platform

2016-04-26 Thread Zachary Ware
Changes by Zachary Ware : -- dependencies: +SYS_getdents64 does not need to be defined on android API 21, add a COMPILEALL_FLAGS Makefile variable, add function to os module for getting path to default shell, add platform.android_ver() for android, android compilation and link flags,

[issue26865] Meta-issue: support of the android platform

2016-04-26 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue26865] toward the support of the android platform

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26858] setting SO_REUSEPORT fails on android

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26856] android does not have pwd.getpwall()

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26862] SYS_getdents64 does not need to be defined on android API 21

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26849] android does not support versioning in SONAME

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26865] Meta-issue: support of the android platform

2016-04-26 Thread Eric Snow
Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue26853] missing symbols in curses and readline modules on android

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26855] add platform.android_ver() for android

2016-04-26 Thread Roman Evstifeev
Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26854] missing header on android for the ossaudiodev module

2016-04-26 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Maybe checking sys/soundcard.h and linux/soundcard.h in configure.ac is better? [1] https://github.com/yan12125/python3-android/blob/cpython-hg/mk/python/soundcard-h-path.patch -- nosy: +Chi Hsuan Yen ___ Python trac

[issue26855] add platform.android_ver() for android

2016-04-26 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: > Also how can we be sure that the '/system/build.prop' file may be guaranteed > to exist on all android devices ? This path is hard-coded in BioniC [1]. Though I can't find a document/relevant source codes to guarantee 'ro.build.version.release' and 'ro.build.

[issue26865] Meta-issue: support of the android platform

2016-04-26 Thread Chi Hsuan Yen
Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Xiang Zhang
Xiang Zhang added the comment: Ohh, it's my fault to misunderstand. I think your thinking is reasonable. Curl handles the suffix check insensitively. -- components: +Library (Lib) -Documentation nosy: -docs@python type: enhancement -> behavior ___ P

[issue26853] missing symbols in curses and readline modules on android

2016-04-26 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Things may be different if ncurses is built with --without-termlib or --enable-widec is not specified. I wasn't hit by this bug as my ncurses is built with --without-termlib. -- nosy: +Chi Hsuan Yen ___ Python tracke

[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Marcos Dione
Marcos Dione added the comment: Hmm, I just noticed that it doesn't fallback to normal copy if the arguments are not valid (EBADF, EXDEV). Back to the drawing board... -- ___ Python tracker ___

[issue26854] missing header on android for the ossaudiodev module

2016-04-26 Thread Stefan Krah
Stefan Krah added the comment: Since Android is the only known system with an odd include path, I prefer the short patch. In general, let's try to keep patches as short as possible (which Xavier is already doing). -- ___ Python tracker

[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Marcos Dione
Changes by Marcos Dione : Removed file: http://bugs.python.org/file42617/copy_file_range.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Marcos Dione
Marcos Dione added the comment: New version. Factoring the old method in a nested function also paves the way to implement https://bugs.python.org/issue25156 . -- Added file: http://bugs.python.org/file42619/copy_file_range.diff ___ Python tracker <

[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue19251] bitwise ops for bytes of equal length

2016-04-26 Thread cowlicks
cowlicks added the comment: @gvanrossum in this previous comment https://bugs.python.org/issue19251?@ok_message=msg%20264184%20created%0Aissue%2019251%20message_count%2C%20messages%20edited%20ok&@template=item#msg257964 I pointed out code from the wild which would be more readable, and posted

[issue19251] bitwise ops for bytes of equal length

2016-04-26 Thread cowlicks
cowlicks added the comment: I'll look through the list @serhiy.storchaka posted and make sure this still seems sane to me. -- ___ Python tracker ___

[issue19251] bitwise ops for bytes of equal length

2016-04-26 Thread STINNER Victor
STINNER Victor added the comment: >> If yes, maybe we should start with a module on PyPI. Is there a volunteer to >> try this option? > > bitsets – ordered subsets over a predefined domain This is an array of *bits*, not an array of bytes (or integers). > bitarray – efficient boolean array imp

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

2016-04-26 Thread Daniel Stokes
Daniel Stokes added the comment: The "Lifecycle of a Patch" document recommends pinging an issue after a month of no review. I do not see any special ping option, so I am assuming that means to post a comment. To help with code review I tried to keep this change very similar to a previous sim

[issue26853] missing symbols in curses and readline modules on android

2016-04-26 Thread Stefan Krah
Stefan Krah added the comment: Do you need libtinfow? It seems that it's not supported in setup.py, and getting even libtinfo support into some Linux distributions took quite a while. -- nosy: +skrah ___ Python tracker

[issue26664] find a bug in activate.fish of venv of cpython3.6

2016-04-26 Thread Tin Tvrtković
Tin Tvrtković added the comment: I'm getting this exact issue on Python 3.5 (xenial system installation). All my existing venvs (from before my upgrade to xenial) work. Here's the diff: > diff .venv/bin/activate.fish ../wrapt/.venv/bin/activate.fish 35c35 < set -gx VIRTUAL_ENV "/home/tin/pg/h

[issue26664] find a bug in activate.fish of venv of cpython3.6

2016-04-26 Thread Tin Tvrtković
Changes by Tin Tvrtković : -- versions: +Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26853] missing symbols in curses and readline modules on android

2016-04-26 Thread Stefan Krah
Stefan Krah added the comment: IOW, on Linux tinfo should work fine in combination with ncursesw. -- ___ Python tracker ___ ___ Python

[issue26664] find a bug in activate.fish of venv of cpython3.6

2016-04-26 Thread Tin Tvrtković
Tin Tvrtković added the comment: Also I will add I've been using fish for a long time and have never been affected by #26348. -- ___ Python tracker ___ _

[issue26862] SYS_getdents64 does not need to be defined on android API 21

2016-04-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: I have no problem just removing the #ifdef as Android API 21 is now old enough (Lollipop / 5.0) that anyone building Python 3.6 for use on Android is probably fine with it. If there is a #define that can be used to test the android api level at compile time

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

2016-04-26 Thread Stefan Krah
Stefan Krah added the comment: It seems that Android is the only known platform that deviates from /bin/sh. So perhaps we should simply set a variable to either /bin/sh or /system/bin/sh rather than waiting for #16353 to settle. -- nosy: +skrah versions: +Python 3.6 -Python 3.4

[issue26866] Inconsistent environment in Windows using "Open With"

2016-04-26 Thread Steve Dower
Steve Dower added the comment: I don't think there's actually a way to fix this - the current working directory is inherited from the current process in the "Open with" case (FWIW, #3 also produces the same result as #1). I suspect it would need a fix in Windows, which is highly unlikely, or

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

2016-04-26 Thread Joseph Hackman
Joseph Hackman added the comment: Uploading a new patch to address the issues in previous patch. -- Added file: http://bugs.python.org/file42620/issue25788-2.patch ___ Python tracker ___

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

2016-04-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks for pinging, Daniel. I'm not a Windows user so I can't test the patch, but I left some review comments on Rietveld: http://bugs.python.org/review/26536/ -- components: +Extension Modules -IO, Windows nosy: +berker.peksag

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Windows ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24933] socket.recv(size, MSG_TRUNC) returns more than size bytes

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5, Python 3.6 ___ Python tracker ___ ___

[issue26826] Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

2016-04-26 Thread Martin Panter
Martin Panter added the comment: Yes, the RST documentation has to be done by hand. It usually has more detail than the doc strings. I didn’t see any changes to the configure script in your patches. Did you make that change to define HAVE_COPY_FILE_RANGE yet? In /Modules/posixmodule.c (all th

[issue25452] Add __bool__() method to subprocess.CompletedProcess

2016-04-26 Thread Berker Peksag
Berker Peksag added the comment: The idea sounds good to me. -- nosy: +berker.peksag stage: -> needs patch versions: +Python 3.6 -Python 3.5 ___ Python tracker ___ _

[issue26859] unittest fails with "Start directory is not importable"

2016-04-26 Thread Martin Panter
Martin Panter added the comment: Is this the same bug as Issue 26481? I.e. is it the unittest dicovery mode that is affected? Maybe close the other bug as a duplicate, since Xavier has provided a patch here. -- components: +Tests nosy: +martin.panter stage: -> patch review __

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Xiang Zhang
Xiang Zhang added the comment: I write a patch to fix this. It seems on Windows and MacOS the behaviour is right. On MacOS it leaves the matching to fnmatch. On Windows it uses case insensitive regular matching. -- keywords: +patch Added file: http://bugs.python.org/file42621/issue2686

[issue24147] Dialect class defaults are not documented.

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Xiang Zhang
Xiang Zhang added the comment: The code has changed recently. I update the patch to reveal the change. -- Added file: http://bugs.python.org/file42622/issue26864_v2.patch ___ Python tracker

[issue26866] Inconsistent environment in Windows using "Open With"

2016-04-26 Thread Tom Middleton
Tom Middleton added the comment: That is interesting, in my use #3 seems to work. I am not certain if it matters whether the default application is already selected as python.exe or not. FWIW I'm on Windows 7 64 bit using 2.7.11 release install. **Full Disclosure** I did muck in the registry to

[issue26867] test_ssl test_options fails on ubuntu 16.04

2016-04-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: xiang.zhang priority: normal severity: normal status: open title: test_ssl test_options fails on ubuntu 16.04 ___ Python tracker ___ ___

[issue26867] test_ssl test_options fails on ubuntu 16.04

2016-04-26 Thread Xiang Zhang
New submission from Xiang Zhang: test_options in test_ssl fails on Ubuntu 16.04. I don't know this is due to the newest ubuntu or a recent code change. But I checkout revision 9 and then rebuild and test, test_option still fails. The traceback is: FAIL: test_options (test.test_ssl.Context

[issue24933] socket.recv(size, MSG_TRUNC) returns more than size bytes

2016-04-26 Thread Martin Panter
Martin Panter added the comment: As far as I know, passing MSG_TRUNC into recv() is Linux-specific. I guess the “right” portable way to get a message size is to know it in advance, or guess and expand the buffer if MSG_PEEK cannot return the whole message. Andrey: I don’t think we are accessin

[issue22234] urllib.parse.urlparse accepts any falsy value as an url

2016-04-26 Thread Luiz Poleto
Luiz Poleto added the comment: I am seeing some results when running urlparse with patch urlparse_empty_bad_arg_deprecation2.patch applied: >>> urllib.parse.urlparse({}) __main__:1: DeprecationWarning: Use of {} is deprecated __main__:1: DeprecationWarning: Use of '' is deprecated ParseResultBy

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Martin Panter
Martin Panter added the comment: I think this patch looks okay. It fixes the case insensitivity problem, but there is also the string suffix problem (see the myexample.com demo). I think it is reasonable for example.com to match my.example.com, but not myexample.com. -- stage: -> patc

[issue22234] urllib.parse.urlparse accepts any falsy value as an url

2016-04-26 Thread Martin Panter
Martin Panter added the comment: Regarding urlparse(b'', ''). Currently the second parameter is “scheme”, which is documented as being an empty text string by default. If we deprecate this, we should update the documentation. -- ___ Python tracker

[issue22234] urllib.parse.urlparse accepts any falsy value as an url

2016-04-26 Thread Luiz Poleto
Luiz Poleto added the comment: As for urlparse_empty_bad_arg_disallow.patch, I didn't go too deep into testing it but I found that calling urlparse with different non-str args are producing different results: urlparse({}) TypeError: unhashable type: 'slice' urlparse([]) AttributeError: 'list'

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Xiang Zhang
Xiang Zhang added the comment: Yes, you are right. I don't notice that. I will try to fix it. -- ___ Python tracker ___ ___ Python-bug

[issue19317] ctypes.util.find_library should examine binary's RPATH on Solaris

2016-04-26 Thread Richard PALO
Richard PALO added the comment: There *is* a feature with linking called $ORIGIN. -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue26868] Incorrect check for return value of PyModule_AddObject in _csv.c

2016-04-26 Thread Berker Peksag
New submission from Berker Peksag: This is probably harmless, but Modules/_csv.c has the following code: Py_INCREF(&Dialect_Type); if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type)) return NULL; However, PyModule_AddObject returns only -1 and 0. It also doesn'

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

2016-04-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, I forget. Needed updates of the documentation (including the "versionchanged" directive). And would be nice if you add corresponding entities in Doc/whatsnew/3.6.rst, Misc/NEWS and Misc/ACKS. The rest of the patch LGTM. -- _

[issue26672] regrtest missing in the module name

2016-04-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2ef61a4747eb by Berker Peksag in branch '2.7': Issue #26672: Fix regrtest example in test.rst https://hg.python.org/cpython/rev/2ef61a4747eb -- nosy: +python-dev ___ Python tracker

[issue26672] regrtest missing in the module name

2016-04-26 Thread Berker Peksag
Berker Peksag added the comment: Good catch, thanks for the report! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: enhancement -> behavior ___ Python tracker

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Xiang Zhang
Xiang Zhang added the comment: I update the patch to use regular expression to handle both case and suffix. This regular expression has the function of curl's check_noproxy. And I think a separate test case is better here. -- Added file: http://bugs.python.org/file42624/issue26864_v3.p

[issue19317] ctypes.util.find_library should examine binary's RPATH on Solaris

2016-04-26 Thread Richard PALO
Richard PALO added the comment: oups... I meant to add the comment about $ORIGIN (not really useful here) but also the fact that the binary python is built with the dependencies found via the library path (-L, for example) and the eventual run-paths (-R or -runpath) when not in the system path

[issue26864] urllib.request no_proxy check differs from curl

2016-04-26 Thread Xiang Zhang
Xiang Zhang added the comment: Update to improve the test case. -- Added file: http://bugs.python.org/file42625/issue26864_v4.patch ___ Python tracker ___ ___

[issue22234] urllib.parse.urlparse accepts any falsy value as an url

2016-04-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: Serhiy: I left review comments on the patch too. I agree to "tightening" of the input arg type in these urlparse functions. Before we for the next version, I think, it will be helpful to enumerate the behavior for wrong arg types for these functions that yo

<    1   2