[issue25300] Enable Intel MPX (Memory protection Extensions) feature

Florin Papa added the comment: > Is there a runtime cost or does the hardware run the bounds checks in > parallel with memory accesses? Are the bounds set when malloc() is called > or elsewhere? I read the provided links but can't say I fully understand how > it works exactly (which memory

[issue25340] libraries variable in setup.py ignore for multiprocessing module

New submission from Guillaume DAVY: Around line 1455 in setup.py the "libraries" variable is assigned but seems to be ignored when the Extension object for multiprocessing is created. This leads to a linking error on my system : "undefined symbol: clock_gettime" -- components: Installat

[issue25341] File mode wb+ appears as rb+

New submission from Mark Williams: There is at least one mode in which a file can be opened that cannot be represented in its mode attribute: wb+. This mode instead appears as 'rb+' in the mode attribute: Python 3.5.0 (default, Oct 3 2015, 10:40:38) [GCC 4.2.1 Compatible FreeBSD Clang 3.4.1

[issue21373] robotparser: Automatically call modified function in read()

Berker Peksag added the comment: This is already fixed by changeset 4ea86cd87f95 in issue 21469 (2.7 and 3.4+). Thanks for the report and for the patch. -- nosy: +berker.peksag resolution: -> out of date stage: -> resolved status: open -> closed __

[issue25300] Enable Intel MPX (Memory protection Extensions) feature

Antoine Pitrou added the comment: > This means that when you perform a malloc, the pointer bounds will be set > inside the malloc call, and then passed on to your variable. For this to be useful in Python, you would have to annotate Python's small object allocator to designate it as a malloc()

[issue16099] robotparser doesn't support request rate and crawl delay parameters

Roundup Robot added the comment: New changeset dbed7cacfb7e by Berker Peksag in branch 'default': Issue #16099: RobotFileParser now supports Crawl-delay and Request-rate https://hg.python.org/cpython/rev/dbed7cacfb7e -- nosy: +python-dev ___ Python tr

[issue25311] Add f-string support to tokenize.py

Eric V. Smith added the comment: Yes, both 'fr' and 'rf' need to be supported (and all upper/lower variants). And in the future, maybe 'fb' (and 'rfb', 'bfr', ...). Unfortunately, the regex doesn't scale well for all of the combinations. -- ___ Pyth

[issue25300] Enable Intel MPX (Memory protection Extensions) feature

Florin Papa added the comment: No modifications need to be made to the small object allocator. The malloc situation was just an example, it does not mean that setting pointer bounds occurs only in a malloc call. It also occurs when you declare a static array or when you initialize a new pointe

[issue25300] Enable Intel MPX (Memory protection Extensions) feature

Antoine Pitrou added the comment: The small object allocator uses large mmap-allocated arenas of 256 KB (IIRC) and carves small objects out of it. So unless the pointer returned by PyObject_Malloc() has its bounds set manually using one of the intrinsic functions (*), MPX would believe the bo

[issue16099] robotparser doesn't support request rate and crawl delay parameters

Berker Peksag added the comment: I've finally committed your patch to default. Thank you for not giving up, Nikolay :) Note that currently the link in the example section doesn't work. I will open a new issue for that. -- resolution: -> fixed stage: patch review -> resolved status: o

[issue25300] Enable Intel MPX (Memory protection Extensions) feature

STINNER Victor added the comment: FYI In the discussion of the PEP 445 "Add new APIs to customize Python memory allocators" it was proposed to add runtime option to choose the memory allocator. At least for debug purpose, it would help to be able to use malloc() for *all* Python memory allocation

[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming

Alex Warhawk added the comment: I have re-targeted the patch for 3.6. It is not a 1 to 1 port of the prior one, but quite similar. -- Added file: http://bugs.python.org/file40716/implement_ssl_session_reuse_3.6.patch ___ Python tracker

[issue25341] File mode wb+ appears as rb+

Changes by Mahmoud Hashemi : -- nosy: +mahmoud ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue21475] Support the Sitemap extension in robotparser

Berker Peksag added the comment: The Crawl-delay part(issue 16099) is now committed. -- stage: -> needs patch title: Support the Sitemap and Crawl-delay extensions in robotparser -> Support the Sitemap extension in robotparser versions: +Python 3.6 -Python 3.5

[issue25300] Enable Intel MPX (Memory protection Extensions) feature

Florin Papa added the comment: Hi Antoine, I understand the problem with the small object allocator now. I will have a closer look at it and come back with a solution. Thank you for pointing this out. -- ___ Python tracker

[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming

Christian Heimes added the comment: Thanks for your patch. There might be a simpler way. By default a SSLContext only caches server sessions. You can enable client session caching with: SSL_CTX_set_session_cache_mode(ctx, SSL_SESS_CACHE_CLIENT) This may be sufficient for FTP over TLS since b

[issue25342] json

Changes by Remi Pointel : -- nosy: rpointel priority: normal severity: normal status: open title: json ___ Python tracker ___ ___ Pyth

[issue25342] json

New submission from Stéphane Wirtel: What the details of this issue? On 8 Oct 2015, at 13:57, Remi Pointel wrote: > Changes by Remi Pointel : > > > -- > nosy: rpointel > priority: normal > severity: normal > status: open > title: json > > ___ > Python

[issue25342] json

Remi Pointel added the comment: Sorry I clicked on "create" before adding info in comment. When I run the test_json suite on OpenBSD, I have a segfault: $ egdb ./python GNU gdb (GDB) 7.10 Copyright (C) 2015 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

[issue25342] test_json segfault on OpenBSD

Changes by Remi Pointel : -- title: json -> test_json segfault on OpenBSD ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue25336] Segmentation fault on Mavericks consistent crashing of software: Please HELP!!!!!

New submission from CM: Process: Python [556] Path: /opt/local/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python Identifier: Python Version: 2.7.10 (2.7.10) Code Type: X86-64 (Native) Parent Process: bash [510] Resp

[issue25342] test_json segfault on OpenBSD

Remi Pointel added the comment: It fails on test_endless_recursion: $ LD_LIBRARY_PATH=. PYTHONPATH=./Lib/ ./python ./Lib/test/test_json -v test_endless_recursion (test.test_json.test_recursion.TestPyRecursion) ... zsh: segmentation fault (core dumped) -- _

[issue25342] test_json segfault on OpenBSD

Stefan Krah added the comment: Try setting the stack size to 8MB (the default on Linux) in login.conf. -- nosy: +skrah ___ Python tracker ___

[issue25342] test_json segfault on OpenBSD

Remi Pointel added the comment: It's good when I entered "ulimit -s 8192". Sorry for the noise... -- ___ Python tracker ___ ___ Python

[issue25338] urllib bypasses all hosts if proxyoverride includes an empty element

R. David Murray added the comment: How does IE itself behave in this case? Also, we should have a test to go along with the fix. -- nosy: +r.david.murray stage: -> test needed title: urllib fail to check host whether it should be bypassed -> urllib bypasses all hosts if proxyoverride

[issue25342] test_json segfault on OpenBSD

Stefan Krah added the comment: It's not noise, we also have problems on Windows with test_json. In theory we should set Py_DEFAULT_RECURSION_LIMIT in Python/ceval.c to appropriate values for the default OS stack sizes in order to get a proper RuntimeError instead of a segfault. For OpenBSD it's

[issue25342] test_json segfault on OpenBSD

STINNER Victor added the comment: Would it be possible to compute the recursion limit depending on the current maximum C stack size? At least estimate it? I guess the sys.getdefaultlimit() is 1000 is an arbitrary value. I also know that the effective limit depends on the memory allocated on th

[issue25342] test_json segfault on OpenBSD

Stefan Krah added the comment: The ratio (1000/8MB) seems to be stable on Linux. Perhaps we could write a getrlimit program for ./configure to get the stack size and adjust the recursion limit to keep the ratio the same. It's just an estimate of course. -- _

[issue25342] test_json segfault on OpenBSD

Stefan Krah added the comment: Or did you want to compute it at runtime? Actually, why not? -- ___ Python tracker ___ ___ Python-bugs

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Sebastian Rittau added the comment: Is there any progress on this? The fix seems trivial. -- ___ Python tracker ___ ___ Python-bugs-li

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue25228] Regression in cookie parsing with brackets and quotes

Pathangi Jatinshravan added the comment: Hi, I've made the change to use str.find() and removed the while loop, can you take a look at it? -- Added file: http://bugs.python.org/file40717/patch.diff ___ Python tracker

[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming

Alex Warhawk added the comment: Thanks for the heads up Christian I'll try enabling client session caching. If this does not work I'll try to adapt the patch to only allow session reusing within the same context. -- ___ Python tracker

[issue25008] Deprecate smtpd (based on deprecated asyncore/asynchat): write a new smtp server with asyncio

Changes by neic : -- nosy: +neic ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailma

[issue5380] pty.read raises IOError when slave pty device is closed

Xavier de Gaye added the comment: TLPI (The Linux Programming Interface book) says about the pty implementation on linux, at section 5 of chapter 64: If we close all file descriptors referring to the pseudoterminal slave, then: a) A read() from the master device fails with the error EI

[issue25343] Document atomic operations on builtin types

Changes by Dima Tisnek : -- assignee: -> docs@python components: +Documentation nosy: +docs@python type: -> enhancement ___ Python tracker ___ _

[issue25343] Document atomic operations on builtin types

New submission from Dima Tisnek: Please document what builtin type operations are actually atomic. For example, what set() operations are atomic? (There are some blogs / tutorials online, but information is outdated and not authoritative) -- messages: 252545 nosy: Dima.Tisnek priority:

[issue25157] Installing Python 3.5.0 32bit on Windows 8.1 64bit system gives Error 0x80240017

Steve Dower added the comment: Shirshendu - any luck with eryksun's suggestions? -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue25342] test_json segfault on OpenBSD

STINNER Victor added the comment: Stefan Krah added the comment: > Or did you want to compute it at runtime? Actually, why not? I'm asking to adjust the limit at _runtime_. getrlimit() is not something static, it's common to modify them manually for the current shell process (and child process)

[issue24848] Warts in UTF-7 error handling

Serhiy Storchaka added the comment: The difference between 2.7 and 3.x is that 2.7 uses isalnum() in IS_BASE64, and 3.x test concrete ranges. Therefore depending on platform and locale 2.7 can accept wrong bytes as BASE64 characters and return incorrect result. Following patch makes 2.7 code t

[issue25161] Missing periods at the end of sentences

TAKASE Arihiro added the comment: Thank you for reviewing. This is an updated patch for 3.x. -- Added file: http://bugs.python.org/file40718/periods_v2.patch ___ Python tracker

[issue25342] test_json segfault on OpenBSD

Serhiy Storchaka added the comment: Duplicates and related issues: issue25329, issue25222, issue24999, issue22984, issue18075, issue12980. -- nosy: +serhiy.storchaka ___ Python tracker

[issue25161] Missing periods at the end of sentences

TAKASE Arihiro added the comment: And this is an updated patch for 2.7. -- Added file: http://bugs.python.org/file40720/periods-2.7_v2.patch ___ Python tracker ___ __

[issue23919] [Windows] test_os fails several C-level assertions

Roundup Robot added the comment: New changeset 69c4fa62b608 by Steve Dower in branch '3.5': Issue #23919: Prevents assert dialogs appearing in the test suite. https://hg.python.org/cpython/rev/69c4fa62b608 New changeset 62897db9ae51 by Steve Dower in branch 'default': Issue #23919: Prevents asse

[issue23919] [Windows] test_os fails several C-level assertions

Changes by Steve Dower : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue25157] Installing Python 3.5.0 32bit on Windows 8.1 64bit system gives Error 0x80240017

Shirshendu Bhowmick added the comment: Installing that update the system says this update is not applicable for your computer and it does not generates any .evtx file. -- ___ Python tracker ___

[issue5380] pty.read raises IOError when slave pty device is closed

Guido van Rossum added the comment: Honestly, Antoine's patch looks reasonable to me (except that the names of the test modules perpetuate the confusion that pipes and ptys are similar). Can someone just port that to 3.6? (The change in semantics is big enough that I don't think we should shov

[issue25089] Can't run Python Launcher on Windows

Roundup Robot added the comment: New changeset 1e99ba6b7c98 by Steve Dower in branch '3.5': Issue #25089: Adds logging to installer for case where launcher is not selected on upgrade. https://hg.python.org/cpython/rev/1e99ba6b7c98 -- nosy: +python-dev __

[issue25089] Can't run Python Launcher on Windows

Steve Dower added the comment: Hopefully with the extra logging we'll be able to see if something is failing at the point of detection. Any failure here (permissions in registry, etc.) will cause the launcher to not be installed on upgrade (which might be the same as removing it... I need to s

[issue25344] Enhancement to Logging - Logging Stack

New submission from David Silverman: It would be useful to have the ability to push logs onto a stack. This way you can log events to the stack. If an error occurred, you could pop the stack and output the log events. If no error occurred, you could pop the stack and discard the logs. An exam

[issue25157] Installing Python 3.5.0 32bit on Windows 8.1 64bit system gives Error 0x80240017

eryksun added the comment: > it does not generates any .evtx file Start a command prompt; change to the directory that has the MSU, and run it with the option "/log:kb2999226.evtx". For me this creates kb2999226.evtx in the current directory, which can be converted to XML using wevtutil. If th

[issue25343] Document atomic operations on builtin types

Brett Cannon added the comment: We actually don't have any guarantees written down because we have never formalized them. It was discussed at the PyCon language summit this past year -- https://lwn.net/Articles/640177/ -- but it didn't lead to anyone writing a proposal to formalize the memory

[issue25344] Enhancement to Logging - Logging Stack

R. David Murray added the comment: I'm guessing you could write a custom hander that would do that. It might be something more suited for a recipe or pypi package. -- nosy: +r.david.murray, vinay.sajip ___ Python tracker

[issue25343] Document atomic operations on builtin types

R. David Murray added the comment: I wonder...personally I prefer to program in asyncio style rather than threading style, where one doesn't have to worry about atomicity. Maybe Python shouldn't make any atomicity guarantees. -- nosy: +r.david.murray _

[issue24848] Warts in UTF-7 error handling

STINNER Victor added the comment: The patch looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25345] Unable to install Python 3.5 on Windows 10

New submission from Gowtham Nm: I downloaded Python 3.5 version to install on Windows 10. But apparently, the installation does not succeed. I have tried with lower version of Python also, the installation does not succeed on Windows 10. Have attached the logs of the error. I have checked for

[issue25346] test_regrtest fails because 'sys' is not imported.

Changes by Anish Shah : -- components: Tests files: test_regrtest.patch keywords: patch nosy: Anish Shah, python-dev, steve.dower priority: normal severity: normal status: open title: test_regrtest fails because 'sys' is not imported. versions: Python 3.6 Added file: http://bugs.python.o

[issue25346] test_regrtest fails because 'sys' is not imported.

New submission from Steve Dower: Fixed in ee1ef5a97e8f -- assignee: -> steve.dower resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ __

[issue25345] Unable to install Python 3.5 on Windows 10

eryksun added the comment: Please attach "Python 3.5.0 (32-bit)_*_core_JustForMe.log", if it exists. According to the log, initially the installer can't create a restore point because, I assume, you have the volume shadow copy (VSS) service disabled, i.e. the error code is ERROR_SERVICE_DISABL

[issue24177] Add https?_proxy support to http.client

Demian Brecht added the comment: Yeah, agreed that it should be opt-in, at least until a major release. I've run into a couple cases where higher level libraries use http.client (or httplib) directly, but don't expose the client directly (not that they should anyways). Because of that, there a

[issue25328] ValueError in smtpd.py __init__() is not raised

Mauro S. M. Rodrigues added the comment: Hi Barry, I was testing this and it seems to work, am I doing something wrong in order to reproduce it? I've used the same parameters from the unit tests Python 3.5.0+ (3.5:1e99ba6b7c98, Oct 8 2015, 17:12:06) [GCC 4.8.4] on linux Type "help", "copyrigh

[issue25328] ValueError in smtpd.py __init__() is not raised

Barry A. Warsaw added the comment: On Oct 08, 2015, at 08:44 PM, Mauro S. M. Rodrigues wrote: >Python 3.5.0+ (3.5:1e99ba6b7c98, Oct 8 2015, 17:12:06) >[GCC 4.8.4] on linux >Type "help", "copyright", "credits" or "license" for more information. import smtpd smtpd.SMTPServer(("127.0.0.

[issue25347] assert_has_calls output is formatted inconsistently

New submission from Robert Zimmerman: For longer lists of calls, the "Expected" list is printed all on one line while the "Actual" list is pprinted and on multiple lines. This makes it hard to do a visual compare of which calls are missing/incorrect. Example: AssertionError: Calls not fou

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

Roundup Robot added the comment: New changeset 1a2175149c5e by Victor Stinner in branch 'default': Issue #25318: Add _PyBytesWriter API https://hg.python.org/cpython/rev/1a2175149c5e -- nosy: +python-dev ___ Python tracker

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

STINNER Victor added the comment: Oh, I was surprised to see same or worse performances for UTF-8/backslashreplace. In fact, I forgot to enable overallocation. With overallocation, it is now faster ;-) I modified the API to put the "stack buffer" inside _PyBytesWriter API directly. I also rew

[issue25348] Update pgo_build.bat to use --pgo flag for regrtest

New submission from Brett Cannon: Should upgrade the command to do what is already occurring in the Makefile for consistency. -- assignee: brett.cannon components: Windows messages: 252572 nosy: brett.cannon, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: norm

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

Roundup Robot added the comment: New changeset 59f4806a5add by Victor Stinner in branch 'default': Optimize backslashreplace error handler https://hg.python.org/cpython/rev/59f4806a5add -- ___ Python tracker __

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

Roundup Robot added the comment: New changeset c134eddcb347 by Victor Stinner in branch 'default': Issue #25318: Move _PyBytesWriter to bytesobject.c https://hg.python.org/cpython/rev/c134eddcb347 -- ___ Python tracker

[issue25343] Document atomic operations on builtin types

Raymond Hettinger added the comment: > what set() operations are atomic? The language doesn't make any guarantees about set operation atomicity. Different implementations such as PyPy, Jython, and IronPython are free to make different choices than CPython. In general, users should make no as

[issue25344] Enhancement to Logging - Logging Stack

Raymond Hettinger added the comment: This seems like a reasonable use case and is worth considering. Offhand, I don't see how a user could easily implement this on their own without hacking the logging module internals. What would be needed is some support for begin-logging-transaction, a ser

[issue17908] Unittest runner needs an option to call gc.collect() after each test

Changes by Raymond Hettinger : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue25349] Use _PyBytesWriter for bytes%args

New submission from STINNER Victor: Attached patch is a work-in-progress patch to use the new private _PyBytesWriter API in bytes % args. The usage of the _PyBytesWriter API will allow further optimization. For example, it avoids the creation of a temporary bytes object to format b'%f' % 1.2.

[issue25349] Use _PyBytesWriter for bytes%args

STINNER Victor added the comment: See also the PEP 461 "Adding % formatting to bytes and bytearray". FYI bytes % args is tested by test_format (good to know to test quickly changes). -- ___ Python tracker ___

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

STINNER Victor added the comment: I created the issue #25349 "Use _PyBytesWriter for bytes%args". -- ___ Python tracker ___ ___ Python

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

Roundup Robot added the comment: New changeset e9c1404d6bd9 by Victor Stinner in branch 'default': Issue #25318: Fix compilation error https://hg.python.org/cpython/rev/e9c1404d6bd9 -- ___ Python tracker __

[issue25326] Improve error message for "character buffer objects"

Roundup Robot added the comment: New changeset 4d1bd86d3bbd by Raymond Hettinger in branch '2.7': Issue #25326: Improve an obscure error message. https://hg.python.org/cpython/rev/4d1bd86d3bbd -- nosy: +python-dev ___ Python tracker

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

STINNER Victor added the comment: The FreeBSD 9.x buildbot is grumpy. http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.x/builds/3495/steps/test/logs/stdio Assertion failed: (start[writer->allocated] == 0), function _PyBytesWriter_CheckConsistency, file Objects/bytesobject.c, l

[issue25326] Improve error message for "character buffer objects"

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue25318] Add _PyBytesWriter API to optimize Unicode encoders

Roundup Robot added the comment: New changeset 9cf89366bbcb by Victor Stinner in branch 'default': Issue #25318: Avoid sprintf() in backslashreplace() https://hg.python.org/cpython/rev/9cf89366bbcb New changeset 0a522f68d275 by Victor Stinner in branch 'default': Issue #25318: Fix backslashrepla

[issue25344] Enhancement to Logging - Logging Stack

Changes by Adam : -- nosy: +azsorkin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/ma

[issue25228] Regression in cookie parsing with brackets and quotes

Martin Panter added the comment: The str.find() call was kind of what I had in mind. But I don’t feel qualified to say whether the fix is good in general. I would have to find out about at the Cookie header format, and understand what the security implications are to do with lax parsing.

[issue25298] Add lock and rlock weakref tests

Roundup Robot added the comment: New changeset 45903695e86c by Raymond Hettinger in branch 'default': Issue #25298: Add lock and rlock weakref tests (Contributed by Nir Soffer). https://hg.python.org/cpython/rev/45903695e86c -- nosy: +python-dev ___

[issue25298] Add lock and rlock weakref tests

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue25315] Make it clear in the collections Python source code that OrderedDict may be overridden

Changes by Raymond Hettinger : -- resolution: -> not a bug status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5380] pty.read raises IOError when slave pty device is closed

Martin Panter added the comment: My biggest worry about the patch is that it looks like it will mask other EIO errors from normal terminals (e.g. perhaps reading from a slave or a real serial port can also produce an EIO error that does not mean EOF). Another option may be to add a specialized

[issue5380] pty.read raises IOError when slave pty device is closed

Guido van Rossum added the comment: So maybe we should just close this as won't fix. Whoever wants to use the master end of a pty had better be prepared for that IOError. On Thursday, October 8, 2015, Martin Panter wrote: > > Martin Panter added the comment: > > My biggest worry about the patc

[issue5380] pty.read raises IOError when slave pty device is closed

Changes by Márcio : -- nosy: -marcio ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/ma

[issue25350] Stronger type enforcement (feature request)

New submission from John Michael Lafayette: With a lot of languages, I can tell that the type I am getting is an instance of the declared type I'm assigning it to. Example: Cat c = Factory.make("cat" Animal d = Factory.make("dog") Python: val c = Factory.make("cat") Problem with this is that

[issue25328] ValueError in smtpd.py __init__() is not raised

Xiang Zhang added the comment: I think this is a typo. The raise is left out. In test_smtpd.py, it only tests the raise condition in SMTPServer but not STMPChannel. I add the raise and a corresponding test in SMTPDChannelTest. -- keywords: +patch nosy: +xiang.zhang Added file: http://b