[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Serhiy, do you see anything actually wrong with the patch? If it isn't broken in some clear cut way, I'm going to apply it shortly. The comparison with dict internals is a red herring -- there is no promise need or precedent for making that code exactly t

[issue24620] Segfault with nonsensical random state

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: This is ready to apply. -- assignee: rhettinger -> serhiy.storchaka ___ Python tracker ___ ___ Py

[issue24659] dict() built-in fails on iterators with a "keys" attribute

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- priority: normal -> low stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch makes set_add_entry() inconsistent not only with dict, but with other set methods that use set_lookkey(). I don't know if there is some subtle bug here, but I feel myself slightly uncomfortable with it. Also the new code looks a little less readabl

[issue24302] Dead Code of Handler check in function faulthandler_fatal_error()

2015-07-23 Thread Pankaj Sharma
Changes by Pankaj Sharma : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue24620] Segfault with nonsensical random state

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0933c00c2765 by Serhiy Storchaka in branch '3.4': Issue #24620: Random.setstate() now validates the value of state last element. https://hg.python.org/cpython/rev/0933c00c2765 New changeset 84070c1225c5 by Serhiy Storchaka in branch '2.7': Issue #24

[issue24620] Segfault with nonsensical random state

2015-07-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

<    1   2