[issue24264] imageop Unsafe Arithmetic

New submission from JohnLeitch: Several functions within the imageop module are vulnerable to exploitable buffer overflows due to unsafe arithmetic in check_multiply_size(). The problem exists because the check to confirm that size == product / y / x does not take remainders into account. sta

[issue24263] Why VALID_MODULE_NAME in unittest/loader.py is r'[_a-z]\w*\.py$' not r'\w+\.py$' ?

Changes by Ned Deily : -- components: -Unicode nosy: +rbcollins versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker ___

[issue22107] tempfile module misinterprets access denied error on Windows

eryksun added the comment: > My reluctance to commit the os.access patch is because it will > cause such a behaviour change in a function which has been > pretty stable for a long while. The original behavior could be preserved as the default. A keyword-only argument could enable checking ac

[issue22107] tempfile module misinterprets access denied error on Windows

Tim Golden added the comment: That is a possibility which hadn't occurred to me. @eryksun, would you mind eyeballing the patch over on issue2582? It almost certainly won't apply cleanly as it's been almost two years since I last refreshed it, but you can hopefully gauge the intent. -- _

[issue24221] Clean-up and optimization for heapq siftup() and siftdown()

Roundup Robot added the comment: New changeset 490720fc1525 by Raymond Hettinger in branch 'default': Issue #24221: Small optimizations for heapq. https://hg.python.org/cpython/rev/490720fc1525 -- nosy: +python-dev ___ Python tracker

[issue24221] Clean-up and optimization for heapq siftup() and siftdown()

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue24221] Clean-up and optimization for heapq siftup() and siftdown()

Stefan Behnel added the comment: There are calls to PyObject_RichCompareBool() in the loops, which means that user code might get executed. What if that's evil code that modifies the heap list? Couldn't that lead to list resizing and thus invalidation of the list item pointer? -- nosy

[issue24219] Repeated integer in Lexical analysis/Integer literals section

Dmitry Kazakov added the comment: Please, do tell me if I'm wrong deleting that literal and it actually serves some purpose... -- ___ Python tracker ___

[issue23969] please set a SOABI for MacOSX

Ned Deily added the comment: Ronald, the change to set the SOABI was pushed several weeks ago (but, because I left out a #, the commit message did not also show up here as I intended): New changeset 32c24eec035f by Ned Deily in branch 'default': Issues #22980, 23969: For OS X, use PEP 3149-styl

[issue24264] imageop Unsafe Arithmetic

Changes by Ned Deily : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue24257] Incorrect use of PyObject_IsInstance

Roundup Robot added the comment: New changeset bccaba8a5482 by Serhiy Storchaka in branch '2.7': Issue #24257: Fixed segmentation fault in sqlite3.Row constructor with faked https://hg.python.org/cpython/rev/bccaba8a5482 New changeset c7b9645a6f35 by Serhiy Storchaka in branch '3.4': Issue #2425

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

Martin Panter added the comment: Looks good in general. I think the signatures in Doc/library/tempfile.rst need updating for the following functions (possibly also version changed notices added somewhere): * NamedTemporaryFile * TemporaryFile * SpooledTemporaryFile * TemporaryDirectory --

[issue24257] Incorrect use of PyObject_IsInstance

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue24221] Clean-up and optimization for heapq siftup() and siftdown()

Serhiy Storchaka added the comment: The list item pointer is updated just after calling PyObject_RichCompareBool(). The code LGTM. -- ___ Python tracker ___

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

Rolf Krahl added the comment: I disagree. I believe that the suggested modification of AbstractHTTPHandler.do_request_() belongs into this change set for the following reasons: 1. "This module [http.client] defines classes which implement the client side of the HTTP and HTTPS protocols. It

[issue24265] IDLE produces error message when run with both -s and -c.

New submission from ppperry: When I run "python -m idlelib.idle -sc [command] from the command line, IDLE runs the startup file, but then pops up an error message saying "the Python Shell window is already executing a command;please wait until it is finished." When the error window is closed,

[issue24265] IDLE produces error message when run with both -s and -c.

Changes by ppperry : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue24262] logging.FileHandler.close() is not thread-safe

Changes by R. David Murray : -- resolution: fixed -> out of date stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list maili

[issue24219] Repeated integer in Lexical analysis/Integer literals section

R. David Murray added the comment: I believe you are correct. -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mai

[issue24221] Clean-up and optimization for heapq siftup() and siftdown()

Stefan Behnel added the comment: Ah, sorry, yes. I somehow misread the arguments being passed *into* richcompare as subsequent array access. LGTM too. Sorry for the noise. -- ___ Python tracker ___

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

Berker Peksag added the comment: Another alternative is using assertWarnsRegex. -- nosy: +berker.peksag ___ Python tracker ___ ___ Pyt

[issue24266] raw_input function (with readline): Ctrl+C (during search mode but not only) leaves readline in broken state

New submission from sping: Hi! A college of mine ran into a bug with raw_input. We have a shell derived from stdlib module "cmd" here but the bug shows with plain raw_input, as well (see demo code). For the symptoms: the shell is executing commands from history that the user explicitly chose n

[issue24266] raw_input function (with readline): Ctrl+C (during search mode but not only) leaves readline in broken state

Changes by sping : Added file: http://bugs.python.org/file39468/raw_input__minimal.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

Roundup Robot added the comment: New changeset 2771a0ac806b by Yury Selivanov in branch 'default': Issue 24237: Raise PendingDeprecationWarning per PEP 479 https://hg.python.org/cpython/rev/2771a0ac806b -- nosy: +python-dev ___ Python tracker

[issue22906] PEP 479: Change StopIteration handling inside generators

Roundup Robot added the comment: New changeset 2771a0ac806b by Yury Selivanov in branch 'default': Issue 24237: Raise PendingDeprecationWarning per PEP 479 https://hg.python.org/cpython/rev/2771a0ac806b -- ___ Python tracker

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

Yury Selivanov added the comment: Nick, I updated the code to use assertWarnsRegex (thanks for suggestion, Berker!) Closing the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22906] PEP 479: Change StopIteration handling inside generators

Roundup Robot added the comment: New changeset c8a3e49f35e7 by Yury Selivanov in branch 'default': docs: Mention PEP 479 in whatsnew. https://hg.python.org/cpython/rev/c8a3e49f35e7 -- ___ Python tracker ___

[issue24180] PEP 492: Documentation

Yury Selivanov added the comment: Closing this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue24056] Expose closure & generator status in function repr()

Yury Selivanov added the comment: Nick, Berker, a kind reminder -- please review the patch if we want to have it in 3.5. -- ___ Python tracker ___ __

[issue20438] inspect: Deprecate getfullargspec?

Changes by Yury Selivanov : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs

[issue20438] inspect: Deprecate getfullargspec?

Roundup Robot added the comment: New changeset 3a5fec5e025d by Yury Selivanov in branch 'default': Issue 20438: Deprecate inspect.getargspec() and friends. https://hg.python.org/cpython/rev/3a5fec5e025d -- nosy: +python-dev ___ Python tracker

[issue23699] Add a macro to ease writing rich comparisons

Petr Viktorin added the comment: Just a reminder: if you want this to be in Python 3.5, please review the patch -- ___ Python tracker ___

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

Demian Brecht added the comment: FWIW, I was intending to address the issues Rolf raised. Also, I agree that a patch shouldn't knowingly have negative knock-on effects to dependents. -- ___ Python tracker

[issue24056] Expose closure & generator status in function repr()

Berker Peksag added the comment: I'm not the ideal candidate to review the second patch since I'm not familiar with the best practices of C :) -- nosy: +serhiy.storchaka ___ Python tracker

[issue24204] string.strip() documentation is misleading

Terry J. Reedy added the comment: With 'leading end' and 'trailing end' replaced by 'left and 'right', the addition looks good to me. -- nosy: +terry.reedy ___ Python tracker __

[issue20035] Clean up Tcl library discovery in Tkinter on Windows

Roundup Robot added the comment: New changeset 951318b651be by Zachary Ware in branch 'default': Issue #20035: Reimplement tkinter._fix module as a C function. https://hg.python.org/cpython/rev/951318b651be -- ___ Python tracker

[issue20035] Clean up Tcl library discovery in Tkinter on Windows

Zachary Ware added the comment: Committed, thanks for the reviews, Serhiy and Steve! -- assignee: -> zach.ware resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue24209] Allow IPv6 bind in http.server

Changes by Demian Brecht : -- nosy: +demian.brecht ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24234] Should we define complex.__complex__ and bytes.__bytes__?

Terry J. Reedy added the comment: To my understanding, the presence of int.__int__ and float.__float__ are implementation issues. I presume that float(ob) just calls ob.__float__ without slowing down for an isinstance(ob, float) check. Ditto for int(ob). The processing for complex(args) and

[issue16991] Add OrderedDict written in C

Jim Jewett added the comment: Why does generated file Include/opcode.h show up as changed? It looks like pure whitespace, but I wonder if a similar whitespace change might be making something a space too long somewhere. -- nosy: +Jim.Jewett ___ Pyt

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Terry J. Reedy added the comment: 3.2 and 3.3 only get security fixes. I condensed the title to be visible in display boxes. It would help if you signed the PSF Contributor Agreement https://www.python.org/psf/contrib/ https://www.python.org/psf/contrib/contrib-form/ and contributed a usable p

[issue24056] Expose closure & generator status in function repr()

Serhiy Storchaka added the comment: I like the look of the repr Terry proposes better. For generator objects the repr is either "" or "". "" and "" would be consistent with this. It also shows the relation and the difference between the generator function and the generator object. Yet one ar

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Serhiy Storchaka added the comment: This behavior annoyed me long time, but I had no idea how to fix this. -- nosy: +pitrou, serhiy.storchaka ___ Python tracker ___ _

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

Gregory P. Smith added the comment: updated, thanks for the great reviews. -- Added file: http://bugs.python.org/file39469/issue24230-gps03.diff ___ Python tracker ___ __

[issue20438] inspect: Deprecate getfullargspec?

Berker Peksag added the comment: Just a minor comment on the patch: +warnings.warn("inspect.getargspec() is deprecated, " + "use inspect.signature() instead", DeprecationWarning) Can you also add "stacklevel=2"? -- nosy: +berker.peksag

[issue16991] Add OrderedDict written in C

Eric Snow added the comment: Include/opcode.h shouldn't be in the change (and won't be when committed). I'm guessing it being there is related to one of the recent merges I did from default into the feature branch. -- ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Roundup Robot added the comment: New changeset 666e5b554f32 by Yury Selivanov in branch 'default': Issue 20438: Adjust stacklevel of inspect.getargspec() warning. https://hg.python.org/cpython/rev/666e5b554f32 -- ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Roundup Robot added the comment: New changeset 621e98bfc74b by Yury Selivanov in branch 'default': Issue 20438: Add a note about deprecating old inspect APIs to whatsnew. https://hg.python.org/cpython/rev/621e98bfc74b -- ___ Python tracker

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: Thanks Berker! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue20438] inspect: Deprecate getfullargspec?

Yury Selivanov added the comment: I'm copying/pasting my latest commit message on this issue here: """Add a note about deprecating old inspect APIs to whatsnew. Also, deprecate formatargspec, formatargvalues, and getargvalues functions. Since we are deprecating 'getfullargspec' function in 3.5

[issue23509] Speed up Counter operators

Raymond Hettinger added the comment: Sorry, I don't want to any of these changes (though it is a close call on a couple of them). Before the particulars, here are some high-level thoughts (not definitive). I would like to confine the optimizations and complexities to the more important parts

[issue24204] string.strip() documentation is misleading

Raymond Hettinger added the comment: This patch looks reasonable. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mai

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

Roundup Robot added the comment: New changeset 254b8e68959e by Steve Dower in branch 'default': Issue 24244: Prevents termination when an invalid format string is encountered on Windows. https://hg.python.org/cpython/rev/254b8e68959e -- nosy: +python-dev ___

[issue23955] Add python.ini file for embedded/applocal installs

Roundup Robot added the comment: New changeset 620a247b4960 by Steve Dower in branch 'default': Issue #23955: Add pyvenv.cfg option to suppress registry/environment lookup for generating sys.path. https://hg.python.org/cpython/rev/620a247b4960 -- nosy: +python-dev _

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

Steve Dower added the comment: That handles Python 3.5 and future versions, even if the supported formats change. Is there something that needs fixing in 3.4? I don't get a crash, just the ValueError... -- ___ Python tracker

[issue23955] Add python.ini file for embedded/applocal installs

Steve Dower added the comment: The support is in and the option remains named "applocal". Hopefully this (and the ZIP file version, which will include the preconfigured pyvenv.cfg) will help with app distributions, though I'm still open to make changes if it doesn't. -- resolution: -

[issue23970] Update distutils.msvccompiler for VC14

Steve Dower added the comment: We don't strictly need this for beta 1, but I'd like to get it in. Final call for feedback (I'll probably hold off checking in until tomorrow morning, ~18 hours from now) -- ___ Python tracker

[issue24056] Expose closure & generator status in function repr()

Raymond Hettinger added the comment: > It's mostly pedagogical - similar to "normal functions" > vs "generator functions", I see a need for this but object to calling it a "generator" rather than a "function that makes a generator" or "generator creating function" or somesuch. There is a hug

[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog

Roundup Robot added the comment: New changeset 117af4bc0513 by Benjamin Peterson in branch '2.7': make idlever.py self-updating (closes #24199) https://hg.python.org/cpython/rev/117af4bc0513 -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed _

[issue16991] Add OrderedDict written in C

Eric Snow added the comment: Just to narrow things down a bit further, the failure happens specifically under ConfigParserTestCaseNoValue: PYTHONHASHSEED=7 ./python -m unittest test.test_configparser.ConfigParserTestCaseNoValue.test_basic -v -- ___

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Martin Panter added the comment: Also applies to the interactive interpreter mode. -- nosy: +vadmium ___ Python tracker ___ ___ Python

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

Roundup Robot added the comment: New changeset 870899ce71f4 by Gregory P. Smith in branch 'default': Issue 24230: The tempfile module now accepts bytes for prefix, suffix and dir https://hg.python.org/cpython/rev/870899ce71f4 -- nosy: +python-dev ___

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

Gregory P. Smith added the comment: that should take care of it. if you see any other issues with this post commit, either raise them here or fix them directly. the reviews were helpful. -- resolution: -> fixed stage: patch review -> commit review status: open -> closed

[issue24219] Repeated integer in Lexical analysis/Integer literals section

Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list ma

[issue16991] Add OrderedDict written in C

Eric Snow added the comment: If I still the following at Lib/test/test_configparser.py:328: print(len(cf._proxies), len(list(cf._proxies)), list(cf._proxies)) print(len(cf._sections), len(list(cf._sections)), list(cf._sections)) I get unexpected results that are a clear indication of a prob

[issue24219] Repeated integer in Lexical analysis/Integer literals section

Roundup Robot added the comment: New changeset 645a03e93008 by Raymond Hettinger in branch '3.4': Issue #24219: Remove duplicate literal in docs. https://hg.python.org/cpython/rev/645a03e93008 -- nosy: +python-dev ___ Python tracker

[issue24219] Repeated integer in Lexical analysis/Integer literals section

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue22189] collections.UserString missing some str methods

Roundup Robot added the comment: New changeset c06b2480766d by Raymond Hettinger in branch 'default': Issue 22189: Add missing methods to UserString https://hg.python.org/cpython/rev/c06b2480766d -- nosy: +python-dev ___ Python tracker

[issue22189] collections.UserString missing some str methods

Raymond Hettinger added the comment: Thanks Joe. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue24195] Add `Executor.filter` to concurrent.futures

Brian Quinlan added the comment: Ethan: I'm -0 so I'd happily go with the consensus. Does anyone have a strong opinion? Ram: What did you mean by "Possible issues"? Did you mean that to be an example using the executor.map() technique? -- ___ Pytho

[issue23969] please set a SOABI for MacOSX

Matthias Klose added the comment: so what you could do is to define more than one SOABI. The code in Python/dynload_shlib.c reads: "." SOABI ".so", ".abi" PYTHON_ABI_STRING ".so", ".so", so it still recognizes .so names. If you want to recognize architecture specific sonames, then

[issue21448] Email Parser use 100% CPU

Roundup Robot added the comment: New changeset 830bcf4fb29b by Raymond Hettinger in branch 'default': Issue #21448: Improve performance of the email feedparser https://hg.python.org/cpython/rev/830bcf4fb29b -- ___ Python tracker

[issue21448] Email Parser use 100% CPU

Changes by Raymond Hettinger : -- assignee: rhettinger -> resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Pyt

[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)

Matthias Klose added the comment: ping? I would like to get this into 3.5. -- keywords: +needs review -patch ___ Python tracker ___ __

[issue14132] Redirect is not working correctly in urllib2

Martin Panter added the comment: The proposed patch looks good to me. A test case would be nice though. Also I wonder why the “malformed URL” logic needs to be in urllib.request. Surely it either belongs in urljoin(), or in the underlying http.client. That needs more thought, but either way th

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

Augie Fackler added the comment: I just removed my hack that gave us unicode to hand to mkdtemp() and everything still passes with your new commit. Thanks much for the quick response! -- ___ Python tracker ___

[issue23712] Experiment: Assume that exact unicode hashes are perfect discriminators

Raymond Hettinger added the comment: Closing this because it was never an active proposal, just more of a thought experiment that I didn't want to lose track of. -- resolution: -> not a bug status: open -> closed ___ Python tracker

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

Martin Panter added the comment: Okay perhaps a new issue at this stage isn’t the best idea, especially if you want both modules updated at the same time. With the urlopen() API, it currently has no explicit support for file objects. So you either have to make sure they get treated like any ot

[issue12849] Cannot override 'connection: close' in urllib2 headers

Martin Panter added the comment: So far the only reasons that have been given to override this header (mine and the one in Issue 15943) seem to be to work around buggy servers. It is already documented that HTTP 1.1 and “Connection: close” are used, so if this issue is only about working aroun

[issue23086] Add start and stop parameters to the Sequence.index() ABC mixin method

Roundup Robot added the comment: New changeset cabd7261ae80 by Raymond Hettinger in branch 'default': Issue #23086: Add start and stop arguments to the Sequence.index() mixin method. https://hg.python.org/cpython/rev/cabd7261ae80 -- nosy: +python-dev

[issue23086] Add start and stop parameters to the Sequence.index() ABC mixin method

Raymond Hettinger added the comment: Devin, thanks for the patch. Serhiy, I added a performance note discussing the computational complexity. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Raymond Hettinger added the comment: > What is left to do with this issue? Nothing that I can see. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue24209] Allow IPv6 bind in http.server

Martin Panter added the comment: I am no IPv6 expert, but this looks like a reasonable first approximation. The “http.server” module documentation should also be updated to say IPv6 addresses are supported on the command line, and I guess there should be a test case added. But maybe see Lib/s

[issue20215] socketserver can not listen IPv6 address

Martin Panter added the comment: I’m no IPv6 expert, but see Lib/smtpd.py:657 and Issue 14758 for how this sort of thing was done for the SMTP server using getaddrinfo(). I think it is similar to David’s suggestion. I also left a comment about the documentation. And it probably needs a test c

[issue24056] Expose closure & generator status in function repr()

Nick Coghlan added the comment: I don't think we should rush this one, especially as PEP 484 provides the possibility for tools (including educational tools) to infer the appropriate return types for generator and coroutine functions. Bumping the target version to 3.6 accordingly. --

[issue24195] Add `Executor.filter` to concurrent.futures

Nick Coghlan added the comment: I vary between +0 and -0 for the addition of the concrete method. When I'm at +0, the main rationale is that we *don't* have the "Where do we stop?" risk here that itertools faces, as we're just replicating the synchronous builtins. When I'm at -0, the main rat

[issue23969] please set a SOABI for MacOSX

Ned Deily added the comment: "If you want to recognize architecture specific sonames" For OS X we don't have a need to recognize architecture specific sonames because we want to continue to defer to the operating system to make the decisions about which, if any, architecture binary to load fro

[issue24195] Add `Executor.filter` to concurrent.futures

Ethan Furman added the comment: It looks like we are pretty much neutral between the +1's and -1's. Antoine seems to be opposed on general principles against bloat, while I am for it on general principles of completeness. The recipe could still go in the docs for people to use on previous vers

[issue24267] test_venv.EnsurePipTest.test_with_pip version conflict

New submission from Martin Panter: Recently when running the test suite on the code from the default Mercuiral branch, I have been seeing following failure. This only started happening in the last week or two. $ ./python -bWall -m test -v test_venv [. . .] test_with_pip (test.test_venv.EnsureP

[issue24267] test_venv.EnsurePipTest.test_with_pip version conflict

Changes by Ned Deily : -- nosy: +dstufft, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24195] Add `Executor.filter` to concurrent.futures

Raymond Hettinger added the comment: I would like to tip the balance in favor of the -1. Antoine is right about this one. -- nosy: +rhettinger ___ Python tracker ___ __