[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

Raymond Hettinger added the comment: > However, doing the check on 'other' and raising a TypeError > with an appropriate message would still be better Let's be clear. These are duck-typed methods. A type check is inappropriate. Anything with o.items() is allowed regardless of type. Also, I

[issue22725] improve documentation for enumerate() (built-in function)

Raymond Hettinger added the comment: I'm sorry but I do not like the proposed patch at all. The wording is awkward "which when iterated" and has weird terminology "the sequence number". The OP's concern about the *sequence* versus *iterable* parameter name has been addressed (it is part of th

[issue22785] range docstring is less useful than in python 2

Raymond Hettinger added the comment: > Note that Python 3 seems to imply that the end-point is included The Python 2 wording is better in this regard. Also, it would be nice clarify what is meant by "virtual sequence". I know what that means only because I already know what range() does. For

[issue22796] Support for httponly/secure cookies reintroduced lax parsing behavior

Raymond Hettinger added the comment: The patch looks good. One nit, please change "items" to "typed_items" or somesuch. That will make it clear why there are 3-tuples instead of the traditional 2-tuple used for normal mappings. -- nosy: +rhettinger __

[issue21650] add json.tool option to avoid alphabetic sort of fields

Raymond Hettinger added the comment: The patch looks good. One nit, the phrase "sorted by their key" has an odd ring to it and is mildly confusing, though technically correct. Perhaps, "sorted alphabetically by key" would be better for most folks. --

[issue22525] ast.literal_eval() doesn't do what the documentation says

Raymond Hettinger added the comment: Georg's proposed wording reads well and is clearer than the current wording. The patch is ready to apply. -- nosy: +rhettinger ___ Python tracker _

[issue22721] pprint output for sets and dicts is not stable

Raymond Hettinger added the comment: > the primary sort will be on the type of quote used for the repr, > which would be surprising and significantly less useful. How about: repr(obj).strip("'\"") ? Overall, the idea of using repr() in some fashion is appealing because it sorts on what the us

[issue22680] Blacklist FunctionTestCase from test discovery

Michael Foord added the comment: I agree. -- title: unittest discovery is fragile -> Blacklist FunctionTestCase from test discovery ___ Python tracker ___ __

[issue22680] Blacklist FunctionTestCase from test discovery

Changes by Ezio Melotti : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue20597] PATH_MAX already defined on some Windows compilers

Jeffrey Armstrong added the comment: What's to understand? Some compilers, particularly MinGW and Open Watcom, already define a PATH_MAX macro on Windows, and it's not necessarily the same as Python's redefinition of it, possibly causing a compiler error. That's all. Given the time frame tha

[issue22798] time.mktime doesn't update time.tzname

New submission from Akira Li: time.tzname is initialized from C tzname variable or tm_zone around Jan, Jul of the current year. If time.mktime() is called with a time tuple from the past/future then after the call time.tzname might be out-of-sync with the corresponding C tzname and tm_zone va

[issue22798] time.mktime doesn't update time.tzname

Akira Li added the comment: I've attached test-timezone-info-is-updated.diff file -- a patch for Lib/test/test_time.py that demonstrates that time functions fail to update the timezone info. The test uses Europe/Moscow timezone but most timezones around the world had/will have different tznam

[issue19884] Importing readline produces erroneous output

STINNER Victor added the comment: Arfever, Antoine: If buildbots are happy (green), you can close the issue. (I'm answering to your question on IRC ;-)) -- ___ Python tracker __

[issue19753] test_gdb failure on SystemZ buildbot

Roundup Robot added the comment: New changeset 4c260cf1ba39 by Victor Stinner in branch '2.7': Issue #19753: Fix test_gdb on SystemZ buildbot, ignore warnings https://hg.python.org/cpython/rev/4c260cf1ba39 -- ___ Python tracker

[issue19753] test_gdb failure on SystemZ buildbot

STINNER Victor added the comment: > Victor, can this patch be applied to Python 2.7 branch also? Done. I didn't check the buildbots, but I guess that the issue was already fixed one year ago... -- resolution: -> fixed status: open -> closed ___ Pyt

[issue20597] PATH_MAX already defined on some Windows compilers

Roundup Robot added the comment: New changeset 6aaa0aab1e93 by Victor Stinner in branch 'default': Issue #20597: Remove unused definition of PATH_MAX on Windows, MAXPATHLEN is https://hg.python.org/cpython/rev/6aaa0aab1e93 -- nosy: +python-dev ___ Pyt

[issue22798] time.mktime doesn't update time.tzname

Changes by Akira Li <4kir4...@gmail.com>: Added file: http://bugs.python.org/file37134/test_mktime_changes_tzname.c ___ Python tracker ___ ___

[issue20597] PATH_MAX already defined on some Windows compilers

Roundup Robot added the comment: New changeset d6fb87972dee by Victor Stinner in branch 'default': Issue #20597, #21274: Remove unused definition of PATH_MAX on GNU/Hurd, https://hg.python.org/cpython/rev/d6fb87972dee -- ___ Python tracker

[issue21274] define PATH_MAX for GNU/Hurd in Python/pythonrun.c

Roundup Robot added the comment: New changeset d6fb87972dee by Victor Stinner in branch 'default': Issue #20597, #21274: Remove unused definition of PATH_MAX on GNU/Hurd, https://hg.python.org/cpython/rev/d6fb87972dee -- ___ Python tracker

[issue20597] PATH_MAX already defined on some Windows compilers

STINNER Victor added the comment: > Reopening. I still don't understand the issue for 3.4, especially in the > light of #21274 In Python 3.5, PATH_MAX is no more used in Modules/main.c nor Python/pythonrun.c. I removed the "#define PATH_MAX ..." on Windows on Hurd. This issue is about support

[issue21274] define PATH_MAX for GNU/Hurd in Python/pythonrun.c

STINNER Victor added the comment: In Python 3.5, PATH_MAX is no more used in Modules/main.c nor Python/pythonrun.c. I removed the "#define PATH_MAX ..." on Hurd. I didn't check Python 3.4. -- nosy: +haypo ___ Python tracker

[issue7559] TestLoader.loadTestsFromName swallows import errors

Changes by Tim Graham : -- nosy: +Tim.Graham ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue22799] wrong time.timezone

New submission from Akira Li: $ TZ=:Europe/Moscow ./python -mtest -v test_time == FAIL: test_localtime_timezone (test.test_time.TestPytime) -- Traceback

[issue22685] memory leak: no transport for pipes by create_subprocess_exec/shell

STINNER Victor added the comment: Here is a patch with a simple unit test. I chose to modify the pause_reading method of the transport instead of mocking "everything" to test the real code (have a better code coverage). -- Added file: http://bugs.python.org/file37135/set_transport-2.pa

[issue22800] IPv6Network constructor sometimes does not recognize legitimate netmask

New submission from Chris PeBenito: Python 3.3/3.4 sometimes does not recognize a legitimate IPv6Network netmask: $ python3 Python 3.3.5 (default, May 28 2014, 13:56:57) [GCC 4.7.3] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import ipaddress as ip >>> no

[issue22793] test_uuid failure on OpenIndiana

Serhiy Storchaka added the comment: Patch for issue17293 changes tests so that this bug is visible on Posix. And it fixes this bug itself. -- ___ Python tracker ___

[issue22793] test_uuid failure on OpenIndiana

Roundup Robot added the comment: New changeset 16d6c2443131 by Victor Stinner in branch 'default': Issue #22793, #22637: Add missing "import os" in uuid._ifconfig_getnode() https://hg.python.org/cpython/rev/16d6c2443131 -- nosy: +python-dev ___ Python

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

Roundup Robot added the comment: New changeset 16d6c2443131 by Victor Stinner in branch 'default': Issue #22793, #22637: Add missing "import os" in uuid._ifconfig_getnode() https://hg.python.org/cpython/rev/16d6c2443131 -- ___ Python tracker

[issue22793] test_uuid failure on OpenIndiana

STINNER Victor added the comment: > NameError: name 'os' is not defined The imports in this module are really weird... But I'm not interested to rework completly the module, so I just fixed this specific issue. -- resolution: -> fixed status: open -> closed __

[issue22721] pprint output for sets and dicts is not stable

Serhiy Storchaka added the comment: > How about: repr(obj).strip("'\"") ? String can starts or ends with quotes. And string repr can be a part of the repr of other type (e.g. short list). -- ___ Python tracker _

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

Ethan Furman added the comment: Raymond declared: > Let's be clear. These are duck-typed methods. A type check is inappropriate. > Anything with o.items() is allowed regardless of type. Wikipedia explains (http://en.wikipedia.org/wiki/Duck_typing):

[issue22795] Intermittent test_tarfile failures on zLinux

Serhiy Storchaka added the comment: This is a duplicate of issue20220. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> TarFile.list() outputs wrong time ___ Python tracker __

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

R. David Murray added the comment: There is no purpose served by changing the AttributeError into a TypeError. It's just extra unneeded code. -- ___ Python tracker ___

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

Ethan Furman added the comment: I've posted to python-list and python-dev. I'll report back here the findings, if any. -- ___ Python tracker ___ ___

[issue22721] pprint output for sets and dicts is not stable

Antoine Pitrou added the comment: I think it'd be nice if the solution kept the current order when all keys are orderable (which is a very common case). So IMO repr() should only be used as a fallback when the object comparison fails. -- ___ Python

[issue22795] Intermittent test_tarfile failures on zLinux

David Edelsohn added the comment: Sorry, I was not aware of the other issue. Three tests seems to have intermittent failures. test_datetime test_tarfile test_strptime -- ___ Python tracker __

[issue22795] Intermittent test_tarfile failures on zLinux

David Edelsohn added the comment: I found the connection but I don't know the cause: Running test_imaplib prior to either test_datetime or test_tarfile causes the latter test to fail. test_datetime seems to fix the problem for test_tarfile if it precedes it. [1/3] test_imaplib [2/3] test_dat

[issue22801] collections.Counter, when empty, doesn't raise an error with &= when other is an incompatible type

New submission from Ethan Furman: test script: --- from collections import Counter empty_counter = Counter() counter = Counter('abbc') empty_counter &= 5 counter &= 5 --- results: --- Trac

[issue22795] Intermittent test_tarfile failures on zLinux

David Edelsohn added the comment: Its the @run_with_tz decorations in test_imaplib and test_datetime. The TZ is not being restored after the test. -- ___ Python tracker ___ ___

[issue22801] collections.Counter, when empty, doesn't raise an error with &= when other is an incompatible type

Changes by Ethan Furman : Removed file: http://bugs.python.org/file37136/issue22778.stoneleaf.01.patch ___ Python tracker ___ ___ Python-bugs-

[issue22801] collections.Counter, when empty, doesn't raise an error with &= when other is an incompatible type

Changes by Ethan Furman : Added file: http://bugs.python.org/file37137/issue22778.stoneleaf.01.patch ___ Python tracker ___ ___ Python-bugs-li

[issue20220] TarFile.list() outputs wrong time

Antoine Pitrou added the comment: I can reproduce under Linux using: $ TZ='America/New_York' ./python -m test -v test_imaplib test_tarfile test_datetime -- nosy: +David.Edelsohn, pitrou ___ Python tracker ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Matt Frank : -- nosy: +WanderingLogic ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue16353] add function to os module for getting path to default shell

Changes by Matt Frank : -- nosy: +WanderingLogic ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20220] TarFile.list() outputs wrong time

Antoine Pitrou added the comment: We seem to be bitten by the following bit of glibc (?) oddity: >>> os.environ['TZ'] = 'America/New_York' >>> time.tzset() >>> time.daylight, time.timezone, time.altzone, time.tzname (1, 18000, 14400, ('EST', 'EDT')) >>> os.environ['TZ'] = 'STD-1DST' >>> time.tzs

[issue20220] TarFile.list() outputs wrong time

Antoine Pitrou added the comment: First unsetting TZ seems to fix it: diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py --- a/Lib/test/support/__init__.py +++ b/Lib/test/support/__init__.py @@ -1507,11 +1507,11 @@ def run_with_tz(tz): try: ret

[issue5717] os.defpath includes unix /bin on windows

Changes by Matt Frank : -- nosy: +WanderingLogic ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue5717] os.defpath includes unix /bin on windows

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue22650] set up and use VM for net access in the test suite

Benjamin Peterson added the comment: I created a repository https://hg.python.org/pythontestdotnet, which is cloned on the server. -- ___ Python tracker ___

[issue22802] On Windows, if you try and use ccs=UTF-8 (or other variants) the U is removed

New submission from Alex Earl: As you can see below, the code in fileobject.c is removing the U from the UTF-8 (or UNICODE) when it tries to replace a U for universal line ending mode. Python 2.7.8 (default, Jun 30 2014, 16:03:49) [MSC v.1500 32 bit (Intel)] on win32 Type "help", "copyright",

[issue22525] ast.literal_eval() doesn't do what the documentation says

Roundup Robot added the comment: New changeset 5c5909740026 by Georg Brandl in branch '3.4': Closes #22525: clarify documentation for ast.literal_eval(). https://hg.python.org/cpython/rev/5c5909740026 -- nosy: +python-dev resolution: -> fixed stage: patch review -> resolved status: open

[issue22525] ast.literal_eval() doesn't do what the documentation says

Georg Brandl added the comment: Thanks, Raymond. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue22525] ast.literal_eval() doesn't do what the documentation says

Roundup Robot added the comment: New changeset 3e8d3c4bc17e by Georg Brandl in branch '2.7': Closes #22525: clarify documentation for ast.literal_eval(). https://hg.python.org/cpython/rev/3e8d3c4bc17e -- ___ Python tracker

[issue22802] On Windows, if you try and use ccs=UTF-8 (or other variants) the U is removed

Georg Brandl added the comment: open() does not support arbitrary platform flags in its mode argument. To open encoded files and transparently decode them to Unicode strings, please use io.open() on Python 2, and pass the correct "encoding" argument. On Python 3, the builtin open() is the sa

[issue22784] test_asyncio fails without the ssl module

Roundup Robot added the comment: New changeset 7e9e2b17ac6f by Antoine Pitrou in branch '3.4': Closes #22784: fix test_asyncio when the ssl module isn't available https://hg.python.org/cpython/rev/7e9e2b17ac6f New changeset 028c729714af by Antoine Pitrou in branch 'default': Closes #22784: fix t

[issue16353] add function to os module for getting path to default shell

Matt Frank added the comment: Unfortunately os.defpath seems to be hardcoded. And hardcoded to the wrong value on every system I have looked at, including Linux. Lib/posixpath.py sets defpath=':/bin:/usr/bin' which is _not_ what `getconf CS_PATH` returns on my Linux (the extra ':' at the begi

[issue5717] os.defpath includes unix /bin on windows

Matt Frank added the comment: os.defpath also seems wrong on Mac (':') and Linux (':/bin:/bin/sh'. The extra ':' at the beginning means the same thing as '.:/bin:/bin/sh' which is probably a security problem. I just started up discussion on http://bugs.python.org/issue16353 (which may require

[issue21650] add json.tool option to avoid alphabetic sort of fields

Changes by Serhiy Storchaka : -- assignee: -> berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue22695] open() declared deprecated in python 3 docs

Changes by Serhiy Storchaka : -- assignee: docs@python -> berker.peksag stage: patch review -> commit review ___ Python tracker ___ __

[issue14260] re.groupindex is available for modification and continues to work, having incorrect data inside it

Changes by Serhiy Storchaka : -- stage: needs patch -> patch review versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker ___ _

[issue22800] IPv6Network constructor sometimes does not recognize legitimate netmask

Changes by Ned Deily : -- nosy: +ncoghlan, pmoody ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue22800] IPv6Network constructor sometimes does not recognize legitimate netmask

Changes by Raymond Hettinger : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue16353] add function to os module for getting path to default shell

Ned Deily added the comment: Matt, ignore Lib/macpath.py. It is not used on OS X systems other than in the rare case that someone explicitly needs to parse obsolete Classic Mac OS (Mac OS 9 or earlier) style path names. OS X uses Lib/posixpath.py. -- nosy: +ned.deily ___

[issue22650] set up and use VM for net access in the test suite

Georg Brandl added the comment: 4985375db40f takes care of test_httplib. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15824] mutable urlparse return type

Matthew Hall added the comment: I don't think having to call a method with a weird secret underscored name to update a value in a URL named tuple is very elegant. Neither is creating a handful of pointless objects to make one simple validator function like the one I had to code today. I would

[issue21367] multiprocessing.JoinableQueue requires new kwarg

larkost added the comment: We just got bitten by this issue because we are trying to be compatible across 2.x and 3.x (including 3.0-3.2). For anyone who runs into the "missing 1 required keyword-only argument: 'ctx'" here is an import statement that works: try: from multiprocessing import

[issue7562] Custom order for the subcommands of build

Joshua J Cogliati added the comment: The documentation does claim that swig should just work "the build_ext command knows how to deal with SWIG extensions: it will run SWIG on the interface file and compile the resulting C/C++ file into your extension." It would be nice if there was one obviou

[issue15824] mutable urlparse return type

R. David Murray added the comment: Think of it as immutable like a string is immutable. The cases are exactly parallel (the string function is of course named 'replace' since it doesn't have to deal with the 'arbitrary attribute names' problem namedtuple does), except that it is much easier t

[issue22796] Support for httponly/secure cookies reintroduced lax parsing behavior

Antoine Pitrou added the comment: Paul, Tim, do you think there's a real risk of regression with the proposed patch? -- stage: -> commit review versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker

[issue16353] add function to os module for getting path to default shell

Akira Li added the comment: > Matt Frank added the comment: > > Unfortunately os.defpath seems to be hardcoded. And hardcoded to the > wrong value on every system I have looked at, including Linux. os.defpath is supposed to be ':'+CS_PATH, e.g., look at glibc (C library used on Linux) sysdeps/p

[issue22796] Support for httponly/secure cookies reintroduced lax parsing behavior

Tim Graham added the comment: Security-wise? I don't know, I haven't really been in the loop on the original issue. -- ___ Python tracker ___ ___

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

Roundup Robot added the comment: New changeset f75b0470168b by Steve Dower in branch '2.7': Issue #20160: broken ctypes calling convention on MSVC / 64-bit Windows (large structs). Patch by mattip https://hg.python.org/cpython/rev/f75b0470168b -- nosy: +python-dev _

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

Roundup Robot added the comment: New changeset cd36ba22602d by Steve Dower in branch '3.4': Issue #20160: broken ctypes calling convention on MSVC / 64-bit Windows (large structs) Patch by mattip https://hg.python.org/cpython/rev/cd36ba22602d New changeset b701eb69260d by Steve Dower in branch

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

Steve Dower added the comment: Done. Thanks mattip! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue22803] textwrap.indent version added not documented

New submission from Christopher Foo: I was running my program under CI and it failed under 3.2: text = textwrap.indent(text, '* ', predicate=lambda line: True) AttributeError: 'module' object has no attribute 'indent' textwrap.indent appears to be a new feature in 3.3 but Doc/library/t

[issue22803] textwrap.indent version added not documented

Roundup Robot added the comment: New changeset 501edbbb74ff by Raymond Hettinger in branch '3.4': Issue 22803: Add missing versionadded directive. https://hg.python.org/cpython/rev/501edbbb74ff -- nosy: +python-dev ___ Python tracker

[issue22803] textwrap.indent version added not documented

Raymond Hettinger added the comment: Thanks for the bug report. -- nosy: +rhettinger resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue22796] Support for httponly/secure cookies reintroduced lax parsing behavior

Antoine Pitrou added the comment: No, I meant functionality-wise. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr