[issue17162] Py_LIMITED_API needs a PyType_GenericDealloc

Martin v. Löwis added the comment: I propose a more general solution: add a function PyType_GetSlot. -- keywords: +patch Added file: http://bugs.python.org/file33762/getslot.diff ___ Python tracker

[issue19081] zipimport behaves badly when the zip file changes while the process is running

Gregory P. Smith added the comment: Fixed in the 2.7 branch. The existing patch in the 3.3 and 3.4 branches is incomplete and does not actually fix the problem. Despite what the Misc/NEWS entry claims. The patch I am attaching now (applies to 3.3, I will forward port it to 3.4) fixes the re

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

Larry Hastings added the comment: Attached is a second patch. * Now includes input and output checksums. Checksums are now truncated to 16 characters each, otherwise the line is >80 columns. * Fixes the doubled-up signature lines for type object slot default signatures. I ran "gcc -E" and

[issue19081] zipimport behaves badly when the zip file changes while the process is running

Roundup Robot added the comment: New changeset ca5431a434d6 by Gregory P. Smith in branch '2.7': Remove unneeded use of globals() and locals() in test on imports http://hg.python.org/cpython/rev/ca5431a434d6 -- ___ Python tracker

[issue20414] Python 3.4 has two Overlapped types

STINNER Victor added the comment: > One sub issue then is naming: _overlapped renamed > Overlapped.GetOverlappedResult to Overlapped.getresult. I think the _winapi > name is better, since all other methods also use Windows API function names. I also prefer Overlapped.GetOverlappedResult name.

[issue20264] Update patchcheck to looks for files with clinic comments

Larry Hastings added the comment: I've attached a script here that uses the new tweaked format of Clinic blocks. The new tweaked format isn't checked in yet--that change is being tracked with #20326. Once that's checked in, though, the attached script will check that both the input and output

[issue17162] Py_LIMITED_API needs a PyType_GenericDealloc

STINNER Victor added the comment: +return *(void**)(((char*)type) + slotoffsets[slot]); New Python versions may add new slots. What do you think of returning NULL if the slot number is higher than the maximum slot? It looks like "#define Py_tp_free 74" is the highest slot number since Pyt

[issue20414] Python 3.4 has two Overlapped types

Richard Oudkerk added the comment: _overlapped is linked against the socket library whereas _winapi is not so it can be bundled in with python3.dll. I did intend to switch multiprocessing over to using _overlapped but I did not get round to it. Since this is a private module the names of method

[issue20414] Python 3.4 has two Overlapped types

STINNER Victor added the comment: > I did intend to switch multiprocessing over to using _overlapped > but I did not get round to it. Do you mean that _overlapped module is newer and should be used instead of _winapi? If multiprocssing is patched to use _overlapped, we can drop overlapped code

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

Vajrasky Kok added the comment: Here is the updated patch for list module based on Zachary and Serhiy's reviews. -- Added file: http://bugs.python.org/file33767/clinic_listobject_v4.patch ___ Python tracker ___

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

Vajrasky Kok added the comment: Forgot to say that, in list module, anything is convertable except __getitem__. -- ___ Python tracker ___

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

Larry Hastings added the comment: I'm surprised it made a review link. It didn't apply cleanly for me here. While merging I noticed that the imperative declension fix had snuck out of the diff somehow. So I redid that. Attached is an updated patch. Also I should mention: clinic.py currentl

[issue20415] Could method "isinstance" take a list as parameter?

New submission from Chen ZHANG: Since the usage of isinstance could be "isinstance(1, (int, float))", I'm wondering why it doesn't accept "[int, float]", if I do so, it would raise TypeError saying "arg 2 must be a type or tuple of types". What's the difference in effect between a tuple and a

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

Vajrasky Kok added the comment: Here is the updated patch for marshal module based on Zachary's review. -- Added file: http://bugs.python.org/file33769/clinic_marshal_v4.patch ___ Python tracker ___

[issue20308] inspect.Signature doesn't support user classes without __init__ or __new__

Stefan Krah added the comment: One test fails --without-doc-strings: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/6266/steps/test/logs/stdio -- nosy: +skrah ___ Python tracker ___

[issue20415] Could method "isinstance" take a list as parameter?

Mark Dickinson added the comment: See related discussion on python-ideas here: https://mail.python.org/pipermail/python-ideas/2011-July/010610.html -- nosy: +mark.dickinson ___ Python tracker _

[issue20338] Idle: increase max calltip width

Stefan Krah added the comment: I think test_idle is failing on many build slaves following this commit. -- nosy: +skrah ___ Python tracker ___ ___

[issue20416] Marshal: special case int and float, don't use references

New submission from STINNER Victor: Attached patched disables references for int and float types. -- files: marshal3_numbers.patch keywords: patch messages: 209524 nosy: haypo priority: normal severity: normal status: open title: Marshal: special case int and float, don't use references

[issue20416] Marshal: special case int and float, don't use references

STINNER Victor added the comment: Use attached bench.py to compare performances. Without the patch: --- dumps v0: 389.6 ms data size v0: 45582.9 kB loads v0: 573.3 ms dumps v1: 391.4 ms data size v1: 45582.9 kB loads v1: 558.0 ms dumps v2: 166.9 ms data size v2: 41395.4 kB loads v2: 482.2 ms

[issue20416] Marshal: special case int and float, don't use references

Changes by STINNER Victor : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue20416] Marshal: special case int and float, don't use references

STINNER Victor added the comment: Performance of Python 3.3.3+: --- dumps v0: 374.8 ms data size v0: 45582.9 kB loads v0: 625.3 ms dumps v1: 374.6 ms data size v1: 45582.9 kB loads v1: 605.1 ms dumps v2: 152.9 ms data size v2: 41395.4 kB loads v2: 556.5 ms --- So with the patch, the Python 3.4

[issue20416] Marshal: special case int and float, don't use references

STINNER Victor added the comment: Oh by the way, on Python 3.4, the file size (on version 3 and 4) is unchanged with my patch. Writing a reference produces takes exactly the same size than an integer. -- ___ Python tracker

[issue20166] window x64 c-extensions not works on python3.4.0b2

Stefan Krah added the comment: Ping. The blocker seems to have passed beta3. :) -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19081] zipimport behaves badly when the zip file changes while the process is running

Georg Brandl added the comment: Since this is a pretty big code churn, I'd prefer B) for 3.3.4. (3.3.5 will be soon anyway.) -- ___ Python tracker ___ _

[issue20416] Marshal: special case int and float, don't use references

Vajrasky Kok added the comment: I am doing clinic conversion for marshal module so I am adding myself to nosy list to make sure both tickets are synchronized. http://bugs.python.org/issue20185 -- nosy: +vajrasky ___ Python tracker

[issue20416] Marshal: special case int and float, don't use references

STINNER Victor added the comment: > I am doing clinic conversion for marshal module so I am adding myself to nosy > list to make sure both tickets are synchronized. The Derby is suspended until the release of Python 3.4 final. I consider this issue as an important performance regression that s

[issue20416] Marshal: special case int and float, don't use references

Changes by Serhiy Storchaka : -- nosy: +kristjan.jonsson, pitrou, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20416] Marshal: special case int and float, don't use references

Serhiy Storchaka added the comment: Did you tested for numerous shared int and floats? [1000] * 100 and [1000.0] * 100? AFAIK this was important use cases for adding 3 or 4 versions. -- ___ Python tracker

[issue20416] Marshal: special case int and float, don't use references

STINNER Victor added the comment: > Did you tested for numerous shared int and floats? [1000] * 100 and > [1000.0] * 100? AFAIK this was important use cases for adding 3 or 4 > versions. Here are new benchmarks on Python 3.4 with: Integers: [1000] * 100 Floats: [1000.0] *

[issue20416] Marshal: special case int and float, don't use references

Martin v. Löwis added the comment: For the record, format 3 was added through issue16475, format 4 was added through issue19219. In msg175962, Kristjan argued that there is no reason _not_ to share int objects, e.g. across multiple code objects. Now it seems that this argument is flawed: ther

[issue20416] Marshal: special case int and float, don't use references

Antoine Pitrou added the comment: > Integers, without the patch: > > dumps v3: 62.8 ms > data size v3: 4882.8 kB > loads v3: 10.7 ms > > Integers, with the patch: > > dumps v3: 18.6 ms (-70%) > data size v3: 4882.8 kB (same size) > loads v3: 27.7 ms (+158%) As I wrote

[issue20417] ensurepip should not be installed with --without-ensurepip

New submission from Arfrever Frehtes Taifersar Arahesis: ensurepip should not be installed when --without-ensurepip was passed to configure. I attach the patch. -- assignee: dstufft components: Installation files: ensurepip_installation.patch keywords: patch messages: 209536 nosy: Arfre

[issue20417] ensurepip should not be installed with --without-ensurepip

Donald Stufft added the comment: I don't see any reason not to install ensurepip in this situation. That flag controls whether or not ``python -m ensurepip`` will be executed during the install, but ensurepip itself will still be installed. It is not an optional module -- ___

[issue20166] window x64 c-extensions not works on python3.4.0b2

Martin v. Löwis added the comment: I think the change should be reverted, and the original issue closed as "won't fix". Alternatively, to fix the original issue, the specific linker warning could be suppressed. -- ___ Python tracker

[issue20418] socket.getaddrinfo fails for hostname that is all digits 0-9

New submission from ariel-wikimedia: With python 2.7.5 (running on fedora 20 with all updates), socket.getaddrinfo for a hostname such as 836937931829 will fail. Docker produces these sorts of hostnames (really random hex strings, but some hex strings only contain digits 0-9). How to reprodu

[issue20414] Python 3.4 has two Overlapped types

Martin v. Löwis added the comment: It seems fine to me to link pythonXY.dll with wsock32.dll. This is a standard library in Windows NT+, so there is no need to avoid linking with it. I also now agree that any change that we may make is too big for 3.4, so I propose to defer any action on this

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

Nick Coghlan added the comment: Looks good to me :) I also like the fact it simplifies the internal APIs by making it really trivial to detect the presence of a clinic signature from C. -- ___ Python tracker

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

Roundup Robot added the comment: New changeset d6311829da15 by Larry Hastings in branch 'default': Issue #20326: Argument Clinic now uses a simple, unique signature to http://hg.python.org/cpython/rev/d6311829da15 -- nosy: +python-dev ___ Python track

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

Changes by Larry Hastings : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

Larry Hastings added the comment: Yeah. I did a pretty terrible job of articulating why the "(" signature was a bad idea in the first place ;-) -- ___ Python tracker ___ __

[issue20338] Idle: increase max calltip width

Terry J. Reedy added the comment: On 1/28/2014 4:48 AM, Stefan Krah wrote: > > Stefan Krah added the comment: > > I think test_idle is failing on many build slaves following this > commit. The two failures I saw on the first 4 3.x bots with Idle failures are the result of changes in the list do

[issue18795] pstats - allow stats sorting by cumulative time per call and total time per call

Alexandre Dias added the comment: Could I get an update on this please? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue9709] test_distutils warning: initfunc exported twice on Windows

Roundup Robot added the comment: New changeset 69827c2ab9d0 by Stefan Krah in branch 'default': Issue #9709: Revert 97fb852c5c26. Many extensions are not using PyMODINIT_FUNC. http://hg.python.org/cpython/rev/69827c2ab9d0 -- ___ Python tracker

[issue20411] IndexError in sys.__interactivehook__ with pyreadline installed

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue20166] window x64 c-extensions not works on python3.4.0b2

Stefan Krah added the comment: Thanks, that seems to be the best course of action. Fixed in 69827c2ab9d0. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed superseder: -> test_distutils warning: initfunc exported twice on Windows type: -> compile error ___

[issue9709] test_distutils warning: initfunc exported twice on Windows

Stefan Krah added the comment: Too many extensions are not using PyMODINIT_FUNC (See #20166). Closing as WONT_FIX. -- resolution: fixed -> wont fix ___ Python tracker ___

[issue20411] IndexError in sys.__interactivehook__ with pyreadline installed

Roundup Robot added the comment: New changeset ca6efeedfc0e by Jason R. Coombs in branch 'default': Issue #20411: Use readline.get_current_history_length to check for the presence of a history, rather than get_history_item, which assumes a history is present. http://hg.python.org/cpython/rev/ca6

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

Vajrasky Kok added the comment: Here is the updated patch for float object based on Zachary and Serhiy's reviews. Some methods that can not be converted are: __getnewargs__, __round__, float_new. So these files are ready for Python 3.4: resource, typeobject, listobject, and floatobject. The

[issue20411] IndexError in sys.__interactivehook__ with pyreadline installed

Jason R. Coombs added the comment: After further consideration and investigation, I believe the fix is to simply use the API as exposed by pyreadline to check the length of the history to detect the presence of an existing history. I've tested that fix locally and it seems to be working suitab

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

Changes by Zachary Ware : Added file: http://bugs.python.org/file33774/bda6dc12a123.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

Changes by Zachary Ware : Added file: http://bugs.python.org/file33775/41ad3c4fc03c.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

Changes by Zachary Ware : Removed file: http://bugs.python.org/file33774/conglomerate.v6-post-20326.diff ___ Python tracker ___ ___ Python-bug

[issue20414] Python 3.4 has two Overlapped types

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue18846] python.exe stdout stderr issues again

SSmith added the comment: Please pay some attention to this. This ISSUE is still valid in 3.4b4! Issue #18338 resolves only part of the problem. Look at this part of the OP: invoking python.exe prints its default output to stderr: [ in]>python 1> null [out]>Python 3.4.0a1 (v3.4.0a1:46535f65e7

[issue18846] python.exe stdout stderr issues again

SSmith added the comment: r/3.4b4/3.4b3 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: Does this patch fix things for you? -- resolution: fixed -> status: closed -> open Added file: http://bugs.python.org/file33776/issue3158.__objclass__-fix.diff ___ Python tracker ___

[issue20414] Python 3.4 has two Overlapped types

Guido van Rossum added the comment: I'm fine with this refactoring. The upstream tulip/asyncio repo will keep its own _overlapped for the purpose of supporting Python 3.3. (I'm not sure what Victor wants to do with Trollius but probably the same.) -- __

[issue20221] #define hypot _hypot conflicts with existing definition

Zachary Ware added the comment: I'm having difficulty wrapping my head around why the math and cmath modules (both of which use hypot) compile fine, but your extensions don't. Anyone have any insight into why that is? -- ___ Python tracker

[issue18846] python.exe stdout stderr issues again

Benjamin Peterson added the comment: Hmm, I'm not sure what the precedence is for that. Where do other interactive languages print their header to? -- ___ Python tracker ___ ___

[issue20075] help(open) eats first line

Larry Hastings added the comment: Yup, sorry about that. We're moving pretty fast with the Derby right now, and sometimes we don't figure out something important until later, and sometimes that means wasted effort. Sorry! -- ___ Python tracker

[issue20075] help(open) eats first line

Zachary Ware added the comment: With #20326 fixed, this is no longer an issue. Gennadiy, thank you for the patch, and I'm sorry it ended up being unused. -- resolution: -> out of date stage: commit review -> committed/rejected status: open -> closed ___

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

Zachary Ware added the comment: I have high hopes for this latest update :) -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue20420] BufferedIncrementalEncoder violates IncrementalEncoder interface

New submission from Serhiy Storchaka: The documentation of IncrementalEncoder.getstate() says: """ Return the current state of the encoder which must be an integer. The implementation should make sure that 0 is the most common state. (States that are more complicated than integers can be conve

[issue20414] Python 3.4 has two Overlapped types

STINNER Victor added the comment: Can please someone review overlapped_dealloc.patch? I would like to apply it on Python 3.4. -- ___ Python tracker ___ _

[issue20421] expose SSL socket protocol version

New submission from Antoine Pitrou: SSL sockets should provide a way to query the current protocol version (e.g. "TLSv1.2"). OpenSSL makes it easy through SSL_get_version(). Open question is whether we return the string returned by SSL_get_version(), or we convert it to one of the constants ss

[issue20419] it's not possible to set ECDH curve name via ssl.wrap_socket

New submission from Michael Gubser: One can only set the ECDH curve name via SSLContext.set_ecdh_curve(). ssl.wrap_socket() doesn't have a parameter to use it for the wrapping of the basic socket. Therefore one always has to do the detour over SSLContext. -- components: Library (Lib) m

[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided

New submission from Yury Selivanov: Right now it may return `None` if no signature can be returned for the given builtin. If we decide to implement #17373 in 3.5, I'd like all three methods -- from_builtin, from_function, from_callable -- to either return a signature or to raise an exception.

[issue20401] inspect.signature removes initial starred method params (bug)

Roundup Robot added the comment: New changeset 3544827d42e6 by Yury Selivanov in branch 'default': inspect.signature: Handle bound methods with '(*args)' signature correctly #20401 http://hg.python.org/cpython/rev/3544827d42e6 -- nosy: +python-dev __

[issue20401] inspect.signature removes initial starred method params (bug)

Yury Selivanov added the comment: Committed. Thank you, Terry. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue20418] socket.getaddrinfo fails for hostname that is all digits 0-9

R. David Murray added the comment: getaddrinfo is a thin wrapper around the system call. Have you tried the same thing in a C program and had it work? My guess would be that the all-numeric 'hostname' is being treated as the integer form of an IP address. I can't immediately find any documen

[issue17481] inspect.getfullargspec should use __signature__

Yury Selivanov added the comment: Larry and Nick, Please review the final patch (getargsspec_04.patch). I'd like to commit it tomorrow. This one is the last one (hopefully), and it supports builtin methods properly -- i.e. works around 'self' parameter correctly. To do that, I check if the '

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

Zachary Ware added the comment: Attaching a conglomerate patch consisting of clinic_resource_v2.patch, clinic_typeobject_v2.patch, clinic_listobject_v3.patch, clinic_marshal_v4.patch, and clinic_floatobject_v2.patch, with updated (post-#20326) clinic output, for easier review. -- Adde

[issue17481] inspect.getfullargspec should use __signature__

Changes by Yury Selivanov : -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue20221] #define hypot _hypot conflicts with existing definition

Tabrez Mohammed added the comment: My extension doesn't compile because I treat warnings as errors. I believe Blender compiles fine, but crashes at runtime because of the infinite recursion (see the second code snippet in Brecht's response (http://bugs.python.org/msg208981). -- _

[issue20221] #define hypot _hypot conflicts with existing definition

Zachary Ware added the comment: Sorry, I wasn't entirely clear. By "compile fine", I meant "compiles without warnings, and actually works when you try to use it". Both math and cmath make use of hypot (as defined in pyconfig.h), but don't have any problems. They also have no problems with yo

[issue20418] socket.getaddrinfo fails for hostname that is all digits 0-9

Ariel Glenn added the comment: Yes, I had checked that just in case; getaddrinfo(3) works for the all-digit hostname, returning no error. I'm using these hints: memset(&hints, 0, sizeof(struct addrinfo)); hints.ai_family = AF_UNSPEC; hints.ai_socktype = SOCK_STREAM; hints.ai_flags

[issue18846] python.exe stdout stderr issues again

SSmith added the comment: Interestingly to me, you 're right! Powershell interpreter does the same. Ironically, failure to launch python from Powershell ISE(Integrated Scripting Environment) was what triggered this bug report. And as I see know, PowershellISE doesnt support launching a 'nes

[issue19081] zipimport behaves badly when the zip file changes while the process is running

Gregory P. Smith added the comment: Thanks Georg. I'll leave it until after the 3.3.4 release. For simplicity's sake I'll leave it for 3.4.1 as well unless Larry says otherwise. -- priority: release blocker -> deferred blocker ___ Python tracker <

[issue20221] #define hypot _hypot conflicts with existing definition

Brecht Van Lommel added the comment: For Visual Studio 2013, here's how to redo the problem. Take this simple program: #include int main(int argc, char **argv) { return (int)hypot(rand(), rand()); } And compile it: cl.exe test.c -I include/python3.3 lib/python33.lib /W4 c:\program file

[issue20423] io.StringIO newline param has wrong default

New submission from couplewavylines: In io.StringIO, the newline argument's default is currently documented as "newline=None" in the section header. However, it's described this way: "The default is to do no newline translation." The behavior of io.StringIO is consistent with this descriptio

[issue20423] io.StringIO newline param has wrong default

Changes by couplewavylines : Added file: http://bugs.python.org/file33780/no_translation_output.txt ___ Python tracker ___ ___ Python-bugs-lis

[issue20414] Python 3.4 has two Overlapped types

Martin v. Löwis added the comment: See my review in Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20423] io.StringIO newline param has wrong default

Serhiy Storchaka added the comment: No, actual default is '\n'. >>> io.StringIO('abc\r\ndef\nghi\rklm').readlines() ['abc\r\n', 'def\n', 'ghi\rklm'] >>> io.StringIO('abc\r\ndef\nghi\rklm', newline=None).readlines() ['abc\n', 'def\n', 'ghi\n', 'klm'] >>> io.StringIO('abc\r\ndef\nghi\rklm', newlin

[issue20423] io.StringIO newline param has wrong default

couplewavylines added the comment: Serhiy, you're right, I now see the default behavior is "newline='\n'". So, the header is still wrong, and the text is "The default is to do no newline translation" may be incorrect too? Or just unclear (to me anyway)? -- ___

[issue20423] io.StringIO newline param has wrong default

Serhiy Storchaka added the comment: On other hand, may be the behavior of io.StringIO is wrong. Because it is different from io.TextIOWrapper. >>> io.TextIOWrapper(io.BytesIO(b'abc\r\ndef\nghi\rklm')).readlines() ['abc\n', 'def\n', 'ghi\n', 'klm'] >>> io.TextIOWrapper(io.BytesIO(b'abc\r\ndef\ng

[issue20221] #define hypot _hypot conflicts with existing definition

Changes by Zachary Ware : -- stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20221] #define hypot _hypot conflicts with existing definition

Zachary Ware added the comment: Your test program works for VS2010 as well (/W4 is unnecessary, the default warning level gives the warning), but still doesn't answer the question of why the math module (specifically math.hypot) doesn't show the problem. I understand why both of your cases *do

[issue20424] _pyio.StringIO doesn't work with lone surrogates

New submission from Serhiy Storchaka: Unlike to io.StringIO, _pyio.StringIO doesn't work with lone surrogates. >>> import io, _pyio >>> io.StringIO('\ud880') <_io.StringIO object at 0xb71426ec> >>> _pyio.StringIO('\ud880') Traceback (most recent call last): File "", line 1, in File "/home/s

[issue20218] Add `pathlib.Path.write` and `pathlib.Path.read`

Christopher Welborn added the comment: Using 'review' with pathlib.readwrite4.patch, it looks like it only modifies one file (test_pathlib.py), which can't be right. Maybe you edited the patch directly instead of generating a new one? (also, the line-counts haven't changed and I think they wer

[issue20425] inspect.Signature should work on decorated builtins

Changes by Yury Selivanov : -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue20425] inspect.Signature should work on decorated builtins

New submission from Yury Selivanov: inspect.signature should work with decorated builtins. Suppose I want to create a cached version of 'min' builtin: cached_min = functools.lru_cache()(min) The signature of the 'cached_min' should match the signature of 'min'. The patch is attached.

[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided

Yury Selivanov added the comment: A patch is attached, please review. -- keywords: +needs review, patch stage: -> patch review Added file: http://bugs.python.org/file33784/from_builtin_errors_01.patch ___ Python tracker

[issue20414] Python 3.4 has two Overlapped types

STINNER Victor added the comment: > See my review in Rietveld. Thanks Martin, but I cannot answer to your question. I didn't write this part of the code and I don't know it. Maybe Richard or Antoine would be able to answer? -- ___ Python tracker <

[issue20424] _pyio.StringIO doesn't work with lone surrogates

STINNER Victor added the comment: I agree that StringIO should accept lone surrogates as str += str accept them. The patch looks good, but please mention the issue number in the unit test. And add an empty line between the two parts of the test (reader, writer). -- ___

[issue20379] help(instance_of_builtin_class.method) does not display self

Yury Selivanov added the comment: FWIW, I solved the first arg consistency for inspect.getfullargspec in #17481. The latest patch always shows the first argument (self) for both python-defined and C-defined methods. -- nosy: +yselivanov ___ Python t

[issue15582] Enhance inspect.getdoc to follow inheritance chains

Changes by Yury Selivanov : -- versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19573] Fix the docstring of inspect.Parameter and the implementation of _ParameterKind

Changes by Yury Selivanov : -- nosy: +yselivanov versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20423] io.StringIO newline param has wrong default

Antoine Pitrou added the comment: Using '\n' as default is normal: StringIOs are not stored on disk so there's no point in converting newlines by default (it's only slower while not improving interoperability). '\n' is the default line separator in Python. So we should just fix the docs here.

[issue19573] Fix the docstring of inspect.Parameter and the implementation of _ParameterKind

Yury Selivanov added the comment: Antony, the docstrings are fixed. Could you please provide a patch just for the _ParameterKind-Enum refactoring? I'll incorporate it into 3.5 then. -- assignee: docs@python -> yselivanov ___ Python tracker

  1   2   >