[issue19944] Make importlib.find_spec load packages as needed

2014-01-25 Thread Eric Snow
Changes by Eric Snow : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread STINNER Victor
STINNER Victor added the comment: 2014-01-25 Charles-François Natali : >> It looks like changing the rounding method doesn't solve anything. >> selector.select(timeout) may still take less than timeout, so it >> doesn't give any guarantee. > > But what problem does it cause if, once in a while, t

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset f453443c96e4 by Victor Stinner in branch 'default': Issue #20311: Fix test_telnetlib, set the resolution of the MockSelector http://hg.python.org/cpython/rev/f453443c96e4 -- ___ Python tracker

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: I don't have the energy to read all the debate here, but over on python-tulip we continue to discuss this. Victor and I have currently agreed to drop the math.ceil() calls from the event loop and instead simply consider any event scheduled within "granularit

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread STINNER Victor
STINNER Victor added the comment: > Looks like 3b8a2281d323aa9abf497192b01cf9 06b98ed3d8 broke the buildbots. Oh, I didn't watch buildbots, sorry. It should be fixed by f453443c96e4. My first attempt used an attribute using a default value of None, but it was harder to use: I had to check if th

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Thanks for the reviews, Nick and Serhiy, especially considering that the Rietveld link didn't work! Serhiy: I believe I fixed everything. There are no side files checked in yet. Can you give me another review? -- Added file: http://bugs.python.org/

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings : Removed file: http://bugs.python.org/file33710/larry.clinic.rollup.jan.25.diff.2.txt ___ Python tracker ___ ___ P

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Hang on, my tree was out of date. Which is why I didn't get a review link, duh. And if side files have appeared I'll fix 'em. -- ___ Python tracker _

[issue20358] test_curses is failing on Ubuntu 13.10

2014-01-25 Thread Zachary Ware
Zachary Ware added the comment: Ok, I've tracked down where the error is happening, but I don't know enough about curses to suggest where it should go from here. It does appear to be the version of ncurses that Ubuntu 13.10 uses that's causing problems, version 5.9+20130608. The issue stems

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Okay, here's my revised patch, for real this time, with "hg mv" for the side files and everything. -- Added file: http://bugs.python.org/file33711/larry.clinic.rollup.jan.25.diff.2.txt ___ Python tracker

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Can you try locally applying my patch for #20390 and seeing if you still have the problem? I tried applying it to the itertoolmodule.c you attached to the issue and it seemed to fix the problem. -- ___ Python track

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Oops, I goofed up moving _lzamodule.clinic.c.h. I'll fix that locally, won't regenerate the patch just for that (unless you ask me to). -- ___ Python tracker

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: No, wait, I think it's fine, it was just some detritus in my directory throwing me off. But "hg stat" looks correct. -- ___ Python tracker ___

[issue20133] Derby: Convert the audioop module to use Argument Clinic

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Christian Heimes just posted this to python-dev: Coverity has detected an issue in this commit: ** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO) /Modules/audioop.c: 1375 in audioop_rate

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Nick Coghlan
Nick Coghlan added the comment: I strongly prefer SocketKind - SockType is far too close to SocketType and "type" is too closely associated with the type system in general. -- ___ Python tracker ___

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Arfrever and Serhiy. Here's a new patch. -- Added file: http://bugs.python.org/file33712/issue20363_v2.diff ___ Python tracker ___

[issue20283] Wrong keyword parameter name in regex pattern methods

2014-01-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great. Old and new both in at least one release, when possible, is best. I should have thought of asking if that would be possible. In this case, I think the (undocumented) old should disappear in 3.5. Since the mistaken 'pattern' name is not documented now, I

[issue20375] ElementTree: Document handling processing instructions

2014-01-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: I've also attached a testcase to confirm that the docpatch reflects current behavior, and to make sure that anticipated enhancements in Python 3.5 behave in a backwards compatible way. -- Added file: http://bugs.python.org/file33713/etree-testcases.patc

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: The new patch has %s and %r reversed in Lib/distutils/command/register.py. -- ___ Python tracker ___ __

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: LGTM. But you also need to update Doc/library/concurrent.futures.rst I see this as a bugfix so it's not necessary to get this in before the beta 3 release tonight. I will work on an asyncio patch and test. -- ___

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: I've attached updated patches to reflect the recent changes in the derby policy. part1 is the part of the patch that is suitable for 3.4. part2 are the changes that have to wait for 3.5 (mostly because of default values). -- Added file: http://bugs.pyt

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Berker Peksag added the comment: Ah, my bad. Thanks Arfrever. -- Added file: http://bugs.python.org/file33715/issue20363_v3.diff ___ Python tracker ___ __

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Changes by Berker Peksag : Removed file: http://bugs.python.org/file33669/issue20363.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Changes by Berker Peksag : Removed file: http://bugs.python.org/file33712/issue20363_v2.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Changes by Nikolaus Rath : Added file: http://bugs.python.org/file33716/timemodule_part1_rev3.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Changes by Nikolaus Rath : Removed file: http://bugs.python.org/file33714/timemodule_part1_rev3.patch ___ Python tracker ___ ___ Python-bugs-l

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Changes by Nikolaus Rath : Added file: http://bugs.python.org/file33717/timemodule_part2_rev3.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: I'll wait with working on _datetimemodule.c until someone had a chance to look over my _timemodule.c patch. (I want to make sure I'm following the right procedure). -- ___ Python tracker

[issue20319] concurrent.futures.wait() can block forever even if Futures have completed

2014-01-25 Thread Brian Quinlan
Brian Quinlan added the comment: I'm looking at "futures.patch". I don't understand why these blocks are helpful -"_create_and_install_waiters" has two call sites and both ("as_completed" and "wait") call "_create_and_install_waiters" from within an _AcquireFutures context manager: -p

[issue20319] concurrent.futures.wait() can block forever even if Futures have completed

2014-01-25 Thread Glenn Langford
Glenn Langford added the comment: > It seems more plausible that the locks around the removals are fixing the bug > but I don't see how. I'll look into it some more. It is the locks around the waiter removals that matter; I think there are only formatting changes elsewhere in the patch. The re

[issue13355] random.triangular error when low = high=mode

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I haven't looked at this in depth but it sounds like this is a legitimate concern. I'd like it fixed for 3.4, preferably before rc1. -- nosy: +larry ___ Python tracker __

[issue20322] Upgrade ensurepip's pip and setuptools

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: You can check those in for 3.4. Do it right now and you can get them in for beta 3. Sorry for the tardy reply! -- ___ Python tracker ___

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I don't know why it's refusing to generate the review link. The patch applies cleanly to trunk, even now, hours later. Maybe it doesn't like file moves? -- ___ Python tracker __

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9c5b421cc7de by Larry Hastings in branch 'default': Issue #20390: Small fixes and improvements for Argument Clinic. http://hg.python.org/cpython/rev/9c5b421cc7de -- nosy: +python-dev ___ Python tracker <

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue20226] Argument Clinic: support for simple expressions?

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings : -- stage: commit review -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue19145] Inconsistent behaviour in itertools.repeat when using negative times

2014-01-25 Thread Vajrasky Kok
Vajrasky Kok added the comment: Larry said, "A proper fix for the "bug" will require changing the semantics of the function. It's inappropriate to do that in 2.7, 3.3, and (now that we're in beta) 3.4." I think we can not have it all and need to be pragmatic in this ticket. While we can not f

[issue19145] Inconsistent behaviour in itertools.repeat when using negative times

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Raymond said "The preferred behavior is that a negative number always means 0." My proposal honors that. We certainly aren't changing this in 3.3 and 2.7, and as release manager for 3.4 I'm pretty sure we aren't changing it there. -- ___

[issue20322] Upgrade ensurepip's pip and setuptools

2014-01-25 Thread Donald Stufft
Changes by Donald Stufft : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1435d2fe8e34 by Larry Hastings in branch 'default': Issue #20390: Final fix, for generating NoPositional/NoKeyword for __init__ calls. http://hg.python.org/cpython/rev/1435d2fe8e34 -- ___ Python tracker

[issue20358] test_curses is failing on Ubuntu 13.10

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0ae768637a07 by Larry Hastings in branch 'default': Issue #20358: Tests for curses.window.overlay and curses.window.overwrite http://hg.python.org/cpython/rev/0ae768637a07 -- nosy: +python-dev ___ Python

[issue20358] test_curses is failing on Ubuntu 13.10

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I changed the unit test so it doesn't specify a minium row/column greater than the maximum row/column. The tests now pass. So I'm calling this good. Thanks for looking in to it, Zachary and Nadeem! -- assignee: -> larry resolution: -> fixed stage:

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Rietveld doesn't like patches against out of date tree. And unfortunately it doesn't like patches in git format. -- ___ Python tracker ___ __

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I don't know about diff #1, but diff #2 definitely applied cleanly against a fresh trunk at 8:22pm local time. I've turned off git format. -- ___ Python tracker _

[issue20394] Coverity complains on audioop

2014-01-25 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Christian Heimes reported (http://permalink.gmane.org/gmane.comp.python.devel/145253) Coverity issue: """ ** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO) /Modules/audioop.c: 1375 in audioop_ratecv_impl() _

[issue20133] Derby: Convert the audioop module to use Argument Clinic

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Christian Heimes just posted this to python-dev: See issue20394. This is unrelated to clicalization patch. -- ___ Python tracker ___ __

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Charles-François Natali
Charles-François Natali added the comment: > > But what problem does it cause if, once in a while, the call takes less > > than the passed timeout? > > If that's the case, you'll simply perform another loop, an wake up 1ms > > later, that's all. > > "perform another loop" is my problem. If possib

<    1   2