[issue19428] marshal: error cases are not documented

2013-10-29 Thread Georg Brandl
Georg Brandl added the comment: Is this backportable? -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19416] NNTP page has incorrect links

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6b2352f1d365 by Georg Brandl in branch '2.7': Closes #19416: fix references in the nntplib docs. http://hg.python.org/cpython/rev/6b2352f1d365 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> closed _

[issue19416] NNTP page has incorrect links

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 03fa1b0af343 by Georg Brandl in branch '3.3': Closes #19416: fix references in the nntplib docs. http://hg.python.org/cpython/rev/03fa1b0af343 -- ___ Python tracker __

[issue19426] Opening a file in IDLE causes a crash or hang

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7fde94ad5df4 by Serhiy Storchaka in branch '2.7': Issue #19426: Fixed the opening of Python source file with specified encoding. http://hg.python.org/cpython/rev/7fde94ad5df4 -- nosy: +python-dev ___ Pyth

[issue19426] Opening a file in IDLE causes a crash or hang

2013-10-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Ned. Definitely IDLE needs more unit tests. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker

[issue17936] O(n**2) behaviour when adding/removing classes

2013-10-29 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Just updating for recent changes, right? LGTM. Shouldn't this just get committed? -- ___ Python tracker ___ ___

[issue19430] argparse replaces \$ to is passed

2013-10-29 Thread telmich
New submission from telmich: When using argparse and the string \$ occurs on the commandline, it is converted to $. This as definitely wrong and renders argparse useless, if the input needs to be trusted (i.e. defitinely the same as given into it)' Example code: import sys import argparse p

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread telmich
Changes by telmich : -- title: argparse replaces \$ to is passed -> argparse replaces \$ with $ (if in commandline) ___ Python tracker ___ _

[issue17936] O(n**2) behaviour when adding/removing classes

2013-10-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: I see I haven't addressed your previous comment about PyErr_Clear(), I should probably address it before anything gets committed. -- ___ Python tracker ___

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread telmich
telmich added the comment: Background information: cdist is written in python 3 and makes heavy use of argparse. One common task is to run a cdist type with some arguments, which in the end configure a remote system. We triggered the bug by running __line ps1 --file /etc/bash.bashrc --line "PS

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread Ezio Melotti
Ezio Melotti added the comment: I don't think this is related to argparse: $ echo 'import sys; print(sys.argv)' > issue19430.py $ python issue19430.py ps1 --file /etc/bash.bashrc --line "PS1='[\t] \[\033[1m\]\h\[\033[0m\]:\w\$ '" ['issue19430.py', 'ps1', '--file', '/etc/bash.bashrc', '--line', "

[issue19431] Document PyFrame_FastToLocals() and PyFrame_FastToLocalsWithError()

2013-10-29 Thread STINNER Victor
New submission from STINNER Victor: (Copy of an email) Georg Brandl via python.org Am 29.10.2013 01:19, schrieb victor.stinner: > http://hg.python.org/cpython/rev/4ef4578db38a > changeset: 86715:4ef4578db38a > user:Victor Stinner > date:Tue Oct 29 01:19:37 2013 +0100

[issue19413] Reload semantics changed unexpectedly in Python 3.3

2013-10-29 Thread Nick Coghlan
Nick Coghlan added the comment: Patch mostly looks good to me, but there should be a second test ensuring that the loader attribute gets *replaced*, even if it is already set to something else. A similar test structure to the existing one should work, but replacing the "del types.__loader__"

[issue18609] test_ctypes failure on AIX in PyEval_CallObjectWithKeywords

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 31f9c1481cfa by Victor Stinner in branch 'default': Issue #18609: Add a fast-path for "iso8859-1" encoding http://hg.python.org/cpython/rev/31f9c1481cfa -- ___ Python tracker

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Indeed, this sounds very much like the shell doing the unescaping, rather than argparse. (I wonder why argparse would special-case $, anyway) -- nosy: +pitrou ___ Python tracker _

[issue4331] Add functools.partialmethod

2013-10-29 Thread Nick Coghlan
Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue19420] Leak in _hashopenssl.c

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6fdbb81b4020 by Christian Heimes in branch 'default': Issue #19420: Fix reference leak in module initalization code of _hashopenssl.c http://hg.python.org/cpython/rev/6fdbb81b4020 -- nosy: +python-dev ___

[issue19420] Leak in _hashopenssl.c

2013-10-29 Thread Christian Heimes
Christian Heimes added the comment: Fixed in 3.4 Georg, 3.3 is currently in RC phase and this fix is not critical. Do you want me to commit it anyway or shall I wait until 3.3.3 has been released by you? -- ___ Python tracker

[issue19432] test_multiprocessing_fork failures

2013-10-29 Thread Stefan Krah
New submission from Stefan Krah: I'm getting the following test_multiprocessing_fork failures on Debian Wheezy. Perhaps this is related to #19227: test_default_timeout (test.test_multiprocessing_fork.WithThreadsTestBarrier) ... Exception in thread Thread-344: Traceback (most recent call last)

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread Nick Coghlan
Nick Coghlan added the comment: Christian's general approach looks fine to me - consolidating the "kind" hashes (i.e. byte sequences, numbers and pointers) into one place independent of any particular type implementation makes sense to me, and the clear abstraction of "What is a hash function?

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: + The above copyright notice and this permission notice shall be included in + all copies or substantial portions of the Software. You should copy the license into Doc/license.rst. -- nosy: +haypo ___ Python tracker

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread R. David Murray
R. David Murray added the comment: Indeed, you can see in the original posting that the \ is already gone from the dollar in sys.argv, so argparse has nothing to do with it. And it is indeed the shell doing the unescaping: rdmurray@session:~>cat test.sh #!/bin/bash echo "$@" rdmurray@session:~

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread R. David Murray
R. David Murray added the comment: Indeed, you can see in the original posting that the \ is already gone from the dollar in sys.argv, so argparse has nothing to do with it. And it is indeed the shell doing the unescaping: rdmurray@session:~>cat test.sh #!/bin/bash echo "$@" rdmurray@session:~

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread R. David Murray
Changes by R. David Murray : -- Removed message: http://bugs.python.org/msg201627 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: To support Windows 32 bit, the following code in PC/pyconfig.h can be modified to use __int64 or _W64: see ssize_t definition below in the same file. #ifndef PY_UINT64_T #if SIZEOF_LONG_LONG == 8 #define HAVE_UINT64_T 1 #define PY_UINT64_T unsigned PY_LONG_LONG

[issue19432] test_multiprocessing_fork failures

2013-10-29 Thread Stefan Krah
Stefan Krah added the comment: The issue is probably different from #19227, since it already occurs with 4e79c3ae8a12. -- components: +Extension Modules nosy: +sbt stage: -> needs patch type: -> behavior versions: +Python 3.3, Python 3.4 ___ Python

[issue19430] argparse replaces \$ with $ (if in commandline)

2013-10-29 Thread telmich
telmich added the comment: sorry for the noise, it was too early in the morning! -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue19432] test_multiprocessing_fork failures

2013-10-29 Thread Richard Oudkerk
Richard Oudkerk added the comment: This is a test of threading.Barrier rather than anything implemented directly by multiprocessing. Tests which involve timeouts tend to be a bit flaky. Increasing the length of timeouts usually helps, but makes the tests take even longer. How often have you

[issue4331] Add functools.partialmethod

2013-10-29 Thread alon horev
alon horev added the comment: I've changed the test according to the code review. Thanks -- Added file: http://bugs.python.org/file32409/4331.v2.patch ___ Python tracker ___ _

[issue19432] test_multiprocessing_fork failures

2013-10-29 Thread Stefan Krah
Stefan Krah added the comment: I've seen the failure very often, without any particular load. Now I noticed that during test_tools there were several ksoftirqd processes consuming 20% CPU on 4 cores. That seemed unusual to me, so I followed the advice of a certain MIT koan and rebooted. test_m

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread Christian Heimes
New submission from Christian Heimes: For PEP 456 it would be useful to have PY_UINT64_T on 32bit Windows. Does anybody see a problem with Victor's idea? I like it. Victor wrote in http://bugs.python.org/issue19183#msg201629: To support Windows 32 bit, the following code in PC/pyconfig.h can b

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread Christian Heimes
Christian Heimes added the comment: Victor: I have added the licence to Doc/licence.rst and created a new ticket for PY_UINT64_T on Windows #19433. Nick: The memory layout of the hash secret is now documented. I have renamed the members to reflect their purpose, too. http://hg.python.org/feat

[issue19229] operator.py: move the Python implementation in the else block of try/except ImportError

2013-10-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Why not: try: from _operator import * except ImportError: from _pyoperator import * -- nosy: +pitrou ___ Python tracker ___ __

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread Martin v . Löwis
Martin v. Löwis added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue19229] operator.py: move the Python implementation in the else block of try/except ImportError

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: > Why not: > > try: > from _operator import * > except ImportError: > from _pyoperator import * Let's try (I replaced operator.py with these 4 lines). $ ./python -m timeit "import sys; modname='operator'" "__import__(modname); del sys.modules[modname]

[issue19229] operator.py: move the Python implementation in the else block of try/except ImportError

2013-10-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: > "import operator" is only 2x faster (289 usec => 136 usec). It's less > interesting. The real question for me is: why are you interested in speeding up the import of the operator module? 200 µs won't make a visible difference. > And what would be the purpose

[issue19229] operator.py: move the Python implementation in the else block of try/except ImportError

2013-10-29 Thread Stefan Krah
Stefan Krah added the comment: I understand the desire to speed things up, but either the four-line facade module or else a single module is probably required by PEP-399. -- title: operator.py: move the Python implementation in the else block of try/except ImportError -> operator.py: m

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread Tim Golden
Tim Golden added the comment: Fine by me -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19434] Wrong documentation of MIMENonMultipart class

2013-10-29 Thread Vajrasky Kok
New submission from Vajrasky Kok: >>> from email.mime.nonmultipart import MIMENonMultipart >>> MIMENonMultipart.__doc__ 'Base class for MIME multipart/* type messages.' >>> Attached the patch to fix the doc of MIMENonMultipart class. -- assignee: docs@python components: Documentation fi

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: This issue has no patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue19435] Directory traversal attack for CGIHTTPRequestHandler

2013-10-29 Thread Alexander Kruppa
New submission from Alexander Kruppa: An error in separating the path and filename of the CGI script to run in http.server.CGIHTTPRequestHandler allows running arbitrary executables in the directory under which the server was started. The problem is that in CGIHTTPRequestHandler we have: de

[issue19435] Directory traversal attack for CGIHTTPRequestHandler

2013-10-29 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +christian.heimes, haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue19436] Python 2.7 on MAC OSX Mavericks crashes on the help('modules') command

2013-10-29 Thread lagoon7
New submission from lagoon7: /usr/lib/python2.7/dist-packages/gobject/constants.py:24: Warning: g_boxed_type_register_static: assertion `g_type_from_name (name) == 0' failed import gobject._gobject /usr/lib/python2.7/dist-packages/gtk-2.0/gtk/__init__.py:40: Warning: g_boxed_type_register_sta

[issue19435] Directory traversal attack for CGIHTTPRequestHandler

2013-10-29 Thread Christian Heimes
Christian Heimes added the comment: I can confirm the issue: $ mkdir www $ cd www $ cat << EOF > badscript.sh #!/bin/sh echo hacked EOF $ chmod +x badscript.sh $ ../python -m http.server --cgi $ echo "GET ///badscript.sh/../cgi-bin/cgi.sh HTTP/1.1" | nc localhost 8000 HTTP/1.0 200 Scr

[issue19435] Directory traversal attack for CGIHTTPRequestHandler

2013-10-29 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19435] Directory traversal attack for CGIHTTPRequestHandler

2013-10-29 Thread Stéphane Glondu
Changes by Stéphane Glondu : -- nosy: +glondu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue19436] Python 2.7 on Linux Ubuntu 12.04 LTS crashes on the help('modules') command

2013-10-29 Thread lagoon7
lagoon7 added the comment: Sorry I meant Linux instead of Mac OSX. -- title: Python 2.7 on MAC OSX Mavericks crashes on the help('modules') command -> Python 2.7 on Linux Ubuntu 12.04 LTS crashes on the help('modules') command ___ Python tracker

[issue19436] Python 2.7 on Linux Ubuntu 12.04 LTS crashes on the help('modules') command

2013-10-29 Thread Ned Deily
Changes by Ned Deily : -- assignee: ronaldoussoren -> resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> pydoc - stall when requesting a list of available modules in the online help utility ___ Python trac

[issue19437] More failures found by pyfailmalloc

2013-10-29 Thread STINNER Victor
New submission from STINNER Victor: Using pyfailamlloc, I found various bugs: see issue #18048. Because this issue has been closed, I'm opening a new issue for new bugs. https://bitbucket.org/haypo/pyfailmalloc -- messages: 201649 nosy: haypo priority: normal severity: normal status: o

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread Christian Heimes
Christian Heimes added the comment: It seems no patch is needed to get PY_UINT64_T on 32bit Windows: >>> import sys >>> sys.version '3.4.0a4+ (pep-456:f0a7e606c2d0, Oct 29 2013, 19:24:12) [MSC v.1600 32 bit (Intel)]' >>> sys.maxsize 2147483647 >>> sys.hash_info sys.hash_info(width=32, modulus=2

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread Tim Peters
Tim Peters added the comment: Yes, it should be taken care of already, because of this in PC/pyconfig.h: #ifdef MS_WIN32 ... #define SIZEOF_LONG_LONG 8 That defines the symbol triggering the PY_UINT64_T define shown in the original message in this issue. -- nosy: +tim.peters

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset daa1ab27b5c2 by Victor Stinner in branch 'default': Issue #19433: test_capi: add tests on the size of some C types http://hg.python.org/cpython/rev/daa1ab27b5c2 -- nosy: +python-dev ___ Python tracker

[issue19437] More failures found by pyfailmalloc

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e5bbaed79ca by Victor Stinner in branch 'default': Issue #19437: Fix Array_subscript() of ctypes, handle Array_item() failure http://hg.python.org/cpython/rev/1e5bbaed79ca New changeset fc825259ee86 by Victor Stinner in branch 'default': Issue #194

[issue19435] Directory traversal attack for CGIHTTPRequestHandler

2013-10-29 Thread janzert
Changes by janzert : -- nosy: +janzert ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: See also issue #17884: "Try to reuse stdint.h types like int32_t". -- ___ Python tracker ___ ___ Pyt

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I don't see a benefit from this patch. _PyUnicode_AsString() is very fast in most cases (because source lines are mostly ASCII only). On other hand, the patch replaces one-time _PyUnicode_AsString() by multiple less effective (even for ASCII strings) operati

[issue19433] Define PY_UINT64_T on Windows 32bit

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5bf96a96f31d by Victor Stinner in branch 'default': Issue #19433: test_capi: check signness of some C types http://hg.python.org/cpython/rev/5bf96a96f31d -- ___ Python tracker

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: > I don't see a benefit from this patch. Oh, sorry, I forgot to explain the motivation. Performances of the warnings module are not critical module. The motivation here is to avoid to encoding string to UTF-8 for correctness. For example, _PyUnicode_AsString(f

[issue19426] Opening a file in IDLE causes a crash or hang

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset e0475c44832f by Benjamin Peterson in branch '2.7': backport #19426 http://hg.python.org/cpython/rev/e0475c44832f -- ___ Python tracker

[issue11508] Virtual Interfaces cause uuid._find_mac to raise a ValueError under Linux

2013-10-29 Thread Kent Frazier
Kent Frazier added the comment: Serhiy, I signed the form. Let me know if you need anything else. -- ___ Python tracker ___ ___ Python

[issue19437] More failures found by pyfailmalloc

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5acbdcfc21c9 by Victor Stinner in branch 'default': Issue #19437: Fix dec_format() of the _decimal module, handle dec_strdup() http://hg.python.org/cpython/rev/5acbdcfc21c9 -- ___ Python tracker

[issue17936] O(n**2) behaviour when adding/removing classes

2013-10-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch replacing PyErr_Clear() with PyErr_WriteUnraisable(), and PyDict_Check() with PyDict_CheckExact(). -- Added file: http://bugs.python.org/file32411/subclasses_dict3.patch ___ Python tracker

[issue19227] test_multiprocessing_xxx hangs under Gentoo buildbots

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5942eea8cf41 by Christian Heimes in branch '3.3': Issue #19227 / Issue #18747: Remove pthread_atfork() handler to remove OpenSSL re-seeding http://hg.python.org/cpython/rev/5942eea8cf41 New changeset 705f2addd0f0 by Christian Heimes in branch 'defa

[issue18747] Re-seed OpenSSL's PRNG after fork

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5942eea8cf41 by Christian Heimes in branch '3.3': Issue #19227 / Issue #18747: Remove pthread_atfork() handler to remove OpenSSL re-seeding http://hg.python.org/cpython/rev/5942eea8cf41 New changeset cd4007fb9c7e by Christian Heimes in branch '3.3'

[issue19227] test_multiprocessing_xxx hangs under Gentoo buildbots

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset ad779da9e351 by Christian Heimes in branch '2.7': Issue #19227 / Issue #18747: Remove pthread_atfork() handler to remove OpenSSL re-seeding http://hg.python.org/cpython/rev/ad779da9e351 -- ___ Python tra

[issue18747] Re-seed OpenSSL's PRNG after fork

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset ad779da9e351 by Christian Heimes in branch '2.7': Issue #19227 / Issue #18747: Remove pthread_atfork() handler to remove OpenSSL re-seeding http://hg.python.org/cpython/rev/ad779da9e351 -- ___ Python tra

[issue17936] O(n**2) behaviour when adding/removing classes

2013-10-29 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue19438] Where is NoneType in Python 3?

2013-10-29 Thread Christian Heimes
Christian Heimes added the comment: How about: type(v) in (bytes, type(None)) or: isinstance(v, (bytes, type(None)) or: v is None or type(v) is bytes or: v is None or isinstance(v, bytes) -- nosy: +christian.heimes ___ Python tracke

[issue17936] O(n**2) behaviour when adding/removing classes

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset a7f1ce6fe293 by Antoine Pitrou in branch 'default': Issue #17936: Fix O(n**2) behaviour when adding or removing many subclasses of a given type. http://hg.python.org/cpython/rev/a7f1ce6fe293 -- nosy: +python-dev ___

[issue17936] O(n**2) behaviour when adding/removing classes

2013-10-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Actually, PyErr_Clear() was necessary in some cases. Now committed. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> pending ___ Python tracker __

[issue19438] Where is NoneType in Python 3?

2013-10-29 Thread mpb
New submission from mpb: types.NoneType seems to have disappeared in Python 3. This is probably intentional, but I cannot figure out how to test if a variable is of type NoneType in Python 3. Specifically, I want to write: assert type (v) in ( bytes, types.NoneType ) Yes, I could write: ass

[issue10112] Use -Wl, --dynamic-list=x.list, not -Xlinker -export-dynamic

2013-10-29 Thread Tom Tromey
Changes by Tom Tromey : -- nosy: +tromey ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue19438] Where is NoneType in Python 3?

2013-10-29 Thread mpb
mpb added the comment: Of your 4 suggestions, I mentioned #3 and #4 in my post. They are less readable, IMO. 1 and 2 are nicer, but both have an "extra" set of nested parenthesis. While I appreciate the suggestions, I submitted this as a documentation bug, because I think I should be able to

[issue19439] Build _testembed on Windows

2013-10-29 Thread Zachary Ware
New submission from Zachary Ware: Here's a patch that builds _testembed on Windows and adjusts test_capi to not skip EmbeddingTests on Windows. The .vcxproj is based on _freeze_importlib, with "when to build" settings lifted from _testimportmultiple. The patch also adjusts test_capi.Embedding

[issue19435] Directory traversal attack for CGIHTTPRequestHandler

2013-10-29 Thread Benjamin Peterson
Benjamin Peterson added the comment: Patch -- keywords: +patch Added file: http://bugs.python.org/file32413/cgi.patch ___ Python tracker ___ _

[issue15792] Fix compiler options for x64 builds on Windows

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset c49b8bdcb5cb by Tim Golden in branch '3.3': Issue 15792 Correct build options on Win64. Patch by Jeremy Kloth. http://hg.python.org/cpython/rev/c49b8bdcb5cb -- ___ Python tracker

[issue19439] Build _testembed on Windows

2013-10-29 Thread Nick Coghlan
Nick Coghlan added the comment: Nice! I wonder if there might a difference between the default console encoding and the default pipe encoding (that test assumes the default standard stream encodings will be the same in the current process as they are in the child). -- __

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: About memcpy(). Here is sample file. Compile it to assembler: gcc -O2 -S -masm=intel fnv.c With memcpy() main loop is compiled to: .L8: movzx ecx, BYTE PTR [ebx+edx] imuleax, eax, 103 add edx, 1 xor eax, ecx cmp edx, edi jn

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg201675 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19440] Clean up test_capi

2013-10-29 Thread Zachary Ware
Changes by Zachary Ware : Added file: http://bugs.python.org/file32416/test_capi_cleanup-3.3.diff ___ Python tracker ___ ___ Python-bugs-list

[issue19440] Clean up test_capi

2013-10-29 Thread Zachary Ware
New submission from Zachary Ware: Here's a patch to clean up test_capi a little bit; it removes a __future__ import, converts from test_main to unittest.main, and makes use of subtests to run each _testcapi function. I'll post a separate patch for 3.3; there's just enough difference between b

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: About memcpy(). Here is sample file. Compile it to assembler: gcc -O2 -S -masm=intel fnv.c With memcpy() main loop is compiled to: .L3: mov esi, DWORD PTR [ebx] imuleax, eax, 103 add ebx, 4 xor eax, esi sub ecx, 1 mov DWORD P

[issue19386] selectors test_interrupted_retry is flaky

2013-10-29 Thread Charles-François Natali
Charles-François Natali added the comment: Here's another failure: """ == FAIL: test_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolShutdownTest)

[issue19386] selectors test_interrupted_retry is flaky

2013-10-29 Thread R. David Murray
R. David Murray added the comment: Yes, it is a linux vserver VM. I would think we would want tests to not fail in VMs, though, in this day and age. -- ___ Python tracker ___ _

[issue19386] selectors test_interrupted_retry is flaky

2013-10-29 Thread R. David Murray
R. David Murray added the comment: Also, unless people haven't been reporting other errors, these buildbots have been stable up until recently, with the exception of the multiprocessing hangs that plague all the buildbots as far as I know. (My impression could be mistaken, though.) -

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Well, it looks reasonable. But an action should be ASCII only string. So perhaps we should first check PyUnicode_IS_ASCII() and then use PyUnicode_1BYTE_DATA() and strcpy(). -- ___ Python tracker

[issue19386] selectors test_interrupted_retry is flaky

2013-10-29 Thread Charles-François Natali
Charles-François Natali added the comment: > Also, unless people haven't been reporting other errors, these buildbots have > been stable up until recently Well, the fact that several tests - which were working just fine - started failing randomly recently (like test_concurrent_futures, test_sub

[issue19373] Tkinter apps including IDLE may not display properly on OS X 10.9 Mavericks

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset f5e0fd7db675 by Ned Deily in branch 'default': Issue #19373: Add Misc/NEWS entry. http://hg.python.org/cpython/rev/f5e0fd7db675 -- ___ Python tracker _

[issue19438] Where is NoneType in Python 3?

2013-10-29 Thread R. David Murray
R. David Murray added the comment: See http://www.python.org/dev/peps/pep-0294/ for some background on this. The unexpected thing is actually that the types module still exists at all in Python3 :) That said, its documentation could, indeed, use some improvement to address this kind of quest

[issue19386] selectors test_interrupted_retry is flaky

2013-10-29 Thread R. David Murray
R. David Murray added the comment: What could cause a VM clock problem on a machine that hasn't been modified, but the VMs have been rebooted recently (ie: it isn't stale state inside the VM itself). Anything you can suggest I look at? -- ___ Pytho

[issue19373] Tkinter apps including IDLE may not display properly on OS X 10.9 Mavericks

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset bcbe4099206f by Ned Deily in branch '2.7': Issue #19373: Apply upstream change to Tk 8.5.15 fixing OS X 10.9 http://hg.python.org/cpython/rev/bcbe4099206f -- ___ Python tracker

[issue19386] selectors test_interrupted_retry is flaky

2013-10-29 Thread R. David Murray
R. David Murray added the comment: I'm going to reboot the host just to see if that makes any difference. It's been up for 105 days. -- ___ Python tracker ___ _

[issue19413] Reload semantics changed unexpectedly in Python 3.3

2013-10-29 Thread Eric Snow
Eric Snow added the comment: Brett: any opinions on fixing this? 3.3? Nick: I'll add another test when I get a chance. -- ___ Python tracker ___ ___

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-29 Thread Christian Heimes
Changes by Christian Heimes : Added file: http://bugs.python.org/file32417/4756e9ed0328.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: "Well, it looks reasonable. But an action should be ASCII only string. So perhaps we should first check PyUnicode_IS_ASCII() and then use PyUnicode_1BYTE_DATA() and strcpy()." Such optimizations in warnings seem overkill, performances are not critical in this

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 34e166d60f37 by Victor Stinner in branch 'default': Issue #19424: Optimize PyUnicode_CompareWithASCIIString() http://hg.python.org/cpython/rev/34e166d60f37 -- nosy: +python-dev ___ Python tracker

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset c7326aa0b69c by Victor Stinner in branch 'default': Issue #19424: Fix the warnings module to accept filename containing surrogate http://hg.python.org/cpython/rev/c7326aa0b69c -- ___ Python tracker

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread STINNER Victor
STINNER Victor added the comment: @Serhiy: Thanks for your review. I modified warnings.warn_explicit() to reject types different than str for the filename. I also removed the useless optimization for PyUnicode_Substring() when i=0. -- ___ Python tra

[issue19441] itertools.tee improve documentation

2013-10-29 Thread Alan Cristhian
New submission from Alan Cristhian: I had some problems using itertools.tee function. Fortunately I found the following advice on the PEP-323: "Currently, the copied iterators remaintied to the original iterator. If the original advances, then so do all of the copies. Good practice is to overw

[issue19424] _warnings: patch to avoid conversions from/to UTF-8

2013-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 05e8dde3229c by Victor Stinner in branch 'default': Issue #19424: Fix test_warnings for locale encoding unable to encode http://hg.python.org/cpython/rev/05e8dde3229c -- ___ Python tracker

  1   2   >