[issue19266] Rename contextlib.ignore to contextlib.suppress

Raymond Hettinger added the comment: After more thought, I think that suppress() isn't as clear as ignore() and it doesn't read as well in typical use cases. I'm assigning this one back to Nick to decide. If you want to scan existing code for examples to see how well this would read, run thi

[issue18723] shorten function of textwrap module is susceptible to non-normalized whitespaces

Vajrasky Kok added the comment: Serhiy's commit http://hg.python.org/cpython/rev/2e8c424dc638 fixed this issue already. So I closed this ticket. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue19266] Rename contextlib.ignore to contextlib.suppress

STINNER Victor added the comment: On python-dev, abort_on() and trap() were proposed. -- nosy: +haypo ___ Python tracker ___ ___ Pytho

[issue19270] sched.cancel() breaks events order

New submission from Serhiy Storchaka: sched.cancel() breaks events order if events are scheduled on same time and have same priority. Patch contains tests which expose this issue. -- components: Library (Lib) files: sched_test_stable.patch keywords: patch messages: 200040 nosy: giampao

[issue13451] sched.py: speedup cancel() method

Changes by Serhiy Storchaka : -- dependencies: +sched.cancel() breaks events order ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19271] Update OrderedDict "see also" link

New submission from Mark Lawrence: Both Python 2 and 3 docs refer to Raymond Hettinger's original recipe here http://code.activestate.com/recipes/576693/. Would it be better to link to pypi https://pypi.python.org/pypi/ordereddict? -- assignee: docs@python components: Documentation me

[issue19271] Update OrderedDict "see also" link

Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger priority: normal -> low ___ Python tracker ___ ___

[issue16500] Add an 'atfork' module

Changes by Aaron Iles : -- nosy: +aliles ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue17087] Improve the repr for regular expression match objects

Claudiu.Popa added the comment: Serhiy, are there any left issues with my latest patch? It would be nice if we could get this into 3.4. -- ___ Python tracker ___ ___

[issue13451] sched.py: speedup cancel() method

Serhiy Storchaka added the comment: All patches have problem with stable order. Rehashifying change it. But there are even more serious problems with current code (see issue19270). -- ___ Python tracker __

[issue19266] Rename contextlib.ignore to contextlib.suppress

Raymond Hettinger added the comment: I oppose abort_on() because it implies that it aborts the program. The word trap() is accurate but will be weird-sounding and non-communicative to users without a CS background: with trap(sqlite3.OperationalError): cursor.execute('CREATE TABLE d

[issue18468] re.group() should never return a bytearray

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18468] re.group() should never return a bytearray

Roundup Robot added the comment: New changeset add40e9f7cbe by Serhiy Storchaka in branch 'default': Issue #18468: The re.split, re.findall, and re.sub functions and the group() http://hg.python.org/cpython/rev/add40e9f7cbe -- nosy: +python-dev ___ Py

[issue18725] Multiline shortening

Vajrasky Kok added the comment: Serhiy, you forgot to add shorten to __all__. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue18468] re.group() should never return a bytearray

Serhiy Storchaka added the comment: Thank you Antoine for your review. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue19270] sched.cancel() breaks events order

Serhiy Storchaka added the comment: Actually there are two bugs: 1. sched.cancel() can remove wrong event (because it uses equality instead identity). 2. sched.cancel() change order of equal (by time and priority) events. -- ___ Python tracker

[issue18725] Multiline shortening

Roundup Robot added the comment: New changeset 0bd257cd3e88 by Serhiy Storchaka in branch 'default': Add shorten to __all_ (issues #18585 and #18725). http://hg.python.org/cpython/rev/0bd257cd3e88 -- ___ Python tracker

[issue18725] Multiline shortening

Serhiy Storchaka added the comment: Thank you Vajrasky. It's Antoine forgot. ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18585] Add a text truncation function

Roundup Robot added the comment: New changeset 0bd257cd3e88 by Serhiy Storchaka in branch 'default': Add shorten to __all_ (issues #18585 and #18725). http://hg.python.org/cpython/rev/0bd257cd3e88 -- ___ Python tracker

[issue19266] Rename contextlib.ignore to contextlib.suppress

Stefan Krah added the comment: trap() is a bit ambiguous, since in floating point operations it means that something is actually raised and not suppressed. So one could write: from decimal import * c = getcontext() c.traps[Inexact] = True >>> Decimal(9) / 11 # raises now! with trap(Inexact):

[issue17087] Improve the repr for regular expression match objects

Claudiu.Popa added the comment: Added the new patch, which addresses Serhiy's comments. Also, this approach fails when bytes are involved: >>> import re >>> re.search(b"a", b"a") Assertion failed: (PyUnicode_Check(op)), function _PyUnicode_CheckConsistency, file Objects/unicodeobject.c, line 30

[issue19266] Rename contextlib.ignore to contextlib.suppress

Zero Piraeus added the comment: 'Ignore' and 'suppress' are not synonyms: https://www.google.com/search?q=define%3Asuppress > forcibly put an end to. > "the rising was savagely suppressed" > synonyms: subdue, repress, crush, quell, quash, squash, stamp out https://www.google.com/search?q=defin

[issue17087] Improve the repr for regular expression match objects

Serhiy Storchaka added the comment: Use correct first argument to getslice(). -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue19266] Rename contextlib.ignore to contextlib.suppress

Stefan Krah added the comment: Zero Piraeus wrote: > 'Ignore' and 'suppress' are not synonyms: I wrote "synonyms here", meaning that in *this context* they are practically synonyms. "suppress" describes the mechanics more precisely, "ignore" descibes the human intent: suppress_and_thereby_ignor

[issue5342] packaging: add tests for old versions cleanup on update

Sergio Callegari added the comment: Getting bitten by this with numpy/scipy installations Having previous scipy installed, pip install -I scipy creates a broken scipy installation, because the previous one is not removed and gets overwritten. For instance, an old spectral.so file leftover

[issue18314] Have os.unlink remove junction points

Kim Gräsman added the comment: Gentle ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue17087] Improve the repr for regular expression match objects

Claudiu.Popa added the comment: Latest patch attached. -- Added file: http://bugs.python.org/file32144/sre_repr5.patch ___ Python tracker ___

[issue18999] Robustness issues in multiprocessing.{get, set}_start_method

Roundup Robot added the comment: New changeset 72a5ac909c7a by Richard Oudkerk in branch 'default': Issue #18999: Make multiprocessing use context objects. http://hg.python.org/cpython/rev/72a5ac909c7a -- nosy: +python-dev ___ Python tracker

[issue18999] Support different contexts in multiprocessing

Changes by Richard Oudkerk : -- resolution: -> fixed stage: -> committed/rejected status: open -> pending title: Robustness issues in multiprocessing.{get,set}_start_method -> Support different contexts in multiprocessing type: behavior -> enhancement

[issue18999] Support different contexts in multiprocessing

Lars Buitinck added the comment: Thanks, much better than my solution! -- status: pending -> open ___ Python tracker ___ ___ Python-bu

[issue5342] packaging: add tests for old versions cleanup on update

Changes by Alan Cristhian : -- nosy: +Alan.Cristhian ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19272] Can't pickle lambda (while named functions are ok)

New submission from Facundo Batista: This is ok: Python 3.4.0a3+ (default:86af5991c809, Oct 13 2013, 16:42:52) ... >>> import pickle >>> def f(): ... pass ... >>> pickle.dumps(f) b'\x80\x03c__main__\nf\nq\x00.' However, when trying to pickle a lambda, it fails: >>> >>> pickle.du

[issue19272] Can't pickle lambda (while named functions are ok)

Amaury Forgeot d'Arc added the comment: Functions are pickled by name, not by code. Unpickling will only work if a function with the same name is present in in the same module (__main__ in your example) This is why pickling a lambda won't work: they have no individual names. -- nosy: +

[issue18999] Support different contexts in multiprocessing

Changes by Richard Oudkerk : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue19272] Can't pickle lambda (while named functions are ok)

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19272] Can't pickle lambda (while named functions are ok)

Jesús Cea Avión added the comment: Would be interesting to be able to pickle "function.__code__". Although, thinking about this, it would be not portable between Python releases, something that pickle guarantee. Thoughs? -- ___ Python tracker

[issue17087] Improve the repr for regular expression match objects

Serhiy Storchaka added the comment: It is too complicated (and perhaps erroneous). Why not use just self->pattern->logical_charsize? -- ___ Python tracker ___ __

[issue19272] Can't pickle lambda (while named functions are ok)

Ethan Furman added the comment: According to the docs[1]: 12.1.4. What can be pickled and unpickled? The following types can be pickled: - None, True, and False - integers, floating point numbers, complex numbers - strings, bytes, bytearrays - tuples, lists, sets, and dictionar

[issue19272] Can't pickle lambda (while named functions are ok)

Facundo Batista added the comment: Ethan, lambda functions are included in "functions defined at the top level of a module". Probably we should note there something like "except lambdas, because function pickling is by name, not by code". -- ___ Py

[issue19272] Can't pickle lambda (while named functions are ok)

Facundo Batista added the comment: Jesús, Amaury: What if pickle would assign a random unique name to the lambda (like, an UUID) so it can be pickled and unpickled? -- ___ Python tracker _

[issue19272] Can't pickle lambda (while named functions are ok)

Ethan Furman added the comment: Yeah, that one line should say, "named functions defined at the top level of a module". The following three paragraphs do, however, mention "named" several times. Sounds like a doc issue. -- ___ Python tracker

[issue19272] Can't pickle lambda (while named functions are ok)

Ethan Furman added the comment: The problem with a randam unique name is making sure you get the same random unique name across different runs, different pythons, and different orders of execution. -- ___ Python tracker

[issue11489] json.dumps not parsable by json.loads (on Linux only)

Taras Prokopenko added the comment: You should use ensure_ascii=False option to json.dumps, ie import json unicode_bytes = '\xed\xa8\x80' unicode_string = unicode_bytes.decode("utf8") json_encoded = json.dumps(unicode_string, ensure_ascii=False) json.loads(json_encoded),unicode_string (u'\uda00

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Guido van Rossum added the comment: New patch, mostly SSL hardening IIRC. -- Added file: http://bugs.python.org/file32145/asyncio7.patch ___ Python tracker ___ __

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Guido van Rossum added the comment: I could use some help for two issues with the tests: (1) How do I stop regrtest.py from running the windows tests? (These import _winapi.) 2 tests failed: test_asyncio.test_windows_events test_asyncio.test_windows_utils (2) I get this message -- what d

[issue19272] Can't pickle lambda (while named functions are ok)

R. David Murray added the comment: So don't make it random, use a hash of the code object :) (I'm not sure I'm serious, the thought just popped into my head...) -- nosy: +r.david.murray ___ Python tracker

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Ned Deily added the comment: 1) The test case decorator perhaps: @unittest.skipIf(sys.platform == "win32", "Does not apply to Windows") -- nosy: +ned.deily ___ Python tracker __

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Martin Matusiak added the comment: I've checked sys.version on IronPython 2.6.1, 2.6.2 (same format) and 2.7.4 (slightly different). The patch includes two new test cases. I've also taken the liberty of adding some newlines in between the items in the dict as I found this code very hard to re

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Ned Deily added the comment: 2) See class saved_test_environment in regrtest.py. I wouldn't worry too much about it initially but it should be looked at and tidied up before release. -- ___ Python tracker ___

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Richard Oudkerk added the comment: On 16/10/2013 8:14pm, Guido van Rossum wrote: > (2) I get this message -- what does it mean and should I care? > 2 tests altered the execution environment: > test_asyncio.test_base_events test_asyncio.test_futures Perhaps threads from the ThreadExecutor ar

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Guido van Rossum added the comment: I'd have to decorate a lot of tests. Is there a way to fix this at the module or at least class level? (I'd be willing to move the imports around.) -- ___ Python tracker ___

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Richard Oudkerk added the comment: I think at module level you can do if sys.platform != 'win32': raise unittest.SkipTest('Windows only') -- ___ Python tracker ___

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Guido van Rossum added the comment: Yup, that works! Not uploading a new patch right now but this is in the tulip repo now. -- ___ Python tracker ___ __

[issue19262] Add asyncio (tulip, PEP 3156) to stdlib

Benjamin Peterson added the comment: You can skip classes with skipIf as a class decorator. -- nosy: +benjamin.peterson ___ Python tracker ___ ___

[issue19213] platform.linux_distribution detects Oracle Linux as Red Hat Enterprise Linux

Alexander Boyd added the comment: They're providing both /etc/oracle-release and /etc/redhat-release (as Oracle Linux is based on RHEL). I've attached /etc/oracle-release for reference. -- Added file: http://bugs.python.org/file32147/oracle-release

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Changes by Berker Peksag : -- stage: needs patch -> patch review versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bu

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Marc-Andre Lemburg added the comment: The patch looks good, except one nit: if 'IronPython' in sys_version is probably not supported in IronPython 2.0, since support for "n-char in m-char" tests were added after Python 2.1. Now, you can either leave this in and remove the IronPython 2.0 suppo

[issue19273] Update PCbuild/readme.txt

New submission from Zachary Ware: Full title: Update PCbuild/readme.txt to be more accurate, more descriptive, more complete, less repetitive, more audience-aware, and all around, hopefully, better. What started as a simple patch to fix the supported Windows versions list, the legacy build fo

[issue19273] Update PCbuild/readme.txt

Zachary Ware added the comment: Here's the patched file for easier review. -- Added file: http://bugs.python.org/file32149/patched_pcbuild_readme.txt ___ Python tracker ___ _

[issue19213] platform.linux_distribution detects Oracle Linux as Red Hat Enterprise Linux

R. David Murray added the comment: Gah. Well, by good fortune 'o' comes before 'r' in the alphabet, so it should be enough to just add 'oracle' to the list of _supported_dists in platform.py. Can you test that and confirm it? -- ___ Python tracker

[issue19274] make zipfile.PyZipFile more usable

New submission from Christian Tismer: zipfile.PyZipFile needs a filter function. Reason: When creating an archive of the python lib, we don't want the tests. Especially the test file "badsyntax_future3.py" does not compile. Use case: With this little addition, it becomes very easy to create a

[issue19274] make zipfile.PyZipFile more usable

Christian Tismer added the comment: Here is my use case as an example. With this patch above, I can easily create a .zip file of the standard lib. This was no longer possible at all, after revision 17558, from 2001-04-18: """This is a test""" from __future__ import nested_scopes from __future__

[issue19272] Can't pickle lambda (while named functions are ok)

Jesús Cea Avión added the comment: Lambdas are "anonymous" functions, by definition. And, usually, they are not top level functions, but defined inside others. If at your "top level" (module) you do: """ a = lambda x: 2*x """ You don't have an anonymous function, but a function called "a". Yo

[issue19266] Rename contextlib.ignore to contextlib.suppress

Changes by Alexander Belopolsky : -- dependencies: +Add context manager for the "try: ... except: pass" pattern ___ Python tracker ___ ___

[issue15806] Add context manager for the "try: ... except: pass" pattern

Changes by Alexander Belopolsky : -- superseder: -> Rename contextlib.ignore to contextlib.suppress ___ Python tracker ___ ___ Python

[issue19266] Rename contextlib.ignore to contextlib.suppress

Alexander Belopolsky added the comment: > Please give some weight to the fact the ignore() was > checked in for seven months, ... +1 -- nosy: +belopolsky ___ Python tracker ___

[issue19266] Rename contextlib.ignore to contextlib.suppress

R. David Murray added the comment: Yes, in this context ingnore, suppress, and silence all have essentially the same problem, or lack of it, depending on your point of view. Catch would be fine with me :) Please note that someone *reading the thread* on python-dev misunderstood what ignore di

[issue19266] Rename contextlib.ignore to contextlib.suppress

R. David Murray added the comment: To be clear: I do think 'suppress' is better than 'ignore', for the reasons Nick articulated. -- ___ Python tracker ___ __

[issue19266] Rename contextlib.ignore to contextlib.suppress

Raymond Hettinger added the comment: On Oct 16, 2013, at 3:55 PM, R. David Murray wrote: > Catch would be fine with me :) I like "catch". Raymond -- ___ Python tracker ___ __

[issue19266] Rename contextlib.ignore to contextlib.suppress

Nick Coghlan added the comment: I didn't choose suppress on a whim. I actually agree with Raymond that ignore reads better when the context manager is used correctly, but suppress is more consistent with the terminology used in the documentation (including even PEP 343), *and* I think it is sligh

[issue19266] Rename contextlib.ignore to contextlib.suppress

Alexander Belopolsky added the comment: > Catch would be fine with me :) Both "catch" and "trap" have the same problem in my view: you don't get to eat what you have caught (or trapped). :-) > Please note that someone *reading the thread* on python-dev > misunderstood what ignore did after *

[issue19266] Rename contextlib.ignore to contextlib.suppress

Nick Coghlan added the comment: The reason I specifically *don't* like trap or catch for this is that they both have "... and do something with it" connotations for me, whereas ignore and suppress both appropriately imply "... and silently discard it". -- ___

[issue19266] Rename contextlib.ignore to contextlib.suppress

Nick Coghlan added the comment: Agreed it's a close call - it's really the docs consistency issue that tipped the balance for me, since I think either ignore *or* suppress would be a suitable name for the pattern when used correctly. -- ___ Python tra

[issue19272] Can't pickle lambda (while named functions are ok)

Ethan Furman added the comment: >From the pickle docs: = Note that functions (built-in and user-defined) are pickled by “fully qualified” name reference, not by value. This means that only the function name is pickled, along wi

[issue19266] Rename contextlib.ignore to contextlib.suppress

Alexander Belopolsky added the comment: Feel free to ignore() me if it helps to close this debate. English is not my native language and my understanding may not match that of the majority of users. Note, however, that this debate might not even have started if not for a change s/ignored/ign

[issue19266] Rename contextlib.ignore to contextlib.suppress

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19273] Update PCbuild/readme.txt

Changes by Ned Deily : -- nosy: +brian.curtin, christian.heimes, loewis, tim.golden ___ Python tracker ___ ___ Python-bugs-list mailin

[issue19272] Can't pickle lambda (while named functions are ok)

Ethan Furman added the comment: Jesús Cea Avión added the comment: > > If at your "top level" (module) you do: > > """ > a = lambda x: 2*x > """ > > You don't have an anonymous function, but a function called "a". Actually, you do have an anonymous function, which happens to be bound to the

[issue19252] Enum.py : Enum.__new__() : Test Coverage

Roundup Robot added the comment: New changeset 89f6abc2e115 by Ethan Furman in branch 'default': Close #19252: better test coverage for Enum. Thanks, CliffM http://hg.python.org/cpython/rev/89f6abc2e115 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: ope

[issue18919] Unify audio modules tests

R. David Murray added the comment: It looks like test_wave is still failing on PPC64 PowerLinux: http://buildbot.python.org/all/builders/PPC64%20PowerLinux%203.x/builds/850/steps/test/logs/stdio -- ___ Python tracker

[issue19275] test_site is failing on AMD64 Snow Leopard

New submission from R. David Murray: See eg http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/158/steps/test/logs/stdio -- keywords: buildbot messages: 200104 nosy: r.david.murray priority: normal severity: normal status: open title: test_site is failing on AMD64

[issue18891] Master patch for content manager addtion to email package.

Roundup Robot added the comment: New changeset 6d12285e250b by R David Murray in branch 'default': #18891: Complete new provisional email API. http://hg.python.org/cpython/rev/6d12285e250b -- nosy: +python-dev ___ Python tracker

[issue18891] Master patch for content manager addtion to email package.

Eric Snow added the comment: nice! Thanks for doing this. -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue1615] PyObject_GenericGetAttr suppresses AttributeErrors in descriptors

Changes by Raymond Hettinger : -- assignee: rhettinger -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue19276] test_wave failing on PPC64 Linux

Changes by David Edelsohn : -- components: Extension Modules nosy: David.Edelsohn priority: normal severity: normal status: open title: test_wave failing on PPC64 Linux type: behavior versions: Python 3.3, Python 3.4, Python 3.5 ___ Python tracker

[issue18891] Master patch for content manager addition to email package

Changes by Arfrever Frehtes Taifersar Arahesis : -- title: Master patch for content manager addtion to email package. -> Master patch for content manager addition to email package ___ Python tracker __

[issue18678] Wrong struct members name for spwd module

Vajrasky Kok added the comment: I think giving deprecation message when accessing incorrect attribute from spwd struct is not practical. You're right, R. David Murray, as you can see in spwd_struct_members_name_fix_v2.patch. So I make a simpler patch. I just give a deprecation message in the s

[issue1615] PyObject_GenericGetAttr suppresses AttributeErrors in descriptors

Ethan Furman added the comment: Well, attached patch doesn't segfault in debug mode, but the errors aren't any better; in fact, I'd say their worse. Here's the current output from my test script: === getter failed for descriptor 'huh'

[issue1615] PyObject_GenericGetAttr suppresses AttributeErrors in descriptors

Ethan Furman added the comment: If anyone with more experience wants ownership, feel free to take it from me. ;) Otherwise I'll do my best to get this figured out in time for the beta. -- assignee: -> ethan.furman stage: -> needs patch ___ Python

[issue8297] AttributeError message text should include module name

Changes by Ethan Furman : -- assignee: -> ethan.furman versions: +Python 3.4 -Python 2.7, Python 3.2 ___ Python tracker ___ ___ Python

[issue8964] platform._sys_version does not parse correctly IronPython 2.x version

Martin Matusiak added the comment: Hm, I see. Actually, "in" is already used in this function a little further down: elif "PyPy" in sys_version: So we should change both occurrences then. I'm attaching a v2 with these changes. -- Added file: http://bugs.python.org/file32154/issue

[issue17087] Improve the repr for regular expression match objects

Claudiu.Popa added the comment: I could use self->pattern->logical_size, but it seems that I still need the call to getstring for bytes & co, to obtain the view to the underlying buffer (otherwise the group0 part from the repr will contain random bytes). I didn't find a simpler way to achieve

[issue19274] make zipfile.PyZipFile more usable

Georg Brandl added the comment: Looks fine but -- as a new feature -- is 3.4 only, and needs docs and tests. -- nosy: +georg.brandl stage: -> patch review versions: +Python 3.4 -Python 2.7 ___ Python tracker _