[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread Charles-François Natali
Charles-François Natali added the comment: > You might also add a check: > > self.assertLessEqual(remaining_fds, {0, 1, 2}) Well no, because the interpreter might have other FDs open than stdin, stdout and stderr. -- ___ Python tracker

[issue18820] json.dump() ignores its 'default' option when serializing dictionary keys

2013-08-23 Thread Ezio Melotti
Ezio Melotti added the comment: Are there already tests that cover the changes in your patch? If not, could you add them? -- nosy: +ezio.melotti, pitrou, rhettinger stage: -> test needed ___ Python tracker _

[issue16123] IDLE - deprecate running without a subprocess

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Slight correction: While I do not believe I have seen *clipboard* contents pasted, after running a program from the editor that prints (to the shell), I *have* seen the last line reprinted when trying to enter something new as the prompt. This sometimes might

[issue17741] event-driven XML parser

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 815f328a6578 by Antoine Pitrou in branch 'default': Issue #17741: use composition, rather than inheritance, for xml.etree.iterparse's result class. http://hg.python.org/cpython/rev/815f328a6578 -- ___ Py

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've committed the inheritance removal patch. I personally don't think there's anything more to do, since the TreeEventBuilder proposal stumbled on some implementation issues. -- status: open -> closed ___ Python tr

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: I was asking for the current implementation to be removed until we have a working implementation that hurts neither the API nor the module design. -- ___ Python tracker ___

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I was asking for the current implementation to be removed until we > have a working implementation that hurts neither the API nor the > module design. It would help if we could keep the discussion on rational terms. -- ___

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 42aecc601a41 by Antoine Pitrou in branch 'default': Back out 5bd9db528aed (issue #18408). It caused unsolved buildbot failures. http://hg.python.org/cpython/rev/42aecc601a41 -- ___ Python tracker

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Victor, I'll let you find out how to improve your debug checks, but in the meantime I've reverted the commit that randomly broke some Windows buildbots. -- nosy: +pitrou ___ Python tracker

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: I don't think I understand what you mean. In any case, it's not to late to remove the implementation. There was only one alpha release so far that included it, so it can't really break any existing code that relies on it. The longer we wait, the more damage wil

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > In any case, it's not to late to remove the implementation. As far as I can say, there's no reason to remove the implementation except for your distaste of the method names. -- ___ Python tracker

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: To wrap things up: - the feature is desireable - the API is reasonable - the implementation is functional and properly tested Really, if you can't come up with an actual blocker, I'll ask you to leave this issue at rest. -- ___

[issue18783] No more refer to Python "long"

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: For msilib, 'int numbers' should just be 'ints' or 'integers'. --- For PC/winreg.c '''\ PyDoc_STRVAR(PyHKEY_Detach_doc, "key.Detach() -> int\n" ... "On 64 bit windows, the result of this function is a long integer");''' This last line should be deleted rather th

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: Could we please keep the discussion on rational terms? It's not just the method names. The problem is that you are duplicating an existing class (the XMLParser) for no good reason, instead of putting the feature where it belongs: *behind* the XMLParser. Even wo

[issue18820] json.dump() ignores its 'default' option when serializing dictionary keys

2013-08-23 Thread July Tikhonov
July Tikhonov added the comment: Proposed tests attached. -- Added file: http://bugs.python.org/file31450/json-default-tests.diff ___ Python tracker ___ _

[issue18803] Fix more typos in .py files

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Incorrect fixes. accidentaly -> accidentally occurence -> occurrence -- nosy: +terry.reedy ___ Python tracker ___ __

[issue18757] Fix internal references for concurrent modules

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6575074aae1c by Serhiy Storchaka in branch '3.3': Issue #18757: Improved cross-references in the concurrent package. http://hg.python.org/cpython/rev/6575074aae1c New changeset 383d85249997 by Serhiy Storchaka in branch 'default': Issue #18757: Impr

[issue18757] Fix internal references for concurrent modules

2013-08-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for the review Ezio. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker _

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: Close_fds is not supposed to close them? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: I didn't know that buildbots are failing. Do you have at least an example? An error message, anything? -- ___ Python tracker ___ ___

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: It's reported in issue18664 (you're nosied there :-)). -- ___ Python tracker ___ ___ Python-bugs-lis

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread Charles-François Natali
Charles-François Natali added the comment: > Close_fds is not supposed to close them? Yes, but some new fds might be open in the child process, e.g. for /dev/urandom. That's why it's better to check that this precise FD is closed. Of course, if the /dev/urandom FD gets assigned the same FD as th

[issue18810] Stop doing stat calls in importlib.machinery.FileFinder to see if something is a file or folder

2013-08-23 Thread Brett Cannon
Brett Cannon added the comment: I don't think it's related to the test_imp bug, but since it was never fully diagnosed I couldn't tell you. -- ___ Python tracker ___ ___

[issue18810] Stop doing stat calls in importlib.machinery.FileFinder to see if something is a file or folder

2013-08-23 Thread Brett Cannon
Brett Cannon added the comment: I did a quick check and at least stripping out the two stat calls for a directory or module file (left in package __init__.py) didn't make a significant difference. -- ___ Python tracker

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > The problem is that you are duplicating an existing class (the > XMLParser) for no good reason No. The logic was already in _IterParseIterator, just wrapped up differently. And the proof is that the original commit, while adding a feature, *removed* code from

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Can you sum the use cases for these? (don't want to read a blog post, sorry :-)) -- nosy: +pitrou ___ Python tracker ___ ___

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: > Yes, but some new fds might be open in the child process, e.g. for > /dev/urandom. The issue #18756 is not implemented not, and I'm still opposed to change os.random() to use persistent FD :) Ok, no problem for not checking others FD, it's not the purpose o

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: "The email package needs has_escaped_bytes. Currently it tries to encode to ascii to find out if there are any, which we proved by microbenchmark is the fastest way to do it as things stand." In which function you need to check this? What do you do if there a

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Well, read the thread! http://mail.python.org/pipermail/python-dev/2009-June/090021.html Basically just a couple of +1's, and a good suggestion to name it something clearer than "crtime". Please fix it! -- nosy: +Zooko.Wilcox-O'Hearn ___

[issue18747] Re-seed OpenSSL's PRNG after fork

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: Oh i forgot that i wrote a patch for openssl: https://bitbucket.org/haypo/hasard/src/tip/patches/openssl_rand_fork.patch -- ___ Python tracker _

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: I don't think we should hijack st_ctime. All the other members of the stat object correspond exactly to what you get back from the Unix stat() call. Let's not break that. How about just leaving st_ctime as it is and adding st_creationtime, which will have t

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: Given that it seems to be hard to come to a consensus in this ticket, I've asked for removal of the code on python-dev. http://mail.python.org/pipermail/python-dev/2013-August/128095.html -- ___ Python tracker

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread R. David Murray
R. David Murray added the comment: The email package uses surrogateescape to store unknown bytes in unicode strings, just as with the handle-bad-data-from-os API surrogateescape was introduced for. (For the same reason: the source data may have improperly encoded bytes that we must neverthele

[issue18823] Idle: use pipes instead of sockets to talk with user subprocess

2013-08-23 Thread Terry J. Reedy
New submission from Terry J. Reedy: Idle once used os.spawnv to open the user subprocess and 2.7 still does. Sockets were then used to interact with the subprocess. Since rev71746, 2011-8-3, 3.2+ use subprocess.Popen but still use sockets. A rare but continual problem is failure to make the so

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Benjamin Peterson: what do you mean "hijack ctime"? I don't think I — or anyone — has proposed anything that fits that description. Please be more specific. My proposal in http://bugs.python.org/issue5720#msg85750 does not break anything. -- _

[issue16123] IDLE - deprecate running without a subprocess

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I opened #18823 "Idle: use pipes instead of sockets to talk with user subprocess" I think this or a socket fix is needed before we remove -n. -- ___ Python tracker ___

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Indeed, "hijacking" is a bit strong. I mean filling it with a value that is not in the underlying st_ctime field from stat() call. -- ___ Python tracker

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Benjamin: I'm sorry, I still don't understand. Do you think my proposal would involve setting something named "ctime" to contain a value that didn't come from the underlying stat "ctime"? -- ___ Python tracker

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: You're quite right. I stupidly misread "crtime" as "ctime". -- ___ Python tracker ___ ___ Python-b

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Aha! Mystery solved. I wouldn't say that you were stupid — I would say that "crtime" is way too close to "ctime", and I strongly agree with the suggestion (http://mail.python.org/pipermail/python-dev/2009-June/090026.html) on the mailing list by Greg Ewi

[issue18307] Relative path in co_filename for zipped modules

2013-08-23 Thread Vitaly Murashev
Vitaly Murashev added the comment: unit-test attached. There are 3 tests inside it: 2 failed, 1 succeeded. According to this test results it becomes clear that specified issue is reproduced only with zip modules which contain precompiled bytecode inside (pyc-files) -- Added file: http

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread Nick Coghlan
Nick Coghlan added the comment: The use case is to take data from a surrogate escaped interface and either filter it out entirely or convert it to a valid Unicode string at the point of *input*, before letting it make its way into the rest of the application. For example, this approach permits th

[issue18808] Thread.join returns before PyThreadState is destroyed

2013-08-23 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17883] Fix buildbot testing of Tkinter

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: ezio.melotti -> terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue15125] argparse: positional arguments containing - in name not handled well

2013-08-23 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17974] Migrate unittest to argparse

2013-08-23 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17741] event-driven XML parser

2013-08-23 Thread Nick Coghlan
Nick Coghlan added the comment: Using tulip-inspired method names (when tulip hasn't landed) to duplicate existing data input functionality (feed() and close()) seems a rather dubious design decision to me. Given how popular lxml.etree is as an alternative to the standard library's etree impl

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread Armin Rigo
Armin Rigo added the comment: @Serhiy: it's a behavior change and as such not an option for a micro release. For example, the following legal code would behave differently: it would compute s = '\\u1234' instead of s = 'UTF8:\xe1\x88\xb4'. try: s = repr(x) except UnicodeEncode

<    1   2