[issue18644] Got ResourceWarning: unclosed file when using test function from formatter module

2013-08-12 Thread Vajrasky Kok
Vajrasky Kok added the comment: Thanks, Benjamin, for reviewing my patch. Attached the fourth patch to wrap the "business" part inside the try ... finally. -- Added file: http://bugs.python.org/file31237/formatter_fix_resource_warning_v4.patch ___

[issue18644] Got ResourceWarning: unclosed file when using test function from formatter module

2013-08-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: That will fail if fp is not assigned before an exception is raised. I mostly mean the part starting with the for loop. -- ___ Python tracker ___

[issue18644] Got ResourceWarning: unclosed file when using test function from formatter module

2013-08-12 Thread Vajrasky Kok
Vajrasky Kok added the comment: Ah, sorry about that. Attached the fifth patch to only wrap "for loop" section inside the try... finally. -- Added file: http://bugs.python.org/file31238/formatter_fix_resource_warning_v5.patch ___ Python tracker

[issue18606] Add statistics module to standard library

2013-08-12 Thread Mark Dickinson
Mark Dickinson added the comment: About the implementation of sum: it's worth noting that the algorithm you're using for floats depends on correct rounding of addition and subtraction, and that that's not guaranteed. See the existing test (testFsum) in test_math for more information, and note

[issue18702] Report skipped tests as skipped

2013-08-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Which one is the preferred way to go? "requires" or "test needs" or "needs"? > Or it does not matter? I used the wording which used in other skips in the same file or in similar skips in other files. If it matters I will correct messages. > Which one is t

[issue16799] start using argparse.Namespace in regrtest

2013-08-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue17974. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue16038] ftplib: unlimited readline() from connection

2013-08-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Error message "got more than %d bytes" is misleading because in most cases (except storlines()) we read not bytes but a text string. There are 4 changes in the ftplib module but only one of them covered by test. -- nosy: +serhiy.storchaka __

[issue18606] Add statistics module to standard library

2013-08-12 Thread Mark Dickinson
Mark Dickinson added the comment: >From the code: # Also, like all dunder methods, we should call # __float__ on the class, not the instance. Why? I've never encountered this recommendation before. x.__float__() would be clearer, IMO. --

[issue18606] Add statistics module to standard library

2013-08-12 Thread Mark Dickinson
Mark Dickinson added the comment: > Why? I've never encountered this recommendation before. x.__float__() > > would be clearer, IMO. Hmm; it would be better if I engaged by brain before commenting. I guess the point is that type(x).__float__(x) better matches the behaviour of the builtin

[issue18606] Add statistics module to standard library

2013-08-12 Thread Mark Dickinson
Mark Dickinson added the comment: (We don't seem to care too much about the distinction in general, though: there are a good few places in the std. lib. where obj.__index__() is used instead of the more correct type(obj).__index__(obj).) -- ___ Pyt

[issue3526] Customized malloc implementation on SunOS and AIX

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: PEP 445 allows you to customize the Python memory allocators, which is a better solution than shipping several ones with Python ;-) -- resolution: -> wont fix status: open -> closed ___ Python tracker

[issue18394] cgi.FieldStorage triggers ResourceWarning sometimes

2013-08-12 Thread Vajrasky Kok
Vajrasky Kok added the comment: It happens because if the length of data is more than 1000: def __write(self, line): """line is always bytes, not string""" if self.__file is not None: if self.__file.tell() + len(line) > 1000: self.file = self.make_

[issue18700] test_cgi raises ResourceWarning

2013-08-12 Thread Vajrasky Kok
Vajrasky Kok added the comment: Superseded by bug #18394. Should we close this one by marking it as duplicate? -- nosy: +vajrasky ___ Python tracker ___

[issue12075] python3.2 memory leak when reloading class with attributes

2013-08-12 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: wont fix -> out of date ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue12075] python3.2 memory leak when reloading class with attributes

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: Yes, __del__ will interfere with garbage collection before Python 3.4. This is pretty much expected (and is fixed in Python 3.4, but won't be backported). -- nosy: +pitrou resolution: -> wont fix stage: -> committed/rejected status: open -> closed ver

[issue1565525] tracebacks eat up memory by holding references to locals and globals when they are not wanted

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: > We need maybe an helper to clear all frames referenced by a traceback? Yes. Something in the traceback module would be fine. -- components: +Library (Lib) -Interpreter Core versions: +Python 3.4 -Python 3.2 ___ Pyt

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Christian Heimes
New submission from Christian Heimes: Ryan Sleevi of the Google Chrome Security Team has informed us that Python's SSL module doesn't handle NULL bytes inside subjectAltNames general names. It's related to Ruby's CVE-2013-4073 http://www.ruby-lang.org/en/news/2013/06/27/hostname-check-bypassin

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Christian Heimes
Changes by Christian Heimes : Added file: http://bugs.python.org/file31242/CVE-2013-4073_py33.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Christian Heimes
Changes by Christian Heimes : -- keywords: +patch Added file: http://bugs.python.org/file31241/CVE-2013-4073_py34.patch ___ Python tracker ___ ___

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Christian Heimes
Changes by Christian Heimes : Added file: http://bugs.python.org/file31243/CVE-2013-4073_py27.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Christian Heimes
Christian Heimes added the comment: Demo certificate: Certificate: Data: Version: 3 (0x2) Serial Number: 0 (0x0) Signature Algorithm: sha1WithRSAEncryption Issuer: C=US, ST=Oregon, L=Beaverton, O=Python Software Foundation, OU=Python Core Development, CN=null.py

[issue18644] Got ResourceWarning: unclosed file when using test function from formatter module

2013-08-12 Thread Martijn Pieters
Martijn Pieters added the comment: > The formatter module was deprecated? When? It wasn't, that's the point I am raising. The `formatter` module was exclusively used by the `htmllib` module, I am surprised the `formatter` module wasn't part of that deprecation. -- ___

[issue18644] Got ResourceWarning: unclosed file when using test function from formatter module

2013-08-12 Thread R. David Murray
R. David Murray added the comment: Pydoc uses DumbWriter. -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16396] Importing ctypes.wintypes on Linux gives a traceback

2013-08-12 Thread Ezio Melotti
Ezio Melotti added the comment: Even if the patch is applied only on 3.4, I would still like to see the ValueError turned into ImportError for 2.7/3.3. -- ___ Python tracker ___

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Antoine Pitrou
New submission from Antoine Pitrou: Attached patch adds PyState_GetModuleAttr() and converts the _csv module to use it (as an example). As you can see, the _csv module grows a little but it now has proper error handling (previously, it didn't check for PyState_FindModule() returning NULL). (A

[issue17997] ssl.match_hostname(): sub string wildcard should not match IDNA prefix

2013-08-12 Thread Christian Heimes
Christian Heimes added the comment: Ryan Sleevi of the Google Chrome Security Team has informed us about another issue that is caused by our failure to implement RFC 6125 wildcard matching rules. RFC 6125 allows only one wildcard in the left-most fragment of a hostname. For security reasons ma

[issue18693] help() not helpful with enum

2013-08-12 Thread Eli Bendersky
Eli Bendersky added the comment: Ethan, please revert your commit first. I liked the previous dir. The current one is useless. I think you may be right about help, but I didn't dig deep enough to be sure. -- ___ Python tracker

[issue18711] Add PyErr_FormatV

2013-08-12 Thread Antoine Pitrou
New submission from Antoine Pitrou: PyErr_FormatV can be useful to write third-party helper functions. Patch attached. -- components: Interpreter Core files: pyerr_formatv.patch keywords: patch messages: 194952 nosy: pitrou priority: low severity: normal stage: patch review status: open

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread STINNER Victor
STINNER Victor added the comment: I don't understand your change. Why do we need to change the _csv module and why storing module global variables in the module dict is better than storing them in a simple C structure? -- nosy: +haypo ___ Python tra

[issue18693] help() not helpful with enum

2013-08-12 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- nosy: +ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I don't understand your change. Why do we need to change the _csv > module and why storing module global variables in the module dict is > better than storing them in a simple C structure? I won't repeat what was already said in the python-dev thread: http://m

[issue18711] Add PyErr_FormatV

2013-08-12 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Christian Heimes
Christian Heimes added the comment: The patch contains the new function and a patch for the CSV module. How about you split it up across two patches: one for the new feature and one for the CSV module? It makes review easier. -- nosy: +christian.heimes

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: Bundling the two was aimed at showcasing the effect the new function can have. The function itself is trivial, there's not much point in reviewing it alone. -- ___ Python tracker

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread STINNER Victor
STINNER Victor added the comment: +PyObject * +PyState_GetModuleAttr(struct PyModuleDef *def, + const char *name, + PyObject *restrict_type) When the char* type is used, the function has usually the suffix String. I prefer the PyIdentifier API because i

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread STINNER Victor
STINNER Victor added the comment: Does it really make sense to allow to open a certificate containing a NUL byte in its name? How does OpenSSL and other projects handle this case? -- nosy: +haypo ___ Python tracker

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Christian Heimes
Christian Heimes added the comment: OpenSSL's print() functions fail to handle the NULL byte in subjectAltName (SAN) general names as they use strlen() or printf() functions with "%s" format char. The subject and issuer elements with NULL bytes are handled correctly by OpenSSL. wget and curl

[issue17997] ssl.match_hostname(): sub string wildcard should not match IDNA prefix

2013-08-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: > When the char* type is used, the function has usually the suffix > String. I prefer the PyIdentifier API because it avoids to create a > temporary Python Unicode object. This is a convenience API, not a performance "optimization". > It's the first type that I

[issue18693] help() not helpful with enum

2013-08-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 39697dcd97e3 by Ethan Furman in branch 'default': Issue 18693: Put custom __dir__ back in place. Will instead look at fixing `help()`. http://hg.python.org/cpython/rev/39697dcd97e3 -- ___ Python tracker

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Eli Bendersky
Eli Bendersky added the comment: The patched code looks better than the original one in several respects, but I think it raises some questions. I agree with Victor that the type-checking API is unnatural, but I also think there may be a deeper issue hiding behind. You felt compelled to add the

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Previously, the only way to add a dialect was through register_dialect that > does > type checking to make sure it gets a legit dialect object. Now, the _dialects > dict is > directly accessible to Python code and it can add arbitrary objects to it > (both

[issue18712] Pure Python operator.index doesn't match the C version.

2013-08-12 Thread Mark Dickinson
New submission from Mark Dickinson: Nitpick: the pure Python version of operator.index (new in Python 3.4, introduced in issue #16694) doesn't match the C version, in that it looks up __index__ on the object rather than the class. iwasawa:cpython mdickinson$ ./python.exe Python 3.4.0a1+ (defa

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Nick Coghlan
Nick Coghlan added the comment: Breaking the 1:1 interpreter <-> extension module mapping involves adding custom types to sys.modules rather than module objects. Making that work sensibly will involve larger changes to the extension initialisation APIs. import-sig already has plans for this :) -

[issue18710] Add PyState_GetModuleAttr

2013-08-12 Thread Eli Bendersky
Eli Bendersky added the comment: > Previously, the only way to add a dialect was through register_dialect that does > > type checking to make sure it gets a legit dialect object. Now, the > _dialects dict is > > directly accessible to Python code and it can add arbitrary objects to > it (both a

[issue18660] os.read behavior on Linux

2013-08-12 Thread Louis Riviere
Louis Riviere added the comment: Thanks Benjamin ! I should have known that "Python doesn't break things" :) -- ___ Python tracker ___ ___

[issue18713] Enable surrogateescape on stdin and stdout when appropriate

2013-08-12 Thread Nick Coghlan
New submission from Nick Coghlan: One problem with Unicode in 3.x is that surrogateescape isn't normally enabled on stdin and stdout. This means the following code will fail with UnicodeEncodeError in the presence of invalid filesystem metadata: print(os.listdir()) We don't really want to

[issue18713] Enable surrogateescape on stdin and stdout when appropriate

2013-08-12 Thread R. David Murray
R. David Murray added the comment: My gut reaction to this is that it feels dangerous. That doesn't mean my gut is right, I'm just reporting my reaction :) -- nosy: +r.david.murray ___ Python tracker

[issue18713] Enable surrogateescape on stdin and stdout when appropriate

2013-08-12 Thread Nick Coghlan
Nick Coghlan added the comment: Everything about surrogateescape is dangerous - we're trying to work around the presence of bad data by at least allowing it to be tunnelled through Python code without corrupting it further :) -- ___ Python tracker

[issue18367] See if a venv setup can be used for devinabox for coverage

2013-08-12 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue18451] Omit test files in devinabox coverage run

2013-08-12 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18689] add argument for formatter to logging.Handler and subclasses in logging module

2013-08-12 Thread Derek Wilson
Derek Wilson added the comment: dictConfig and fileConfig are nice for static needs, but when I want to quickly enable a complex (but not complicated) logging flow I find it just as tedious as the current situation with the direct API. > ... as at the very least every handler would need to be

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

2013-08-12 Thread Seydou Dia
Seydou Dia added the comment: I have a hard time figuring out what exactly BytecodeTestCase methods actually do. Thus the documentation is not probably accurate. -- keywords: +patch Added file: http://bugs.python.org/file31247/issue-18578.diff ___ Py

[issue18598] Importlib, more verbosity please

2013-08-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2294594fbe6c by Brett Cannon in branch 'default': Closes issue #18598: Have the exception message for http://hg.python.org/cpython/rev/2294594fbe6c -- nosy: +python-dev ___ Python tracker

[issue18598] Importlib, more verbosity please

2013-08-12 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue12837] Patch for issue #12810 removed a valid check on socket ancillary data

2013-08-12 Thread Brett Cannon
Brett Cannon added the comment: This is still a warning and so I'm still looking for a solution. -- ___ Python tracker ___ ___ Python-

[issue18667] missing HAVE_FCHOWNAT

2013-08-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset a89226508a04 by Larry Hastings in branch '3.3': Issue #18667: Add missing "HAVE_FCHOWNAT" symbol to posix._have_functions. http://hg.python.org/cpython/rev/a89226508a04 -- nosy: +python-dev ___ Python tra

[issue18667] missing HAVE_FCHOWNAT

2013-08-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 92de1a5dc3ea by Larry Hastings in branch 'default': Issue #18667: Add missing "HAVE_FCHOWNAT" symbol to posix._have_functions. http://hg.python.org/cpython/rev/92de1a5dc3ea -- ___ Python tracker

[issue18667] missing HAVE_FCHOWNAT

2013-08-12 Thread Larry Hastings
Larry Hastings added the comment: Fixed in 3.3 and trunk. Thanks for the report! -- assignee: -> larry resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker

[issue18416] Move to absolute file paths for module.__file__

2013-08-12 Thread Madison May
Madison May added the comment: Here's a minor revision to that patch removing an unnecessary @skip_if_dont_write_bytecode decorator from the test I added to test_import.py. No docs changes are included in the current patch -- I'm guessing this should probably wait until we have all the othe

[issue18416] Move to absolute file paths for module.__file__

2013-08-12 Thread Madison May
Changes by Madison May : Added file: http://bugs.python.org/file31248/Issue18416_v2.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18700] test_cgi raises ResourceWarning

2013-08-12 Thread Madison May
Madison May added the comment: Good catch, Vajrasky. I'll close the issue and add my brief report to bug #18394. -- status: open -> closed ___ Python tracker ___ __

[issue18394] cgi.FieldStorage triggers ResourceWarning sometimes

2013-08-12 Thread Madison May
Madison May added the comment: I ran into a similar issue (see #18700) with test_cgi. ``/home/mmay/cpython/Lib/test/test_cgi.py:276: ResourceWarning: unclosed file <_io.BufferedRandom name=3>`` -- nosy: +madison.may ___ Python tracker

[issue1666318] shutil.copytree doesn't give control over directory permissions

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hey Catherine, Do you want to update your patch to include Vajrasky's suggestion? -- ___ Python tracker ___ __

[issue18694] getxattr on Linux ZFS native filesystem happily returns partial values

2013-08-12 Thread Larry Hastings
Larry Hastings added the comment: Attached is an updated patch, this time for 3.3. (So I'm guessing we won't get a "review" link.) It incorporates Benjamin's two comments. -- Added file: http://bugs.python.org/file31249/larry.setxattr.zfs.3.3.patch.1.txt _

[issue18694] getxattr on Linux ZFS native filesystem happily returns partial values

2013-08-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: Okay. Hopefully, we can kill that thing one day... -- ___ Python tracker ___ ___ Python-bugs-list

[issue18606] Add statistics module to standard library

2013-08-12 Thread Steven D'Aprano
Steven D'Aprano added the comment: On 09/08/13 21:49, Oscar Benjamin wrote: > I think that the argument `m` to variance, pvariance, stdev and pstdev > should be renamed to `mu` for pvariance/pstdev and `xbar` for > variance/stdev. The doc-strings should carefully distinguish that `mu` > is the t

[issue16396] Importing ctypes.wintypes on Linux gives a traceback

2013-08-12 Thread Jason R. Coombs
Jason R. Coombs added the comment: My sense on the issue is that wintypes was added to the library and was never intended to raise a ValueError on import. By that logic, the behavior is a bug, not a new feature. I agree with Ezio that raising a ValueError on import is a bug. And since the patc

[issue18714] Add tests for pdb.find_function

2013-08-12 Thread Kevin Jing Qiu
New submission from Kevin Jing Qiu: PyConCA 2013 sprint task -- components: Tests messages: 194986 nosy: Kevin.Jing.Qiu priority: normal severity: normal status: open title: Add tests for pdb.find_function type: enhancement versions: Python 3.5 ___ Py

[issue18714] Add tests for pdb.find_function

2013-08-12 Thread Kevin Jing Qiu
Changes by Kevin Jing Qiu : -- keywords: +patch Added file: http://bugs.python.org/file31251/mywork.patch ___ Python tracker ___ ___ P

[issue18715] Tests fail when run with coverage

2013-08-12 Thread Seydou Dia
New submission from Seydou Dia: When I run the tests suit with coverage (e.g, ./python COVERAGEDIR run --pylib Lib/test/regrtest.py test_frame), the following tests fails: * test_frame * test_xml_etree * test_threading_local * test_super * test_importlib The tracebacks are available here

[issue18585] Add a text truncation function

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch renaming summarize() to shorten(), and adding docs and a fix for a nit reported by Vajrasky. -- Added file: http://bugs.python.org/file31250/shorten.patch ___ Python tracker

[issue18716] Deprecate the formatter module

2013-08-12 Thread Brett Cannon
New submission from Brett Cannon: Turns out the formatter module isn't really used by anyone. Pydoc uses it, but it could easily use textwrap. Searching on Github shows a usage by someone who simply re-exposes it as part of their own public API but has no actual usage themselves (https://gith

[issue18707] the readme should also talk about how to build doc.

2013-08-12 Thread Éric Araujo
Éric Araujo added the comment: There is a README in the Doc directory. Wouldn’t it be enough to point to that file from the main README? -- ___ Python tracker ___ _

[issue18694] getxattr on Linux ZFS native filesystem happily returns partial values

2013-08-12 Thread Larry Hastings
Larry Hastings added the comment: Kill what thing? The review link? I love that thing? Anyway, we did get a review link, hoopla! -- ___ Python tracker ___

[issue18606] Add statistics module to standard library

2013-08-12 Thread Steven D'Aprano
Steven D'Aprano added the comment: On 12/08/13 19:21, Mark Dickinson wrote: > About the implementation of sum: it's worth noting that the algorithm you're > using for floats depends on correct rounding of addition and subtraction, and > that that's not guaranteed. [...] > Steven: any thoughts

[issue18716] Deprecate the formatter module

2013-08-12 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue18606] Add statistics module to standard library

2013-08-12 Thread Mark Dickinson
Mark Dickinson added the comment: Okay, that works. I agree that not documenting add_partial is probably a good plan. -- ___ Python tracker ___

[issue18689] add argument for formatter to logging.Handler and subclasses in logging module

2013-08-12 Thread Vinay Sajip
Vinay Sajip added the comment: > If 3rd party handlers are intelligent It's not an ideal world. Sorry, but I think this change is too invasive to consider. I can't believe this change is really needed - logging has been around since 2002 and this has never been raised before. -- statu

[issue18716] Deprecate the formatter module

2013-08-12 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18716] Deprecate the formatter module

2013-08-12 Thread Larry Hastings
Larry Hastings added the comment: +1 -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18717] test for request.urlretrieve

2013-08-12 Thread Muhammad Jehanzeb
New submission from Muhammad Jehanzeb: As part of pyconca sprints, this is my first patch for urlcleanup test -- components: Tests files: test_urllib.py messages: 194996 nosy: mjehanzeb priority: normal severity: normal status: open title: test for request.urlretrieve type: enhancement v

[issue18717] test for request.urlretrieve

2013-08-12 Thread Ezio Melotti
Ezio Melotti added the comment: Thanks for your contribution. Can you submit this as a diff? -- nosy: +ezio.melotti stage: -> patch review ___ Python tracker ___ __

[issue16799] start using argparse.Namespace in regrtest

2013-08-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a preliminary patch which get rids of _convert_namespace_to_getopt() and directly uses a Namespace object. Unfortunately it breaks tests because test_regrtest depends on implementation details of the regrtest module and uses _convert_namespace_to_get

[issue18712] Pure Python operator.index doesn't match the C version.

2013-08-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: We can use type(a).__index__(a). Should we also correct the documentation for operator.index() and operator.length_hint()? -- nosy: +serhiy.storchaka ___ Python tracker

[issue18717] test for request.urlretrieve

2013-08-12 Thread Muhammad Jehanzeb
Muhammad Jehanzeb added the comment: the patch fie -- keywords: +patch Added file: http://bugs.python.org/file31255/mywork.patch ___ Python tracker ___ __

[issue18717] test for request.urlretrieve

2013-08-12 Thread Muhammad Jehanzeb
Changes by Muhammad Jehanzeb : Removed file: http://bugs.python.org/file31253/test_urllib.py ___ Python tracker ___ ___ Python-bugs-list maili

[issue17701] Improving strftime documentation

2013-08-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset adbc9789a5e4 by David Wolever in branch '2.7': Issue #17701: Improving strftime documentation http://hg.python.org/cpython/rev/adbc9789a5e4 -- nosy: +python-dev ___ Python tracker

[issue18707] the readme should also talk about how to build doc.

2013-08-12 Thread Ezio Melotti
Ezio Melotti added the comment: +1 -- type: -> enhancement versions: +Python 2.7, Python 3.3 ___ Python tracker ___ ___ Python-bugs-l

[issue18717] test for request.urlretrieve

2013-08-12 Thread Muhammad Jehanzeb
Changes by Muhammad Jehanzeb : Removed file: http://bugs.python.org/file31255/mywork.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18717] test for request.urlretrieve

2013-08-12 Thread Muhammad Jehanzeb
Muhammad Jehanzeb added the comment: included issue# in the patch file -- Added file: http://bugs.python.org/file31256/issue18717.patch ___ Python tracker ___ ___

[issue18717] test for request.urlretrieve

2013-08-12 Thread Muhammad Jehanzeb
Changes by Muhammad Jehanzeb : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue18606] Add statistics module to standard library

2013-08-12 Thread Oscar Benjamin
Oscar Benjamin added the comment: On 12 August 2013 20:20, Steven D'Aprano wrote: > On 12/08/13 19:21, Mark Dickinson wrote: >> About the implementation of sum: > add_partial is no longer documented as a public function, so I'm open to > switching algorithms in the future. Along similar lines

[issue18699] What is Future.running() for in PEP 3148 / concurrent.futures.Future?

2013-08-12 Thread Andrew Svetlov
Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18585] Add a text truncation function

2013-08-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch addressing Ezio's comments. -- Added file: http://bugs.python.org/file31257/shorten2.patch ___ Python tracker ___

[issue18712] Pure Python operator.index doesn't match the C version.

2013-08-12 Thread Mark Dickinson
Mark Dickinson added the comment: Yes, I think it would make sense to fix the docs as well, at least for Python 3.4. Probably not worth it for the maintenance releases. -- ___ Python tracker _

[issue18715] Tests fail when run with coverage

2013-08-12 Thread Ned Deily
Ned Deily added the comment: Please upload the test results as file attachment(s) to this issue. Files stored elsewhere may disappear. -- nosy: +ned.deily ___ Python tracker __

[issue18677] Enhanced context managers with ContextManagerExit and None

2013-08-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue18718] datetime documentation contradictory on leap second support

2013-08-12 Thread David Wolever
New submission from David Wolever: The documentation for the `%S` formatter suggests that it supports leap seconds, but the footnote contradicts that: > The range really is 0 to 61; according to the Posix standard this > accounts for leap seconds and the (very rare) double leap seconds. > The t

  1   2   >