[issue17290] pythonw - loading cursor bug when launching scripts

2013-02-25 Thread Mark Hammond
Mark Hammond added the comment: The problem is that Explorer displays the IDC_APPSTARTING icon when an app launches, until that app does something ui-ish (eg, creating a window, fetching a windows message). I could reproduce the problem on XP, and pushed a fix for the launcher to https://bit

[issue17290] pythonw - loading cursor bug when launching scripts

2013-02-25 Thread Mark Hammond
Mark Hammond added the comment: If anyone would like to test the fix out, I've put a 32bit pyw.exe with the fix at http://starship.python.net/crew/skippy/downloads/pyw.exe -- ___ Python tracker ___

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Nick Coghlan
Nick Coghlan added the comment: Perfect is the enemy of good. I vote for just committing it, then Chris can propose additional fixes/changes in a subsequent patch. On 26 Feb 2013 09:52, "Chris Jerdonek" wrote: > > Chris Jerdonek added the comment: > > > I still fail to understand what are you t

[issue17290] pythonw - loading cursor bug when launching scripts

2013-02-25 Thread Vinay Sajip
Vinay Sajip added the comment: Good catch, Mark! I'll wait for confirmation that your patched pyw.exe works, then make the changes in the Python repository and also update the standalone launcher. -- ___ Python tracker

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Ezio Melotti
Ezio Melotti added the comment: > Perfect is the enemy of good. I vote for just committing it, then > Chris can propose additional fixes/changes in a subsequent patch. Agreed. Chris, any preference about the number of commits (8 separate commits, 1-6 + 7-8, 2 on its own)? --

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Chris Jerdonek
Chris Jerdonek added the comment: For the record, I don't recall *any* changes being made to any of the patches in response to mine or others' comments, other than dividing them up. So we're not talking about perfection. If they're going to be committed as is, it might as well be one patch.

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Ned Deily
Ned Deily added the comment: ISTM, committing changes to the devguide is fundamentally different from committing a change to Python itself. The devguide has a much smaller and focused audience, does not have compatibility considerations, it's continuously releasable etc etc. So there's no ne

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Ezio Melotti
Ezio Melotti added the comment: OK, I'll commit 1-6 and 7-8 then. After that we can further improve things starting from there. > it would be easier to get meaningful additional review after the > current set of changes are committed rather than continually redoing a > large set of patches.

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Chris Jerdonek
Chris Jerdonek added the comment: > But, surely at this point, it would be easier to get meaningful additional > review after the current set of changes are committed rather than continually > redoing a large set of patches. This was my reason for asking early on that the changes be proposed a

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Ezio Melotti
Ezio Melotti added the comment: This was a somewhat major rewrite. The fact that we had no rietveld available made things more complicated on the reviewer side, and splitting the patch in smaller chunks made things more complicated on my side. FWIW I have 2 major doc issues up next: #4153 and

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset a50e537c5914 by Ezio Melotti in branch 'default': #14468: document the use of the share extension as the suggested approach for core developers. http://hg.python.org/devguide/rev/a50e537c5914 New changeset 3e213eaf85a6 by Ezio Melotti in branch 'de

[issue17284] create mercurial section in devguide's committing.rst

2013-02-25 Thread Ezio Melotti
Ezio Melotti added the comment: This has now been committed as part of #14468. Regarding the change of the section title, I'm not sure that's necessary. Currently the section covers all the fundamental Mercurial-related operations that a committers needs to know (set up, commit, merge, push), no

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

2013-02-25 Thread karl
karl added the comment: This is a possible additional example for set_tunnel, modification of python3.3/html/_sources/library/http.client.txt Hope it helps. -- nosy: +karlcow Added file: http://bugs.python.org/file29243/http.client.patch ___ Python

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: While multiple, spaced, commits might have been better, if the first had been made at least 6 months ago, I agree that the best thing *now* was to commit these as a base for further improvements. There are 19 other open devguide issues to review and close as o

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Ned Deily
Ned Deily added the comment: "I think the core-mentorship list would be one place to get more opinions if more are needed." Keep in mind that the core-mentorship list is a closed list so any discussions there would take place without direct participation of the (many?) core developers, like m

[issue16942] urllib still doesn't support persistent connections

2013-02-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: +class FileCookieJar(CookieJar, metaclass=ABCMeta): +"""Abstract Base Class for any file-based CookieJar.""" Is it just me or is it a bit strange to derive an abstract base class from a concrete class? Is CookieJar meant to be directly used? +with

[issue14468] Update cloning guidelines in devguide

2013-02-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: I have no intention of excluding you ;-). Please comment on any or all of the other 19. But if an issue is stuck with inadequate or conflicting developer opinion, getting supplemental opinions from target users, as in "There is a proposal to change 'abc' to 'x

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-02-25 Thread Christoph Gohlke
Changes by Christoph Gohlke : -- nosy: +cgohlke ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17263] crash when tp_dealloc allows other threads

2013-02-25 Thread Charles-François Natali
Charles-François Natali added the comment: > Note that in threadmodule.c, in local_clear, we are iterating through all > threads: > > In PyDict_DelItem, if the GIL is released and meanwhile, the list of > threadstates is altered, is that a problem for this loop? So maybe tstate > becomes inval

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-25 Thread Stefan Behnel
Stefan Behnel added the comment: I still can't see a reference to Cython in the PEP. Larry, I don't really mind adding a newly designed DSL for this, but regarding the implementation of the actual argument parser, could you at least add a short paragraph to the PEP that mentions it as worth be

[issue16930] mention limitations and/or alternatives to hg graft

2013-02-25 Thread Ezio Melotti
Ezio Melotti added the comment: http://docs.python.org/devguide/committing.html#porting-changesets-between-the-two-major-python-versions-2-x-and-3-x now mentions both "hg graft" and "hg export|import". Do you think this is enough or should we add a link to http://mercurial.selenic.com/wiki/Fi

[issue1744382] Read Write lock

2013-02-25 Thread Vladimir Rutsky
Changes by Vladimir Rutsky : -- nosy: +rutsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

<    1   2