[issue16748] Make CPython test package discoverable

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are tests outside of Lib/test/ hierarchy. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue16871] Cleanup a few minor things

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Agreed. Maintainers of asynchat, tkinter.tix, optparse and difflib must pay attention to this. -- nosy: +aronacher, giampaolo.rodola, gpolo, josiahcarlson, stutzbach resolution: -> rejected stage: patch review -> committed/rejected status: pending ->

[issue16891] Fix docs about module search order

2013-01-08 Thread Dmitry Mugtasimov
New submission from Dmitry Mugtasimov: http://docs.python.org/2/tutorial/modules.html should be rewritten. AS IS 6.1.2. The Module Search Path When a module named spam is imported, the interpreter first searches for a built-in module with that name. If not found, it then searches for a file nam

[issue16891] Fix docs about module search order

2013-01-08 Thread Dmitry Mugtasimov
Dmitry Mugtasimov added the comment: UPDATE: CHANGE http://stackoverflow.com/questions/14183541/why-python-finds-module-instead-of-package-if-they-have-the-same-name#comment19687166_14183541 TO http://stackoverflow.com/questions/14183541/why-python-finds-module-instead-of-package-if-they-have-th

[issue14323] Normalize math precision in RGB/YIQ conversion

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: According to Wikipedia FCC conversion is defined as: y = 0.30*r + 0.59*g + 0.11*b i = 0.5990*r - 0.2773*g - 0.3217*b q = 0.2130*r - 0.5251*g + 0.3121*b and non-FCC conversion is defined as: y = 0.299*r + 0.587*g + 0.114*b i = 0.595716*r -

[issue8489] Support UTF8SMTP as part of RFC 5336 in smptlib

2013-01-08 Thread David Lam
Changes by David Lam : -- nosy: +dlam ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mai

[issue14468] Update cloning guidelines in devguide

2013-01-08 Thread Ezio Melotti
Ezio Melotti added the comment: Here is another iteration of the patch. I removed some of the old material, added half of the FAQs and the title and outline for the other FAQs. If the structure looks good I'll proceed. -- assignee: sandro.tosi -> ezio.melotti Added file: http://bugs.py

[issue14468] Update cloning guidelines in devguide

2013-01-08 Thread Ezio Melotti
Changes by Ezio Melotti : Added file: http://bugs.python.org/file28629/committing.rst ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue15845] Fixing some byte-to-string conversion warnings

2013-01-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9458a516f769 by Serhiy Storchaka in branch '3.2': Issue #15845: Fix comparison between bytes and string. http://hg.python.org/cpython/rev/9458a516f769 New changeset f6cf2985348a by Serhiy Storchaka in branch '3.3': Issue #15845: Fix comparison betwe

[issue15845] Fixing some byte-to-string conversion warnings

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Fixed. Thank your for report and patch, Alessandro. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue16851] ismethod and isfunction methods error

2013-01-08 Thread Federico Reghenzani
Changes by Federico Reghenzani : -- keywords: +patch Added file: http://bugs.python.org/file28630/inspect.patch ___ Python tracker ___ ___

[issue16890] minidom error

2013-01-08 Thread Javier Domingo
Javier Domingo added the comment: I know that is the problem, but that shouldn't happen! if you remove a item from a list, that doesn't happen. That is why I tagged the error as minidom's El 08/01/2013 04:24, "Ezio Melotti" escribió: > > Ezio Melotti added the comment: > > The problem is that y

[issue16853] add a Selector to the select module

2013-01-08 Thread Charles-François Natali
Charles-François Natali added the comment: So I assume that the second failure is fixed, which means that OS-X returns a funny event (and not POLLIN/POLLHUP/POLLERR) in case of ECONNREFUSED :-( > 2 - In EventLoopTestsMixin::test_writer_callback if the writer socket isn't > non-blocking, the tes

[issue16890] minidom error

2013-01-08 Thread Ezio Melotti
Ezio Melotti added the comment: It happens with lists too: >>> l = list(range(10)) >>> for x in l: ... l.remove(x) ... >>> l [1, 3, 5, 7, 9] -- ___ Python tracker ___ __

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Vinay Sajip
Vinay Sajip added the comment: I agree this is a reasonable expectation, but I've not encountered this problem before. Can you provide a short script demonstrating the problem? Which platform did you encounter these problems on, and what was the logging configuration? -- _

[issue16890] minidom error

2013-01-08 Thread Javier Domingo
Javier Domingo added the comment: Ok, sorry then. Javier Domingo 2013/1/8 Ezio Melotti > > Ezio Melotti added the comment: > > It happens with lists too: > >>> l = list(range(10)) > >>> for x in l: > ... l.remove(x) > ... > >>> l > [1, 3, 5, 7, 9] > > -- > > __

[issue16884] logging handler automatically added starting in 3.2+

2013-01-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 51138680b968 by Vinay Sajip in branch '2.7': Issue #16884: Updated docs to use 'note' directives. http://hg.python.org/cpython/rev/51138680b968 -- ___ Python tracker _

[issue16884] logging handler automatically added starting in 3.2+

2013-01-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 50af862d0625 by Vinay Sajip in branch '3.2': Issue #16884: Updated docs to use 'note' directives in a couple of places missed earlier. http://hg.python.org/cpython/rev/50af862d0625 New changeset b00c4a095b00 by Vinay Sajip in branch '3.3': Issue #1

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: This can happen with any standard logging configuration when there are writes to sys.stderr that don't end with "\n". I'm using Mac OS X 10.7. A minimal script: import logging, unittest log = logging.getLogger() class Test(unittest.TestCase): def setUp

[issue16884] logging handler automatically added starting in 3.2+

2013-01-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue16871] Cleanup a few minor things

2013-01-08 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Ok for asyncore/asynchat in 3.4 branch. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Ezio Melotti
Ezio Melotti added the comment: Note that for this specific problem you could call unittest.main(verbosity=0). -- nosy: +ezio.melotti ___ Python tracker ___ _

[issue15442] Expand the list of default dirs filecmp.dircmp ignores

2013-01-08 Thread Éric Araujo
Éric Araujo added the comment: > Should __pycache__ be ignored too? Sounds good. > I don't know how to compile python without having to install it See the devguide http://docs.python.org/devguide -- stage: needs patch -> test needed ___ Python tracke

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Vinay Sajip
Vinay Sajip added the comment: Oh, I see what you mean now. I guess the approach you used is straightforward, and perhaps something could be added to test.support. It's only an aesthetic thing, though, IIUC. I normally don't run into this because I log to file when running unit tests, or run

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Ezio, the use case is to add to the existing test output additional diagnostic logging. In particular, you might want to run tests even with verbosity=2 in addition to the log messages. -- ___ Python tracker

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Yes, it's primarily for easier scanning/reading as well as aesthetic. With -v I get the following output though: test1 (test_logging.Test) ... INFO:root:setting up ok test2 (test_logging.Test) ... INFO:root:setting up ok --

[issue13198] Remove duplicate definition of write_record_file

2013-01-08 Thread Éric Araujo
Éric Araujo added the comment: Please don’t; distutils2 still exists and is mutating into one or more projects where these bug reports will be useful. If it bothers Python core devs to have the bugs in this tracker, they will be migrated, but for the moment please leave them open so they can

[issue12944] Accept arbitrary files for packaging's upload command

2013-01-08 Thread Éric Araujo
Éric Araujo added the comment: distutils2, while not actively developed any more for inclusion in the stdlib in 3.4, will mutate into one or more projects where these bug reports will be useful. Bugs will certainly be migrated (and closed in this tracker), but please keep them open for easy q

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: > and perhaps something could be added to test.support. Also, just to clarify, I had in mind outside projects and the larger community for this request rather than CPython development, so I'm not sure test.support would be the right location. --

[issue16842] Allow to override a function signature for pydoc with a docstring

2013-01-08 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16805] when building docs on Debian 7 --> ERROR: Error in "note" directive

2013-01-08 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14470] Remove using of w9xopen in subprocess module

2013-01-08 Thread Éric Araujo
Éric Araujo added the comment: FTR, was the deprecation for 3.3 committed? -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bug

[issue16814] use --directory option of make in describing how to build the docs

2013-01-08 Thread Éric Araujo
Éric Araujo added the comment: FWIW I use make -C Doc all the time but agree with Georg’s point about conciseness. Ezio, I suggest you bookmark some make doc page if you can’t remember it :) -- nosy: +eric.araujo ___ Python tracker

[issue16851] ismethod and isfunction methods error

2013-01-08 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16851] Hint about correct ismethod and isfunction usage

2013-01-08 Thread Éric Araujo
Changes by Éric Araujo : -- title: ismethod and isfunction methods error -> Hint about correct ismethod and isfunction usage ___ Python tracker ___ _

[issue16891] Fix docs about module search order

2013-01-08 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +brett.cannon, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue16748] Make CPython test package discoverable

2013-01-08 Thread R. David Murray
R. David Murray added the comment: Yes, but not many, and not as many as there used to be. I'd like to see them all moved, but met resistance on that front. It may be that those just can't be run using unittest discovery, and perhaps that will eventually convince the maintainers to move them

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-08 Thread Éric Araujo
Éric Araujo added the comment: Idle needs to find its text help files at runtime, so they are installed as data alongside with the code. The rst doc files however can be installed anywhere or not installed at all, so we can’t change Idle to look for them. An alternate idea to avoid duplicatio

[issue16748] Make CPython test package discoverable

2013-01-08 Thread R. David Murray
R. David Murray added the comment: Also, it may be possible to add unittest discovery hooks to the stubs that *are* in Lib/test. -- ___ Python tracker ___ __

[issue16851] Hint about correct ismethod and isfunction usage

2013-01-08 Thread Federico Reghenzani
Changes by Federico Reghenzani : -- nosy: +federico.reghenzani ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16886] Doctests in test_dictcomp depend on dict order

2013-01-08 Thread Éric Araujo
Éric Araujo added the comment: Yes, we definitely want to eat our dogfood and stop relying on dict order, especially now that hashing is randomized. I would argue for backporting this to stable branches. Patch looks good. A semi-related improvement for this bug would be to switch these docte

[issue16836] configure script disables support for IPv6 on a system where IPv6 is disabled

2013-01-08 Thread Martin v . Löwis
Martin v. Löwis added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16892] Windows bug picking up stdin from a pipe

2013-01-08 Thread Robert Oeffner
New submission from Robert Oeffner: Hi, This is a bug that seems to exist on python 2.7, python 3.3 on Windows versions XP, Vista, 7 and 8 and has been around for some years, presumably also in other python versions. It is only recently I have managed to better isolate it although not complet

[issue16891] Fix docs about module search order

2013-01-08 Thread Dmitry Mugtasimov
Dmitry Mugtasimov added the comment: As I investigate it a little closer it seems to me that it is not a documentation issue, but an implementation issue. http://docs.python.org/2/reference/simple_stmts.html#import "A package can contain other packages and modules while modules cannot contain

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

2013-01-08 Thread Eli Bendersky
Eli Bendersky added the comment: Daniel, thanks for this patch, it looks very good. I had some comments in the code review. As for TreeBuilder, let's split it into a separate issue - I think it's much less critical. We can discuss it later once we're done with Element. If anything, it's more

[issue16891] Fix docs about module search order

2013-01-08 Thread R. David Murray
R. David Murray added the comment: > So it looks like if "import xyz.b" bahaves different depending on how > a.py was initially loaded as a script or imported from another module. There are several differences between importing a module and running a script, one of which is what is on sys.path

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

2013-01-08 Thread Eli Bendersky
Eli Bendersky added the comment: P = import_fresh_module('xml.etree.ElementTree', blocked=['_elementtree']) tb = P.TreeBuilder(element_factory=lambda a, b: [a, b]) print(pickle.dumps(tb)) Gives: _pickle.PicklingError: Can't pickle : attribute lookup builtins.function failed -- ___

[issue16891] Fix docs about module search order

2013-01-08 Thread Dmitry Mugtasimov
Dmitry Mugtasimov added the comment: A lot of people are still using python 2.7, even 2.6. For me it would be a nice fix in docs since I spent a plenty of time, trying to figure out what is going on. In my previous comment I also pointed out that implementation probably should be fixed too, s

[issue16889] facilitate log output starting at beginning of line

2013-01-08 Thread Vinay Sajip
Vinay Sajip added the comment: > I had in mind outside projects and the larger community for this request Fair enough - then the best place for the specialisation of stream and handler would seem to be unittest/unittest2. So I'll add Michael Foord to the nosy list. -- nosy: +michael.fo

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: Regardless of the topic of merge, the suggested improvements for both idle.rst and help.txt are great! Thanks for working the patch, Todd. I am +1 with the changes. If no else has any comments, I can go ahead with committing this. -- nosy: +orsenthil

[issue16730] _fill_cache in _bootstrap.py crashes without directory execute permissions

2013-01-08 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-08 Thread Zachary Ware
Zachary Ware added the comment: I'd like to see Éric, Ezio, and my comments on v3 in Rietveld addressed, but after that I'm good with it :) -- ___ Python tracker ___

[issue16748] Make CPython test package discoverable

2013-01-08 Thread Brett Cannon
Brett Cannon added the comment: It's totally doable to set up stubs in Lib/test to use test discovery on those tests which exist outside of that directory. test_importlib actually has some code for that left over from when it lived in Lib/importlib/test: http://hg.python.org/cpython/file/4617b

[issue16893] Create IDLE help.txt from Doc/library/idle.rst

2013-01-08 Thread Zachary Ware
New submission from Zachary Ware: Lib/idlelib/help.txt and Doc/library/idle.rst contain almost exactly the same information, only formatted a bit differently. This issue is to suggest the merger of the two files, by way of creating help.txt from idle.rst as a part of the build or install proc

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-08 Thread Zachary Ware
Zachary Ware added the comment: Issue 16893 has been filed to deal with the idea of merging the files. -- ___ Python tracker ___ ___ Py

[issue16894] Function attribute access doesn't invoke methods in dict subclasses

2013-01-08 Thread David Beazley
New submission from David Beazley: Suppose you subclass a dictionary: class mdict(dict): def __getitem__(self, index): print('Getting:', index) return super().__getitem__(index) Now, suppose you define a function and perform these steps that reassign the function's attribut

[issue16894] Function attribute access doesn't invoke methods in dict subclasses

2013-01-08 Thread Alex Gaynor
Changes by Alex Gaynor : -- nosy: +alex ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue16853] add a Selector to the select module

2013-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: Ok, I fixed test_writer_callback() in the tulip repo. Indeed the error I reported first is gone now. I logged the value of kev on failure, and got this output: ERROR:root:kev = Traceback (most recent call last): File "/Users/guido/tulip/tulip/selectors.py

[issue16894] Function attribute access doesn't invoke methods in dict subclasses

2013-01-08 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue16836] configure script disables support for IPv6 on a system where IPv6 is disabled

2013-01-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1d8effd379c3 by Charles-François Natali in branch '2.7': Issue #16836: Enable IPv6 support even if IPv6 is disabled on the build host. http://hg.python.org/cpython/rev/1d8effd379c3 New changeset d5df9ed118c5 by Charles-François Natali in branch '3.2

[issue16836] configure script disables support for IPv6 on a system where IPv6 is disabled

2013-01-08 Thread Charles-François Natali
Charles-François Natali added the comment: Should be fixed now, thanks. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue16886] Doctests in test_dictcomp depend on dict order

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It would be good actually get rid of doctests, turning them into unittests. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue16895] Batch file to mimic 'make' on Windows

2013-01-08 Thread Zachary Ware
New submission from Zachary Ware: I find myself frustrated with some of the hoops I have to jump through and extra things I have to remember when I want to play around with Python on Windows. To make things a little easier, I've created a 'make.bat' file that can sit in the root of the reposi

[issue16748] Make CPython test package discoverable

2013-01-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Also, it may be possible to add unittest discovery hooks to the stubs that > *are* in Lib/test. The load_tests protocol (2.7, 3.2+) seems like the right approach for this: http://docs.python.org/dev/library/unittest.html#load-tests-protocol --

[issue9242] unicodeobject.c: use of uninitialized values

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I forgot mention the issue number in commit messages. See changeset3570e04f4ea9 and changesetbf347198fbaf. Is the issue fixed now? -- ___ Python tracker

[issue9242] unicodeobject.c: use of uninitialized values

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: changeset 3570e04f4ea9 and changeset bf347198fbaf -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue16896] Fix test discovery for test_asyncore.py

2013-01-08 Thread Zachary Ware
New submission from Zachary Ware: Here's the fix for test_asyncore.py. -- components: Tests files: test_asyncore_fix.diff keywords: patch messages: 179373 nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_asyncor

[issue16897] Fix test discovery for test_bisect.py

2013-01-08 Thread Zachary Ware
New submission from Zachary Ware: Here's the fix for test_bisect.py. This one has an extra change, that of replacing the manual method of obtaining c_bisect and py_bisect with two calls to support.import_fresh_module. This one also has an extra wrench thrown in the gears by including a few do

[issue16898] Fix test discovery for test_bufio.py

2013-01-08 Thread Zachary Ware
Changes by Zachary Ware : -- components: Tests files: test_bufio_fix.diff keywords: patch nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_bufio.py type: behavior versions: Python 3.3, Python 3.4 Added file: htt

[issue11461] UTF-16 incremental decoder doesn't support partial surrogate pair

2013-01-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset f2353e74b335 by Serhiy Storchaka in branch '2.7': Issue #11461: Fix the incremental UTF-16 decoder. Original patch by http://hg.python.org/cpython/rev/f2353e74b335 New changeset 4677c5f6fcf7 by Serhiy Storchaka in branch '3.2': Issue #11461: Fix the

[issue11461] UTF-16 incremental decoder doesn't support partial surrogate pair

2013-01-08 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue9242] unicodeobject.c: use of uninitialized values

2013-01-08 Thread Stefan Krah
Stefan Krah added the comment: The utf_32_le_decode invalid access is gone; for Valgrind the issue is fixed (I didn't look at the patch, no time ATM, sorry). -- ___ Python tracker ___

[issue4773] HTTPMessage not documented and has inconsistent API across Py2/Py3

2013-01-08 Thread Piotr Dobrogost
Piotr Dobrogost added the comment: @joel.verhagen "Should HTTPResponse.getheaders() comma-separate the values (...)" No, it should not. RFC 2616 states: "Multiple message-header fields with the same field-name MAY be present in a message if and only if the entire field-value for that header f

[issue16899] Add support for C99 complex type (_Complex) as ctypes.c_complex

2013-01-08 Thread Vladimir Rutsky
New submission from Vladimir Rutsky: It would be nice if Python will be able to access variables with C99 complex types through ctypes module. -- components: ctypes messages: 179378 nosy: rutsky priority: normal severity: normal status: open title: Add support for C99 complex type (_Com

[issue4773] HTTPMessage not documented and has inconsistent API across Py2/Py3

2013-01-08 Thread Piotr Dobrogost
Piotr Dobrogost added the comment: ...continuing my previous comment Joining headers with the same name by ", " by HTTPResponse.getheaders() in Python 2.7 is wrong and there's a bug for this - see http://bugs.python.org/issue1660009 -- ___ Python t

[issue16843] sporadic test_sched failure

2013-01-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset ab36d3bb5996 by Serhiy Storchaka in branch '3.3': Issue #16843: Make concurrent tests for sched module deterministic. http://hg.python.org/cpython/rev/ab36d3bb5996 New changeset f65eae38f71e by Serhiy Storchaka in branch 'default': Issue #16843: Mak

[issue16843] sporadic test_sched failure

2013-01-08 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue9242] unicodeobject.c: use of uninitialized values

2013-01-08 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16853] add a Selector to the select module

2013-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: Figured it out. KqueueSelector was missing the unregister() implementation. Here it is: def unregister(self, fileobj): key = super().unregister(fileobj) mask = 0 if key.events & SELECT_IN: mask |= K

[issue16853] add a Selector to the select module

2013-01-08 Thread Charles-François Natali
Charles-François Natali added the comment: This should fix some kqueue failures (the FDs were not unregistered, which could result in spurious FDs being reported at a later time). For the "negative FDs", all spurious events are now caught and logged (I think it's better than silently ignoring th

[issue16853] add a Selector to the select module

2013-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: Whoops, the unregister() function needs to return key. -- ___ Python tracker ___ ___ Python-bugs-l

[issue16853] add a Selector to the select module

2013-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: That ought to be added to the docstrings for register()/unregister() in _BaseSelector. -- ___ Python tracker ___

[issue16853] add a Selector to the select module

2013-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: A patch for making register()/unregister() return the key. -- Added file: http://bugs.python.org/file28638/return_key_fix.diff ___ Python tracker

[issue16853] add a Selector to the select module

2013-01-08 Thread Charles-François Natali
Charles-François Natali added the comment: As it is now, _Key is actually an implementation detail, that's why it's not part of the methods signature. Oonly the base register()/unregister() return the key because it's an easy way for the derived classes to get the FD without calling _fileobj_t

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

2013-01-08 Thread Daniel Shahaf
Daniel Shahaf added the comment: Eli Bendersky wrote on Tue, Jan 08, 2013 at 15:00:42 +: > > Eli Bendersky added the comment: > > P = import_fresh_module('xml.etree.ElementTree', blocked=['_elementtree']) > tb = P.TreeBuilder(element_factory=lambda a, b: [a, b]) > print(pickle.dumps(tb)) >

[issue16850] Add "e" mode to open(): close-and-exec (O_CLOEXEC) / O_NOINHERIT

2013-01-08 Thread STINNER Victor
STINNER Victor added the comment: According to the following script, FD_CLOEXEC is available on: * Solaris 8 * HP-UX 11 * Unicos 9.0 * Digital UNIX 4.0 * SunOS 4.1.1_U1 * IRIX 6.5 * Linux 2.0 and Linux 2.4 with glibc 2.2.3 * AIX 4.2 (Versions are tested versions, it doesn't mean that the

[issue16853] add a Selector to the select module

2013-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: Please consider my patches instead; it seems our patches crossed. Merging is now difficult because I already submitted my version to Tulip. Your version still has a bug: it uses select.kevent(...) twice, where it should just use kevent(...). Also my versi

[issue12107] TCP listening sockets created without FD_CLOEXEC flag

2013-01-08 Thread STINNER Victor
STINNER Victor added the comment: See also #5715 which asks for something similar. -- nosy: +haypo ___ Python tracker ___ ___ Python-b

[issue1660009] continuing problem with httplib multiple set-cookie headers

2013-01-08 Thread Piotr Dobrogost
Piotr Dobrogost added the comment: @jjlee What you said re commas in 2007 was wrong and still is. Joining (with commas) multiple header field values having the same field name unconditionally (without knowing it's safe) was not allowed by RFC 2616 and still is not allowed by the upcoming new

[issue16853] add a Selector to the select module

2013-01-08 Thread Richard Oudkerk
Richard Oudkerk added the comment: > Richard, in Tulip's WSAPoll code, it reads: > > class WindowsPollPollster(PollPollster): > """Pollster implementation using WSAPoll. > > WSAPoll is only available on Windows Vista and later. Python > does not currently support WSA

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

2013-01-08 Thread Eli Bendersky
Eli Bendersky added the comment: On Tue, Jan 8, 2013 at 2:51 PM, Daniel Shahaf wrote: > > Daniel Shahaf added the comment: > > Eli Bendersky wrote on Tue, Jan 08, 2013 at 15:00:42 +: > > > > Eli Bendersky added the comment: > > > > P = import_fresh_module('xml.etree.ElementTree', > blocked=[

[issue16900] SSL sockets don't give resource warnings

2013-01-08 Thread Benjamin Peterson
New submission from Benjamin Peterson: Python 3.3.0+ (3.3:ab36d3bb5996+, Jan 8 2013, 17:08:35) [GCC 4.5.4] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import socket >>> s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) >>> del s __main__:1: ResourceWa

[issue16076] xml.etree.ElementTree.Element is no longer pickleable

2013-01-08 Thread Daniel Shahaf
Daniel Shahaf added the comment: Dissociating TreeBuilder from this issue per recent comments. -- title: xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable -> xml.etree.ElementTree.Element is no longer pickleable ___

[issue12107] TCP listening sockets created without FD_CLOEXEC flag

2013-01-08 Thread STINNER Victor
STINNER Victor added the comment: "Note that I don't like the idea of falling back to FD_CLOEXEC since it's not atomic, and some people might rely on this." There is a similar question (atomic or best effort) for the #16860 issue. It looks like more people prefer the best effort option. IMO mo

[issue12107] TCP listening sockets created without FD_CLOEXEC flag

2013-01-08 Thread STINNER Victor
STINNER Victor added the comment: Oh, by the way: I never understood why SimpleXMLRPCServer does set FD_CLOEXEC (since the issue #1222790), whereas TCPServer doesn't. -- ___ Python tracker

[issue16901] In http.cookiejar.FileCookieJar() the .load() and .revert() methods don't work

2013-01-08 Thread py.user
New submission from py.user: >>> import http.cookiejar >>> cjf = http.cookiejar.FileCookieJar() >>> cjf.load('file.txt') Traceback (most recent call last): File "", line 1, in File "/usr/local/lib/python3.3/http/cookiejar.py", line 1767, in load self._really_load(f, filename, ignore_disc

[issue16891] Fix docs about module search order

2013-01-08 Thread Nick Coghlan
Nick Coghlan added the comment: The docs sometimes try to draw a sharp distinction between modules and packages, but it's essentially a lie - a package is really just a module with a __path__ attribute, and if you know what you are doing, you make even an ordinary module behave like a package (e.

[issue16076] xml.etree.ElementTree.Element is no longer pickleable

2013-01-08 Thread Daniel Shahaf
Daniel Shahaf added the comment: v8 removes TreeBuilder handling (code + tests) and removes memcpy per review. (Outstanding issues in the review can be fixed post-v8, if needed.) -- Added file: http://bugs.python.org/file28639/i16076-v8.diff ___ Pyt

[issue16715] Get rid of IOError. Use OSError instead

2013-01-08 Thread py.user
py.user added the comment: found a typo (removed LoadError) commit 80f2b1273e8c0e1a28fabe537ae9c5acbbcee187 Author: Andrew Svetlov Date: Tue Dec 25 16:47:37 2012 +0200 Replace IOError with OSError (#16715) ... diff --git a/Lib/http/cookiejar.py b/Lib/http/cookiejar.py index a77dc3f

[issue12107] TCP listening sockets created without FD_CLOEXEC flag

2013-01-08 Thread STINNER Victor
STINNER Victor added the comment: socketserver_close_on_exec.patch: - Add TCPServer.close_on_exec class attribute: True by default if the fcntl module is present, False otherwise - Use SOCK_CLOEXEC if present, fcntl() + FD_CLOEXEC otherwise Even if SOCK_CLOEXEC is present, fcntl() is used to

  1   2   >