[issue15573] Support unknown formats in memoryview comparisons

STINNER Victor added the comment: Even if I would prefer to see a fully working new implementation of the buffer interface, I agree with Georg: it's too late for such huge change in Python 3.3. Can' we wait Python 3.4 to change the equality operator? It also took me three major releases to fix a

[issue15573] Support unknown formats in memoryview comparisons

Stefan Krah added the comment: The effect of the change is pretty minimal though: Previously "not equal" was returned for unknown formats, now the struct module figures it out. memoryobject.c has 100% coverage except for a couple of lines that are either impossible to reach or very hard to reach

[issue15573] Support unknown formats in memoryview comparisons

Nick Coghlan added the comment: With Stefan's major improvements to the test suite for 3.3, the risk is low and I *really* don't want to spend the life of the 3.3 series excusing the current comparison behaviour. By contrast, explaining the shift in definition as moving from raw memory compar

[issue15573] Support unknown formats in memoryview comparisons

Georg Brandl added the comment: Well, I'm not against you committing it as long as you commit it *right now*. I'm about to cut the tag. -- ___ Python tracker ___ __

[issue15573] Support unknown formats in memoryview comparisons

Stefan Krah added the comment: > You can look at the attached memoryobject.c.gcov: *All* failure paths > are taken since Python API functions are wrapped in macros that > set PyExc_FailAPIError and return failure at predefined points > the test suite. That should read: With a patch that wraps Py

[issue15573] Support unknown formats in memoryview comparisons

Stefan Krah added the comment: Great, give me 20 minutes or so. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue15573] Support unknown formats in memoryview comparisons

Nick Coghlan added the comment: I'm currently on IRC and double checking the patch locally. -- ___ Python tracker ___ ___ Python-bugs-

[issue15573] Support unknown formats in memoryview comparisons

Nick Coghlan added the comment: Stefan, was there something specific you wanted to do before committing? Otherwise I can commit it as soon as this full test run finishes. -- ___ Python tracker

[issue7475] codecs missing: base64 bz2 hex zlib hex_codec ...

Changes by Nick Coghlan : -- priority: release blocker -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue15573] Support unknown formats in memoryview comparisons

Roundup Robot added the comment: New changeset afa3dedfee18 by Nick Coghlan in branch 'default': Close #15573: use value-based memoryview comparisons (patch by Stefan Krah) http://hg.python.org/cpython/rev/afa3dedfee18 -- resolution: -> fixed stage: patch review -> committed/rejected st

[issue15573] Support unknown formats in memoryview comparisons

Stefan Krah added the comment: Except for Misc/NEWS the patch can be committed unchanged. Please go ahead! [The remaining doc changes are tracked elsewhere.] -- ___ Python tracker _

[issue15781] test_threaded_import fails on Windows

New submission from Stefan Krah: test_parallel_module_init() fails on Windows-64: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/553/steps/test/logs/stdio == FAIL: test_parallel_module_init (test.te

[issue13370] test_ctypes fails when building python with clang

Ronald Oussoren added the comment: Duh... 3.3 without patch fails when I leave out '--with-pydebug'. I'm now running the testsuite for 2.7 and 3.2 with patch and will commit once those are ready, which should be within an hour from now. -- ___ Py

[issue15756] subprocess.poll() does not handle errno.ECHILD "No child processes"

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue15781] test_threaded_import fails on Windows

Changes by Nick Coghlan : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: The buildbot in question uses -j4, and I can reproduce this on Linux with: ./python -m test -uall -F -j4 -v test_threaded_import == FAIL: test_parallel_meta_path (test.test_threaded_import.Thread

[issue13518] configparser can’t read file objects from urlopen

Changes by Antoine Pitrou : -- resolution: -> invalid status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue15765] test_getcwd_long_pathnames (in test_posix) kills NetBSD

Stefan Krah added the comment: I completely forgot about that issue. The patch looks good to me. -- ___ Python tracker ___ ___ Python-

[issue13370] test_ctypes fails when building python with clang

Roundup Robot added the comment: New changeset 58a87c02692c by Ronald Oussoren in branch '2.7': Fix issue 13370: Ensure that ctypes works on Mac OS X when Python is compiled using the clang compiler http://hg.python.org/cpython/rev/58a87c02692c New changeset a425f2697273 by Ronald Oussoren in b

[issue13370] test_ctypes fails when building python with clang

Ronald Oussoren added the comment: The issue should be gone in the upcoming 3.3rc1 release and the next stable releases of 3.2 and 2.7. -- resolution: -> fixed status: open -> pending ___ Python tracker

[issue15781] test_threaded_import fails with -j4

Antoine Pitrou added the comment: With $ ./python -m test -uall -F -j16 -v test_threaded_import I couldn't reproduce after 1000 test passes. -- ___ Python tracker ___ ___

[issue15782] Compile error for a number of Mac modules with recent Xcode

New submission from Ronald Oussoren: Recent versions of Xcode on OSX 10.7 and 10.8 fail to compile 3 of the extension modules in Mac/Modules: the modules for fm, qd and qdoffs. That's because those extensions wrap APIs that are long deprecated and are no longer present. The attached patch "fi

[issue15781] test_threaded_import fails with -j4

Nick Coghlan added the comment: No joy here either - currently at 704 successful runs and counting with Stefan's command line. $ uname -a Linux lancre 3.5.1-1.fc17.x86_64 #1 SMP Thu Aug 9 17:50:43 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux $ cat /proc/cpuinfo | grep "model name" model name

[issue12834] memoryview.to_bytes() and PyBuffer_ToContiguous() incorrect for non-contiguous arrays

Martin v. Löwis added the comment: The last bugfix release of 3.2 will happen "shortly" after the release of 3.3, so in a not-too-far future (compared to the age of this issue, which just had its first birthday yesterday). So if this issue should really block 3.2 (which I still think it should

[issue12834] memoryview.to_bytes() and PyBuffer_ToContiguous() incorrect for non-contiguous arrays

Nick Coghlan added the comment: Despite my earlier comments, I'm now inclined to agree with Martin here - upgrading to 3.3 fixes so many other problems with memoryview, that's a more compelling solution. And, of course, using NumPy instead always remains an option for more robust buffer API s

[issue12834] memoryview.to_bytes() and PyBuffer_ToContiguous() incorrect for non-contiguous arrays

Nick Coghlan added the comment: (Not saying this shouldn't be fixed, just saying it's not a disaster if it isn't) -- ___ Python tracker ___ _

[issue12834] memoryview.to_bytes() and PyBuffer_ToContiguous() incorrect for non-contiguous arrays

Stefan Krah added the comment: I agree that for 3.2 this isn't so important given that non-contiguous arrays have multiple issues there. Christian, does a fix for 3.2 benefit FreeImage? Don't you run into other problems with memoryview? If it helps, I can try to write a patch for 3.2. ---

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: I can only reproduce this on a Core i7. Native OS is Debian Wheezy, also reproduced earlier on a FreeBSD VM hosted on that machine (see msg167989). The machine has 4 physical cores, perhaps we can blame hyper-threading. ;) $ cat /proc/cpuinfo | grep "model name" m

[issue15776] Allow pyvenv to work in existing directory

Roundup Robot added the comment: New changeset b200acb6bed4 by Andrew Svetlov in branch 'default': Delete Misc/NEWS record for reverted #15776. http://hg.python.org/cpython/rev/b200acb6bed4 -- ___ Python tracker __

[issue15776] Allow pyvenv to work in existing directory

Changes by Andrew Svetlov : -- priority: release blocker -> critical stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-lis

[issue15724] Add "versionchanged" to memoryview docs

Stefan Krah added the comment: This was less work than expected. I suppose docs can always go in even after rc1 is out, so I'll wait for that. -- keywords: +patch Added file: http://bugs.python.org/file26994/issue15724.diff ___ Python tracker

[issue15781] test_threaded_import fails with -j4

Nick Coghlan added the comment: Up to 2279 runs without a failure here - yay for elusive hardware specific threading bugs :P I'll leave it running overnight and see what happens. -- ___ Python tracker ___

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: I can also reproduce it on the Core 2 machine with a ridiculuously low switch interval: diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py --- a/Lib/test/regrtest.py +++ b/Lib/test/regrtest.py @@ -198,6 +198,8 @@ except ImportError: multiprocessing =

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: Oh, and as usual, my machines have all CPUs at 100% load. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

New submission from Nick Coghlan: decimal.localcontext() works correctly with both the pure Python decimal module and the C accelerator. decimal.localcontext(None) only works with the pure Python version. The C accelerator throws an exception instead of treating it as equivalent to omitting t

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Nick Coghlan added the comment: Georg, a regression in the decimal API relative to 3.2 got picked up by #15136. Are you OK with cherrypicking a fix for this into rc2? -- nosy: +georg.brandl ___ Python tracker

[issue15136] Decimal accepting Fraction

Nick Coghlan added the comment: There is indeed a regression in decimal.localcontext with the C accelerator: omitting the argument entirely still works, but passing None explicitly now fails. I created #15783 for that. On the topic of this thread, I'm also -1 on conversion methods, but +1 on

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Stefan Krah added the comment: The feature is undocumented though. Is it a regression? There are other places as well. The topic was raised in msg153447 and msg153506, with no further comments. So I concluded that None argument support wasn't important. -- _

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Nick Coghlan added the comment: While it's undocumented in the main docs [1], help(decimal.localcontext) in 3.2 starts with: localcontext(ctx=None) Return a context manager for a copy of the supplied context We essentially have two votes in favour of "it should work" (the pure Python impl

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Ezio Melotti added the comment: Can't this be fixed in the CONTEXT_CHECK_VA macro? With the attached patch decimal.localcontext(None) works and there aren't any failures, however I don't think there are tests that pass None explicitly, so this approach might not work. -- keywords: +pat

[issue10650] decimal.py: quantize(): excess digits with watchexp=0

Stefan Krah added the comment: Here's a patch deprecating watchexp. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue10650] decimal.py: quantize(): excess digits with watchexp=0

Changes by Stefan Krah : -- keywords: +patch Added file: http://bugs.python.org/file26996/issue10650.diff ___ Python tracker ___ ___ P

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Stefan Krah added the comment: OK, but for example: Help on function __truediv__ in module decimal: __truediv__(self, other, context=None) Return self / other. Here I think it's undisputed that a C version should not cram a context argument into a number method. There are many functions in

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Stefan Krah added the comment: > Can't this be fixed in the CONTEXT_CHECK_VA macro? No, the macro should only allow contexts. E.g. in the case of localcontext(None) context_copy(local, NULL) would be called on local=Py_None, which is undefined. What would perhaps be needed for a nice C-API is a

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Stefan Krah added the comment: This is the complete list of context=None divergences. It would be possible to change that, since most of the functions are generated by macro wrappers. # This is the only place where 'ctx' is used localcontext(ctx=None) canonical(self, context=None) compare(self

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Mark Dickinson added the comment: This doesn't strike me as something it's essential to resolve before 3.3.1. And I agree that decimal.localcontext(None) looks peculiar. I noticed this yesterday when looking at #15136 and dismissed it as an artifact of the implementation---I didn't think to c

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Mark Dickinson added the comment: Adding Raymond to the nosy, since he may know more about what was intended. -- nosy: +rhettinger ___ Python tracker ___

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

Chris Jerdonek added the comment: > Personally I prefer to have the test case create the file(s) used in the test > dynamically, writing them to the temporary working directory. I prefer that too, but when I approached this issue, I found that test_doctest doesn't use unittest. It uses only d

[issue15136] Decimal accepting Fraction

Terry J. Reedy added the comment: After reading the comments, I am ambivalent about a conversion function, and given the lack of consensus or even a clear majority, -1. (Which implies a change in issue title.) I am +1 on using the new .format() machinery to have fractions format themselves. (

[issue15222] mailbox.mbox writes without empty line after each message

Petri Lehtinen added the comment: Attaching two patches. Patch 1 changes the common message template in mailbox tests to end in a newline. If this wasn't done, more or less all common mailbox tests would have to be special cased for mbox. Patch 2 adds a single blank line after each message in

[issue15222] mailbox.mbox writes without empty line after each message

Changes by Petri Lehtinen : -- keywords: +needs review stage: -> patch review Added file: http://bugs.python.org/file26999/issue15222_v1_0002_insert_blank_after_each_message_in_mbox.patch ___ Python tracker _

[issue15781] test_threaded_import fails with -j4

Eric Snow added the comment: So this was a random one-off (hardly even intermittent) failed test that passed on the retry. Ah, threads. Is there an easy way to find all other failures in test_threaded_import in the past, for this and for all buildbots? Do we have information about load duri

[issue15781] test_threaded_import fails with -j4

Eric Snow added the comment: (sorry, only saw the first couple messages) -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

Chris Jerdonek added the comment: Small tweak to a code comment in the patch (`tests` is not itself a unittest.TestSuite instance). -- Added file: http://bugs.python.org/file27000/issue-14649-4.patch ___ Python tracker

[issue15784] OSError.__str__() should distinguish between errno and winerror

New submission from Richard Oudkerk: Since WindowsError became an alias of OSError, the error number shown in the stringification of an OSError err can either be a windows error code (err.winerror) or a posix style error number (err.errno), with no way to tell which. For instance in >>> os

[issue15784] OSError.__str__() should distinguish between errno and winerror

Changes by Richard Oudkerk : Added file: http://bugs.python.org/file27002/winerror.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue15784] OSError.__str__() should distinguish between errno and winerror

Changes by Richard Oudkerk : Removed file: http://bugs.python.org/file27001/winerror.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: On the i7 machine with hyper-threading the issue occurs since edb9ce3a6c2e. The tests also got slower: 3430d7329a3b: $ time ./python -m test -uall -v test_threaded_import real0m3.195s user0m0.656s sys 0m0.284s edb9ce3a6c2e: $ time ./python -m te

[issue15720] move __import__() out of the default lookup chain

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15753] No-argument super in method with variable arguments raises SystemError

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15749] cgitb prints html for text when display disabled.

Éric Araujo added the comment: Thanks for the report and patch. Is this a duplicate of #12890? -- nosy: +eric.araujo ___ Python tracker ___ _

[issue11776] Constructor signatures missing in types module documentation

Mike Hoy added the comment: I've added a completed patch for review. There was some talk on IRC that the wording for MappingProxyType should be changed to: "Return a read-only view of the given mapping." We decided to leave it to the review process to determine the exact wording. -- A

[issue15749] cgitb prints html for text when display disabled.

aliles added the comment: Not an exact duplicate, although I should have seen that issue. Oops. The 'display' and 'logdir' arguments are independent. Although I do appear to have gone a little overboard and fixed 12890 issue as well. Should I wait for that fix to be merged then reissue the pat

[issue11776] Constructor signatures missing in types module documentation

Mike Hoy added the comment: Ezio Melotti was the one that offered to change the wording on MappingProxyType doc -- ___ Python tracker ___ ___

[issue11776] Constructor signatures missing in types module documentation

Ezio Melotti added the comment: > We decided to leave it to the review process to determine the exact wording. The problem with the current wording is that it explain how to use it (in case it's used to create a new mapping proxy), but doesn't say much about the object itself (in case it's use

[issue15510] textwrap.wrap('') returns empty list

Chris Jerdonek added the comment: Here is a patch that documents and adds tests for the existing behavior (i.e. keeping the current behavior the same). I also expanded the patch slightly to cover related edge cases that involve the interplay between whitespace, empty lines, and indenting (some

[issue12890] cgitb displays tags when executed in text mode

Ezio Melotti added the comment: What about closing the too (see attached patch)? (I know the is not necessary, but I prefer to add it.) -- Added file: http://bugs.python.org/file27005/issue12890.diff ___ Python tracker

[issue15767] add ModuleNotFoundError

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue13801] The Python 3 Docs don't highlight nonlocal

Ezio Melotti added the comment: Sphinx is configured to use Python3Lexer (highlight_language is set to 'python3' in Doc/conf.py). 'nonlocal' is not highlighted because in the pygments version that we are using 'nonlocal' is missing in Python3Lexer.tokens['keywords'] see (Doc/tools/pygments/lex