[issue1812] doctest _load_testfile function -- newline handling seems incorrect

2012-07-24 Thread Peter Donis
Peter Donis added the comment: I recently noticed that there has been a minor code change in the _load_testfile function in doctest, so I generated a new patch against the latest pull from Mercurial (cpython). No actual changes to the issue fix, but this patch should apply cleanly against a c

[issue15441] test_posixpath fails on Japanese edition of Windows

2012-07-24 Thread Atsuo Ishimoto
Changes by Atsuo Ishimoto : Removed file: http://bugs.python.org/file26502/test_nonascii_abspath_2.patch ___ Python tracker ___ ___ Python-bug

[issue15269] Document dircmp.left and dircmp.right

2012-07-24 Thread Eli Bendersky
Eli Bendersky added the comment: Makes sense. I agree that publicly exposing the left/right attributes makes sense. But let's do it properly: 1. Add an example to the documentation 2. Add some tests to Lib/test/test_filecmp.py that verify these attributes behave as expected In addition, I th

[issue15441] test_posixpath fails on Japanese edition of Windows

2012-07-24 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: I'm sorry, I generated a patch in wrong direction. -- Added file: http://bugs.python.org/file26506/issue15441.patch ___ Python tracker ___

[issue15207] mimetypes.read_windows_registry() uses the wrong regkey, creates wrong mappings

2012-07-24 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: This patch looks good to me. I generated a patch for current trunk, with some cosmetic changes. -- nosy: +ishimoto Added file: http://bugs.python.org/file26507/issue15207.patch ___ Python tracker

[issue11549] Build-out an AST optimizer, moving some functionality out of the peephole optimizer

2012-07-24 Thread Meador Inge
Changes by Meador Inge : -- nosy: +meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue2122] mmap.flush does not check for errors on windows

2012-07-24 Thread Atsuo Ishimoto
Changes by Atsuo Ishimoto : -- nosy: +ishimoto ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue1812] doctest _load_testfile function -- newline handling seems incorrect

2012-07-24 Thread Peter Donis
Peter Donis added the comment: Updated patch to ensure that tests pass when the -v flag is set running the test suite. This is done by having the helper script, doctest_testfile.py, call doctest.testfile with verbose=False to ensure there is no output if the test passes (which is what the mas

[issue15436] __sizeof__ is not documented

2012-07-24 Thread Eric Snow
Eric Snow added the comment: issue2898 smells like an implementation detail to me. Also, sys.getsizeof() isn't necessarily authoritative here, since the sys module is full of all sorts of implementation details. I'm not saying __sizeof__ shouldn't be made an official part of the language, bu

[issue15402] Correct __sizeof__ support for struct

2012-07-24 Thread Meador Inge
Meador Inge added the comment: I agree with Martin on having tests for the exact values and the s_len + 1 point. I will fix both issues. -- assignee: -> meador.inge nosy: -python-dev stage: patch review -> needs patch ___ Python tracker

[issue15439] Include Misc/ACKS names into the documentation

2012-07-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: Okay, thanks for clarifying. Then I have no strong opinion. However, if Doc/ACKS.txt is retained, then I think the Dev Guide should mention Doc/ACKS.txt just as it mentions Misc/ACKS: http://docs.python.org/devguide/patch.html#preparation And it should incl

[issue15444] Incorrectly writen contributor's names

2012-07-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > It seems to be the latter: Žiga Seilnacht Then Misc/ACKS should be corrected too. -- ___ Python tracker ___ __

[issue15444] Incorrectly writen contributor's names

2012-07-24 Thread Chris Jerdonek
Chris Jerdonek added the comment: Is there a reason not to correct that spelling in this issue? Otherwise, we could create a new issue. -- ___ Python tracker ___ _

[issue15439] Include Misc/ACKS names into the documentation

2012-07-24 Thread Martin v . Löwis
Martin v. Löwis added the comment: I don't know how Doc ACKS is maintained, but I think the devguide is fine as it stands, whether or not Doc ACKS is preserved or not. People should put themselves into Misc/ACKS if they made a contribution, period. If people need to be acknowledged separately

<    1   2