[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: The more I think about it, the more the bootstrap code in _elementtree.c annoys me. It's the only instance of calling PyRun_String in Modules/ ! It's hackish and causes ugly import problems. If the C code needs stdlib functionality like copy.deepcopy, it shoul

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Stefan Behnel added the comment: Eli Bendersky, 11.02.2012 09:08: > The more I think about it, the more the bootstrap code in _elementtree.c > annoys me. It's the only instance of calling PyRun_String in Modules/ ! > > It's hackish and causes ugly import problems. If the C code needs stdlib > f

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: >> I find it perfectly legitimate to run Python code from a C module. Certainly not a hack. We all know that most non-trivial functionality can be expressed much easier in Python than in C, that's why we use Python after all. In particular, defining a class with

[issue13953] Get rid of doctests in packaging.tests.test_version

Francisco Martín Brugué added the comment: Thank you for the review. Just some questions: Isn't that what the previous code (doctest code) did? I thought that the code should be ported as far backwards as possible and that's why I used the plain assertEqual (I don't know exactly in with vers

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Florent Xicluna added the comment: > Anyhow, I tried to apply it and a few tests in test_xml_etree_c fail, > because it can't find fromstring and fromstringlist. Ooops, I cut some redundancy after running the tests, and I forgot to re-add the import. You're right. > However, why did you leave

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Florent Xicluna added the comment: Updated patch: - fixed missing import and missing alias - moved the XMLTreeBuilder alias to the Python module -- ___ Python tracker ___

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Changes by Florent Xicluna : Added file: http://bugs.python.org/file24485/issue13988_prepare_pep399_v2.diff ___ Python tracker ___ ___ Python-

[issue12659] Add tests for packaging.tests.support

Francisco Martín Brugué added the comment: On 02/11/2012 05:59 AM, Éric Araujo wrote: >> BTW: in distutils2 I get (not because of this change): > Actually I did fix that, but depending on your Python version the conditional > in the test may be wrong. What’s the Python version you used? I di

[issue13123] bdist_wininst uninstaller does not remove pycache directories

Paul Moore added the comment: I'll try to take a look over the next couple of days. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: >> Do I need to hg clone then do some magic pip incantation to get it installed? > Why would you want to install it?  Clone it, hack on it in place, run tests > in place.  :) > > FTR, “bin/pip install -e .” is the command to “install” a project in develop > (or ed

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Roundup Robot added the comment: New changeset 31dfb4be934d by Florent Xicluna in branch 'default': Issue #13988: move the python bootstrap code to cElementTree.py, and remove obsolete code for Python 2.4 and 2.5. http://hg.python.org/cpython/rev/31dfb4be934d -- nosy: +python-dev

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Florent Xicluna added the comment: I've pushed this first part, which is just a code refactoring. I tried to work out a patch for the second part. The tricky thing is because of xml.etree still using doctests. The patch for the tests seems to be enough small and readable. We have small differe

[issue13991] namespace packages depending on order

andrea crotti added the comment: There is nothing binary in the archive, just a simple example of namespace packages, which was the minimal example that I could create to make things fail. I use the standard pkg_resources way to do things: __import__('pkg_resources').declare_namespace(__name__

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: Another random cleanup idea: ElementTree.py has this code: try: from . import ElementPath except ImportError: ElementPath = _SimpleElementPath() Since in the stdlib ElementPath.py is always there, this is meaningless, so I'd say this try... except Imp

[issue13992] Segfault in PyTrash_destroy_chain

New submission from Aaron Staley : Am frequently getting segmentation faults with my python program. I am utilizing heavy use of threading and sockets. All sorts of ones are showing in syslog: kernel: [7763578.475590] python[10097]: segfault at 88e5a0 ip 0088e5a0 sp 7f640efd4028

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Nadeem Vawda added the comment: All tests pass with the patch applied, on both Windows 7 and Ubuntu 11.10. I notice that the patch only changes Lib/packaging/manifest.py; does Lib/distutils/filelist.py perhaps also need to be updated? Changeset 64485e0700ba modified both of these files. --

[issue13992] Segfault in PyTrash_destroy_chain

Aaron Staley added the comment: For some more context: Python 2.7.2 Running on Amazon EC2 Linux 3.0.0-14-virtual x86_64 in ubuntu 11.10 170 threads in this particular core dump (another similar crash has 135) -- ___ Python tracker

[issue13993] Handling of broken end tags in HTMLParser

New submission from Ezio Melotti : The attached patch fixes the parser to handle broken end tags like: < -- assignee: ezio.melotti components: Library (Lib) files: issue13993.diff keywords: patch messages: 153126 nosy: eric.araujo, ezio.melotti priority: normal severity: normal stag

[issue5148] gzip.open breaks with 'U' flag

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue13989] gzip always returns byte strings, no text mode

Nadeem Vawda added the comment: The problem here is that gzip.GzipFile does not support text mode, only binary mode. Unfortunately, its __init__ method doesn't handle unexpected mode strings sensibly, so you get a confusing error message. If you need to open a compressed file in text mode in Py

[issue13992] Segfault in PyTrash_destroy_chain

Charles-François Natali added the comment: The crash occurs in an oject's destructor. Are you using any third-party module (lsof/pmap can help)? Also, it'd help if you tried reproducing the crash with a debug build (./configure --with-pydebug && make). -- nosy: +neologix

[issue13993] Handling of broken end tags in HTMLParser

Changes by Ezio Melotti : Added file: http://bugs.python.org/file24488/issue13993-2.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue13952] mimetypes doesn't recognize .csv

Antoine Pitrou added the comment: > About Antoine’s remark: mimetypes already reads mime.types files, so > even if our internal registry is not up-to-date the module should know > about all types present in /etc/mime.types. The point was about systems which don't have a /etc/mime.types (Windows

[issue13994] incomplete revert in 2.7 Distutils left two copies of customize_compiler

New submission from Ned Deily : While final testing Distutils changes for Issue13590, I noticed that a few tests were failing unexpectedly on 2.7.x but passing on 3.2.x. Upon further investigation, I discovered that in 2.7 there are two copies of "customize_compiler", the function being modif

[issue13994] incomplete revert in 2.7 Distutils left two copies of customize_compiler

Changes by Ned Deily : -- keywords: +patch stage: needs patch -> commit review Added file: http://bugs.python.org/file24489/issue13994_27.patch ___ Python tracker ___ ___

[issue5411] add xz compression support to shutil

Nadeem Vawda added the comment: > This not-so-bad patch adds lzma compression support to the shutil functions, > under the 'xztar' name. Please review. Functionally, the patch looks good to me. There are some docstrings that should probably be updated, though: - _make_tarball (the 'compress'

[issue13878] test_sched failures on Windows buildbot

Nadeem Vawda added the comment: Patch looks good, but you might want to make this change to test_priority: l = [] fun = lambda x: l.append(x) scheduler = sched.scheduler(time.time, time.sleep) +now = time.time() for priority in [1,

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13994] incomplete revert in 2.7 Distutils left two copies of customize_compiler

Roundup Robot added the comment: New changeset 6240ff5dfebe by Ned Deily in branch '2.7': Issue #13994: Earler partial revert of Distutils enhancements in 2.7 http://hg.python.org/cpython/rev/6240ff5dfebe -- nosy: +python-dev ___ Python tracker

[issue13994] incomplete revert in 2.7 Distutils left two copies of customize_compiler

Ned Deily added the comment: With the release manager's concurrence, I've applied this patch prior to the freeze for 2.7.3. -- assignee: tarek -> ned.deily priority: release blocker -> normal resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed _

[issue13990] Benchmarks: 2to3 failures on the py3 side

Antoine Pitrou added the comment: > Antoine (since you last looked at the benchmark suite for Python 3), do > you know anything about this? I don't know. It works here. It may depend on the version of 2to3 used for the conversion, try passing PYTHON=some_newer_python when running make_perf.sh

[issue13995] sqlite3 Cursor.rowcount documentation for old sqlite bug

New submission from Matthew Woodcraft : The documentation for the sqlite3 module contains the following statement, under 'Cursor.rowcount': For DELETE statements, SQLite reports rowcount as 0 if you make a DELETE FROM table without any condition. This doesn't happen for me (with sqlite 3.7.

[issue2636] Adding a new regex module (compatible with re)

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue13952] mimetypes doesn't recognize .csv

R. David Murray added the comment: On Windows we do (now) read from the registry as well. My guess is there are a lot more Windows systems out there with outdated registries then there are unix systems with outdated /etc/mime files, though. -- ___

[issue13996] "What's New in Python" should have initial release date on heading

New submission from Tshepang Lekhonkhobe : As an example, the date near the top of this document http://docs.python.org/py3k/whatsnew/3.0.html matches that of today, which can be misleading (it appears as if the thing was released today). Also, by initial release, I mean the first "final", not

[issue13996] "What's New in Python" should have initial release date on heading

Changes by Ezio Melotti : -- nosy: +eric.araujo, ezio.melotti, georg.brandl, terry.reedy versions: -Python 2.6, Python 3.1 ___ Python tracker ___ ___

[issue13989] gzip always returns byte strings, no text mode

Roundup Robot added the comment: New changeset 4b32309631da by Nadeem Vawda in branch '3.2': Issue #13989: Document that GzipFile does not support text mode. http://hg.python.org/cpython/rev/4b32309631da New changeset 8dbe8faea0e7 by Nadeem Vawda in branch 'default': Merge: #13989: Document tha

[issue13703] Hash collision security issue

Dave Malcolm added the comment: I'm not quite sure how that would interact with the -R command-line option for enabling randomization. The changes to the docs in the latest patch clarifies the meaning of what I've implemented (I hope). My view is that we should simply enable hash randomization

[issue13881] Stream encoder for zlib_codec doesn't use the incremental encoder

Jesús Cea Avión added the comment: Andrew, could you possibly write a patch and a test for 3.3? -- nosy: +jcea versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ _

[issue13703] Hash collision security issue

Gregory P. Smith added the comment: Should -R be required to take a parameter specifying "on" or "off" so that code using a #! line continues to work as specified across the a change in default behavior when upgrading from 3.2 to 3.3? #!/usr/bin/python3 -R on #!/usr/bin/python3 -R off In 3.3 i

[issue13703] Hash collision security issue

Gregory P. Smith added the comment: Comments to be addressed added on the code review. -- ___ Python tracker ___ ___ Python-bugs-list

[issue13996] "What's New in Python" should have initial release date on heading

Éric Araujo added the comment: I agree that the date of the release would be more useful than the date of the doc build. -- nosy: +rhettinger ___ Python tracker ___ ___

[issue13991] namespace packages depending on order

Éric Araujo added the comment: > There is nothing binary in the archive The archive is a binary file. We tend to dislike those because we need to download and process them instead of just reading them in a browser tab, and in some cases (Windows .exe files) there are also security reasons. I

[issue10287] NNTP authentication should check capabilities

Antoine Pitrou added the comment: Hynek, the patch doesn't apply properly here. Are you soon it's been generated against an up-to-date working copy? Also, I think the logic is wrong: the capabilities should *always* be queried after auth, even if they are already known. That's because they ca

[issue10287] NNTP authentication should check capabilities

Antoine Pitrou added the comment: (oh, and better if it can come with a test) -- type: -> behavior versions: +Python 3.3 ___ Python tracker ___

[issue13994] incomplete revert in 2.7 Distutils left two copies of customize_compiler

Éric Araujo added the comment: FWIW I approve of the patch. Quoting Ned: > this isn't the first time we've been burned by the after effects of the 2.7 > Distutils > revert. I really think we should go through and make sure there aren't other > unnecessary > discrepancies between the current

[issue13953] Get rid of doctests in packaging.tests.test_version

Éric Araujo added the comment: > Isn't that what the previous code (doctest code) did? I don’t understand, could you rephrase? > I thought that the code should be ported as far backwards as possible and > that's why I > used the plain assertEqual (I don't know exactly in with version the other

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Éric Araujo added the comment: >> I think that 3.2 and 2.7 should get a doc note about cET > What doc note? I was referring to one of the points raised in the email thread: the docs don’t tell people that they can import a faster ET version, cET. -- __

[issue13950] rm commented-out code

Éric Araujo added the comment: Done as part of my general cleanup of test_version. -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Get rid of doctests in packaging.tests.test_version ___ Python tracke

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset c566a3447ba1 by Éric Araujo in branch '2.7': Fix distutils.filelist.FileList under Windows (#13193). http://hg.python.org/cpython/rev/c566a3447ba1 -- ___ Python tracker

[issue13949] rm needless use of pass statement

Éric Araujo added the comment: Will commit this together with the test_version cleanup. -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Get rid of doctests in packaging.tests.test_version ___ Python t

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: >> I was referring to one of the points raised in the email thread: the docs >> don’t tell people that they can import a faster ET version, cET. Well, they *do*, but very modestly :-) I agree that should be improved and emphasized a bit, perhaps even mentionin

[issue13996] "What's New in Python" should have initial release date on heading

Raymond Hettinger added the comment: I think this is the wrong place to show release dates (a subject that would be further confused by having multiple point releases). -- resolution: -> rejected status: open -> closed ___ Python tracker

[issue13948] rm needless use of set function

Éric Araujo added the comment: Done as part of my general test_version cleanup. -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Get rid of doctests in packaging.tests.test_version ___ Python tracker

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: Florent, The issue13988_fold_cET_behind_ET.diff patch looks good to me. Unless there are objections from others, you can commit! Even the tests became simpler now, that's awesome ;-) Now, what's left for this issue: 1. Update the documentation 2. Update "wha

[issue12297] Clarifications to atexit.register and unregister doc

Terry J. Reedy added the comment: I assume the patch is an improved description of reality. The old 'without binding the original name to ``None``.' is confusing to me in that context, so good riddance. However, I am not familiar with atexit or how it is intended to work. If you are not sure

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: Attaching a patch for Doc/library/xml.etree.elementtree.rst and Misc/NEWS. The doc notice is modeled after a similar notice in the doc of 'pickle'. Note that I've also removed the mention that effbot's site is the home of the development version of the library

[issue13946] readline completer could return an iterable

Changes by Terry J. Reedy : -- versions: +Python 3.3 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset 90b30d62caf2 by Éric Araujo in branch '3.2': Fix distutils.filelist.FileList under Windows (#13193). http://hg.python.org/cpython/rev/90b30d62caf2 New changeset 68347f8430ec by Éric Araujo in branch 'default': Merge fixes for #13193 and FAQ from 3.

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: Reverted the liberal fix and replaced it with Vinay’s in time for the next bugfix releases. Will watch buildbot and close the report. Thanks to all who helped. -- resolution: -> fixed stage: -> committed/rejected

[issue13952] mimetypes doesn't recognize .csv

Terry J. Reedy added the comment: One solution would be to update our mimetypes file just before a new version, and then leave it until the next, just as we update unicodedata to current unicode and then leave it alone for bugfix releases. Rather than the entire IANA file, which has a lot of

[issue13997] Add open_ascii() builtin

New submission from Nick Coghlan : (This proposes a new builtin, so may need to become a PEP) A common programming task is "I want to process this text file, I know it's in an ASCII compatible encoding, I don't know which one specifically, but I'm only manipulating the ASCII parts so it doesn'

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: Florent, Just something minor I noticed in the new cElementTree.py: # Wrapper module for _elementtree from xml.etree.ElementTree import * # Not in __all__ from xml.etree.ElementTree import ElementPath, XMLID, register_namespace The "wrapper" comment s

[issue13963] dev guide has no mention of mechanics of patch review

Terry J. Reedy added the comment: At one time, reviews (or the fact of a review) were posted back here automatically (or perhaps it is an option?) just like push messages. But I am not much familiar with the process either. -- nosy: +terry.reedy __

[issue13997] Add open_ascii() builtin

Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue13997] Add open_ascii() builtin

Eli Bendersky added the comment: Would not adding a new keyword arg to open() be less intrusive and more consistent? I.e. open(fname, asciionly=True) or something similar. -- nosy: +eli.bendersky ___ Python tracker

[issue13198] Remove duplicate definition of write_record_file

Changes by Éric Araujo : Removed file: http://bugs.python.org/file23666/remove-duplicate-write_record_file.diff ___ Python tracker ___ ___ Py

[issue13972] set and frozenset constructors don't accept multiple iterables

Terry J. Reedy added the comment: I believe s = set(); s.update(s1, s2, s3, ...) a) does what is requested; b) is the proper spelling, as the request *is* for a union of input collections. So I recommend closing. -- nosy: +terry.reedy ___ Python tra

[issue13997] Add open_ascii() builtin

Antoine Pitrou added the comment: Hmm, what happened to "not every one-liner should be a builtin function"? > I'm only manipulating the ASCII parts How can you be sure about that? > It would be significantly more friendly to beginners (and migrants from > Python 2) To the point that many of

[issue13997] Add open_ascii() builtin

Chris Rebert added the comment: @Bendersky: Unlike open()'s other arguments, that one wouldn't be orthogonal though. It would be possible to write e.g.: f = open(fname, encoding="big5", errors="replace", ascii_only=True) which seems disturbing, IMO. It would be nicer to rule out such impossi

[issue13997] Add open_ascii() builtin

Nick Coghlan added the comment: No point to adding a new keyword arg - if people are going to do something like that, they may as well learn to use "errors" and "encoding" properly. Adding open_ascii() would be an acknowledgement that "basically ASCII, but maybe with a few other bytes that ju

[issue13986] ValueError: cannot convert float NaN to integer

Terry J. Reedy added the comment: If I believe the error message, os.fstat(f.fileno()).st_mtime is returning a NaN, which would be a bug in our function or your system. Since os.fstat should be a thin wrapper over the system call, I would lean to the latter. I do not know if writing to sys.st

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: Buildbots exist to crush joy: http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%202.7/builds/1285/steps/test/logs/stdio/text Possible ways forward: - One of you gentlemen with a Windows box and a clear head can try to find a correct fix for the bug - If

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Antoine Pitrou added the comment: > Possible ways forward: > - One of you gentlemen with a Windows box and a clear head can try to > find a correct fix for the bug This error shows that distutils's own test suite relies on being able to put both kind of path separators in a manifest, so my fix

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Éric Araujo added the comment: > perhaps even mentioning (at least in the 3.2 doc) that in 3.3 it's going > to be done by default. Is that accepted practice? I don’t think we ever do that, and it would be confusing. -1 to mentioning _elementtree, an implementation detail. What I was talking a

[issue12297] Clarifications to atexit.register and unregister doc

Éric Araujo added the comment: I wrote the patch after testing in a shell, so I’m confident it describes reality; I was more asking a wording/phrasing review. -- ___ Python tracker ___

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: I’d say there is a bug in the tests then. Remember that they were added recently and only tested on posix, so they’re not authoritative. -- ___ Python tracker _

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Antoine Pitrou added the comment: > I’d say there is a bug in the tests then. Remember that they were > added recently and only tested on posix, so they’re not authoritative. How about people who have similar "bugs" in their code then? I think you're trying to be pure instead of practical. --

[issue13997] Add open_ascii() builtin

Éric Araujo added the comment: IMO it is a fact that the characters used by human languages are stored as bytes by computers, so a programmer needs to know the basics about text handling and encoding. I don’t like the idea of a built-in function helping people to put their hands on their ear

[issue13988] Expose the C implementation of ElementTree by default when importing ElementTree

Eli Bendersky added the comment: Éric, Could you please open a new issue (with a dependency on this one) and explain there clearly what you want/mean? -- ___ Python tracker __

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

Éric Araujo added the comment: FYI the tests revealed a bug in the code on Windows: #13193 -- ___ Python tracker ___ ___ Python-bugs-

[issue13997] Add open_ascii() builtin

Nick Coghlan added the comment: Pondering it further (and reading subsequent comments here and in the thread), I agree an open_ascii() builtin would be a step backwards, not forwards. So, morphing this issue into a documentation one to work out: - the bare minimum we think Python 3 users shoul

[issue13997] Clearly explain the bare minimum Python 3 users should know about Unicode

Changes by Nick Coghlan : -- assignee: -> docs@python components: +Documentation nosy: +docs@python title: Add open_ascii() builtin -> Clearly explain the bare minimum Python 3 users should know about Unicode versions: +Python 3.2, Python 3.3 ___ Py

[issue13997] Clearly explain the bare minimum Python 3 users should know about Unicode

Eli Bendersky added the comment: If the concept is accepted. I see no better place for this than the Unicode HOWTO. If it's too long, then a TL;DR; section should be added in the beginning detailing "the bare minimum". No need to scatter such information in bits and pieces around the documentati

[issue13609] Add "os.get_terminal_size()" function

Arfrever Frehtes Taifersar Arahesis added the comment: test_stty_match() should be skipped also when os.isatty(sys.__stdin__.fileno()) is False. This test fails when test suite is run by Portage (Gentoo package manager), which somehow sets null input. -- _

[issue13609] Add "os.get_terminal_size()" function

Zbyszek Szmek added the comment: Hi, looking at the tests, the test should be skipped with 'stty invocation failed'. Does something different happen? Can you post the output from the tests? -- ___ Python tracker

[issue13198] Remove duplicate definition of write_record_file

Éric Araujo added the comment: Patch attached. Adding people from #13175 for review/testing on Windows. -- keywords: +needs review nosy: +pmoore, tarek, vinay.sajip stage: test needed -> patch review Added file: http://bugs.python.org/file24494/remove-duplicate-write_record_file.diff