[issue8087] Unupdated source file in traceback

Nick Coghlan added the comment: (just reviewing the idea here, not the current patch) The problem of "stale code" (i.e. what was executed doesn't match what is displayed in the traceback) is a tricky and subtle one. There are a few different cases: 1. Source displayed does not match source o

[issue2945] bdist_rpm does not list dist files (should effect upload)

Carl Robben added the comment: Here's a patch for test_bdist_rpm.py and to check the contents of dist.dist_files -- Added file: http://bugs.python.org/file23363/test_bdist_rpm.patch ___ Python tracker

[issue2945] bdist_rpm does not list dist files (should effect upload)

Carl Robben added the comment: Adding a patch for 2.7 -- Added file: http://bugs.python.org/file23364/bdist_rpm-2.7.patch ___ Python tracker ___ _

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

Changes by Ezio Melotti : Removed file: http://bugs.python.org/file23355/issue12753-4.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

Changes by Ezio Melotti : Added file: http://bugs.python.org/file23365/issue12753-4.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue11776] types.MethodType() params and usage is not documented

Changes by Guandalino : -- nosy: +guandalino ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue13143] os.path.islink documentation is ambiguous

Changes by Eric V. Smith : -- nosy: +eric.smith, jason.coombs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue1673007] urllib2 requests history + HEAD support

Ezio Melotti added the comment: Attached an updated patch that addresses the comments of Éric in the review and adds an entry to the whatsnew. -- assignee: orsenthil -> ezio.melotti keywords: +needs review nosy: -BreamoreBoy stage: patch review -> commit review Added file: http://bugs

[issue13144] Global Module Index link in the offline documentation is incorrect

New submission from Graeme Glass : On my machine (Ubuntu 11.04) the link to "Python Module Index" from the index page is incorrect in the "Indices and tables" section (it links to modindex.html instead of py-modindex.html). It links to the correct place in the navigation bar at the top right

[issue13062] Introspection generator and function closure state

Nick Coghlan added the comment: No, the naming problem had occurred to me as well. Given the 'vars' builtin, perhaps 'getclosurevars' would do as the name? -- ___ Python tracker __

[issue13145] Documentation of PyNumber_ToBase() wrong

New submission from Sven Marnach : The documentation of PyNumber_ToBase() [1] states When base is not 2, 8, 10, or 16, the format is 'x#num' where x is the base. In reality, the function does not accept any bases different from 2, 8, 10, or 16, as can be seen in the source code of _PyL

[issue1673007] urllib2 requests history + HEAD support

Senthil Kumaran added the comment: Hi Ezio, I had probably overlooked this one. But It's a very interesting one for me. Do you mind if I commit it ? On Oct 10, 2011 7:20 PM, "Ezio Melotti" wrote: > > Ezio Melotti added the comment: > > Attached an updated patch that addresses the comments of

[issue13143] os.path.islink documentation is ambiguous

Jason R. Coombs added the comment: Thanks Garen for the detailed analysis and writeup. The short answer to your question is "supported by the Python runtime". Allow me to provide a bit of history. Symlink awareness under Windows was added to Python in Python 3.2, so the behavior you see in P

[issue13062] Introspection generator and function closure state

Meador Inge added the comment: > perhaps 'getclosurevars' would do as the name? I like vars. Updated patch attached. -- Added file: http://bugs.python.org/file23368/issue13062-3.patch ___ Python tracker

[issue13143] os.path.islink documentation is ambiguous

Ezio Melotti added the comment: > Symlink awareness under Windows was added to Python in Python 3.2 If they are not available on Windows with 2.7, the doc should get an "availability: unix" or something similar (depending on where they are actually supported), or mention explicitly symlink fo

[issue1673007] urllib2 requests history + HEAD support

Éric Araujo added the comment: I made some more comments. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11776] types.MethodType() params and usage is not documented

Changes by Éric Araujo : -- keywords: +easy versions: +Python 2.7, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue3902] Packages containing only extension modules have to contain __init__.py

Éric Araujo added the comment: You did not reply to my first question on apiref.rst, and you did not rewrap your lines to 80 chars :) -- ___ Python tracker ___ _

[issue13055] Distutils tries to handle null versions but fails

Éric Araujo added the comment: > The bug was encountered while trying to install a package. As it turns > out, a dependency was incorrectly installed, resulting in a null > version being passed around which quickly caused a crash in setup.py. > While this is definitely not a normal circumstance,

[issue2945] bdist_rpm does not list dist files (should effect upload)

Éric Araujo added the comment: Looks good. Do you have rpm on your machine? If yes, have you run the tests successfully? -- stage: needs patch -> patch review ___ Python tracker _

[issue12436] Missing items in installation/setup instructions

Éric Araujo added the comment: Thanks, I will take all contributions and suggestions and propose one patch. -- assignee: docs@python -> eric.araujo ___ Python tracker ___ __

[issue12602] Missing cross-references in Doc/using

Éric Araujo added the comment: > For new doc editors, it would be nicer if the filename (directory name, > actually) > had been changed to 'py_setup' or even 'py_usage'. py_setup would conflict with pysetup, the installer part of distutils2/packaging. py_ seems redundant to me, we are in the

[issue13062] Introspection generator and function closure state

Nick Coghlan added the comment: In reviewing Meador's patch (which otherwise looks pretty good), I had a thought about the functionality and signature of getclosurevars(). Currently, it equates "closure" to "nonlocal scope", which isn't really true - the function's closure is really the curre

[issue12393] Packaging should provide support for extensible categories

Vinay Sajip added the comment: > Can you add tests? https://bitbucket.org/vinay.sajip/pythonv/changeset/f7c5098e3c3b -- ___ Python tracker ___ _

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

M. Zilmer added the comment: Just to make it clear: I have not observed any problems on the Windows terminal (cmd) with \n newline, but at least Notepad does not break lines correctly if only \n is used. -- ___ Python tracker

[issue3902] Packages containing only extension modules have to contain __init__.py

Mike Hoy added the comment: Responded to first question in apiref and uploaded a new patch that wraps lines at 80 characters. -- Added file: http://bugs.python.org/file23369/apiref-setupscript-v3.diff ___ Python tracker

[issue8087] Unupdated source file in traceback

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue12602] Missing cross-references in Doc/using

Terry J. Reedy added the comment: I was not necessary suggesting that the filename actually be changed, just that the mapping between docs and filenames is not always obvious. I will somedays look at the dev docs doc page and see if I have any further suggestions to help. Add 'in the Python d

[issue13146] Writing a pyc file is not atomic

New submission from Antoine Pitrou : One of the buildbots recently showed the following failure: == ERROR: test_rapid_restart (test.test_multiprocessing.WithProcessesTestManagerRestart) -

[issue12659] Add tests for packaging.tests.support

Francisco Martín Brugué added the comment: The patch is updated. Let me know if I've understood your review. Thanks ! -- Added file: http://bugs.python.org/file23370/issue12659_v3.patch ___ Python tracker

[issue13062] Introspection generator and function closure state

Changes by Ron Adam : -- nosy: +ron_adam ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue13055] Distutils tries to handle null versions but fails

Ben Gamari added the comment: Sorry, no log is available. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue13147] Multiprocessing Pool.map_async() does not have an error_callback parameter

New submission from Jakub Gedeon : Multiprocessing Pool.map_async() does not have an error_callback paramter as described here http://docs.python.org/library/multiprocessing.html#multiprocessing.pool.multiprocessing.Pool.map_async I assume this is an old configuration that no longer works... I

[issue6715] xz compressor support

Amaury Forgeot d'Arc added the comment: *Very* good news for lzma on windows: The precompiled static library liblzma.a works very well with MSVC (tested with VS2008 on Windows XP, 32bit). This was a surprise for me... Here is a patch for the win32 build files, to be applied after Nadeem's. I

[issue12602] Missing cross-references in Doc/using

Nick Coghlan added the comment: Don't feel bad about not recognising the context - this stuff wasn't documented at all for a long time, and it wasn't until Georg pointed me to the usage docs that I realised adding it there would be the right place. I should have remembered that and been less

[issue13148] simple bug in mmap size check

New submission from Maxim Yanchenko : The condition contradicts the exception text: if (offset >= st.st_size) { PyErr_SetString(PyExc_ValueError, "mmap offset is greater than file size"); return NULL; } The co

[issue8065] Memory leak in readline.get_current_history_length

Garrett Cooper added the comment: As a note for future reference, FreeBSD/NetBSD/OpenBSD doesn't use the term "bug", but instead uses the term "problem report" (the NetBSD website says "bug" though BTW). The PR system for NetBSD can be accessed here: http://www.netbsd.org/cgi-bin/sendpr.cgi?

[issue13148] simple bug in mmap size check

Antoine Pitrou added the comment: Well, you have to understand what this code does: it tries to prevent non-meaningful offsets. If the offset is equal to the file size, mapping from that offset would not map anything in the file (and the system call may actually fail). -- nosy: +pitr

[issue13149] optimization for append-only StringIO

New submission from Antoine Pitrou : io.StringIO is quite slower than ''.append() when used for mass concatenation (around 5x slower). This patch brings it to similar performance by deferring construction of the internal buffer until needed. The problem is that it's very easy to disable the op

[issue13148] simple bug in mmap size check

Maxim Yanchenko added the comment: First of all, it doesn't fail (at least on Linux), I tested it before posting. And the latest, it's not like I'm just stalking around and reading Python sources for fun. It's a real and pretty valid case, I hit it while upgrading our production code to pytho

[issue13148] simple bug in mmap size check

Antoine Pitrou added the comment: I don't think it makes sense to accept mmap'ing empty contents when at offset "n" but not at offset "n + 1". Either we remove the check entirely and let people deal with the consequences, or we keep the check as-is. -- nosy: +neologix stage: committed

[issue13148] simple bug in mmap size check

Maxim Yanchenko added the comment: Well, "n+1" is clearly outside the file, wile "n" is within and therefore valid. Also, if your position is to forbid zero-size mmapping completely, then the checks inside "if (map_size == 0) {" don't make any sense, especially as they may or may fail. >From

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

Changes by Ezio Melotti : Removed file: http://bugs.python.org/file23365/issue12753-4.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

Changes by Ezio Melotti : Added file: http://bugs.python.org/file23374/issue12753-4.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue13146] Writing a pyc file is not atomic

Antoine Pitrou added the comment: Here is a patch for import.c. -- keywords: +patch Added file: http://bugs.python.org/file23375/importrename.patch ___ Python tracker ___ __

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

Ezio Melotti added the comment: (I had to re-upload the patch a couple of time to get the review button to work. Apparently if there are some conflicts rietveld fails to apply the patch, whereas hg is able to merge files without problems here. Sorry for the noise.) --

[issue1673007] urllib2 requests history + HEAD support

Changes by Ezio Melotti : -- assignee: ezio.melotti -> orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue13150] Most of Python's startup time is sysconfig

New submission from Antoine Pitrou : sysconfig is imported and used by site.py. $ time ./python -S -c '' real0m0.019s user0m0.013s sys 0m0.005s $ time ./python -S -c 'import sysconfig' real0m0.047s user0m0.046s sys 0m0.002s $ time ./python -S -c 'import sysconfig; sys

[issue13150] Most of Python's startup time is sysconfig

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue1673007] urllib2 requests history + HEAD support

Ezio Melotti added the comment: We have discussed the API a bit on IRC and these are the outcomes: 1) should method always have priority or should 'POST' always be used whenever data is passed? 2) if the method is e.g. 'GET' and data is passed, should an error be raised? 3) should Request.meth

[issue12602] Missing cross-references in Doc/using

Terry J. Reedy added the comment: That was the page I said I would look at. My suggest is that one or more of the directory entries could have either a bit more information about the directory or a "More info" link to a separate page. As a remember, files for modules were named after the modu

[issue1673007] urllib2 requests history + HEAD support

Senthil Kumaran added the comment: Our discussion stemmed from this point. If you look at the change proposed, Request class is taking a new parameter by name 'method' and it is initialized to None: class Request: def __init__(self, url, data=None, headers={}, - origin_

[issue13148] simple bug in mmap size check

Maxim Yanchenko added the comment: tried on newer Linux - crashes with my patch. So I'll be thinking about a workaround, probably a fix for NumPy to avoid using mmap in such cases but still provide uniform interface to avoid making special conditional handling in all my scripts. Therefore, I'm

[issue2945] bdist_rpm does not list dist files (should effect upload)

Carl Robben added the comment: Yeah I installed rpm and have run the tests successfully. -- ___ Python tracker ___ ___ Python-bugs-lis