[issue11610] Improved support for abstract base classes with descriptors

Daniel Urban added the comment: It doesn't work with staticmethod: >>> import abc >>> >>> class C(metaclass=abc.ABCMeta): ... @staticmethod ... @abc.abstractmethod ... def foo(x): ... raise NotImplementedError() ... >>> class D(C): ... @staticmethod ... def foo

[issue11610] Improved support for abstract base classes with descriptors

Darren Dale added the comment: On Sat, Jun 11, 2011 at 3:11 AM, Daniel Urban wrote: > > Daniel Urban added the comment: > > It doesn't work with staticmethod: > import abc class C(metaclass=abc.ABCMeta): > ...     @staticmethod > ...     @abc.abstractmethod > ...     def foo(x):

[issue12310] Segfault in test_multiprocessing

Charles-François Natali added the comment: I think it might be related to Issue #6721. Using a mutex/condition variable after fork (from the child process) is unsafe: it can lead to deadlocks, and on OS-X, it seems like it can lead to segfaults. Normally, Queue's synchronization primitives ar

[issue11553] Docs for: import, packages, site.py, .pth files

Graham Wideman added the comment: Hi Eric, Thanks for starting to review this, and your responses are encouraging. Some comments inline below. FWIW, along the way I accumulated my own notes on this topic, on some pages here: grahamwideman.wikispaces.com (Left navigation panel...) Software d

[issue11610] Improved support for abstract base classes with descriptors

Darren Dale added the comment: [...] >> Traceback (most recent call last): >>  File "", line 1, in >> TypeError: Can't instantiate abstract class D with abstract methods >> foo.__func__ > > You still need to use @abc.abstractstaticmethod. Thinking about this some more, I think the error you f

[issue11553] Docs for: import, packages, site.py, .pth files

Nick Coghlan added the comment: Thanks for getting started with such a detailed review on this Graham. We've known the documentation in this area has been flawed for a long time, but actually *fixing* seemed like such a big task that it has tended to get pushed to the bottom of our respective

[issue11610] Improved support for abstract base classes with descriptors

Nick Coghlan added the comment: inspect.getattr_static has the necessary logic to search for descriptors without invoking them. However, it may be better to revert to the idea of pushing this functionality back onto the individual descriptors and have the problematic descriptors like propert

[issue11610] Improved support for abstract base classes with descriptors

Darren Dale added the comment: On Sat, Jun 11, 2011 at 8:55 AM, Nick Coghlan wrote: > > Nick Coghlan added the comment: > > inspect.getattr_static has the necessary logic to search for descriptors > without invoking them. Unfortunately, we can't import inspect, even inside ABCMeta.__new__.

[issue11553] Docs for: import, packages, site.py, .pth files

Changes by Greg Słodkowicz : -- nosy: +Greg.Slodkowicz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3

Vinay Sajip added the comment: Patch is now in my public sandbox on hg.python.org. -- hgrepos: +26 ___ Python tracker ___ ___ Python-

[issue11553] Docs for: import, packages, site.py, .pth files

Graham Wideman added the comment: Hi Nick: Thanks for your additional points. Comments inline: > __all__ only affects import *, and may also affect documentation tools (e.g. > pydoc will respect __all__ when deciding what to display). It has no effect > on attribute retrieval from modules. T

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3

Vinay Sajip added the comment: For some reason, "Create Patch" is failing with a [Errno 2] No such file or directory: '/home/roundup/trackers/tracker/cpython/Doc/Makefile' I've logged an issue on the meta tracker: http://psf.upfronthosting.co.za/roundup/meta/issue405 -- ___

[issue12310] Segfault in test_multiprocessing

Antoine Pitrou added the comment: Less disruptive approach: old_process = _current_process _current_process = self try: util._finalizer_registry.clear() util._run_after_forkers() finally: del old_process This will delay finali

[issue10115] Support accept4() for atomic setting of flags at socket creation

Charles-François Natali added the comment: No one seems to object, and since this approach has been suggested by Martin and is consistent with the posix module's policy (i.e. a thin wrapper around the underlying syscall), I guess you can go ahead. -- __

[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

Charles-François Natali added the comment: For oss_check_closed.diff, should I apply it to default only or to every branch? -- ___ Python tracker ___ ___

[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

Antoine Pitrou added the comment: > For oss_check_closed.diff, should I apply it to default only or to > every branch? Only default I'd say. -- ___ Python tracker ___ _

[issue10897] UNIX mmap unnecessarily dup() file descriptor

Charles-François Natali added the comment: > Perhaps by adding some new argument to the mmap constructor? (dup_fd = True) I don't really like the idea of exposing the FD duplication to the user, because: - it's an implementation detail - it doesn't reflect any argument of the POSIX mmap version

[issue12315] Improve http.client.HTTPResponse.read documentation

Changes by Antoine Pitrou : -- nosy: +orsenthil stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue12310] Segfault in test_multiprocessing

Charles-François Natali added the comment: Yes, I also tried this. This fixed the test_multiprocessing failure, but I think it triggered a failure in test_concurrent_futures (didin't look in more detail). Would it be possible to try this on the buildbot to see if it fixes the segfaults? -

[issue11610] Improved support for abstract base classes with descriptors

Darren Dale added the comment: [...] > > This wouldn't allow for the prettier error messages, but it's much cleaner > than having ABCMeta trawling through class attribute dir() lists. I think there is another reason to do it this way. Suppose I have a custom descriptor MyProperty that stores i

[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

Roundup Robot added the comment: New changeset d0952a2fb7bd by Charles-François Natali in branch 'default': Issue #12287: In ossaudiodev, check that the device isn't closed in several http://hg.python.org/cpython/rev/d0952a2fb7bd -- nosy: +python-dev ___

[issue9098] MSYS build fails with `S_IXGRP' undeclared

Yuri added the comment: I fixed all build problems on the current MinGW32. python.exe builds ok, but build fails since python.exe can't find some modules after this. Not sure why. -- keywords: +patch nosy: +yurivict Added file: http://bugs.python.org/file22329/python-3.2.patch ___

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

Roundup Robot added the comment: New changeset 303e3693d634 by Éric Araujo in branch 'default': Move useful function to packaging.util. http://hg.python.org/cpython/rev/303e3693d634 New changeset 06670bd0e59e by Éric Araujo in branch 'default': Fix assorted bugs in packaging.util.cfg_to_args (#

[issue11599] Useless error message when distutils fails compiling

Roundup Robot added the comment: New changeset 3ba34c03f2fc by Éric Araujo in branch 'default': Adjust logging in packaging.util.spawn (related to #11599) http://hg.python.org/cpython/rev/3ba34c03f2fc -- nosy: +python-dev ___ Python tracker

[issue12240] Allow multiple setup_hooks

Roundup Robot added the comment: New changeset 5f0cd4844061 by Éric Araujo in branch 'default': Allow multiple setup hooks in packaging’s setup.cfg files (#12240). http://hg.python.org/cpython/rev/5f0cd4844061 -- nosy: +python-dev ___ Python tracker

[issue12313] make install misses packaging module

Éric Araujo added the comment: > Also you may want to add some of the packaging test directories to > those excluded in the calls to compileall.py a little further down in > the libinstall target. Ah, good one. I guess doing this could have prevented http://hg.python.org/cpython/rev/9041520be

[issue828450] sdist generates bad MANIFEST on Windows

Éric Araujo added the comment: > I just recreated this patch against version 2.7, so I'm not sure it > can be applied to all the listed versions. It’s okay, distutils in 2.7 and 3.x is very similar, I can port. > Note: there still are two pathes, one for sdist.py and another for > test_sdist.py

[issue11595] Miscellaneous bugs in cfg_to_args() utility function

Éric Araujo added the comment: Thanks again! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue11599] Useless error message when distutils fails compiling

Éric Araujo added the comment: I intend to ask on distutils-sig whether doing the change in distutils would break code. -- assignee: tarek -> eric.araujo ___ Python tracker ___

[issue12279] Add build_distinfo command to packaging

Éric Araujo added the comment: I forgot one thing: setuptools’ egg_info command does write a list of paths, so we can look at how it solved the problem with the RECORD and RESOURCES files. Higery: Michael is willing to work with you on this bug. -- ___

[issue12240] Allow multiple setup_hooks

Éric Araujo added the comment: Done. -- assignee: tarek -> eric.araujo resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

Éric Araujo added the comment: > Hmm, in http://bugs.python.org/issue7511#msg106420 Tarek appeared to > be supportive of the patch. I believe Martin has more knowledge about Windows. -- ___ Python tracker

[issue12317] inspect.getabsfile() is not documented

Changes by Giampaolo Rodola' : -- assignee: giampaolo.rodola nosy: giampaolo.rodola priority: normal severity: normal status: open title: inspect.getabsfile() is not documented versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3 ___ P

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

John Edmonds added the comment: Here is the patch, re-written for the packaging module. -- Added file: http://bugs.python.org/file22330/patch.diff ___ Python tracker ___ ___

[issue9284] inspect.findsource() cannot find source for doctest code

Roundup Robot added the comment: New changeset 527c40add91d by Benjamin Peterson in branch '2.7': allow "fake" filenames in findsource (closes #9284) http://hg.python.org/cpython/rev/527c40add91d New changeset 6cc4579dca02 by Benjamin Peterson in branch '3.2': allow "fake" filenames in findsour

[issue12206] Documentation Std. Library 15.7.5 "LogRecord objects": Parameters: level(currently wrong) -> levelno (correct)

Vinay Sajip added the comment: Attached is a simple patch clarifying that the level argument in the constructor maps to the two LogRecord attributes, levelno and levelname, -- keywords: +patch Added file: http://bugs.python.org/file22331/patch12206.diff ___

[issue12318] list + tuple inconsistency

New submission from Filip Gruszczyński : You can do this: >>> [1] + (1,) Traceback (most recent call last): File "", line 1, in TypeError: can only concatenate list (not "tuple") to list But you can do this: >>> result = [1] >>> result += (1,) >>> result [1, 1] Is it the expected behaviour

[issue12318] list + tuple inconsistency

Filip Gruszczyński added the comment: Obviously first sentence should be "You can't do this:". -- ___ Python tracker ___ ___ Python-b

[issue12206] Documentation Std. Library 15.7.5 "LogRecord objects": Parameters: level(currently wrong) -> levelno (correct)

Roundup Robot added the comment: New changeset bb6fe43191c0 by Vinay Sajip in branch '3.2': Issue #12206: documentation for LogRecord constructor updated re. the level argument. http://hg.python.org/cpython/rev/bb6fe43191c0 New changeset 596adf14914c by Vinay Sajip in branch 'default': Merged

[issue12206] Documentation Std. Library 15.7.5 "LogRecord objects": Parameters: level(currently wrong) -> levelno (correct)

Changes by Vinay Sajip : -- assignee: docs@python -> vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12318] list + tuple inconsistency

Raymond Hettinger added the comment: Yes, this is the expected behavior and yes, it is inconsistent. It's been that way for a long while and Guido said he wouldn't do it again (it's in his list of regrets). However, we're not going to break code by changing it (list.__iadd__ working like lis

[issue11610] Improved support for abstract base classes with descriptors

Eric Snow added the comment: Perhaps rather than changing ABCMeta, provide a base descriptor class that has __isabstractmethod__ implemented to calculate the abstractness. Then property could use that, as could any of the other relevant descriptors we have around. The __isabstractmethod__ a

[issue12310] Segfault in test_multiprocessing

STINNER Victor added the comment: > Would it be possible to try this on the buildbot to see if it fixes > the segfaults? You can fork cpython, modify the code, and run a custom buildbot on your clone. -- ___ Python tracker

[issue11553] Docs for: import, packages, site.py, .pth files

Nick Coghlan added the comment: "Public name" is a term that describes a convention, not anything enforced by the interpreter. Names starting with underscores typically aren't public either (unless documented otherwise), but that has no effect on the ability to retrieve them as attributes. A

[issue11610] Improved support for abstract base classes with descriptors

Nick Coghlan added the comment: Remember the goal here is *not* to completely eliminate the need to test that objects implement an ABC correctly. It's to make it easier to declare the expected interface in a way that helps readers of the ABC definition to figure out what is going on, and to r

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

Changes by Mark Mc Mahon : -- keywords: +patch Added file: http://bugs.python.org/file22332/support_vt_empty_in_summary_getproperty.patch ___ Python tracker ___

[issue11553] Docs for: import, packages, site.py, .pth files

Graham Wideman added the comment: > "Public name" is a term that describes a convention, not anything enforced by > the interpreter. And I guess that's really the main point. In other languages Public means accessible, and Private means not so. In Python, Public means "suggested for outsid

[issue828450] sdist generates bad MANIFEST on Windows

higery added the comment: OK. I recreated a full version patch. I'll remove old patches. -- Added file: http://bugs.python.org/file22333/change_path_separator_fullversion.patch ___ Python tracker ___

[issue828450] sdist generates bad MANIFEST on Windows

Changes by higery : Removed file: http://bugs.python.org/file21713/change_path_separator_in_MANIFEST.patch ___ Python tracker ___ ___ Python

[issue828450] sdist generates bad MANIFEST on Windows

Changes by higery : Removed file: http://bugs.python.org/file22328/test_manifest_reading_sdist.diff ___ Python tracker ___ ___ Python-bugs-li

[issue11610] Improved support for abstract base classes with descriptors

Eric Snow added the comment: Didn't mean to sidetrack. :) I really appreciate the effort Darren has put into this. -- ___ Python tracker ___ _

[issue12279] Add build_distinfo command to packaging

higery added the comment: > Higery: Michael is willing to work with you on this bug. > OK. :) -- Added file: http://bugs.python.org/file22334/unnamed ___ Python tracker ___ Hi

[issue12279] Add build_distinfo command to packaging

Changes by higery : Removed file: http://bugs.python.org/file22334/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue9035] os.path.ismount on windows doesn't support windows mount points

Mark Mc Mahon added the comment: I was looking at this - and see that (at least as far as GetFileAttributes is concerned) that a mount and a linked directory are seen the same... Here are some tests using ctypes # mounted drive >>> hex(windll.kernel32.GetFileAttributesW(ur"c:\temp\test_c_moun

[issue9035] os.path.ismount on windows doesn't support windows mount points

Changes by Brian Curtin : -- nosy: +brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt