[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

2011-06-10 Thread STINNER Victor
STINNER Victor added the comment: Comments on is_selectable.diff. > +#define IS_SELECTABLE(s) (_PyIsSelectable_fd((s)->sock_fd) || > s->sock_timeout <= 0.0) You may add parenthesis around the second s (even if it's unrelated to this issue and not a regression of your patch). > +#ifdef Py_SO

[issue12316] test_signal: test_sigwait_thread failure on FreeBSD 6.4 buildbot

2011-06-10 Thread Charles-François Natali
New submission from Charles-François Natali : http://www.python.org/dev/buildbot/all/builders/x86 FreeBSD 6.4 3.x/builds/1570/steps/test/logs/stdio """ [ 29/356] test_signal Fatal error 'mutex is on list' at line 540 in file /usr/src/lib/libpthread/thread/thr_mutex.c (errno = 22) test test_sig

[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

2011-06-10 Thread Charles-François Natali
Charles-François Natali added the comment: > In oss_check_closed.diff, you might want to add tests for the other > methods as well. I've added checks for other methods (not all of them, there are quite a few). I've also added a check for the mixer object. > You may add parenthesis around the

[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

2011-06-10 Thread Charles-François Natali
Changes by Charles-François Natali : Added file: http://bugs.python.org/file22327/oss_check_closed.diff ___ Python tracker ___ ___ Python-bugs

[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

2011-06-10 Thread Charles-François Natali
Changes by Charles-François Natali : Removed file: http://bugs.python.org/file22324/is_selectable.diff ___ Python tracker ___ ___ Python-bugs-

[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE

2011-06-10 Thread Charles-François Natali
Changes by Charles-François Natali : Removed file: http://bugs.python.org/file22325/oss_check_closed.diff ___ Python tracker ___ ___ Python-bu

[issue12313] make install misses packaging module

2011-06-10 Thread Ned Deily
Ned Deily added the comment: Listing all those directories to the Makefile does seem very brittle and will certainly be a maintenance hassle. OTOH, there is something to be said for being explicit about what gets installed. I suppose you could add the find step to ./configure and pass the l

[issue12316] test_signal: test_sigwait_thread failure on FreeBSD 6.4 buildbot

2011-06-10 Thread STINNER Victor
STINNER Victor added the comment: > In a multi-threaded program, we're only allowed to call async-safe > functions between fork() and exec() in the child process Oh, I don't know that. The test should be modified to create a new clean Python process using subprocess to run the test. -

[issue11898] Sending binary data with a POST request in httplib can cause Unicode exceptions

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: should *not* be reopened. Sorry for omission of 'not'. -- ___ Python tracker ___ ___ Python-bugs-li

[issue12188] PEP 7 (or guide) add C style policies and explanation

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: We have a second item for the PEP (or Guide) section (but I think I prefer in the PEP so as to have one place to look for such things.). So I changed the title a bit. On 6/10/2011 3:49 PM, Guido van Rossum wrote: > On Wed, Jun 8, 2011 at 8:12 AM, Nick Coghlan

[issue12260] Make install default to user site-packages

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: In my Winxp machine, I can add and delete directories in python32/Lib/site-packages (all-users installation) from my user account. That is what I expect and want the default to be, not the Terry/whatever that I have never used (or the admin/whatever if I happ

[issue12261] urllib.parse docs still refer to urlparse

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe this is ready to apply. -- nosy: +terry.reedy stage: -> commit review versions: +Python 3.3 ___ Python tracker ___ _

[issue12272] Python 2.7.1 version conflict for package "Tcl" on Windows 7

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Martin, any ideas? Jack, I would wipe out the tcl directory and rerun the 2.7.1 installer, selecting just the tk/tcl/idle option. I have trouble believe that every 2.7.1 install on win7 is bad. -- nosy: +loewis, terry.reedy _

[issue12276] 3.x ignores sys.tracebacklimit=0

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Either code or doc must change (with 'version changed' note). Doc: "The default is 1000. When set to 0 or less, all traceback information is suppressed and only the exception type and value are printed." Christian's patch: "values <= 0 are replaced with a def

[issue12299] Stop documenting functions added by site as builtins

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: In the 3.2.0 doc, quit and exit (which are unnecessary and nearly useless) are already in the site-variables section (where I think they should be), not in builtin funcs. Did someone move them since? If so, you should discuss rather than just revert. The ex

[issue12300] Document pydoc.help

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is already a link to the main entry, which is where I think it should be. -- nosy: +terry.reedy ___ Python tracker ___ __

[issue828450] sdist generates bad MANIFEST on Windows

2011-06-10 Thread higery
Changes by higery : Removed file: http://bugs.python.org/file21725/test_manifest_reading_sdist.diff ___ Python tracker ___ ___ Python-bugs-li

[issue828450] sdist generates bad MANIFEST on Windows

2011-06-10 Thread higery
Changes by higery : Removed file: http://bugs.python.org/file21764/test_manifest_reading_sdist_v2.diff ___ Python tracker ___ ___ Python-bug

[issue12301] Use :data:`sys.thing` instead of ``sys.thing`` throughout

2011-06-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Links are good ;-). -- nosy: +terry.reedy stage: -> needs patch ___ Python tracker ___ ___ Python-

[issue828450] sdist generates bad MANIFEST on Windows

2011-06-10 Thread higery
higery added the comment: I just recreated this patch against version 2.7, so I'm not sure it can be applied to all the listed versions. Note: there still are two pathes, one for sdist.py and another for test_sdist.py -- Added file: http://bugs.python.org/file22328/test_manifest_readi

<    1   2