[issue6727] ImportError when package is symlinked on Windows

Waldemar Kornewald added the comment: I've tracked it down. It's caused by KB2467174 (http://support.microsoft.com/kb/2467174) and I can reliably reproduce it. Here's how to reproduce it: Install *only* the "Microsoft Visual C++ 2008 Redistributable Package (x86)" from http://www.microsoft.

[issue12039] test_logging: bad file descriptor on FreeBSD bot

Senthil Kumaran added the comment: Hi Vinay, Normally, when one uses send_response() call, it is most often followed with (multiple) send_header() calls and I updated the documentation keeping that in mind. Just calling of send_response() without any send_header and end_headers was an interes

[issue12039] test_logging: bad file descriptor on FreeBSD bot

Roundup Robot added the comment: New changeset 4651bf40af8d by Senthil Kumaran in branch 'default': issue12039 - update the documentation of send_response method in http.server.rst. http://hg.python.org/cpython/rev/4651bf40af8d -- ___ Python tracker

[issue9971] Optimize BufferedReader.readinto

STINNER Victor added the comment: Le mardi 10 mai 2011 à 19:06 +, John O'Connor a écrit : > Victor: AFAIK its not actually downcasting. On Linux 32 bits, size_t is 32 bits, off_t is 64 bits. If the file size is 4 GB, the downcast may truncate the size of 0 byte. It would be safer to use off

[issue12044] subprocess.Popen.__exit__ doesn't wait for process end

Gregory P. Smith added the comment: I didn't initially like the idea of __exit__ blocking on another process... but the zombie issue is real does make me think we should reconsider this and have it wait(). It is a backwards incompatible change if anyone has started using the Popen context manag

[issue6727] ImportError when package is symlinked on Windows

Waldemar Kornewald added the comment: That's really strange. We uninstalled Service Pack 1 from my friend's machine and now everything works. What I don't understand is why I don't have Service Pack 1 on my machine and why Windows Update also doesn't offer to install it. Does it have to be in

[issue12016] Wrong behavior for '\xff\n'.decode('gb2312', 'ignore')

STINNER Victor added the comment: I asked if the change is correct on iconv mail list. Here is a copy of an answer. De: Bruno Haible À: [iconv mailing list] Cc: Victor Stinner Sujet: Re: [bug-gnu-libiconv] Invalid byte sequences and multiybyte encodings Date: Tue, 10 May 2011 1

[issue9971] Optimize BufferedReader.readinto

Antoine Pitrou added the comment: > On Linux 32 bits, size_t is 32 bits, off_t is 64 bits. If the file size > is 4 GB, the downcast may truncate the size of 0 byte. We are not talking about the file size here. -- ___ Python tracker

[issue12016] Wrong behavior for '\xff\n'.decode('gb2312', 'ignore')

STINNER Victor added the comment: Oh, the HZ codec has no test! And what is this horrible BLOB, Lib/test/cjkencodings_test.py? -- ___ Python tracker ___ ___

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

Changes by Sijin Joseph : -- nosy: +sijinjoseph ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue12034] check_GetFinalPathNameByHandle() suboptimal

Changes by Sijin Joseph : -- nosy: +sijinjoseph ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue11882] test_imaplib failed on x86 ubuntu

Changes by Sijin Joseph : -- nosy: +sijinjoseph ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue12045] external shell command executed twice in ctypes.util._get_soname

Changes by Sijin Joseph : -- nosy: +sijinjoseph ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue12055] doctest not working on nested functions

New submission from Dave Abrahams : The attached file demonstrates -- components: Library (Lib) files: bug.py messages: 135770 nosy: dabrahams priority: normal severity: normal status: open title: doctest not working on nested functions versions: Python 2.6, Python 2.7 Added file: http:/

[issue12039] test_logging: bad file descriptor on FreeBSD bot

Changes by Vinay Sajip : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue12056] "…" (HORIZONTAL ELLIPSIS) should be an alternative syntax for "..." (FULL STOP FULL STOP FULL STOP)

New submission from Xavier Morel : In Python 3, "..." became useable as a normal expression, and translates into an ellipsis instance. Unicode defines an ellipsis character "…" (U+2026 HORIZONTAL ELLIPSIS) which is canonically equivalent to a 3-sequence of FULL STOP [U+002E U+002E U+002E] I t

[issue12056] "…" (HORIZONTAL ELLIPSIS) should be an alternative syntax for "..." (FULL STOP FULL STOP FULL STOP)

Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue2857] add codec for java modified utf-8

STINNER Victor added the comment: utf_8_java.patch: Implement "utf-8-java" encoding. * It has no alias * 'a\0b'.encode('utf-8-java') returns b'a\xc0\x80b' * b'a\xc0\x80b'.decode('utf-8-java') returns 'a\x00b' * I added some tests to utf-8 codec (test_invalid, test_null_byte) * I added many

[issue12057] HZ codec has no test

New submission from STINNER Victor : All CJK codecs have tests except the chinese HZ codec, I don't know why. But to add a test, I need to add data to Lib/test/cjkencodings_test.py and the format of this file is not documented. It is not too difficult to understand the format by reading the co

[issue11799] urllib HTTP authentication behavior with unrecognized auth method

Roundup Robot added the comment: New changeset 6072db001b51 by Senthil Kumaran in branch 'default': Fix closes Issue #11799: urllib.request Authentication Handlers will raise a http://hg.python.org/cpython/rev/6072db001b51 -- nosy: +python-dev ___ Py

[issue12057] HZ codec has no test

Changes by STINNER Victor : Added file: http://bugs.python.org/file21966/convert_cjkencodings.py ___ Python tracker ___ ___ Python-bugs-list m

[issue12057] HZ codec has no test

Changes by STINNER Victor : -- keywords: +patch Added file: http://bugs.python.org/file21967/cjkencodings.patch ___ Python tracker ___ ___

[issue11799] urllib HTTP authentication behavior with unrecognized auth method

Changes by Senthil Kumaran : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue12057] HZ codec has no test

Changes by STINNER Victor : Removed file: http://bugs.python.org/file21967/cjkencodings.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue12057] HZ codec has no test

Changes by STINNER Victor : Added file: http://bugs.python.org/file21968/cjkencodings.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12057] HZ codec has no test

STINNER Victor added the comment: convert_cjkencodings.py is script to replace Lib/test/cjkencodings_test.py by a Lib/test/cjkencodings/ directory: --- big5hkscs.txt big5hkscs-utf8.txt big5.txt big5-utf8.txt cp949.txt cp949-utf8.txt euc_jisx0213.txt euc_jisx0213-utf8.txt euc_jp.txt euc_jp-utf8.

[issue2857] add codec for java modified utf-8

Marc-Andre Lemburg added the comment: Thanks for the patch, Victor. Some comments on the patch: * the codec will have to be able to work with lone surrogates (see the wikipedia page explaining this detail), which the UTF-8 codec in Python 3.x no longer does, so another special case i

[issue12057] HZ codec has no test

Changes by STINNER Victor : -- dependencies: +HZ codec has no test ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue12057] HZ codec has no test

Changes by STINNER Victor : -- dependencies: -HZ codec has no test ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue12016] Wrong behavior for '\xff\n'.decode('gb2312', 'ignore')

Changes by STINNER Victor : -- dependencies: +HZ codec has no test ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue12057] HZ codec has no test

STINNER Victor added the comment: New files should be marked as binary in Mercurial: add "Lib/test/cjkencodings/* = BIN" in .hgeol. -- ___ Python tracker ___ __

[issue12056] "…" (HORIZONTAL ELLIPSIS) should be an alternative syntax for "..." (FULL STOP FULL STOP FULL STOP)

Brandon Craig Rhodes added the comment: But if we allow for ellipsis, then would we not also have to start allowing characters like ≥ and ≤ in Python? And the problem with any of these (admittedly very attractive) substitutions is that they seem to abandon the principle of there being One Obv

[issue12056] "…" (HORIZONTAL ELLIPSIS) should be an alternative syntax for "..." (FULL STOP FULL STOP FULL STOP)

Benjamin Peterson added the comment: Making such substitutions is a good way to introduce subtle bugs. -- nosy: +benjamin.peterson resolution: -> rejected status: open -> closed ___ Python tracker ___

[issue11968] wsgiref's wsgi application sample code does not work

Roundup Robot added the comment: New changeset e7c62e0981c7 by Senthil Kumaran in branch 'default': Fix closed Issue #11968 - the start_response header values in wsgiref shoudl be http://hg.python.org/cpython/rev/e7c62e0981c7 -- nosy: +python-dev ___

[issue11968] wsgiref's wsgi application sample code does not work

Changes by Senthil Kumaran : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue11968] wsgiref's wsgi application sample code does not work

Roundup Robot added the comment: New changeset 5add0c01933f by Senthil Kumaran in branch '3.2': Issue #11968 - the start_response header values in wsgiref shoudl be str not http://hg.python.org/cpython/rev/5add0c01933f New changeset 482f60d6a687 by Senthil Kumaran in branch 'default': [Merge Br

[issue12014] str.format parses replacement field incorrectly

Changes by Éric Araujo : -- keywords: +needs review stage: -> patch review versions: -Python 2.6, Python 3.4 ___ Python tracker ___

[issue12013] file /usr/local/lib/python3.1/lib-dynload/_socket.so: symbol inet_aton: referenced symbol not found

Éric Araujo added the comment: Is the original bug still present in your new install? -- ___ Python tracker ___ ___ Python-bugs-list

[issue12044] subprocess.Popen.__exit__ doesn't wait for process end

Charles-François Natali added the comment: I'm re-opening this issue, since Gregory agrees to change the current behaviour. Patch attached (along with test and documentation update). -- components: +Library (Lib) keywords: +patch resolution: rejected -> status: closed -> open Added fil

[issue12058] Minor edits to comments in faulthandler

New submission from Éric Araujo : I fixed or improved some comments in faulthandler. The only non-trivial change is a replacement of “until” to “before” (until did not make sense). Please review and if you agree, commit. -- files: faulthandler-comments.diff keywords: patch messages:

[issue12057] HZ codec has no test

Terry J. Reedy added the comment: Looking at cjkencodings.py the format is pretty clear. The file consists of one statement that creates one dict that maps encoding names to a pair of (encoded) byte strings. The bytes literals are entirely hex escapes, with a maximum of 16 per chunk (line). F

[issue10419] distutils command build_scripts fails with UnicodeDecodeError

Arfrever Frehtes Taifersar Arahesis added the comment: I have committed the fix for Distribute: https://bitbucket.org/tarek/distribute/changeset/97f12f8f6bf1 (However Distribute would fail to create entry points scripts if sys.executable contained unencodable characters.) --

[issue12057] HZ codec has no test

Marc-Andre Lemburg added the comment: Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > Looking at cjkencodings.py the format is pretty clear. The file consists of > one statement that creates one dict that maps encoding names to a pair of > (encoded) byte strings. The bytes l

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

Roundup Robot added the comment: New changeset 82cfbe2ddfbb by Kurt B. Kaiser in branch '3.1': Issue #1028: Tk returns invalid Unicode null in %A: UnicodeDecodeError. http://hg.python.org/cpython/rev/82cfbe2ddfbb -- nosy: +python-dev ___ Python track

[issue12057] HZ codec has no test

STINNER Victor added the comment: > Looking at cjkencodings.py the format is pretty clear. The file > consists of one statement that creates one dict that maps encoding > names to a pair of (encoded) byte strings. The bytes literals are > entirely hex escapes, with a maximum of 16 per chunk (lin

[issue12057] HZ codec has no test

STINNER Victor added the comment: Le mercredi 11 mai 2011 à 17:27 +, Marc-Andre Lemburg a écrit : > Victor, could you please contact Hye-Shik Chang > before making significant changes to the test suite. Good idea, done. > Wouldn't it be better to just use example strings from the RFC and

[issue11935] MMDF/MBOX mailbox need utime

Steffen Daode Nurpmeso added the comment: For the record: On Mac OS X 10.6.7, ,HFS, case sensitive` updates st_atime by itself *once only*. It does so ~0.75 seconds after os.utime() (+) was called. A time.sleep(0.8) can be used to detect this automatic update reliably (about 50 tests with chan

[issue12057] HZ codec has no test

STINNER Victor added the comment: Lib/test/cjkencodings_test.py was created when CJK were introduced in Python: changeset 31386 by Hye-Shik Chang . "Add CJK codecs support as discussed on python-dev. (SF #873597) Several style fixes are suggested by Martin v. Loewis and Marc-Andre Lemburg. Th

[issue12058] Minor edits to comments in faulthandler

Roundup Robot added the comment: New changeset 5f407b5479f5 by Victor Stinner in branch 'default': Issue #12058: Minor edits to comments in faulthandler http://hg.python.org/cpython/rev/5f407b5479f5 -- nosy: +python-dev ___ Python tracker

[issue12059] hashlib does not handle missing hash functions correctly

New submission from Ian Wienand : If one of the hash functions isn't defined in _hashlib, the code suggests it should just be skipped === # this one has no builtin implementation, don't define it pass === This doesn't happen however; due to ImportError not being caught th

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

STINNER Victor added the comment: I'm working on #2857 which adds the "Modified UTF-8" ("utf-8-java"?) codec to Python. We can maybe use it instead of raising an error in 3.3? -- nosy: +haypo ___ Python tracker __

[issue2857] add codec for java modified utf-8

STINNER Victor added the comment: See also issue #1028. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue12057] HZ codec has no test

Changes by STINNER Victor : -- nosy: +hyeshik.chang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue12016] Wrong behavior for '\xff\n'.decode('gb2312', 'ignore')

Changes by STINNER Victor : -- nosy: +hyeshik.chang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue12050] unconsumed_tail of zlib.Decompress is not always cleared on decompress() call

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue2857] add codec for java modified utf-8

STINNER Victor added the comment: Benchmark: a) ./python -m timeit "(b'\xc3\xa9' * 1).decode('utf-8')" b)./python -m timeit "(''.join( map(chr, range(0, 128)) )*1000).encode('utf-8')" c) ./python -m timeit "f=open('Misc/ACKS', encoding='utf-8'); acks=f.read(); f.close()" "acks.encode('utf-8

[issue11948] Tutorial/Modules - small fix to better clarify the modules search path

Sandro Tosi added the comment: I first would like to apologize if my comments were interpreted like I'd like to do a poor quality job, that's actually the opposite! I just get caught by surprise how a simple change in a word to better join two paragraphs grows up like this - but that's perfec

[issue12013] file /usr/local/lib/python3.1/lib-dynload/_socket.so: symbol inet_aton: referenced symbol not found

Alex Lai added the comment: I haven't get time to upgarde my workstation yet. I don't know when I'm going to do it. I compile the software successfully on the other server. and that's enough for me. Thanks, Alex -- ___ Python tracker

[issue11888] Add C99's log2() function to the math library

STINNER Victor added the comment: > I wait for the following build to close this issue. > http://www.python.org/dev/buildbot/all/builders/x86%20Tiger%203.x/builds/2507 Oh, it's the wrong build. The correct build is: http://www.python.org/dev/buildbot/all/builders/x86%20Tiger%203.x/builds/2508

[issue12044] subprocess.Popen.__exit__ doesn't wait for process end

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12057] HZ codec has no test

Terry J. Reedy added the comment: Reading http://tools.ietf.org/html/rfc1843 suggests that the reason that there is no HZ pair in cjkencodings.py is that it is not a cjkencoding. Instead it is a formatter or meta-encoding for intermixing ascii codes and GB2312(-80) codes. (I assume the '-80'

[issue12057] HZ codec has no test

Terry J. Reedy added the comment: Reading http://tools.ietf.org/html/rfc1843 suggests that the reason that there is no HZ pair in cjkencodings.py is that it is not a cjkencoding. Instead it is a formatter or meta-encoding for intermixing ascii codes and GB2312(-80) codes. (I assume the '-80'

[issue12057] HZ codec has no test

Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg135802 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue11877] Change os.fsync() to support physical backing store syncs

Steffen Daode Nurpmeso added the comment: Ouch, ouch, ouch!! I'll have to send 11877.7.diff which extends 11877.6.diff. This is necessary because using fcntl(2) with F_FULLFSYNC may fail with ENOTTY (inapprobiate ioctl for device) in situations where a normal fsync(2) succeeds (e.g. STDOUT_FILEN

[issue12049] expose RAND_bytes() function of OpenSSL

STINNER Victor added the comment: ssl_rand.patch adds RAND_bytes() and RAND_pseudo_bytes() functions to the ssl module. I moved /dev/urandom to /dev/urandom.xxx and /dev/random to /dev/random.xxx to test RAND_bytes() error path. In this case, RAND_pseudo_bytes() generates non-cryptographic p

[issue11877] Change os.fsync() to support physical backing store syncs

Changes by Steffen Daode Nurpmeso : Removed file: http://bugs.python.org/file21924/11877.5.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue11877] Change os.fsync() to support physical backing store syncs

Changes by Steffen Daode Nurpmeso : Removed file: http://bugs.python.org/file21953/11877.6.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue9971] Optimize BufferedReader.readinto

John O'Connor added the comment: I've attached the latest changes based on feedback (issue9971-v5.patch) for i in 1 4 128 256 1024 2048 4069 8192 16384; do echo -n "buffer_size=$i "; ./python -m timeit -s "f=open('LICENSE','rb');b=bytearray($i)" "f.seek(0)" "while f.readinto(b): pass"; done

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

Kurt B. Kaiser added the comment: r70039 3.1 forward ported > 3.2 > default. Will be in 3.2.1. -- resolution: accepted -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

Kurt B. Kaiser added the comment: Having a modified utf-8 codec will be useful. That said, it is an error for Tcl/Tk to expose modified utf-8 externally, and that was fixed at some point in Tk8.5. Since Tk is no longer sending 0xC080 for the %A char, switching codecs in _tkinter.c won't accomp

[issue12060] Python doesn't support real time signals

New submission from STINNER Victor : If a real time signal is raised 2 times whereas the signal is blocked, unblock the signal will call the signal handler twice. The C signal handler of the Python signal module only stores a boolean to say if the Python signal handler should be called or not

[issue12060] Python doesn't support real time signals

STINNER Victor added the comment: example.py: example to demonstrate the problem. The Python signal handler is only called once, it should be called twice. -- Added file: http://bugs.python.org/file21977/example.py ___ Python tracker

[issue12060] Python doesn't support real time signals

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue12061] Remove duplicate 'key functions' entry in Glossary

New submission from Sandro Tosi : Hi, only on 2.7 there were 2 entries for 'key function': this patches remove the second occurrence, leaving that part of Glossary equals to the other branches. -- assignee: docs@python components: Documentation files: remove_duplicate_key_functions-2.7

[issue9971] Optimize BufferedReader.readinto

Roundup Robot added the comment: New changeset a1d77c6f4ec1 by Antoine Pitrou in branch 'default': Issue #9971: Write an optimized implementation of BufferedReader.readinto(). http://hg.python.org/cpython/rev/a1d77c6f4ec1 -- nosy: +python-dev ___ Pyt

[issue9971] Optimize BufferedReader.readinto

Antoine Pitrou added the comment: I've committed a minimally modified version of the patch, thank you! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue12057] HZ codec has no test

Hyeshik Chang added the comment: Hello, everyone! The rationale why I chose to encode the test strings into a Python source code was that I wanted for them to be treated as text files which are trackable in CVS or subversion and to keep Python source codes free of any non-ASCII characters. N

[issue12044] subprocess.Popen.__exit__ doesn't wait for process end

Roundup Robot added the comment: New changeset 7a3f3ad83676 by Gregory P. Smith in branch 'default': - Issue #12044: Fixed subprocess.Popen when used as a context manager to http://hg.python.org/cpython/rev/7a3f3ad83676 -- nosy: +python-dev ___ Pytho

[issue12044] subprocess.Popen.__exit__ doesn't wait for process end

Roundup Robot added the comment: New changeset b00a64a5cb93 by Gregory P. Smith in branch '3.2': merge - 7a3f3ad83676 Fixes Issue #12044. http://hg.python.org/cpython/rev/b00a64a5cb93 -- ___ Python tracker __

[issue12044] subprocess.Popen.__exit__ doesn't wait for process end

Gregory P. Smith added the comment: did my commits in the reverse order (default before 3.2), oops. this is fixed. this wasn't ever in 2.7 so no need for the documentation note. i'm not worried about adding a note about 3.2.0 vs 3.2.1 beyond the mention in Misc/NEWS as this was new in 3.2.

[issue5723] Incomplete json tests

Ezio Melotti added the comment: Attached patch refactors the tests to use import_fresh_module and different subclasses for Python and C tests. It also includes a fix to import_fresh_module to make it work with packages (it can be committed separately). -- assignee: bob.ippolito -> ezi

[issue12061] Remove duplicate 'key functions' entry in Glossary

Roundup Robot added the comment: New changeset 534a9e274d88 by Georg Brandl in branch '2.7': #12061: remove duplicate glossary entry. http://hg.python.org/cpython/rev/534a9e274d88 -- nosy: +python-dev ___ Python tracker

[issue12061] Remove duplicate 'key functions' entry in Glossary

Georg Brandl added the comment: Thanks for the patch! -- nosy: +georg.brandl resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue12058] Minor edits to comments in faulthandler

Changes by Ezio Melotti : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Pyt

[issue8824] Improve documentation of exec

Ezio Melotti added the comment: In 3.x exec is a function, so the reference to 'in' should be removed/updated. On 2.x it might be better to just use ``in`` instead of :keyword:`in`, because the latter probably links to the 'in' operator that checks for containment. -- nosy: +ezio.mel

[issue12042] What's New multiprocessing example error

Ezio Melotti added the comment: The workflow to prepare a patch using Mercurial is pretty much the same as SVN: # get a clone (checkout) of the repository hg clone http://hg.python.org/cpython # select the branch where you want to fix the issue hg update 2.7 # make changes on the file(s) and m