[issue11660] closure with too few cells segfaults

2011-03-24 Thread Eric Snow
New submission from Eric Snow : While perhaps esoteric, it looks like exec'ing a code object that has freevars, using a closure that has too few cells causes a segfault. I believe the problem is around line 3276 of ceval.c at the PyTuple_GET_ITEM call: if (PyTuple_GET_SIZE(co->co_freevars

[issue11477] Bug in code dispatching based on internal slots

2011-03-24 Thread Martin v . Löwis
Changes by Martin v. Löwis : Added file: http://bugs.python.org/file21367/650549138a3d.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11477] Bug in code dispatching based on internal slots

2011-03-24 Thread Martin v . Löwis
Changes by Martin v. Löwis : Removed file: http://bugs.python.org/file21258/f1bd5468dae6.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue11477] Bug in code dispatching based on internal slots

2011-03-24 Thread Martin v . Löwis
Changes by Martin v. Löwis : Removed file: http://bugs.python.org/file21367/650549138a3d.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue11477] Bug in code dispatching based on internal slots

2011-03-24 Thread Martin v . Löwis
Changes by Martin v. Löwis : Added file: http://bugs.python.org/file21368/650549138a3d.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

2011-03-24 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: By the way, in another thread i've seen a link to issue960406, where Guido van Rossum states (in msg46074): Ideally, ^C should always cause the signal handler for SIGINT to be called, and the KeyboardInterrupt should be generated by the def

[issue11606] maxlinelen exceeded by email module's body_encode() function

2011-03-24 Thread Michael Henry
Michael Henry added the comment: David, Your patch looks fine to me. I like putting the logic is a separate class as you've done. I looked in itertools for something to perform the job of the each_last() generator I'd had in my patch, but I didn't see anything. I like the idea of encapsulati

[issue11650] Faulty RESTART/EINTR handling in Parser/myreadline.c

2011-03-24 Thread Davide Rizzo
Changes by Davide Rizzo : -- nosy: +mwh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: By the way, as my simple tests, wprintf() with "%ls" does apply the width and precision formatters on units of characters. -- ___ Python tracker ___

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: There are 4 patches "issue 7030" attached to this issue. Some of them have a version number in their name, some doesn't. You did the same on other issues. It is more easy to follow a patch if it has a version number, for example: issue_7330.diff, issue_7330-2

[issue11658] complex sqrt error

2011-03-24 Thread Mark Dickinson
Mark Dickinson added the comment: I don't see a real problem here: both cmath.sqrt(-1) and (-1)**0.5 are producing good approximations to the correct result, which is about as much as you can hope for in general with floating-point algorithms. I wouldn't want to start special-casing the comp

[issue11650] Faulty RESTART/EINTR handling in Parser/myreadline.c

2011-03-24 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: On Thu, Mar 23, 2011 at 21:50:42PM +, Davide Rizzo wrote: > Steffen, on a side note, I got readline working with brew. Say - readline not libedit which does not take care of .inputrc? Without permanently modifying GNU autoconf stuff? How do you do

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: Sorry for having done that! I will remove old patches and leave a cleaner view. -- ___ Python tracker ___ ___

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20739/issue_7330.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20786/issue_7330.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20983/issue7330_2.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue9523] Improve dbm modules

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: I tried to work out a doc patch for 3.2 to mention the limitation api: the missing methods compared with dict and the imperfect methods(keys(), items()) of collections.MutableMapping. Here is it. -- Added file: http://bugs.python.org/file21369/issue_9523_3

[issue11661] test_collections.TestNamedTuple.test_source failing on many buildbots after f09f7ab40ce6

2011-03-24 Thread R. David Murray
New submission from R. David Murray : Example: http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%207.2%203.x/builds/1609/steps/test/logs/stdio == FAIL: test_source (test.test_collections.TestNamedTuple)

[issue11656] Debug builds for Windows would be very helpful

2011-03-24 Thread Jack Jansen
Jack Jansen added the comment: Martin, I agree about the Py_DEBUG issue. My reason for asking is really only a workaround for the VC++ problam that you can't link non-debug and debug builds together. You know what: if you think it isn't worth it just assign it to me and I'll try to go the ex

[issue11661] test_collections.TestNamedTuple.test_source failing on many buildbots after f09f7ab40ce6

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: Link to the commit: f09f7ab40ce6 -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11655] map() must not swallow exceptions from PyObject_GetIter

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: There maybe compatibility issues which prevent such behavior change. -- nosy: +ysj.ray ___ Python tracker ___ __

[issue11455] issue a warning when populating a CPython type dict with non-string keys

2011-03-24 Thread Nick Coghlan
Nick Coghlan added the comment: Thomas, I know you've been working on this post-Pycon. Could you please take a look at Daniel's patch and/or publish your own. -- assignee: -> twouters nosy: +ncoghlan, twouters ___ Python tracker

[issue11455] issue a warning when populating a CPython type dict with non-string keys

2011-03-24 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue11455] issue a warning when populating a CPython type dict with non-string keys

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: Cool, someone uses my PyErr_WarnFormat() function! :-) I didn't know that NULL can be used for the category: I would prefer an explicit PyExc_RuntimeWarning to not have to read the source of PyErr_WarnFormat() or its documentation. -- ___

[issue1590744] mail message parsing glitch

2011-03-24 Thread R. David Murray
R. David Murray added the comment: I needed an airplane-trip-sized problem to work on on the way back from PyCon and the sprints, so I tried my hand at "fixing" this. The attached patch is really just a proof of concept. Because it is so invasive of the email package machinery I doubt that

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: Agree to removing of termios.ISIG so that we get a KeyBoardInterrupt exception raised when CNTL-C is pressed. Looking at discussion more carefully, it does not present any security risk. Should this be fixed in 3.3 only with NEWS detailing the change in beha

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset c177faafec51 by Senthil Kumaran in branch 'default': issue11236 getpass.getpass to respond ctrl-c or ctrl-z http://hg.python.org/cpython/rev/c177faafec51 -- nosy: +python-dev ___ Python tracker

[issue11466] getpass.getpass doesn't close tty file

2011-03-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue975330] Inconsistent newline handling in email module

2011-03-24 Thread R. David Murray
Changes by R. David Murray : -- versions: -Python 2.7, Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue11466] getpass.getpass doesn't close tty file

2011-03-24 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: On Thu, Mar 24, 2011 at 02:34:34PM +, Senthil Kumaran wrote: > assignee: -> orsenthil Here is yet another patch which only passes valid streams into _user_input(), so that this does not need to take care about that at all. Would you please revie

[issue11635] concurrent.futures uses polling

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 76a898433a02 by Antoine Pitrou in branch '3.2': Add tests for the atexit hook in concurrent.futures (part of #11635) http://hg.python.org/cpython/rev/76a898433a02 New changeset d6bbde982c1c by Antoine Pitrou in branch 'default': Add tests for the a

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Guido van Rossum
New submission from Guido van Rossum : We received the following on the security list. With the OP's permission I am now filing a public bug with a patch, with the intent to submit the patch ASAP (in time for MvL's planned April security release of Python 2.5). The OP's description is below; I

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: >> HTTPRedirectHandler behaviour can be changed >> to only allow redirects to HTTP, HTTPS and FTP by checking the scheme >> of the location URL (this seems to be a common practise in browsers) This would be the way to go. -- nosy: +orsenthil

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Guido van Rossum
Changes by Guido van Rossum : -- keywords: +patch Added file: http://bugs.python.org/file21372/dd852a0f92d6.diff ___ Python tracker ___ __

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: Repository URL is incorrect (missing http:/ prefix). The commit: http://hg.python.org/sandbox/guido/rev/dd852a0f92d6 -- nosy: +haypo ___ Python tracker ___

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Guido van Rossum
Guido van Rossum added the comment: Please review the patch that I created. (Now why doesn't it have a "review" link?) Note that the patch currently only allows http and https. -- ___ Python tracker _

[issue11653] Problems with some tests using -j2

2011-03-24 Thread Skip Montanaro
Skip Montanaro added the comment: Ned> Skip, what parameters are you using with ./configure ? Pretty vanilla. Install in my directory tree, get libraries from MacPorts: --prefix=/Users/skip/local --enable-shared LDFLAGS=-L/opt/local/lib CPPFLAGS=-I/opt/local/include I thought you had fixe

[issue11635] concurrent.futures uses polling

2011-03-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: Tests now committed, here is a patch without them. -- Added file: http://bugs.python.org/file21373/cfpolling4.patch ___ Python tracker ___

[issue11653] Problems with some tests using -j2

2011-03-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Pretty vanilla. Install in my directory tree, get libraries from MacPorts: > > --prefix=/Users/skip/local --enable-shared LDFLAGS=-L/opt/local/lib > CPPFLAGS=-I/opt/local/include > > I thought you had fixed the --enable-shared linkage problems, but takin

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: >> why doesn't it have a "review" link? Perhaps, as it is not against the 'default'? Let's try my hg sandbox link which has a fix committed. Let's see if it gives the review link. -- hgrepos: +7 ___ Python tracke

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : Added file: http://bugs.python.org/file21374/c6a4d267fe88.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: The patch has no test. You may read our new "Python Developer’s Guide" for new contributors: http://docs.python.org/devguide/runtests.html#writing -- ___ Python tracker _

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Guido van Rossum
Guido van Rossum added the comment: Oddly, I now see a review link for my own diff but not for orsenthil's. Maybe there's a delay? I could use help with the tests. I suppose orsenthil's patch is for Python 3? -- ___ Python tracker

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: Which patch should be reviewed? They seem to be different. Senthil's patch allows a redirect to ftp while Guido's doesn't. Senthil's patch doesn't seem to fix urllib-inherited code, only urllib2- (see FancyURLopener.redirect_internal()). Guido's patch doesn'

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: c6a4d267fe88.diff: This patch doesn't explain why other scheme are not allowed. I like Guido's comment: # For security reasons we do not allow redirects to protocols # other than HTTP or HTTPS. -- ___ Python tracke

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread R. David Murray
R. David Murray added the comment: Yes there is a delay. The cron job that creates the link runs every two minutes. Not sure why the delay seems to be longer than that, though. -- nosy: +r.david.murray ___ Python tracker

[issue11606] maxlinelen exceeded by email module's body_encode() function

2011-03-24 Thread R. David Murray
R. David Murray added the comment: I turns out that issue 5803 has a patch that also fixes this bug, and the algorithm used there is even more efficient than the one you've developed here. However, it is also not compatible with the email5 version of quoprimime. It could be adapted, but I t

[issue11663] concurrent.futures (or multiprocessing?) doesn't detect killed processes

2011-03-24 Thread Antoine Pitrou
New submission from Antoine Pitrou : If you do: ./python -c "from concurrent.futures import *; from time import *; t = ProcessPoolExecutor(1); t.submit(sleep, 60)" and then kill the child process, the parent process doesn't notice and waits endlessly for the child to return the results. I'm

[issue11663] concurrent.futures (or multiprocessing?) doesn't detect killed processes

2011-03-24 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue11393] Integrate faulthandler module into Python 3.3

2011-03-24 Thread Scott Dial
Scott Dial added the comment: Antoine Pitrou wrote: > It would be nice if it were enabled by default for fatal errors (and asserts > perhaps?). I feel like a broken record. This code hardcodes fd=2 as a write target on crash, which is not safe thing to do at all. You can argue that adopters o

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

2011-03-24 Thread Merlijn van Deen
Merlijn van Deen added the comment: @orsenthil > Close similarity with getpass.c 's behavior had lent some to support to this > change in 2.6. Changing now in older codeline has some chances of breaking > others code. > Someone who has been affected by this change in behavior should provide so

[issue11663] concurrent.futures (or multiprocessing?) doesn't detect killed processes

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: In the following example, if I kill the child process, the parent is immediatly done: --- from os import getpid from time import sleep from multiprocessing import Process def f(sec): print("child %s: wait %s seconds" % (getpid(), sec)) sleep(sec) if _

[issue11663] concurrent.futures (or multiprocessing?) doesn't detect killed processes

2011-03-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le jeudi 24 mars 2011 à 16:16 +, STINNER Victor a écrit : > STINNER Victor added the comment: > > In the following example, if I kill the child process, the parent is > immediatly done: > --- > from os import getpid > from time import sleep > from multipr

[issue11393] Integrate faulthandler module into Python 3.3

2011-03-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Antoine Pitrou wrote: > > It would be nice if it were enabled by default for fatal errors (and > > asserts perhaps?). > > I feel like a broken record. This code hardcodes fd=2 as a write target on > crash, For fatal errors, you needn't be async-safe, so th

[issue11610] Improving property to accept abstract methods

2011-03-24 Thread Darren Dale
Darren Dale added the comment: Here is a new version of the patch. I think it addresses all of the issues that have been raised to date. I had to comment out the -lintl line in Modules/Setup to build on OS X, this seems to be a similar issue to http://bugs.python.org/issue6154 . So I don't h

[issue11477] Bug in code dispatching based on internal slots

2011-03-24 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue11606] maxlinelen exceeded by email module's body_encode() function

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 37ba11d806c5 by R David Murray in branch '3.1': #11606: improved body_encode algorithm, no longer produces overlong lines http://hg.python.org/cpython/rev/37ba11d806c5 New changeset b801d55a9979 by R David Murray in branch '3.2': Merge #11606: impr

[issue11393] Integrate faulthandler module into Python 3.3

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: > For fatal errors, you needn't be async-safe, so the fatal error code > could read fileno(stderr) and give it to the traceback printing code. My last patch for issue #8863 does exactly that: ## void Py_FatalError(const char *msg) { -fprintf

[issue11606] maxlinelen exceeded by email module's body_encode() function

2011-03-24 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11663] concurrent.futures (or multiprocessing?) doesn't detect killed processes

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: In the following example, the parent doesn't react when the child process is killed: - from os import getpid from time import sleep, time from multiprocessing import Pool def f(sec): print("child %s: wait %s seconds" % (getpid(), sec)) sleep(sec)

[issue11663] multiprocessing (and concurrent.futures) doesn't detect killed processes

2011-03-24 Thread STINNER Victor
Changes by STINNER Victor : -- title: concurrent.futures (or multiprocessing?) doesn't detect killed processes -> multiprocessing (and concurrent.futures) doesn't detect killed processes ___ Python tracker ___

[issue11663] multiprocessing (and concurrent.futures) doesn't detect killed processes

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: It's possible to stop the parent with a CTRL+c, and so here is the trace of blocking function: $ ./python y.py parent 26706: wait child child 26707: wait 60 seconds ^CProcess PoolWorker-2: Traceback (most recent call last): File "y.py", line 13, in Traceba

[issue11661] test_collections.TestNamedTuple.test_source failing on many buildbots after f09f7ab40ce6

2011-03-24 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks for the report. It looks like globals() contamination is happening on the buildbot that isn't happening locally. Isolated the test in commit 4f1cd92fe835 Will check the buildbots after to make sure it worked. Otherwise, will delete test. ---

[issue11661] test_collections.TestNamedTuple.test_source failing on many buildbots after f09f7ab40ce6

2011-03-24 Thread STINNER Victor
STINNER Victor added the comment: Why do you remove NTColor from globals *after* creating it? The assertion looks useless, or are you testing that globals().pop() works as expected? tmp = namedtuple('NTColor', 'red green blue') globals().pop('NTColor', None) # remove artifacts from ot

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Guido van Rossum
Guido van Rossum added the comment: > Which patch should be reviewed? They seem to be different. Both. Mine's for the Python 2 line while Senthil seems to deal with Python 3. (However the presence of Senthil's patch somehow overrode my patch in Rietveld. It looks like Martin didn't think of thi

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : Added file: http://bugs.python.org/file21376/3c07ea6a176a.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: Here is a more complete patch with tests. Please review this. Yes, it is against the default branch (3.x codeline). We can backport this behavior to 2.x codeline. I have raised an URLError exception when the direct to invalid_schemes is detected. Also, ftp

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: > > Senthil's patch allows a redirect to ftp while Guido's doesn't. > > That is a good question. Should we? It doesn't look like ftp: > participates in the vulnerability, but I'm not sure how useful it is > either. I would say accept it anyway. That way we min

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Guido van Rossum
Guido van Rossum added the comment: I am okay with adding FTP to the list. I still don't think we should raise URLError on the bad redirect; we should treat it the same as a missing URI/Location header, and it will raise HTTPError. -- ___ Python tr

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Guido van Rossum
Changes by Guido van Rossum : Added file: http://bugs.python.org/file21377/ca3b117c40f3.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11635] concurrent.futures uses polling

2011-03-24 Thread Antoine Pitrou
Antoine Pitrou added the comment: After studying the multiprocessing code, it turns out that Queue.get() with a timeout does its own rather high-frequency polling under Windows (see Modules/_multiprocessing/pipe_connection.c). Therefore, here is an updated patch which doesn't have a security

[issue5305] imaplib should support international mailbox names

2011-03-24 Thread Александр Цамутали
Александр Цамутали added the comment: So noone is working on this issue ATM? -- nosy: +astsmtl ___ Python tracker ___ ___ Python-bugs-

[issue11030] regrtest - allow for relative path with --coverdir

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6ff4e479f03b by R David Murray in branch 'default': #11030: make --coverdir work for relative directories again. http://hg.python.org/cpython/rev/6ff4e479f03b -- nosy: +python-dev ___ Python tracker

[issue11030] regrtest - allow for relative path with --coverdir

2011-03-24 Thread R. David Murray
R. David Murray added the comment: Thanks. Shortened patch by using the fact that os.path.join returns the second component if it is absolute, as discussed on IRC. -- nosy: +r.david.murray resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed type: ->

[issue11031] regrtest - --testdir, new command-line option to specify alternative test directory

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset ef393e6ac31b by R David Murray in branch 'default': #11031: Add --testdir to specify where to find tests http://hg.python.org/cpython/rev/ef393e6ac31b -- nosy: +python-dev ___ Python tracker

[issue11031] regrtest - --testdir, new command-line option to specify alternative test directory

2011-03-24 Thread R. David Murray
R. David Murray added the comment: Made the same change to the usage of os.path.join. -- nosy: +r.david.murray resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed type: -> feature request ___ Python tracker

[issue11093] test_future - rename not-unittest files to make regrtest.NOTTESTS an empty set

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6a649a15cd14 by R David Murray in branch 'default': #11093: make NOTTESTS empty by renaming confusingly named files in test dir. http://hg.python.org/cpython/rev/6a649a15cd14 -- nosy: +python-dev ___ Pyt

[issue11093] test_future - rename not-unittest files to make regrtest.NOTTESTS an empty set

2011-03-24 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue10225] Fix doctest runable examples in python manual

2011-03-24 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > Please leave the deployed code for named tuple as-is. Doctest may > have issues with trailing whitespace, but that is doctest's problem, > not named tuple's. I am curious, what was the reason to add trailing whitespace in the named tuple template? --

[issue10225] Fix doctest runable examples in python manual

2011-03-24 Thread Raymond Hettinger
Raymond Hettinger added the comment: > I am curious, what was the reason to add > trailing whitespace in the named tuple template? To make it hard to doctest ;-) I had a thought that it made the template more readable, but the better solution was to just use real newlines instead of '\n'.

[issue9344] please add posix.getgrouplist()

2011-03-24 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Looks good to me as well. Just a nit-pick: in python code base "sizeof" is not separated from the opening parenthesis. I understand the desire to distinguish "sizeof" from a function, but it is probably better to be consistent. -- assignee: be

[issue9344] please add posix.getgrouplist()

2011-03-24 Thread Ross Lagerwall
Ross Lagerwall added the comment: Ronald, does it have the same problem as #7900 on OS X or can I commit? -- ___ Python tracker ___ __

[issue9909] request for calendar.dayofyear() function

2011-03-24 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue1156179] Calls from VBScript clobber passed args

2011-03-24 Thread Chris Lambacher
Chris Lambacher added the comment: copied to pywin32 bug tracker: http://sourceforge.net/tracker/index.php?func=detail&aid=3238774&group_id=78018&atid=551954 -- nosy: +lambacck ___ Python tracker __

[issue11650] Faulty RESTART/EINTR handling in Parser/myreadline.c

2011-03-24 Thread Michael Hudson
Michael Hudson added the comment: To be clear, I have no idea why the patch for issue 960406 removed the continue from my_fgets. It may have been simply a mistake. -- ___ Python tracker _

[issue11610] Improving property to accept abstract methods

2011-03-24 Thread Ned Deily
Ned Deily added the comment: (Darren, what version of OS X and what arguments did you use for ./configure ? In general, for testing purposes, a vanilla ./configure with no args should work fine for building a Python that works right from your source build directory. If you want to build som

[issue11664] Add patch method to unittest.TestCase

2011-03-24 Thread Éric Araujo
New submission from Éric Araujo : A common thing to do in setUp or test* methods is to replace some module attribute with something else, either to mock an object calling an external resource or to test platform-specific behavior (for example, changing os.name before calling some function). C

[issue11664] Add patch method to unittest.TestCase

2011-03-24 Thread Éric Araujo
Éric Araujo added the comment: Typo s/self.path/self.patch/ I forgot to mention the rationale for this method: factor out common code to make sure the cleanup is not forgotten. Also kill debates about addCleanup vs. tearDown vs. try/finally. -- _

[issue11664] Add patch method to unittest.TestCase

2011-03-24 Thread Éric Araujo
Éric Araujo added the comment: Needless to say the name is open: patch, replace, settempvalue, what have you. -- ___ Python tracker ___ _

[issue11634] misleading comment on PyBytes_FromStringAndSize

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset a729dfdbd24b by Eli Bendersky in branch 'default': Issue #11634: Remove misleading paragraph from a comment http://hg.python.org/cpython/rev/a729dfdbd24b -- nosy: +python-dev ___ Python tracker

[issue11634] misleading comment on PyBytes_FromStringAndSize

2011-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 44749e501982 by Eli Bendersky in branch '2.7': Issue #11634: Remove misleading paragraph from a comment http://hg.python.org/cpython/rev/44749e501982 -- ___ Python tracker

[issue11634] misleading comment on PyBytes_FromStringAndSize

2011-03-24 Thread Eli Bendersky
Eli Bendersky added the comment: Patch reviewed by Nick Coghlan and committed -- resolution: -> fixed status: open -> closed versions: +Python 2.7 -Python 3.2 ___ Python tracker __

[issue11650] Faulty RESTART/EINTR handling in Parser/myreadline.c

2011-03-24 Thread Steffen Daode Nurpmeso
Changes by Steffen Daode Nurpmeso : -- nosy: +jesstess ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue11455] issue a warning when populating a CPython type dict with non-string keys

2011-03-24 Thread Daniel Urban
Daniel Urban added the comment: > I would prefer an explicit PyExc_RuntimeWarning to not have to read the > source of PyErr_WarnFormat() or its documentation. The patch at issue11470 adds a new warning type, CompatibilityWarning. I think probably that should be used here too. --

[issue9056] Adding additional level of bookmarks and section numbers in python pdf documents.

2011-03-24 Thread Sandro Tosi
Sandro Tosi added the comment: The number of items in the bookmark is controlled by \setcounter{tocdepth}{1} in sphinxmanual.cls, that's included in every latex file (the source of the PDF documentation). The cls file is coming directly from sphinx, so Georg: what is the purpose of limiting

[issue10966] eliminate use of ImportError implicitly representing SkipTest

2011-03-24 Thread Éric Araujo
Éric Araujo added the comment: I’m probably the one with the least regrtest knowledge among us, but I like the general idea of moving the compat info from one huge dict into the tests themselves. It looks more readable and maintainable. The new tests for test.support looks good. I have a re

[issue11660] closure with too few cells segfaults

2011-03-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: And the source of exec_closure is what exactly? -- nosy: +benjamin.peterson ___ Python tracker ___ _

[issue11610] Improving property to accept abstract methods

2011-03-24 Thread Darren Dale
Darren Dale added the comment: (Ned, I'm running 10.6.6 with a 64-bit kernel. I've tried running ./configure without any arguments, and also with --prefix=/opt/local, since I install essentially everything with MacPorts.) -- ___ Python tracker

[issue11656] Debug builds for Windows would be very helpful

2011-03-24 Thread Martin v . Löwis
Martin v. Löwis added the comment: > Martin, I agree about the Py_DEBUG issue. My reason for asking is > really only a workaround for the VC++ problam that you can't link > non-debug and debug builds together. Please understand that this is factually incorrect, if, by "debug build" you mean "bu

[issue11660] closure with too few cells segfaults

2011-03-24 Thread Daniel Urban
Changes by Daniel Urban : -- nosy: +durban ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

  1   2   >