[issue10641] kill_python sometimes fails to kill processes on buildbots

2010-12-07 Thread Hirokazu Yamamoto
Hirokazu Yamamoto added the comment: To kill python_d.exe, you should use kill_python_d.exe instead of kill_python.exe. > On the XP and Win7 buildbots, kill_python sometimes fails to kill hung > processes. Could you post the buildbot log url? -- nosy: +ocean-city

[issue10641] kill_python sometimes fails to kill processes on buildbots

2010-12-07 Thread Hirokazu Yamamoto
Hirokazu Yamamoto added the comment: I think #9973 is rather related. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9973] Sometimes buildbot fails to cleanup working copy

2010-12-07 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto : Added file: http://bugs.python.org/file19968/py3k_buildbot_error_in_clean_faze_v2.patch ___ Python tracker ___

[issue9973] Sometimes buildbot fails to cleanup working copy

2010-12-07 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file19047/py3k_buildbot_error_in_clean_faze.patch ___ Python tracker ___ _

[issue10643] OSX proxy exceptions parse bug in urllib (crash)

2010-12-07 Thread Ned Deily
Ned Deily added the comment: The fix for this problem, originally reported in Issue8883, was released in Python 2.6.6. -- assignee: -> ronaldoussoren components: +Library (Lib), Macintosh -Extension Modules nosy: +ned.deily, ronaldoussoren resolution: -> duplicate status: open -> clo

[issue10644] socket loses data, calling send()/sendall() on invalid socket does not report error and returns all bytes as written

2010-12-07 Thread diekmann
New submission from diekmann : Calling send()/sendall() on an invalid socket does not report an error and returns all bytes as written. Thus, all bytes written to the socket are lost and the application is not informed about that and treats the bytes as successfully sent. The bytes given to th

[issue10641] kill_python sometimes fails to kill processes on buildbots

2010-12-07 Thread David Bolen
David Bolen added the comment: > To kill python_d.exe, you should use kill_python_d.exe instead of > kill_python.exe. Crud, I thought I did. Well, ok, so can't trust this test. > Could you post the buildbot log url? I think this is the last build in the sequence that was failing until I kill

[issue10645] egg-info file in lib-dynload

2010-12-07 Thread Ronald Oussoren
New submission from Ronald Oussoren : I just noticed that distutils creates an egg-info for the stdlib while installing Python. This definitely happens for Python 2.7 and Python 3.2 (both framework builds on OSX). In lib-dynload there is and egg-info file: "Python-2.7.1-py2.7.egg-info" Is t

[issue10641] kill_python sometimes fails to kill processes on buildbots

2010-12-07 Thread David Bolen
David Bolen added the comment: > I think #9973 is rather related. Certainly could be another artifact of a python_d process still executing. In particular though, the suggested patch in that issue agrees with what I was thinking might be needed, in terms of moving kill_python_d over to clean.

[issue10548] Error in setUp not reported as expectedFailure (unittest)

2010-12-07 Thread holger krekel
holger krekel added the comment: Michael, if you have it i'd like to see the original post/concrete use case. thanks, holger -- ___ Python tracker ___ _

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

2010-12-07 Thread Hirokazu Yamamoto
Hirokazu Yamamoto added the comment: Committed in r87117(py3k). -- priority: release blocker -> resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue9558] build_ext fails on VS8.0

2010-12-07 Thread Hirokazu Yamamoto
Hirokazu Yamamoto added the comment: Won't this go into python3.2? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue9558] build_ext fails on VS8.0

2010-12-07 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: I happen to have the same change in my workspace. Please apply this patch, it fixes the test suite when compiled with VS8.0. -- nosy: +amaury.forgeotdarc ___ Python tracker

[issue10626] Bad interaction between test_logging and test_concurrent_futures

2010-12-07 Thread Vinay Sajip
Vinay Sajip added the comment: I will take a look at test_logging tidying up after itself, though the intention is to leave things as they were found (this is done in setUp/tearDown, and if it doesn't tidy up properly, that would be a bug). As already explained in logging's documentation, the

[issue10626] Bad interaction between test_logging and test_concurrent_futures

2010-12-07 Thread Nick Coghlan
Nick Coghlan added the comment: Yeah, I think that comment was just a mistaken impression on my part. Definitely something odd going on with the test interaction though. -- ___ Python tracker

[issue9558] build_ext fails on VS8.0

2010-12-07 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the ping and the confirmation that it works. Will check in shortly. -- components: +Distutils2 priority: normal -> high status: open -> pending versions: +3rd party -Python 2.6 ___ Python tracker

[issue10645] egg-info file in lib-dynload

2010-12-07 Thread Éric Araujo
Éric Araujo added the comment: I think the existence of this file is intentional, to satisfy pkg_resources requirements for “Python”. Philip can confirm. -- nosy: +pje ___ Python tracker

[issue5587] vars() no longer has a useful __repr__

2010-12-07 Thread Éric Araujo
Éric Araujo added the comment: Looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue10642] site.py crashes on python startup due to defective .pth file

2010-12-07 Thread Éric Araujo
Changes by Éric Araujo : -- assignee: tarek -> components: +Library (Lib) -Distutils2 type: crash -> behavior versions: +Python 3.1, Python 3.2 ___ Python tracker ___ __

[issue8194] Incompatible API change in xmlrpclib.Transport.parse_response() of Python 2.7 and 3.2

2010-12-07 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Please also fix it in py3k branch in Lib/xmlrpc/client.py. -- ___ Python tracker ___ __

[issue10642] site.py crashes on python startup due to defective .pth file

2010-12-07 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue10643] OSX proxy exceptions parse bug in urllib (crash)

2010-12-07 Thread R. David Murray
Changes by R. David Murray : -- stage: -> committed/rejected type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mail

[issue10644] socket loses data, calling send()/sendall() on invalid socket does not report error and returns all bytes as written

2010-12-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: Which OS is it? It works for me: Traceback (most recent call last): File "socketbug.py", line 24, in print(con.send(bytes("Hello", "ascii"))) socket.error: [Errno 32] Broken pipe Regardless, the error returned is the one returned by your OS here. If you

[issue10642] site.py crashes on python startup due to defective .pth file

2010-12-07 Thread R. David Murray
R. David Murray added the comment: If the problem is in site.py it doesn't sound like a distutils bug at all. I remember Victor doing something that changed the error handling/reporting when importing site.py, so I'm adding him as nosy. I thought that was only in 3.x, though. Does this not

[issue9523] Improve dbm modules

2010-12-07 Thread Ray.Allen
Ray.Allen added the comment: Oh, yes. I noticed that the pep3119 defines return value of method MutableMapping.keys() as Set, as well as method items(). So the implementation of dumb.keys() and dump.items() are not correct since they all return lists while the class inherits MutableMapping.

[issue9227] can't import Tkinter / use IDLE after installing Python 2.7 on Mac OS X

2010-12-07 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ P

[issue10107] Quitting IDLE on Mac doesn't save unsaved code

2010-12-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: Ned: why does the patch change the signature of close_all_callback? -def close_all_callback(self, event): +def close_all_callback(self, *args, **kwds): -- ___ Python tracker

[issue2799] Remove _PyUnicode_AsString(), rework _PyUnicode_AsStringAndSize(), add PyUnicode_AsChar()

2010-12-07 Thread Julian Andres Klode
Julian Andres Klode added the comment: The problem I see here is that there is no public way to simply get a C string from a unicode object similar to PyBytes_AsString() for bytes. That's bad because we don't want to rewrite the whole code to duplicate strings all the time and free every stri

[issue10154] locale.normalize strips "-" from UTF-8, which fails on Mac

2010-12-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: UTF-8 works on SuSE Enterprise Linux 9 and 10 as well. BTW, neither UTF8 nor UTF-8 work on HPUX 10. That platform requires spelling it as utf8. This sadly enought means that this code doesn't work on HPUX 10: >>> locale.setlocale(locale.LC_ALL, locale.get

[issue10580] Installer sentence in bold

2010-12-07 Thread Brian Curtin
Brian Curtin added the comment: Changing "Completing" to "Complete" seems fine to me. Here is a screenshot of where this currently appears: http://i.imgur.com/RX9b9.png -- ___ Python tracker

[issue9129] DoS smtpd module vulnerability

2010-12-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm okay classifying this as a security bug that should be fixed in the 2.6 tree. -- ___ Python tracker ___ __

[issue6706] asyncore's accept() is broken

2010-12-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I do not see this as a security bug so no patch for 2.6 please. (Comment requested from IRC). -- nosy: +barry ___ Python tracker ___

[issue10107] Quitting IDLE on Mac doesn't save unsaved code

2010-12-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: Ned: never mind the command callback has a different signature than a keybinding. Committed the patch for 3.2 in r87119. -- ___ Python tracker _

[issue9523] Improve dbm modules

2010-12-07 Thread R. David Murray
R. David Murray added the comment: I believe that in the absence of other documentation the ABC is considered authoritative. -- nosy: +r.david.murray ___ Python tracker ___

[issue10404] IDLE on OS X popup menus do not work: cannot set/clear breakpoints

2010-12-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: The patch binds the menu to Ctrl-Button-1 (that is, the way you open context menu's on OSX systems with a single button), however rightclick still doens't work (but does an X11-style paste operation). I propose adding an explicit binding for button-2 as well

[issue10107] Quitting IDLE on Mac doesn't save unsaved code

2010-12-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: Merged to 3.1.x in r87120, merged to 2.7. in r87121. Ned: thanks for looking into this, doubly so because Tk-on-OSX is involved. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___

[issue10406] IDLE 2.7 on OS X does not enable Rstrip extension by default

2010-12-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: Fixed in r87122. Thanks you. -- resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue9973] Sometimes buildbot fails to cleanup working copy

2010-12-07 Thread David Bolen
David Bolen added the comment: I wonder if it might be better to have kill_python run at the tail end of test.bat, since there's a potential window where losing a connection to the build master might not run the clean step, so still risk blocking a future build after a reconnect due to still

[issue8084] pep-0370 on osx duplicates existing functionality

2010-12-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: (reopening to ensure glyph's message doesn't get lost) -- status: closed -> open ___ Python tracker ___ ___

[issue10646] ntpath.samefile doesn't work for hard links

2010-12-07 Thread Brian Curtin
New submission from Brian Curtin : ntpath.samefile is currently implemented using GetFinalPathNameByHandle, which doesn't work for hard links. Since I introduced values for os.stat().st_ino in #8879 (which implemented os.link), I suspect we can possibly change ntpath.samefile to be the same as

[issue10644] socket loses data, calling send()/sendall() on invalid socket does not report error and returns all bytes as written

2010-12-07 Thread diekmann
diekmann added the comment: ubuntu 9.10 with python 3.1.1+ and debian 5.0.6 with Python 3.1.3rc1 I can reproduce the bug on both systems. Maybe it has been fixed in python 3.2? -- resolution: invalid -> status: pending -> open versions: -Python 3.2 __

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I am attaching a revised version of the patch which also includes some tests. Interestingly, the issue in syslog module is a regression from 3.1 introduced in r80401. Although it is not a crasher, I don't think it was intentional because although open

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Added file: http://bugs.python.org/file19970/issue6697a.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue10644] socket loses data, calling send()/sendall() on invalid socket does not report error and returns all bytes as written

2010-12-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: I tried on both 3.1.3 and 3.2. It works (raises an error) under Mandriva; I've just tested under Debian stable and it fails. Looking at netstat, the difference seems to be that "nc" closes the TCP connection fine under Mandriva when killed, and doesn't under

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Alexander Belopolsky wrote: > > Alexander Belopolsky added the comment: > > I am attaching a revised version of the patch which also includes some tests. > Interestingly, the issue in syslog module is a regression from 3.1 > introduced in r80401. Alth

[issue8654] Improve ABI compatibility between UCS2 and UCS4 builds

2010-12-07 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue10542] Py_UNICODE_NEXT and other macros for surrogates

2010-12-07 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Daniel, While these macros should not affect ABI, I would appreciate your feedback in light of your work on issue 8654. -- nosy: +stutzbach ___ Python tracker

[issue10542] Py_UNICODE_NEXT and other macros for surrogates

2010-12-07 Thread Daniel Stutzbach
Daniel Stutzbach added the comment: +1 on the general idea of abstracting out repeated code. I will take a closer look at the details within the next few days. -- ___ Python tracker __

[issue5673] Add timeout option to subprocess.Popen

2010-12-07 Thread Pablo Bitton
Pablo Bitton added the comment: Has anybody had a chance to look into the problem I encountered yet? Do you need more information? -- ___ Python tracker ___

[issue10404] IDLE on OS X popup menus do not work: cannot set/clear breakpoints

2010-12-07 Thread Ned Deily
Ned Deily added the comment: Unfortunately, just adding the binding to does not work because the Tk Text widget already has a documented binding of "paste-text" to and this does not override that. With the binding added, I found that the button-2 behavior for breakpoints did not work corre

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Dec 7, 2010 at 12:44 PM, Marc-Andre Lemburg wrote: .. > * Rather than just patching in error handling code, please consider > removing use of those APIs and replace their calls with something > more appropriate, e.g. using a parser API. > Yes, tha

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Alexander Belopolsky wrote: > > Alexander Belopolsky added the comment: > > On Tue, Dec 7, 2010 at 12:44 PM, Marc-Andre Lemburg > wrote: > .. >> * Rather than just patching in error handling code, please consider >> removing use of those APIs and replace

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Dec 7, 2010 at 1:11 PM, Marc-Andre Lemburg wrote: >>  I am not sure what >> you mean by "a parser API." > > PyArg_Parse() et al. See the discussion earlier on this ticket. > I've just realized that. It is the "u#" code. Yes, I'll see if I can u

[issue9129] DoS smtpd module vulnerability

2010-12-07 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Fixed for Python 2.6 in r87123. Closing out as fixed. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Alexander Belopolsky wrote: > > Alexander Belopolsky added the comment: > > On Tue, Dec 7, 2010 at 1:11 PM, Marc-Andre Lemburg > wrote: >>> I am not sure what >>> you mean by "a parser API." >> >> PyArg_Parse() et al. See the discussion earlier on this

[issue1528154] New sequences for Unicode groups and block ranges needed

2010-12-07 Thread Martin v . Löwis
Changes by Martin v. Löwis : -- Removed message: http://bugs.python.org/msg54865 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10615] Trivial mingw compile fixes

2010-12-07 Thread Martin v . Löwis
Martin v. Löwis added the comment: > - Embedding Python by just compiling/linking all the .c files in > seems to be a major feature to me; so fixing compilation is useful > for its own If that's the objective of the patch, I'm -1 on it. > - The win32 build system has never used "configure;make

[issue1528154] New sequences for Unicode groups and block ranges needed

2010-12-07 Thread admin
admin merkte an: note that posix uses a special set syntax, [:name:], for this purpose: [:alnum:] [:cntrl:] [:lower:] [:space:] [:alpha:] [:digit:] [:print:] [:upper:] [:blank:] [:graph:] [:punct:] [:xdigit:] adding a new character escape will probably break more existing ex

[issue1528154] New sequences for Unicode groups and block ranges needed

2010-12-07 Thread admin
admin merkte an: Logged In: YES user_id=38388 Could you make your request a little more specific ? We already have catregories in the re module, so adding a few more would be possible (patches are welcome !). However, we do need to know why you need them and whether there are other RE impleme

[issue10626] Bad interaction between test_logging and test_concurrent_futures

2010-12-07 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue8754] ImportError: quote bad module name in message

2010-12-07 Thread Éric Araujo
Éric Araujo added the comment: I fixed my patch, thanks to a recent commit that showed me an example of PyErr_Format :) All tests now pass. -- keywords: +needs review stage: needs patch -> patch review Added file: http://bugs.python.org/file19971/import-repr.diff

[issue8754] ImportError: quote bad module name in message

2010-12-07 Thread Éric Araujo
Changes by Éric Araujo : Removed file: http://bugs.python.org/file19726/import-repr.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue10647] scrollbar crash in non-US locale format settings

2010-12-07 Thread Herm Fischer
New submission from Herm Fischer : My app has a tkinter messages listbox with a scrollbar which works fine in US setting, but not when locale is a European setting (with comma for decimal point). It's a highly interactive app with a lot of number formattings in the local locale, and mostly us

[issue10647] scrollbar crash in non-US locale format settings

2010-12-07 Thread Brian Curtin
Changes by Brian Curtin : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue10647] scrollbar crash in non-US locale format settings

2010-12-07 Thread R. David Murray
R. David Murray added the comment: I'm not sure what bug you are reporting here. Are you saying that values using a , are automatically getting generated by tkinter and then rejected when fed back in? If so, I suspect this is a tk problem, not tkinter problem, but someone would have to prod

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2010-12-07 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: issue6697b.diff addresses Marc's comments. Thanks for the review. -- stage: patch review -> commit review Added file: http://bugs.python.org/file19972/issue6697b.diff ___ Python tracker

[issue8754] ImportError: quote bad module name in message

2010-12-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: The patch looks same to me as far as I can judge. I would have used .format instead of %, but you wrote it ;-). Seeing how many of our tests had to be patched convinced me that we should treat this like a feature request and only apply to 3.2. -- __

[issue6632] Include more fullwidth chars in the decimal codec

2010-12-07 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I wish I discovered this issue when I was working on #10557! Chances are I wouldn't have started a long python-dev thread rehashing the same issues as I see discussed here. In any case, in #10557, I replaced core uses of PyUnicode_EncodeDecimal() with

[issue10647] scrollbar crash in non-US locale format settings

2010-12-07 Thread Herm Fischer
Herm Fischer added the comment: The attached test case demonstrates this issue, run on pthyon 3.1.3 x64 and included tkinter. When running on US Locale, runs fine. Numbers have the period decimal point, no exceptions raised. Then select control panel, "Language or Region", "Change keyboards

[issue10647] scrollbar crash in non-US locale format settings

2010-12-07 Thread R. David Murray
R. David Murray added the comment: On gentoo linux with tcl/tk 8.5.8, if I use the following command line: >LC_NUMERIC=fr_FR ../release31-maint/python ListboxScrollbarLocaleIssue.py (which runs 3.1.3+) I can move the slider without any problem. I confirmed that locale.format_string("%f", 0.3

[issue10647] scrollbar crash in non-US locale format settings

2010-12-07 Thread Herm Fischer
Herm Fischer added the comment: I'm using the 3.1.3 x64 of python.org The dll's that came with it: tck85.dll, version 8.5.2.2, created 8/10/2010 tk85.dll, version 8.5.2.2, same date Is there a different way to get the version that is more helpful? Is there an easy way to try the tcl/tk you a

[issue10648] Extend peepholer to reverse loads or stores instead of build/unpack

2010-12-07 Thread Demur Rumed
New submission from Demur Rumed : This modifies the peepholer's BUILD/UNPACK_SEQUENCE for the case when all stores are simple, or all loads are simple It first scans to see if the pushing is done with simple LOADs. If so, it reverses the loads and removes the build unpack. If not, it scans ahe

[issue10649] Attempting to override special methods of a function object does not cause an error

2010-12-07 Thread Chinmay Kanchi
New submission from Chinmay Kanchi : Attempting to override a special method of an object of a builtin (like list) raises an AttributeError. This is obviously by design. However, doing the same to a user-defined function object seemingly replaces the function, but does not have the expected ef

[issue10648] Extend peepholer to reverse loads or stores instead of build/unpack

2010-12-07 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger priority: normal -> low versions: +Python 3.3 -Python 3.2 ___ Python tracker ___

[issue10647] scrollbar crash in non-US locale format settings

2010-12-07 Thread R. David Murray
R. David Murray added the comment: Well, it sounds like you are on Windows, which is a platform I'm not all that familiar with. I think we bundle TK for the windows installer, but I'm not 100% sure. I think to use a different version you have to recompile Python, which on Windows is a non-t

[issue10649] Attempting to override special methods of a function object does not cause an error

2010-12-07 Thread R. David Murray
R. David Murray added the comment: As you observe, the attribute is not read only, it simply isn't referred to when special method lookup is done. This is specified as part of the language design for new style classes, but has only been made consistently true in recent versions. On on the o

[issue10648] Extend peepholer to reverse loads or stores instead of build/unpack

2010-12-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks for the patch. I had looked at this long ago when I first added the ROT2 optimization and the ROT3/ROT2 optimization. It wasn't included because it wasn't worth the added complexity in the peepholer logic and because there were concerns about exec