[issue2382] [Py3k] SyntaxError cursor shifted if multibyte character is in line.

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment: Experimental patch was experimental, wcswidth(3) returns 1 for East Asian Ambiguous character. debian:~/python-dev/py3k# ./python /mnt/windows/a.py File "/mnt/windows/a.py", line 3 "♪xÅx" abc ^ should point 'c'. And anot

[issue4052] Build on 2.6 on AIX 5.3 fails (syntax error / undeclared identifier subtract)

New submission from Gerard <[EMAIL PROTECTED]>: I'm using an IBM compiler running in AIX 5.3. Compilation of Python 2.6 fails (see explanation below). Compilation of Python 2.5.2 is ok. /home/xyz/python/Python-2.6$ lslpp -L | grep vac vac.C 10.1.0.0C FIBM XL C C

[issue2574] Add RFC 3768 SSM Multicast support to "socket"

T.Morin <[EMAIL PROTECTED]> added the comment: I've applied the patch to the release26-maint branch, and I was able to properly compile, run and do some basic testing of the result. Find attached a patch applying cleanly to SVN release26-maint branch. -- versions: +Python 2.6 -Python 2.

[issue4051] use of TCHAR under win32

New submission from Ulrich Eckhardt <[EMAIL PROTECTED]>: In several places, Python is using TCHAR-based win32 APIs which has several consequences: 1. The actually used function depends on the _UNICODE macro, while the using code often assumes that this macro is not defined. That means that not

[issue4051] use of TCHAR under win32

Ulrich Eckhardt <[EMAIL PROTECTED]> added the comment: Add a patch that fixes a warning. -- keywords: +patch Added file: http://bugs.python.org/file11708/Python-unicode-redefine-warning.0.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue4053] str.split unintentionally strips char 'I' from the string

New submission from Govind <[EMAIL PROTECTED]>: I tried to process a text file (with UTF-8 encoding) which has contents like this: FILE=India asbds FILE=Indonasia ssgsds FILE=Africa DBGDGDFG When I use the below code: >>> f = open("e:\\temp\\file.txt", 'r') >>> lines = f.readlines() >>> for l

[issue4054] str.split unintentionally strips char 'I' from the string

New submission from Govind <[EMAIL PROTECTED]>: I tried to process a text file (with UTF-8 encoding) which has contents like this: FILE=India asbds FILE=Indonasia ssgsds FILE=Africa DBGDGDFG When I use the below code: >>> f = open("e:\\temp\\file.txt", 'r') >>> lines = f.readlines() >>> for l

[issue4053] str.split unintentionally strips char 'I' from the string

STINNER Victor <[EMAIL PROTECTED]> added the comment: Duplicate of issue4054. -- nosy: +haypo resolution: -> duplicate status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> __

[issue4054] str.split unintentionally strips char 'I' from the string

STINNER Victor <[EMAIL PROTECTED]> added the comment: It's not a bug. Please read the documentation of the split() method: http://docs.python.org/library/stdtypes.html#str.split If you want to get the value after "=", use: value = line.split("FILE=", 1)[1] or: value = line[len('FILE='):

[issue4040] ignored exceptions in generators (regression?)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: This is not specific to generators, this is due to the fact that a lot of recursion checks have been added all over the place. When an internal function designed to ignore exceptions (for example PyErr_GivenExceptionMatches()) encounters such

[issue1597850] Cross compiling patches for MINGW

rwmjones <[EMAIL PROTECTED]> added the comment: I'm trying to use this patch to cross-compile Python under Fedora, using the Fedora-MinGW project (http://fedoraproject.org/wiki/MinGW) IMHO the documentation is confusing. It sounds from the docs like CC_FOR_BUILD should be the native system comp

[issue4018] "for me" installer problem on x64 Vista

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Here is a patch that fixes the problem as proposed. An installer built with that patch is available from http://www.dcl.hpi.uni-potsdam.de/home/loewis/u/python-3.0.14158.msi -- keywords: +patch Added file: http://bugs.python.org/fil

[issue1597850] Cross compiling patches for MINGW

Luke Kenneth Casson Leighton <[EMAIL PROTECTED]> added the comment: ok. what's not explained, and isn't clear, is exactly whether you're supposed to - or even _capable_ of - cross-compiling the _entire_ python sourcecode base with mingw32, or whether you're supposed to get _just_ the python.exe

[issue4028] Problem compiling the multiprocessing module on sunos5

Changes by Jesse Noller <[EMAIL PROTECTED]>: -- assignee: -> jnoller nosy: +jnoller priority: -> normal versions: +Python 3.0 ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3876] multiprocessing does not compile on *BSD and potentialy other systems

Changes by Jesse Noller <[EMAIL PROTECTED]>: -- assignee: -> jnoller nosy: +jnoller priority: -> normal ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3876] multiprocessing does not compile on systems which do not define sem_timedwait

Changes by Jesse Noller <[EMAIL PROTECTED]>: -- title: multiprocessing does not compile on *BSD and potentialy other systems -> multiprocessing does not compile on systems which do not define sem_timedwait ___ Python tracker <[EMAIL PROTECTED]>

[issue1597850] Cross compiling patches for MINGW

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: So what's the status of this? Who is still interested in seeing what patches considered? ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3740] PEP 3121 --- module state is not nul-initalized as claimed in the PEP

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Here is a patch that should fix this. -- keywords: +needs review, patch priority: critical -> release blocker Added file: http://bugs.python.org/file11712/init.diff ___ Python tracker <[EMAIL PROT

[issue4018] "for me" installer problem on x64 Vista

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- keywords: +needs review priority: normal -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue1597850] Cross compiling patches for MINGW

rwmjones <[EMAIL PROTECTED]> added the comment: I'm very slowly working up a patch here (again 2.5.2). Since I haven't actually got even python.exe compiled yet I can't promise anything, but you never know ... ___ Python tracker <[EMAIL PROTECTED]>

[issue4014] Python-2.6-py2.6.egg-info contains Alpha reference

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Ok, I have now removed the Alpha designation, in r66814, r66815, and r66816. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue4018] "for me" installer problem on x64 Vista

Steve Lee <[EMAIL PROTECTED]> added the comment: Works for me on Vista, Not tried on XP. Seems a reasonable temporary compromise though we are now stopping all possibility of an 'all' install but as noted there is probably little need for it when application installers are created.

[issue1202] zlib.crc32() and adler32() return value

Facundo Batista <[EMAIL PROTECTED]> added the comment: Let me reopen this, I think we have an issue with this fix. The conclusion of this discussion so far is that in 3.0 the crc32 will behave like the standard, which is a good thing (tm), but in 2.6 it will not: it should return a signed intege

[issue4055] Documentation on website is missing section numbers

New submission from Ignacio Vazquez-Abrams <[EMAIL PROTECTED]>: The documentation on the website seems to have lost the numbers identifying the various sections. It was useful to point a user to e.g. §3.6.2 of the libref in order to guide them to the string interpolation documentation. This is no

[issue2960] bsddb/test/test_replication.py bus error, segfault, assertion error, pass

Jesús Cea Avión <[EMAIL PROTECTED]> added the comment: Greg, is this issue still pending?. Can we close it?. ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3439] math.frexp and obtaining the bit size of a large integer

Terry J. Reedy <[EMAIL PROTECTED]> added the comment: To add support to the proposal: there is currently yet another thread on c.l.p on how to calculate numbits efficiently. The OP needs it for prototyping cryptographic algorithms and found Python-level code slower than he wanted. -- no

[issue1202] zlib.crc32() and adler32() return value

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: An int is 32-bits on all popular platforms. Anyways i'll double check things. What platforms did you run your test on? ___ Python tracker <[EMAIL PROTECTED]> _

[issue4056] :Class: causes exception

New submission from Ian Bicking <[EMAIL PROTECTED]>: I used a reference like :Class:`something` (note the capitalization) and got this exception: Traceback (most recent call last): File "/home/ianb/src/env/lib/python2.4/site-packages/sphinx/__init__.py", line 135, in main app.builder.build

[issue4051] use of TCHAR under win32

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Please create a separate tracker item per individual change (or per group by enourmously similar changes). Each change will be reviewed separately, and will get accepted or rejected separately. This specific patch (Python-unicode-redefine-wa

[issue4052] Build on 2.6 on AIX 5.3 fails (syntax error / undeclared identifier subtract)

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: This has been fixed in r66739. -- nosy: +loewis resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _

[issue4057] Popen(..., cwd=...) does not set PWD environment variable

New submission from Miki Tebeka <[EMAIL PROTECTED]>: [21:26] pwd-bug $cat m #!/usr/bin/env python from subprocess import Popen Popen(["./t"], cwd="./p") [21:26] pwd-bug $cat p/t #!/usr/bin/env python from os import environ print environ["PWD"] [21:26] pwd-bug $python m /Users/mtebeka/playgrou

[issue4058] markup in What's New in 2.6

New submission from Robert Lehmann <[EMAIL PROTECTED]>: The markup in the Doc/whatsnew/2.6.rst document is somewhat messy in some places. I fixed indentation (spaces to tabs -- made some things readable in the docutils output but not in the source), code samples ("->" notation to Python prompt) a

[issue3740] PEP 3121 --- module state is not nul-initalized as claimed in the PEP

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I'm ok with that patch. -- keywords: -needs review nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2744] Fix test_cProfile

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Done in r66817. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3574] compile() cannot decode Latin-1 source encodings

Changes by STINNER Victor <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11698/tokenizer_iso-8859-1.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4059] sqlite3 docs incomplete

New submission from Robert Lehmann <[EMAIL PROTECTED]>: The sqlite3 documentation misses Row and Cursor.description. Additionally it does not use the best markup in all places (missing links, basically, and forgotten .. class:: statements). A patch is attached. -- assignee: georg.brandl

[issue3574] compile() cannot decode Latin-1 source encodings

Changes by STINNER Victor <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11716/tokenizer_iso-8859-1-patch3.patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2384] [Py3k] line number is wrong after encoding declaration

STINNER Victor <[EMAIL PROTECTED]> added the comment: benjamin was afraid by the comment /* dirty hack */ in my previous comment. After reading tokenizer.c again and again, I can say that the fix is correct: the file is closed and then re-opened by fp_setreadl() (using io.open()), and so the f

[issue4008] IDLE: checksyntax() doesn't support Unicode?

Changes by STINNER Victor <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11677/idle_encoding-2.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3574] compile() cannot decode Latin-1 source encodings

Changes by STINNER Victor <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11715/python3_bytes_filename-3.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3574] compile() cannot decode Latin-1 source encodings

STINNER Victor <[EMAIL PROTECTED]> added the comment: My patch version 2 included an "unrelated" fix for the issue2384. Added file: http://bugs.python.org/file11715/python3_bytes_filename-3.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue2744] Fix test_cProfile

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment: Have you verified the numbers? They don't look right to me. The problem is the 2nd argument of cProfile's constructor has a different semantic meaning than the one for profile.py. For profile.py, it is used to set the "bias" (I presume

[issue2744] Fix test_cProfile

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: No, I didn't look too hard at it; I just got it scraping along, so I can forward port a fix for it. I'll reopen this, so you can take more action, so you wish. :) -- resolution: fixed -> status: closed -> open ___

[issue2744] Fix test_cProfile

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment: Unassigning myself as I don't have the time to fix this properly. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2744] Fix test_cProfile

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>: -- assignee: alexandre.vassalotti -> ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3623] _json: fix raise_errmsg(), py_encode_basestring_ascii() and linecol()

Changes by STINNER Victor <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11718/json_test.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4060] PyUnicode_DecodeUTF16(..., byteorder=0) gets it wrong on Mac OS X/PowerPC

New submission from Trent Mick <[EMAIL PROTECTED]>: Revision 63955 removed a block from configure.in (and effectively from pyconfig.h.in) having to do with endianness that results in an incorrect setting for "WORDS_BIGENDIAN" in Universal builds on Mac OS X. The removed part was this: > AH_VERB

[issue4060] PyUnicode_DecodeUTF16(..., byteorder=0) gets it wrong on Mac OS X/PowerPC

Trent Mick <[EMAIL PROTECTED]> added the comment: This also shows up in the byte ordering that Python uses to encode utf-16: $ uname -a Darwin sphinx 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc $ python2.6 -c "impor

[issue4060] PyUnicode_DecodeUTF16(..., byteorder=0) gets it wrong on Mac OS X/PowerPC

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment: Does this also affect sys.byteorder and the struct module ? I think those would be more important to get right than the UTF-16 codec, since this only uses the native byte ordering for increased performance and compatibility with other OS

[issue1565525] gc allowing tracebacks to eat up memory

STINNER Victor <[EMAIL PROTECTED]> added the comment: Similar issue: issue4034 proposes to be able to set tb.tb_frame=None. It's easy to implement this, I can write a patch for this. -- nosy: +haypo ___ Python tracker <[EMAIL PROTECTED]>

=?utf-8?q?[issue4060]_PyUnicode=5FDecodeUTF16(..., =09byteorder=3D0)_gets_it_wrong_on_Mac_OS_X/PowerPC?=

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment: BTW: Does this simplified approach really work for Python on Mac OS X: On 2008-10-07 00:27, Trent Mick wrote: >> The block below does compile-time checking for endianness on > platforms >> that use GCC and therefore allows c

[issue3758] "make check" suggest a testing target under GNU coding standards

Brett Cannon <[EMAIL PROTECTED]> added the comment: 2.7 through r66819, 2.6 through r66820, and 3.0 through r66821. -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

=?utf-8?q?[issue4060]_PyUnicode=5FDecodeUTF16(..., =09byteorder=3D0)_gets_it_wrong_on_Mac_OS_X/PowerPC?=

Trent Mick <[EMAIL PROTECTED]> added the comment: > Does this also affect sys.byteorder and the struct module ? Doesn't seem to affect sys.byteorder: $ /usr/bin/python -c "import sys; print sys.byteorder" big $ python2.6 -c "import sys; print sys.byteorder" big > I think those would be more i

[issue4034] traceback attribute error

STINNER Victor <[EMAIL PROTECTED]> added the comment: Instead of converting tb_frame attribute to read only, I prefer to allow the user to clear the traceback to free some memory bytes. So I wrote a different patch. marge$ ./python Python 2.7a0 (trunk:66786M, Oct 7 2008, 00:48:32) >>> try: ..

=?utf-8?q?[issue4060]_PyUnicode=5FDecodeUTF16(..., =09byteorder=3D0)_gets_it_wrong_on_Mac_OS_X/PowerPC?=

Trent Mick <[EMAIL PROTECTED]> added the comment: > BTW: Does this simplified approach really work for Python on Mac OS X It works for Python 2.5: http://svn.python.org/view/*checkout*/python/branches/release25-maint/configure.in?rev=66299 search for "BIGENDIAN". _

=?utf-8?q?[issue4060]_PyUnicode=5FDecodeUTF16(..., =09byteorder=3D0)_gets_it_wrong_on_Mac_OS_X/PowerPC?=

Changes by Trent Mick <[EMAIL PROTECTED]>: -- keywords: +patch Added file: http://bugs.python.org/file11720/issue4060_macosx_endian.patch ___ Python tracker <[EMAIL PROTECTED]> ___

=?utf-8?q?[issue4060]_PyUnicode=5FDecodeUTF16(..., _=09byteorder=3D0)_gets_it_wrong_on_Mac_OS_X/PowerPC?=

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment: On 2008-10-07 00:52, Trent Mick wrote: > Trent Mick <[EMAIL PROTECTED]> added the comment: > >> BTW: Does this simplified approach really work for Python on Mac OS X > > It works for Python 2.5: > > http://svn.python.org/view/*checkout*

[issue4061] summing two numbers-strange answer

New submission from Mehmet Yozcu <[EMAIL PROTECTED]>: I don't know what's wrong but when I write on the IDLE 2.3+6.3 it gives an answer like 8.596 or similar when I write on the IDLE print 2.3+6.3 the answer is 8.6 as I expected I tried these two commands on the DrPython IDE;the result w

[issue3187] os.listdir can return byte strings

STINNER Victor <[EMAIL PROTECTED]> added the comment: Would it possible to close this issue since os.listdir() is fixed and many other related functions (posix, posixpath, ntpath, macpath, etc.) are also fixed? I propose to open new issues for new bugs since this issue becomes a little big lon

[issue4061] summing two numbers-strange answer

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: This is a result of poor floating-point precision: >>> 2.3 2.2998 >>> 6.3 6.2998 See http://docs.python.org/tutorial/floatingpoint.html for more information. -- nosy: +benjamin.peterson resolution: -> inv

[issue4061] summing two numbers-strange answer

STINNER Victor <[EMAIL PROTECTED]> added the comment: Use Decimal to get an exact result: >>> from decimal import Decimal >>> print Decimal('2.3') + Decimal('6.3') 8.6 -- nosy: +haypo ___ Python tracker <[EMAIL PROTECTED]>

[issue3187] os.listdir can return byte strings

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > Would it possible to close this issue since os.listdir() is fixed and > many other related functions (posix, posixpath, ntpath, macpath, etc.) > are also fixed? IIUC, these fixes are still not complete: they lack documentation changes. O

[issue4062] Reference to non-existent __version__ in ast module

New submission from Orestis Markou <[EMAIL PROTECTED]>: The docs for the ast module refer to a __version__ number, that should track the Subversion id. However, this doesn't exist: >>>import ast >>>ast.__version__ Traceback (most recent call last): File "", line 1, in AttributeError: 'mod

[issue3187] os.listdir can return byte strings

STINNER Victor <[EMAIL PROTECTED]> added the comment: Le Tuesday 07 October 2008 01:13:22 Martin v. Löwis, vous avez écrit : > IIUC, these fixes are still not complete: they lack documentation > changes. (...) Of course, it would have been better if the original patches > already contained the n

[issue3574] compile() cannot decode Latin-1 source encodings

Brett Cannon <[EMAIL PROTECTED]> added the comment: So I tried the patch (I attached my version with different comments in the header file and removed some redundant change in whitespacing), and test_sys consistently fails for me: test_current_frames (__main__.SysModuleTest) AssertionError: ''

[issue3574] compile() cannot decode Latin-1 source encodings

Changes by Brett Cannon <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11722/alt_latin_1.diff ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue4061] summing two numbers-strange answer

Mehmet Yozcu <[EMAIL PROTECTED]> added the comment: Dear Victor Stinner; Thank you very much for your answer. That was very helpful Best Wishes 2008/10/7 STINNER Victor <[EMAIL PROTECTED]>: > > STINNER Victor <[EMAIL PROTECTED]> added the comment: > > Use Decimal to get an exact result: fro

[issue4061] summing two numbers-strange answer

Mehmet Yozcu <[EMAIL PROTECTED]> added the comment: Dear Benjamin Peterson; Thank you very much for your answer. That was very helpful Best Wishes 2008/10/7 Benjamin Peterson <[EMAIL PROTECTED]>: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > This is a result of poor floating-p

[issue4061] summing two numbers-strange answer

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: FWIW, what you're seeing is related to "representation error" not "poor precision". The numbers 2.3, 6.3, and 8.6 cannot be exactly represented in binary floating point. When you think about it, this is no more surprising than knowing the

[issue4061] summing two numbers-strange answer

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Mon, Oct 6, 2008 at 8:54 PM, Raymond Hettinger <[EMAIL PROTECTED]> wrote: > > Raymond Hettinger <[EMAIL PROTECTED]> added the comment: > > FWIW, what you're seeing is related to "representation error" not "poor > precision". The numbers

[issue4010] configure options don't trickle down to distutils

Skip Montanaro <[EMAIL PROTECTED]> added the comment: I checked in r66823 to add the -R flag extraction like Brett's -L extraction. I'll leave the issue open while folks discuss Roumen's proposal. I have no particular desire to delve deeper into distutils.

[issue3895] _lsprof issue

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Forward ported in r66827. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _

[issue3623] _json: fix raise_errmsg(), py_encode_basestring_ascii() and linecol()

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment: The patch looks good to me. You may want to fix the refleak in the PyList_Append() calls (I counted 4) too: if (PyList_Append(chunks, chunk)) { goto bail; } should be: if (PyList_A

[issue4029] Documentation displays incorrectly in iexplore.

David W. Lambert <[EMAIL PROTECTED]> added the comment: I installed google chrome. The manual display is absolutely beautiful. Thanks for your good work! Proofreader Dave. ___ Python tracker <[EMAIL PROTECTED]> ___

=?utf-8?q?[issue4060]_PyUnicode=5FDecodeUTF16(..., _=09byteorder=3D0)_gets_it_wrong_on_Mac_OS_X/PowerPC?=

Ronald Oussoren <[EMAIL PROTECTED]> added the comment: The issue was introduced while moving universal-binary specific trickery from pyconfig.h.in to a separate header file. Obviously I must have been drunk at the time, because I didn't move the WORDS_BIGENDIAN bits correctly. The attached pa