[issue991266] Cookie.py does not correctly quote Morsels

Berker Peksag added the comment: I've opened bpo-33535 to discuss Mark Williams' suggestion. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue991266] Cookie.py does not correctly quote Morsels

Berker Peksag added the comment: New changeset 9fc998d761591f2741d8e94f5b3009c56ae83882 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-991266: Fix quoting of Comment attribute of SimpleCookie (GH-6555) https://github.com/python/cpython/commit/9fc998d761591f2741d8e94f5b3009c56ae83

[issue991266] Cookie.py does not correctly quote Morsels

Berker Peksag added the comment: New changeset 8a6f4b4bba950fb8eead1b176c58202d773f2f70 by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-991266: Fix quoting of Comment attribute of SimpleCookie (GH-6555) https://github.com/python/cpython/commit/8a6f4b4bba950fb8eead1b176c58202d773f2

[issue991266] Cookie.py does not correctly quote Morsels

Change by miss-islington : -- pull_requests: +6268 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue991266] Cookie.py does not correctly quote Morsels

Change by miss-islington : -- pull_requests: +6267 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue991266] Cookie.py does not correctly quote Morsels

Berker Peksag added the comment: New changeset d5a2377c3d70e4143bcbee4a765b3434e21f683a by Berker Peksag in branch 'master': bpo-991266: Fix quoting of Comment attribute of SimpleCookie (GH-6555) https://github.com/python/cpython/commit/d5a2377c3d70e4143bcbee4a765b3434e21f683a -- __

[issue991266] Cookie.py does not correctly quote Morsels

Change by Berker Peksag : -- pull_requests: +6251 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue991266] Cookie.py does not correctly quote Morsels

Alex Gaynor added the comment: None of the above :-) I'd expect the last one, but with quoting. You should not be able to set fields in a cookie by injection. -- ___ Python tracker _

[issue991266] Cookie.py does not correctly quote Morsels

Berker Peksag added the comment: >>> from http.cookies import SimpleCookie >>> c = SimpleCookie() >>> c['name'] = 'value' >>> c['name']['comment'] = '\n' >>> c['name']['expires'] = '123; path=.example.invalid' 'Set-Cookie: name=value; Comment="\\012"; expires=123; path=.example.invalid' What do

[issue991266] Cookie.py does not correctly quote Morsels

Mark Williams added the comment: This patch only quotes the Comment attribute, and the rest of the code only quotes attributes if they're of the expected type. Consider Expires: >>> from http.cookies import SimpleCookie >>> c = SimpleCookie() >>> c['name'] = 'value' >>> c['name']['comment'] =

[issue991266] Cookie.py does not correctly quote Morsels

Alex Gaynor added the comment: Berker your patch looks good to me. Convert it to a PR and then merge? -- nosy: +alex ___ Python tracker ___ __

[issue991266] Cookie.py does not correctly quote Morsels

Berker Peksag added the comment: Here is a patch for Python 3. -- nosy: +berker.peksag versions: +Python 3.5, Python 3.6 -Python 3.1, Python 3.2 Added file: http://bugs.python.org/file42589/issue991266.diff ___ Python tracker

[issue991266] Cookie.py does not correctly quote Morsels

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue991266] Cookie.py does not correctly quote Morsels

Mark Lawrence added the comment: Can we have this committed please, msg82420 says the patches are ok. -- ___ Python tracker ___ ___

[issue991266] Cookie.py does not correctly quote Morsels

Changes by Mark Lawrence : -- versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list m

[issue991266] Cookie.py does not correctly quote Morsels

Mark Lawrence added the comment: Can someone please take a look at this Cookie.py two line patch. -- nosy: +BreamoreBoy ___ Python tracker ___ _

[issue991266] Cookie.py does not correctly quote Morsels

Daniel Diniz added the comment: Thanks, Zan! All tests pass with both patches applied. Test and fix look correct to me. -- nosy: +ajaksu2 stage: test needed -> patch review ___ Python tracker ___

[issue991266] Cookie.py does not correctly quote Morsels

Zan Dobersek added the comment: This patch properly quotes cookie's comment and successfully passes test_cookie.py with applied patch. Added file: http://bugs.python.org/file13130/991266fix.patch ___ Python tracker _

[issue991266] Cookie.py does not correctly quote Morsels

Zan Dobersek added the comment: This patch adds an unicode character, converted to UTF8 as a cookie's comment and then checks if it is correctly quoted. -- keywords: +patch nosy: +zdobersek Added file: http://bugs.python.org/file13085/991266test.patch __

[issue991266] Cookie.py does not correctly quote Morsels

Changes by John J Lee : -- nosy: -jjlee ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue991266] Cookie.py does not correctly quote Morsels

Changes by Daniel Diniz : -- nosy: +jjlee stage: -> test needed type: -> behavior versions: +Python 2.6 -Python 2.3 ___ Python tracker ___