[issue9895] Speed up test_subprocess

2010-09-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Done, thank you. (r84883, r84884, r84885) -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue9895] Speed up test_subprocess

2010-09-18 Thread Florent Xicluna
Florent Xicluna added the comment: +1 fo faster regrtest -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue9895] Speed up test_subprocess

2010-09-18 Thread Florent Xicluna
Changes by Florent Xicluna : Removed file: http://bugs.python.org/file18924/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue9895] Speed up test_subprocess

2010-09-18 Thread Florent Xicluna
Changes by Florent Xicluna : Removed file: http://bugs.python.org/file18923/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue9895] Speed up test_subprocess

2010-09-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: looks good to me. commit it. :) -- Added file: http://bugs.python.org/file18924/unnamed ___ Python tracker ___looks good to me.  commit it.

[issue9895] Speed up test_subprocess

2010-09-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: > A few questions / clarifications: > > is errno.EMFILE portable? will that errno test work on both posix and > windows? It does (tested under Linux and a Win64 VM). > should the is_resource_enabled('subprocess') stuff be preserved (why was it > there to b

[issue9895] Speed up test_subprocess

2010-09-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: Overall I like the approach. A few questions / clarifications: is errno.EMFILE portable? will that errno test work on both posix and windows? should the is_resource_enabled('subprocess') stuff be preserved (why was it there to begin with? because the old

[issue9895] Speed up test_subprocess

2010-09-18 Thread Antoine Pitrou
New submission from Antoine Pitrou : test_subprocess is currently very slow and the main culprit is test_no_leaking (here, it takes 80s out of the 100s needed for the whole run). This tests spawns as many subprocesses as would be needed to reach the max file descriptor limit. Spawning a subpro